Friday, 2015-01-23

*** vigneshvar has quit IRC00:00
*** sabari is now known as zz_sabari00:10
*** salv-orlando has quit IRC00:10
*** dims__ has joined #openstack-oslo00:11
*** ozialien has quit IRC00:11
*** salv-orlando has joined #openstack-oslo00:13
*** salv-orlando has quit IRC00:14
*** salv-orlando has joined #openstack-oslo00:14
*** dims__ has quit IRC00:16
*** ajo has quit IRC00:21
*** oomichi has joined #openstack-oslo00:22
openstackgerritJoshua Harlow proposed openstack/taskflow: Show the failure discarded (and the future intention)  https://review.openstack.org/14942500:25
*** sputnik13 has joined #openstack-oslo00:28
sputnik13is this the right place to ask questions about incubator libs?00:28
sputnik13trying to use the service lib, can't seem to get services to exit gracefully00:29
harlowjasputnik13 should be the right place, although not sure who is the resident expert on that lib00:29
sputnik13harlowja: that's what I was afraid of00:30
sputnik13http://paste.openstack.org/show/160524/00:30
harlowja:)00:30
sputnik13this is the code I'm trying to run, it seems like it should work...  but "shutdown complete" never hits00:30
harlowja:-/00:31
*** achanda has quit IRC00:31
harlowjadid u ensure that eventlet has monkeypatched the world00:32
harlowjai'm wondering if thats part of the reason00:32
sputnik13uh, what?00:32
harlowjaafaik service stuff is highly dependency on eventlet00:32
harlowjaplace the following at the top of that paste00:32
harlowjaimport eventlet00:32
harlowjaeventlet.monkey_patch(all=True)00:32
sputnik13yeah, it uses eventlet00:32
harlowjamake sure u do that monkey patch as early as possible00:33
sputnik13harlowja: that did it00:33
harlowjacool00:33
sputnik13harlowja: python hurts my head00:33
harlowja:)00:33
sputnik13@_@00:33
harlowjaif u mix code that uses eventlet stuff + threads (that aren't patched) it usually locks up00:34
harlowjaor eventlet stuff + thread (locks, threads, events....)00:34
*** achanda has joined #openstack-oslo00:34
harlowjaso have to pretty much accept eventlet into your heart, lol00:34
harlowja*or not use stuff that is using eventlet00:34
sputnik13harlowja: i c, I'll switch to using eventlet.event.Event00:35
harlowjawell u can do that or just make sure u monkey_patch00:35
*** zzzeek has joined #openstack-oslo00:35
harlowjamonkey_patch(all=True) will turn code that thinks its using threading.Event into something that really uses eventlet.event.Event00:36
lifelesseventlet must die00:36
harlowja*under the covers (which is why u need to do that as early in the program as possible)00:36
harlowjalol00:36
lifelessjust saying00:36
sputnik13well, I didn't bother to even search for an eventlet event...  I'm assuming it would work better than threading.Event when using eventlet00:36
harlowjasputnik13 probably; thought it should be to much diff00:36
sputnik13lifeless: why is that?  I'm still new to python, I have no basis for an opinion, just curious00:36
harlowja*though it shouldn't be to much of a diff (if eventlet folks monkey patched the right stuff...)00:37
*** zzzeek has quit IRC00:37
lifelesssputnik13: its very fragile00:37
harlowjahehe, enter the pits of hell u may00:37
harlowjalol00:37
harlowjasputnik13 it also is all-consuming00:38
lifelesssputnik13: its extremely hard to reason about (e.g. there's something like 30 different permutations in how it may be used with the monkey patching of some or none or all modules00:38
lifelesssputnik13: its not well integrated into DB access, which we do a lot of from the DB using APIs00:38
sputnik13harlowja: how funny, without monkey patch, using eventlet.event.Event in lieu of threading.Event still locks up00:38
harlowja*as u are seeing, if u don't monkey patch all the things at the right time in your program, then some random library u import might just lock all the things up (even though that library works fine normally...)00:38
harlowjasputnik13 ya, so then it gets into the question of what else service.py is using00:38
harlowjaif its using time.time; that can lock up still00:38
harlowjajust accept it into your heart :-P00:39
sputnik13yeah I'm going to monkeypatch00:39
sputnik13so then why is oslo.service written using eventlet I wonder...00:39
harlowjahistorical reason likely00:40
harlowjaif it was refactored to not, then it would probably work better in your situation that u are seeing right now00:40
harlowjai don't think there is anything that really requires eventlet in it, i just think thats how it has been...00:40
harlowjaand once u start with eventlet, u never go back, ha00:41
harlowja:-/00:41
sputnik13huh00:41
harlowja*later statement was a joke00:41
sputnik13:)00:41
harlowjaits fragile and u get addicted to it (in a way)00:41
* sputnik13 needs to read up on eventlet00:41
harlowjathings like https://github.com/openstack/oslo-incubator/blob/master/openstack/common/service.py#L452 and such could probably be refactored to use native threads (and then let eventlet monkey patch the threading module when eventlet is used)00:42
harlowjathere are a few other places that would need adjustment and refactoring to do similar things00:42
harlowjaso that way, it would work with native threads and then when someone wants eventlet they just have to do the same monkey_patch that u are doing and then rely on the fact that that service module is now really using greenthreads00:43
harlowjaanyways00:43
sputnik13harlowja: that's the module I'm using btw00:45
harlowjaya00:45
harlowjaits coupled to eventlet, so that means if u use it u have to be to :-/00:45
harlowja*the aforementioned addiction problem, lol00:46
sputnik13but if it requires eventlet and it's known that eventlet requires monkey patching, why don't they call monkey_patch in that module00:46
harlowjato late at that point00:46
sputnik13ah ok00:46
harlowjaand its the incubator stuff, so mostly that gets copied into other apps; so the creators of that don't really know the appropriate place to call that00:46
harlowjaalthough it should have a big warning on the top of the file or something00:47
harlowjaMAKE SURE EVENTLET PATCHEDDDDD00:47
harlowjalol00:47
sputnik13yeah, agreed with warning00:47
*** salv-orlando has quit IRC00:47
sputnik13would be nice if there was a flag being set by monkey_patch that the lib could check for and throw an exception or something if monkey_patch hasn't been run00:47
harlowjaagreed00:47
*** salv-orlando has joined #openstack-oslo00:47
sputnik13anyway, that should allow me to push ahead, thanks :)00:48
harlowjathat would probably be helpful, at the expense of a lot of checks in places00:48
sputnik13I'd rather have a few additional checks than have mysterious lockups00:48
sputnik13personally00:48
harlowjaaka in taskflow i have the following stuffs to avoid this00:49
harlowjahttps://github.com/openstack/taskflow/blob/master/taskflow/types/futures.py#L28300:49
harlowjaeu.check_for_eventlet and such...00:49
harlowjaagreed00:49
harlowja^ above will blowup if it can't be used00:49
harlowjaalthough it doesn't right now check that u have monkey patched certain modules, maybe should do that00:50
harlowjai think that api exists00:50
sputnik13yeah, that would be good00:50
sputnik13btw, I think you'd be glad to know we're "officially" going forward with taskflow on cue00:51
harlowjacools00:51
harlowjalet the fun begin, ha00:51
*** salv-orlando has quit IRC00:52
harlowjapoppy (another project) also decided that i think earlier today00:52
harlowjai think thats dns-service or something, can't remember these codenames00:52
harlowjacdn aas or something, lol00:52
harlowjato many projects :-P00:52
sputnik13hah, good problem to have :)00:55
sputnik13for a general purpose lib00:55
harlowjadef, hopefully it helps people (thats all my goal is)00:55
harlowjaif not, well, don't blame me, haha00:55
*** yamahata has joined #openstack-oslo00:56
sputnik13well, it's open source right, if it doesn't do what's needed, the user should contribute to make it do what's needed, isn't that the whole point?00:57
sputnik13:)00:57
harlowja:)00:57
harlowja+200:57
sputnik13time to head home, thanks for your help00:58
harlowjanp :)00:59
*** dims__ has joined #openstack-oslo00:59
harlowjai'll add u on a review for taskflow, to at least try to warn people about eventlet usage there00:59
harlowjaelsewhere imho something similar shoudl be done01:00
*** zz_sabari is now known as sabari01:04
*** noelbk has quit IRC01:06
*** sputnik13 has quit IRC01:07
*** sigmavirus24_awa is now known as sigmavirus2401:10
openstackgerritJoshua Harlow proposed openstack/taskflow: Warn when eventlet is being used and certain modules are not patched  https://review.openstack.org/14945201:29
*** tsekiyam_ has joined #openstack-oslo01:33
*** tsekiyama has quit IRC01:37
*** mtanino has quit IRC01:38
*** tsekiyam_ has quit IRC01:38
*** alexpilotti has joined #openstack-oslo01:39
harlowjaprobably should get that into oslo.utils or something after it bakes for a little...01:39
harlowjaseems useful01:39
openstackgerritJoshua Harlow proposed openstack/taskflow: Warn when eventlet is being used and certain modules are not patched  https://review.openstack.org/14945201:39
openstackgerritJoshua Harlow proposed openstack/taskflow: Warn when eventlet is being used and certain modules are not patched  https://review.openstack.org/14945201:48
openstackgerritJoshua Harlow proposed openstack/taskflow: Warn when eventlet is being used and certain modules are not patched  https://review.openstack.org/14945201:49
openstackgerritJoshua Harlow proposed openstack/taskflow: Fix leftover/remaining 'oslo.utils' usage  https://review.openstack.org/14945501:53
dims__hey harlowja: is MV nearby for you? (nova mid-cyle)01:53
harlowjadims__ ya, like 10 minutes driving01:53
harlowja*traffic dependent, ha01:53
dims__so i'll see you there then?01:53
harlowjaya01:53
dims__cool!01:53
harlowjai'll be there (until i get bored, which then i might run-away)01:53
harlowja:-P01:53
dims__i hear ya!01:54
harlowjadims__ if u get ambitous https://review.openstack.org/#/c/148721/ :)01:55
harlowjaand https://review.openstack.org/#/c/148759/01:55
harlowjamight as well get that library moving along01:55
dims__harlowja: ack. will do01:56
harlowjasweets01:56
harlowjathx01:56
harlowjabbl01:58
*** dhellman_ has quit IRC02:02
*** alexpilotti has quit IRC02:03
*** alexpilotti has joined #openstack-oslo02:05
*** alexpilotti has quit IRC02:06
*** alexpilotti has joined #openstack-oslo02:07
*** alexpilotti has quit IRC02:08
*** alexpilotti has joined #openstack-oslo02:11
openstackgerritAngus Lees proposed openstack/oslo.db: Test that concurrent sqlalchemy transactions don't block  https://review.openstack.org/10443602:13
*** sabari is now known as zz_sabari02:22
*** _amrith_ is now known as amrith02:33
*** alexpilotti has quit IRC02:38
*** stevemar has quit IRC02:39
*** stevemar2 has joined #openstack-oslo02:39
openstackgerritZhiQiang Fan proposed openstack/oslo-incubator: Use oslo_utils instead of deprecated oslo.utils  https://review.openstack.org/14742702:39
*** zz_sabari is now known as sabari02:46
*** yamahata has quit IRC02:50
*** stevemar2 is now known as stevemar02:50
*** rushiagr_away is now known as rushiagr02:56
*** harlowja is now known as harlowja_away02:59
*** ozialien has joined #openstack-oslo03:16
*** sabari is now known as zz_sabari03:28
*** rushiagr is now known as rushiagr_away03:30
*** dims__ has quit IRC03:34
*** zz_sabari is now known as sabari03:40
*** achanda has quit IRC03:40
*** zzzeek has joined #openstack-oslo03:45
*** amrith is now known as _amrith_03:45
*** zzzeek has quit IRC03:58
*** sabari is now known as zz_sabari04:00
*** achanda has joined #openstack-oslo04:00
openstackgerritxhzhf proposed openstack/oslo.vmware: oslo.vmware: getattr throw exception insteading returning none  https://review.openstack.org/14704404:04
*** yamahata has joined #openstack-oslo04:16
*** sigmavirus24 is now known as sigmavirus24_awa04:21
*** salv-orlando has joined #openstack-oslo04:23
*** achanda has quit IRC04:29
*** salv-orlando has quit IRC04:29
*** crc32 has joined #openstack-oslo04:31
*** achanda has joined #openstack-oslo04:32
*** zzzeek has joined #openstack-oslo04:33
openstackgerritOpenStack Proposal Bot proposed openstack/oslo-incubator: Updated from global requirements  https://review.openstack.org/14947404:37
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.concurrency: Updated from global requirements  https://review.openstack.org/14947504:37
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.db: Updated from global requirements  https://review.openstack.org/14947604:37
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.log: Updated from global requirements  https://review.openstack.org/14670304:37
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements  https://review.openstack.org/14947704:37
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.middleware: Updated from global requirements  https://review.openstack.org/14947804:37
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.serialization: Updated from global requirements  https://review.openstack.org/14947904:37
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.utils: Updated from global requirements  https://review.openstack.org/13524204:37
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.vmware: Updated from global requirements  https://review.openstack.org/14948004:37
openstackgerritOpenStack Proposal Bot proposed openstack/tooz: Updated from global requirements  https://review.openstack.org/14478604:39
*** zzzeek has quit IRC04:41
*** rushiagr_away is now known as rushiagr04:49
*** achanda has quit IRC04:51
*** zz_sabari is now known as sabari04:52
*** achanda has joined #openstack-oslo04:56
*** yamahata has quit IRC05:10
*** yamahata has joined #openstack-oslo05:17
*** salv-orlando has joined #openstack-oslo05:25
*** stevemar has quit IRC05:30
*** stevemar has joined #openstack-oslo05:31
*** salv-orlando has quit IRC05:31
*** crc32 has quit IRC05:45
openstackgerritAngus Lees proposed openstack/oslo.db: Test that concurrent sqlalchemy transactions don't block  https://review.openstack.org/10443605:50
*** fnordahl has quit IRC05:59
*** fnordahl has joined #openstack-oslo06:02
*** inc0 has joined #openstack-oslo06:03
*** fnordahl has quit IRC06:09
*** fnordahl has joined #openstack-oslo06:09
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.messaging: Imported Translations from Transifex  https://review.openstack.org/14325606:10
*** yalie has joined #openstack-oslo06:21
yaliehi all, a question about oslo_concurrency06:21
yalieoslo_concurrency regiester lock_path, could I use var in this opt?06:22
yalielike lock_path=$st_path/xxxx06:22
yaliecould I use it like this?06:22
*** liusheng has joined #openstack-oslo06:26
*** dims__ has joined #openstack-oslo06:35
*** dims__ has quit IRC06:39
openstackgerritMerged openstack/taskflow: Fix leftover/remaining 'oslo.utils' usage  https://review.openstack.org/14945506:56
openstackgerritMerged openstack/taskflow: Use a class provided logger before falling back to module  https://review.openstack.org/14910606:56
openstackgerritMerged openstack/taskflow: Use explicit WBE object arguments (instead of kwargs)  https://review.openstack.org/14841106:56
*** vigneshvar has joined #openstack-oslo07:02
*** sputnik13 has joined #openstack-oslo07:08
openstackgerritJoshua Harlow proposed openstack/taskflow: Tidy up the WBE cache (now WBE types) module  https://review.openstack.org/10324507:08
openstackgerritZhiQiang Fan proposed openstack/oslo-incubator: switch to oslo_i18n  https://review.openstack.org/14951907:09
*** sputnik13 has quit IRC07:19
*** sputnik13 has joined #openstack-oslo07:23
openstackgerritJoshua Harlow proposed openstack/taskflow: Add a WBE request state diagram + explanation  https://review.openstack.org/14905007:26
openstackgerritJoshua Harlow proposed openstack/taskflow: WBE documentation tweaks/adjustments  https://review.openstack.org/14908107:26
*** sabari is now known as zz_sabari07:28
*** zz_sabari is now known as sabari07:31
openstackgerritxhzhf proposed openstack/oslo.vmware: oslo.vmware: getattr throw exception insteading returning none  https://review.openstack.org/14704407:34
*** liusheng has quit IRC07:34
*** liusheng has joined #openstack-oslo07:35
*** sabari is now known as zz_sabari07:35
*** zz_sabari is now known as sabari07:36
*** sabari is now known as zz_sabari07:41
*** stevemar has quit IRC07:44
*** zz_sabari is now known as sabari07:46
*** stevemar has joined #openstack-oslo07:46
openstackgerritZhiQiang Fan proposed openstack/oslo-incubator: Use oslo_middleware instead of deprecated oslo.middleware  https://review.openstack.org/14743107:50
*** e0ne has joined #openstack-oslo07:53
*** e0ne is now known as e0ne_07:54
*** e0ne_ is now known as e0ne07:54
*** ozialien has quit IRC07:54
*** stevemar has quit IRC07:57
*** sabari is now known as zz_sabari07:59
*** sputnik13 has quit IRC08:00
*** zz_sabari is now known as sabari08:00
yaliehi dhellmann ?08:02
*** pblaho has joined #openstack-oslo08:03
*** salv-orlando has joined #openstack-oslo08:09
*** liusheng has quit IRC08:11
*** liusheng has joined #openstack-oslo08:13
*** e0ne has quit IRC08:15
*** salv-orlando has quit IRC08:16
openstackgerritMerged openstack/taskflow: Tidy up the WBE cache (now WBE types) module  https://review.openstack.org/10324508:26
*** ihrachyshka has joined #openstack-oslo08:33
*** dtantsur is now known as dtantsur|brb08:33
*** liusheng has quit IRC08:35
*** liusheng has joined #openstack-oslo08:35
*** achanda has quit IRC08:36
*** sabari is now known as zz_sabari08:40
openstackgerritJoshua Harlow proposed openstack/taskflow: Use explicit WBE worker object arguments (instead of kwargs)  https://review.openstack.org/14953608:43
*** zz_sabari is now known as sabari08:45
*** sabari is now known as zz_sabari08:49
*** i159 has joined #openstack-oslo08:50
*** liusheng has quit IRC08:50
*** liusheng has joined #openstack-oslo08:51
openstackgerritMerged openstack/taskflow: Add a WBE request state diagram + explanation  https://review.openstack.org/14905008:59
ozamiatinsileht, ok I have no objections09:01
*** yamahata has quit IRC09:02
*** liusheng has quit IRC09:06
*** liusheng has joined #openstack-oslo09:06
*** yalie has quit IRC09:08
*** salv-orl_ has joined #openstack-oslo09:14
*** salv-orl_ has quit IRC09:14
*** salv-orlando has joined #openstack-oslo09:15
*** isviridov_away is now known as isviridov09:16
openstackgerritMerged openstack/taskflow: WBE documentation tweaks/adjustments  https://review.openstack.org/14908109:20
*** lifeless has quit IRC09:21
*** lifeless has joined #openstack-oslo09:22
*** liusheng has quit IRC09:22
*** liusheng has joined #openstack-oslo09:23
*** dulek has joined #openstack-oslo09:31
*** liusheng has quit IRC09:41
*** liusheng has joined #openstack-oslo09:41
*** sputnik13 has joined #openstack-oslo09:46
*** sreshetnyak has joined #openstack-oslo09:49
*** sputnik13 has quit IRC09:51
*** sputnik13 has joined #openstack-oslo09:54
openstackgerritJames Page proposed openstack/oslo.messaging: zmq: support Cinder multi-backend server targets  https://review.openstack.org/12918509:54
*** andreykurilin_ has joined #openstack-oslo09:55
*** viktors|afk has quit IRC09:56
*** sputnik13 has quit IRC09:56
*** i159 has quit IRC09:56
*** andreykurilin has quit IRC09:56
*** ozamiatin has quit IRC09:56
*** ozamiatin has joined #openstack-oslo09:56
*** i159 has joined #openstack-oslo09:59
*** e0ne has joined #openstack-oslo09:59
*** andreykurilin has joined #openstack-oslo10:00
*** viktors has joined #openstack-oslo10:01
openstackgerritJulien Danjou proposed openstack/oslo-incubator: Remove context  https://review.openstack.org/14854510:03
*** e0ne is now known as e0ne_10:04
openstackgerritJulien Danjou proposed openstack/oslo-incubator: Replace mox by mox3  https://review.openstack.org/14824310:06
openstackgerritMerged openstack/oslo-incubator: Updated from global requirements  https://review.openstack.org/14947410:06
*** e0ne_ is now known as e0ne10:08
*** sputnik13 has joined #openstack-oslo10:09
*** jaosorior has joined #openstack-oslo10:14
*** yalie has joined #openstack-oslo10:14
yalieHi jd__ ?10:16
jd__hi yalie10:16
yaliecould you help to review this patch https://review.openstack.org/#/c/148789/10:17
yalieit's a tempest-lib dependency issue10:17
openstackgerritJulien Danjou proposed openstack/oslo-incubator: Replace mox by mox3  https://review.openstack.org/14824310:18
openstackgerritJulien Danjou proposed openstack/oslo-incubator: Remove useless dependencies  https://review.openstack.org/14824210:18
jd__yalie: sure, done10:18
yaliethank you! jd__10:18
*** takedakn has joined #openstack-oslo10:19
*** salv-orlando has quit IRC10:25
*** dulek has quit IRC10:31
*** yalie has quit IRC10:32
*** takedakn has quit IRC10:32
openstackgerritMerged openstack/oslo.concurrency: Updated from global requirements  https://review.openstack.org/14947510:37
*** amotoki has joined #openstack-oslo10:40
openstackgerritMerged openstack/oslo.serialization: Updated from global requirements  https://review.openstack.org/14947910:46
openstackgerritMerged openstack/oslo.middleware: Updated from global requirements  https://review.openstack.org/14947810:52
*** dims__ has joined #openstack-oslo10:58
*** inc0_ has joined #openstack-oslo11:00
*** dims__ has quit IRC11:02
*** inc0 has quit IRC11:02
*** inc0_ has quit IRC11:03
*** inc0 has joined #openstack-oslo11:03
*** dims__ has joined #openstack-oslo11:11
*** inc0 has quit IRC11:11
*** inc0 has joined #openstack-oslo11:11
*** liusheng has quit IRC11:12
*** liusheng has joined #openstack-oslo11:12
*** andreykurilin_ has quit IRC11:14
openstackgerritIvan Melnikov proposed openstack/taskflow: Fix coverage environment  https://review.openstack.org/14957211:16
*** liusheng has quit IRC11:19
*** liusheng has joined #openstack-oslo11:19
*** ajo has joined #openstack-oslo11:33
*** dtantsur|brb is now known as dtantsur11:38
*** e0ne is now known as e0ne_11:47
*** e0ne_ is now known as e0ne11:49
dtantsurhey folks! :) anyone up for reviewing 2 mostly-refactoring patches for periodic_task? https://review.openstack.org/#/c/147567/ and https://review.openstack.org/#/c/148854/11:50
dtantsur(already got 1x +2)11:50
*** inc0_ has joined #openstack-oslo12:03
*** inc0_ has quit IRC12:06
*** inc0 has quit IRC12:07
*** alexpilotti has joined #openstack-oslo12:12
*** e0ne is now known as e0ne_12:34
*** e0ne_ is now known as e0ne12:35
*** liusheng has quit IRC12:40
*** liusheng has joined #openstack-oslo12:41
*** _amrith_ is now known as amrith12:44
*** amotoki has quit IRC12:45
*** amotoki has joined #openstack-oslo12:57
*** denis_makogon has joined #openstack-oslo13:02
*** vigneshvar has quit IRC13:08
*** dulek has joined #openstack-oslo13:10
*** rushiagr is now known as rushiagr_away13:10
*** dims__ has quit IRC13:11
*** dims__ has joined #openstack-oslo13:11
*** dulek has quit IRC13:15
*** bknudson has joined #openstack-oslo13:16
*** e0ne is now known as e0ne_13:22
*** sputnik13 has quit IRC13:28
*** e0ne_ has quit IRC13:28
*** e0ne has joined #openstack-oslo13:33
*** e0ne is now known as e0ne_13:38
*** liusheng has quit IRC13:40
*** liusheng has joined #openstack-oslo13:41
*** e0ne_ has quit IRC13:43
*** gordc has joined #openstack-oslo13:46
*** rushiagr_away is now known as rushiagr13:46
*** sputnik13 has joined #openstack-oslo13:54
*** kgiusti has joined #openstack-oslo14:02
*** e0ne has joined #openstack-oslo14:03
*** sputnik13 has quit IRC14:04
*** amrith is now known as _amrith_14:07
*** mtreinish has quit IRC14:08
zhiyanhi dims__ jd__ , around?14:09
dims__zhiyan: pong14:09
zhiyandims__: hi dims, how are you?14:10
jd__yes but I don't like empty ping :)14:10
zhiyanhey jd!14:11
zhiyanjd__: dims__ not sure if you ok could help review https://review.openstack.org/#/c/145717/ ? )14:11
zhiyanit's a straightforward change14:11
jd__zhiyan: done14:13
zhiyanjd__: thanks. the change will make https://review.openstack.org/#/c/145715/ easier.14:14
zhiyanify14:14
dims__zhiyan: i've left a note :)14:15
zhiyandims__: ah, anyway..#148547 works for my purpose as well :)14:16
dims__:) thanks for the flexibility14:16
zhiyandims__: ;)14:16
zhiyandims__: just a little sad, i prepared it at 8th )14:18
dims__apologies :)14:18
zhiyandims__: np (next time will ping you help here earlier =))14:19
dims__zhiyan: yep, sounds good.14:19
*** salv-orlando has joined #openstack-oslo14:25
openstackgerritMerged openstack/oslo-incubator: Remove uuidutils  https://review.openstack.org/14854714:25
*** amotoki has quit IRC14:28
*** jecarey has joined #openstack-oslo14:32
*** amotoki has joined #openstack-oslo14:32
*** ajo has quit IRC14:38
*** denis_makogon has quit IRC14:41
*** ajo has joined #openstack-oslo14:46
*** amotoki has quit IRC14:48
*** denis_makogon has joined #openstack-oslo14:53
*** _amrith_ is now known as amrith14:55
*** sheeprine has quit IRC14:57
*** sheeprine has joined #openstack-oslo15:00
*** dulek has joined #openstack-oslo15:02
*** pblaho has quit IRC15:05
*** pblaho_ has joined #openstack-oslo15:05
*** dulek has quit IRC15:09
*** viktors is now known as viktors|afk15:10
*** sigmavirus24_awa is now known as sigmavirus2415:12
*** mtanino has joined #openstack-oslo15:16
*** sputnik13 has joined #openstack-oslo15:24
*** pblaho__ has joined #openstack-oslo15:34
*** pblaho__ is now known as pblaho15:35
*** achanda has joined #openstack-oslo15:35
*** pblaho has quit IRC15:35
*** pblaho has joined #openstack-oslo15:36
*** pblaho_ has quit IRC15:37
*** liusheng has quit IRC15:41
*** liusheng has joined #openstack-oslo15:41
*** achanda has quit IRC15:43
*** sheeprine has quit IRC15:45
*** sheeprine has joined #openstack-oslo15:48
openstackgerritMerged openstack/oslo-incubator: Remove useless dependencies  https://review.openstack.org/14824215:49
bnemecjd__: So why did we ever bother adding mox to six.moves?15:53
bnemecIf mox3 works on both versions, it would have made more sense to just switch to it.15:53
jd__bnemec: I have no idea15:53
jd__and mox3 and mox are only 99% compatible anyway15:53
jd__there's some corner cases that me and dims__ hit that does not work so you have to port the code15:54
bnemecAh, maybe that's why.15:54
jd__we were probably too optimistic I'd say :)15:54
bnemecLooks like you fixed everything though, so I guess it's fine.15:54
bnemecJust wanted to understand what we were changing there.15:54
jd__sure, no problem15:55
*** zzzeek has joined #openstack-oslo15:56
openstackgerritMerged openstack/oslo-incubator: Replace mox by mox3  https://review.openstack.org/14824315:59
*** yamahata has joined #openstack-oslo16:02
*** achanda has joined #openstack-oslo16:02
*** achanda has quit IRC16:06
*** booly-yam-9623 has joined #openstack-oslo16:08
*** dulek has joined #openstack-oslo16:19
*** tsekiyama has joined #openstack-oslo16:27
*** dulek has quit IRC16:30
*** david-lyle_afk is now known as david-lyle16:35
openstackgerritMerged openstack/oslo.utils: Updated from global requirements  https://review.openstack.org/13524216:50
*** kgiusti has quit IRC17:02
*** e0ne is now known as e0ne_17:03
*** i159 has quit IRC17:04
*** e0ne_ is now known as e0ne17:04
*** dims__ has quit IRC17:04
*** e0ne has quit IRC17:05
ihrachyshkadhellmann, https://review.openstack.org/149400 please17:08
*** liusheng has quit IRC17:08
*** liusheng has joined #openstack-oslo17:09
*** dims__ has joined #openstack-oslo17:14
*** dims__ is now known as dimsum__17:16
bnemecihrachyshka: Just FYI, he's travelling today so he will probably have spotty/no availability.17:17
tteggelhey oslo - who looks after your stable/juno branch? Looking for +2/+A on https://review.openstack.org/#/c/149008/ thanks!17:18
*** bnemec is now known as beekneemech17:21
ihrachyshkabeekneemech, tnx17:21
ihrachyshkazzzeek, hey, around?17:21
zzzeekihrachyshka: hi17:21
ihrachyshkazzzeek, I have a dumb question (for sure) on sqla17:21
ihrachyshkazzzeek, in update(), there is synchronize_session argument. if it's False, docs say: "Before the expiration, updated objects may still remain in the session with stale values on their attributes, which can lead to confusing results."17:22
ihrachyshkawhat does it mean?17:22
dhellmannihrachyshka: done17:22
ihrachyshkais it safe to fetch from the result of the query and use value as in: https://review.openstack.org/#/c/122265/5/neutron/db/l3_db.py ?17:22
zzzeekwow folks sure get messed up on that argument :)17:22
zzzeekwe didnt have query.update() for the longest time b.c. of this issue17:23
zzzeekihrachyshka: say you do this:   my_obj = session.query(MyClass).filter_by(id=5).one()17:23
zzzeekihrachyshka: then you do this:   session.query(MyClass).update({"17:23
zzzeekoops17:23
zzzeekyou do this:  session.query(MyClass).update({“name”: “newname”}, synchronize_session=False)17:24
zzzeekwhat is my_obj.name set to ?17:24
ihrachyshkazzzeek, you mean, in that case it may be different, right?17:25
zzzeekihrachyshka: yes17:25
zzzeekihrachyshka: because its just in memory17:25
zzzeeknothing touched it17:25
ihrachyshkazzzeek, and if we want it to refetch on demand, we need to change that sync_session arg?17:25
ihrachyshkazzzeek, ok, does it apply in the case I posted?17:26
ihrachyshkaor is .first() ok?17:26
zzzeekihrachyshka: looking17:26
zzzeekihrachyshka: yeah so there, this will probably be OK.  But in the abstract, it’s not entirely “safe”.  if this “fip” row were already loaded in terms of this Session, it would not have the new value.   There’s a way to guard here though I will add that in.17:27
zzzeekthough theres somethign else not ideal here either17:27
ihrachyshkazzzeek, go comment then! you're the SQL master here ;)17:28
ihrachyshkazzzeek, I'm less than ignorant here17:29
*** bknudson has quit IRC17:29
*** salv-orlando has quit IRC17:30
*** zzzeek_ has joined #openstack-oslo17:31
*** dulek has joined #openstack-oslo17:32
*** zzzeek has quit IRC17:32
*** zzzeek_ is now known as zzzeek17:32
*** liusheng has quit IRC17:33
*** liusheng has joined #openstack-oslo17:34
*** zzzeek_ has joined #openstack-oslo17:35
*** zzzeek has quit IRC17:37
*** zzzeek_ is now known as zzzeek17:37
ihrachyshkazzzeek, so, just to make it clear, will you update there with your comment?17:39
zzzeekim editing17:39
zzzeekinternet has been up and down the last few minutes17:39
*** denis_makogon has quit IRC17:40
ihrachyshkazzzeek, yeah, I saw that, that's why I'm asking in case you missed the latest comments. Thanks a lot, we really appreciate your comments on db side of things.17:43
zzzeekihrachyshka: im not sure why everyone’s using query.update() all over the place.   if ppl just read the ORM tutorial before doing openstack patches, maybe things would be better :)17:44
*** amrith is now known as _amrith_17:44
*** jaosorior has quit IRC17:44
ihrachyshkazzzeek, hm. what's that tutorial?17:45
zzzeekits the link with the boldface “Read this first” right here: http://docs.sqlalchemy.org/en/rel_0_9/ :)17:45
zzzeekhttp://docs.sqlalchemy.org/en/rel_0_9/orm/tutorial.html17:45
*** booly-yam-9623 has quit IRC17:46
ihrachyshkazzzeek, thanks, I will try to swallow that17:47
zzzeekihrachyshka: i am sure you can do it17:47
*** booly-yam-9623_ has joined #openstack-oslo17:47
zzzeekihrachyshka: openstack hardly uses relationship() at all so really just the first third of it is 90% of what we need17:48
*** liusheng has quit IRC17:48
*** liusheng has joined #openstack-oslo17:49
*** pblaho has quit IRC17:50
*** yamahata has quit IRC17:52
*** e0ne has joined #openstack-oslo18:01
*** dulek has quit IRC18:05
*** dulek has joined #openstack-oslo18:06
*** mtreinish has joined #openstack-oslo18:08
*** dtantsur is now known as dtantsur|afk18:09
*** kgiusti has joined #openstack-oslo18:11
*** dulek has quit IRC18:12
*** harlowja_away is now known as harlowja18:14
*** rushiagr is now known as rushiagr_away18:19
*** salv-orlando has joined #openstack-oslo18:19
*** zz_sabari is now known as sabari18:20
dimsum__dhellmann: i stopped responding on that thread, qiming had some bone to pick (don't know what/why!)18:28
dhellmanndimsum__: yeah, I re-read it and noticed the issue had nothing to do with what qiming was asserting18:28
*** _amrith_ is now known as amrith18:31
dimsum__zzzeek: pretty excited about oslo.context eh? :)18:33
zzzeekyup18:33
harlowjalol18:33
dimsum__dhellmann saw it coming :) i was going to shove it into utils or something18:33
harlowjaCALM DOWN zzzeek !!!18:33
harlowjalol18:33
beekneemechOlso - solving problems before you knew you had them. :-D18:34
dimsum__beekneemech: hear hear!18:35
harlowjadimsum__ dhellmann beekneemech  what do u think about having https://review.openstack.org/#/c/149452/ in oslo.utils; and applying it where useful?18:35
harlowjabasically emitting a warning when eventlet is partially patched (or missing patches for certain modules) which would likely cause issues later on for libraries that aren't meant to work in partially patched mode (say patching only os and not threading...)18:36
beekneemechharlowja: I could see that being useful for concurrency too.18:37
harlowjaya, there to18:37
beekneemechAlthough we'd have to figure out which combination of modules needs to be patched.18:37
harlowjaya, pretty sure its mostly [os, thread, time] for everyone, ha18:37
beekneemechBut yeah, off hand utils seems like a reasonable place for it.18:37
harlowjak18:38
harlowjalet me just move it there ahead of time18:38
dimsum__harlowja: nova has had variations of it before, but yes, +1 to add somewhere and it looks like it won't drag in eventlet in requirements either, so +118:38
harlowjacools18:38
harlowjawill move that over in a few18:39
*** achanda has joined #openstack-oslo18:40
*** achanda has quit IRC18:41
*** viktors|afk has quit IRC18:43
*** ozamiatin has quit IRC18:43
*** andreykurilin has quit IRC18:43
*** david-lyle has quit IRC18:46
*** achanda has joined #openstack-oslo18:46
openstackgerritOpenStack Proposal Bot proposed openstack/oslo-incubator: Updated from global requirements  https://review.openstack.org/14971518:49
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.vmware: Updated from global requirements  https://review.openstack.org/14948018:49
*** liusheng has quit IRC18:55
*** vigneshvar has joined #openstack-oslo18:55
*** liusheng has joined #openstack-oslo18:55
*** ihrachyshka has quit IRC19:03
*** alexpilotti has quit IRC19:12
openstackgerritMichael Bayer proposed openstack/oslo.db: Implement new oslo.db.sqlalchemy.enginefacade module  https://review.openstack.org/13821519:16
*** ozamiatin has joined #openstack-oslo19:19
*** viktors has joined #openstack-oslo19:30
*** andreykurilin has joined #openstack-oslo19:32
openstackgerritMichael Bayer proposed openstack/oslo.db: Implement new oslo.db.sqlalchemy.enginefacade module  https://review.openstack.org/13821519:33
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Add a eventlet utils helper module  https://review.openstack.org/14973019:33
harlowjadimsum__ ^19:33
harlowjabeekneemech ^19:33
beekneemechharlowja: Nice, thanks.  Will take a look.19:33
harlowjanp19:34
*** booly-yam-9623_ has quit IRC19:36
*** lifeless has quit IRC19:37
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Add a eventlet utils helper module  https://review.openstack.org/14973019:37
*** lifeless has joined #openstack-oslo19:37
*** sabari is now known as zz_sabari19:50
*** salv-orlando has quit IRC20:04
*** salv-orlando has joined #openstack-oslo20:04
*** yamahata has joined #openstack-oslo20:07
*** salv-orlando has quit IRC20:09
*** liusheng has quit IRC20:24
*** liusheng has joined #openstack-oslo20:25
*** salv-orlando has joined #openstack-oslo20:29
openstackgerritMerged openstack/taskflow: add clarification re parallel engine  https://review.openstack.org/14323120:44
*** achanda has quit IRC20:47
openstackgerritMerged openstack/taskflow: Switch to using 'oslo_serialization' vs 'oslo.serialization'  https://review.openstack.org/14629820:49
*** achanda has joined #openstack-oslo20:58
openstackgerritMerged openstack/oslo.middleware: Update Oslo imports to remove namespace package  https://review.openstack.org/14909921:07
openstackgerritMerged openstack/oslo.middleware: Move i18n module to a private name  https://review.openstack.org/14910321:07
openstackgerritJoshua Harlow proposed openstack/taskflow: Rework the sqlalchemy backend  https://review.openstack.org/12611021:09
openstackgerritJoshua Harlow proposed openstack/taskflow: Use the new table length constants  https://review.openstack.org/12616621:09
*** vigneshvar has quit IRC21:24
*** stevemar has joined #openstack-oslo21:35
*** liusheng has quit IRC21:47
*** liusheng has joined #openstack-oslo21:49
*** noelbk has joined #openstack-oslo21:51
*** trown is now known as trown|outttypeww21:53
*** ajo has quit IRC21:56
*** andreykurilin_ has joined #openstack-oslo21:57
*** liusheng has quit IRC22:08
*** liusheng has joined #openstack-oslo22:09
*** isq has quit IRC22:16
*** isq has joined #openstack-oslo22:16
*** ajo has joined #openstack-oslo22:19
openstackgerritJoshua Harlow proposed openstack/taskflow: Allow just specifying 'workers' for WBE entrypoint  https://review.openstack.org/14977022:22
openstackgerritEric Brown proposed openstack/oslo.vmware: Correct the doc usage example  https://review.openstack.org/14977522:35
openstackgerritMerged openstack/taskflow: Show the failure discarded (and the future intention)  https://review.openstack.org/14942522:35
*** salv-orlando has quit IRC22:38
openstackgerritJoshua Harlow proposed openstack/taskflow: Allow just specifying 'workers' for WBE entrypoint  https://review.openstack.org/14977022:39
*** salv-orlando has joined #openstack-oslo22:46
*** e0ne is now known as e0ne_22:47
openstackgerritJoshua Harlow proposed openstack/taskflow: Add comments to runner state machine reaction functions  https://review.openstack.org/14978022:48
openstackgerritRyan Hsu proposed openstack/oslo.vmware: Fix missing project name in installation doc  https://review.openstack.org/14978122:53
*** salv-orlando has quit IRC22:59
*** salv-orlando has joined #openstack-oslo22:59
openstackgerritJoshua Harlow proposed openstack/taskflow: Allow just specifying 'workers' for WBE entrypoint  https://review.openstack.org/14977023:00
openstackgerritJoshua Harlow proposed openstack/taskflow: Leave use-cases out of developer documentation  https://review.openstack.org/14978523:04
openstackgerritJoshua Harlow proposed openstack/taskflow: Leave use-cases out of WBE developer documentation  https://review.openstack.org/14978523:04
openstackgerritEric Brown proposed openstack/oslo.vmware: Correct the doc usage example  https://review.openstack.org/14977523:05
*** david-ly_ has joined #openstack-oslo23:07
*** ajo has quit IRC23:09
*** david-ly_ is now known as david-lyle23:11
*** raildo has joined #openstack-oslo23:11
*** liusheng has quit IRC23:22
*** liusheng has joined #openstack-oslo23:23
*** raildo has quit IRC23:27
*** e0ne_ has quit IRC23:28
*** dimsum__ has quit IRC23:34
*** andreykurilin_ has quit IRC23:40
*** sigmavirus24 is now known as sigmavirus24_awa23:58
openstackgerritJoshua Harlow proposed openstack/taskflow: Use monotonic time when/if available  https://review.openstack.org/14421223:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!