| *** _Patang has quit IRC | 00:03 | |
| *** Patang has joined #openstack-oslo | 00:03 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 00:07 | |
| *** Patang has quit IRC | 00:09 | |
| *** alexpilotti has quit IRC | 00:10 | |
| *** marun has quit IRC | 00:11 | |
| *** andreykurilin_ has quit IRC | 00:16 | |
| *** dims has quit IRC | 00:22 | |
| *** dims has joined #openstack-oslo | 00:23 | |
| *** oomichi has joined #openstack-oslo | 00:26 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Bump up the env_builder.sh to 2.7.9 https://review.openstack.org/152750 | 00:51 |
|---|---|---|
| *** david-lyle is now known as david-lyle_afk | 00:57 | |
| *** zzzeek has quit IRC | 01:00 | |
| *** tsekiyam_ has joined #openstack-oslo | 01:16 | |
| *** mtanino has quit IRC | 01:19 | |
| *** achanda_ has joined #openstack-oslo | 01:19 | |
| *** tsekiyama has quit IRC | 01:20 | |
| *** tsekiyam_ has quit IRC | 01:21 | |
| *** achanda has quit IRC | 01:22 | |
| *** achanda_ has quit IRC | 01:24 | |
| openstackgerrit | zhangjl proposed openstack/oslo.messaging: Fix the bug redis do not delete the expired keys https://review.openstack.org/152471 | 01:28 |
| *** dims has quit IRC | 01:33 | |
| *** amrith is now known as _amrith_ | 01:34 | |
| *** mriedem has quit IRC | 01:38 | |
| *** dims has joined #openstack-oslo | 01:38 | |
| *** Patang has joined #openstack-oslo | 01:40 | |
| *** dims has quit IRC | 01:42 | |
| *** dims has joined #openstack-oslo | 01:42 | |
| *** sputnik13 has quit IRC | 01:52 | |
| openstackgerrit | Merged openstack/oslo-incubator: Refactor graduate.sh https://review.openstack.org/151027 | 01:56 |
| openstackgerrit | Merged openstack/oslotest: Move the script for running pre-releases into oslotest https://review.openstack.org/151753 | 02:02 |
| *** noelbk has quit IRC | 02:02 | |
| openstackgerrit | Merged openstack/oslo-incubator: Fix spelling of noteables -> notables https://review.openstack.org/147974 | 02:02 |
| openstackgerrit | Merged openstack/oslo-incubator: Report: Add basic processes section https://review.openstack.org/78793 | 02:04 |
| jogo | dhellmann: http://docs-draft.openstack.org/80/136380/7/check/gate-nova-docs/28be8b3//doc/build/html/support-matrix.html | 02:05 |
| jogo | dhellmann: can we make the oslo docs format support variable width? | 02:06 |
| jogo | even if I full screen that page the text almost 50% of the page is blank | 02:07 |
| *** sputnik13 has joined #openstack-oslo | 02:14 | |
| openstackgerrit | Li Ma proposed openstack/oslo.messaging: Increase rpc_response_timeout https://review.openstack.org/151979 | 02:21 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 02:26 | |
| *** tsekiyama has joined #openstack-oslo | 02:27 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 02:27 | |
| *** salv-orlando has quit IRC | 02:29 | |
| *** tsekiyama has quit IRC | 02:31 | |
| *** dims has quit IRC | 02:35 | |
| *** noelbk has joined #openstack-oslo | 02:35 | |
| *** dims has joined #openstack-oslo | 02:36 | |
| openstackgerrit | Merged openstack/oslo.messaging: Implements notification-dispatcher-filter https://review.openstack.org/77886 | 02:40 |
| openstackgerrit | Merged openstack/oslo.messaging: Add the threading executor setup.cfg entrypoint https://review.openstack.org/152378 | 02:40 |
| *** noelbk has quit IRC | 02:40 | |
| openstackgerrit | Merged openstack/oslo.messaging: Move each drivers options into its own group https://review.openstack.org/120038 | 02:42 |
| *** rushiagr_away is now known as rushiagr | 02:48 | |
| *** dims has quit IRC | 02:51 | |
| openstackgerrit | Balaji Narayanan proposed openstack/taskflow: Improved diagram for Taskflow https://review.openstack.org/152354 | 03:17 |
| *** rushiagr is now known as rushiagr_away | 03:19 | |
| *** stevemar has quit IRC | 03:23 | |
| *** stevemar has joined #openstack-oslo | 03:24 | |
| *** harlowja is now known as harlowja_away | 03:28 | |
| *** rushiagr_away is now known as rushiagr | 03:45 | |
| *** noelbk has joined #openstack-oslo | 03:47 | |
| *** noelbk has quit IRC | 03:54 | |
| stevemar | anyone familiar with oslo_log around? | 04:16 |
| stevemar | err... oslo.log | 04:16 |
| stevemar | trying to migrate from the oslo-incubator log handler to oslo.log for keystone, but running into some problems with loggers.WritableLogger | 04:17 |
| *** achanda has joined #openstack-oslo | 04:20 | |
| *** achanda has quit IRC | 04:22 | |
| *** achanda has joined #openstack-oslo | 04:22 | |
| *** noelbk has joined #openstack-oslo | 04:27 | |
| openstackgerrit | Balaji Narayanan proposed openstack/taskflow: Improved diagram for Taskflow https://review.openstack.org/152354 | 04:53 |
| *** oomichi has quit IRC | 05:04 | |
| *** noelbk has quit IRC | 05:08 | |
| *** david-lyle_afk has quit IRC | 05:11 | |
| *** achanda has quit IRC | 05:11 | |
| *** david-lyle_afk has joined #openstack-oslo | 05:11 | |
| *** ajo has joined #openstack-oslo | 05:12 | |
| *** harlowja_away has quit IRC | 05:19 | |
| *** achanda has joined #openstack-oslo | 05:27 | |
| *** mtreinish has quit IRC | 05:40 | |
| *** ankit_ag has joined #openstack-oslo | 05:49 | |
| *** dims has joined #openstack-oslo | 05:52 | |
| ankit_ag | Hi all | 05:53 |
| ankit_ag | request_utils module has been removed from oslo-incubator project which we need to sync in Nova to log cross project request-id mappings. For now I'm planning to put that code in Nova project itself, could someone please suggest a better way to proceed on this. | 05:54 |
| *** mtreinish has joined #openstack-oslo | 05:56 | |
| *** dims has quit IRC | 05:57 | |
| *** achanda has quit IRC | 06:00 | |
| *** achanda has joined #openstack-oslo | 06:05 | |
| *** achanda has quit IRC | 06:13 | |
| *** inc0 has joined #openstack-oslo | 06:16 | |
| *** enykeev has joined #openstack-oslo | 06:17 | |
| *** vigneshvar has joined #openstack-oslo | 06:22 | |
| *** achanda has joined #openstack-oslo | 06:35 | |
| openstackgerrit | Merged openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/152721 | 06:41 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Remove openstack.common.local https://review.openstack.org/152805 | 06:49 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Use oslo_i18n https://review.openstack.org/152806 | 06:55 |
| *** pblaho has joined #openstack-oslo | 06:58 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Use oslo namespaces for oslo libraries https://review.openstack.org/152808 | 06:59 |
| *** stevemar has quit IRC | 07:06 | |
| *** harlowja_at_home has joined #openstack-oslo | 07:10 | |
| *** sputnik13 has quit IRC | 07:12 | |
| *** sputnik13 has joined #openstack-oslo | 07:16 | |
| *** ajo has quit IRC | 07:22 | |
| *** dtantsur|afk is now known as dtantsur | 07:22 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo-incubator: Remove policy from oslo-incubator https://review.openstack.org/152812 | 07:29 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo-incubator: Prevent update.py from updating policy https://review.openstack.org/152813 | 07:31 |
| *** ajo has joined #openstack-oslo | 07:39 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo-incubator: Remove policy from oslo-incubator https://review.openstack.org/152812 | 07:42 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo-incubator: Prevent update.py from updating policy https://review.openstack.org/152813 | 07:42 |
| openstackgerrit | Merged openstack/taskflow: Use class constants during pformatting a tree node https://review.openstack.org/151996 | 07:46 |
| *** achanda has quit IRC | 07:46 | |
| *** e0ne has joined #openstack-oslo | 07:52 | |
| *** dulek has joined #openstack-oslo | 07:57 | |
| *** achanda has joined #openstack-oslo | 08:01 | |
| *** harlowja_at_home has quit IRC | 08:02 | |
| *** ajo has quit IRC | 08:10 | |
| *** achanda has quit IRC | 08:26 | |
| *** jaosorior has joined #openstack-oslo | 08:29 | |
| openstackgerrit | yangxurong proposed openstack/taskflow: Remove dumplicate code https://review.openstack.org/152826 | 08:42 |
| *** ajo has joined #openstack-oslo | 09:05 | |
| *** takedakn has joined #openstack-oslo | 09:12 | |
| *** e0ne has quit IRC | 09:12 | |
| *** mfedosin has quit IRC | 09:20 | |
| *** takedakn has quit IRC | 09:29 | |
| *** salv-orlando has joined #openstack-oslo | 09:37 | |
| *** boris-42 has joined #openstack-oslo | 09:39 | |
| *** e0ne has joined #openstack-oslo | 09:57 | |
| *** e0ne is now known as e0ne_ | 10:04 | |
| *** andreykurilin_ has joined #openstack-oslo | 10:08 | |
| *** ihrachyshka has joined #openstack-oslo | 10:12 | |
| *** e0ne_ is now known as e0ne | 10:12 | |
| *** dtantsur is now known as dtantsur|bbl | 10:13 | |
| *** pasquier-s has quit IRC | 10:21 | |
| *** pasquier-s has joined #openstack-oslo | 10:36 | |
| *** jaosorior has quit IRC | 10:46 | |
| *** alexpilotti has joined #openstack-oslo | 10:47 | |
| *** rushiagr has quit IRC | 10:52 | |
| *** dtantsur|bbl is now known as dtantsur | 10:56 | |
| *** vigneshvar has quit IRC | 10:57 | |
| *** dims has joined #openstack-oslo | 10:57 | |
| *** dims has quit IRC | 11:01 | |
| *** rushiagr has joined #openstack-oslo | 11:02 | |
| *** dims has joined #openstack-oslo | 11:02 | |
| *** vigneshvar has joined #openstack-oslo | 11:02 | |
| openstackgerrit | Roman Podoliaka proposed openstack/oslo.db: Organize provisioning to use testresources https://review.openstack.org/120870 | 11:03 |
| *** ihrachyshka has quit IRC | 11:04 | |
| *** cdent has joined #openstack-oslo | 11:06 | |
| *** andreykurilin_ has quit IRC | 11:20 | |
| *** i159 has joined #openstack-oslo | 11:21 | |
| *** e0ne is now known as e0ne_ | 11:21 | |
| *** e0ne_ has quit IRC | 11:31 | |
| *** ankit_ag has quit IRC | 11:37 | |
| *** sputnik13 has quit IRC | 11:38 | |
| ajo | dhellmann: do you have a minute to look at https://bugs.launchpad.net/oslo.rootwrap/+bug/1417331 ? | 11:41 |
| ajo | I'm already working on it, but if you could have a look to confirm our reasoning looks correct | 11:42 |
| ajo | that would be awesoem | 11:42 |
| ajo | awesome | 11:42 |
| *** ihrachyshka has joined #openstack-oslo | 11:52 | |
| *** pasquier-s has quit IRC | 11:58 | |
| *** david-lyle_afk is now known as david-lyle | 12:01 | |
| *** SlickN1k has joined #openstack-oslo | 12:12 | |
| ajo | ihrachyshka, can you double check marun and me are making sense here: https://bugs.launchpad.net/oslo.rootwrap/+bug/1417331 ? | 12:13 |
| ajo | when you have a minute. | 12:13 |
| ajo | I'm working on it | 12:13 |
| ajo | to propose a patch | 12:13 |
| *** pasquier-s has joined #openstack-oslo | 12:13 | |
| ajo | TL;DR, basically, ip netns exec $ | 12:13 |
| *** alexpilotti has quit IRC | 12:13 | |
| ajo | TL;DR, basically, ip netns exec $*, doesn't expand $* exec path to an absolute version | 12:13 |
| *** i159_ has joined #openstack-oslo | 12:14 | |
| ajo | that's done normally for the CommandFilter, because you want to enforce certain paths, and... because "sudo" env may have other paths defined | 12:14 |
| ajo | marun was missing that for functional testing, when we provides a rootwrap config also pointing to specific test binaries. | 12:15 |
| *** trown|call has joined #openstack-oslo | 12:16 | |
| ihrachyshka | ajo, that sounds reasonable, I saw that issue when running tests locally. | 12:17 |
| ajo | thanks ihrachyshka | 12:17 |
| *** rodrigod` has joined #openstack-oslo | 12:18 | |
| *** subscope has quit IRC | 12:19 | |
| *** subscope has joined #openstack-oslo | 12:20 | |
| *** i159 has quit IRC | 12:20 | |
| *** trown has quit IRC | 12:20 | |
| *** rodrigods has quit IRC | 12:20 | |
| *** svasheka has quit IRC | 12:20 | |
| *** SlickNik has quit IRC | 12:20 | |
| *** SlickN1k is now known as SlickNik | 12:20 | |
| *** rodrigod` is now known as rodrigods | 12:22 | |
| *** rodrigods has quit IRC | 12:22 | |
| *** rodrigods has joined #openstack-oslo | 12:22 | |
| *** svasheka has joined #openstack-oslo | 12:24 | |
| *** viktors has joined #openstack-oslo | 12:28 | |
| *** david-lyle is now known as david-lyle_afk | 12:36 | |
| *** ihrachyshka_ has joined #openstack-oslo | 12:36 | |
| *** ihrachyshka has quit IRC | 12:36 | |
| *** david-lyle_afk is now known as david-lyle | 12:36 | |
| *** david-lyle is now known as david-lyle_afk | 12:44 | |
| *** david-lyle_afk is now known as david-lyle | 12:45 | |
| *** jaosorior has joined #openstack-oslo | 12:45 | |
| *** takedakn has joined #openstack-oslo | 12:47 | |
| *** e0ne has joined #openstack-oslo | 12:53 | |
| *** vipul has quit IRC | 12:59 | |
| *** vipul has joined #openstack-oslo | 13:03 | |
| *** e0ne is now known as e0ne_ | 13:04 | |
| *** e0ne_ is now known as e0ne | 13:05 | |
| breton | oslo_db, I'd appreciate if you had a look at https://review.openstack.org/#/c/134885/ . I'd really love to see it in the next release | 13:09 |
| *** dims has quit IRC | 13:10 | |
| *** bknudson has joined #openstack-oslo | 13:11 | |
| *** dims has joined #openstack-oslo | 13:19 | |
| *** prad has joined #openstack-oslo | 13:19 | |
| *** dims has quit IRC | 13:28 | |
| *** e0ne is now known as e0ne_ | 13:29 | |
| *** prad has quit IRC | 13:31 | |
| *** kgiusti has joined #openstack-oslo | 13:36 | |
| *** e0ne_ is now known as e0ne | 13:38 | |
| *** vigneshvar has quit IRC | 13:43 | |
| *** trown|call is now known as trown | 13:43 | |
| *** rushiagr is now known as rushiagr_away | 13:45 | |
| *** _amrith_ is now known as amrith | 13:54 | |
| dhellmann | jogo: annegentle is working on a new theme for docs, but I'm not sure if it's meant to be used for developer docs or not. Either way, I'd be happy to have that be more responsive. | 13:58 |
| inc0 | dhellmann, hi, any news about gerrit by any chance?:) | 13:59 |
| dhellmann | ajo: you want to talk to ttx about rootwrap stuff, he leads that team | 14:00 |
| ajo | dhellmann, thanks, I will | 14:00 |
| ttx | ajo: hi | 14:01 |
| ajo | ttx: https://bugs.launchpad.net/oslo.rootwrap/+bug/1417331 could you look that bug ? | 14:01 |
| dhellmann | inc0: I want to give the oslo core team a few days to look at the repo being imported, so we won't do anything before next week | 14:01 |
| ajo | I'm working to provide a bugfix, but I wanted to double check it makes sense | 14:01 |
| inc0 | dhellmann, roger that | 14:01 |
| inc0 | let me know if there is anything for me to help with | 14:02 |
| ajo | ttx, the problem is that IpNetns filter doesn't expand the exec path for the argument after ip netns exec net-namespace $0 .... | 14:02 |
| dhellmann | breton: added to my review queue | 14:02 |
| ttx | ajo: reminds me of another bug | 14:02 |
| ajo | so even if we provide extra exec_dirs during testing to rootwrap.conf, those won't be accessible (due that sudo has differen paths) | 14:02 |
| ajo | different | 14:02 |
| dhellmann | inc0: thanks, as soon as we have it imported I'll email the dev list and we can start cleaning it up. you'll want to coordinate with dansmith, since he's the lead dev for the library | 14:03 |
| ajo | ttx, which one? | 14:03 |
| ttx | https://bugs.launchpad.net/oslo.rootwrap/+bug/1394279 | 14:03 |
| ajo | ttx: our problem is that we want to use rootwrap in functional testing, without fully installing the environment to the system | 14:03 |
| ttx | same: issues running rootwrap from a venv | 14:04 |
| ttx | that one with KillFilter trying to kill a venv-local python process | 14:04 |
| ajo | ahaa, very similar, yes | 14:04 |
| ajo | I'm reading your comments | 14:05 |
| ttx | ajo: might not be as much of a corner case as I thought | 14:05 |
| ttx | so maybe worth making that change | 14:05 |
| ttx | The issue being the match function doesn't have exec_dirs handy, so we need to change the filter contract | 14:06 |
| ttx | unless you find a more creative way to solve it | 14:06 |
| *** dulek has quit IRC | 14:06 | |
| ajo | ttx: ack, I will talk about this with marun, may be we can just set the secure path in sudo config for the functional testing environment | 14:06 |
| *** takedakn has quit IRC | 14:07 | |
| *** dulek has joined #openstack-oslo | 14:07 | |
| ajo | ttx: I have a half-way cooked patch , | 14:07 |
| ajo | but I broke the matching | 14:07 |
| ttx | right | 14:07 |
| ttx | I mean, I'm not opposed to chnage that, but we need to make sure it's really worth it ;) | 14:07 |
| ajo | ttx: but if we have a simpler solution, may be it's not worth adding complexity to rootwrap for a corner case | 14:07 |
| ajo | ttx: ack, let's check the simple solution first | 14:08 |
| ttx | ajo: keep me posted | 14:08 |
| ajo | commenting on the new bug, | 14:08 |
| ajo | ok ttx, thanks a lot | 14:08 |
| ttx | you can refer to the other one, will make it easier to find | 14:08 |
| ajo | sure | 14:08 |
| ajo | btw, I will post my half-cooked patch as WIP for reference / backup, | 14:10 |
| openstackgerrit | Miguel Angel Ajo proposed openstack/oslo.rootwrap: WIP: expand IpNetnsFilter executable path from exec_dirs https://review.openstack.org/152902 | 14:17 |
| *** rushiagr_away is now known as rushiagr | 14:18 | |
| *** prad has joined #openstack-oslo | 14:19 | |
| ajo | ttx ^ the WIP patch, for reference, I made some comment on it, | 14:20 |
| ajo | if we finally need to support it, we can do the exec / exec_dirs lookup as a final step after matching | 14:21 |
| ajo | if there is no better place to do it | 14:21 |
| ajo | right now it's broken, as I expand before trying to match ':) | 14:22 |
| *** jecarey has quit IRC | 14:28 | |
| *** dims has joined #openstack-oslo | 14:29 | |
| *** gordc has joined #openstack-oslo | 14:29 | |
| *** dims_ has joined #openstack-oslo | 14:33 | |
| breton | dhellmann: thanks in advance | 14:37 |
| *** dims has quit IRC | 14:37 | |
| *** andrearo1 has joined #openstack-oslo | 14:43 | |
| *** e0ne is now known as e0ne_ | 14:44 | |
| *** mriedem has joined #openstack-oslo | 14:45 | |
| *** andrearosa has quit IRC | 14:45 | |
| *** dulek has quit IRC | 14:46 | |
| *** dulek has joined #openstack-oslo | 14:47 | |
| *** e0ne_ is now known as e0ne | 14:47 | |
| *** andrearo1 is now known as andrearosa | 14:52 | |
| dims_ | breton: lgtm. | 14:53 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:00 | |
| *** kgiusti has quit IRC | 15:02 | |
| *** kgiusti has joined #openstack-oslo | 15:05 | |
| *** zz_jgrimm is now known as jgrimm | 15:09 | |
| *** ihrachyshka_ is now known as ihrachyshka | 15:13 | |
| *** amotoki has joined #openstack-oslo | 15:20 | |
| breton | dims_: awesome, thank you | 15:21 |
| *** mtanino has joined #openstack-oslo | 15:22 | |
| *** yamahata has joined #openstack-oslo | 15:28 | |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: rabbit: allow to configure heartbeat rate https://review.openstack.org/152201 | 15:29 |
| openstackgerrit | Mehdi Abaakouk proposed openstack/oslo.messaging: rabbit: heartbeat implementation https://review.openstack.org/146047 | 15:29 |
| *** jecarey has joined #openstack-oslo | 15:34 | |
| openstackgerrit | Merged openstack/oslo.db: Refactor database migration manager to use given engine https://review.openstack.org/134885 | 15:35 |
| *** e0ne is now known as e0ne_ | 15:37 | |
| *** ChuckC has joined #openstack-oslo | 15:40 | |
| *** ChuckC_ has quit IRC | 15:41 | |
| *** e0ne_ is now known as e0ne | 15:47 | |
| dims_ | denis_makogon: ozamiatin: i see 2 bugs for adding global requirements for oslo.messaging. did anyone try filing reviews yet? | 15:50 |
| denis_makogon | dims_, hi there, which ones? | 15:50 |
| ozamiatin | dims_, no i didn't | 15:51 |
| dims_ | https://bugs.launchpad.net/oslo.messaging/+bug/1417505 https://bugs.launchpad.net/oslo.messaging/+bug/1417132 | 15:51 |
| dims_ | dhellmann: sileht: would optional dependencies in oslo.messaging ever get blessed by requirements-core folks? | 15:55 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove duplicate code https://review.openstack.org/152826 | 15:57 |
| denis_makogon | dims_, ozamiatin will fix those bugs soon, so there would be something to approve =) | 15:57 |
| dims_ | haha denis_makogon | 15:57 |
| ozamiatin | :) | 15:58 |
| dims_ | denis_makogon: you mentioned something about load testing for oslo.messaging, is there a spec or review? | 16:02 |
| *** pblaho has quit IRC | 16:04 | |
| *** tsekiyama has joined #openstack-oslo | 16:04 | |
| denis_makogon | dims_, for now, we don't have but we're currently trying to build a tool that works in that manner that i've described in ML, so, once we'd have something more concrete to propose, we'd publish spec, i would foresee that it would happen in couple weeks | 16:04 |
| dims_ | denis_makogon: very cool | 16:04 |
| dims_ | sileht: ^^ | 16:05 |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: Missed requirements for zmq oslo.messaging https://review.openstack.org/152966 | 16:09 |
| *** inc0 has quit IRC | 16:11 | |
| sileht | dims_, requirements are already in test-requirements*.txt | 16:13 |
| sileht | dims_, we don't want to enforce everybody to install zmq/redis stuffs | 16:14 |
| *** stevemar has joined #openstack-oslo | 16:14 | |
| ozamiatin | sileht, but devstack need them too | 16:14 |
| ozamiatin | sileht how to make it optional to install? | 16:14 |
| *** ChuckC_ has joined #openstack-oslo | 16:14 | |
| sileht | ozamiatin, devstack manually install them, when you setup zeromq | 16:14 |
| ozamiatin | sileht, now it doesn't :( | 16:15 |
| dhellmann | dims_: what sort of optional dependencies? | 16:15 |
| sileht | ozamiatin, see https://github.com/openstack-dev/devstack/blob/master/lib/rpc_backend#L164 | 16:15 |
| sileht | and see https://github.com/openstack-dev/devstack/blob/master/lib/rpc_backend#L176 | 16:15 |
| dims_ | dhellmann: zmq and redis was what the bugs from oslo.messaging ask for | 16:16 |
| dhellmann | dims_: ah, see sileht's response ^^ | 16:16 |
| dims_ | dhellmann: very interesting :) didn't realize we had one more layer of dependencies in the scripts :) | 16:17 |
| *** ChuckC has quit IRC | 16:17 | |
| dhellmann | dims_: The "O" in OpenStack stands for "onion" | 16:17 |
| ozamiatin | sileht, thanks for pointing that, I'll check why it wasn't installed properly on my workstation | 16:18 |
| dims_ | dhellmann: makes you cry as you peel it :) | 16:20 |
| dhellmann | dims_: exactly | 16:20 |
| sileht | dhellmann, dims_ the big quesions is, should optional be in the requirements.txt ? | 16:20 |
| dhellmann | sileht: yes, keep them optional | 16:20 |
| dims_ | sileht: i've seen push back from requirements-core folks | 16:20 |
| dims_ | to add to global-requirements.txt | 16:21 |
| dhellmann | we have this problem with drivers all over openstack, and the current standard is to keep them in test-requirements.txt | 16:21 |
| sileht | so let's close these bugs :) | 16:21 |
| dhellmann | or retarget them, if devstack isn't installing what it needs properly? | 16:22 |
| sileht | dhellmann, it works with devstack I have tested them to prepare the funcionnal tests for gate | 16:22 |
| dhellmann | sileht: cool, just checking | 16:23 |
| ozamiatin | I'll check once more and then I'll update the status | 16:23 |
| sileht | ozamiatin, cool thanks, I use trusty if that's help | 16:23 |
| sileht | dhellmann, I'm waiting for infra guys to enable all this tests: https://review.openstack.org/#/q/status:open+project:openstack-infra/project-config+branch:master+topic:sileht/oslo-func,n,z | 16:24 |
| dims_ | dhellmann: even test-requirements have to be in global-requirements, so these 2 won't make it there. devstack script is the best way i guess for now | 16:24 |
| dhellmann | sileht: cool -- is their approval blocked on something or do they just need some time to review them? | 16:25 |
| dhellmann | dims_: we can have functional test requirements in the global list | 16:25 |
| dhellmann | we just can't require them for the library itself | 16:25 |
| sileht | dhellmann, I just wait, they should be landed soon | 16:25 |
| dhellmann | sileht: ok, good | 16:25 |
| dims_ | dhellmann: ah cool. i'll let ozamiatin and denis_makogon come back after checking up on the possibilities | 16:26 |
| dhellmann | dims_: at least I think so | 16:26 |
| * bnemec wishes he had time to finish the optional dependencies work | 16:26 | |
| dims_ | hehe dhellmann | 16:26 |
| bnemec | It's come up like three times in the past week again. | 16:26 |
| dims_ | bnemec: have to ask...which one? | 16:26 |
| dhellmann | the requirements rules have been changing lately :-/ | 16:26 |
| dims_ | big tent == bigger dependencies | 16:27 |
| bnemec | dims_: https://review.openstack.org/#/c/83150/ | 16:27 |
| bnemec | That was a PoC of the idea we had discussed on the list. | 16:27 |
| dims_ | denis_makogon: maybe you can help bnemec with that? | 16:28 |
| bnemec | I believe it was working for me locally, but I needed to get the requirements check job to recognize the new files and the -r syntax. | 16:29 |
| *** marun has joined #openstack-oslo | 16:30 | |
| bnemec | dims_: denis_makogon: Also http://lists.openstack.org/pipermail/openstack-dev/2015-January/055263.html | 16:31 |
| openstackgerrit | Merged openstack/oslo.messaging: Make sure zmq can work with redis https://review.openstack.org/142651 | 16:37 |
| denis_makogon | dims_, bnemec, sure, let me know how can i help you. | 16:39 |
| bnemec | denis_makogon: At this point I think it's mostly a question of checking that it still works, then working with infra to get the requirements check job and proposal bot aware of the new file locations. | 16:43 |
| denis_makogon | bnemec, you've been talking about those patchsets from your mail? | 16:45 |
| *** noelbk has joined #openstack-oslo | 16:46 | |
| bnemec | denis_makogon: Yep | 16:47 |
| bnemec | Basically it's a way for us to have a blessed way of specifying which extra dependencies a given driver needs. | 16:47 |
| bnemec | Rather than just "look at what devstack does" :-) | 16:48 |
| *** sputnik13 has joined #openstack-oslo | 16:48 | |
| *** amrith is now known as _amrith_ | 16:48 | |
| *** rpodolyaka has left #openstack-oslo | 16:50 | |
| *** rpodolyaka has joined #openstack-oslo | 16:50 | |
| openstackgerrit | Merged openstack-dev/cookiecutter: Updated template from global requirements https://review.openstack.org/149883 | 16:52 |
| openstackgerrit | Merged openstack-dev/cookiecutter: Add a tox debug environment https://review.openstack.org/149884 | 16:52 |
| dhellmann | bnemec: there's a pep for that for setuptools, are you using that syntax? | 16:52 |
| dhellmann | the "right" solution might be to contribute that up to setuptools | 16:53 |
| bnemec | dhellmann: You mean something like this: http://lists.openstack.org/pipermail/openstack-dev/2014-February/027373.html ? | 16:53 |
| *** e0ne is now known as e0ne_ | 16:54 | |
| dhellmann | bnemec: yeah, the "extras" thing is what I was thinking of | 16:55 |
| dhellmann | although I think they came up with something more sophisticated, too, let me see if I can find it | 16:55 |
| dhellmann | bnemec: https://www.python.org/dev/peps/pep-0426/#extras-optional-dependencies | 16:56 |
| *** sputnik13 has quit IRC | 16:59 | |
| *** dtantsur is now known as dtantsur|afk | 17:01 | |
| dhellmann | stevemar: let me know if you're still running into issues with the WritableLogger | 17:03 |
| *** ihrachyshka has quit IRC | 17:05 | |
| *** kgiusti has quit IRC | 17:07 | |
| *** _amrith_ is now known as amrith | 17:23 | |
| denis_makogon | bnemec, i will take a look at that patch in a few days, may i submit new patchset if i'd have something to update? | 17:28 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Have a little fun with release notes https://review.openstack.org/152680 | 17:29 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Add tox env for running release notes script https://review.openstack.org/147963 | 17:29 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Adjust release note template whitespace https://review.openstack.org/147964 | 17:29 |
| bnemec | denis_makogon: Absolutely. I expect there will be at least some rebasing needed. | 17:29 |
| bnemec | denis_makogon: I can restore the existing change or you can just start a new one. | 17:30 |
| denis_makogon | bnemec, sure, will do, thanks | 17:30 |
| *** e0ne_ is now known as e0ne | 17:30 | |
| denis_makogon | bnemec, let's keep it as the same patchset, so please restore it if you don't mind | 17:31 |
| bnemec | denis_makogon: Done | 17:32 |
| denis_makogon | bnemec, thanks | 17:32 |
| *** GheRivero has quit IRC | 17:34 | |
| *** prad has quit IRC | 17:36 | |
| *** prad has joined #openstack-oslo | 17:36 | |
| *** i159_ has quit IRC | 17:37 | |
| *** denis_makogon has quit IRC | 17:43 | |
| stevemar | dhellmann, yeah still seem to be running into issues: https://review.openstack.org/#/c/152699/ specifically the change to keystone/common/environment/eventlet_server.py | 17:47 |
| *** dulek has quit IRC | 17:47 | |
| *** dulek has joined #openstack-oslo | 17:47 | |
| *** zzzeek has joined #openstack-oslo | 17:51 | |
| *** vigneshvar has joined #openstack-oslo | 17:56 | |
| *** harlowja has joined #openstack-oslo | 18:11 | |
| *** yamahata has quit IRC | 18:14 | |
| *** daniel3_ has joined #openstack-oslo | 18:22 | |
| *** kgiusti has joined #openstack-oslo | 18:22 | |
| *** jaosorior has quit IRC | 18:26 | |
| *** achanda has joined #openstack-oslo | 18:31 | |
| *** amotoki has quit IRC | 18:32 | |
| *** yamahata has joined #openstack-oslo | 18:36 | |
| *** rushiagr is now known as rushiagr_away | 18:38 | |
| *** sputnik13 has joined #openstack-oslo | 18:39 | |
| *** e0ne is now known as e0ne_ | 18:41 | |
| bknudson | The BadLog exception is because of this: http://git.openstack.org/cgit/openstack/keystone/tree/keystone/tests/core.py#n390 | 18:42 |
| bknudson | it's to prevent keystone code from having invalid log strings (e.g. missing parameters) | 18:43 |
| *** e0ne_ is now known as e0ne | 18:45 | |
| *** e0ne is now known as e0ne_ | 18:45 | |
| *** e0ne_ is now known as e0ne | 18:46 | |
| dhellmann | stevemar: looking | 18:46 |
| *** ihrachyshka has joined #openstack-oslo | 18:46 | |
| *** e0ne is now known as e0ne_ | 18:47 | |
| *** e0ne_ is now known as e0ne | 18:48 | |
| dhellmann | bknudson: is there any way to figure out what's invalid about it? | 18:48 |
| *** e0ne has quit IRC | 18:48 | |
| bknudson | dhellmann: Not sure that I've ever had to look into it... maybe add a breakpoint in BadLog __init__ and check the backtrace? | 18:51 |
| dhellmann | ok, I'll fiddle | 18:51 |
| bknudson | the handleError function could be enhanced to provide more information -- at least the record. | 18:52 |
| dhellmann | bknudson: as it happens, we have a fixture in oslo.log for this | 18:57 |
| bknudson | dhellmann: I should have looked. | 18:57 |
| dhellmann | stevemar: do you mind if I update your patch to use the oslo logging fixture for reporting logging errors? | 18:57 |
| bknudson | http://git.openstack.org/cgit/openstack/oslo.log/tree/oslo_log/fixture/logging_error.py ! | 18:57 |
| dhellmann | right | 18:58 |
| stevemar | dhellmann, go right ahead | 18:58 |
| dhellmann | stevemar: done | 18:58 |
| dhellmann | the error seems to be something to do with unicode handling | 18:59 |
| dhellmann | it's entirely likely the problem is actually in oslo.log | 18:59 |
| bknudson | dhellmann: what does it raise? | 18:59 |
| bknudson | _handleError? | 18:59 |
| dhellmann | bknudson, stevemar : http://paste.openstack.org/show/166953/ | 19:00 |
| bknudson | TypeError? | 19:00 |
| dhellmann | bknudson: no, handleError is called in the context of an exception handler so the bare raise re-raises the current exception | 19:00 |
| bknudson | ahh | 19:01 |
| bknudson | I don't see that in the docs. | 19:01 |
| dhellmann | http://docs.openstack.org/developer/oslo.log/api/fixtures.html#oslo_log.fixture.get_logging_handle_error_fixture | 19:03 |
| dhellmann | there was a fairly recent patch to document it | 19:03 |
| bknudson | File "keystone/common/wsgi.py", line 445, in __call__ does LOG.exception(e) | 19:04 |
| bknudson | probably not how you're supposed to log an exception. | 19:04 |
| *** enykeev has quit IRC | 19:04 | |
| dhellmann | that should work -- I suspect the issue is with how the logging is being configured in the tests | 19:04 |
| dhellmann | maybe the default format string is bad or something | 19:04 |
| bknudson | could be like LOG.exception('an error happened) | 19:04 |
| dhellmann | oh, yeah, I'll bet you're right | 19:05 |
| *** enykeev has joined #openstack-oslo | 19:06 | |
| dhellmann | bknudson: yeah, fixing a few of those seems to have resolved it. | 19:08 |
| bknudson | wow | 19:08 |
| dhellmann | bknudson, stevemar : I'll submit this as a second patch and you can decide whether you like my version or want to provide more useful message strings | 19:08 |
| dhellmann | bknudson: good eye | 19:08 |
| bknudson | wonder why that changed (why it worked before) | 19:08 |
| dhellmann | it's possible this is a new interaction of the i18n and logging code | 19:09 |
| dhellmann | translatable message objects in exceptions don't want to be used as strings, and the logging code expects its first argument to be a formatting string or other message | 19:09 |
| bknudson | when I said "I don't see that in the docs." I was referring to the python logging doc -- https://docs.python.org/2/library/logging.html#logging.Handler.handleError -- and "that" was referring to it being called in an exception handler. | 19:11 |
| dhellmann | bknudson: ah, we probably looked at the source for the logging module | 19:11 |
| dhellmann | bknudson: I'm seeing similar behavior with logging errors in other code now. This patch I have is going to be an example, but not a complete solution to the problem. | 19:12 |
| dhellmann | hmm, there were only 14 failures, so maybe I can fix the others, too | 19:12 |
| *** cdent has quit IRC | 19:18 | |
| *** e0ne has joined #openstack-oslo | 19:24 | |
| dhellmann | bknudson: the old logging adapter may have been hiding these issues, too | 19:26 |
| bknudson | you'd think if the exception str() had formatting %s then that should have failed before... not sure if that's what's happening. | 19:27 |
| dhellmann | if you have a unicode string, '%s' invokes __unicode__, which is supported | 19:27 |
| dhellmann | if you have a byte string, '%s' invokes __str__, which is not supported | 19:28 |
| dhellmann | I think the old context adapter used to call unicode() | 19:28 |
| *** achanda has quit IRC | 19:35 | |
| *** achanda has joined #openstack-oslo | 19:45 | |
| openstackgerrit | Merged openstack/taskflow: Improved diagram for Taskflow https://review.openstack.org/152354 | 19:48 |
| *** harlowja is now known as harlowja_away | 19:50 | |
| *** amrith is now known as _amrith_ | 19:52 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Start creating migration notes https://review.openstack.org/153031 | 19:56 |
| dhellmann | bknudson: ^^ | 19:56 |
| dhellmann | dims_: ^^ | 19:56 |
| dims_ | pong dhellmann | 19:56 |
| dhellmann | dims_: logging doc review for when you have some time ^^ | 19:56 |
| *** dulek has quit IRC | 19:58 | |
| dims_ | dhellmann: do we want to document any fixture changes there? | 19:58 |
| dhellmann | dims_: probably eventually; I wanted to capture this particular thing since it was a pain for the keystone folks | 19:59 |
| dims_ | dhellmann: looks good, thje warning with exception, we may need a hacking rule eventually | 20:00 |
| bknudson | dims_: no hacking rule needed in keystone since it fails tests | 20:00 |
| dims_ | bknudson: :) | 20:01 |
| dims_ | bknudson: not all projects have good code coverage | 20:01 |
| bknudson | hacking isn't going to help them... they're too far gone. | 20:02 |
| *** tsufiev_ is now known as tsufiev | 20:02 | |
| dims_ | fair enough :) | 20:02 |
| *** prad has quit IRC | 20:06 | |
| *** prad has joined #openstack-oslo | 20:10 | |
| *** daniel3_ has quit IRC | 20:14 | |
| *** _amrith_ is now known as amrith | 20:18 | |
| *** achanda has quit IRC | 20:20 | |
| *** achanda has joined #openstack-oslo | 20:21 | |
| *** achanda has quit IRC | 20:32 | |
| *** ihrachyshka has quit IRC | 20:32 | |
| *** harlowja_away is now known as harlowja | 20:33 | |
| *** 6A4ABBR4J has quit IRC | 20:34 | |
| *** achanda has joined #openstack-oslo | 20:40 | |
| *** daniel3_ has joined #openstack-oslo | 20:57 | |
| *** ajo has quit IRC | 21:09 | |
| *** ajo has joined #openstack-oslo | 21:10 | |
| *** ChuckC_ is now known as ChuckC | 21:16 | |
| *** achanda has quit IRC | 21:33 | |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Update .gitignore https://review.openstack.org/148671 | 21:37 |
| *** achanda has joined #openstack-oslo | 21:38 | |
| stevemar | sigmavirus24, just a few more open reviews: https://review.openstack.org/#/q/project:openstack/oslo.policy+status:open,n,z | 21:42 |
| sigmavirus24 | stevemar: I don't mind abandoning mine. It was a drive-by question | 21:43 |
| stevemar | merge yours and add mine on top :O | 21:44 |
| sigmavirus24 | or make yours dependent on mine? | 21:44 |
| sigmavirus24 | No need | 21:44 |
| sigmavirus24 | That's all a headache | 21:44 |
| sigmavirus24 | Just add the blueprint info to yours so we can track that stuff across projects | 21:44 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Use oslo namespaces for oslo libraries https://review.openstack.org/152808 | 21:45 |
| stevemar | done | 21:45 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Use oslo namespaces for oslo libraries https://review.openstack.org/152808 | 21:46 |
| sigmavirus24 | that works too lol | 21:46 |
| stevemar | what headache, took 2 seconds :) | 21:46 |
| stevemar | `git review -d yours; git review -x mine; git review` | 21:46 |
| sigmavirus24 | Yeah that's the thing. I'm not yet familiar enough with git-review | 21:46 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.policy: Drop use of oslo namespace for oslo libraries https://review.openstack.org/152808 | 21:47 |
| stevemar | dhellmann, ty for the correction :) | 21:47 |
| stevemar | sigmavirus24, this one was funny: https://review.openstack.org/#/c/152805/ | 21:48 |
| sigmavirus24 | Yeah | 21:48 |
| * sigmavirus24 didn't notice it when he was removing the graduated modules | 21:48 | |
| stevemar | sigmavirus24, you are human after all | 21:49 |
| dhellmann | stevemar: yeah, that seemed like it was easier to just fix and +2 than make you go through another rev | 21:50 |
| stevemar | dhellmann, i'm wondering if we need the copyright in the _i18n file, i copy-pasted from a keystone project | 21:51 |
| dhellmann | stevemar: I didn't know where you worked. I wouldn't bother with that, so if you want to remove it that's fine. | 21:51 |
| stevemar | dhellmann, removing it then | 21:51 |
| openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Use oslo_i18n https://review.openstack.org/152806 | 21:52 |
| stevemar | dhellmann, i think that's all thats left before tagging a release? | 21:53 |
| dhellmann | stevemar: https://bugs.launchpad.net/oslo.policy | 21:55 |
| dhellmann | I should probably tag some of those as pre-release or something | 21:55 |
| * sigmavirus24 feels like working on https://bugs.launchpad.net/oslo.policy/+bug/1384377 | 21:56 | |
| dhellmann | stevemar: https://bugs.launchpad.net/oslo.policy/+bugs?field.tag=prerelease | 21:56 |
| sigmavirus24 | Seems like it would be fun | 21:56 |
| stevemar | dhellmann, thanks for the tag | 21:57 |
| dhellmann | stevemar: 1415633 is pretty fuzzily defined | 21:57 |
| stevemar | sigmavirus24, that is a brutal one | 21:57 |
| sigmavirus24 | dhellmann: I agree | 21:58 |
| stevemar | dhellmann, yeah thats super vague | 21:58 |
| sigmavirus24 | I wouldn't be opposed to making it some other module inside oslo_policy | 21:58 |
| sigmavirus24 | i.e., oslo_policy.rules | 21:58 |
| dhellmann | stevemar: basically, go through everything with a fine toothed comb and think about whether you want to support someone using that class in weird ways for the rest of the life of this library | 21:59 |
| sigmavirus24 | but I'm not sure I see the benefit in making Rules private given I know of at least one project that relies on it for testing purposes | 21:59 |
| dhellmann | stevemar: if not, make it private for now | 21:59 |
| sigmavirus24 | dhellmann: I think \t betrayed you ;) | 21:59 |
| dhellmann | sigmavirus24: I was replying to stevemar about 1415633 | 21:59 |
| stevemar | i got the message :) | 22:00 |
| dhellmann | sigmavirus24: although I do agree that the current policy.py could use some reorg | 22:00 |
| dhellmann | when in doubt, I mark something private. it's easier to make it public later than to go the other way | 22:00 |
| sigmavirus24 | Fair enough :) | 22:00 |
| stevemar | dhellmann, i should mark that i18n patch as closing https://bugs.launchpad.net/oslo.policy/+bug/1415628 | 22:01 |
| dhellmann | stevemar: good idea. at this point you'll need to add a link to the patch in the bug by hand (the bot only does that on first submissions) | 22:01 |
| stevemar | ah okay | 22:02 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Tweak the WBE diagram (and present it as an svg) https://review.openstack.org/153064 | 22:07 |
| *** daniel3_ has quit IRC | 22:07 | |
| *** achanda has quit IRC | 22:08 | |
| *** andreykurilin_ has joined #openstack-oslo | 22:08 | |
| *** vigneshvar has quit IRC | 22:17 | |
| *** jecarey has quit IRC | 22:20 | |
| *** dulek has joined #openstack-oslo | 22:24 | |
| *** daniel3_ has joined #openstack-oslo | 22:26 | |
| *** dulek has quit IRC | 22:29 | |
| *** belliott has joined #openstack-oslo | 22:35 | |
| openstackgerrit | Merged openstack/debtcollector: Fix up the docs into reasonable shape https://review.openstack.org/152251 | 22:37 |
| openstackgerrit | Merged openstack/debtcollector: Upper case python https://review.openstack.org/152291 | 22:37 |
| belliott | dhellmann: hello - i'm wondering when the next release of oslo.messaging might be? i'm not familiar with the process around it. We've run into a bug with 1.5.1 at rackspace and the fix is only on master. (https://bugs.launchpad.net/oslo.messaging/+bug/1406629) | 22:38 |
| belliott | sileht: btw thx for fixing that ^ :) | 22:38 |
| *** kgiusti has left #openstack-oslo | 22:40 | |
| *** mriedem has quit IRC | 22:41 | |
| *** andreykurilin_ has quit IRC | 22:46 | |
| *** andreykurilin_ has joined #openstack-oslo | 22:55 | |
| *** amrith is now known as _amrith_ | 22:57 | |
| *** dims_ has quit IRC | 22:57 | |
| *** ajo has quit IRC | 23:00 | |
| *** jaypipes has quit IRC | 23:00 | |
| *** achanda has joined #openstack-oslo | 23:08 | |
| *** prad has quit IRC | 23:10 | |
| *** achanda has quit IRC | 23:15 | |
| *** e0ne has quit IRC | 23:24 | |
| *** gordc has quit IRC | 23:26 | |
| *** sputnik13 has quit IRC | 23:34 | |
| *** achanda has joined #openstack-oslo | 23:37 | |
| *** dulek has joined #openstack-oslo | 23:39 | |
| *** dims__ has joined #openstack-oslo | 23:40 | |
| *** dims_ has joined #openstack-oslo | 23:41 | |
| *** ViswaV has joined #openstack-oslo | 23:45 | |
| *** dims__ has quit IRC | 23:46 | |
| openstackgerrit | Vilobh Meshram proposed openstack/taskflow: Docstrings should document parameters return values https://review.openstack.org/152375 | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!