*** kragniz_ is now known as kragniz | 00:00 | |
*** dims_ has quit IRC | 00:12 | |
*** dimsum__ has joined #openstack-oslo | 00:49 | |
*** dimsum__ has quit IRC | 00:54 | |
openstackgerrit | Min Pae proposed openstack/taskflow: adding check for str/unicode type in requires https://review.openstack.org/156094 | 00:58 |
---|---|---|
*** liusheng has quit IRC | 01:02 | |
*** bknudson has quit IRC | 01:07 | |
*** zz_jgrimm has quit IRC | 01:27 | |
*** achanda has joined #openstack-oslo | 01:28 | |
*** zz_jgrimm has joined #openstack-oslo | 01:31 | |
*** achanda has quit IRC | 01:33 | |
*** ndonegan has quit IRC | 02:05 | |
*** amotoki has quit IRC | 02:38 | |
openstackgerrit | Ian Wienand proposed openstack/oslo.policy: Do not log on missing or empty policy_dirs https://review.openstack.org/154742 | 02:43 |
openstackgerrit | Ian Wienand proposed openstack/oslo.policy: Do not log on missing or empty policy_dirs https://review.openstack.org/154742 | 02:47 |
*** achanda has joined #openstack-oslo | 02:52 | |
*** jaypipes has joined #openstack-oslo | 03:10 | |
*** harlowja_at_home has joined #openstack-oslo | 03:34 | |
*** amotoki has joined #openstack-oslo | 03:37 | |
*** amotoki has quit IRC | 03:43 | |
*** amotoki has joined #openstack-oslo | 03:49 | |
*** achanda has quit IRC | 04:00 | |
*** ndonegan has joined #openstack-oslo | 04:01 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Make the dispatcher handler be an actual type https://review.openstack.org/156114 | 04:05 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add retries to fetching the zookeeper server version https://review.openstack.org/155950 | 04:07 |
*** harlowja_at_home has quit IRC | 04:07 | |
*** jaosorior has quit IRC | 04:11 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Make the dispatcher handler be an actual type https://review.openstack.org/156114 | 04:13 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Make the dispatcher handler be an actual type https://review.openstack.org/156114 | 04:16 |
*** stevemar has joined #openstack-oslo | 04:17 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Make the dispatcher handler be an actual type https://review.openstack.org/156114 | 04:21 |
*** BAKfr has quit IRC | 04:32 | |
*** ndonegan has quit IRC | 04:32 | |
*** BAKfr has joined #openstack-oslo | 04:32 | |
*** BAKfr has quit IRC | 04:37 | |
*** stevemar has quit IRC | 04:47 | |
*** BAKfr has joined #openstack-oslo | 04:48 | |
*** achanda has joined #openstack-oslo | 05:00 | |
*** achanda has quit IRC | 05:06 | |
*** stevemar has joined #openstack-oslo | 05:25 | |
*** ndonegan has joined #openstack-oslo | 06:04 | |
*** ankit_ag has joined #openstack-oslo | 06:08 | |
*** achanda has joined #openstack-oslo | 06:13 | |
*** stevemar has quit IRC | 06:20 | |
*** achanda has quit IRC | 06:45 | |
openstackgerrit | Sridhar Gaddam proposed openstack/oslo.utils: Utility API to generate EUI-64 IPv6 address https://review.openstack.org/137774 | 06:51 |
openstackgerrit | Andreas Jaeger proposed openstack/oslo.versionedobjects: Set up translations https://review.openstack.org/156139 | 06:53 |
*** SridharGaddam has joined #openstack-oslo | 06:57 | |
*** achanda has joined #openstack-oslo | 07:04 | |
*** andreykurilin_ has joined #openstack-oslo | 07:13 | |
openstackgerrit | Min Pae proposed openstack/taskflow: adding check for str/unicode type in requires https://review.openstack.org/156094 | 07:21 |
*** inc0 has joined #openstack-oslo | 07:33 | |
*** andreykurilin_ has quit IRC | 07:35 | |
*** ihrachyshka has joined #openstack-oslo | 07:35 | |
openstackgerrit | Sridhar Gaddam proposed openstack/oslo.utils: Utility API to generate EUI-64 IPv6 address https://review.openstack.org/137774 | 07:36 |
*** ihrachyshka has quit IRC | 07:45 | |
*** snikitin has joined #openstack-oslo | 08:00 | |
*** shardy has joined #openstack-oslo | 08:02 | |
*** takedakn has joined #openstack-oslo | 08:13 | |
*** achanda has quit IRC | 08:18 | |
*** takedakn has quit IRC | 08:19 | |
*** achanda has joined #openstack-oslo | 08:28 | |
*** achanda has quit IRC | 08:35 | |
*** achanda has joined #openstack-oslo | 08:40 | |
*** dulek has joined #openstack-oslo | 08:40 | |
*** takedakn has joined #openstack-oslo | 08:42 | |
*** ihrachyshka has joined #openstack-oslo | 08:48 | |
ihrachyshka | dhellmann, https://review.openstack.org/#/c/137913/ please remove W-1. | 08:48 |
*** i159 has joined #openstack-oslo | 08:49 | |
*** rpodolyaka has left #openstack-oslo | 08:53 | |
*** rpodolyaka has joined #openstack-oslo | 08:54 | |
*** takedakn has quit IRC | 08:54 | |
*** amotoki_ has joined #openstack-oslo | 08:56 | |
*** openstackgerrit has quit IRC | 08:57 | |
*** openstackgerrit has joined #openstack-oslo | 08:57 | |
*** viktors has joined #openstack-oslo | 08:58 | |
*** amotoki_ has quit IRC | 09:02 | |
*** achanda has quit IRC | 09:02 | |
openstackgerrit | Grzegorz Grasza proposed openstack/oslo.versionedobjects: Rename utils -> _utils https://review.openstack.org/154409 | 09:08 |
*** ajo has joined #openstack-oslo | 09:10 | |
*** achanda has joined #openstack-oslo | 09:12 | |
*** salv-orlando has quit IRC | 09:22 | |
*** achanda has quit IRC | 09:23 | |
openstackgerrit | Vipin Balachandran proposed openstack/oslo.vmware: Handle SPBM SecurityError https://review.openstack.org/156164 | 09:36 |
*** sreshetnyak has joined #openstack-oslo | 09:37 | |
*** amotoki_ has joined #openstack-oslo | 09:45 | |
*** pblaho has joined #openstack-oslo | 09:52 | |
*** takedakn has joined #openstack-oslo | 10:01 | |
openstackgerrit | Grzegorz Grasza proposed openstack/oslo.versionedobjects: Rename utils -> _utils https://review.openstack.org/154409 | 10:13 |
*** takedakn has quit IRC | 10:14 | |
*** e0ne has joined #openstack-oslo | 10:20 | |
openstackgerrit | Grzegorz Grasza proposed openstack/oslo.versionedobjects: Rename utils -> _utils https://review.openstack.org/154409 | 10:20 |
*** rushiagr_away is now known as rushiagr | 10:23 | |
*** xek_ is now known as xek | 10:36 | |
*** rushiagr is now known as rushiagr_away | 10:40 | |
*** amotoki_ has quit IRC | 10:52 | |
*** e0ne is now known as e0ne_ | 10:57 | |
*** amotoki_ has joined #openstack-oslo | 10:58 | |
*** e0ne_ is now known as e0ne | 11:00 | |
*** amotoki_ has quit IRC | 11:03 | |
*** salv-orlando has joined #openstack-oslo | 11:12 | |
*** amotoki_ has joined #openstack-oslo | 11:13 | |
*** salv-orlando has quit IRC | 11:14 | |
*** salv-orlando has joined #openstack-oslo | 11:14 | |
*** miqui_ has quit IRC | 11:18 | |
*** miqui has joined #openstack-oslo | 11:18 | |
*** amotoki_ has quit IRC | 11:33 | |
*** amotoki_ has joined #openstack-oslo | 11:38 | |
*** amotoki_ has quit IRC | 11:40 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Remove more Nova-isms https://review.openstack.org/155393 | 11:41 |
*** e0ne is now known as e0ne_ | 11:45 | |
*** e0ne_ has quit IRC | 11:55 | |
*** e0ne has joined #openstack-oslo | 11:57 | |
*** andreykurilin_ has joined #openstack-oslo | 11:59 | |
inc0 | https://review.openstack.org/#/c/154835/ guys can I have this reviewed please? Its for versionedobjects | 12:00 |
*** amotoki_ has joined #openstack-oslo | 12:04 | |
*** dimsum__ has joined #openstack-oslo | 12:11 | |
*** amotoki_ has quit IRC | 12:21 | |
*** amotoki_ has joined #openstack-oslo | 12:23 | |
*** andreykurilin_ has quit IRC | 12:25 | |
*** andreykurilin_ has joined #openstack-oslo | 12:26 | |
*** amotoki_ has quit IRC | 12:31 | |
*** amotoki_ has joined #openstack-oslo | 12:31 | |
*** e0ne is now known as e0ne_ | 12:35 | |
*** kbyrne has joined #openstack-oslo | 12:37 | |
*** amotoki_ has quit IRC | 12:39 | |
*** e0ne_ is now known as e0ne | 12:39 | |
openstackgerrit | Merged openstack-dev/cookiecutter: Bump cookiecutter's hacking to 0.10 https://review.openstack.org/155843 | 12:49 |
openstackgerrit | Merged openstack-dev/oslo-cookiecutter: Bump cookiecutter's hacking to 0.10 https://review.openstack.org/155846 | 12:52 |
*** takedakn has joined #openstack-oslo | 12:56 | |
*** takedakn has quit IRC | 12:56 | |
*** palendae has quit IRC | 12:57 | |
*** cdent has joined #openstack-oslo | 12:57 | |
*** palendae has joined #openstack-oslo | 12:58 | |
*** jaosorior has joined #openstack-oslo | 12:59 | |
*** hogepodge has quit IRC | 13:03 | |
*** hogepodge has joined #openstack-oslo | 13:04 | |
*** e0ne is now known as e0ne_ | 13:04 | |
*** takedakn has joined #openstack-oslo | 13:05 | |
*** dimsum__ is now known as dims | 13:05 | |
*** dims is now known as Guest70266 | 13:05 | |
*** takedakn has quit IRC | 13:07 | |
*** e0ne_ has quit IRC | 13:14 | |
*** e0ne has joined #openstack-oslo | 13:16 | |
*** ankit_ag has quit IRC | 13:19 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Set up translations https://review.openstack.org/156139 | 13:22 |
openstackgerrit | Merged openstack/oslo.versionedobjects: Use six.wraps for py2/py3 compat https://review.openstack.org/155882 | 13:22 |
openstackgerrit | Merged openstack/oslo.serialization: add dependency warning to requirements.txt https://review.openstack.org/156015 | 13:27 |
*** gordc has joined #openstack-oslo | 13:32 | |
*** rushiagr_away is now known as rushiagr | 13:34 | |
*** e0ne is now known as e0ne_ | 13:40 | |
*** e0ne_ has quit IRC | 13:45 | |
*** kgiusti has joined #openstack-oslo | 13:46 | |
*** zzzeek has joined #openstack-oslo | 13:47 | |
*** Guest70266 is now known as dims__ | 13:48 | |
*** e0ne has joined #openstack-oslo | 13:50 | |
*** e0ne is now known as e0ne_ | 13:51 | |
*** e0ne_ is now known as e0ne | 13:51 | |
*** e0ne is now known as e0ne_ | 13:51 | |
*** e0ne_ is now known as e0ne | 13:52 | |
*** e0ne is now known as e0ne_ | 13:52 | |
*** e0ne_ is now known as e0ne | 13:52 | |
*** e0ne is now known as e0ne_ | 13:53 | |
*** e0ne_ is now known as e0ne | 13:53 | |
*** inc0 has quit IRC | 13:54 | |
*** inc0_ has joined #openstack-oslo | 13:55 | |
*** andreykurilin_ has quit IRC | 13:56 | |
*** andreykurilin_ has joined #openstack-oslo | 13:56 | |
*** Nakato has quit IRC | 13:59 | |
*** Nakato has joined #openstack-oslo | 13:59 | |
*** Guest59076 is now known as dansmith | 14:05 | |
*** dansmith is now known as Guest28456 | 14:06 | |
*** salv-orlando has quit IRC | 14:08 | |
*** Guest28456 is now known as dansmith_ | 14:09 | |
*** salv-orlando has joined #openstack-oslo | 14:09 | |
*** salv-orlando has quit IRC | 14:12 | |
*** salv-orlando has joined #openstack-oslo | 14:13 | |
*** salv-orlando has quit IRC | 14:15 | |
inc0_ | dansmith_, hi | 14:28 |
dansmith_ | inc0_: warning, only one half cup of coffee ingested so far | 14:28 |
dansmith_ | inc0_: hi :) | 14:28 |
inc0_ | I'll tread softly | 14:29 |
inc0_ | regarding https://review.openstack.org/#/c/154835/6 2 questions | 14:29 |
dansmith_ | sure | 14:29 |
inc0_ | 1. Can I safely remove this tzinfo thingy? You've mentioned in comment thats its for transition | 14:29 |
inc0_ | 2. About comparing objects - you've proposed that it is to be done as separate mixin, I've made just that | 14:30 |
inc0_ | why -1 then?:( | 14:31 |
dansmith_ | ah, I really thought I commented on the datetime thing the first time but I guess I didn't | 14:31 |
*** mriedem has joined #openstack-oslo | 14:31 | |
dansmith_ | when we pull things out of the DB, they have no tz-aware-ness, so we want to coerce them to tz-aware, but UTC | 14:32 |
dansmith_ | why do you want to remove that? | 14:32 |
*** amotoki_ has joined #openstack-oslo | 14:32 | |
*** jecarey has joined #openstack-oslo | 14:32 | |
dansmith_ | and on #2: because I was looking at an older patch (and also, see: coffee) | 14:32 |
inc0_ | because we don't always want to use tzaware datetime | 14:32 |
inc0_ | in my opinion its directly messing with data | 14:33 |
dansmith_ | well, we do, having made a lot of changes to get there | 14:33 |
dansmith_ | how about we have two fields then? DateTime and DateTimeNoTZ (or some better name) | 14:33 |
inc0_ | or a flag defaulting to False? | 14:34 |
inc0_ | True == no-tz | 14:34 |
dansmith_ | sure that's cool | 14:35 |
dansmith_ | so, if I may expand on a side tangent: | 14:35 |
dansmith_ | we have a test in nova that calculates the hash of all the objects, across every aspect of a thing that we consider "versioned", which includes the formats of the fields, and thus would need to cover this flag | 14:35 |
dansmith_ | to make sure nobody changes it and thinks it's a minor thing | 14:36 |
dansmith_ | I think we probably want to have some sort of infrastructure in here that makes it easy for projects to do that in their tree | 14:36 |
dansmith_ | there are remnants of it in test_objects.py, but it doesn't really make sense to be here since it's a library with no objects inside | 14:37 |
dhellmann | good morning, all | 14:37 |
dansmith_ | I haven't done much thinking about what that will look like, but just wanted to throw it out there if you're working on the heat side of this as well | 14:37 |
inc0_ | well in heat I had mostly problems with tests, and these failed on this tzinfo thing | 14:41 |
inc0_ | it seems they explicitly didn't suspect to have tzinfo in datetime | 14:42 |
inc0_ | hello dhellmann | 14:42 |
dhellmann | hi, inc0_ | 14:42 |
inc0_ | by the way, when do we want to have first release? | 14:42 |
inc0_ | anything remain to be done before that? | 14:43 |
dhellmann | we have to be pretty careful with the first release, because whatever we include there is going to be supported for a long time | 14:43 |
dhellmann | I don't want to rush into it | 14:44 |
inc0_ | how about having a rc or something? so we could try out cinder and heat implementation | 14:44 |
inc0_ | ? | 14:44 |
dhellmann | inc0_: as soon as we release something, no matter how we tag it, someone somewhere is going to start using it as though it is fully baked | 14:45 |
inc0_ | (myself included) | 14:46 |
inc0_ | dansmith_, can you think of anything needing to be done before release? | 14:47 |
dansmith_ | inc0_: yeah, we have a list of things to accomplish first, right? the work items? | 14:47 |
dansmith_ | the registry change was the big thing I wanted to do | 14:47 |
*** amotoki_ has quit IRC | 14:48 | |
inc0_ | do we have this list somewhere summarized? So we can split work? | 14:48 |
dansmith_ | inc0_: https://github.com/openstack/oslo-specs/blob/master/specs/kilo/adopt-oslo-versionedobjects.rst#work-items | 14:49 |
dansmith_ | I think we have a couple more things to make private in base.py | 14:49 |
dansmith_ | I can do that | 14:49 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.vmware: Add missing links to README https://review.openstack.org/156237 | 14:50 |
inc0_ | when we merge this comparason+datetime thing I should be able to make prototype in heat | 14:50 |
dansmith_ | cool | 14:50 |
*** tsekiyama has joined #openstack-oslo | 14:51 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Update release tool for governance change https://review.openstack.org/156238 | 14:53 |
*** jecarey has quit IRC | 14:53 | |
*** cdent_ has joined #openstack-oslo | 14:57 | |
*** amotoki_ has joined #openstack-oslo | 14:57 | |
*** cdent has quit IRC | 14:57 | |
*** cdent_ is now known as cdent | 14:57 | |
*** amotoki_ has quit IRC | 14:59 | |
*** tsekiyam_ has joined #openstack-oslo | 15:00 | |
*** amotoki_ has joined #openstack-oslo | 15:00 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:01 | |
*** ihrachyshka has quit IRC | 15:02 | |
*** amotoki_ has quit IRC | 15:03 | |
*** zz_jgrimm is now known as jgrimm | 15:04 | |
*** tsekiyama has quit IRC | 15:04 | |
*** dansmith_ is now known as dansmith | 15:05 | |
dhellmann | sileht: are we ready for an oslo.messaging release? | 15:10 |
dhellmann | viktors, rpodolyaka, zzzeek: are we ready for an oslo.db release? | 15:11 |
rpodolyaka | viktors: could you please trigger your magic 'run tests on all projects' script? | 15:12 |
rpodolyaka | dhellmann: ^ other than that, we should be good to go | 15:12 |
dhellmann | beekneemech: it looks like we could do with an oslo.concurrency release to update the requirements and imports | 15:13 |
dhellmann | rpodolyaka, viktors: we have a script like that in the incubator, hang on | 15:13 |
*** beekneemech is now known as bnemec | 15:13 | |
dhellmann | rpodolyaka: tools/pre_release_tests.py | 15:13 |
dhellmann | you have to have everything checked out already for that to work | 15:14 |
bnemec | dhellmann: Okay, I'll look into that today. | 15:14 |
bnemec | dhellmann: I may not be around much during the meeting. Somebody decided to schedule another one off meeting for Monday morning. :-/ | 15:15 |
dhellmann | bnemec: :-/ | 15:15 |
rpodolyaka | dhellmann: ah, didn't know that, thanks! but viktors has hardware for that ;) | 15:15 |
dhellmann | bnemec: ok, I can do the release if you have a few minutes to sanity check the need | 15:15 |
dhellmann | rpodolyaka: yeah, hardware is the tricky part :-) | 15:15 |
inc0_ | cya guys, gtg | 15:15 |
haypo | hi. i don't understand why people send new versions of a patch just after i review it? | 15:15 |
haypo | ex: i voted +2 to https://review.openstack.org/#/c/154409/ and then xek just posted a new version | 15:16 |
haypo | there are 7 versions of the patch set. and no changelog for each changelog. it's not convinient :-/ | 15:16 |
haypo | is there a way to see the change between two versions of a change set? except of manually comparing them? | 15:16 |
xek | haypo, hi, I just added a line in the commit message, like you suggested | 15:17 |
*** ihrachyshka has joined #openstack-oslo | 15:17 | |
haypo | xek: my questions are not specific to your issue. i have the problem every day :) | 15:18 |
xek | a way of reviewing the changes between patches would be nice | 15:18 |
haypo | it's just annoying to have to vote 3 times for exactly the same patch :-p | 15:18 |
viktors | rpodolyaka, dhellmann: ok, I'll do | 15:19 |
bnemec | haypo: xek: There should be some links at the top of the diff for each file that say "Patch Set Base 1 2 3.....17" If you select the two versions you want to compare it will only show the differences between those two. | 15:19 |
viktors | dhellmann: do we have meeting today as usual? | 15:19 |
*** inc0_ has quit IRC | 15:20 | |
haypo | bnemec: oh wait, i never noticed that they are "Patch Set .. " links at left too | 15:20 |
dhellmann | haypo: if you set the "reference version" in gerrit, it will show the diff of the current patch against that version. So you can set it to N-1 and see the changes between N-1 and N, or you can set it to N-2, etc. It defaults to the first patch. | 15:20 |
dhellmann | viktors: yes | 15:20 |
haypo | i see https://review.openstack.org/#/c/154409/6..7//COMMIT_MSG,unified | 15:20 |
haypo | cool | 15:21 |
bnemec | haypo: Yep. It's still a good idea for people to leave comments saying what they changed if they push new patch sets without prompting though. | 15:21 |
bnemec | Anything that makes the reviewer's life easier gets a +1 from me. :-) | 15:21 |
xek | bnemec, thanks :) | 15:22 |
bnemec | xek: np | 15:22 |
haypo | sometimes, i think that it would be faster to just accept the patch instead of having the dance of new change set => vote => conflict => rebase => vote => conflict => ... :) | 15:22 |
*** jecarey has joined #openstack-oslo | 15:22 | |
haypo | (olso_versionedobject is moving fast ;-)) | 15:22 |
*** jecarey_ has joined #openstack-oslo | 15:23 | |
viktors | zzzeek: hi! This patch may be interesting for you - https://review.openstack.org/#/c/154521/ (Implement online schema migrations) | 15:26 |
zigo | dhellmann: http://paste.debian.net/149738/ | 15:26 |
zigo | dhellmann: As I wrote previously, we still have an issue with Python3 and oslo.utils: unit tests can't be run with it. | 15:27 |
*** jecarey has quit IRC | 15:28 | |
dhellmann | zigo: I *just* released 1.3.0 with the packaging fix. Can you try that version? | 15:28 |
*** e0ne is now known as e0ne_ | 15:28 | |
zigo | dhellmann: Will it work for Juno? Because the global-reqs for Juno are saying <= 1.2.1 | 15:28 |
dhellmann | zigo: no, it is not meant to be used for juno | 15:28 |
zigo | dhellmann: My issue currently is that I can't upload Kilo stuff in Experimental, as this would overwrite Juno... :( | 15:29 |
zigo | dhellmann: And I need oslo.utils as a dependency for other stuff, like debtcollector. | 15:29 |
dhellmann | zigo: nothing in juno should be using debtcollector | 15:29 |
zigo | dhellmann: I know, that's my own kitchen and I shouldn't bother anyone with it. | 15:29 |
zigo | dhellmann: Yeah, I just want to upload it so that it goes in the NEW queue early enough, so it gets a chance to be approved by FTP masters before Kilo is released. | 15:30 |
zigo | dhellmann: Anyway, could you point to me the packaging fix commit, or is it burried with so many other stuff? | 15:30 |
dhellmann | let me look | 15:31 |
zigo | Thanks. | 15:31 |
dhellmann | zigo: http://git.openstack.org/cgit/openstack/oslo.utils/commit/?id=942cf060a1ece4999234191da19aea48e005f740 | 15:31 |
zigo | .oO(if only we had Debian PPAMAIN, my troubles with nowhere to upload would be over...) | 15:31 |
zigo | dhellmann: This will not fix unit testing, will it? | 15:32 |
dhellmann | zigo: if we need to create a stable/juno branch of oslo.utils and release a 1.2.2 or something we can do that | 15:32 |
*** ihrachyshka has quit IRC | 15:32 | |
zigo | This fixeds the setup.py install though... | 15:32 |
dhellmann | zigo: it should ensure that the files missing from the sdist are -- right | 15:32 |
zigo | Yeah, got that point ! :) | 15:32 |
zigo | dhellmann: Though what I'm trying to fix is unit test listing... | 15:34 |
zigo | (in python3) | 15:34 |
*** pradk has joined #openstack-oslo | 15:35 | |
* zigo is trying to patch .testr.conf | 15:35 | |
*** e0ne_ has quit IRC | 15:38 | |
dhellmann | zigo: oslo.utils is tested under python 3, so maybe this is a different issue than I thought. Do you have a traceback or something? | 15:42 |
dhellmann | bnemec: how about an oslo.serialization release, too? | 15:42 |
zigo | dhellmann: That's the same issue which we had before moving to no namespace: if there's *any* oslo lib installed in the system (in this case, oslo.config and oslo.i18n, which are build-depends), then the namespace fails in Python3. | 15:43 |
dhellmann | zigo: ok, well, that doesn't have anything to do with python 3. | 15:44 |
bnemec | dhellmann: Yep, looks like they could both use releases. | 15:44 |
*** ihrachyshka has joined #openstack-oslo | 15:44 | |
dhellmann | that's just an issue with the namespace package, and AFAICT the only fix for that right now is to not install any of the libraries on the build machine until we can get all of them out of the namespace package | 15:44 |
dhellmann | bnemec: ok, do you need a chance to look them over or should I go ahead and release them? | 15:45 |
zigo | dhellmann: Which I can do with Build-Conflicts, though *not* when there's build-depends (here, oslo.config and oslo.i18n, when building oslo.utils) | 15:45 |
dhellmann | zigo: I'm not sure of the difference. Why does building oslo.utils depend on oslo.config? just because of the tests? | 15:46 |
zigo | dhellmann: http://paste.debian.net/149758/ | 15:46 |
zigo | dhellmann: Yes, because of tests. | 15:46 |
*** tsekiyam_ has quit IRC | 15:46 | |
zigo | Hum... | 15:46 |
dhellmann | zigo: ok. I'm not sure what to say. We're working on getting rid of the ns packages, but I'm not sure what to tell you to do in the mean time. | 15:47 |
zigo | dhellmann: I'm just telling you that you *cannot* do tests.test_warning.DeprecationWarningTest | 15:48 |
zigo | Let me try something else again. | 15:48 |
dhellmann | zigo: is there an environment variable we could check for to skip that test while you're packaging? something that is only set for debian packaging builds? | 15:48 |
bnemec | dhellmann: I don't see any issues with releasing them. | 15:49 |
dhellmann | bnemec: ok, I'll do those after the meeting | 15:50 |
*** tsekiyama has joined #openstack-oslo | 15:50 | |
* zigo is checking | 15:51 | |
dhellmann | zigo: if that's easy to do, and easier than you ignoring that one test file, then we can put the needed changes in all the libs | 15:51 |
zigo | dhellmann: I'm just trying to find a *smart* way to do stuff so that it works in all cases, and I'm failing at doing that. | 15:52 |
zigo | :( | 15:52 |
zigo | dhellmann: Patching your upstream code and/or .testr.conf is what I'm trying to avoid. | 15:52 |
*** mtanino has joined #openstack-oslo | 15:53 | |
dhellmann | zigo: ok, I'm trying to be a bit flexible :-) | 15:53 |
zigo | dhellmann: I know you are, and I want to thank you so much, I'm just trying to figure out what to do... :) | 15:54 |
dhellmann | zigo: ok, let me know what you find | 15:55 |
zigo | dhellmann: Currently, here's the issue: | 15:55 |
zigo | http://paste.debian.net/149765/ | 15:56 |
zigo | (I've disabled python 2.7 tests, which are passing ok) | 15:56 |
zigo | It's looking like subunit will list all tests whatever I put as argument for testr. | 15:56 |
dhellmann | zigo: there are arguments to tell it where to start scanning for tests | 15:57 |
zigo | dhellmann: Is this in the .testr.conf, or can it be overridden? | 15:58 |
dhellmann | zigo: it would help if you could make it show what the import error really is by just running or importing the test script directly | 15:58 |
dhellmann | zigo: it's in that file, but I don't know how you would override it | 15:58 |
dhellmann | meeting time coming up | 15:59 |
zigo | Well, tests.tests_encodeutils tries to import oslo.utils, and fails... | 15:59 |
dhellmann | is oslo.utils present and installed? | 15:59 |
dhellmann | this should all work the same way under python 2 and 3 | 15:59 |
*** david-lyle_afk is now known as david-lyle | 16:01 | |
*** jecarey_ is now known as jecarey | 16:01 | |
*** palendae has quit IRC | 16:02 | |
*** palendae has joined #openstack-oslo | 16:03 | |
zigo | dhellmann: Of course, it's *NOT* present and installed, it can't build-depends on itself. Anyway, seems patching .testr.conf does the trick, though I would have prefer avoiding it. | 16:10 |
zigo | That, plus explicitly writting that I want to do testr run --subunit 'oslo_utils.*' | 16:10 |
zigo | Which is really fine. | 16:10 |
*** jgrimm is now known as zz_jgrimm | 16:11 | |
*** zz_jgrimm is now known as jgrimm | 16:12 | |
openstackgerrit | Merged openstack/oslo.vmware: Add missing links to README https://review.openstack.org/156237 | 16:18 |
*** hogepodge has quit IRC | 16:18 | |
*** sreshetnyak has quit IRC | 16:21 | |
*** sreshetnyak has joined #openstack-oslo | 16:22 | |
*** hogepodge has joined #openstack-oslo | 16:23 | |
openstackgerrit | Merged openstack/taskflow: Add retries to fetching the zookeeper server version https://review.openstack.org/155950 | 16:25 |
openstackgerrit | Julien Danjou proposed openstack/oslo.utils: Deprecate strtime https://review.openstack.org/148500 | 16:26 |
*** zigo has quit IRC | 16:26 | |
*** zigo has joined #openstack-oslo | 16:31 | |
*** e0ne has joined #openstack-oslo | 16:38 | |
*** ramishra has joined #openstack-oslo | 16:38 | |
*** ramishra has left #openstack-oslo | 16:38 | |
openstackgerrit | Merged openstack/oslo.policy: Do not log on missing or empty policy_dirs https://review.openstack.org/154742 | 16:47 |
*** i159 has quit IRC | 16:50 | |
*** dulek has quit IRC | 16:52 | |
*** vigneshvar has joined #openstack-oslo | 16:53 | |
*** e0ne is now known as e0ne_ | 16:56 | |
*** e0ne_ is now known as e0ne | 17:00 | |
amrith | dhellmann, is this the right place to ask a python question (that is specific to openstack and may have an OSLO answer?) | 17:02 |
dhellmann | amrith: It's hard to say without knowing what the question is. :-) | 17:03 |
amrith | ok, 1 paste bomb coming up. ;) | 17:03 |
dhellmann | amrith: if it's that big, maybe the mailing list is a better place | 17:05 |
amrith | <paste-bomb> | 17:05 |
amrith | there are tons of places in trove where we do imports. | 17:05 |
amrith | these are of the form | 17:05 |
amrith | from x import y | 17:05 |
amrith | from x import y as z | 17:05 |
amrith | import x | 17:06 |
amrith | I'd like to restructure the code and move modules (x) around within the code base. | 17:06 |
amrith | And I expect that over time these same modules will move again and again. | 17:06 |
amrith | Basically we're trying to create a notion of "stable", "experimental" and "preview" guest agents. | 17:06 |
amrith | To that end, I'd like to make the 'x' a string and dynamically load 'x' from that string. | 17:06 |
amrith | That makes it easier for me to fix all the code in the future when I move a module from point A to point B; fix the string and stuff magically works. | 17:06 |
dansmith | dhellmann: the unit tests don't end up in the release such that a project like nova could import/use stuff in tests/ right? | 17:06 |
amrith | With importlib I can deal with the third and first kinds of imports. Having trouble with the second. Was wondering whether (a) there's a simple reference you could recommend and (b) is there any OSLO support for this kind of thing. | 17:06 |
amrith | </paste-bomb> | 17:06 |
amrith | oops | 17:06 |
amrith | just overlapped with your question. | 17:06 |
amrith | yes, maybe ML | 17:06 |
dhellmann | dansmith: they do, but we do not expect anyone to use anything in oslo_foo/tests/ and so we don't provide a stable API for them | 17:06 |
dansmith | dhellmann: okay, so there is some object-sanity and object-version-hash test stuff that we really should export for other projects to use so they don't recreate the wheel.. should that stuff live outside of tests/ for that reason? | 17:07 |
dhellmann | amrith: can you use stevedore with separate namespaces? | 17:07 |
* amrith ponders | 17:08 | |
dhellmann | dansmith: good question, I think we do something like that in oslo.db where we provide a base class for tests | 17:08 |
amrith | dhellmann, let me look. not sure but I'll look. | 17:08 |
dhellmann | dansmith: in the other libs we've been able to just use fixtures, I think, but it sounds like this wouldn't fit into that sort of structure? | 17:08 |
dansmith | dhellmann: yeah, it's not really a fixture sort of thing | 17:09 |
dhellmann | dansmith: see oslo_db/sqlalchemy/test_*.py | 17:09 |
dhellmann | although IIRC, using test_* as the filename caused issues, so maybe we can come up with a name that doesn't match the regex testr uses to load test cases | 17:09 |
dansmith | dhellmann: hmm, sqlalchemy/test/test_base.py seems to just import * from itself.. am I missing something? | 17:10 |
dhellmann | dansmith: oslo_db not oslo/db | 17:11 |
dansmith | dhellmann: okay | 17:11 |
dhellmann | dansmith: http://git.openstack.org/cgit/openstack/oslo.db/tree/oslo_db/sqlalchemy/test_base.py | 17:11 |
dansmith | yeah | 17:11 |
dansmith | okay, I'll do something like this, without the word test in the path | 17:12 |
*** ihrachyshka has quit IRC | 17:12 | |
dhellmann | amrith: stevedore may not help you if you're needing to update the imports inside the experimental modules themselves | 17:12 |
dhellmann | amrith: it would be better to organize the code in a way that doesn't have to change when the experimental status of the driver changes | 17:12 |
dhellmann | dansmith: sounds good | 17:13 |
*** noelbk has joined #openstack-oslo | 17:18 | |
openstackgerrit | Merged openstack/oslo-incubator: Switch from oslo.config to oslo_config https://review.openstack.org/155869 | 17:23 |
*** dtantsur has quit IRC | 17:25 | |
*** miqui_away has quit IRC | 17:25 | |
*** mtreinish has quit IRC | 17:25 | |
*** tsufiev has quit IRC | 17:25 | |
*** JoshNang has quit IRC | 17:25 | |
*** SergeyLukjanov has quit IRC | 17:25 | |
*** rharwood has quit IRC | 17:25 | |
*** dtantsur has joined #openstack-oslo | 17:31 | |
*** miqui_away has joined #openstack-oslo | 17:31 | |
*** mtreinish has joined #openstack-oslo | 17:31 | |
*** tsufiev has joined #openstack-oslo | 17:31 | |
*** JoshNang has joined #openstack-oslo | 17:31 | |
*** SergeyLukjanov has joined #openstack-oslo | 17:31 | |
*** rharwood has joined #openstack-oslo | 17:31 | |
dhellmann | jd__, harlowja_away, dims__: is https://review.openstack.org/#/c/154547/6 a backwards-incompatible change to the msgpack format? | 17:35 |
jd__ | dhellmann: yes, though we can make it read old format if needed – i'm not sure we released it though? | 17:36 |
dhellmann | jd__: ah, good point, we haven't released the msgpack serializer yet | 17:37 |
*** harlowja_at_home has joined #openstack-oslo | 17:37 | |
dhellmann | jd__: I'm doing a release for oslo.serialization right now | 17:37 |
jd__ | maybe we could mark it experimental as I expect us to change a few things | 17:37 |
jd__ | ok :) | 17:37 |
jd__ | dhellmann: don't you want to review my patches first? | 17:37 |
jd__ | dhellmann: https://review.openstack.org/#/q/status:open+project:openstack/oslo.serialization+branch:master+topic:jd/serialize-set,n,z | 17:38 |
dhellmann | jd__: ok, I see 2 are already approved so let me look at the other | 17:38 |
*** andrearosa has quit IRC | 17:39 | |
dhellmann | dims__, bnemec, flaper87 : if you have a minute to look at https://review.openstack.org/#/c/147194/ we can include it in the serialization release | 17:39 |
*** andreykurilin_ has quit IRC | 17:40 | |
dims__ | 147194 - Done | 17:42 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow turning off the version check https://review.openstack.org/156303 | 17:50 |
*** terryw is now known as otherwiseguy | 17:50 | |
*** hogepodge has quit IRC | 17:53 | |
*** stevemar has joined #openstack-oslo | 17:53 | |
*** hogepodge has joined #openstack-oslo | 17:54 | |
*** dtantsur is now known as dtantsur|afk | 17:56 | |
harlowja_at_home | jd__, if u get some time let me know what u think of https://review.openstack.org/#/c/156013/ | 17:59 |
harlowja_at_home | its a nice little change i think | 17:59 |
*** amotoki_ has joined #openstack-oslo | 18:04 | |
*** e0ne has quit IRC | 18:05 | |
*** amotoki_ has quit IRC | 18:08 | |
*** rushiagr is now known as rushiagr_away | 18:11 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Revert "Add retries to fetching the zookeeper server version" https://review.openstack.org/156317 | 18:13 |
openstackgerrit | Merged openstack/oslo.concurrency: Ability to set working directory https://review.openstack.org/155847 | 18:17 |
openstackgerrit | Merged openstack/oslo.serialization: Use default in dumps() https://review.openstack.org/147194 | 18:28 |
openstackgerrit | Merged openstack/oslo.serialization: jsonutils: support UUID encoding https://review.openstack.org/147198 | 18:29 |
openstackgerrit | Merged openstack/oslo.serialization: jsonutils: add set() tests and simplify recursive code https://review.openstack.org/147195 | 18:29 |
*** MasterPiece has joined #openstack-oslo | 18:38 | |
*** andreykurilin_ has joined #openstack-oslo | 18:46 | |
*** e0ne has joined #openstack-oslo | 18:56 | |
*** crc32 has joined #openstack-oslo | 19:01 | |
*** crc32 has quit IRC | 19:14 | |
openstackgerrit | Merged openstack/taskflow: adding check for str/unicode type in requires https://review.openstack.org/156094 | 19:15 |
*** dims__ has quit IRC | 19:25 | |
openstackgerrit | Merged openstack/taskflow: Allow turning off the version check https://review.openstack.org/156303 | 19:25 |
*** noelbk has quit IRC | 19:31 | |
openstackgerrit | Marian Horban proposed openstack/oslo-incubator: Using of waitpid system call was optimized https://review.openstack.org/156345 | 19:39 |
openstackgerrit | Merged openstack/taskflow: Revert "Add retries to fetching the zookeeper server version" https://review.openstack.org/156317 | 19:44 |
*** noelbk has joined #openstack-oslo | 19:47 | |
*** MasterPiece has quit IRC | 19:49 | |
*** amrith is now known as _amrith_ | 19:55 | |
jogo | zzzeek: nice blog post post, I really enjoyed it | 19:55 |
*** achanda has joined #openstack-oslo | 19:58 | |
openstackgerrit | Marian Horban proposed openstack/oslo-incubator: Using of waitpid system call was optimized https://review.openstack.org/156345 | 20:08 |
*** achanda has quit IRC | 20:09 | |
*** andreykurilin_ has quit IRC | 20:21 | |
*** andreykurilin_ has joined #openstack-oslo | 20:21 | |
*** dims__ has joined #openstack-oslo | 20:25 | |
*** miqui_away has quit IRC | 20:30 | |
*** miqui_ has joined #openstack-oslo | 20:30 | |
*** andreykurilin_ has quit IRC | 20:30 | |
*** dims__ has quit IRC | 20:30 | |
*** andreykurilin_ has joined #openstack-oslo | 20:31 | |
*** harlowja_at_home has quit IRC | 20:31 | |
zzzeek | jogo: thank! | 20:34 |
zzzeek | s! | 20:34 |
*** achanda has joined #openstack-oslo | 20:45 | |
*** dulek has joined #openstack-oslo | 20:45 | |
*** samueldmq has joined #openstack-oslo | 20:54 | |
*** samueldmq has left #openstack-oslo | 20:54 | |
*** ajo has quit IRC | 20:55 | |
*** dulek has quit IRC | 20:56 | |
*** devlaps has joined #openstack-oslo | 21:01 | |
*** achanda has quit IRC | 21:06 | |
*** jgrimm is now known as zz_jgrimm | 21:12 | |
*** dims__ has joined #openstack-oslo | 21:33 | |
*** dims_ has joined #openstack-oslo | 21:34 | |
*** dims__ has quit IRC | 21:38 | |
*** himangi has joined #openstack-oslo | 21:49 | |
*** andreykurilin_ has quit IRC | 21:56 | |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Remove internal items from public namespace https://review.openstack.org/156393 | 22:18 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize the indirection_api interface https://review.openstack.org/156394 | 22:18 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Remove Nova objects module registration code https://review.openstack.org/156395 | 22:18 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Add conditional object registration https://review.openstack.org/156396 | 22:18 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize remote testing infrastructure https://review.openstack.org/156397 | 22:18 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize object hash-based change detection https://review.openstack.org/156398 | 22:18 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize object dependency change detection https://review.openstack.org/156399 | 22:18 |
dansmith | dims_: jaypipes: ^ | 22:21 |
dansmith | I'm making my way through the work items | 22:21 |
*** himangi has quit IRC | 22:22 | |
dims_ | dansmith: ack. heading out to get some pizza and will review after that | 22:23 |
dansmith | dims_: I'll allow it | 22:23 |
dims_ | thanks :) | 22:23 |
openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Use single quotes consistently https://review.openstack.org/156404 | 22:27 |
openstackgerrit | Steve Martinelli proposed openstack/oslo.policy: Fix minor spelling issues in oslo.policy https://review.openstack.org/156405 | 22:27 |
jaypipes | dansmith: will try to get to those in a bit. | 22:28 |
dansmith | they're not critical | 22:28 |
dansmith | and I'm probably failing some py3 stuff still | 22:28 |
*** achanda has joined #openstack-oslo | 22:34 | |
*** mriedem has quit IRC | 22:46 | |
*** e0ne has quit IRC | 22:50 | |
*** dims_ has quit IRC | 22:51 | |
*** dims__ has joined #openstack-oslo | 22:51 | |
*** kgiusti has left #openstack-oslo | 22:52 | |
*** trown is now known as trown|outttypeww | 22:52 | |
*** tsekiyama has quit IRC | 22:58 | |
*** salv-orlando has joined #openstack-oslo | 23:02 | |
*** tsekiyama has joined #openstack-oslo | 23:03 | |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize object dependency change detection https://review.openstack.org/156399 | 23:07 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize object hash-based change detection https://review.openstack.org/156398 | 23:07 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize remote testing infrastructure https://review.openstack.org/156397 | 23:07 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Add conditional object registration https://review.openstack.org/156396 | 23:07 |
*** cdent has quit IRC | 23:09 | |
*** achanda has quit IRC | 23:21 | |
*** dims_ has joined #openstack-oslo | 23:30 | |
*** dims__ has quit IRC | 23:32 | |
*** gordc has quit IRC | 23:32 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo-specs: Open specs repository for Liberty proposals https://review.openstack.org/156418 | 23:44 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize object dependency change detection https://review.openstack.org/156399 | 23:47 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize object hash-based change detection https://review.openstack.org/156398 | 23:47 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Generalize remote testing infrastructure https://review.openstack.org/156397 | 23:47 |
*** dims__ has joined #openstack-oslo | 23:47 | |
*** dims_ has quit IRC | 23:47 | |
openstackgerrit | Merged openstack/oslo-specs: Open specs repository for Liberty proposals https://review.openstack.org/156418 | 23:49 |
*** himangi has joined #openstack-oslo | 23:50 | |
*** dims__ has quit IRC | 23:56 | |
*** dims_ has joined #openstack-oslo | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!