| *** dims has quit IRC | 00:08 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:24 | |
| *** tsekiyama has quit IRC | 00:28 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Experimentally & optionally use tooz to find/advertise workers https://review.openstack.org/151495 | 00:28 |
|---|---|---|
| openstackgerrit | Eric Brown proposed openstack/oslo.vmware: Change use of random to random.SystemRandom https://review.openstack.org/156889 | 00:39 |
| *** dims has joined #openstack-oslo | 00:42 | |
| *** mtanino has joined #openstack-oslo | 00:42 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Experimentally & optionally use tooz to find/advertise workers https://review.openstack.org/151495 | 00:43 |
| *** ChuckC has quit IRC | 00:56 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 01:10 | |
| *** devlaps has quit IRC | 01:11 | |
| *** david-lyle is now known as david-lyle_afk | 01:19 | |
| *** achanda has quit IRC | 01:21 | |
| *** noelbk has quit IRC | 01:39 | |
| *** tsekiyam_ has quit IRC | 01:48 | |
| *** jecarey has quit IRC | 01:50 | |
| *** himangi has joined #openstack-oslo | 02:03 | |
| *** dims has quit IRC | 02:14 | |
| openstackgerrit | Min Pae proposed openstack/taskflow: Added a map and a reduce task https://review.openstack.org/157677 | 02:51 |
| *** yamahata has quit IRC | 03:06 | |
| *** MasterPiece has quit IRC | 03:11 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow periodics to run in parallel (WIP/Exploratory) https://review.openstack.org/158092 | 03:12 |
| *** stevemar has quit IRC | 03:55 | |
| *** amotoki has joined #openstack-oslo | 03:55 | |
| *** stevemar has joined #openstack-oslo | 03:55 | |
| *** himangi has quit IRC | 03:55 | |
| *** harlowja is now known as harlowja_away | 04:14 | |
| *** harlowja_away is now known as harlowja | 04:15 | |
| *** devlaps has joined #openstack-oslo | 04:17 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow periodics to run in parallel (WIP/Exploratory) https://review.openstack.org/158092 | 04:50 |
| *** sputnik13 has quit IRC | 04:55 | |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Allow providing a logger to save_and_reraise_exception https://review.openstack.org/158158 | 05:06 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow periodics to run in parallel (WIP/Exploratory) https://review.openstack.org/158092 | 05:11 |
| *** devlaps has quit IRC | 05:17 | |
| *** achanda has joined #openstack-oslo | 05:34 | |
| *** harlowja is now known as harlowja_away | 06:11 | |
| *** andreykurilin_ has joined #openstack-oslo | 06:14 | |
| *** sputnik13 has joined #openstack-oslo | 06:24 | |
| *** sputnik13 has quit IRC | 06:26 | |
| *** sputnik13 has joined #openstack-oslo | 06:34 | |
| *** andreykurilin_ has quit IRC | 06:44 | |
| *** rushiagr_away is now known as rushiagr | 06:49 | |
| *** sputnik13 has quit IRC | 06:52 | |
| openstackgerrit | Merged openstack/taskflow: Refactor parts of the periodic worker https://review.openstack.org/158096 | 06:58 |
| *** sputnik13 has joined #openstack-oslo | 07:05 | |
| openstackgerrit | Merged openstack/taskflow: Use oslo.utils encodeutils for encode/decode functions https://review.openstack.org/158143 | 07:05 |
| openstackgerrit | Merged openstack/taskflow: Move 'provides' and 'name' to instance attributes https://review.openstack.org/155060 | 07:06 |
| *** sputnik13 has quit IRC | 07:08 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/oslo.config: Add exception handling for entry points https://review.openstack.org/153863 | 07:12 |
| *** sputnik13 has joined #openstack-oslo | 07:14 | |
| *** rushiagr is now known as rushiagr_away | 07:42 | |
| *** e0ne has joined #openstack-oslo | 07:50 | |
| *** dulek has joined #openstack-oslo | 07:59 | |
| *** sputnik13 has quit IRC | 07:59 | |
| *** sputnik13 has joined #openstack-oslo | 08:00 | |
| *** i159 has joined #openstack-oslo | 08:31 | |
| *** dtantsur|afk is now known as dtantsur | 08:37 | |
| *** achanda has quit IRC | 08:42 | |
| openstackgerrit | Valeriy Ponomaryov proposed openstack/oslo.config: Add exception handling for entry points https://review.openstack.org/153863 | 08:46 |
| *** achanda has joined #openstack-oslo | 08:49 | |
| *** ajo has joined #openstack-oslo | 08:51 | |
| *** vigneshvar has joined #openstack-oslo | 08:53 | |
| *** burgobianco has quit IRC | 09:04 | |
| *** achanda has quit IRC | 09:06 | |
| *** rpodolyaka_afk is now known as rpodolyaka | 09:08 | |
| *** sputnik13 has quit IRC | 09:15 | |
| *** SridharGaddam has joined #openstack-oslo | 09:19 | |
| *** viktors|afk is now known as viktors | 09:20 | |
| *** salv-orlando has joined #openstack-oslo | 09:21 | |
| *** sputnik13 has joined #openstack-oslo | 09:22 | |
| *** stevemar has quit IRC | 09:34 | |
| *** i159 has quit IRC | 09:35 | |
| *** openstackgerrit has quit IRC | 09:36 | |
| *** openstackgerrit has joined #openstack-oslo | 09:36 | |
| *** i159 has joined #openstack-oslo | 09:37 | |
| *** himangi has joined #openstack-oslo | 09:40 | |
| *** jaosorior has joined #openstack-oslo | 09:50 | |
| *** takedakn has joined #openstack-oslo | 09:59 | |
| *** harlowja_away has quit IRC | 10:04 | |
| *** ihrachyshka has joined #openstack-oslo | 10:06 | |
| *** khivin has joined #openstack-oslo | 10:08 | |
| *** himangi has quit IRC | 10:08 | |
| openstackgerrit | Yuriy Nesenenko proposed openstack/oslo.config: Fix cfg.py checks list_config_files if it is empty https://review.openstack.org/157454 | 10:13 |
| *** himangi has joined #openstack-oslo | 10:33 | |
| *** exploreshaifali has joined #openstack-oslo | 10:35 | |
| *** takedakn has quit IRC | 10:57 | |
| *** himangi has quit IRC | 10:58 | |
| *** subscope has quit IRC | 11:05 | |
| *** shardy is now known as shardy_afk | 11:13 | |
| *** subscope has joined #openstack-oslo | 11:17 | |
| *** salv-orlando has quit IRC | 11:18 | |
| *** dims has joined #openstack-oslo | 11:20 | |
| *** takedakn has joined #openstack-oslo | 11:31 | |
| *** takedakn has quit IRC | 11:32 | |
| *** takedakn has joined #openstack-oslo | 11:32 | |
| *** takedakn has quit IRC | 11:36 | |
| dims | rpodolyaka: dhellmann: mdbooth on nova channel found something else in oslo.db trunk that may break nova when released. he is filing a bug or review shortly | 11:36 |
| *** takedakn has joined #openstack-oslo | 11:40 | |
| *** takedakn has quit IRC | 11:40 | |
| *** exploreshaifali has quit IRC | 11:40 | |
| *** sputnik13 has quit IRC | 11:41 | |
| rpodolyaka | dims: it's the same thing we talked about yesterday | 11:42 |
| rpodolyaka | dims: I have a patch on review https://review.openstack.org/#/c/158364/ | 11:42 |
| *** sputnik13 has joined #openstack-oslo | 11:42 | |
| *** exploreshaifali has joined #openstack-oslo | 11:43 | |
| dims | rpodolyaka: i thought so, but he said it's different! | 11:43 |
| *** sputnik13 has quit IRC | 11:44 | |
| rpodolyaka | dims: heh :) | 11:45 |
| dims | thanks, looks like you both are in sync, haha | 11:47 |
| *** cdent has joined #openstack-oslo | 11:48 | |
| *** himangi has joined #openstack-oslo | 11:54 | |
| *** exploreshaifali has quit IRC | 12:08 | |
| *** salv-orlando has joined #openstack-oslo | 12:10 | |
| openstackgerrit | Matthew Booth proposed openstack/oslo.db: Revert "Organize provisioning to use testresources" https://review.openstack.org/158662 | 12:10 |
| *** eezhova has joined #openstack-oslo | 12:25 | |
| flaper87 | do you guys know if there's a type of flow in taskflow that doesn't cause a rollback ? | 12:25 |
| flaper87 | I mean, when one of the tasks fails | 12:26 |
| flaper87 | ah mmh, it's probably done at a task level | 12:27 |
| flaper87 | using Retry | 12:27 |
| dims | flaper87: too early for harlowja :) | 12:59 |
| flaper87 | dims: yeah, I didn't want to sound rude and just say "I'll wait for harlowja" | 13:00 |
| flaper87 | :D | 13:00 |
| dims | hehe | 13:01 |
| *** kgiusti has joined #openstack-oslo | 13:03 | |
| dhellmann | rpodolyaka, dims : I missed most of the discusssion of oslo.db yesterday. I see mdbooth's revert patch there, is that the direction we want to take? | 13:04 |
| rpodolyaka | dhellmann: we are currently arguing in #openstack-nova... | 13:05 |
| dims | dhellmann: no | 13:06 |
| dhellmann | rpodolyaka: I'll join you | 13:06 |
| rpodolyaka | dhellmann: the problem is we didn't make DbFixture private in the first place and mdbooth has started to use it (in his patch series that hasn't been merged yet) and the fixture is not usable without DbTestCase | 13:07 |
| rpodolyaka | dhellmann: so basically now we are arguing what should be the public API oslo.db exposes - a base test case or a fixture | 13:07 |
| rpodolyaka | dhellmann: while I see the point of the fixture it's not the way it is right now | 13:08 |
| rpodolyaka | dhellmann: and we really meant to expose only DbTestCase and it's subclasses (PostgreSQL/MySQL opportunistic test cases) | 13:08 |
| *** himangi has quit IRC | 13:09 | |
| rpodolyaka | dhellmann: so mdbooth wants us to do a revert of a testresources patch and redesign the fixture a bit, while I suggested to merge https://review.openstack.org/#/c/158364/3 to nova and unblock oslo.db release | 13:09 |
| *** vigneshvar has quit IRC | 13:13 | |
| *** mdbooth has joined #openstack-oslo | 13:16 | |
| * mdbooth waves | 13:17 | |
| dhellmann | hi, mdbooth | 13:17 |
| *** exploreshaifali has joined #openstack-oslo | 13:17 | |
| dhellmann | rpodolyaka: could we fix DbFixture by making it take the schema as an argument? | 13:17 |
| dhellmann | or do you *want* it to be private? | 13:17 |
| *** sreshetnyak has joined #openstack-oslo | 13:18 | |
| rpodolyaka | so I'd say the way it's written right now implies it to be private... | 13:18 |
| dhellmann | and multiple inheritance with test classes definitely can cause problems, so we'll want to spend some time thinking about how to address that | 13:18 |
| rpodolyaka | I see mdbooth point in actually making it 'public' and usable | 13:18 |
| dhellmann | rpodolyaka: what says that to you? just the implementation? | 13:18 |
| rpodolyaka | usable on its own, without DbTestCase | 13:18 |
| rpodolyaka | dhellmann: yes, implementation | 13:18 |
| mdbooth | I've actually used it. It is currently usable. | 13:19 |
| mdbooth | Well, it was. | 13:19 |
| dims | haha, in a review, not merged yet :) | 13:19 |
| mdbooth | dims: In 2 patches. | 13:19 |
| dhellmann | rpodolyaka: ok, well apparently we didn't signal that well enough :-) | 13:19 |
| rpodolyaka | we didn't :( | 13:19 |
| dhellmann | so the question is, is it something we do want to support? | 13:19 |
| mdbooth | But remember, I can't do those things if we let the breakage stand. | 13:20 |
| dims | dhellmann: right | 13:20 |
| dhellmann | not a big deal, we're learning | 13:20 |
| dhellmann | mdbooth: right now nothing is actually broken, right? so we're trying to agree on the path to a release that doesn't break | 13:20 |
| mdbooth | dhellmann: Right now my patch series is broken. | 13:20 |
| *** amotoki has quit IRC | 13:21 | |
| dims | dhellmann: i'd just block the usage of stuff we don't want people to use right now when it's not in anyone's trunk | 13:21 |
| mdbooth | It replaces nova custom db stuff with DbFixture | 13:21 |
| dhellmann | mdbooth: ok | 13:21 |
| rpodolyaka | dhellmann: so we might give it a try to put this https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/test_base.py#L90-L165 into DbFixture and add docs on how to use it and advertise that approach instead of inheritance | 13:21 |
| dhellmann | mdbooth: does it use both the fixture and the base class? | 13:21 |
| mdbooth | dhellmann: No, just the fixture. | 13:21 |
| mdbooth | Using the base class isn't likely to work | 13:22 |
| mdbooth | Not cleanly, anyway | 13:22 |
| dhellmann | rpodolyaka: ok, that sounds like a reasonable approach to at least try | 13:22 |
| dhellmann | mdbooth: that was my understanding, so I'm just making sure I didn't miss something in the scrollback earlier | 13:22 |
| dims | dhellmann: so we add _ to the base class | 13:22 |
| rpodolyaka | ok, so revert or change to nova first then? :) | 13:22 |
| dhellmann | what change in nova? | 13:22 |
| rpodolyaka | https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/test_base.py#L90-L165 | 13:23 |
| dhellmann | I thought we were talking about things still in progress? | 13:23 |
| rpodolyaka | oops, https://review.openstack.org/#/c/158364/3 | 13:23 |
| mdbooth | dhellmann: The same change also broke existing nova tests in another way. | 13:23 |
| mdbooth | But we have a nova patch for that. | 13:23 |
| * dims back in 20 mins, gotta drop off kids to school - too cold! | 13:23 | |
| rpodolyaka | dhellmann: yesterday's issue with deletion of attributes | 13:23 |
| dhellmann | yeah, I'm really not inclined to say that's a thing that's our fault | 13:24 |
| sdague | rpodolyaka: I very much like the idea of highly documented fixture | 13:24 |
| sdague | dhellmann: agreed, however it's fallout from multiple inheritance problem | 13:24 |
| sdague | which I think is the root issue that needs to be unwound | 13:24 |
| dhellmann | sdague: yeah, I think we'll need to have a policy of not using test base classes | 13:25 |
| dhellmann | unfortunately, we already have one out there | 13:25 |
| sdague | definitely not exporting functionality that way | 13:25 |
| *** salv-orlando has quit IRC | 13:25 | |
| dhellmann | right | 13:25 |
| sdague | exporting test facilities from libraries should really come as well documented fixtures | 13:25 |
| *** salv-orlando has joined #openstack-oslo | 13:26 | |
| sdague | honestly, I've been internally cleaning up the nova tree a ton here this cycle as well | 13:26 |
| dhellmann | how about this: 1. mark the current version of the fixture private 2. keep the existing test class as-is and deprecate it 3. release oslo.db 4. create a new public fixture with the features of both | 13:26 |
| dhellmann | step 3 relies on that nova patch, I guess | 13:27 |
| rpodolyaka | +1 | 13:27 |
| dhellmann | and of course 5. release oslo.db with the public supported fixture | 13:27 |
| mdbooth | I'm still -1 on that. | 13:27 |
| mdbooth | It was usable as a fixture, and now it's not. | 13:27 |
| mdbooth | I call that a regression. | 13:27 |
| sdague | mdbooth: but you'll get the fixture in a little bit, right? | 13:28 |
| dhellmann | mdbooth: look, I'm sorry, but we made a mistake and you've gotten caught up in it. We're going to work to fix that, but it's going to take a little time to get right. | 13:28 |
| mdbooth | sdague: I'd be happy to leave it as is until we get there. | 13:28 |
| *** gordc has joined #openstack-oslo | 13:28 | |
| mdbooth | That way there's no period of regression. | 13:28 |
| dhellmann | but we don't want anyone else to use it. | 13:28 |
| sdague | mdbooth: but it's not in tree regression | 13:28 |
| sdague | dhellmann: I think your plan is a reasonable one | 13:29 |
| mdbooth | My doomometer predicts this will never be fixed :) | 13:29 |
| dhellmann | rpodolyaka: do you have folks available to work on it this week? | 13:30 |
| mdbooth | My expection is that if we allow it to be broken now, it will never work | 13:30 |
| dhellmann | mdbooth: I find your lack of faith disturbing. :-) | 13:30 |
| mdbooth | dhellmann: We could just leave it, you know. What's the rush to get this patch back in? | 13:30 |
| mdbooth | Is there some specific feature depending on it? | 13:30 |
| rpodolyaka | dhellmann: I think me, viktors or zzzeek will give it a try just to prove mdbooth wrong :) | 13:30 |
| mdbooth | rpodolyaka: LOL. That's my favourite way to be wrong :) | 13:31 |
| dhellmann | mdbooth: 1. We do not want anyone else to use the fixture. 2. We have other projects waiting for unreleased fixes in the library, and have delayed a few weeks releasing now already. | 13:31 |
| dhellmann | so we want to first get to a point where nova's master branch won't break if we release, then release, then work on making this thing publicly consumable | 13:31 |
| mdbooth | I see where you're coming from, but I can't say I'm not disappointed | 13:32 |
| dhellmann | rpodolyaka: ok, good. please file a bp. I don't think you need a spec unless you want to work out the design details that way, but a bp will help all of us keep track of progress. | 13:32 |
| rpodolyaka | dhellmann: ok | 13:33 |
| * mdbooth abandons the ability to run db tests on MySQL :( | 13:33 | |
| dhellmann | mdbooth: I do understand. | 13:33 |
| dhellmann | mdbooth: how about if you give us a week before you give up hope? | 13:33 |
| mdbooth | I'll be watching :) | 13:34 |
| dhellmann | mdbooth: good, we can always use more reviewers | 13:34 |
| dhellmann | mdbooth: you could also, you know, help with the patch itself ;-) | 13:35 |
| *** jaypipes has quit IRC | 13:36 | |
| sdague | mdbooth: honestly, if we are talking about a couple of weeks here, you can keep your patch set up against the old fixture and work through issues | 13:41 |
| sdague | and once the new fixture is up, flip it over to use that | 13:41 |
| sdague | dhellmann: ok, so which patch do we need on the nova side again? | 13:42 |
| rpodolyaka | dhellmann: mdbooth: https://blueprints.launchpad.net/oslo.db/+spec/make-db-fixture-public | 13:42 |
| *** rushiagr_away is now known as rushiagr | 13:43 | |
| *** ChuckC has joined #openstack-oslo | 13:45 | |
| rpodolyaka | sdague: https://review.openstack.org/158364 | 13:46 |
| sdague | dhellmann: so we should deprecate oslotest base class as well, right? what is the prescribed correct way for that in an oslo lib at this point? | 13:56 |
| *** bknudson has joined #openstack-oslo | 13:57 | |
| dhellmann | sdague: I'll have to look at what that class does. I *thought* it just set up a few common fixtures, but if it has other features we'll see if they need to move to fixtures | 13:57 |
| dhellmann | rpodolyaka: thanks | 13:58 |
| sdague | well, looking at https://review.openstack.org/158364 we have to add the timeout bit a 3rd time because of the interactions between oslotest and nova base test classes | 13:58 |
| sdague | so I think we should just deprecate the oslotest base class and expose those things as fixtures | 13:59 |
| *** vigneshvar has joined #openstack-oslo | 13:59 | |
| dhellmann | sdague: yeah, that seems like it might be better. I had hoped that class would avoid the need for everyone to invent their own base, but if they're doing so anyway... | 14:01 |
| sdague | for stuff like tests, I kind of thing it's important that people invent their own base classes | 14:01 |
| sdague | because it's really important to be aware of everything that's happening here | 14:02 |
| dhellmann | that does make sense. the stuff in that base class came out of nova, iirc, and similar patterns were happening everywhere, so we thought having a single copy would be better. maybe tests are just different enough that way | 14:03 |
| * dims catching up on scrollback | 14:03 | |
| dims | yay, we have a plan | 14:04 |
| dhellmann | dims: I'm looking out of my window, and I think your delivery of snow was misdirected. Should I mark it "return to sender"? | 14:04 |
| dims | haha, it's now solid ice dhellmann, we could build a igloo in my backyard | 14:04 |
| dhellmann | dims: those are fun, you should! | 14:05 |
| sdague | it was -11 here this morning. I'm getting ready for spring :) | 14:05 |
| dhellmann | we have just a dusting, and it's supposed to rain later today, but then snow more tomorrow | 14:05 |
| dhellmann | I hope the store isn't out of bread by the time I get there :-) | 14:06 |
| dims | sdague: +10000000000000 | 14:06 |
| * dhellmann goes to find breakfast | 14:06 | |
| dims | dhellmann: so i learnt that we have to keep cash in the house in winter now apparently. clearing snow off roof etc are pure cash only business! | 14:07 |
| sdague | dims: interesting... :) | 14:07 |
| *** kgiusti has left #openstack-oslo | 14:07 | |
| *** dims has quit IRC | 14:13 | |
| *** dims has joined #openstack-oslo | 14:13 | |
| dhellmann | dims: avoiding taxes, I suppose? | 14:14 |
| *** vigneshvar has quit IRC | 14:21 | |
| *** amotoki has joined #openstack-oslo | 14:24 | |
| *** salv-orlando has quit IRC | 14:24 | |
| *** mtanino has quit IRC | 14:34 | |
| *** kgiusti has joined #openstack-oslo | 14:36 | |
| *** yamahata has joined #openstack-oslo | 14:36 | |
| dims | dhellmann: y | 14:42 |
| *** mriedem has joined #openstack-oslo | 14:47 | |
| openstackgerrit | Li Ma proposed openstack/oslo.messaging: ZeroMQ deployment guide https://review.openstack.org/130943 | 14:50 |
| *** exploreshaifali has quit IRC | 14:57 | |
| *** alexpilotti has quit IRC | 15:07 | |
| flaper87 | harlowja wake up, NOW! >.> | 15:12 |
| *** mfedosin has quit IRC | 15:14 | |
| *** mfedosin has joined #openstack-oslo | 15:14 | |
| *** daniel3_ has joined #openstack-oslo | 15:15 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:16 | |
| kragniz | flaper87: real people sleep | 15:16 |
| kragniz | not like these Mk 87 flaper robots | 15:16 |
| *** salv-orlando has joined #openstack-oslo | 15:17 | |
| flaper87 | kragniz: damn, I keep forgetting that :( | 15:18 |
| *** jecarey has joined #openstack-oslo | 15:19 | |
| *** prad has joined #openstack-oslo | 15:19 | |
| * bnemec is annoyed that Georgia is getting more snow than Minnesota | 15:22 | |
| *** jecarey has quit IRC | 15:23 | |
| *** mtanino has joined #openstack-oslo | 15:23 | |
| *** devlaps has joined #openstack-oslo | 15:24 | |
| *** devlaps has quit IRC | 15:24 | |
| * dhellmann packs up snow to send to bnemec | 15:37 | |
| bnemec | :-) | 15:38 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-specs: Dropping oslo-cache-using-dogpile spec https://review.openstack.org/158734 | 15:39 |
| dhellmann | morganfainberg: ^^ let me know if I'm wrong, please! | 15:39 |
| morganfainberg | you're right | 15:40 |
| morganfainberg | bye bye spec | 15:40 |
| morganfainberg | :( | 15:40 |
| dhellmann | morganfainberg: would you +1 the spec for the record? :-( | 15:40 |
| morganfainberg | yep | 15:40 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-specs: Dropping graduate-oslo-reports https://review.openstack.org/158736 | 15:42 |
| *** stevemar has joined #openstack-oslo | 15:43 | |
| *** david-lyle_afk is now known as david-lyle | 15:47 | |
| dhellmann | dims, bnemec, flaper87, jd__: I've submitted 2 spec removals for blueprints we aren't likely to be doing this cycle. I don't want to approve them without you all having a chance to see. ^^ | 15:48 |
| * flaper87 clicks | 15:49 | |
| bnemec | dhellmann: +2 to both | 15:49 |
| dims | yep me too | 15:49 |
| *** rushiagr is now known as rushiagr_away | 15:50 | |
| flaper87 | +2 to both | 15:50 |
| dhellmann | dims, bnemec, flaper87, jd__ : do any of you know solly's irc nick? | 15:54 |
| bnemec | dhellmann: sross I believe | 15:55 |
| dims | i see a directxman12 as well | 15:55 |
| bnemec | Oh yeah, that might be his public nick. | 15:57 |
| dhellmann | dims: thanks, I pinged him | 15:58 |
| dims | dansmith: one question inline - https://review.openstack.org/#/c/158359/1/oslo_versionedobjects/base.py,cm | 15:59 |
| *** enikanorov has joined #openstack-oslo | 16:00 | |
| dansmith | dims: just replied, thanks, good catch | 16:02 |
| *** jecarey has joined #openstack-oslo | 16:03 | |
| *** vigneshvar has joined #openstack-oslo | 16:21 | |
| *** tsekiyama has joined #openstack-oslo | 16:25 | |
| *** tsekiyama has quit IRC | 16:26 | |
| *** tsekiyama has joined #openstack-oslo | 16:26 | |
| bnemec | dhellmann: Your snow delivery just arrived here. :-) | 16:27 |
| dhellmann | bnemec: you're welcome! | 16:27 |
| *** daniel3_ has quit IRC | 16:30 | |
| *** yamahata has quit IRC | 16:38 | |
| *** i159 has quit IRC | 16:41 | |
| *** vigneshvar has quit IRC | 16:44 | |
| *** yamahata has joined #openstack-oslo | 17:02 | |
| dansmith | dims: somehow we lost test coverage of that path, so adding it back in found another bug. so, double thanks :) | 17:02 |
| dims | very cool | 17:02 |
| openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Allow subclasses to define the serialization namespaces https://review.openstack.org/158359 | 17:06 |
| *** exploreshaifali has joined #openstack-oslo | 17:07 | |
| *** ihrachyshka has quit IRC | 17:07 | |
| *** dtantsur is now known as dtantsur|afk | 17:08 | |
| *** vigneshvar has joined #openstack-oslo | 17:10 | |
| *** amotoki has quit IRC | 17:12 | |
| viktors | dhellmann: hi! A quick question - who do we use oslo.config version<=1.6.0 - not <=1.6.1 - at https://github.com/openstack/requirements/blob/stable/juno/global-requirements.txt#L55 ? | 17:13 |
| *** noelbk has joined #openstack-oslo | 17:15 | |
| dhellmann | viktors: I'd have to go look, but I think 1.5 was the juno series and 1.6 started the kilo series, and we don't want patch versions from kilo ending up in the juno test environment | 17:17 |
| dims | dansmith: would a test for VersionedObjectSerializer's override option of OBJ_SERIAL_NAMESPACE be good to add? | 17:19 |
| dansmith | dims: ah, sure | 17:19 |
| viktors | dhellmann: hm, ok, let it be | 17:22 |
| viktors | dhellmann: but it looks like, that the kilo series started with 1.5 ... | 17:26 |
| viktors | ok, will look tomorrow | 17:27 |
| *** daniel3_ has joined #openstack-oslo | 17:27 | |
| *** viktors is now known as viktors|afk | 17:27 | |
| dhellmann | viktors: ok, it's possible we went with a higher number because that was what we were actually testing in the gate at the time | 17:27 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-specs: Add general policy on test tooling https://review.openstack.org/158787 | 17:32 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-specs: Refactor oslotest base class into fixtures https://review.openstack.org/158788 | 17:32 |
| dhellmann | sdague, rpodolyaka: ^^ | 17:33 |
| viktors|afk | dhellmann: is that spec to L cycle & | 17:34 |
| rpodolyaka | dhellmann: ack, will take a look tomorrow | 17:34 |
| viktors|afk | take a look tomorrow as well. Also it's would be nice to ping zzzeek... | 17:35 |
| dhellmann | viktors|afk: the policy is for now, the spec for oslotest is for L | 17:35 |
| dhellmann | viktors|afk: I'll add him. I don't see him online. | 17:35 |
| viktors|afk | dhellmann: ok, thanks! | 17:36 |
| viktors|afk | bye :) | 17:36 |
| *** daniel3__ has joined #openstack-oslo | 17:58 | |
| *** ihrachyshka has joined #openstack-oslo | 18:00 | |
| *** daniel3_ has quit IRC | 18:01 | |
| *** dulek has quit IRC | 18:04 | |
| openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Allow subclasses to define the serialization namespaces https://review.openstack.org/158359 | 18:07 |
| dansmith | dims: I changed the serializer bit a little after writing that test and deciding it could be more helpfuler a different way ^ | 18:07 |
| *** prad has quit IRC | 18:09 | |
| *** devlaps has joined #openstack-oslo | 18:11 | |
| *** vigneshvar has quit IRC | 18:15 | |
| *** harlowja has joined #openstack-oslo | 18:20 | |
| *** ChuckC has quit IRC | 18:20 | |
| *** ChuckC has joined #openstack-oslo | 18:21 | |
| *** harlowja has quit IRC | 18:24 | |
| *** harlowja has joined #openstack-oslo | 18:24 | |
| *** sputnik13 has joined #openstack-oslo | 18:43 | |
| *** cdent has quit IRC | 18:45 | |
| *** vigneshvar has joined #openstack-oslo | 18:48 | |
| *** achanda has joined #openstack-oslo | 18:52 | |
| openstackgerrit | Merged openstack/oslo.vmware: Change use of random to random.SystemRandom https://review.openstack.org/156889 | 19:01 |
| *** crc32 has joined #openstack-oslo | 19:13 | |
| *** ChuckC_ has joined #openstack-oslo | 19:23 | |
| *** vigneshvar has quit IRC | 19:25 | |
| openstackgerrit | Min Pae proposed openstack/taskflow: Added a map and a reduce task https://review.openstack.org/157677 | 19:25 |
| *** ChuckC has quit IRC | 19:25 | |
| *** ChuckC has joined #openstack-oslo | 19:26 | |
| *** ChuckC_ has quit IRC | 19:28 | |
| *** prad has joined #openstack-oslo | 19:31 | |
| *** achanda has quit IRC | 19:33 | |
| *** devlaps has quit IRC | 19:33 | |
| *** achanda has joined #openstack-oslo | 19:41 | |
| *** prad has quit IRC | 19:43 | |
| *** e0ne has quit IRC | 19:43 | |
| *** trown is now known as trown|brb | 19:50 | |
| *** kgiusti1 has joined #openstack-oslo | 20:00 | |
| *** kgiusti has quit IRC | 20:01 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 20:11 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Experimentally & optionally use tooz to find/advertise workers https://review.openstack.org/151495 | 20:12 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 20:13 | |
| *** trown|brb is now known as trown | 20:16 | |
| krotscheck | Is there a best practice way for something to reach into the oslo_db config and pull out the connection string? I'd like to reuse it for apscheduler. | 20:20 |
| krotscheck | (Other than list_opts) | 20:21 |
| *** exploreshaifali has quit IRC | 20:24 | |
| krotscheck | n/m, just registering them for safety's sake works. | 20:32 |
| *** roaet has joined #openstack-oslo | 20:33 | |
| roaet | Howdy oslo folk. | 20:33 |
| *** prad has joined #openstack-oslo | 20:40 | |
| roaet | dhellmann or stevedore pros: I'm really not certain how to use TextExtensionManager with an example Plugin/extension that is not 'installed'. | 20:41 |
| *** jaosorior has quit IRC | 20:41 | |
| roaet | All the examples appear to assume that the extensions will be installed into the python path with the entry points, which I'm fine with during runtime, but during testing I don't know how to make the Extension to put in the list for the constructor of the TestExtensionManager. | 20:42 |
| krotscheck | roaet: You mean something like make_test_instance? | 20:43 |
| roaet | Don't you need to make an Extension for the first arg of that? Yes. I don't know how to make that extension then. | 20:43 |
| krotscheck | roaet: Sec, lemme pastebin something for ya. | 20:44 |
| roaet | krotscheck: thanks! | 20:44 |
| openstackgerrit | Cedric Brandily proposed openstack/cliff: Allow to call initialize_app when running --help https://review.openstack.org/158343 | 20:44 |
| krotscheck | roaet: http://paste.openstack.org/show/181417/ | 20:45 |
| krotscheck | The extension list is created in setUp | 20:45 |
| krotscheck | roaet: The test that came from is here, but it's a little confusing because we extend ExtensionManager and call it StoryboardPluginLoader http://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/tests/plugin/test_base.py | 20:46 |
| roaet | krotscheck: cool. trying to understand it right now. | 20:47 |
| roaet | where does the ep 'stroyboard.plugin.testing' come into play? does it not because it's testing? | 20:47 |
| krotscheck | roaet: So, that's the namespace under which the plugin is defined in setup.cfg | 20:48 |
| krotscheck | See http://git.openstack.org/cgit/openstack-infra/storyboard/tree/setup.cfg | 20:48 |
| *** kgiusti1 has quit IRC | 20:48 | |
| krotscheck | it's just a convenient way for me to say "Hey, try to 'load' the plugins in this dummy entry point" | 20:49 |
| krotscheck | Normally it'd be storyboard.plugin.user_preferences or something else. | 20:49 |
| roaet | Ah so that ep is a dummy (since it's not in the cfg) | 20:49 |
| krotscheck | yep | 20:49 |
| roaet | So in this situation you create the extensions list in setup, then create an extension named 'test_one', has no EP or plugin, and then uses the TestClass itself as the object? | 20:50 |
| roaet | You don't need have a EP or plugin for an Extension? | 20:50 |
| roaet | (which seems obvious, but wondering if I should PR a doc change to the code) | 20:51 |
| krotscheck | Almost. The plugins are loaded into the dummy ep when make_test_instance is invoked. | 20:52 |
| roaet | krotscheck: https://github.com/dhellmann/stevedore/blob/master/stevedore/extension.py#L22 if it said 'can be null' or whatever that'd help a bit.. I think I understand now what it happening. Thanks! | 20:52 |
| krotscheck | roaet: You're welcome! | 20:52 |
| krotscheck | Glad I could help | 20:52 |
| roaet | krotscheck: Ah. i can see that. I just had no idea how to make the Extension to put into the list for make_test_instance | 20:52 |
| roaet | because I didn't know what to do for the plugin arg of Extension contructor | 20:52 |
| krotscheck | Yeah, I'm sure those parameters are useful for something, just not for this particular case. | 20:52 |
| dansmith | dims: that same test is failing again.. known issue or just luck? | 20:53 |
| roaet | krotscheck: do you think it'd be objectionable to make a PR to add 'can be none' to that param list? | 20:53 |
| roaet | it really would have helped me a lot to know that it was even an option. | 20:53 |
| krotscheck | roaet: I don't think so, but the cores will be certain to bring it up if it is. | 20:54 |
| roaet | thanks again krotscheck | 20:54 |
| krotscheck | And more documentation is always good | 20:54 |
| openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Allow providing a logger to save_and_reraise_exception https://review.openstack.org/158158 | 20:58 |
| harlowja | dtantsur|afk something u might be interested in for https://review.openstack.org/#/c/158092/ | 21:02 |
| harlowja | it could replace that whole periodic stuff (and then either use real threads, or green threads, depending on what is patching what) | 21:03 |
| *** ihrachyshka has quit IRC | 21:03 | |
| *** kgiusti has joined #openstack-oslo | 21:04 | |
| *** kgiusti has quit IRC | 21:04 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow periodics to run in parallel (WIP/Exploratory) https://review.openstack.org/158092 | 21:05 |
| harlowja | something to look over if u want | 21:06 |
| harlowja | i don't mind splitting it out into a new pypi library or something | 21:06 |
| *** ihrachyshka has joined #openstack-oslo | 21:06 | |
| harlowja | maybe https://pypi.python.org/pypi/recurrence or something, ha | 21:06 |
| flaper87 | harlowja: there you are, I've been waiting for you the whole day for something I bet is very simple :D | 21:08 |
| harlowja | oh my | 21:08 |
| *** salv-orlando has quit IRC | 21:08 | |
| harlowja | lol | 21:08 |
| flaper87 | harlowja: I got some questions about taskflow | 21:08 |
| flaper87 | :) | 21:08 |
| harlowja | i've been waiting for u also | 21:08 |
| harlowja | j/k | 21:08 |
| harlowja | whats up :) | 21:08 |
| flaper87 | aww :( | 21:08 |
| flaper87 | you broke my heart | 21:08 |
| harlowja | i mean, not kidding | 21:08 |
| flaper87 | anyway | 21:08 |
| harlowja | damn it | 21:08 |
| flaper87 | :P | 21:08 |
| flaper87 | so, first question is, what's the default revert behavior when a task fails? | 21:09 |
| flaper87 | does it rollback just the subflow ? | 21:09 |
| flaper87 | I think I read that somewhere | 21:09 |
| flaper87 | :) | 21:09 |
| flaper87 | somwhere in the docs, I mean | 21:09 |
| harlowja | revert all the things is the default | 21:09 |
| harlowja | u can control this though, if u dare | 21:10 |
| flaper87 | I dare :P | 21:10 |
| harlowja | by placing in http://docs.openstack.org/developer/taskflow/atoms.html#retry (those objects there) into flows | 21:10 |
| flaper87 | is that by setting the REVERT attribute ? | 21:10 |
| flaper87 | in the task | 21:10 |
| flaper87 | ah ok | 21:10 |
| harlowja | nah, by assocating a retry (better named controller really) with a flow/subflow | 21:11 |
| flaper87 | harlowja: awesome, thanks for the hint. | 21:11 |
| flaper87 | another question | 21:11 |
| harlowja | np | 21:11 |
| flaper87 | if a subflow fails (and I revert *just* the subflow) will the parent flow execution continue ? | 21:11 |
| flaper87 | as in, I want to execute this task/sub-flow but I don't give a crap of what happens with it | 21:12 |
| *** andreykurilin_ has joined #openstack-oslo | 21:12 | |
| harlowja | so this depends on the structuring of the flows/subflows | 21:12 |
| harlowja | u want the 'keep on running' if possible feature, even when one breaks feature that i think manish (a y! doing stuff in neutron) i think also wants | 21:13 |
| harlowja | its possibly to do it, but not really possible if u say have an ordering dependency that needs data from the thing thats breaking | 21:13 |
| harlowja | u should jump into #openstack-state-management and poke manishg there | 21:13 |
| harlowja | i think he was maybe making something that would do this kind of thing | 21:14 |
| flaper87 | ahhh that's the name of the freakin' channel | 21:14 |
| flaper87 | :P | 21:14 |
| harlowja | :-p | 21:14 |
| harlowja | ya, its long, lol | 21:14 |
| *** andreykurilin_ has quit IRC | 21:17 | |
| *** andreykurilin__ has joined #openstack-oslo | 21:17 | |
| dims | dansmith: it's the ceilometer thing that mriedem mentioned http://logs.openstack.org/59/158359/3/check/gate-tempest-dsvm-neutron-src-oslo.versionedobjects-icehouse/8c7a377/logs/devstacklog.txt.gz#_2015-02-24_18_21_45_922 | 21:18 |
| dansmith | dims: ah | 21:18 |
| mriedem | busted! | 21:18 |
| mriedem | 158842 is going through the gate to fix that | 21:19 |
| *** andreykurilin_ has joined #openstack-oslo | 21:22 | |
| *** andreykurilin__ has quit IRC | 21:22 | |
| sdague | hmmm... why is olso.versioned objects testing on icehouse? | 21:24 |
| dims | sdague: template of some kind? :) | 21:25 |
| sdague | yeh, so someone should remove the stable-compat jobs, that's just a random grind job, there is nothing being tested in it | 21:25 |
| dims | looking | 21:25 |
| sdague | in fairness, there is really no reason to run any of the tempest tests until something is consuming it | 21:27 |
| sdague | but definitely shouldn't postdate the branch jobs | 21:27 |
| dims | sdague: https://review.openstack.org/158878 | 21:28 |
| sdague | dims: +2 | 21:29 |
| *** tsekiyama has quit IRC | 22:00 | |
| *** tsekiyama has joined #openstack-oslo | 22:00 | |
| elarson | sigmavirus24: do you ever mess with keystone? am I right that a keystoneclient.session is a requests session? | 22:01 |
| * elarson is hoping to clear up how the designate client actually makes requests :) | 22:02 | |
| sigmavirus24 | elarson: not much but I think the keystoneclient.session.Session actually has the session inside it | 22:02 |
| sigmavirus24 | also better suited for #openstack-keystone probably | 22:02 |
| * sigmavirus24 hasn't looked at ksc in a while though | 22:03 | |
| sigmavirus24 | let me look again | 22:03 |
| elarson | makes sense | 22:03 |
| dhellmann | krotscheck: the configuration settings of the libraries are not part of their API. Why do you need that? | 22:08 |
| *** tsekiyama has quit IRC | 22:08 | |
| *** tsekiyama has joined #openstack-oslo | 22:09 | |
| krotscheck | dhellmann: Because I don't want to bother configuring the connection string in two places. | 22:09 |
| dhellmann | roaet: don't use the TestExtensionManager, use make_test_instance() on the manager class you would normally use | 22:09 |
| dhellmann | krotscheck: are you accessing the same database with oslo.db and some other library? | 22:12 |
| krotscheck | dhellmann: Yep. apscheduler. | 22:12 |
| dhellmann | krotscheck: ok, we have an "under" layer to the db api where you can pass the connection string yourself, so that may be a better option for your case | 22:13 |
| dhellmann | there you would register the connection setting yourself as part of your apps config, and then it's a value you know about | 22:13 |
| dhellmann | that's safer, because the library configuration values are not part of the stable API, so if we rename it your app will just break | 22:13 |
| krotscheck | dhellmann: Safer, perhaps, but is that going to force me to move everything in the [database] block out? | 22:14 |
| dhellmann | krotscheck: I'd have to get viktors|afk or rpodolyaka to explain how to use it. | 22:15 |
| krotscheck | dhellmann: You know, why don't I just use get_engine() instead. | 22:16 |
| *** stevemar has quit IRC | 22:17 | |
| dhellmann | krotscheck: ah, yeah, the EngineFacade class looks like the thing I was thinking of | 22:20 |
| *** ViswaV has joined #openstack-oslo | 22:28 | |
| *** ihrachyshka has quit IRC | 22:31 | |
| *** salv-orlando has joined #openstack-oslo | 22:33 | |
| *** jaosorior has joined #openstack-oslo | 22:33 | |
| *** openstackgerrit has quit IRC | 22:37 | |
| *** openstackgerrit has joined #openstack-oslo | 22:37 | |
| *** roaet has left #openstack-oslo | 22:37 | |
| openstackgerrit | James Carey proposed openstack/oslo.i18n: Update guideline doc of multiple use msg case https://review.openstack.org/158900 | 22:38 |
| *** achanda has quit IRC | 22:54 | |
| *** mriedem has quit IRC | 22:57 | |
| *** harlowja is now known as harlowja_away | 23:02 | |
| *** harlowja_away is now known as harlowja | 23:05 | |
| *** bknudson has quit IRC | 23:07 | |
| *** daniel3__ has quit IRC | 23:12 | |
| *** achanda has joined #openstack-oslo | 23:13 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow periodics to run in parallel (WIP/Exploratory) https://review.openstack.org/158092 | 23:16 |
| *** salv-orl_ has joined #openstack-oslo | 23:20 | |
| *** salv-orlando has quit IRC | 23:22 | |
| openstackgerrit | Merged openstack/oslo-incubator: Fix the regex for turning project.lib back to oslo.lib https://review.openstack.org/157178 | 23:27 |
| *** andreykurilin_ has quit IRC | 23:28 | |
| *** jecarey has quit IRC | 23:30 | |
| *** gordc has quit IRC | 23:33 | |
| *** achanda has quit IRC | 23:48 | |
| *** achanda has joined #openstack-oslo | 23:53 | |
| *** mriedem has joined #openstack-oslo | 23:53 | |
| *** salv-orlando has joined #openstack-oslo | 23:56 | |
| *** prad has quit IRC | 23:57 | |
| *** salv-orl_ has quit IRC | 23:57 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!