| *** tsekiyama has joined #openstack-oslo | 00:00 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:01 | |
| *** tsekiyama has quit IRC | 00:01 | |
| *** flwang1 has quit IRC | 00:01 | |
| *** tsekiyam_ has quit IRC | 00:01 | |
| *** tsekiyama has joined #openstack-oslo | 00:02 | |
| *** tsekiyama has quit IRC | 00:02 | |
| *** tsekiyama has joined #openstack-oslo | 00:03 | |
| *** tsekiyama has quit IRC | 00:03 | |
| *** tsekiyama has joined #openstack-oslo | 00:04 | |
| *** tsekiyama has quit IRC | 00:04 | |
| *** tsekiyama has joined #openstack-oslo | 00:04 | |
| *** achanda has quit IRC | 00:05 | |
| *** tsekiyama has quit IRC | 00:05 | |
| *** tsekiyama has joined #openstack-oslo | 00:05 | |
| *** tsekiyama has quit IRC | 00:06 | |
| *** tsekiyama has joined #openstack-oslo | 00:06 | |
| *** tsekiyama has quit IRC | 00:07 | |
| *** tsekiyama has joined #openstack-oslo | 00:08 | |
| *** tsekiyama has quit IRC | 00:08 | |
| *** tsekiyama has joined #openstack-oslo | 00:08 | |
| *** tsekiyama has quit IRC | 00:09 | |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack/oslo.messaging: Add a gearman/gearstore/gearhorn driver https://review.openstack.org/165646 | 00:09 |
|---|---|---|
| *** tsekiyama has joined #openstack-oslo | 00:09 | |
| *** tsekiyama has quit IRC | 00:10 | |
| *** tsekiyama has joined #openstack-oslo | 00:10 | |
| *** tsekiyama has quit IRC | 00:11 | |
| *** tsekiyama has joined #openstack-oslo | 00:11 | |
| *** tsekiyama has quit IRC | 00:12 | |
| *** tsekiyama has joined #openstack-oslo | 00:12 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use a small coroutine in the conductor to iterate over jobs https://review.openstack.org/166051 | 00:12 |
| *** tsekiyam_ has joined #openstack-oslo | 00:13 | |
| *** tsekiyama has quit IRC | 00:13 | |
| *** YorikSar has quit IRC | 00:14 | |
| *** tsekiyam_ has quit IRC | 00:14 | |
| *** tsekiyama has joined #openstack-oslo | 00:14 | |
| *** sputnik13 has quit IRC | 00:16 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:16 | |
| *** tsekiyama has quit IRC | 00:16 | |
| *** tsekiyam_ has quit IRC | 00:17 | |
| *** tsekiyama has joined #openstack-oslo | 00:17 | |
| *** _amrith_ is now known as amrith | 00:17 | |
| *** tsekiyama has quit IRC | 00:17 | |
| *** tsekiyama has joined #openstack-oslo | 00:18 | |
| *** tsekiyama has quit IRC | 00:19 | |
| *** tsekiyama has joined #openstack-oslo | 00:19 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:20 | |
| *** tsekiyama has quit IRC | 00:20 | |
| *** tsekiyam_ has quit IRC | 00:20 | |
| *** tsekiyama has joined #openstack-oslo | 00:21 | |
| *** tsekiyama has quit IRC | 00:21 | |
| *** tsekiyama has joined #openstack-oslo | 00:22 | |
| *** tsekiyama has quit IRC | 00:22 | |
| *** tsekiyama has joined #openstack-oslo | 00:23 | |
| *** tsekiyama has quit IRC | 00:23 | |
| *** stevemar has joined #openstack-oslo | 00:23 | |
| *** tsekiyama has joined #openstack-oslo | 00:24 | |
| *** tsekiyama has quit IRC | 00:25 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:25 | |
| *** tsekiyam_ has quit IRC | 00:25 | |
| *** tsekiyama has joined #openstack-oslo | 00:26 | |
| *** tsekiyama has quit IRC | 00:26 | |
| *** tsekiyama has joined #openstack-oslo | 00:27 | |
| *** tsekiyama has quit IRC | 00:27 | |
| *** tsekiyama has joined #openstack-oslo | 00:27 | |
| *** tsekiyama has quit IRC | 00:28 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:28 | |
| *** tsekiyam_ has quit IRC | 00:29 | |
| *** tsekiyama has joined #openstack-oslo | 00:29 | |
| *** tsekiyama has quit IRC | 00:30 | |
| *** tsekiyama has joined #openstack-oslo | 00:30 | |
| *** tsekiyama has quit IRC | 00:31 | |
| *** tsekiyama has joined #openstack-oslo | 00:31 | |
| *** tsekiyama has quit IRC | 00:32 | |
| *** tsekiyama has joined #openstack-oslo | 00:32 | |
| *** tsekiyama has quit IRC | 00:33 | |
| *** tsekiyama has joined #openstack-oslo | 00:33 | |
| *** tsekiyama has quit IRC | 00:34 | |
| *** tsekiyama has joined #openstack-oslo | 00:34 | |
| *** tsekiyama has quit IRC | 00:34 | |
| *** tsekiyama has joined #openstack-oslo | 00:35 | |
| *** tsekiyama has quit IRC | 00:35 | |
| *** tsekiyama has joined #openstack-oslo | 00:36 | |
| *** tsekiyama has quit IRC | 00:37 | |
| *** tsekiyama has joined #openstack-oslo | 00:37 | |
| *** tsekiyama has quit IRC | 00:37 | |
| *** tsekiyama has joined #openstack-oslo | 00:38 | |
| *** tsekiyama has quit IRC | 00:38 | |
| *** tsekiyama has joined #openstack-oslo | 00:39 | |
| *** tsekiyama has quit IRC | 00:39 | |
| *** tsekiyama has joined #openstack-oslo | 00:40 | |
| *** tsekiyama has quit IRC | 00:40 | |
| *** tsekiyama has joined #openstack-oslo | 00:41 | |
| *** tsekiyama has quit IRC | 00:41 | |
| *** tsekiyama has joined #openstack-oslo | 00:42 | |
| *** tsekiyama has quit IRC | 00:43 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:43 | |
| *** tsekiyam_ has quit IRC | 00:43 | |
| *** tsekiyama has joined #openstack-oslo | 00:44 | |
| *** tsekiyama has quit IRC | 00:44 | |
| *** tsekiyama has joined #openstack-oslo | 00:45 | |
| *** tsekiyama has quit IRC | 00:45 | |
| *** tsekiyama has joined #openstack-oslo | 00:46 | |
| *** tsekiyama has quit IRC | 00:46 | |
| *** tsekiyama has joined #openstack-oslo | 00:46 | |
| *** tsekiyama has quit IRC | 00:47 | |
| *** tsekiyama has joined #openstack-oslo | 00:47 | |
| *** tsekiyama has quit IRC | 00:48 | |
| *** tsekiyama has joined #openstack-oslo | 00:48 | |
| *** tsekiyama has quit IRC | 00:49 | |
| *** tsekiyama has joined #openstack-oslo | 00:49 | |
| *** tsekiyama has quit IRC | 00:50 | |
| *** tsekiyama has joined #openstack-oslo | 00:50 | |
| *** tsekiyama has quit IRC | 00:51 | |
| *** tsekiyama has joined #openstack-oslo | 00:51 | |
| *** bknudson has joined #openstack-oslo | 00:51 | |
| *** tsekiyama has quit IRC | 00:51 | |
| *** tsekiyama has joined #openstack-oslo | 00:52 | |
| *** tsekiyama has quit IRC | 00:53 | |
| *** tsekiyama has joined #openstack-oslo | 00:53 | |
| *** tsekiyama has quit IRC | 00:53 | |
| *** tsekiyama has joined #openstack-oslo | 00:54 | |
| *** tsekiyama has quit IRC | 00:54 | |
| *** tsekiyama has joined #openstack-oslo | 00:55 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:56 | |
| *** tsekiyama has quit IRC | 00:56 | |
| *** tsekiyam_ has quit IRC | 00:56 | |
| *** tsekiyama has joined #openstack-oslo | 00:57 | |
| *** tsekiyama has quit IRC | 00:57 | |
| *** tsekiyama has joined #openstack-oslo | 00:58 | |
| *** tsekiyam_ has joined #openstack-oslo | 00:59 | |
| *** tsekiyama has quit IRC | 00:59 | |
| *** sreshetn1 has joined #openstack-oslo | 01:05 | |
| *** spyyy has quit IRC | 01:07 | |
| *** dims has joined #openstack-oslo | 01:08 | |
| *** sreshetn1 has quit IRC | 01:09 | |
| *** prad has quit IRC | 01:21 | |
| *** harlowja_ is now known as harlowja_away | 01:46 | |
| *** yamahata has quit IRC | 02:11 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 02:14 | |
| *** jamielennox is now known as jamielennox|lunc | 02:32 | |
| *** jamielennox|lunc is now known as jamielennox|food | 02:32 | |
| openstackgerrit | ayoung proposed openstack/oslo.policy: Convert Exceptions to failures. https://review.openstack.org/165908 | 02:37 |
| *** sputnik13 has joined #openstack-oslo | 02:45 | |
| *** achanda has joined #openstack-oslo | 02:45 | |
| *** BrianShang has quit IRC | 02:50 | |
| *** BrianShang has joined #openstack-oslo | 02:52 | |
| *** amotoki has joined #openstack-oslo | 02:53 | |
| *** sreshetn1 has joined #openstack-oslo | 02:53 | |
| *** greghaynes has quit IRC | 02:58 | |
| *** sreshetn1 has quit IRC | 02:58 | |
| *** jamielennox|food is now known as jamielennox | 03:01 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo-incubator: Fix TODO - switch functools.wraps to six.wraps https://review.openstack.org/166084 | 03:03 |
| *** subscope_ has joined #openstack-oslo | 03:05 | |
| *** greghaynes has joined #openstack-oslo | 03:06 | |
| *** amotoki has quit IRC | 03:11 | |
| *** lan has quit IRC | 03:15 | |
| *** jecarey has joined #openstack-oslo | 03:15 | |
| *** dims has quit IRC | 03:20 | |
| *** lan has joined #openstack-oslo | 03:27 | |
| *** tsekiyam_ has quit IRC | 03:29 | |
| *** sputnik13 has quit IRC | 03:33 | |
| *** sputnik13 has joined #openstack-oslo | 03:37 | |
| *** sputnik13 has quit IRC | 03:44 | |
| *** achanda has quit IRC | 03:49 | |
| *** sputnik13 has joined #openstack-oslo | 03:55 | |
| *** achanda has joined #openstack-oslo | 03:59 | |
| *** achanda has quit IRC | 04:01 | |
| *** amotoki has joined #openstack-oslo | 04:09 | |
| *** achanda has joined #openstack-oslo | 04:12 | |
| *** sputnik13 has quit IRC | 04:15 | |
| *** achanda has quit IRC | 04:15 | |
| *** sputnik13 has joined #openstack-oslo | 04:16 | |
| *** dims has joined #openstack-oslo | 04:25 | |
| *** sputnik13 has quit IRC | 04:27 | |
| *** dims has quit IRC | 04:32 | |
| *** sputnik13 has joined #openstack-oslo | 04:36 | |
| *** sreshetn1 has joined #openstack-oslo | 04:42 | |
| *** sputnik13 has quit IRC | 04:44 | |
| *** sputnik13 has joined #openstack-oslo | 04:46 | |
| *** BrianShang_ has joined #openstack-oslo | 04:46 | |
| *** sreshetn1 has quit IRC | 04:47 | |
| *** BrianShang has quit IRC | 04:49 | |
| *** yamahata has joined #openstack-oslo | 04:57 | |
| *** sputnik13 has quit IRC | 04:59 | |
| *** sputnik13 has joined #openstack-oslo | 05:00 | |
| *** amotoki_ has joined #openstack-oslo | 05:00 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 05:02 | |
| *** sputnik13 has quit IRC | 05:02 | |
| *** sputnik13 has joined #openstack-oslo | 05:03 | |
| openstackgerrit | Masaki Matsushita proposed openstack/oslo-incubator: Disable SSL v2 and v3 https://review.openstack.org/166101 | 05:05 |
| *** rushiagr_away is now known as rushiagr | 05:07 | |
| *** mdbooth has quit IRC | 05:07 | |
| *** achanda has joined #openstack-oslo | 05:08 | |
| *** mdbooth has joined #openstack-oslo | 05:11 | |
| *** mriedem_away has quit IRC | 05:18 | |
| *** mriedem has joined #openstack-oslo | 05:18 | |
| *** mriedem has quit IRC | 05:18 | |
| *** mriedem has joined #openstack-oslo | 05:18 | |
| *** alexpilotti has quit IRC | 05:35 | |
| *** rushiagr is now known as rushiagr_away | 05:42 | |
| *** sreshetn1 has joined #openstack-oslo | 05:43 | |
| *** mdbooth has quit IRC | 05:45 | |
| *** sputnik13 has quit IRC | 05:46 | |
| *** sputnik13 has joined #openstack-oslo | 05:47 | |
| *** sreshetn1 has quit IRC | 05:48 | |
| *** mdbooth has joined #openstack-oslo | 05:50 | |
| *** sputnik13 has quit IRC | 05:54 | |
| *** rushiagr_away is now known as rushiagr | 05:59 | |
| *** sputnik13 has joined #openstack-oslo | 06:11 | |
| *** sputnik13 has quit IRC | 06:12 | |
| *** mdbooth has quit IRC | 06:17 | |
| *** dims has joined #openstack-oslo | 06:18 | |
| *** sreshetn1 has joined #openstack-oslo | 06:19 | |
| *** mdbooth has joined #openstack-oslo | 06:23 | |
| *** dims has quit IRC | 06:24 | |
| *** jamielennox is now known as jamielennox|away | 06:35 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/166111 | 06:36 |
| *** subscope_ has quit IRC | 06:42 | |
| *** sigmavirus24 is now known as sigmavirus24_awa | 06:44 | |
| *** inc0 has joined #openstack-oslo | 06:55 | |
| *** yamahata has quit IRC | 06:58 | |
| *** yamahata has joined #openstack-oslo | 06:58 | |
| *** rushiagr is now known as rushiagr_away | 07:16 | |
| *** achanda has quit IRC | 07:17 | |
| *** achanda has joined #openstack-oslo | 07:29 | |
| *** shardy has joined #openstack-oslo | 07:40 | |
| *** sheeprine has joined #openstack-oslo | 07:40 | |
| *** rushiagr_away is now known as rushiagr | 07:46 | |
| *** e0ne has joined #openstack-oslo | 07:51 | |
| *** dtantsur|afk is now known as dtantsur | 08:02 | |
| *** dims has joined #openstack-oslo | 08:09 | |
| *** viktors|afk is now known as viktors | 08:13 | |
| *** dulek has joined #openstack-oslo | 08:15 | |
| *** dims has quit IRC | 08:18 | |
| *** e0ne has quit IRC | 08:19 | |
| openstackgerrit | Mehdi Abaakouk proposed openstack/tooz: fix lock concurrency issues with certain drivers https://review.openstack.org/164642 | 08:20 |
| *** ndipanov has joined #openstack-oslo | 08:20 | |
| *** openstackgerrit has quit IRC | 08:22 | |
| *** jaosorior has joined #openstack-oslo | 08:22 | |
| *** openstackgerrit has joined #openstack-oslo | 08:22 | |
| *** achanda has quit IRC | 08:23 | |
| *** achanda has joined #openstack-oslo | 08:27 | |
| *** boris-42 has quit IRC | 08:32 | |
| *** dtantsur is now known as dtantsur|bbl | 08:41 | |
| *** achanda has quit IRC | 08:50 | |
| *** stevemar has quit IRC | 08:54 | |
| *** andreykurilin_ has joined #openstack-oslo | 08:58 | |
| *** andreykurilin_ has quit IRC | 09:03 | |
| *** andreykurilin_ has joined #openstack-oslo | 09:04 | |
| *** andreykurilin__ has joined #openstack-oslo | 09:08 | |
| *** yamahata has quit IRC | 09:09 | |
| *** andreykurilin_ has quit IRC | 09:09 | |
| *** i159 has joined #openstack-oslo | 09:12 | |
| *** jamielennox|away is now known as jamielennox | 09:14 | |
| openstackgerrit | Merged openstack/oslo.messaging: Minor improvement https://review.openstack.org/165278 | 09:17 |
| *** ajo has joined #openstack-oslo | 09:20 | |
| *** andreykurilin__ has quit IRC | 09:27 | |
| *** andreykurilin_ has joined #openstack-oslo | 09:27 | |
| *** exploreshaifali has joined #openstack-oslo | 09:30 | |
| *** sreshetn1 has quit IRC | 09:32 | |
| *** mtreinish has quit IRC | 09:35 | |
| *** mtreinish has joined #openstack-oslo | 09:36 | |
| *** amotoki has quit IRC | 09:37 | |
| *** andreykurilin_ has quit IRC | 09:43 | |
| *** exploreshaifali has quit IRC | 09:44 | |
| *** sreshetn1 has joined #openstack-oslo | 09:53 | |
| *** sreshetn1 has quit IRC | 10:02 | |
| *** sileht has quit IRC | 10:07 | |
| *** e0ne has joined #openstack-oslo | 10:08 | |
| *** dimsum__ has joined #openstack-oslo | 10:11 | |
| *** pblaho__ is now known as pblaho | 10:15 | |
| openstackgerrit | Vipin Balachandran proposed openstack/oslo.vmware: Remove old tests https://review.openstack.org/166157 | 10:18 |
| *** sileht has joined #openstack-oslo | 10:22 | |
| openstackgerrit | Vipin Balachandran proposed openstack/oslo.vmware: Move exception related tests to new module https://review.openstack.org/166159 | 10:35 |
| *** spyyy has joined #openstack-oslo | 10:40 | |
| *** YorikSar has joined #openstack-oslo | 10:47 | |
| *** BrianShang_ has quit IRC | 10:48 | |
| *** BrianShang has joined #openstack-oslo | 10:49 | |
| *** e0ne is now known as e0ne_ | 10:55 | |
| *** e0ne_ is now known as e0ne | 10:57 | |
| *** rushiagr is now known as rushiagr_away | 10:58 | |
| *** BrianShang has quit IRC | 11:01 | |
| *** BrianShang has joined #openstack-oslo | 11:02 | |
| openstackgerrit | Mehdi Abaakouk proposed openstack/tooz: fix lock concurrency issues with certain drivers https://review.openstack.org/164642 | 11:02 |
| *** cdent has joined #openstack-oslo | 11:12 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo-incubator: Fix TODO - switch functools.wraps to six.wraps https://review.openstack.org/166084 | 11:19 |
| openstackgerrit | Merged openstack/oslo.messaging: Create a unique transport for each server in the functional tests https://review.openstack.org/155476 | 11:33 |
| openstackgerrit | Merged openstack/oslo.messaging: Add pluggability for matchmakers https://review.openstack.org/161615 | 11:36 |
| dimsum__ | sileht: ping | 11:38 |
| dimsum__ | sileht: regular success code path looks good against stable/junotoo :) (running oslo.messaging trunk against stable/juno) - https://review.openstack.org/#/c/165981/ | 11:38 |
| *** dtantsur|bbl is now known as dtantsur | 11:41 | |
| *** ajo has quit IRC | 11:42 | |
| *** ajo has joined #openstack-oslo | 11:43 | |
| *** ajo has quit IRC | 11:44 | |
| *** ajo has joined #openstack-oslo | 11:44 | |
| openstackgerrit | Vipin Balachandran proposed openstack/oslo.vmware: Fix exception during connection close https://review.openstack.org/166181 | 11:46 |
| *** exploreshaifali has joined #openstack-oslo | 11:49 | |
| *** e0ne is now known as e0ne_ | 11:49 | |
| *** spyyy has quit IRC | 11:55 | |
| *** dulek has quit IRC | 11:57 | |
| *** e0ne_ is now known as e0ne | 11:59 | |
| *** dulek has joined #openstack-oslo | 12:01 | |
| *** inc0_ has joined #openstack-oslo | 12:02 | |
| *** inc0 has quit IRC | 12:03 | |
| *** ihrachyshka has joined #openstack-oslo | 12:11 | |
| sileht | dimsum__, it should work on icehouse too (for those that have switch to oslo.msg) | 12:12 |
| dimsum__ | i won't try that far :) | 12:12 |
| *** stpierre has joined #openstack-oslo | 12:15 | |
| *** jaypipes has joined #openstack-oslo | 12:22 | |
| *** gordc has joined #openstack-oslo | 12:27 | |
| *** bknudson has quit IRC | 12:29 | |
| *** inc0_ has quit IRC | 12:29 | |
| *** kgiusti has joined #openstack-oslo | 12:34 | |
| *** e0ne is now known as e0ne_ | 12:41 | |
| *** inc0 has joined #openstack-oslo | 12:43 | |
| *** ajo has quit IRC | 12:43 | |
| *** ajo has joined #openstack-oslo | 12:43 | |
| *** e0ne_ is now known as e0ne | 12:44 | |
| *** inc0 has quit IRC | 12:48 | |
| *** inc0_ has joined #openstack-oslo | 12:48 | |
| *** inc0_ has quit IRC | 12:54 | |
| *** bknudson has joined #openstack-oslo | 12:54 | |
| social | just asking should I change this now or keep it and someone will approve it anyway https://review.openstack.org/#/c/165831/ | 12:59 |
| social | frankly I don't like checking for : even though the checking for ip is kinda weak | 12:59 |
| *** ChuckC_ has joined #openstack-oslo | 13:00 | |
| *** ChuckC has quit IRC | 13:01 | |
| *** i159_ has joined #openstack-oslo | 13:04 | |
| *** sreshetn1 has joined #openstack-oslo | 13:05 | |
| *** dulek has quit IRC | 13:05 | |
| *** dulek has joined #openstack-oslo | 13:05 | |
| *** i159 has quit IRC | 13:05 | |
| *** ChuckC_ has quit IRC | 13:05 | |
| *** ihrachyshka has quit IRC | 13:14 | |
| *** ChuckC_ has joined #openstack-oslo | 13:19 | |
| sdague | hmmm... we've really defined config group that's based on a library name - https://review.openstack.org/#/c/162340/6 ? | 13:23 |
| *** dimsum__ has quit IRC | 13:27 | |
| *** amotoki_ has quit IRC | 13:35 | |
| *** amotoki has joined #openstack-oslo | 13:35 | |
| *** cdent has quit IRC | 13:36 | |
| *** jamielennox is now known as jamielennox|away | 13:36 | |
| *** mtanino has joined #openstack-oslo | 13:50 | |
| *** ihrachyshka has joined #openstack-oslo | 13:51 | |
| *** dimsum__ has joined #openstack-oslo | 13:51 | |
| *** sreshetn1 has quit IRC | 13:55 | |
| *** alexpilotti has joined #openstack-oslo | 13:56 | |
| dimsum__ | social: there are 3 spots already in oslo_messaging where we use "if ':' in host", so i'd prefer that, will +2A if you can help do that quickly :) | 13:57 |
| *** sreshetn1 has joined #openstack-oslo | 13:57 | |
| *** jecarey has quit IRC | 13:58 | |
| SpamapS | wow.. trying to make an already threaded thing work inside eventlet is zomg weird | 14:00 |
| dimsum__ | sdague: at least 4 libraries do it. | 14:01 |
| *** spyyy has joined #openstack-oslo | 14:02 | |
| *** dansmith is now known as superdan | 14:03 | |
| openstackgerrit | Lukas Bezdicka proposed openstack/oslo.messaging: rabbit: fix ipv6 support https://review.openstack.org/165831 | 14:05 |
| *** cdent has joined #openstack-oslo | 14:06 | |
| *** sputnik13 has joined #openstack-oslo | 14:19 | |
| *** prad has joined #openstack-oslo | 14:21 | |
| *** e0ne is now known as e0ne_ | 14:26 | |
| *** e0ne_ is now known as e0ne | 14:27 | |
| *** mvandijk has joined #openstack-oslo | 14:30 | |
| mvandijk | To change an oslo utils test, do I edit the files in oslo.utils/tests/ or oslo.utils/oslo_utils/tests/ ? | 14:33 |
| *** dulek has quit IRC | 14:33 | |
| *** prad has quit IRC | 14:35 | |
| dhellmann | mvandijk: the files in oslo.utils/tests are verifying that the old import style still work. The copies under oslo_utils use the new import style. So if you're changing behavior, you need to make both copies work. What are you working on? | 14:35 |
| *** prad has joined #openstack-oslo | 14:36 | |
| mvandijk | proposing a proper fix for https://bugs.launchpad.net/oslo.utils/+bug/1433652 | 14:37 |
| openstack | Launchpad bug 1433652 in oslo.utils "make the sanitization keys in mask_password dynamic" [Undecided,Opinion] - Assigned to Amrith (amrith) | 14:37 |
| mvandijk | i.e. add an optional parameter to mask_password that is a list of keys to mask the values of | 14:37 |
| mvandijk | and a test along with it | 14:38 |
| dhellmann | mvandijk: ok, in that case only the tests under oslo.utils/oslo_utils/tests need to be modified because it's a new feature | 14:38 |
| mvandijk | alright, cheers | 14:38 |
| dhellmann | mvandijk: be forewarned, though, I still think that's a bad idea and I'm not sure the team has agreed on whether to accept it or not. So it's probably worth starting a discussion about that before spending a bunch of time on code. | 14:38 |
| *** sreshetn1 has quit IRC | 14:40 | |
| mvandijk | alright | 14:40 |
| dhellmann | mvandijk: the mailing list is a good place for that discussion | 14:40 |
| *** i159_ has quit IRC | 14:41 | |
| *** sreshetn1 has joined #openstack-oslo | 14:45 | |
| *** sputnik13 has quit IRC | 14:45 | |
| *** dtantsur has left #openstack-oslo | 14:53 | |
| *** dimsum__ has quit IRC | 15:01 | |
| *** stevemar has joined #openstack-oslo | 15:02 | |
| *** zzzeek has joined #openstack-oslo | 15:08 | |
| *** yamahata has joined #openstack-oslo | 15:13 | |
| *** dimsum__ has joined #openstack-oslo | 15:14 | |
| *** sputnik13 has joined #openstack-oslo | 15:15 | |
| *** dimsum__ has quit IRC | 15:16 | |
| *** yamahata has quit IRC | 15:17 | |
| *** sputnik13 has quit IRC | 15:18 | |
| *** sputnik13 has joined #openstack-oslo | 15:21 | |
| *** jogo is now known as flashgordon | 15:21 | |
| *** openstackgerrit has quit IRC | 15:21 | |
| *** openstackgerrit has joined #openstack-oslo | 15:22 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:22 | |
| openstackgerrit | Victor Stinner proposed openstack/oslo.utils: Add exception_to_unicode() function https://review.openstack.org/163507 | 15:27 |
| *** sputnik13 has quit IRC | 15:28 | |
| *** sputnik13 has joined #openstack-oslo | 15:28 | |
| *** sputnik13 has quit IRC | 15:28 | |
| haypo | dhellmann: logging exceptions really makes me crazy :-p | 15:29 |
| haypo | dhellmann: i updated https://review.openstack.org/163507 it should take in account your remark | 15:30 |
| dhellmann | haypo: regarding your second comment, _Message is a subclass of unicode and has a special __new__ method. Have you checked to see if unicode(_Message()) returns another _Message() object? | 15:33 |
| sigmavirus24 | stupid question: So I"m trying to get Nova (stable/juno) working on Debian (using a source install) and sslutils inside of Nova causes it to fail because ssl.PROTOCOL_SSLv3 is no longer defined. sslutils currently doesn't have that code anymore. Is it acceptable to sync oslo-incubator to Nova stable/juno? That's the only file using either _SSL_PROTOCOLS or validate_ssl_version so a sync shouldn't break it from that perspective | 15:33 |
| * sigmavirus24 is looking at other methods in sslutils that nova might be using | 15:34 | |
| dhellmann | sigmavirus24: yes, I think we removed it from the incubator but no one every updated nova's stable branch with that fix | 15:34 |
| dhellmann | *ever | 15:34 |
| sigmavirus24 | So updates to stable branches are acceptable? | 15:34 |
| * sigmavirus24 wasn't quite certain | 15:34 | |
| haypo | dhellmann: exception_to_unicode() expects an exception, do you mean that exc.__unicode__() or exc.__str__() may return a Message object? | 15:35 |
| dhellmann | haypo: yes | 15:36 |
| dhellmann | haypo: you said nova is converting the message string to unicode, but I think if you do unicode(_Message()) you get a _Message() -- I need to test that | 15:37 |
| haypo | dhellmann: i only checked nova yet, and nova doesn't store the message object, but a unicode string | 15:37 |
| *** dimsum__ has joined #openstack-oslo | 15:37 | |
| dhellmann | haypo: link? | 15:37 |
| dhellmann | haypo: remember, _Message is a subclass of unicode | 15:37 |
| haypo | >>> nova.exception.NovaException(nova.i18n._('Instance event failed')).__unicode__() | 15:37 |
| *** jaypipes is now known as leakypipes | 15:37 | |
| haypo | u'Instance event failed' | 15:37 |
| *** ndipanov has quit IRC | 15:38 | |
| haypo | hum, i'm not sure that i initialized correctly oslo.i18n, because nova.i18n._('hello') returns a unicode object | 15:38 |
| *** sreshetn1 has quit IRC | 15:38 | |
| dhellmann | haypo: ok, nova's exception class is broken then because it's not supporting lazy translation if it does that | 15:38 |
| *** ndipanov has joined #openstack-oslo | 15:39 | |
| haypo | dhellmann: nova.i18n._("text") is supposed to return a Message object | 15:39 |
| haypo | ? | 15:39 |
| *** ChuckC_ is now known as ChuckC | 15:39 | |
| dhellmann | haypo: http://docs.openstack.org/developer/oslo.i18n/usage.html#lazy-translation | 15:42 |
| haypo | dhellmann: ah wait, better example with lazy translation enabled: http://pastealacon.com/37093 | 15:42 |
| haypo | dhellmann: it's ok, exc.args[0] is a Message object | 15:43 |
| dhellmann | haypo: ok, we need to fix nova's handling of the exception there, but we also need your change to work with a message | 15:43 |
| haypo | dhellmann: it's just that exc.__unicode__() converts the Message to unicode | 15:43 |
| dhellmann | I wonder if Message.__unicode__ should just return a Message | 15:43 |
| dhellmann | right, and doing that at that point means the translation is never applied | 15:43 |
| haypo | dhellmann: in some places, python really wants a unicode type, not a subtype | 15:44 |
| dhellmann | haypo: ok? | 15:44 |
| *** sreshetn1 has joined #openstack-oslo | 15:44 | |
| haypo | dhellmann: if i understand correctly, the translation is not done when the exception is created, but when the exception is converted to a string | 15:46 |
| dhellmann | haypo: yes, that's right. And we want the wsgi stack code to handle that, since it knows (a) that it should call translate() and (b) what language setting to pass to translate() | 15:46 |
| haypo | dhellmann: to come back to my exception_to_unicode() function, does it look ok? it now calls exc.__unicode__() first | 15:46 |
| dhellmann | haypo: what exactly is this new function for? because I think it's bypassing the translation stuff, and we don't want that | 15:47 |
| haypo | dhellmann: the function ensures that we will never get a unicode error when trying to log an exception | 15:48 |
| dhellmann | haypo: is it just for logging? | 15:48 |
| dhellmann | and who calls it? where? | 15:48 |
| haypo | dhellmann: anywhere where you want to convert an exception to text. usually, it's for logging | 15:49 |
| dhellmann | do I put that in my application? or is the log library going to do this for me? | 15:49 |
| haypo | dhellmann: my starting point is https://bugs.launchpad.net/nova/+bug/1419905 -- a bug in nova with a locale different than en_US when logging an exception | 15:49 |
| openstack | Launchpad bug 1419905 in OpenStack Compute (nova) "Nova may not start instances when OS is installed with locale not en_US" [Low,Fix released] - Assigned to Davanum Srinivas (DIMS) (dims-v) | 15:50 |
| dhellmann | haypo: I need a more detailed example, because I think you're trying to solve a problem we have either fixed or you're solving it in a way that breaks some other stuff | 15:50 |
| dhellmann | haypo: would https://review.openstack.org/#/c/163027/ fix that? | 15:50 |
| haypo | dhellmann: the bug is at the left of https://review.openstack.org/#/c/159209/4/nova/virt/libvirt/firewall.py | 15:51 |
| haypo | dhellmann: the pattern LOG.debug("...: %s" % (..., exc)) doesn't work | 15:51 |
| dhellmann | haypo: if that format string to debug() was made a unicode string everything would work fine, no? | 15:51 |
| haypo | but i'm not sure that LOG.debug("...: %(exc)s", {..., 'exc': exc}) works in all cases | 15:51 |
| dhellmann | LOG.debug(u'...', (name, e)) | 15:52 |
| haypo | dhellmann: logging.critical(u'error: %s', Exception('\xe9'.encode('utf8')) doesn't work | 15:52 |
| haypo | dhellmann: IMO the bug is specific to Python 2 | 15:52 |
| *** harlowja_at_home has joined #openstack-oslo | 15:52 | |
| haypo | dhellmann: well, i'm chatting with you to ensure that i understood the problem... maybe i missed something | 15:53 |
| dhellmann | haypo: yeah, I may be missing a case, too. I know it doesn't work if the format string is ascii and the exception can't be encoded that way. I don't know that the case you list with critical() fails, so I'd have to test that. In any case, what you're proposing will require too many application-level changes to be effective, so I think we need to fix the problem down in oslo.log. If my patch above doesn't work, we need to do more work there. | 15:54 |
| dhellmann | Expecting developers to remember to call this new function isn't going to scale, though. :-/ | 15:54 |
| haypo | dhellmann: i saw a patch to convert parameters of a lo to unicode | 15:55 |
| haypo | dhellmann: it's a good idea, but i'm not sure that it works with exceptions | 15:56 |
| haypo | dhellmann: the next step would be to modify the logging wrapper to convert exceptions to unicode using exception_to_unicode() | 15:56 |
| haypo | dhellmann: i'm talking about https://review.openstack.org/#/c/163027/ | 15:56 |
| openstackgerrit | Chris Dent proposed openstack/tooz: Use a sentinel connection pool to manage failover https://review.openstack.org/166291 | 15:57 |
| dhellmann | haypo: why does it not work with exceptions? | 15:57 |
| haypo | hum, your patch only changes the formatting string, not parameters | 15:57 |
| dhellmann | yes | 15:58 |
| haypo | dhellmann: i'm stuck at logging.critical(u'error: %s', Exception('\xe9'.encode('utf8')) | 15:58 |
| dhellmann | although there are some cases where an exception is passed as the formatting string | 15:58 |
| haypo | dhellmann: maybe this case never happens in practice? | 15:58 |
| dhellmann | haypo: can you show me a traceback for that? | 15:58 |
| dhellmann | oh, hang on, you're calling encode there? no, I don't think we would ever want someone to do that | 15:58 |
| haypo | dhellmann: see https://review.openstack.org/#/c/163507/1//COMMIT_MSG | 15:58 |
| dhellmann | haypo: do you have a real case in our code where someone is passing an encoded string as the only message to an exception? | 15:59 |
| haypo | dhellmann: '\xe9'.encode('utf8') is just to have a more readable example | 15:59 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Ensure docstring on storage properties https://review.openstack.org/166292 | 15:59 |
| haypo | dhellmann: in python 2, exception messages are almost always bytes. i'm talking about the stdlib (and most 3rd party modules) | 15:59 |
| haypo | dhellmann: I have a meeting. i will try to summarize our discussion and write an email instead :) | 16:00 |
| *** harlowja_at_home has quit IRC | 16:00 | |
| dhellmann | haypo: yes, thanks, I'm also trying to do something else right now so I'm not giving you my full attention. Sorry if that makes this a frustrating conversation. | 16:00 |
| dhellmann | haypo: in general, if there is a "correct" way to call the logging functions that avoids this problem without requiring the developer to know about a library function, that's OK and the bug can be considered in the caller. However, if oslo.log needs to handle cases it is not, we need to fix the problem inside the library. | 16:01 |
| dhellmann | haypo: and if we can fix the bad calls by making the library protect us more, we should also do that | 16:01 |
| dhellmann | haypo: but we can't realistically expect the app developers to find all log calls with exceptions and add a new wrapper function to them | 16:01 |
| *** dimsum__ has quit IRC | 16:02 | |
| *** amotoki has quit IRC | 16:07 | |
| *** amotoki has joined #openstack-oslo | 16:07 | |
| haypo | dhellmann: (no problem) | 16:10 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo-incubator: Drop pylint requirement https://review.openstack.org/166297 | 16:11 |
| *** jecarey has joined #openstack-oslo | 16:13 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.vmware: Move pylint dependency to tox.ini https://review.openstack.org/166298 | 16:14 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 16:17 | |
| *** kbyrne has quit IRC | 16:18 | |
| *** exploreshaifali has quit IRC | 16:19 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 16:20 | |
| *** dimsum__ has joined #openstack-oslo | 16:23 | |
| *** BrianShang_ has joined #openstack-oslo | 16:25 | |
| *** BrianShang has quit IRC | 16:28 | |
| *** sreshetn1 has quit IRC | 16:28 | |
| *** sabari has quit IRC | 16:31 | |
| *** sabari has joined #openstack-oslo | 16:33 | |
| *** amotoki has quit IRC | 16:36 | |
| *** spyyy has quit IRC | 16:37 | |
| *** andreykurilin_ has joined #openstack-oslo | 16:42 | |
| *** yamahata has joined #openstack-oslo | 16:43 | |
| *** viktors has quit IRC | 16:43 | |
| *** harlowja_away is now known as harlowja_ | 16:51 | |
| jungleboyj | dhellmann: You around? Let me know if you have a chance to talk about this: https://review.openstack.org/#/c/165431/ | 16:51 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 16:53 | |
| *** sreshetn1 has joined #openstack-oslo | 16:58 | |
| *** spyyy has joined #openstack-oslo | 17:09 | |
| *** e0ne has quit IRC | 17:11 | |
| *** achanda has joined #openstack-oslo | 17:15 | |
| *** pblaho has quit IRC | 17:20 | |
| *** openstackgerrit has quit IRC | 17:21 | |
| *** openstackgerrit has joined #openstack-oslo | 17:22 | |
| *** kgiusti has quit IRC | 17:22 | |
| *** sreshetn1 has quit IRC | 17:24 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Ensure periodic freshening of the job board contents https://review.openstack.org/165989 | 17:37 |
| *** sputnik13 has joined #openstack-oslo | 17:37 | |
| *** sreshetn1 has joined #openstack-oslo | 17:40 | |
| *** spyyy has quit IRC | 17:42 | |
| openstackgerrit | Clint 'SpamapS' Byrum proposed openstack/oslo.messaging: Add a gearman/gearstore/gearhorn driver https://review.openstack.org/165646 | 17:44 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Ensure we are really setup before being connected https://review.openstack.org/166329 | 17:45 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Ensure we are really setup before being connected https://review.openstack.org/166329 | 17:46 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Ensure we are really setup before being connected https://review.openstack.org/166329 | 17:47 |
| *** andreykurilin_ has quit IRC | 17:54 | |
| *** shardy has quit IRC | 18:01 | |
| *** e0ne has joined #openstack-oslo | 18:05 | |
| dhellmann | jungleboyj: looking now | 18:14 |
| jungleboyj | dhellmann: Thanks. | 18:15 |
| dhellmann | jungleboyj: one thing I noticed is the list of options is all being reported as though they belong under the default group, but I don't think that's true | 18:17 |
| dhellmann | jungleboyj: for example, the keymgr options should be in the 'keymgr' group, right? | 18:17 |
| dhellmann | jungleboyj: hmm, the thing with the dynamic option registration by drivers is interesting, too. What's the background there? e.g., fc_fabric_names | 18:20 |
| *** spyyy has joined #openstack-oslo | 18:21 | |
| *** kgiusti has joined #openstack-oslo | 18:23 | |
| dhellmann | jungleboyj: I left some comments on the review | 18:32 |
| *** crc32 has joined #openstack-oslo | 18:35 | |
| *** dougwig has quit IRC | 18:39 | |
| jungleboyj | dhellmann: Sorry, got pulled into a meeting. | 18:47 |
| dhellmann | jungleboyj: np, that's what I figured | 18:47 |
| dhellmann | jungleboyj: let me know if my comments make sense :-) | 18:47 |
| jungleboyj | dhellmann: Let me go take a look. I think you are right. Some of those options do need to be put into a different section. You are right. | 18:48 |
| dhellmann | jungleboyj: also the thing about layering the functions, so you don't have one big list of imports there | 18:49 |
| jungleboyj | dhellmann: Some of the FC options are dynamically added depending on other options that are enabled. Wasn't sure how to deal with that. | 18:49 |
| dhellmann | jungleboyj: if you want your config file to be complete, always add them | 18:49 |
| dhellmann | I'm not sure we intended for options to be defined conditionally like that. maybe not used, but not defining them is an interesting pattern | 18:49 |
| *** mvandijk has left #openstack-oslo | 18:49 | |
| jungleboyj | dhellmann: Yeah, that made me uncomfortable when I found it. :-) Anyway, let me look at your comments here. | 18:51 |
| *** sreshetn2 has joined #openstack-oslo | 18:51 | |
| dhellmann | jungleboyj: I'm not sure it's wrong, it's just unexpected :-) | 18:51 |
| jungleboyj | Indeed. | 18:52 |
| *** sreshetn1 has quit IRC | 18:52 | |
| *** pradk has joined #openstack-oslo | 18:55 | |
| *** pradk has quit IRC | 18:55 | |
| jungleboyj | dhellmann: So, your reponses make sense I think. Take the base_san_opts and put them in the driver file. Similarly to the way we have cinder/opts.py set up so they don't have to be manually added in cinder/opts.py | 18:55 |
| jungleboyj | dhellmann: You are right that I need to move some of the imported opts to a non-default section. I cna fix that. | 18:56 |
| dhellmann | jungleboyj: ok, good, I'll watch for an updated draft to review | 18:56 |
| jungleboyj | dhellmann: On the deepcopy() You mean put that around the whole value that is being returned? | 18:56 |
| *** prad has quit IRC | 18:56 | |
| dhellmann | jungleboyj: yeah, or just leave it out. Someone was being paranoid in the docs, and we ended up with that being a pattern | 18:57 |
| jungleboyj | Ok, I can fix that. | 18:57 |
| jungleboyj | So, the bigger question still remains. | 18:57 |
| dhellmann | it's more likely to be important to do that in a lib, where someone might get to the list_opts and do something tricky than with the app | 18:57 |
| *** e0ne has quit IRC | 18:57 | |
| jungleboyj | Winston-D wants me to not create cinder/opts.py . He thinks we should write a program to dynamically generate it for oslo-config-generator to then use. | 18:58 |
| *** e0ne has joined #openstack-oslo | 18:58 | |
| dhellmann | that brings you back to the same problem we were trying to solve by moving away from scanning code | 18:58 |
| jungleboyj | He is concerned that I am putting us back in the state where we are going to have failures in the gate like we had with check_uptodate.py run. | 18:58 |
| dhellmann | something has to find all of the options, and it has to emit them all in the right format | 18:59 |
| *** prad has joined #openstack-oslo | 18:59 | |
| dhellmann | I don't follow that | 18:59 |
| jungleboyj | :-) | 18:59 |
| jungleboyj | dhellmann: He is concerned that we will have people not running unit test and pushing up their changes and the gate failing on my hacking check, which really is the whole point of that check. | 19:00 |
| jungleboyj | dhellmann: They don't want the developers to have to do additional work editing cinder/opts.py | 19:00 |
| jungleboyj | dhellmann: He wants me to just automatically go through the code and generate cinder/opts.py when tox -egenconfig is run. | 19:01 |
| jungleboyj | Wondering what you think about that. | 19:01 |
| jungleboyj | I explained that it is not consistent with what other projects are doing. | 19:01 |
| dhellmann | yeah, I wouldn't do that. | 19:02 |
| dhellmann | As you move the list_opt functions lower in the code, you'll find that the duplication of options happens there | 19:02 |
| ihrachyshka | dhellmann, hey. any plans for oslo.messaging releases till the end of Kilo? | 19:03 |
| ihrachyshka | dhellmann, I wonder whether we can get a release with https://review.openstack.org/#/c/163673/ included. | 19:03 |
| dhellmann | It will be natural to replace calls to register_opts() with explicit variable references to once that call those lower-level functions to get the option lists and groups | 19:03 |
| dhellmann | ihrachyshka: did someone backport that to the stable/kilo branch? | 19:03 |
| ihrachyshka | oh, there is one... | 19:04 |
| ihrachyshka | ok, got it | 19:04 |
| dhellmann | ihrachyshka: yeah, we've cut our stable releases for kilo already, so fixes that need to go into the apps need to be backported | 19:04 |
| jungleboyj | dhellmann: Sorry, not following you. | 19:04 |
| dhellmann | ihrachyshka: there are several like that for messaging, I meant to poke sileht about it | 19:04 |
| ihrachyshka | dhellmann, I missed that somehow. (probably my brain is leaking these days.) so backport: https://review.openstack.org/#/c/166349/ | 19:04 |
| dhellmann | jungleboyj: say you create a little list_opts down in cinder.keymgr. It's going to look like def list_opts(): return [(local_var_defining_group_name, local_var_defining_list_of_opts)] | 19:05 |
| dhellmann | jungleboyj: so then instead of calling register_opts(local_var_defining_list_of_opts, group=local_var_defining_group_name) it would be natural to loop over the return value of list_opts() | 19:06 |
| dhellmann | jungleboyj: so now you're back to only having to edit the list of options in one place | 19:06 |
| jungleboyj | dhellmann: No, what I was thinking was basically writing something like what my hacking check is doing. It would check every file for register_opts() and dynamically create the cinder/opts.py file. | 19:07 |
| *** achanda has quit IRC | 19:07 | |
| jungleboyj | dhellmann: Oh wait, so you are saying move the list_opts down into each file? | 19:08 |
| dhellmann | jungleboyj: potentially, whatever level makes sense | 19:08 |
| *** e0ne has quit IRC | 19:08 | |
| jungleboyj | dhellmann: Then how do we know where all we need to do list_opts at? | 19:08 |
| dhellmann | there is no "you should do it this way" answer to your question, so I'm trying to propose alternatives that move you in the direction you want to go. | 19:08 |
| dhellmann | well, how often do you add whole new modules? | 19:09 |
| jungleboyj | dhellmann: Ah, whenever volume developers add a new driver. | 19:09 |
| dhellmann | I mean, I understand the problem you're trying to solve, I'm just not sure how big of a problem it really is | 19:10 |
| jungleboyj | :-) Agreed. | 19:10 |
| *** e0ne has joined #openstack-oslo | 19:10 | |
| dhellmann | I sort of thought the drivers issue would be solved with a separate entry point for each driver. That would be an easy check to automate. | 19:11 |
| dhellmann | it would mean you'd have a long list of modules in the generator config, but that's not too big of a deal since you only add the entry when a new module is created | 19:11 |
| dhellmann | that also has the benefit of clearly indicating in the sample config output which options are coming from the app, and which are coming from the driver | 19:12 |
| jungleboyj | Yeah, that would also require adding the list_opts() function to each file. Correct? | 19:13 |
| *** exploreshaifali has joined #openstack-oslo | 19:13 | |
| dhellmann | yeah, one per driver somewhere | 19:13 |
| dhellmann | for the rest of the code, I'd stick with one per package probably | 19:13 |
| jungleboyj | That, however, would make it clearer where the options were coming from, right? | 19:13 |
| dhellmann | right | 19:14 |
| jungleboyj | Ok, so that makes sense for the drivers. | 19:15 |
| jungleboyj | What do you mean one one per package? | 19:15 |
| dhellmann | cinder.api, cinder.db, cinder.scheduler, etc. | 19:15 |
| dhellmann | otherwise you end up with a million functions | 19:15 |
| dhellmann | what I'm worried about is the duplication of the group name setting | 19:16 |
| openstackgerrit | Merged openstack/oslo.messaging: rabbit: fix ipv6 support https://review.openstack.org/165831 | 19:16 |
| jungleboyj | Gotcha. Which means for those we are going to have to move those options into one file per package? | 19:16 |
| dhellmann | jungleboyj: let me look more closely at some of the existing option definitions - how many app options don't go in the default group? | 19:16 |
| jungleboyj | dhellmann: Let me look. | 19:17 |
| *** e0ne has quit IRC | 19:19 | |
| jungleboyj | dhellmann: We have [DEFAULT] , a few sections for zonemanager set up. [database] [keymgr] couple from keystone, few from oslo_messaging and [profiler] | 19:20 |
| jungleboyj | dhellmann: So, really all those others do fall under [DEFAULT] | 19:20 |
| dhellmann | ok | 19:20 |
| dhellmann | so that eases my concern about duplicating group names a bit since there aren't a bunch of them | 19:20 |
| * jungleboyj is starting to wonder if I need to create an L spec for this though. | 19:21 | |
| dhellmann | is the other main concern with modifying the list in 2 places? or missing something? or what? | 19:21 |
| *** achanda has joined #openstack-oslo | 19:21 | |
| jungleboyj | dhellmann: The main concern is with developers having to update cinder/opts.py if they add a new option list. | 19:22 |
| dhellmann | ok. I don't think there's a realistic way to get around being explicit with adding new things. That's sort of the point with this new approach. | 19:22 |
| dhellmann | so the question is how to make it easy to not forget | 19:22 |
| dhellmann | and that comes down to having fewer lists of options, so new lists aren't needed as often, or to combining the lists in some other way | 19:23 |
| dhellmann | but if you add a new module, it's going to have to be plumbed in | 19:23 |
| jungleboyj | dhellmann: That was what I tried to communicate. | 19:24 |
| dhellmann | the benefit is you can do things like generate example sections for options that may only be registered if a device exists (something I think ironic and cinder both wanted) | 19:24 |
| dhellmann | and you can use different namespaces to generate different sample configs for different services, which several projects want to do | 19:25 |
| dhellmann | (nova compute, nova conductor, etc.) | 19:25 |
| *** sreshetn2 has quit IRC | 19:25 | |
| *** tsekiyama has joined #openstack-oslo | 19:28 | |
| *** tsekiyama has quit IRC | 19:29 | |
| *** tsekiyama_ has joined #openstack-oslo | 19:30 | |
| jungleboyj | dhellmann: So, here is what I am thinking: | 19:30 |
| jungleboyj | dhellmann: Feels like this needs to be fleshed out more before being implemented. | 19:31 |
| *** exploreshaifali has quit IRC | 19:31 | |
| dhellmann | jungleboyj: possibly | 19:31 |
| jungleboyj | dhellmann: Think I may try to summarize our discussion to the mailing list and tag nova, cinder and neutron. Point out what I currently have in place and propose the idea of doing a more /driver /package entry point design. | 19:32 |
| dhellmann | jungleboyj: that seems like a good plan | 19:33 |
| jungleboyj | This may then need to get moved out to L, but I would rather have that happen and get it right. | 19:33 |
| jungleboyj | Let me go write that note while it is fresh in my head. | 19:34 |
| *** sreshetn2 has joined #openstack-oslo | 19:34 | |
| *** yamahata has quit IRC | 19:36 | |
| jungleboyj | dhellmann: Thanks for being so helpful! | 19:37 |
| *** yamahata has joined #openstack-oslo | 19:37 | |
| dhellmann | jungleboyj: thanks for thinking this through! | 19:39 |
| jungleboyj | :-) I am learning a lot. Kind-of fun to blaze the trail. | 19:39 |
| *** andreykurilin_ has joined #openstack-oslo | 19:41 | |
| *** ihrachyshka has quit IRC | 19:44 | |
| *** andreykurilin_ has quit IRC | 20:01 | |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.concurrency: Remove tools/run_cross_tests.sh from openstack-common.conf https://review.openstack.org/166359 | 20:03 |
| openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Sync with latest oslo-incubator https://review.openstack.org/166361 | 20:05 |
| *** ChuckC has quit IRC | 20:05 | |
| *** dougwig has joined #openstack-oslo | 20:13 | |
| *** sreshetn2 has quit IRC | 20:17 | |
| *** ndipanov has quit IRC | 20:23 | |
| *** andreykurilin_ has joined #openstack-oslo | 20:34 | |
| openstackgerrit | Assaf Muller proposed openstack/oslo.messaging: Remove 'UNIQUE_ID is %s' spam https://review.openstack.org/166372 | 20:38 |
| *** jaosorior has quit IRC | 20:52 | |
| *** spyyy has quit IRC | 20:55 | |
| *** spyyy has joined #openstack-oslo | 21:13 | |
| *** kgiusti has left #openstack-oslo | 21:32 | |
| *** jamielennox|away is now known as jamielennox | 21:49 | |
| *** mriedem has quit IRC | 21:54 | |
| *** gordc has quit IRC | 21:58 | |
| *** jamielennox is now known as jamielennox|away | 22:05 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Have conductors be disconnected from builder helper methods https://review.openstack.org/166398 | 22:14 |
| openstackgerrit | Assaf Muller proposed openstack/oslo.messaging: Remove 'UNIQUE_ID is %s' logging https://review.openstack.org/166372 | 22:15 |
| *** amuller has joined #openstack-oslo | 22:22 | |
| amuller | dhellmann: new version up for https://review.openstack.org/#/c/166372/ | 22:22 |
| amuller | this time with less venomous phrasing :) | 22:23 |
| *** prad has quit IRC | 22:25 | |
| *** bknudson has quit IRC | 22:36 | |
| *** mriedem has joined #openstack-oslo | 22:44 | |
| openstackgerrit | Merged openstack/oslo.concurrency: Remove tools/run_cross_tests.sh from openstack-common.conf https://review.openstack.org/166359 | 22:54 |
| *** dimsum__ has quit IRC | 22:58 | |
| *** andreykurilin_ has quit IRC | 22:58 | |
| *** dimsum__ has joined #openstack-oslo | 22:59 | |
| *** dimsum__ is now known as dims | 23:00 | |
| *** boris-42 has joined #openstack-oslo | 23:02 | |
| *** mtanino has quit IRC | 23:08 | |
| *** tsekiyam_ has joined #openstack-oslo | 23:11 | |
| *** tsekiyama_ has quit IRC | 23:15 | |
| *** tsekiyam_ has quit IRC | 23:16 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Ensure thread-safety of persistence dir backend https://review.openstack.org/166417 | 23:20 |
| harlowja_ | dhellmann i think https://review.openstack.org/#/c/166404/ should fix the root cause for your need to make https://review.openstack.org/#/c/166377/ | 23:22 |
| harlowja_ | fyi | 23:22 |
| *** achanda has quit IRC | 23:24 | |
| *** achanda has joined #openstack-oslo | 23:26 | |
| *** harlowja_ has quit IRC | 23:41 | |
| *** harlowja has joined #openstack-oslo | 23:42 | |
| openstackgerrit | Merged openstack/oslo.vmware: Move pylint dependency to tox.ini https://review.openstack.org/166298 | 23:48 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!