*** dims has quit IRC | 00:04 | |
*** achanda has joined #openstack-oslo | 00:09 | |
*** li-ma has quit IRC | 00:14 | |
*** li-ma has joined #openstack-oslo | 00:14 | |
*** li-ma has quit IRC | 00:20 | |
*** dims has joined #openstack-oslo | 00:22 | |
*** YorikSar has quit IRC | 00:25 | |
*** li-ma has joined #openstack-oslo | 00:30 | |
*** bknudson has joined #openstack-oslo | 00:43 | |
*** ChuckC has quit IRC | 00:44 | |
*** cpg is now known as cpg|away | 00:46 | |
*** ujjain has quit IRC | 00:48 | |
*** BrianShang_ has joined #openstack-oslo | 00:54 | |
*** BrianShang has quit IRC | 00:56 | |
*** sputnik13 has quit IRC | 00:58 | |
*** redrobot has quit IRC | 00:59 | |
*** tteggel_ has quit IRC | 01:00 | |
*** amauryme` has quit IRC | 01:01 | |
*** jgrimm has quit IRC | 01:01 | |
*** tteggel has joined #openstack-oslo | 01:01 | |
*** jgrimm has joined #openstack-oslo | 01:02 | |
*** amaurymedeiros has joined #openstack-oslo | 01:05 | |
*** amaurymedeiros has quit IRC | 01:05 | |
*** amaurymedeiros has joined #openstack-oslo | 01:05 | |
*** redrobot has joined #openstack-oslo | 01:06 | |
*** redrobot is now known as Guest48074 | 01:06 | |
*** stevemar has quit IRC | 01:07 | |
*** li-ma has quit IRC | 01:18 | |
*** kiseok7_ has joined #openstack-oslo | 01:33 | |
*** takedakn has joined #openstack-oslo | 01:38 | |
*** harlowja is now known as harlowja_away | 01:52 | |
*** amrith is now known as _amrith_ | 01:54 | |
*** yamahata has quit IRC | 01:59 | |
*** elarson has quit IRC | 02:00 | |
*** li-ma has joined #openstack-oslo | 02:03 | |
*** takedakn has quit IRC | 02:06 | |
*** li-ma has quit IRC | 02:30 | |
*** li-ma has joined #openstack-oslo | 02:34 | |
*** takedakn has joined #openstack-oslo | 02:46 | |
*** takedakn has quit IRC | 02:49 | |
*** cpg|away is now known as cpg | 02:58 | |
*** max_lobur has quit IRC | 02:59 | |
*** achanda has quit IRC | 03:03 | |
*** li-ma has quit IRC | 03:12 | |
*** achanda has joined #openstack-oslo | 03:16 | |
*** sputnik13 has joined #openstack-oslo | 03:32 | |
*** achanda has quit IRC | 03:36 | |
*** links has joined #openstack-oslo | 03:45 | |
*** achanda has joined #openstack-oslo | 03:45 | |
*** zzzeek has joined #openstack-oslo | 03:46 | |
*** stevemar has joined #openstack-oslo | 03:46 | |
*** rushiagr_away is now known as rushiagr | 03:58 | |
*** achanda has quit IRC | 04:02 | |
*** subscope has quit IRC | 04:07 | |
*** YorikSar has joined #openstack-oslo | 04:27 | |
*** achanda has joined #openstack-oslo | 04:45 | |
*** dougwig has quit IRC | 04:46 | |
*** zhiyan has quit IRC | 04:46 | |
*** zhiyan has joined #openstack-oslo | 04:47 | |
*** dougwig has joined #openstack-oslo | 04:48 | |
*** YorikSar has quit IRC | 04:58 | |
*** zzzeek has quit IRC | 05:11 | |
*** rushiagr is now known as rushiagr_away | 05:20 | |
*** mdbooth has quit IRC | 05:32 | |
*** sreshetn1 has joined #openstack-oslo | 05:36 | |
*** arnaud___ has joined #openstack-oslo | 05:37 | |
*** mdbooth has joined #openstack-oslo | 05:38 | |
*** achanda has quit IRC | 05:57 | |
*** YorikSar has joined #openstack-oslo | 05:58 | |
*** BrianShang_ has quit IRC | 06:06 | |
*** achanda has joined #openstack-oslo | 06:26 | |
*** rushiagr_away is now known as rushiagr | 06:29 | |
*** ihrachyshka has joined #openstack-oslo | 06:31 | |
*** ttx has quit IRC | 06:44 | |
*** ttx has joined #openstack-oslo | 06:44 | |
*** ihrachyshka has quit IRC | 06:47 | |
*** arnaud___ has quit IRC | 06:51 | |
*** e0ne has joined #openstack-oslo | 07:09 | |
*** stevemar has quit IRC | 07:18 | |
*** e0ne has quit IRC | 07:20 | |
*** amotoki has joined #openstack-oslo | 07:23 | |
*** e0ne has joined #openstack-oslo | 07:24 | |
*** achanda has quit IRC | 07:33 | |
*** achanda has joined #openstack-oslo | 07:33 | |
*** ihrachyshka has joined #openstack-oslo | 07:37 | |
*** e0ne has quit IRC | 07:40 | |
openstackgerrit | Tiantian Gao proposed openstack/oslo.messaging: Do not skip functional test for amqp driver https://review.openstack.org/170369 | 07:41 |
---|---|---|
*** spyyy has joined #openstack-oslo | 07:45 | |
*** ihrachyshka has quit IRC | 07:47 | |
*** sreshetn1 has quit IRC | 07:48 | |
*** arnaud___ has joined #openstack-oslo | 07:51 | |
*** arnaud___ has quit IRC | 07:56 | |
*** dulek has joined #openstack-oslo | 07:57 | |
*** sreshetn1 has joined #openstack-oslo | 08:01 | |
*** dims has quit IRC | 08:03 | |
*** rushiagr is now known as rushiagr_away | 08:04 | |
*** sreshetn1 has quit IRC | 08:20 | |
*** e0ne has joined #openstack-oslo | 08:28 | |
*** sreshetn1 has joined #openstack-oslo | 08:30 | |
*** sreshetn1 has quit IRC | 08:35 | |
*** salv-orlando has quit IRC | 08:40 | |
*** cpg is now known as cpg|away | 08:40 | |
*** ndipanov has joined #openstack-oslo | 08:46 | |
*** e0ne is now known as e0ne_ | 08:48 | |
*** e0ne_ is now known as e0ne | 08:49 | |
*** andreykurilin_ has joined #openstack-oslo | 08:50 | |
*** ihrachyshka has joined #openstack-oslo | 08:52 | |
*** arnaud___ has joined #openstack-oslo | 08:52 | |
*** sreshetn1 has joined #openstack-oslo | 08:53 | |
*** achanda has quit IRC | 08:55 | |
*** achanda has joined #openstack-oslo | 08:55 | |
*** arnaud___ has quit IRC | 08:57 | |
*** salv-orlando has joined #openstack-oslo | 08:57 | |
*** sreshetn1 has quit IRC | 08:59 | |
*** subscope has joined #openstack-oslo | 09:02 | |
*** rushiagr_away is now known as rushiagr | 09:09 | |
*** achanda has quit IRC | 09:25 | |
*** achanda has joined #openstack-oslo | 09:28 | |
*** achanda has quit IRC | 09:28 | |
*** achanda has joined #openstack-oslo | 09:30 | |
*** sreshetn1 has joined #openstack-oslo | 09:31 | |
*** bnemec has quit IRC | 09:33 | |
*** rushiagr is now known as rushiagr_away | 09:43 | |
*** andreykurilin_ has quit IRC | 09:50 | |
*** rushiagr_away is now known as rushiagr | 09:58 | |
*** achanda has quit IRC | 10:02 | |
*** dims has joined #openstack-oslo | 10:12 | |
*** dims has quit IRC | 10:13 | |
*** bnemec has joined #openstack-oslo | 10:19 | |
*** dims has joined #openstack-oslo | 10:20 | |
*** sreshetn1 has quit IRC | 10:42 | |
*** sreshetn1 has joined #openstack-oslo | 10:48 | |
*** sputnik13 has quit IRC | 10:52 | |
*** sreshetn1 has quit IRC | 10:52 | |
*** dulek_ has joined #openstack-oslo | 10:55 | |
*** sreshetn1 has joined #openstack-oslo | 10:57 | |
*** dulek has quit IRC | 10:59 | |
*** sreshetn1 has quit IRC | 11:09 | |
*** sreshetn1 has joined #openstack-oslo | 11:10 | |
*** pblaho has joined #openstack-oslo | 11:12 | |
*** e0ne is now known as e0ne_ | 11:25 | |
openstackgerrit | Merged openstack/oslo.messaging: Do not skip functional test for amqp driver https://review.openstack.org/170369 | 11:29 |
openstackgerrit | Merged openstack/oslo.serialization: Make the msgpackutils handlers more extendable https://review.openstack.org/156013 | 11:35 |
*** e0ne_ has quit IRC | 11:35 | |
dhellmann | good morning, everyone | 11:40 |
*** alexpilotti has joined #openstack-oslo | 11:42 | |
dhellmann | dims: I'm not sure why https://review.openstack.org/#/c/163027/ didn't merge - maybe it actually needs 2 +2 votes? /cc bnemec | 11:45 |
*** ndipanov is now known as ndipanoff | 11:51 | |
sdague | dhellmann: no workflow bit | 11:55 |
sdague | dims added it, then removed it | 11:56 |
dhellmann | sdague: ah, missed that | 11:56 |
sdague | when he added it it would have entered the gate | 11:56 |
sdague | but zuul wouldn't have merged it when it passed because W was missing | 11:56 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Add `versionutils` for version compatibility checks https://review.openstack.org/170452 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Remove vim header https://review.openstack.org/170453 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Adds decorator to deprecate functions and methods https://review.openstack.org/170454 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Fix violations of H302:import only modules https://review.openstack.org/170455 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: fixed typos https://review.openstack.org/170456 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Use hacking import_exceptions for gettextutils._ https://review.openstack.org/170457 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Use oslotest instead of common test module https://review.openstack.org/170458 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: pep8: fixed multiple violations https://review.openstack.org/170459 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Add JUNO as a target to versionutils module https://review.openstack.org/170460 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Allow deprecated decorator to specify no plan for removal https://review.openstack.org/170461 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Add Kilo release name to versionutils https://review.openstack.org/170462 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Enhance versionutils.deprecated to work with classes https://review.openstack.org/170463 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Remove code that moved to oslo.i18n https://review.openstack.org/170464 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Remove oslo.log code and clean up versionutils API https://review.openstack.org/170465 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Switch from oslo.config to oslo_config https://review.openstack.org/170466 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Expose opts entry point for version_utils https://review.openstack.org/170467 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Add liberty release name to versionutils https://review.openstack.org/170468 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Move versionutils into place and remove deprecation tools https://review.openstack.org/170469 | 12:09 |
openstackgerrit | Doug Hellmann proposed openstack/oslo-specs: graduate-oslo-versionutils https://review.openstack.org/167737 | 12:11 |
*** stpierre has joined #openstack-oslo | 12:16 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Remove is_compatible from versionutils https://review.openstack.org/170471 | 12:16 |
sdague | dhellmann: oof, you pushed a giant series with early pep8 fails | 12:18 |
*** _amrith_ is now known as amrith | 12:18 | |
dhellmann | sdague: hmm, those were passing for me here -- they're old commits imported from the incubator :-/ | 12:19 |
sdague | 2015-04-03 12:15:28.384 | ./tests/unit/test_versionutils.py:19:1: H307 like imports should be grouped together (testtools.matchers and openstack.common.test from third-party are separated by whitespace) | 12:19 |
sdague | 2015-04-03 12:15:28.384 | from openstack.common import test | 12:19 |
sdague | 2015-04-03 12:15:28.384 | ^ | 12:19 |
dhellmann | I wonder how that passed in the oslo.log repo when the changes went there | 12:20 |
dhellmann | did we update hacking or something? | 12:20 |
*** e0ne has joined #openstack-oslo | 12:21 | |
sdague | the kilo cycle hacking is - hacking<0.11,>=0.10.0 | 12:21 |
sdague | so it looks like this never updated | 12:21 |
sdague | H307 was dropped because it does bogus things like this | 12:21 |
*** prad has joined #openstack-oslo | 12:25 | |
dhellmann | ah, so we haven't updated it in oslo.utils yet | 12:25 |
*** pblaho_ has joined #openstack-oslo | 12:27 | |
viktors | dhellmann: as for patches ^ - should openstack/common/versionutils.py be added similar to sync from oslo-incubator? | 12:28 |
viktors | *in a similar way | 12:28 |
dhellmann | viktors: I'm not sure what you mean? | 12:28 |
sdague | dhellmann: some of these patches are weird - https://review.openstack.org/#/c/170455/1 and https://review.openstack.org/#/c/170457/1 which just set then invert the same thing | 12:28 |
viktors | dhellmann: I mean, add versionutils to openstack-common.conf and run sync script | 12:29 |
*** ihrachyshka has quit IRC | 12:29 | |
dhellmann | sdague: I'm importing the history of that module from the incubator, so we want it intact | 12:29 |
sdague | ah.... gotcha | 12:30 |
dhellmann | viktors: no, we're moving the file and we want to take all of its history | 12:30 |
dims | hey dhellmann, weclome back :) | 12:30 |
dhellmann | sdague: https://review.openstack.org/167737 is the spec | 12:30 |
dhellmann | dims: thanks! :-) | 12:30 |
sdague | ok, is there missing tox.ini changes to go with all that? | 12:30 |
sdague | because those commits and those commit messages don't seem to match | 12:30 |
sdague | maybe that's just what happens in these cases | 12:31 |
*** pblaho has quit IRC | 12:31 | |
*** pblaho__ has joined #openstack-oslo | 12:31 | |
dhellmann | sdague: yeah, the filter script removes files from commits, so the messages may no longer match exactly what changes are being made | 12:32 |
*** pblaho_ has quit IRC | 12:32 | |
viktors | dhellmann: it seems to be, that I missed something. Is there any bp/etherpad/spec about it ? | 12:32 |
dhellmann | we normally don't see this, because it normally turns into a new library without the old commits being reviewed | 12:32 |
dhellmann | viktors: https://review.openstack.org/167737 | 12:32 |
viktors | thanks | 12:32 |
sdague | dhellmann: you fixing the hacking thing, or would you like me to? | 12:33 |
dhellmann | sdague: i'm going to submit it as the first patch in my series | 12:34 |
sdague | ok, coolio | 12:34 |
dhellmann | running the tests locally now to make sure it works | 12:34 |
dhellmann | there has to be a more clever way to do this than: while tox -e pep8,py27 && git rebase --continue ; do echo ; done | 12:34 |
dhellmann | does git have something like this? | 12:35 |
*** sreshetn1 has quit IRC | 12:36 | |
sdague | git-bisect ? | 12:36 |
*** e0ne is now known as e0ne_ | 12:37 | |
dhellmann | yeah, I suppose that would have been another way to do it | 12:37 |
*** e0ne_ is now known as e0ne | 12:37 | |
dhellmann | although I wouldn't want it to skip around -- I would want to fix commits as needed, so doing them sequentially would be better | 12:39 |
*** miqui has joined #openstack-oslo | 12:42 | |
*** sreshetn1 has joined #openstack-oslo | 12:47 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Add liberty release name to versionutils https://review.openstack.org/170468 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Move versionutils into place and remove deprecation tools https://review.openstack.org/170469 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Switch from oslo.config to oslo_config https://review.openstack.org/170466 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Expose opts entry point for version_utils https://review.openstack.org/170467 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Remove code that moved to oslo.i18n https://review.openstack.org/170464 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Remove oslo.log code and clean up versionutils API https://review.openstack.org/170465 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Remove vim header https://review.openstack.org/170453 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Add `versionutils` for version compatibility checks https://review.openstack.org/170452 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Fix violations of H302:import only modules https://review.openstack.org/170455 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Adds decorator to deprecate functions and methods https://review.openstack.org/170454 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Allow deprecated decorator to specify no plan for removal https://review.openstack.org/170461 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Add JUNO as a target to versionutils module https://review.openstack.org/170460 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Enhance versionutils.deprecated to work with classes https://review.openstack.org/170463 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Add Kilo release name to versionutils https://review.openstack.org/170462 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Use hacking import_exceptions for gettextutils._ https://review.openstack.org/170457 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: fixed typos https://review.openstack.org/170456 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: pep8: fixed multiple violations https://review.openstack.org/170459 | 12:51 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.utils: Use oslotest instead of common test module https://review.openstack.org/170458 | 12:51 |
*** sreshetn1 has quit IRC | 12:53 | |
*** pblaho__ is now known as pblaho | 12:56 | |
*** pblaho has joined #openstack-oslo | 12:56 | |
*** bknudson has quit IRC | 13:00 | |
*** dulek_ has quit IRC | 13:00 | |
*** dims has quit IRC | 13:01 | |
*** dims has joined #openstack-oslo | 13:02 | |
*** elarson has joined #openstack-oslo | 13:18 | |
*** sreshetn1 has joined #openstack-oslo | 13:26 | |
*** mriedem_away is now known as mriedem | 13:26 | |
*** miqui has quit IRC | 13:29 | |
*** bknudson has joined #openstack-oslo | 13:30 | |
*** amotoki has quit IRC | 13:33 | |
*** openstackgerrit has quit IRC | 13:36 | |
*** openstackgerrit has joined #openstack-oslo | 13:36 | |
*** jecarey has joined #openstack-oslo | 13:39 | |
*** rushiagr is now known as rushiagr_away | 13:41 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:43 | |
openstackgerrit | Merged openstack/oslo.policy: Lists for Generic Checks https://review.openstack.org/169045 | 13:49 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: Update hacking to kilo level https://review.openstack.org/170494 | 13:55 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.context: Update to latest hacking https://review.openstack.org/170495 | 13:58 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.db: Update to latest hacking https://review.openstack.org/170496 | 13:59 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.log: Update to latest hacking https://review.openstack.org/170497 | 14:02 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.middleware: Update to latest hacking https://review.openstack.org/170498 | 14:03 |
*** sdake has joined #openstack-oslo | 14:03 | |
sdake | hey quick question about versioned objects support | 14:03 |
sdake | anyone around that knows about this code? | 14:03 |
dhellmann | sdake: you likely want dansmith | 14:04 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.rootwrap: Update to latest hacking https://review.openstack.org/170499 | 14:04 |
sdake | dhellman thanks ill ping him | 14:04 |
sdake | dansmith happen to have 5 minutes to answer some basic q's about versioned objects? | 14:05 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.versionedobjects: Update to the latest version of hacking https://review.openstack.org/170503 | 14:08 |
*** exploreshaifali has joined #openstack-oslo | 14:09 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.vmware: Update to latest hacking https://review.openstack.org/170506 | 14:11 |
openstackgerrit | Doug Hellmann proposed openstack/oslosphinx: Update to latest hacking https://review.openstack.org/170507 | 14:12 |
openstackgerrit | Doug Hellmann proposed openstack/oslotest: Update to latest hacking https://review.openstack.org/170508 | 14:13 |
*** zul has quit IRC | 14:13 | |
*** zul has joined #openstack-oslo | 14:14 | |
dansmith | sdake: yeah | 14:20 |
dansmith | sdake: I'm supposed to be out today, so... | 14:22 |
* dansmith taps his watch | 14:22 | |
sdake | dansmith is it a normal design pattern to create a version object in the api -> https://github.com/openstack/magnum/blob/master/magnum/api/controllers/v1/pod.py#L247 | 14:22 |
sdake | sorry was gettinga link :) | 14:22 |
*** jungleboyj has joined #openstack-oslo | 14:22 | |
sdake | this model seems to work reallly well for magnum | 14:22 |
dansmith | sdake: yep, pretty normal | 14:23 |
sdake | then when it gets to the rpc server (or daemon process) it autoconverts into a new versioned object | 14:23 |
sdake | cool so not doing anything out of the ordinary? | 14:23 |
dansmith | what do you mean "autoconverts to a new versioned object" ? | 14:23 |
sdake | I copied ironic's code base early on for magnum - based upon suggestions from asalkeld | 14:23 |
sdake | dansmith I mean it comes into the rpc server as a versioned object | 14:24 |
sdake | kind of automatically | 14:24 |
sdake | not quite sure how that part works ;) | 14:24 |
dansmith | sdake: you mean it serializes and deserializes so you get an actual object on the other side? that's ... kinda the idea :) | 14:24 |
sdake | its like somehow the object is serialized/deserialized automatically | 14:24 |
dansmith | hah | 14:24 |
dansmith | yeah, that's the whole point here :) | 14:24 |
sdake | right | 14:24 |
dansmith | well, one of the whole points | 14:24 |
sdake | it rocks :) | 14:24 |
dansmith | \o/ | 14:25 |
sdake | is it hard to convert to the oslo version of the library? | 14:25 |
dansmith | it will be some work for nova for $old_reasons, | 14:25 |
dansmith | but if you copied ironic, it should be much easier | 14:25 |
sdake | nice | 14:25 |
sdake | ya all that code in ironic rocks | 14:25 |
sdake | if I started a new project today I'd copy ironic | 14:26 |
sdake | not fork but copy | 14:26 |
dansmith | the library is really just a lift of the code, but with some cleanups we've been wanting to make for a long time | 14:26 |
dansmith | the major one is we removed the metaclass | 14:26 |
dansmith | because it causes problems automatically registering everything at times, | 14:26 |
dansmith | where you want to be able to disable something, objects for testing, etc | 14:26 |
dansmith | so now there is just a decorator that says "make this a thing I can send" | 14:26 |
sdake | is there still an as_dict()? | 14:28 |
sdake | we rely on that | 14:28 |
dansmith | that's an ironic thing | 14:28 |
*** rushiagr_away is now known as rushiagr | 14:28 | |
dansmith | for anything like that, you (and nova) will just subclass the main versionedobject and add those sorts of helpers to your base class | 14:29 |
dansmith | and then inherit from that everywhere | 14:29 |
sdake | right | 14:29 |
sdake | makes sense | 14:29 |
sdake | one last q | 14:29 |
sdake | the versioned in the name | 14:29 |
sdake | what is that all about? | 14:29 |
dansmith | lol | 14:29 |
openstackgerrit | Julien Danjou proposed openstack/oslo.db: Handle CHECK constraint integrity in PostgreSQL https://review.openstack.org/170515 | 14:29 |
dansmith | so the other "whole point" of this is that all objects have a version number attached, | 14:30 |
dansmith | which lets you indicate every change you make to the object, so that if you send one to a node running old code, it can say "I don't support this version" in a handle-able way | 14:30 |
sdake | minor version number results in an exception? | 14:31 |
dansmith | in nova, we automatically kick those to a service on the network that is always newer than everything else, and it can "backport" that object for the older node | 14:31 |
dansmith | yes, because it's not semver | 14:31 |
sdake | cool - we are not using thatfeature yet but i"m sure we will | 14:31 |
dansmith | yeah, I don't think ironic is either | 14:31 |
sdake | we odnt have horizontal scale in magnum atm | 14:32 |
dansmith | yeah | 14:32 |
dansmith | when you do, we have a lot of battle scars in nova to help :) | 14:32 |
sdake | cool | 14:32 |
sdake | well, versioned objects rocks when I implemente dit from ironic in december/january | 14:32 |
*** links has quit IRC | 14:33 | |
sdake | I was really impressed with how it worked | 14:33 |
sdake | seemed a bit ike heavy wizardry | 14:33 |
sdake | but whatever, its a lbirary :) | 14:33 |
dansmith | heh | 14:33 |
dansmith | well, glad it's working | 14:33 |
sdake | so nice job on that :) | 14:33 |
dansmith | thanks :) | 14:34 |
*** subscope has quit IRC | 14:35 | |
*** openstackgerrit has quit IRC | 14:39 | |
*** openstackgerrit has joined #openstack-oslo | 14:39 | |
*** eezhova has quit IRC | 14:41 | |
*** jaypipes has joined #openstack-oslo | 14:42 | |
openstackgerrit | Julien Danjou proposed openstack/oslotest: mockpatch: factorize code https://review.openstack.org/163817 | 14:43 |
openstackgerrit | Merged openstack/stevedore: Updated from global requirements https://review.openstack.org/166476 | 14:46 |
*** eezhova has joined #openstack-oslo | 14:49 | |
openstackgerrit | Merged openstack/oslo.context: Updated from global requirements https://review.openstack.org/166451 | 14:55 |
*** daniel3_ has joined #openstack-oslo | 14:58 | |
*** jaypipes is now known as leakypipes | 15:02 | |
*** sdake_ has joined #openstack-oslo | 15:03 | |
*** sdake has quit IRC | 15:07 | |
*** exploreshaifali has quit IRC | 15:08 | |
*** spyyy1 has joined #openstack-oslo | 15:14 | |
*** spyyy has quit IRC | 15:14 | |
*** salv-orlando has quit IRC | 15:20 | |
*** exploreshaifali has joined #openstack-oslo | 15:21 | |
*** zzzeek has joined #openstack-oslo | 15:23 | |
*** links has joined #openstack-oslo | 15:26 | |
*** YorikSar has quit IRC | 15:32 | |
*** amotoki has joined #openstack-oslo | 15:35 | |
*** sputnik13 has joined #openstack-oslo | 15:36 | |
*** rushiagr is now known as rushiagr_away | 15:40 | |
*** dims is now known as dimsum__ | 15:44 | |
*** harlowja_at_home has joined #openstack-oslo | 15:46 | |
*** arnaud___ has joined #openstack-oslo | 15:50 | |
*** rushiagr_away is now known as rushiagr | 15:51 | |
*** sreshetn1 has quit IRC | 15:52 | |
*** prad has quit IRC | 15:56 | |
*** sreshetn1 has joined #openstack-oslo | 15:59 | |
*** harlowja_at_home has quit IRC | 16:01 | |
krotscheck | Anyone have suggestions on how to modify/improve the configuration section in https://review.openstack.org/#/c/170260/ ? | 16:08 |
krotscheck | (Best example of what I'm trying to do is here: http://docs-draft.openstack.org/60/170260/3/check/gate-oslo.middleware-docs/1e0dbec//doc/build/html/cors.html#quickstart ) | 16:10 |
*** e0ne is now known as e0ne_ | 16:14 | |
*** exploreshaifali has quit IRC | 16:15 | |
*** arnaud___ has quit IRC | 16:20 | |
*** e0ne_ is now known as e0ne | 16:20 | |
*** e0ne has quit IRC | 16:21 | |
*** pblaho has quit IRC | 16:21 | |
*** stevemar has joined #openstack-oslo | 16:34 | |
*** stevemar has quit IRC | 16:38 | |
openstackgerrit | Merged openstack/taskflow: Put the examples/misc/considerations under a new section https://review.openstack.org/169922 | 16:45 |
*** sdake_ has quit IRC | 16:52 | |
*** sdake has joined #openstack-oslo | 16:53 | |
*** YorikSar has joined #openstack-oslo | 16:57 | |
*** jogo is now known as flashgordon | 16:57 | |
*** yamahata has joined #openstack-oslo | 16:58 | |
*** prad has joined #openstack-oslo | 16:59 | |
dimsum__ | krotscheck: ping | 17:00 |
*** sreshetn1 has quit IRC | 17:00 | |
dimsum__ | krotscheck: i was thinking more like this - http://paste.openstack.org/show/198159/ | 17:00 |
krotscheck | dimsum__: pong! | 17:00 |
dimsum__ | a common group and specific ones overriding | 17:01 |
*** jecarey has quit IRC | 17:01 | |
krotscheck | dimsum__: Oh, interesting. So a global config, and then individual overrides. | 17:01 |
dimsum__ | y | 17:01 |
krotscheck | dimsum__: I can do that. Back in a bit. | 17:01 |
dimsum__ | krotscheck: we were thinking about that pattern for say ssl config for different services | 17:01 |
dimsum__ | cool thanks | 17:01 |
*** harlowja_away is now known as harlowja | 17:02 | |
*** sreshetn1 has joined #openstack-oslo | 17:04 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 17:07 | |
openstackgerrit | Merged openstack/taskflow: Add a suspension engine section https://review.openstack.org/169548 | 17:08 |
openstackgerrit | Merged openstack/taskflow: Shrink the bookshelf description https://review.openstack.org/170241 | 17:08 |
openstackgerrit | Merged openstack/taskflow: Remove link about implementing job garbage binning https://review.openstack.org/169953 | 17:08 |
*** hogepodge has quit IRC | 17:12 | |
*** hogepodge has joined #openstack-oslo | 17:14 | |
*** sreshetn1 has quit IRC | 17:20 | |
krotscheck | dimsum__: Is there any good way to detect whether a particular configuration option is reaching for the Opt default rather than the config file? | 17:20 |
dimsum__ | krotscheck: don't think so | 17:21 |
*** leakypipes has quit IRC | 17:21 | |
krotscheck | dimsum__: That's going to make a graceful degradation tricky. If I can't ask "Is this property set in this particular config block" I can't degrade gracefully, since it'll always hit the default. | 17:22 |
*** exploreshaifali has joined #openstack-oslo | 17:22 | |
*** links has quit IRC | 17:27 | |
*** david-lyle has quit IRC | 17:29 | |
*** sputnik13 has quit IRC | 17:29 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a example showing how to share an executor https://review.openstack.org/170571 | 17:30 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a example showing how to share an executor https://review.openstack.org/170571 | 17:31 |
*** yamahata has quit IRC | 17:31 | |
*** yamahata has joined #openstack-oslo | 17:31 | |
krotscheck | dimsum__: I'm rooting around cfg.py right now, and it doesn't look like I can do what you want me to without using private methods. Do you have any alternative suggestions? | 17:35 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a example showing how to share an executor https://review.openstack.org/170571 | 17:40 |
dimsum__ | krotscheck: if you register CORS_OPTS using rregister_opts(CORS_OPTS, "cors"). then you can do CONF.cors.allowed_methods. right? that will let you get the values from "[cors]" and you already have code for "[cors.xyz]". no? | 17:40 |
dimsum__ | ok i see the problem now | 17:41 |
dimsum__ | you have defaults as well in the options definitions | 17:41 |
krotscheck | dimsum__: I can, but how can I determine whether cors.xyz is reaching for the CORS_OPTS default value rather than a configured value, and should therefore fall back to cors? | 17:41 |
krotscheck | Right | 17:41 |
krotscheck | Given the complexity of the available options, I feel that defaults are necessary. | 17:42 |
krotscheck | I could create a second OPTS block with no defaults though. | 17:43 |
dimsum__ | hang on | 17:43 |
krotscheck | Though, well, copy/pasta | 17:43 |
dimsum__ | y, i dont' see a way to do it...am ok with what you have :) only issue i have with what you have is when we run oslo-config-generator, these options do not end up in the sample configuration file | 17:47 |
dimsum__ | typically we do this by exposing list_opts() | 17:48 |
dimsum__ | with a specific group name | 17:48 |
*** bknudson has quit IRC | 17:48 | |
dimsum__ | in your case if we use group name as "cors" then people will end up trying "[cors]" in their sample file and it won't be picked up | 17:49 |
dimsum__ | s/sample/config/ | 17:49 |
krotscheck | dimsum__: Well, I can add an extra config block with slightly different configuration options. | 17:49 |
krotscheck | As in, do an explicit register for the global overrides so that it gets picked up, and add the complex config parsing as the 'advanced' feature. | 17:50 |
dimsum__ | sounds good krotscheck. | 17:51 |
*** achanda has joined #openstack-oslo | 17:57 | |
*** sheeprine has quit IRC | 18:00 | |
*** stpierre has quit IRC | 18:03 | |
openstackgerrit | Merged openstack/oslo.log: Restore automatic unicode conversion https://review.openstack.org/163027 | 18:05 |
openstackgerrit | Michael Krotscheck proposed openstack/oslo.middleware: Add CORS Middleware for Oslo. https://review.openstack.org/170260 | 18:09 |
krotscheck | dimsum__: I think ^^ will do what you're asking for. | 18:10 |
*** leakypipes has joined #openstack-oslo | 18:10 | |
*** sputnik13 has joined #openstack-oslo | 18:12 | |
dimsum__ | krotscheck: need a list_opts() (see http://specs.openstack.org/openstack/oslo-specs/specs/juno/oslo-config-generator.html) | 18:13 |
*** sdake_ has joined #openstack-oslo | 18:20 | |
*** daniel3_ has quit IRC | 18:20 | |
*** achanda has quit IRC | 18:20 | |
*** achanda has joined #openstack-oslo | 18:24 | |
*** sdake has quit IRC | 18:24 | |
openstackgerrit | Doug Hellmann proposed openstack/oslo.db: Update to latest hacking https://review.openstack.org/170496 | 18:32 |
*** alexpilotti has quit IRC | 18:37 | |
openstackgerrit | Michael Krotscheck proposed openstack/oslo.middleware: Add CORS Middleware for Oslo. https://review.openstack.org/170260 | 18:40 |
krotscheck | dimsum__: Like ^^? | 18:41 |
*** cpg|away is now known as cpg | 18:46 | |
*** daniel3_ has joined #openstack-oslo | 18:53 | |
dimsum__ | krotscheck: since the subdomain is dynamic, we may want to drop that line https://review.openstack.org/#/c/170260/4..5/oslo_middleware/opts.py,cm | 18:53 |
krotscheck | dimsum__: Maybe. I can see either side of the argument, we may want to let that shake out in the gerrit discussion. | 18:55 |
dimsum__ | sounds good | 18:55 |
*** sdake has joined #openstack-oslo | 18:56 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow for decommissioning a board via a .tombstone file https://review.openstack.org/92289 | 18:57 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow for decommissioning a board via a .tombstone file https://review.openstack.org/92289 | 18:59 |
*** sdake_ has quit IRC | 19:00 | |
*** exploreshaifali has quit IRC | 19:00 | |
*** daniel3_ has quit IRC | 19:02 | |
*** daniel3_ has joined #openstack-oslo | 19:03 | |
*** daniel3_ has quit IRC | 19:03 | |
*** daniel3_ has joined #openstack-oslo | 19:03 | |
*** sdake_ has joined #openstack-oslo | 19:05 | |
*** sdake has quit IRC | 19:08 | |
*** sdake has joined #openstack-oslo | 19:15 | |
*** achanda has quit IRC | 19:15 | |
*** sdake_ has quit IRC | 19:19 | |
*** ndipanoff has quit IRC | 19:21 | |
*** YorikSar has quit IRC | 19:26 | |
*** jstacks has joined #openstack-oslo | 19:27 | |
jstacks | Is there a specific channel to ask oslo messaging questions in? | 19:29 |
*** achanda has joined #openstack-oslo | 19:29 | |
*** e0ne has joined #openstack-oslo | 19:31 | |
dimsum__ | jstacks: just ask here, no separate channel | 19:34 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow for decommissioning a board via a .tombstone file https://review.openstack.org/92289 | 19:35 |
jstacks | Thanks dimsum__, I'm trying to use oslo messaging to listen to events and run some custom scripts. If I create an endpoint, will it create a new queue that is connected to the target or will it try to find an existing queue? | 19:37 |
openstackgerrit | Michael Krotscheck proposed openstack/oslo.middleware: Add CORS Middleware for Oslo. https://review.openstack.org/170260 | 19:39 |
dhellmann | jstacks: I think by default it creates a queue with the same name as the topic, but there should be a way to specify a different name | 19:43 |
jstacks | Thanks dhellmann, I'm worried I'm bleeding the default notifications.info queue and other subscribers won't get the messages. I'll look to see if there is a way to specify a queue name | 19:45 |
dhellmann | jstacks: you might want to look in ceilometer's code base to see how they subscribe. IIRC, they use a custom queue for exactly the reason you mention | 19:46 |
jstacks | dhellmann: thanks, don't know why i didn't think to look there | 19:47 |
*** amotoki has quit IRC | 19:47 | |
*** zzzeek has quit IRC | 19:47 | |
*** zzzeek has joined #openstack-oslo | 19:48 | |
openstackgerrit | Michael Krotscheck proposed openstack/oslo.middleware: Add CORS Middleware for Oslo. https://review.openstack.org/170260 | 19:51 |
openstackgerrit | Jeremy Stanley proposed openstack-dev/cookiecutter: Don't omit tests from coverage https://review.openstack.org/170594 | 19:51 |
* krotscheck just dropped his middleware into Ironic for some actual use tests. Just needed a few tweaks :) | 19:51 | |
*** pblaho has joined #openstack-oslo | 19:52 | |
*** pblaho has quit IRC | 19:53 | |
openstackgerrit | Jeremy Stanley proposed openstack-dev/cookiecutter: More portable to use setup.py test not testr https://review.openstack.org/170596 | 19:55 |
dimsum__ | jstacks: see the simulator.py, it has a working example | 19:55 |
*** ozamiatin_ has joined #openstack-oslo | 19:56 | |
*** ozamiatin_ has quit IRC | 19:57 | |
*** ozamiatin_ has joined #openstack-oslo | 19:57 | |
jstacks | dimsum__: where would i find the simulator.py file? Not seeing it in the ceilometer repo | 19:58 |
dimsum__ | in oslo.messaging repo | 19:58 |
jstacks | oh okay. Thanks :) | 19:59 |
openstackgerrit | Joshua Harlow proposed openstack/debtcollector: By default mutate the docstring(s) for deprecations https://review.openstack.org/155988 | 20:00 |
*** ozamiatin_ has quit IRC | 20:04 | |
dimsum__ | krotscheck: why StrOpt for max_age? | 20:04 |
krotscheck | dimsum__: Because all HTTP headers need to be strings, and since we're just passing it through, it seemed easier. | 20:04 |
dimsum__ | or a str() | 20:06 |
dimsum__ | since you lose validation | 20:06 |
krotscheck | I could do that. No issues with py34 on str()? | 20:07 |
openstackgerrit | Michael Krotscheck proposed openstack/oslo.middleware: Add CORS Middleware for Oslo. https://review.openstack.org/170260 | 20:08 |
krotscheck | dimsum__: ^^ There ya go | 20:09 |
*** YorikSar has joined #openstack-oslo | 20:10 | |
*** e0ne has quit IRC | 20:13 | |
*** sheeprine has joined #openstack-oslo | 20:20 | |
*** daniel3_ has quit IRC | 20:27 | |
*** prad has quit IRC | 20:39 | |
*** harlowja has quit IRC | 20:53 | |
*** daniel3_ has joined #openstack-oslo | 20:57 | |
*** sdake has quit IRC | 20:58 | |
*** andreykurilin_ has joined #openstack-oslo | 21:00 | |
*** jungleboyj has quit IRC | 21:08 | |
*** achanda has quit IRC | 21:08 | |
*** andreykurilin_ has quit IRC | 21:08 | |
*** andreykurilin_ has joined #openstack-oslo | 21:09 | |
*** jstacks has quit IRC | 21:11 | |
*** daniel3_ has quit IRC | 21:13 | |
openstackgerrit | Michael Krotscheck proposed openstack/oslo.middleware: Add CORS Middleware for Oslo. https://review.openstack.org/170260 | 21:18 |
*** yamahata has quit IRC | 21:40 | |
*** yamahata has joined #openstack-oslo | 21:40 | |
*** mriedem has quit IRC | 21:44 | |
*** sputnik13 has quit IRC | 21:46 | |
openstackgerrit | Merged openstack/oslosphinx: Update to latest hacking https://review.openstack.org/170507 | 21:47 |
openstackgerrit | Merged openstack/oslotest: mockpatch: factorize code https://review.openstack.org/163817 | 21:48 |
*** achanda has joined #openstack-oslo | 22:08 | |
*** david-lyle has joined #openstack-oslo | 22:12 | |
*** achanda has quit IRC | 22:14 | |
*** yamahata has quit IRC | 22:21 | |
*** achanda has joined #openstack-oslo | 22:26 | |
openstackgerrit | Merged openstack/oslo.middleware: Update to latest hacking https://review.openstack.org/170498 | 22:33 |
openstackgerrit | Merged openstack/oslo.config: Update hacking to kilo level https://review.openstack.org/170494 | 22:36 |
openstackgerrit | Merged openstack/oslo.utils: Update hacking setting https://review.openstack.org/170478 | 22:37 |
*** harlowja has joined #openstack-oslo | 22:40 | |
openstackgerrit | Merged openstack/oslo.context: Update to latest hacking https://review.openstack.org/170495 | 22:41 |
*** andreykurilin_ has quit IRC | 22:42 | |
*** amotoki has joined #openstack-oslo | 22:48 | |
*** amotoki has quit IRC | 22:52 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Update to the latest version of hacking https://review.openstack.org/170503 | 22:53 |
*** achanda has quit IRC | 22:53 | |
*** sputnik13 has joined #openstack-oslo | 22:56 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use the ability to chain exceptions correctly https://review.openstack.org/155187 | 23:05 |
*** zzzeek has quit IRC | 23:06 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Avoid going into causes of non-taskflow exceptions https://review.openstack.org/170625 | 23:10 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Avoid going into causes of non-taskflow exceptions https://review.openstack.org/170625 | 23:11 |
*** zzzeek has joined #openstack-oslo | 23:26 | |
*** zzzeek has quit IRC | 23:26 | |
*** Viswanath has joined #openstack-oslo | 23:31 | |
*** achanda has joined #openstack-oslo | 23:32 | |
*** rushiagr is now known as rushiagr_away | 23:33 | |
*** Viswanath has quit IRC | 23:40 | |
*** cpg is now known as cpg|away | 23:46 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!