lifeless | tchaypo: so I'd write a three dimension sparse set of scenarios and one test | 00:00 |
---|---|---|
lifeless | tchaypo: in pbr | 00:00 |
lifeless | tchaypo: the dimensions are 'pbr-present-or-not', '-e or not' and 'install tree or sdist' | 00:01 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: POC of some useful decorators to make things simpler https://review.openstack.org/185116 | 00:03 |
dhellmann | harlowja_, dims_: this is actually why we want more small libs, rather than one big utils lib | 00:04 |
harlowja_ | dhellmann i tots agree | 00:05 |
harlowja_ | but i think infra is confused as to what is oslo :-P | 00:05 |
harlowja_ | let me find that discussion from yesterday | 00:05 |
dhellmann | harlowja_, dims_ : these relationships were hidden when we had the code all in the incubator, since modules could have circular dependencies | 00:05 |
lifeless | dhellmann: hey since you're here | 00:05 |
tchaypo | When you say sparse - which scenarios would you ignore? | 00:05 |
lifeless | dhellmann: two thinkgs I want from you | 00:05 |
lifeless | dhellmann: firstly, the photos from the requirements session | 00:05 |
* dhellmann puts down third thing | 00:05 | |
dhellmann | ah, yeah, I need to post those, I'll do that first thing in the morning | 00:06 |
harlowja_ | http://eavesdrop.openstack.org/irclogs/%23openstack-infra/%23openstack-infra.2015-05-26.log.html#t2015-05-26T23:20:46 | 00:06 |
tchaypo | thanks, I’d like to see those too | 00:06 |
harlowja_ | dhellmann ^ (a similar question on the oslo.concurrency stuff, which would also benefit from a small extracted lib to share) | 00:06 |
lifeless | dhellmann: secondly, whats the oslo policy on API breaks - harlowja_ has a patch up for taskflow that changes the behaviour of ls() in a memory fs thing, and while I have no personal opinion, API break implies major version etc... | 00:06 |
lifeless | dhellmann: so if it lands, its a major version on the very next release - or do we require some compromise/deprecation/newmethod etc etc etc | 00:07 |
lifeless | tchaypo: -e + sdist makes no sense. | 00:07 |
dhellmann | harlowja_: create the review and if you get pushback refer them to http://specs.openstack.org/openstack/oslo-specs/specs/policy/naming-libraries.html | 00:07 |
harlowja_ | ya | 00:08 |
harlowja_ | lifeless ya, this one is also more of a bug, i'd consider it that (although maybe i should just retain the existing behavior and make it optional to do it right) | 00:08 |
* harlowja_ could do that, vs fixing the actual API to not be weird | 00:08 | |
lifeless | tchaypo: so I'd start with multiply_scenarios(-e-or-not, tree), then add (not, sdist) to the end, then multiply_scenarios by pbr-present-or-not | 00:08 |
harlowja_ | maybe better to just leave it as weird, and have people use the keyword argument to make it not-weird | 00:09 |
lifeless | harlowja_: yeah, I am just levelling up on oslo policy; I don't want to apply my prejuidices willy-nilly | 00:09 |
dhellmann | lifeless: I would have to look at it to understand the change, but if it's a bug and the current behavior is wrong or not usable then I don't think it requires a major bump | 00:09 |
harlowja_ | i'd consider it a bug/oversight | 00:09 |
tchaypo | oh, of course. | 00:09 |
lifeless | dhellmann: its unusual, but its likely that folk have code depending on it | 00:09 |
harlowja_ | https://review.openstack.org/#/c/183194/ | 00:09 |
lifeless | dhellmann: AIUI, of course | 00:09 |
harlowja_ | https://bugs.launchpad.net/taskflow/+bug/1458114 | 00:09 |
openstack | Launchpad bug 1458114 in taskflow "Recursive `ls` works different than non-recursive `ls`" [Medium,In progress] - Assigned to Joshua Harlow (harlowja) | 00:09 |
*** mtanino has quit IRC | 00:09 | |
dhellmann | in general we can't just make breaking changes, even with semver, because we have to actually get the consuming project updated to use the new version and that requires a compatibility period | 00:09 |
lifeless | harlowja_: what are the odds someone will be broken when we release this? thats the acid question I suspect based on dhellmann's answer | 00:10 |
tchaypo | lifeless: next question: how do I run a unit test in the pbr unit tests without pbr being in the venv to start with, but with pbr being installed from my local tree rather than from pypi? | 00:10 |
dhellmann | harlowja_: if we have people depending on the current behavior, you should try to find a way to maintain it while providing a fixed version -- usually a different symbol name for the new implementation is simplest there, rather than a flag or something | 00:10 |
harlowja_ | unlikely, not in openstack at least, its a internal detail of a storage feature that i'm not sure all to many people are aware of | 00:10 |
lifeless | tchaypo: you make a new venv in the test, there's glue there to do that already | 00:11 |
dhellmann | harlowja_, lifeless : it's time for me to sign off, but I'll catch up on that review tomorrow | 00:11 |
tchaypo | perhaps if i build the sdist first and use “pip install -f dists/ “ so that when it hits the setup_requires and goes off to find pbr it will grab the sdist? | 00:11 |
lifeless | dhellmann: photos first if you can! ;) | 00:11 |
dhellmann | lifeless: yep, I'll throw together a blog post first thing | 00:11 |
harlowja_ | dhellmann k, let me know, i'm ok with a variety of the ideas here, ha | 00:11 |
dhellmann | harlowja_: if it's easy enough to maintain backwards compatibility, we should go ahead and do it | 00:13 |
harlowja_ | k | 00:13 |
harlowja_ | its easy | 00:13 |
lifeless | dhellmann: blog post? Oh, with the photos? whatever works | 00:13 |
lifeless | dhellmann: I just want them to reference as I write up the spec | 00:13 |
lifeless | tchaypo: no, you want pip install --no-index path-to-sdist | 00:14 |
dhellmann | lifeless: yeah, that's probably the simplest way for me to share them | 00:14 |
lifeless | tchaypo: or pip install --no-index path-to-tree | 00:14 |
*** salv-orlando has joined #openstack-oslo | 00:15 | |
lifeless | dhellmann: you could email them :) Just saying. blog is fine too of course. | 00:15 |
dhellmann | lifeless: oh, if that works then check your inbox | 00:16 |
lifeless | dhellmann: got it, thanks | 00:18 |
* harlowja_ didn't get it | 00:19 | |
harlowja_ | ha | 00:19 |
*** salv-orlando has quit IRC | 00:19 | |
tchaypo | lifeless: I’ll give that a try; but how will that tell pip where to load the setup_requires from? surely it needs an index for that? | 00:23 |
ViswaV | tchaypo, when using tox , to get the behavior you mentioned, I use sitepackages=True in my tox.ini | 00:25 |
lifeless | tchaypo: if pip honoured that, it would. | 00:25 |
*** ViswaV has quit IRC | 00:28 | |
*** tobe has joined #openstack-oslo | 00:32 | |
tchaypo | *thinks* | 00:32 |
tchaypo | so for testing I should be able to use the test package I’m already creating for other tests, and we simply install that package under the conditions from the scenario | 00:34 |
*** alexpilotti has joined #openstack-oslo | 00:34 | |
*** tobe has quit IRC | 00:36 | |
openstackgerrit | Min Pae proposed openstack/oslo.serialization: Adding failure detail to Exceptions on encode https://review.openstack.org/186233 | 00:41 |
tchaypo | I wish all my reviews went in as simply as https://review.openstack.org/#/c/184866/ | 00:42 |
tchaypo | perhaps if they were all one-line doc changes they would | 00:42 |
*** zzzeek has quit IRC | 00:45 | |
*** vilobhmm has quit IRC | 00:47 | |
*** rushiagr_away is now known as rushiagr | 00:56 | |
lifeless | tchaypo: seems reasonable, yes | 00:57 |
tchaypo | I think I’m just going to modify/replace the existing TestRequirementParsing class rather than adding to it | 01:00 |
tchaypo | it’s testing that particular things get written into requires.txt; but that’s an implementation detail | 01:00 |
tchaypo | what I really care about is “does the right stuff get installed?" | 01:01 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a new `ls_r` method https://review.openstack.org/183194 | 01:01 |
harlowja_ | lifeless dhellmann ^ there new method, old behavior retained + tested (new and old) | 01:01 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: POC of some useful decorators to make things simpler https://review.openstack.org/185116 | 01:18 |
*** tobe has joined #openstack-oslo | 01:18 | |
*** vilobhmm has joined #openstack-oslo | 01:20 | |
*** rushiagr is now known as rushiagr_away | 01:24 | |
*** sdake_ has quit IRC | 01:28 | |
*** browne has quit IRC | 01:29 | |
*** Rockyg has quit IRC | 01:31 | |
*** dims_ has quit IRC | 01:35 | |
*** sputnik13 has quit IRC | 01:35 | |
*** vilobhmm has quit IRC | 01:38 | |
*** vilobhmm has joined #openstack-oslo | 01:38 | |
*** amotoki_ has joined #openstack-oslo | 01:40 | |
*** alexpilotti has quit IRC | 01:42 | |
*** amotoki_ has quit IRC | 01:45 | |
openstackgerrit | Joshua Harlow proposed openstack/tooz: Use a lua script(s) instead of transactions (WIP) https://review.openstack.org/180800 | 01:47 |
*** amrith is now known as _amrith_ | 01:48 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: POC of some useful decorators to make things simpler https://review.openstack.org/185116 | 01:49 |
*** sigmavirus24 is now known as sigmavirus24_awa | 01:50 | |
openstackgerrit | Merged openstack/stevedore: Add sphinx integration https://review.openstack.org/183820 | 01:54 |
*** vilobhmm has quit IRC | 01:55 | |
*** rushiagr_away is now known as rushiagr | 02:08 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add support for conditional execution https://review.openstack.org/164922 | 02:16 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add ability to reset an engine via a `reset` method https://review.openstack.org/186239 | 02:29 |
*** browne has joined #openstack-oslo | 02:29 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add ability to reset an engine via a `reset` method https://review.openstack.org/186239 | 02:30 |
*** salv-orlando has joined #openstack-oslo | 02:37 | |
*** yamahata has quit IRC | 02:42 | |
*** salv-orlando has quit IRC | 02:42 | |
*** rushiagr is now known as rushiagr_away | 02:55 | |
lifeless | tchaypo: I was suggesting end to end tests | 03:08 |
lifeless | tchaypo: since we know *our* core is fine | 03:08 |
lifeless | tchaypo: the point of this is to tell us when your candidate setuptools patch really is good | 03:09 |
lifeless | tchaypo: no? | 03:09 |
*** achanda has joined #openstack-oslo | 03:22 | |
*** amotoki_ has joined #openstack-oslo | 03:28 | |
*** amotoki_ has quit IRC | 03:33 | |
*** ayoung has quit IRC | 03:42 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add ability to reset an engine via a `reset` method (WIP) https://review.openstack.org/186239 | 03:50 |
*** rushiagr_away is now known as rushiagr | 04:00 | |
*** achanda has quit IRC | 04:01 | |
tchaypo | something seems to be producing output that parts of setuptools can’t handle, and sometimes sending execution into those parts | 04:04 |
tchaypo | it seems we could just as easily frame that as setuptools being wrong for having two incompatible paths, or pbr for being wrong for handling the same input differently depending on how pbr is installed | 04:05 |
*** jaison has joined #openstack-oslo | 04:05 | |
tchaypo | now that I’ve had lunch.. | 04:10 |
lifeless | tchaypo: does pbr handle it differently? you haven't demonstrated that. | 04:28 |
lifeless | tchaypo: having end to end tests which you can then use to triangulate would help :) | 04:28 |
tchaypo | well. I don’t know if pbr handles it differently, that’s what I need to figure out | 04:31 |
*** tobe has quit IRC | 04:36 | |
tchaypo | pkg_resources/__init__.py has some code just after the definition of _markerlib_evaluate which switches the evaluate_marker name to point at one either _markerlib_evaluate or another function. i know that it’s making a different choice if pbr is installed in the venv than if pbr is installed via setup_requires. But I haven’t been able to figure out why, | 04:37 |
tchaypo | partly beacuse pdb never stops on a breakpoint on that line | 04:37 |
*** sdake has joined #openstack-oslo | 04:39 | |
*** salv-orlando has joined #openstack-oslo | 04:42 | |
tchaypo | or maybe i don’t understand where the error is coming from. | 04:43 |
tchaypo | it’d be really really really nice if we got a stack trace instead of sys.exit() and a message that conceals the original exception | 04:44 |
* tchaypo goes back to writing tests | 04:44 | |
*** openstackgerrit has quit IRC | 04:50 | |
*** openstackgerrit has joined #openstack-oslo | 04:50 | |
*** sdake_ has joined #openstack-oslo | 04:50 | |
*** salv-orlando has quit IRC | 04:53 | |
*** sdake has quit IRC | 04:54 | |
*** zul has quit IRC | 04:57 | |
tchaypo | hrm. my laptop batery is at 0%. | 04:57 |
*** zul has joined #openstack-oslo | 04:57 | |
tchaypo | the screen is quite impressively bright for a non-powered laptop | 04:58 |
tchaypo | and it heard me talking | 04:58 |
*** nkrinner has joined #openstack-oslo | 04:59 | |
*** stevemar has joined #openstack-oslo | 05:06 | |
*** qianli has joined #openstack-oslo | 05:16 | |
*** amotoki_ has joined #openstack-oslo | 05:17 | |
*** jaison has quit IRC | 05:18 | |
*** amotoki_ has quit IRC | 05:22 | |
*** salv-orlando has joined #openstack-oslo | 05:23 | |
*** achanda has joined #openstack-oslo | 05:38 | |
lifeless | tchaypo: heh | 05:40 |
*** harlowja_ has quit IRC | 05:40 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a new `ls_r` method https://review.openstack.org/183194 | 05:43 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Remove usage of contentmanager for executors https://review.openstack.org/140985 | 05:51 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: rabbit: Add logging on blocked connection https://review.openstack.org/185851 | 05:54 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.versionedobjects: Imported Translations from Transifex https://review.openstack.org/186272 | 06:03 |
*** tobe has joined #openstack-oslo | 06:04 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/186276 | 06:05 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.concurrency: Imported Translations from Transifex https://review.openstack.org/186277 | 06:05 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/186284 | 06:08 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/186288 | 06:14 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/186289 | 06:15 |
*** stevemar has quit IRC | 06:25 | |
*** amotoki_ has joined #openstack-oslo | 06:48 | |
*** amotoki_ has quit IRC | 06:53 | |
*** vilobhmm has joined #openstack-oslo | 06:59 | |
*** salv-orlando has quit IRC | 07:00 | |
*** salv-orlando has joined #openstack-oslo | 07:00 | |
*** haypo has joined #openstack-oslo | 07:01 | |
*** vilobhmm has quit IRC | 07:10 | |
*** browne has quit IRC | 07:21 | |
*** dguitarbite has joined #openstack-oslo | 07:25 | |
*** dulek has joined #openstack-oslo | 07:27 | |
*** salv-orlando has quit IRC | 07:38 | |
*** ozamiatin has joined #openstack-oslo | 07:51 | |
*** dguitarbite has quit IRC | 07:54 | |
*** dguitarbite has joined #openstack-oslo | 07:57 | |
*** ihrachyshka has joined #openstack-oslo | 07:57 | |
*** dims_ has joined #openstack-oslo | 08:02 | |
*** yassine_ has joined #openstack-oslo | 08:07 | |
*** dims_ has quit IRC | 08:08 | |
*** shardy has joined #openstack-oslo | 08:18 | |
*** qianli has quit IRC | 08:23 | |
openstackgerrit | Merged openstack/tooz: Move more string constants to class constants with docstrings https://review.openstack.org/180764 | 08:28 |
*** amotoki_ has joined #openstack-oslo | 08:37 | |
*** salv-orlando has joined #openstack-oslo | 08:39 | |
*** ndipanov has joined #openstack-oslo | 08:40 | |
*** ihrachyshka has quit IRC | 08:42 | |
*** amotoki_ has quit IRC | 08:42 | |
*** salv-orlando has quit IRC | 08:45 | |
openstackgerrit | Merged openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/186288 | 08:49 |
openstackgerrit | Merged openstack/oslo.middleware: Added CORS wildcard handling https://review.openstack.org/185079 | 08:50 |
*** ihrachyshka has joined #openstack-oslo | 08:54 | |
openstackgerrit | Merged openstack/oslo.log: Allow integer logging levels https://review.openstack.org/182096 | 08:57 |
*** sdake has joined #openstack-oslo | 08:58 | |
openstackgerrit | Merged openstack/tooz: Use lua locks instead of pipeline locks https://review.openstack.org/182036 | 08:58 |
*** SridharGaddam has joined #openstack-oslo | 08:58 | |
*** sdake_ has quit IRC | 09:01 | |
*** sdake_ has joined #openstack-oslo | 09:04 | |
*** sdake has quit IRC | 09:07 | |
*** xek_ is now known as xek | 09:12 | |
*** e0ne has joined #openstack-oslo | 09:22 | |
*** e0ne is now known as e0ne_ | 09:30 | |
openstackgerrit | Merged openstack/oslo.vmware: Revert "Raise VimFaultException for unknown faults" https://review.openstack.org/185744 | 09:31 |
*** e0ne_ has quit IRC | 09:35 | |
*** _amrith_ is now known as amrith | 09:40 | |
*** ozamiatin has quit IRC | 09:48 | |
openstackgerrit | Merged openstack/oslo.messaging: Imported Translations from Transifex https://review.openstack.org/186284 | 09:52 |
*** ozamiatin has joined #openstack-oslo | 09:55 | |
*** yassine_ has quit IRC | 09:56 | |
*** e0ne has joined #openstack-oslo | 09:57 | |
*** dims_ has joined #openstack-oslo | 09:57 | |
*** salv-orlando has joined #openstack-oslo | 10:10 | |
*** hogepodge has quit IRC | 10:11 | |
*** hogepodge has joined #openstack-oslo | 10:13 | |
*** pasquier-s has joined #openstack-oslo | 10:16 | |
*** amotoki_ has joined #openstack-oslo | 10:25 | |
*** amotoki_ has quit IRC | 10:30 | |
*** kbyrne has quit IRC | 10:34 | |
*** sdake_ has quit IRC | 10:38 | |
*** e0ne is now known as e0ne_ | 10:39 | |
*** kbyrne has joined #openstack-oslo | 10:41 | |
*** e0ne_ has quit IRC | 10:45 | |
*** e0ne has joined #openstack-oslo | 10:53 | |
*** hogepodge has quit IRC | 10:59 | |
openstackgerrit | Merged openstack/oslo.messaging: Fix deprecated_group of rpc_conn_pool_size https://review.openstack.org/185935 | 11:00 |
*** hogepodge has joined #openstack-oslo | 11:02 | |
openstackgerrit | Merged openstack/oslo.vmware: Imported Translations from Transifex https://review.openstack.org/186276 | 11:05 |
*** yassine_ has joined #openstack-oslo | 11:06 | |
*** yassine_ has quit IRC | 11:06 | |
*** yassine_ has joined #openstack-oslo | 11:07 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Imported Translations from Transifex https://review.openstack.org/186272 | 11:10 |
*** e0ne is now known as e0ne_ | 11:11 | |
*** e0ne_ is now known as e0ne | 11:12 | |
*** salv-orlando has quit IRC | 11:12 | |
openstackgerrit | Merged openstack/oslo.messaging: Adding Publisher Acknowledgements/confirms https://review.openstack.org/185989 | 11:13 |
*** dims_ has quit IRC | 11:16 | |
*** dims_ has joined #openstack-oslo | 11:17 | |
*** e0ne is now known as e0ne_ | 11:20 | |
openstackgerrit | Merged openstack/oslo.utils: Imported Translations from Transifex https://review.openstack.org/186289 | 11:20 |
*** e0ne_ has quit IRC | 11:25 | |
*** dims_ has quit IRC | 11:28 | |
*** dims_ has joined #openstack-oslo | 11:28 | |
*** tobe has quit IRC | 11:30 | |
*** dims_ has quit IRC | 11:33 | |
*** e0ne has joined #openstack-oslo | 11:34 | |
*** openstackgerrit has quit IRC | 11:39 | |
*** openstackgerrit has joined #openstack-oslo | 11:39 | |
openstackgerrit | Merged openstack/oslo.concurrency: Imported Translations from Transifex https://review.openstack.org/186277 | 11:39 |
*** dims_ has joined #openstack-oslo | 11:39 | |
*** tobe has joined #openstack-oslo | 11:39 | |
*** amotoki_ has joined #openstack-oslo | 11:41 | |
*** amotoki has quit IRC | 11:45 | |
*** amotoki_ has quit IRC | 11:46 | |
*** rushiagr is now known as rushiagr_away | 11:48 | |
*** achanda has quit IRC | 11:57 | |
*** dulek has quit IRC | 11:58 | |
*** dulek has joined #openstack-oslo | 12:00 | |
*** inc0 has joined #openstack-oslo | 12:10 | |
*** salv-orlando has joined #openstack-oslo | 12:12 | |
*** inc0 has quit IRC | 12:16 | |
openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Move the option definitions into a private file https://review.openstack.org/186360 | 12:22 |
*** stpierre has joined #openstack-oslo | 12:26 | |
*** e0ne is now known as e0ne_ | 12:32 | |
*** kgiusti has joined #openstack-oslo | 12:34 | |
openstackgerrit | Victor Sergeyev proposed openstack/oslo.messaging: Don't create a new channel in RabbitMQ Connection.reset() https://review.openstack.org/182272 | 12:39 |
*** prad has joined #openstack-oslo | 12:39 | |
*** inc0 has joined #openstack-oslo | 12:39 | |
*** e0ne_ has quit IRC | 12:43 | |
*** inc0_ has joined #openstack-oslo | 12:46 | |
*** e0ne has joined #openstack-oslo | 12:47 | |
*** inc0 has quit IRC | 12:48 | |
*** inc0__ has joined #openstack-oslo | 12:52 | |
*** inc0_ has quit IRC | 12:55 | |
*** tobe has quit IRC | 13:08 | |
*** salv-orlando has quit IRC | 13:11 | |
*** salv-orlando has joined #openstack-oslo | 13:11 | |
*** bknudson has joined #openstack-oslo | 13:19 | |
*** stpierre has quit IRC | 13:19 | |
*** stpierre has joined #openstack-oslo | 13:21 | |
openstackgerrit | Victor Sergeyev proposed openstack/oslo.messaging: Allow to remove second _send_reply() call https://review.openstack.org/180542 | 13:23 |
openstackgerrit | Flavio Percoco proposed openstack/oslo.messaging: Remove python-qpid-proton from amqp1 reqs https://review.openstack.org/186384 | 13:27 |
*** jamielennox is now known as jamielennox|away | 13:29 | |
*** amotoki has joined #openstack-oslo | 13:30 | |
*** ChuckC has quit IRC | 13:32 | |
*** pradk has joined #openstack-oslo | 13:33 | |
*** pradk has quit IRC | 13:33 | |
*** pradk has joined #openstack-oslo | 13:34 | |
*** amotoki has quit IRC | 13:35 | |
ihrachyshka | guys, can we move forward with https://review.openstack.org/#/c/176683/ for neutron's sake? dhellmann, dims_ ? | 13:35 |
dhellmann | ihrachyshka: +2 | 13:36 |
dhellmann | ihrachyshka: is there a bug or blueprint to reference in the commit message? if not, that's OK, I just noticed there's not one | 13:37 |
*** dims_ has quit IRC | 13:37 | |
*** bnemec has quit IRC | 13:37 | |
*** dims_ has joined #openstack-oslo | 13:38 | |
ihrachyshka | dhellmann, I better update commit message with details | 13:38 |
dims_ | ihrachyshka: looking | 13:38 |
dims_ | ihrachyshka: y, one of us can +A after | 13:39 |
dhellmann | ihrachyshka: ok, I'm going to make some breakfast but as dims_ says, one or the other of us will approve after that's updated | 13:39 |
*** achanda has joined #openstack-oslo | 13:40 | |
openstackgerrit | Ihar Hrachyshka proposed openstack/oslo.policy: Expose base check classes as part of public API https://review.openstack.org/176683 | 13:42 |
ihrachyshka | dhellmann, dims_ ^^ | 13:42 |
*** bnemec has joined #openstack-oslo | 13:42 | |
dims_ | ihrachyshka: done | 13:43 |
ihrachyshka | thanks! | 13:43 |
*** mriedem has joined #openstack-oslo | 13:48 | |
*** dulek has quit IRC | 13:50 | |
*** dulek_ has joined #openstack-oslo | 13:50 | |
*** jecarey has joined #openstack-oslo | 13:51 | |
*** exploreshaifali has joined #openstack-oslo | 13:52 | |
*** mdbooth has quit IRC | 13:54 | |
*** mdbooth has joined #openstack-oslo | 13:55 | |
*** nkrinner has quit IRC | 13:59 | |
*** dulek___ has joined #openstack-oslo | 14:01 | |
*** inc0__ has quit IRC | 14:02 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:02 | |
*** dulek_ has quit IRC | 14:04 | |
*** inc0 has joined #openstack-oslo | 14:05 | |
*** pradk has quit IRC | 14:05 | |
*** miqui has joined #openstack-oslo | 14:06 | |
*** zzzeek has joined #openstack-oslo | 14:07 | |
*** pradk has joined #openstack-oslo | 14:09 | |
*** sdake has joined #openstack-oslo | 14:09 | |
*** sdake_ has joined #openstack-oslo | 14:10 | |
*** achanda_ has joined #openstack-oslo | 14:13 | |
*** sdake has quit IRC | 14:14 | |
*** achanda has quit IRC | 14:17 | |
*** inc0 has quit IRC | 14:21 | |
*** ozamiatin has quit IRC | 14:25 | |
*** mtanino has joined #openstack-oslo | 14:28 | |
*** fnordahl has quit IRC | 14:33 | |
*** fnordahl has joined #openstack-oslo | 14:40 | |
*** sdake has joined #openstack-oslo | 14:40 | |
*** sdake_ has quit IRC | 14:44 | |
*** zz_jgrimm is now known as jgrimm | 14:46 | |
*** stevemar has joined #openstack-oslo | 14:51 | |
*** inc0 has joined #openstack-oslo | 14:54 | |
*** dulek___ has quit IRC | 14:55 | |
*** inc0 has quit IRC | 14:56 | |
*** inc0 has joined #openstack-oslo | 14:57 | |
*** dulek has joined #openstack-oslo | 14:58 | |
*** gordc has joined #openstack-oslo | 14:59 | |
*** e0ne is now known as e0ne_ | 15:00 | |
*** e0ne_ is now known as e0ne | 15:00 | |
*** amotoki has joined #openstack-oslo | 15:01 | |
*** inc0 has quit IRC | 15:04 | |
*** amotoki has quit IRC | 15:05 | |
*** inc0 has joined #openstack-oslo | 15:06 | |
*** mtanino has quit IRC | 15:06 | |
*** mtanino has joined #openstack-oslo | 15:07 | |
*** mtanino has quit IRC | 15:07 | |
*** mtanino has joined #openstack-oslo | 15:08 | |
*** exploreshaifali has quit IRC | 15:18 | |
*** browne has joined #openstack-oslo | 15:26 | |
*** kgiusti has left #openstack-oslo | 15:45 | |
*** haypo has left #openstack-oslo | 15:45 | |
openstackgerrit | Merged openstack/oslo.policy: Expose base check classes as part of public API https://review.openstack.org/176683 | 15:47 |
*** sputnik13 has joined #openstack-oslo | 15:50 | |
*** dulek_ has joined #openstack-oslo | 15:56 | |
*** sputnik13 has quit IRC | 15:57 | |
*** sputnik13 has joined #openstack-oslo | 15:58 | |
*** sdake_ has joined #openstack-oslo | 15:58 | |
*** dulek has quit IRC | 15:59 | |
*** sdake has quit IRC | 15:59 | |
*** dulek_ has quit IRC | 15:59 | |
*** ashleighfarnham has joined #openstack-oslo | 15:59 | |
*** pradk has quit IRC | 16:00 | |
*** sdake has joined #openstack-oslo | 16:00 | |
*** dulek has joined #openstack-oslo | 16:00 | |
*** ihrachyshka has quit IRC | 16:01 | |
*** mtanino_ has joined #openstack-oslo | 16:02 | |
*** mtanino has quit IRC | 16:03 | |
*** sdake_ has quit IRC | 16:03 | |
*** miqui has quit IRC | 16:04 | |
*** chuckC_ has joined #openstack-oslo | 16:11 | |
*** inc0 has quit IRC | 16:16 | |
*** yassine_ has quit IRC | 16:24 | |
*** ndipanov has quit IRC | 16:26 | |
*** tsekiyam is now known as tsekiyama | 16:27 | |
*** sileht has quit IRC | 16:47 | |
*** amotoki has joined #openstack-oslo | 16:50 | |
*** tsekiyama has quit IRC | 16:50 | |
*** tsbot_ has joined #openstack-oslo | 16:53 | |
*** amotoki has quit IRC | 16:54 | |
*** achanda_ has quit IRC | 16:54 | |
*** dulek has quit IRC | 16:54 | |
*** tsbot_ has quit IRC | 16:55 | |
*** tsbot_ has joined #openstack-oslo | 16:58 | |
*** tsekiyama has joined #openstack-oslo | 16:59 | |
*** tsbot_ has quit IRC | 17:02 | |
*** browne has quit IRC | 17:02 | |
*** tsbot_ has joined #openstack-oslo | 17:02 | |
*** rushiagr_away is now known as rushiagr | 17:03 | |
*** harlowja has joined #openstack-oslo | 17:05 | |
*** e0ne has quit IRC | 17:08 | |
*** stpierre has quit IRC | 17:19 | |
*** stpierre has joined #openstack-oslo | 17:20 | |
*** vilobhmm has joined #openstack-oslo | 17:26 | |
*** sileht has joined #openstack-oslo | 17:27 | |
dims_ | jd__: looks like the date/time format is blowing up in nova cells - http://logs.openstack.org/18/186418/3/check/check-devstack-dsvm-cells/1e0709d/logs/screen-n-cell-region.txt.gz?level=ERROR | 17:31 |
*** sdake_ has joined #openstack-oslo | 17:35 | |
*** browne has joined #openstack-oslo | 17:38 | |
*** sdake has quit IRC | 17:39 | |
*** salv-orlando has quit IRC | 17:43 | |
*** salv-orlando has joined #openstack-oslo | 17:47 | |
jd__ | dims_: interesting… | 17:51 |
jd__ | dims_: I wonder if they are not passing string instead of datetime object, they need to use parse_isotime() | 17:52 |
jd__ | I hope I'm wrong but it looks like they're doing crap :( | 17:52 |
dims_ | jd__: this is the receiving side i think | 17:52 |
dansmith | jd__: very likely that there are some differences in that code | 17:52 |
jd__ | dims_: "receiving" in what sense? I don't know nova cells | 17:53 |
dims_ | dansmith: fyi, this is unreleased code | 17:53 |
dansmith | jd__: alaski is out the rest of the week, but we could ask melwitt (not in this channel) to look | 17:53 |
dansmith | dims_: yep | 17:53 |
jd__ | dansmith: ok, let me know if I can help! | 17:53 |
dansmith | jd__: she'll probably need some syncing up on what is going on, if you can help with that.. I'll try to get her to join this channel when she pops up | 17:54 |
jd__ | dansmith: no prob | 17:54 |
dims_ | jd__: just poring through the code now | 17:54 |
jd__ | i'm on GMT+2 so I might be off later but she can drop me a mail anytime if needed, or bother dims or anyone else ;) | 17:54 |
dims_ | jd__: dansmith: looks like created_at and updated_at has bad date stamp | 17:55 |
dims_ | format to be precise | 17:55 |
jd__ | dims_: I think they are trying to insert directly a string, not a datetime object, in the DB | 17:55 |
jd__ | which used to work by chance | 17:55 |
dansmith | probably being converted to a string somewhere by RPC | 17:55 |
jd__ | yep | 17:56 |
jd__ | so it should be unserialized with parse_isotime | 17:56 |
*** dulek has joined #openstack-oslo | 17:56 | |
*** dulek_ has joined #openstack-oslo | 17:57 | |
*** achanda has joined #openstack-oslo | 18:00 | |
*** e0ne has joined #openstack-oslo | 18:06 | |
*** dulek_ has quit IRC | 18:08 | |
*** bknudson has quit IRC | 18:13 | |
*** alexpilotti has joined #openstack-oslo | 18:14 | |
*** bknudson has joined #openstack-oslo | 18:18 | |
*** e0ne has quit IRC | 18:21 | |
*** achanda has quit IRC | 18:23 | |
openstackgerrit | Min Pae proposed openstack/oslo-specs: Spec for taskflow stack trace on exception https://review.openstack.org/186524 | 18:30 |
openstackgerrit | Min Pae proposed openstack/oslo-specs: Spec for taskflow stack trace on exception https://review.openstack.org/186524 | 18:32 |
openstackgerrit | Min Pae proposed openstack/oslo-specs: Spec for taskflow stack trace on exception https://review.openstack.org/186524 | 18:34 |
*** amotoki has joined #openstack-oslo | 18:38 | |
*** amotoki has quit IRC | 18:43 | |
*** browne has quit IRC | 18:45 | |
openstackgerrit | Merged openstack/taskflow: Remove 'pass' usage not needed https://review.openstack.org/185271 | 18:56 |
*** kgiusti has joined #openstack-oslo | 19:04 | |
*** amrith is now known as _amrith_ | 19:04 | |
openstackgerrit | Marian Horban proposed openstack/oslo-incubator: WIP: Graceful shutdown WSGI server https://review.openstack.org/186533 | 19:08 |
*** gordc has quit IRC | 19:22 | |
*** alexpilotti has quit IRC | 19:23 | |
*** sdake has joined #openstack-oslo | 19:26 | |
*** sdake_ has quit IRC | 19:29 | |
dims_ | dhellmann: others: found a way to run all of oslo-* master with nova jobs (https://review.openstack.org/#/c/186413/) and devstack jobs (https://review.openstack.org/#/c/186418/) | 19:37 |
*** dulek has quit IRC | 20:00 | |
*** rushiagr is now known as rushiagr_away | 20:10 | |
*** achanda has joined #openstack-oslo | 20:13 | |
*** browne has joined #openstack-oslo | 20:20 | |
*** achanda has quit IRC | 20:20 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add ability to reset an engine via a `reset` method https://review.openstack.org/186239 | 20:23 |
*** sdake_ has joined #openstack-oslo | 20:26 | |
*** amotoki has joined #openstack-oslo | 20:27 | |
*** sdake has quit IRC | 20:30 | |
*** amotoki has quit IRC | 20:32 | |
*** sdake_ has quit IRC | 20:47 | |
*** sdake has joined #openstack-oslo | 20:49 | |
*** salv-orlando has quit IRC | 20:49 | |
*** shardy has quit IRC | 20:56 | |
*** vilobhmm1 has joined #openstack-oslo | 21:00 | |
*** vilobhmm has quit IRC | 21:00 | |
*** vilobhmm1 has quit IRC | 21:01 | |
*** vilobhmm has joined #openstack-oslo | 21:01 | |
mriedem | jecarey: what are your thoughts on getting this into icehouse at this point given we're about to end icehouse? https://review.openstack.org/#/c/159705/ | 21:09 |
mriedem | jecarey: that would require a backport of the change in oslo-incubator also on stable/icehouse | 21:10 |
mriedem | jecarey: it is a high impact bug though if you're not using an english locale | 21:10 |
*** sdake_ has joined #openstack-oslo | 21:11 | |
mriedem | jecarey: oh yeah, this was a regression due to the backport of https://review.openstack.org/#/c/121383/ | 21:11 |
mriedem | which was a security issue | 21:11 |
mriedem | so, we should probably work to get this in before icehouse-eol | 21:12 |
mriedem | i'll work on the o-i backport to stable/icehouse | 21:12 |
mriedem | although, https://review.openstack.org/#/c/125496/ | 21:13 |
*** jgrimm is now known as zz_jgrimm | 21:13 | |
*** sdake has quit IRC | 21:14 | |
dhellmann | dims_: o_O :-) | 21:18 |
*** haypo has joined #openstack-oslo | 21:18 | |
dhellmann | dims_: I suppose we would only do that for the one library we are considering for release | 21:19 |
dhellmann | dims_: it might be simpler to set up an experimental job using http://git.openstack.org/cgit/openstack/oslotest/tree/tools/oslo_run_pre_release_tests that we can trigger by hand somewhere | 21:20 |
*** alexpilotti has joined #openstack-oslo | 21:21 | |
haypo | dhellmann, such tool would detect the nova failure introduced by oslo.vmware 0.13 ? | 21:24 |
*** tsekiyama has quit IRC | 21:26 | |
dims_ | dhellmann: right need to figure out how to do the experimental job | 21:28 |
dims_ | haypo: one of the reviews (the one against nova) would have detected it | 21:29 |
dims_ | haypo: (https://review.openstack.org/#/c/186413/) | 21:29 |
haypo | dims_, i see "SUCCESS in 12m 34s" there, was it before the change breaking backward compatibility in nova? | 21:30 |
*** mtanino_ has quit IRC | 21:31 | |
dims_ | haypo: line 25 - https://review.openstack.org/#/c/186413/1/test-requirements.txt,cm - it's running against what we have in oslo.vmware master at the moment | 21:32 |
haypo | dims_, i would be nice to be able to automate such check before a release of an oslo library | 21:32 |
haypo | because it looks common to break a random project after an oslo release :-p | 21:32 |
dims_ | haypo: y 0.13.1 is out and seems to be fine | 21:33 |
haypo | dims_, cool :) | 21:33 |
dims_ | sending email now | 21:33 |
haypo | dims_, i will reenable oslo.vmware when tox -e py34 will pass on nova and nova will have a py34 check job | 21:34 |
*** jamielennox|away is now known as jamielennox | 21:34 | |
haypo | i mean reenable oslo.vmware on python 3, it was disable because oslo.vmware was not compatible with python 3 last week ;) | 21:34 |
dims_ | haypo: yes, please | 21:34 |
*** openstackgerrit has quit IRC | 21:36 | |
*** openstackgerrit has joined #openstack-oslo | 21:36 | |
dims_ | haypo: find someone in nova to +A https://review.openstack.org/#/c/185361/ ? | 21:38 |
haypo | dims_, joe gordon may approve the patch with my comment, i don't know | 21:39 |
haypo | dims_, if you know someone else, you can ping him/her :) | 21:39 |
*** stpierre has quit IRC | 21:46 | |
*** kgiusti has left #openstack-oslo | 21:47 | |
*** salv-orlando has joined #openstack-oslo | 21:50 | |
*** salv-orlando has quit IRC | 21:55 | |
*** alexpilotti has quit IRC | 21:55 | |
*** sdake has joined #openstack-oslo | 21:59 | |
haypo | dims_, please see https://review.openstack.org/186574 -- if i remember correctly, the first step to being able to drop suds is to upgrade oslo.vmware to 0.13.1 | 21:59 |
haypo | dims_, hum, i probably also need this change in cinder & nova to ensure that oslo.vmware works on python 3 | 22:00 |
dims_ | haypo: please add another review to drop suds>=0.4 that depends on 186574 | 22:00 |
dims_ | haypo: y, +1 to file dummy reviews in cinder, nova and other projects to make sure dropping suds and updating oslo.vmware to > 0.13.1 works | 22:01 |
dims_ | i gotta run. back in a bit | 22:01 |
*** sdake_ has quit IRC | 22:03 | |
*** jecarey has quit IRC | 22:07 | |
*** vilobhmm has quit IRC | 22:10 | |
*** amotoki has joined #openstack-oslo | 22:13 | |
*** salv-orlando has joined #openstack-oslo | 22:15 | |
*** vilobhmm has joined #openstack-oslo | 22:18 | |
*** amotoki has quit IRC | 22:18 | |
*** sdake_ has joined #openstack-oslo | 22:23 | |
*** sdake has quit IRC | 22:27 | |
*** exploreshaifali has joined #openstack-oslo | 22:37 | |
*** barra204 has joined #openstack-oslo | 22:43 | |
*** bknudson has quit IRC | 22:45 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add ability to reset an engine via a `reset` method https://review.openstack.org/186239 | 22:52 |
*** barra204 has quit IRC | 23:01 | |
openstackgerrit | Joshua Harlow proposed openstack/oslotest: Add a 'assertRaisesOneOf' helper to the base test class https://review.openstack.org/186592 | 23:01 |
*** barra204 has joined #openstack-oslo | 23:15 | |
*** dims_ has quit IRC | 23:17 | |
*** dims_ has joined #openstack-oslo | 23:20 | |
*** ashleighfarnham has quit IRC | 23:22 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add a test that checks for task result visibility https://review.openstack.org/186600 | 23:25 |
*** salv-orlando has quit IRC | 23:30 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add ability to reset an engine via a `reset` method https://review.openstack.org/186239 | 23:36 |
openstackgerrit | Merged openstack/taskflow: Only show state transitions to logging when in BLATHER mode https://review.openstack.org/184814 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!