| *** browne has joined #openstack-oslo | 00:03 | |
| *** sputnik13 has quit IRC | 00:08 | |
| *** shakamunyi has joined #openstack-oslo | 00:12 | |
| *** barra204 has joined #openstack-oslo | 00:12 | |
| openstackgerrit | James Polley proposed openstack-dev/pbr: Move CapturedSubprocess fixture to base https://review.openstack.org/187822 | 00:27 |
|---|---|---|
| openstackgerrit | James Polley proposed openstack-dev/pbr: WIP: more extensive testing of requirement parsing https://review.openstack.org/187823 | 00:27 |
| tchaypo | lifeless: on my machine, ^^^ reproduces the “invalid environment marker” failure in some cases | 00:31 |
| tchaypo | and in other cases, I am fairly sure it’s not installing the things that should be installed | 00:31 |
| tchaypo | and now it’s breakfast time | 00:31 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Cache the individual atom schedulers at compile time https://review.openstack.org/187828 | 00:39 |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Make the file driver more capable (with regard to groups) https://review.openstack.org/187750 | 00:47 |
| *** salv-orlando has joined #openstack-oslo | 00:48 | |
| harlowja | lifeless if u get some time can u re-look-over https://review.openstack.org/#/c/183194/ | 00:51 |
| harlowja | adjusted to be a new api and all that jazz | 00:51 |
| * harlowja although i'd like it for sphinx to be able to look into decorators, still doesn't do that right | 00:52 | |
| harlowja | ie http://docs-draft.openstack.org/94/183194/13/check/gate-taskflow-docs/6d0d3b2//doc/build/html/persistence.html#taskflow.persistence.backends.impl_memory.FakeFilesystem.ls (ie post-decorated method loses the docs ability to show what the args are...) | 00:53 |
| harlowja | pretty sure a known sphinx issue | 00:53 |
| openstackgerrit | lifeless proposed openstack/oslo-specs: Enable optional dependencies in OpenStack projects https://review.openstack.org/187830 | 00:53 |
| lifeless | harlowja: reminds me, haven't tracked down that weird pbr thing your colleague suffered | 00:54 |
| lifeless | harlowja: wondering if getting me a shell would be faster | 00:54 |
| *** salv-orlando has quit IRC | 00:55 | |
| *** mtanino has quit IRC | 00:56 | |
| harlowja | lifeless i'll poke him again tommorow, get him on here | 00:56 |
| harlowja | pretty sure he got sucked into doing something else | 00:56 |
| * harlowja pretty sure he's gone for the day | 00:57 | |
| *** tsekiyama has quit IRC | 00:59 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Cache the individual atom schedulers at compile time https://review.openstack.org/187828 | 01:02 |
| openstackgerrit | Merged openstack/oslo-specs: Fix references syntax for correct conversion into html https://review.openstack.org/187555 | 01:11 |
| *** superfly_ has joined #openstack-oslo | 01:12 | |
| *** superfly_ is now known as superflyy | 01:14 | |
| *** _amrith_ is now known as amrith | 01:18 | |
| *** vilobhmm1 has joined #openstack-oslo | 01:20 | |
| *** vilobhmm has quit IRC | 01:21 | |
| *** amotoki has quit IRC | 01:21 | |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Make the file driver more capable (with regard to groups) https://review.openstack.org/187750 | 01:23 |
| *** barra204 has quit IRC | 01:24 | |
| *** shakamunyi has quit IRC | 01:24 | |
| *** superflyy has quit IRC | 01:24 | |
| openstackgerrit | James Polley proposed openstack-dev/pbr: WIP: more extensive testing of requirement parsing https://review.openstack.org/187823 | 01:25 |
| *** browne has quit IRC | 01:31 | |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Make the file driver more capable (with regard to groups) https://review.openstack.org/187750 | 01:32 |
| *** tobe has joined #openstack-oslo | 01:33 | |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Make the file driver more capable (with regard to groups) https://review.openstack.org/187750 | 01:34 |
| *** amotoki has joined #openstack-oslo | 01:41 | |
| *** vilobhmm1 has quit IRC | 01:42 | |
| *** amotoki has quit IRC | 01:45 | |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Make the file driver more capable (with regard to groups) https://review.openstack.org/187750 | 01:53 |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Make the file driver more capable (with regard to groups) https://review.openstack.org/187750 | 02:02 |
| *** amotoki has joined #openstack-oslo | 02:04 | |
| *** salv-orlando has joined #openstack-oslo | 02:08 | |
| *** rushiagr_away is now known as rushiagr | 02:09 | |
| *** sdake has quit IRC | 02:11 | |
| *** salv-orlando has quit IRC | 02:14 | |
| *** yamahata has quit IRC | 02:17 | |
| openstackgerrit | Merged openstack/oslo.service: Updated from global requirements https://review.openstack.org/187683 | 02:24 |
| *** haigang has quit IRC | 02:26 | |
| *** haigang has joined #openstack-oslo | 02:27 | |
| *** haigang has quit IRC | 02:30 | |
| *** haigang has joined #openstack-oslo | 02:32 | |
| *** achanda has joined #openstack-oslo | 02:32 | |
| *** haigang has quit IRC | 02:33 | |
| lifeless | tchaypo: your patches are very confused. | 02:34 |
| lifeless | tchaypo: ok with you if I push up a fix ? | 02:34 |
| *** haigang has joined #openstack-oslo | 02:34 | |
| *** Kennan2 has joined #openstack-oslo | 02:37 | |
| *** Kennan has quit IRC | 02:38 | |
| *** haigang has quit IRC | 02:38 | |
| *** rushiagr is now known as rushiagr_away | 02:40 | |
| openstackgerrit | lifeless proposed openstack-dev/pbr: WIP detangling. https://review.openstack.org/187845 | 02:43 |
| *** haigang has joined #openstack-oslo | 02:46 | |
| openstackgerrit | lifeless proposed openstack-dev/pbr: WIP detangling. https://review.openstack.org/187845 | 02:47 |
| lifeless | tchaypo: squash that into your patch | 02:47 |
| *** Kennan2 is now known as Kennan | 02:49 | |
| openstackgerrit | lifeless proposed openstack-dev/pbr: Fix everything by requiring setuptools>=16. https://review.openstack.org/187846 | 02:54 |
| *** dims__ has quit IRC | 02:56 | |
| lifeless | tchaypo: (nicely done on the tests btw, made a good matrix to base analysis on) | 02:57 |
| lifeless | tchaypo: I haven't dug into *why* setuptools 16 is key, just that it made all the tests pass | 02:58 |
| *** achanda has quit IRC | 03:02 | |
| *** achanda has joined #openstack-oslo | 03:03 | |
| tchaypo | gah. | 03:07 |
| *** achanda has quit IRC | 03:08 | |
| tchaypo | ho hum. I seem to already have setuptools 16 on my machine | 03:08 |
| tchaypo | lifeless: yes, very okay, I was out getting coffee/lunch :) | 03:08 |
| tchaypo | ah, i have setuptools 16 in the system, but 15 in the tox venv | 03:09 |
| tchaypo | no doubt i have an older version of irtualenv.. | 03:09 |
| lifeless | yah | 03:25 |
| lifeless | system virtualenv likely | 03:25 |
| *** achanda has joined #openstack-oslo | 03:34 | |
| tchaypo | I think I upgraded it a few weeks ago, but that was probably just before the most recent release | 03:46 |
| tchaypo | the most recent major version, rather | 03:46 |
| lifeless | note too that there is a matrix | 03:46 |
| lifeless | pip installed || distro | 03:46 |
| lifeless | one bundles the other unbundles | 03:46 |
| lifeless | etc | 03:46 |
| tchaypo | looking at your detangling | 03:48 |
| tchaypo | I’m confused about os.makedirs() | 03:48 |
| lifeless | do you understand the confusion your code had? | 03:48 |
| tchaypo | at line 438 - shouldn’t the TempDir fixture be doing that? | 03:49 |
| lifeless | that is a different path | 03:49 |
| lifeless | look at the uses of tempdir in the test_ function | 03:49 |
| tchaypo | well, there are several sets of confusion | 03:49 |
| tchaypo | one is that i was using a single tempdir as both the base for the venv and the base for the package, which I don’t think breaks anything per se but it gets confusing | 03:50 |
| tchaypo | the other is installing the wrong pbr | 03:50 |
| lifeless | I haven't fixed that one | 03:50 |
| lifeless | we should if we want to land this patch | 03:51 |
| tchaypo | oh *facepalm* | 03:51 |
| tchaypo | also, looking at your change to the _run_cmd call | 03:51 |
| tchaypo | I hadn’t thought about what sys.executable was doing there | 03:51 |
| tchaypo | but from your change it looks like I was calling the system pip rather than the one in the venv? | 03:52 |
| lifeless | not quite | 03:52 |
| lifeless | system python, script from the venv | 03:52 |
| lifeless | the results from that are poor :) | 03:52 |
| tchaypo | yes. | 03:53 |
| tchaypo | hrm. so lines 487/488, where you create venv_dir and pkg_dir | 03:53 |
| tchaypo | oh | 03:53 |
| tchaypo | the “haven’t fixed that one” refers to installing this version of pbr | 03:54 |
| *** arnaud____ has joined #openstack-oslo | 03:54 | |
| tchaypo | right | 03:54 |
| tchaypo | so I could do that by hard-coding “pip install -U /Users/james/src/openstack-dev/pbr”, but that doesn’t seem very portable | 03:55 |
| *** alexpilotti has joined #openstack-oslo | 03:55 | |
| *** browne has joined #openstack-oslo | 03:55 | |
| lifeless | an easy approximation would be do os.path.join(__file__, '..', '..', '..') or something like that | 03:56 |
| lifeless | no -U needed | 03:57 |
| lifeless | we can't do much about the pbr-not-installed case sadly | 03:58 |
| *** achanda has quit IRC | 03:58 | |
| lifeless | because easy_install | 03:58 |
| *** achanda has joined #openstack-oslo | 03:58 | |
| tchaypo | hrm. on my system, I’ve added “setuptools>=16” to test-requirements.txt, rmed .tox, and re-run tox | 03:59 |
| tchaypo | I’m still getting the same failure, even though the venv now has setuptools 17 | 03:59 |
| lifeless | that won't do anything | 03:59 |
| lifeless | you're creating a venv per test case | 03:59 |
| lifeless | tox has 0 to do with that venv's contents | 03:59 |
| tchaypo | *facepalm* | 04:00 |
| tchaypo | please excuse me while I do a dance of frustration around the room | 04:00 |
| lifeless | what are you frustrated by ? | 04:01 |
| tchaypo | the layers | 04:02 |
| tchaypo | but I guess that’s to be expected when you’re testing behind-the-scenes install-packages machinery | 04:02 |
| tchaypo | in order to exercise it you need to actually be installing packages inside your test | 04:02 |
| *** achanda has quit IRC | 04:03 | |
| lifeless | remember too we can't setup_require setuptools | 04:05 |
| lifeless | so there is nothing we can do to fix this systematically (today) | 04:05 |
| tchaypo | yep | 04:05 |
| lifeless | what we can do is make sure opentack CI has setuptools>=16 everywhere. | 04:05 |
| lifeless | I have a patch up for virtualenv that will do that (its in system-config) | 04:06 |
| tchaypo | it’s just going to have to be a case of “if you want to be able to use extras_require in setup.cfg, your system must have setuptools>=16, cheers" | 04:06 |
| tchaypo | does that patch also use pip7? | 04:06 |
| lifeless | tchaypo: not quite; 'markers' | 04:06 |
| tchaypo | urr, yes. markers. | 04:06 |
| lifeless | extras are fine regardless | 04:06 |
| tchaypo | if we can get pip7 we can start using `pip install .[test]` | 04:06 |
| lifeless | the patch makes the images we build have virtualenv with pip 7.0.3 in it preinstalled | 04:07 |
| lifeless | so yes | 04:07 |
| lifeless | tchaypo: I put up an oslo spec on using this too btw | 04:07 |
| tchaypo | link? | 04:07 |
| lifeless | meh | 04:07 |
| * tchaypo will dig | 04:08 | |
| lifeless | (I don't have one to hand) | 04:08 |
| tchaypo | https://review.openstack.org/#/c/187830/ | 04:08 |
| *** salv-orlando has joined #openstack-oslo | 04:10 | |
| tchaypo | that took like 3 seconds to find | 04:10 |
| lifeless | ok so jenkins didn't like my patch :) | 04:14 |
| lifeless | tag, its yours | 04:14 |
| tchaypo | tah cheers thanks a lot | 04:14 |
| tchaypo | in other news, your spec reads to me like it’s trying to do two things at once | 04:15 |
| tchaypo | the “problem description” talks about one problem (we don’t support extras), but everything else solves a different problem (oslo.db needs dfferent backends for different databases) | 04:15 |
| tchaypo | they’re interrelated, in that the latter requires - and acts as a nice proof-of-concept for - the former | 04:16 |
| lifeless | mmm | 04:17 |
| lifeless | perhaps | 04:17 |
| lifeless | we're doing one (extras) for the other | 04:17 |
| lifeless | linear dependency chain | 04:17 |
| tchaypo | extras is useful for other things too though, and we already have patches up wanting to take advantage | 04:24 |
| *** jecarey has joined #openstack-oslo | 04:25 | |
| tchaypo | 184328 is one but I think there’s another one somewhere | 04:26 |
| tchaypo | okay, this is going to have to wait for tomorrow | 04:50 |
| tchaypo | my expense report is already half a week overdue and I really don’t want to make ng any sadder | 04:51 |
| *** stevemar has quit IRC | 04:58 | |
| *** nkrinner has joined #openstack-oslo | 05:03 | |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Make the file driver more capable (with regard to groups) https://review.openstack.org/187750 | 05:13 |
| *** jecarey has quit IRC | 05:15 | |
| *** yamahata has joined #openstack-oslo | 05:19 | |
| *** arnaud____ has quit IRC | 05:21 | |
| *** exploreshaifali has joined #openstack-oslo | 05:27 | |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Make the file driver more capable (with regard to groups) https://review.openstack.org/187750 | 05:34 |
| *** vilobhmm has joined #openstack-oslo | 05:42 | |
| *** exploreshaifali has quit IRC | 05:43 | |
| *** dulek has joined #openstack-oslo | 05:46 | |
| *** ihrachyshka has joined #openstack-oslo | 05:50 | |
| *** vipul has quit IRC | 05:53 | |
| *** vipul has joined #openstack-oslo | 05:54 | |
| *** vilobhmm has quit IRC | 05:58 | |
| *** ihrachyshka has quit IRC | 06:02 | |
| *** shakamunyi has joined #openstack-oslo | 06:16 | |
| *** barra204 has joined #openstack-oslo | 06:17 | |
| *** shardy has joined #openstack-oslo | 06:55 | |
| *** browne has quit IRC | 07:02 | |
| *** inc0 has joined #openstack-oslo | 07:03 | |
| *** rpodolyaka1 has joined #openstack-oslo | 07:11 | |
| *** Nakato has quit IRC | 07:16 | |
| *** exploreshaifali has joined #openstack-oslo | 07:18 | |
| *** Nakato has joined #openstack-oslo | 07:18 | |
| *** haigang has quit IRC | 07:19 | |
| *** tobe has quit IRC | 07:52 | |
| *** ozamiatin has joined #openstack-oslo | 07:54 | |
| *** dims_ has joined #openstack-oslo | 07:58 | |
| *** ndipanov has joined #openstack-oslo | 08:00 | |
| *** rushiagr_away is now known as rushiagr | 08:02 | |
| *** dims_ has quit IRC | 08:03 | |
| *** ozamiatin has quit IRC | 08:07 | |
| *** exploreshaifali has quit IRC | 08:08 | |
| *** Kennan2 has joined #openstack-oslo | 08:11 | |
| *** Kennan has quit IRC | 08:11 | |
| *** Nakato has quit IRC | 08:13 | |
| *** rpodolyaka1 has quit IRC | 08:14 | |
| *** tobe has joined #openstack-oslo | 08:14 | |
| *** Nakato has joined #openstack-oslo | 08:14 | |
| *** shardy_ has joined #openstack-oslo | 08:16 | |
| *** shardy has quit IRC | 08:17 | |
| *** shardy_ has quit IRC | 08:22 | |
| *** shardy has joined #openstack-oslo | 08:22 | |
| *** yassine_ has joined #openstack-oslo | 08:27 | |
| *** rpodolyaka1 has joined #openstack-oslo | 08:30 | |
| *** ozamiatin has joined #openstack-oslo | 08:36 | |
| *** e0ne has joined #openstack-oslo | 08:46 | |
| *** nkrinner has quit IRC | 08:52 | |
| *** nkrinner has joined #openstack-oslo | 08:57 | |
| *** e0ne is now known as e0ne_ | 09:01 | |
| *** e0ne_ is now known as e0ne | 09:01 | |
| *** dguitarbite has quit IRC | 09:09 | |
| *** cdent has joined #openstack-oslo | 09:10 | |
| openstackgerrit | Merged openstack-dev/pbr: Remove sphinx_config.init_values() manual call https://review.openstack.org/187672 | 09:13 |
| openstackgerrit | Victor Sergeyev proposed openstack/oslo.messaging: Reduce `magic` conf attribute usage https://review.openstack.org/187923 | 09:17 |
| *** gcb has joined #openstack-oslo | 09:27 | |
| *** rpodolyaka1 has quit IRC | 09:42 | |
| *** rpodolyaka1 has joined #openstack-oslo | 09:45 | |
| *** ozamiatin has quit IRC | 09:49 | |
| *** e0ne is now known as e0ne_ | 09:55 | |
| *** e0ne_ is now known as e0ne | 09:57 | |
| *** dguitarbite has joined #openstack-oslo | 09:59 | |
| openstackgerrit | Dirk Mueller proposed openstack/oslo.db: Remove outdated tox environments for SQLAlchemy 0.8 https://review.openstack.org/187927 | 09:59 |
| *** dims_ has joined #openstack-oslo | 10:06 | |
| *** rpodolyaka1 has quit IRC | 10:10 | |
| *** exploreshaifali has joined #openstack-oslo | 10:12 | |
| *** amotoki has quit IRC | 10:40 | |
| *** amotoki has joined #openstack-oslo | 10:44 | |
| *** amotoki has quit IRC | 10:48 | |
| dhellmann | sileht: did you see https://bugs.launchpad.net/oslo.messaging/+bug/1461182 ? | 10:52 |
| openstack | Launchpad bug 1461182 in oslo.messaging "After oslo.messaging release Ironic gate is broken" [Undecided,In progress] - Assigned to Doug Hellmann (doug-hellmann) | 10:52 |
| dhellmann | sileht: also, good morning/afternoon :-) | 10:52 |
| sileht | dhellmann, yep, I have seen your quick re-released this morning | 10:52 |
| dhellmann | sileht: yeah, that patch is sort of ugly, but I wanted to fix up ironic quickly. Do you have ideas for fixing the issue in a better way? Maybe moving the option definition somewhere where sharing it seems less ugly? | 10:53 |
| sileht | dhellmann, we should register the option with the Transport | 10:54 |
| dhellmann | sileht: that's not the code that uses it, though, right? | 10:54 |
| sileht | dhellmann, this is the only common path between the client and the server parts | 10:54 |
| *** exploreshaifali has quit IRC | 10:54 | |
| dhellmann | I don't mind calling register more than once, I just don't like having the server code import the client code to do it | 10:55 |
| sileht | dhellmann, oh so we can add it the the rpc server | 10:55 |
| dhellmann | ok, except that the case that was breaking was the rabbit driver module | 10:56 |
| dhellmann | maybe if we have oslo_messaging/rpc/_opts.py and use that from both client.py and server.py it's clear enough that it is an rpc option, and it's safe to assume it will be registered before the driver is loaded? | 10:57 |
| sileht | dhellmann, yes that my thougt | 10:57 |
| dhellmann | except that the driver might also be used for notifications, right? and so we need that option to be registered *there* too in case the application only does notifications and not rpc | 10:57 |
| sileht | dhellmann, I need to check how ironic trigger that | 10:58 |
| dhellmann | they have an application that only accepts incoming rpc requests, and never makes any outgoing requests to other services | 10:58 |
| sileht | dhellmann, the driver use it for reply messages | 10:58 |
| dhellmann | the tests that failed were in their integration suite, not unit tests or dsvm, so I'm not entirely sure how to trigger it | 10:59 |
| dhellmann | no, the driver was never instantiating a Client instance, it was using direct communication | 10:59 |
| dhellmann | at least not in the path involved here | 10:59 |
| *** sdake has joined #openstack-oslo | 11:02 | |
| sileht | dhellmann, the rpc/_opts.py looks good for me, publish_and_retry_on_missing_exchange is a rpc thing only | 11:02 |
| dhellmann | publish_and_retry... is part of the driver API that is only used by rpc? | 11:03 |
| dhellmann | I don't suppose there's a way we could have the higher level code pass this value to the driver, instead of having the driver rely on the option being registered? would that require a bunch of driver API changes? | 11:04 |
| *** exploreshaifali has joined #openstack-oslo | 11:10 | |
| *** rpodolyaka1 has joined #openstack-oslo | 11:10 | |
| sileht | dhellmann, This is used to workaround a rabbit failover race, when we fix the issue, we hardcore 60 sec, we have improve the code by not always waiting 60 sec, perhaps we should create an new configuration option that clearly identify this race, with as default value '$rpc_response_timeout' | 11:15 |
| dhellmann | sileht: let me think about that. I'm not sure I like the idea of having more options. Would a deployer ever want to make the values different? | 11:17 |
| sileht | dhellmann, this depends on the time of every rpc server take to reconnect to the new rabbit | 11:18 |
| sileht | dhellmann, we choice rpc_response_timeout, because we known the the client will not wait more for a reply | 11:19 |
| sileht | dhellmann, but usually just 1 or 2 is enough | 11:19 |
| sileht | (sec) | 11:20 |
| dhellmann | sileht: ok. it seems cleaner inside the code to add a new option, but it does increase configuration complexity. :-/ | 11:22 |
| *** rushiagr is now known as rushiagr_away | 11:25 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/futurist: Updated from global requirements https://review.openstack.org/187951 | 11:28 |
| *** ozamiatin has joined #openstack-oslo | 11:29 | |
| *** e0ne is now known as e0ne_ | 11:32 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: Add drivers to the documentation https://review.openstack.org/183825 | 11:41 |
| *** e0ne_ has quit IRC | 11:42 | |
| *** rpodolyaka1 has quit IRC | 11:44 | |
| *** rpodolyaka1 has joined #openstack-oslo | 11:46 | |
| openstackgerrit | Victor Sergeyev proposed openstack/oslo.messaging: Enable `fanout_target` scenarios in test_impl_rabbit https://review.openstack.org/187963 | 11:52 |
| *** tobe has quit IRC | 11:56 | |
| *** tobe has joined #openstack-oslo | 11:57 | |
| *** e0ne has joined #openstack-oslo | 11:58 | |
| *** tobe has quit IRC | 12:02 | |
| *** rpodolyaka1 has quit IRC | 12:06 | |
| *** rpodolyaka1 has joined #openstack-oslo | 12:08 | |
| *** amrith is now known as _amrith_ | 12:17 | |
| *** amotoki has joined #openstack-oslo | 12:18 | |
| openstackgerrit | Kobi Samoray proposed openstack/tooz: Use MySQL default port when not set explicitly https://review.openstack.org/187982 | 12:32 |
| *** gordc has joined #openstack-oslo | 12:38 | |
| *** kgiusti has joined #openstack-oslo | 12:39 | |
| openstackgerrit | Merged openstack/oslotest: Add class to deal with clouds.yaml support https://review.openstack.org/183387 | 12:44 |
| viktors | dhellmann: around? | 12:47 |
| viktors | dhellmann: as for patch https://review.openstack.org/#/c/187746/ - are you sure, that oslo.messaging catch a bug 1367907? Is it possible, that oslo.messaging bug caused by checking time of thread run in test_impl_rabbit.py ? | 12:49 |
| openstack | bug 1367907 in python3.4 (Ubuntu Trusty) "Segfault in gc with cyclic trash" [Undecided,Triaged] https://launchpad.net/bugs/1367907 | 12:49 |
| dims_ | sileht: do we need any changes in kombu and/or pyamqp? | 12:50 |
| dims_ | sileht: to make things better for us in oslo.messaging | 12:50 |
| sileht | dims_, just something to set a default timeout for socket opened by pyamqp to remove the workaround in our driver | 12:51 |
| *** inc0 has quit IRC | 12:52 | |
| sileht | dims_, viktors cool investigation of rabbit guys https://github.com/rabbitmq/rabbitmq-website/issues/6 | 12:54 |
| *** bknudson has joined #openstack-oslo | 12:56 | |
| sileht | dims_, viktors https://www.rabbitmq.com/direct-reply-to.html is interesting, but I have no idea of how many works it is | 12:56 |
| dims_ | flaper87: we could use your help with this https://github.com/celery/kombu/issues/463 | 12:57 |
| dims_ | sileht: nice avatar on github :) | 12:58 |
| sileht | dims_, flaper87 an other work around py-amqp timeout: https://github.com/celery/py-amqp/pull/64 | 12:59 |
| *** ozamiatin has quit IRC | 12:59 | |
| viktors | sileht: looks like a cool thing, reading now | 13:00 |
| * flaper87 checks both links | 13:00 | |
| sileht | I think is one is enough for ys | 13:00 |
| sileht | (and my better than my patch) | 13:00 |
| *** tsekiyama has joined #openstack-oslo | 13:01 | |
| *** tsekiyama has quit IRC | 13:04 | |
| dims_ | sileht: added a bug so we don't forget - https://bugs.launchpad.net/oslo.messaging/+bug/1461538 | 13:05 |
| openstack | Launchpad bug 1461538 in oslo.messaging "Track upstream changes from projects we use for rabbitmq" [Undecided,New] | 13:05 |
| sileht | dims_, cool | 13:06 |
| *** nkrinner has quit IRC | 13:15 | |
| *** stevemar has joined #openstack-oslo | 13:17 | |
| dhellmann | dims_, jd__, harlowja, bnemec : this namespace package change in oslo.middleware is ready to go in: https://review.openstack.org/#/c/181975/ | 13:19 |
| dhellmann | sileht: ^^ | 13:19 |
| dhellmann | viktors: it's possible -- I'm not sure what's causing the bug. But either way, it was blocking us from fixing ironic yesterday. | 13:19 |
| *** ozamiatin has joined #openstack-oslo | 13:20 | |
| dims_ | dhellmann: +2 | 13:20 |
| dhellmann | dims_: thanks; if we can merge it this week, I'd like to release it next monday | 13:21 |
| dims_ | dhellmann: sounds good | 13:22 |
| *** zzzeek has joined #openstack-oslo | 13:23 | |
| *** jecarey has joined #openstack-oslo | 13:32 | |
| *** mriedem_away is now known as mriedem | 13:32 | |
| *** e0ne is now known as e0ne_ | 13:41 | |
| *** e0ne_ is now known as e0ne | 13:41 | |
| openstackgerrit | Merged openstack/tooz: Use fasteners library for interprocess locks https://review.openstack.org/185784 | 13:42 |
| * mdbooth waves | 13:43 | |
| * dhellmann waves back | 13:43 | |
| mdbooth | dhellmann: Were you referring to pbr, btw? | 13:43 |
| * mdbooth is | 13:43 | |
| dhellmann | mdbooth: yeah, what's up | 13:43 |
| * mdbooth is getting the following error trying to run some old unit tests: | 13:43 | |
| viktors | dims_: can you please abandon this one - https://review.openstack.org/#/c/123691/ ? | 13:43 |
| mdbooth | ValueError: git history requires a target version of pbr.version.SemanticVersion(2013.2.5), but target version is pbr.version.SemanticVersion(2013.2.4) | 13:43 |
| mdbooth | I don't know what any of those things mean :) | 13:44 |
| dims_ | viktors: done | 13:44 |
| viktors | dims_: thanks! | 13:44 |
| dhellmann | mdbooth: hang on, I think lifeless wrote something about this on the ML a while back | 13:44 |
| mdbooth | I can obviously find out by rtfs, but I was hoping somebody might be able to shortcut the process for me :) | 13:44 |
| dhellmann | mdbooth: which version of pbr are you using? | 13:44 |
| mdbooth | dhellmann: requirements.txt says: pbr>=0.5.21,<1.0 | 13:45 |
| mdbooth | How do I ask pip? | 13:45 |
| dhellmann | mdbooth: http://lists.openstack.org/pipermail/openstack-dev/2015-April/063063.html | 13:45 |
| mdbooth | Hmm, interesting | 13:45 |
| mdbooth | Seems it's 1.0.1 | 13:45 |
| dhellmann | mdbooth: you can run "pip freeze" to get the pbr version | 13:46 |
| mdbooth | Which is decidedly not <1.0 | 13:46 |
| dhellmann | is this a devstack system? | 13:46 |
| mdbooth | No, RHOS 4 | 13:46 |
| dhellmann | master or kilo? | 13:46 |
| mdbooth | No ;) | 13:46 |
| dhellmann | ok, well, I can't explain what you've got then :-) | 13:47 |
| mriedem | mdbooth: so you are probably working with no longer supported upstream branches, | 13:47 |
| mriedem | and newer pbr | 13:47 |
| mriedem | mdbooth: we've had the same issue in our internal havana which we still support | 13:47 |
| mdbooth | Release H I believe | 13:47 |
| mriedem | basically, comment out the version from setup.cfg so that pbr will automatically generate the next version for you | 13:47 |
| mdbooth | Ish | 13:47 |
| dhellmann | mriedem: this sounds like something worthy of a bug report | 13:48 |
| mriedem | dhellmann: it's by design | 13:48 |
| mriedem | documented here http://docs.openstack.org/developer/pbr/semver.html | 13:48 |
| mdbooth | pbr-0.11.0 | 13:48 |
| mriedem | the only bug would have been they shouldn't have made the cutover in 0.11 but held off for 1.0 | 13:48 |
| mriedem | mdbooth: yeah, we've had the same issue - you have 3 options: | 13:49 |
| mriedem | 1. remove explicit version entry from setup.cfg | 13:49 |
| mriedem | 2. pin pbr < 0.11 | 13:49 |
| mriedem | 3. update the version in setup.cfg to be n+1 for your last release tag in your repo | 13:49 |
| *** ihrachyshka has joined #openstack-oslo | 13:49 | |
| mdbooth | Just tried 2 and got: | 13:50 |
| mdbooth | File "/home/mbooth/src/openstack/nova/.venv/lib/python2.7/site-packages/testtools/__init__.py", line 126, in <module> | 13:51 |
| mdbooth | __version__ = _version.semantic_version().version_tuple() | 13:51 |
| mdbooth | AttributeError: 'VersionInfo' object has no attribute 'semantic_version' | 13:51 |
| openstackgerrit | Julien Danjou proposed openstack/oslo.utils: Replace parse_strtime with parse_isotime in older/newer https://review.openstack.org/188009 | 13:51 |
| openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: fix newer/older comparison with TZ aware datetime https://review.openstack.org/188010 | 13:51 |
| mriedem | mdbooth: so, the tricky thing is, | 13:51 |
| mdbooth | Trying 1 | 13:51 |
| mriedem | mdbooth: if you're going to pin pbr < 0.11, you also have to pin a bunch of test libraries that pull in pbr >= 0.11 | 13:51 |
| mriedem | so pinning was a pain in the ass option for us and we went with #2 | 13:51 |
| mriedem | fwiw, i think there are some bugs in pbr if it's supposed to match everything in http://docs.openstack.org/developer/pbr/semver.html | 13:52 |
| mdbooth | You mean #3? | 13:52 |
| mriedem | sorry, #1 | 13:52 |
| mriedem | we did 1 | 13:52 |
| mdbooth | Ok | 13:52 |
| mdbooth | I just unpinned the version, and I still get the SemanticVersion error | 13:52 |
| mriedem | and we version our packages as we want regardless of what pbr thinks the version should be since we have vendor tags in our versions | 13:52 |
| mriedem | b/c our versions were like 2013.2.5.ibm | 13:53 |
| * mdbooth will try an explicit version # in setup.cfg | 13:53 | |
| mriedem | and that used to work, but now the .ibm doesn't work | 13:53 |
| mdbooth | tbh, the version number isn't at all interesting to my use case, here | 13:53 |
| mdbooth | Really just need the unit tests to run | 13:53 |
| mriedem | mdbooth: yeah, so #1 should fix that | 13:54 |
| mriedem | pbr will scan the git tags on the repo and find the latest release tag and use that + 1 for the next version number on the package | 13:54 |
| *** sigmavirus24_awa is now known as sigmavirus24 | 13:54 | |
| mriedem | isn't it awesome supporting branches that are eol upstream? :) | 13:55 |
| mdbooth | \o/ | 13:55 |
| * mriedem was just about to send a note to the ML about icehouse-eol | 13:55 | |
| *** dulek has quit IRC | 14:00 | |
| *** rpodolyaka1 has quit IRC | 14:01 | |
| dhellmann | lifeless: I wonder if we need a better story for ^^. Either docs, or some way to turn off the check? | 14:02 |
| *** Kennan2 has quit IRC | 14:02 | |
| *** Kennan has joined #openstack-oslo | 14:03 | |
| *** rpodolyaka1 has joined #openstack-oslo | 14:07 | |
| mdbooth | mriedem: I allowed it to fetch the latest pbr, and hacked setup.cfg to contain what it seemed to be looking for. Success :) | 14:09 |
| mdbooth | mriedem dhellmann: Thanks | 14:09 |
| mriedem | mdbooth: sure, although if you're setting a specific version in setup.cfg and at some point you do a release on your havana branch, you'll hit the same issue again later | 14:09 |
| mdbooth | That stuff happens behind a curtain. I assume... | 14:10 |
| openstackgerrit | Merged openstack/oslo.middleware: Remove oslo namespace package https://review.openstack.org/181975 | 14:10 |
| *** inc0_ has joined #openstack-oslo | 14:13 | |
| *** inc0_ has quit IRC | 14:13 | |
| *** mtanino has joined #openstack-oslo | 14:20 | |
| *** mdbooth has quit IRC | 14:21 | |
| *** elarson_ has joined #openstack-oslo | 14:22 | |
| *** zz_jgrimm is now known as jgrimm | 14:25 | |
| *** david-lyle has quit IRC | 14:25 | |
| *** elarson has quit IRC | 14:27 | |
| *** tsekiyama has joined #openstack-oslo | 14:27 | |
| *** elarson_ is now known as elarson | 14:27 | |
| *** rpodolyaka1 has quit IRC | 14:27 | |
| *** sputnik13 has joined #openstack-oslo | 14:31 | |
| *** _amrith_ is now known as amrith | 14:33 | |
| dhellmann | dims_, jd__, sileht, harlowja, bnemec : another namespace package patch ready to land, oslo.rootwrap: https://review.openstack.org/#/c/181978 (cc ttx) | 14:35 |
| *** exploreshaifali has quit IRC | 14:36 | |
| *** barra204 has quit IRC | 14:36 | |
| *** shakamunyi has quit IRC | 14:36 | |
| *** nikhil_k is now known as nikhil_k-brb | 14:52 | |
| *** dguitarbite has quit IRC | 14:59 | |
| *** jgrimm is now known as zz_jgrimm | 15:10 | |
| *** ozamiatin has quit IRC | 15:12 | |
| *** mdbooth has joined #openstack-oslo | 15:20 | |
| *** alexpilotti has quit IRC | 15:24 | |
| *** jecarey has quit IRC | 15:24 | |
| *** jecarey has joined #openstack-oslo | 15:26 | |
| openstackgerrit | Kobi Samoray proposed openstack/tooz: Use MySQL default port when not set explicitly https://review.openstack.org/187982 | 15:28 |
| openstackgerrit | Julien Danjou proposed openstack/oslo.utils: timeutils: fix newer/older comparison with TZ aware datetime https://review.openstack.org/188010 | 15:31 |
| *** e0ne is now known as e0ne_ | 15:32 | |
| *** rpodolyaka1 has joined #openstack-oslo | 15:34 | |
| *** e0ne_ is now known as e0ne | 15:35 | |
| openstackgerrit | Merged openstack/oslo.rootwrap: Remove oslo namespace package https://review.openstack.org/181978 | 15:36 |
| *** david-lyle has joined #openstack-oslo | 15:39 | |
| *** zz_jgrimm is now known as jgrimm | 15:40 | |
| *** rpodolyaka1 has quit IRC | 15:40 | |
| *** rpodolyaka1 has joined #openstack-oslo | 15:41 | |
| *** david-lyle has quit IRC | 15:47 | |
| *** alexpilotti has joined #openstack-oslo | 15:48 | |
| *** mdbooth has quit IRC | 15:49 | |
| *** nikhil_k-brb is now known as nikhil_k | 15:50 | |
| *** mdbooth has joined #openstack-oslo | 15:50 | |
| *** david-lyle has joined #openstack-oslo | 15:53 | |
| *** dulek has joined #openstack-oslo | 15:59 | |
| *** rushiagr_away is now known as rushiagr | 16:03 | |
| *** arnaud____ has joined #openstack-oslo | 16:05 | |
| *** jgrimm is now known as zz_jgrimm | 16:07 | |
| *** jecarey has quit IRC | 16:07 | |
| *** zz_jgrimm is now known as jgrimm | 16:09 | |
| *** jecarey has joined #openstack-oslo | 16:10 | |
| *** dulek has quit IRC | 16:13 | |
| *** SridharGaddam has quit IRC | 16:13 | |
| *** dulek has joined #openstack-oslo | 16:14 | |
| *** vilobhmm has joined #openstack-oslo | 16:16 | |
| *** dims_ has quit IRC | 16:18 | |
| *** dims_ has joined #openstack-oslo | 16:18 | |
| *** ashleighfarnham has joined #openstack-oslo | 16:19 | |
| *** gordc is now known as gordc_afk | 16:19 | |
| *** dims__ has joined #openstack-oslo | 16:20 | |
| *** jamielennox is now known as jamielennox|away | 16:21 | |
| *** barra204 has joined #openstack-oslo | 16:21 | |
| *** david-lyle has quit IRC | 16:22 | |
| *** dims_ has quit IRC | 16:24 | |
| *** rpodolyaka1 has quit IRC | 16:24 | |
| *** rpodolyaka1 has joined #openstack-oslo | 16:25 | |
| *** barra204 has quit IRC | 16:28 | |
| *** ihrachyshka has quit IRC | 16:28 | |
| *** yassine_ has quit IRC | 16:31 | |
| *** arnaud____ has quit IRC | 16:31 | |
| *** dulek has quit IRC | 16:33 | |
| *** dulek has joined #openstack-oslo | 16:36 | |
| *** rpodolyaka1 has quit IRC | 16:53 | |
| *** dulek has quit IRC | 16:58 | |
| *** amotoki has quit IRC | 17:09 | |
| *** david-lyle has joined #openstack-oslo | 17:13 | |
| *** david-lyle has quit IRC | 17:13 | |
| *** david-lyle has joined #openstack-oslo | 17:15 | |
| *** rushiagr is now known as rushiagr_away | 17:15 | |
| *** e0ne has quit IRC | 17:17 | |
| *** yamahata has quit IRC | 17:21 | |
| krotscheck | Does anyone here understand how pastedeploy work, and can answer a few quick questions? | 17:25 |
| krotscheck | i.e. I have this CORS middleware that currently takes an oslo config instance as an explicit parameter. | 17:25 |
| krotscheck | Is that somethign that pastedeploy can manage, or do I have to update the middleware? | 17:25 |
| *** david-lyle has quit IRC | 17:28 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/188114 | 17:38 |
| *** gordc_afk is now known as gordc | 17:39 | |
| *** yamahata has joined #openstack-oslo | 17:40 | |
| *** ashleighfarnham has left #openstack-oslo | 17:45 | |
| *** directxman12 has joined #openstack-oslo | 17:52 | |
| *** stpierre has joined #openstack-oslo | 17:54 | |
| directxman12 | dims__: for graduating oslo.reports, does it matter whether I create the launchpad project first, and then file the gerrit CI request, or the other way around? (the "CreatingANewLibrary" page does CI first, LP later, but the "Repository Creator's Guide seems to suggest the other way around) | 17:56 |
| lifeless | mdbooth: hi | 18:08 |
| lifeless | dhellmann: hi | 18:09 |
| lifeless | so, if the repo is tagged, the tag wins | 18:09 |
| lifeless | we could indeed have a way to say that the version line in setup.cfg should be ignored if not plausible | 18:09 |
| lifeless | I think that would have to be opt-in though | 18:10 |
| dims__ | directxman12: either one is fine | 18:15 |
| directxman12 | dims__: ok, thanks | 18:15 |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Use a lru cache to limit the size of the internal file cache https://review.openstack.org/176104 | 18:19 |
| *** yamahata has quit IRC | 18:25 | |
| *** yamahata has joined #openstack-oslo | 18:25 | |
| lifeless | zzzeek: hi | 18:26 |
| zzzeek | lifeless: heya | 18:26 |
| lifeless | zzzeek: there was a session on moving to pymysql @ the summit, and our names got put on some actions :) | 18:27 |
| zzzeek | wow | 18:27 |
| harlowja | jd__ lol, all the timezone stuff is funny | 18:27 |
| harlowja | *and/or scary, lol | 18:27 |
| zzzeek | lifeless: well, pymysql is just change the URL + requirements | 18:27 |
| lifeless | https://etherpad.openstack.org/p/liberty-cross-project-python3 | 18:27 |
| lifeless | zzzeek: there was a little more to it :) | 18:28 |
| lifeless | tasks, down the bottom | 18:28 |
| zzzeek | lifeless: bah. | 18:28 |
| harlowja | zzzeek when will https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/dialects/mysql/__init__.py#L12 change? | 18:28 |
| harlowja | will it? | 18:28 |
| harlowja | to be pymysql | 18:28 |
| lifeless | zzzeek: anyhow, the good news is that we committed to moving to it - so that megathread has finally paid off :) | 18:28 |
| zzzeek | harlowja: unlikely | 18:28 |
| harlowja | durn | 18:28 |
| zzzeek | lifeless: so…. element 4.6 ? | 18:29 |
| zzzeek | lifeless: or element 4.4, that one seems more strangey | 18:29 |
| zzzeek | lifeless: run nova on both? ooooo k | 18:30 |
| openstackgerrit | Joshua Harlow proposed openstack/tooz: Make the file driver more capable (with regard to groups) https://review.openstack.org/187750 | 18:30 |
| lifeless | so - the thing was 'if everything works just switch it', but 'if it might uncover bugs etc, lets do a expand-contract pattern' | 18:31 |
| lifeless | oh, 4.7 was the alternate to 4.6. | 18:31 |
| lifeless | fungi isn't in this channel | 18:32 |
| *** greghaynes has joined #openstack-oslo | 18:32 | |
| * mordred agrees with all the things | 18:32 | |
| mordred | except the ones he disagrees with | 18:32 |
| *** fungi has joined #openstack-oslo | 18:32 | |
| fungi | whadid i miss? | 18:32 |
| zzzeek | lifeless: um what is expand-contract in this context ? | 18:33 |
| lifeless | fungi: https://etherpad.openstack.org/p/liberty-cross-project-python3 | 18:33 |
| *** david-lyle has joined #openstack-oslo | 18:33 | |
| lifeless | fungi: pm'ing scrollback | 18:33 |
| zzzeek | lifeless: the problems that we might get with pymysql are specifically that eventlet is suddenly going to work correctly and we’re going to have a lot more concurrency agains the DB within a single process | 18:33 |
| lifeless | zzzeek: yes, exactly | 18:35 |
| lifeless | zzzeek: expand-contract: add new CI jobs with pymysql, nonvoting. When they are no less reliable than the current jobs, delete the current jobs making teh new ones voting. | 18:35 |
| fungi | thanks lifeless | 18:35 |
| lifeless | fungi: so - sdague has done 4.7? | 18:35 |
| fungi | so on the devstack flag, sdague actually took that over and it's landed now. there's still a change pending to toggle the default for it to on | 18:35 |
| fungi | lemme dig up the review links | 18:36 |
| lifeless | sdague: did you do the oslo.db dep changes too ? | 18:36 |
| zzzeek | lifeless: i like that idea , is that too much work ? | 18:36 |
| fungi | so https://review.openstack.org/184489 implemented the devstack support | 18:36 |
| zzzeek | lifeless: at least for tempest type things | 18:36 |
| fungi | https://review.openstack.org/184493 will switch it on | 18:37 |
| sdague | lifeless: I didn't touch oslo.db | 18:37 |
| fungi | i've still got a wip oslo.db change i need to polish up https://review.openstack.org/184392 | 18:37 |
| fungi | along with a lot of other cleanup patches i pushed for it during the summit https://review.openstack.org/#/q/status:open+topic:pymysql-switch,n,z | 18:38 |
| lifeless | fungi: https://review.openstack.org/184392 seems to have conflicts | 18:38 |
| lifeless | fungi: ok cool - thanks | 18:38 |
| lifeless | zzzeek: its not a huge chunk of work, just assessing if its needed really | 18:39 |
| lifeless | fungi: I'm confused by https://review.openstack.org/184392 | 18:39 |
| lifeless | fungi: is it just the contrat? | 18:39 |
| lifeless | contract | 18:39 |
| jlvillal | dhellmann: Can this be closed now? https://bugs.launchpad.net/ironic/+bug/1461182 | 18:40 |
| openstack | Launchpad bug 1461182 in oslo.messaging "After oslo.messaging release Ironic gate is broken" [Undecided,In progress] - Assigned to Doug Hellmann (doug-hellmann) | 18:40 |
| fungi | lifeless: i haven't looked closely yet. that's the initial patchset which was part of a mass stream edit across a couple hundred git repos | 18:40 |
| zzzeek | lifeless: for jobs that are running the sevices for real it would be nice to ahve pymysql as non-voting unless we are willing to have things potentially klinky for a little while | 18:40 |
| zzzeek | lifeless: i mean, we shoudl be able to -> pymysql and everything just works. | 18:40 |
| zzzeek | lifeless: depends on how serious it is if jobs fail and if we might need to revert | 18:41 |
| lifeless | zzzeek: https://review.openstack.org/184392 appears to run with pymysql and the world didn't end. we could recheck it a few times to get a sense of failure rate | 18:41 |
| zzzeek | lifeless: if it were me, I’d just push it all up and if it breaks, we can fix then | 18:41 |
| zzzeek | lifeless: see? all those failures are tests I wrote in the 1st place :) | 18:43 |
| *** flaper87 has quit IRC | 18:44 | |
| zzzeek | lifeless: OK so, a job I can do is, make oslo.db pass 100% for pymysql. I’ll just do it as a whole review, hows that | 18:44 |
| lifeless | seems like a necessary thing to do too | 18:45 |
| lifeless | AIUI there are some nova tests that might be driver specific as well | 18:45 |
| lifeless | sdague: were you hacking on those? there's no owner from the session | 18:46 |
| zzzeek | fungi: OK on https://review.openstack.org/#/c/184392/ are you working through those failures or do you want me to take a crack at them | 18:46 |
| zzzeek | fungi: those are mostly my tests looking for specific strings and such | 18:46 |
| zzzeek | fungi: if you want to keep going, that woudl be fine :) | 18:46 |
| sdague | lifeless: I am not, I think fungi poked a thing. I assume the python 3 folks will trip over it and just fix it. | 18:46 |
| sdague | because the other driver doesn't work in python 3 | 18:47 |
| lifeless | ack | 18:47 |
| sdague | I just took the devstack bits because it seemed like I could get it resolved quicker than anyone else, the rest I'll leave distributed to other people doing the python3 work | 18:47 |
| lifeless | all good; just seeking clarity :) | 18:48 |
| fungi | zzzeek: i can continue to drive that change, but feel free to take it over if you want it done faster (any of you) | 18:48 |
| zzzeek | fungi: Im not ina hurry, just ask me for help b.c. those are tests I wrote anyway that are failing | 18:49 |
| fungi | i am of course already up to my eyeballs with things to work on, but wanted to make sure that someone volunteered to solve this and figured i could beat it into submission if nobody else has the desire to do so | 18:49 |
| *** jecarey has quit IRC | 18:49 | |
| fungi | zzzeek: thanks, once i fix the things i already know are issues i'll hit you up with questions | 18:50 |
| *** cdent has quit IRC | 18:50 | |
| zzzeek | fungi: I’ll look tomorrow and if its still kicking around and you’re onto other thigns ill take a crack at it | 18:50 |
| fungi | i'm always happy to hand off work. it's not like i'm particularly attached to any of it. but i'll hopefully make some progress on it today | 18:51 |
| *** rpodolyaka1 has joined #openstack-oslo | 18:52 | |
| *** mordred has quit IRC | 18:55 | |
| *** mordred has joined #openstack-oslo | 18:55 | |
| *** barra204 has joined #openstack-oslo | 18:57 | |
| openstackgerrit | Joshua Harlow proposed openstack/futurist: Remove dependency on oslo.utils (replace with small util code) https://review.openstack.org/187804 | 19:01 |
| *** barra204 has quit IRC | 19:02 | |
| openstackgerrit | Joshua Harlow proposed openstack/futurist: Remove dependency on oslo.utils (replace with small util code) https://review.openstack.org/187804 | 19:04 |
| *** shardy_ has joined #openstack-oslo | 19:06 | |
| *** shardy has quit IRC | 19:08 | |
| *** flaper87 has joined #openstack-oslo | 19:08 | |
| *** flaper87 has quit IRC | 19:09 | |
| *** flaper87 has joined #openstack-oslo | 19:09 | |
| *** cdent has joined #openstack-oslo | 19:09 | |
| *** dand has joined #openstack-oslo | 19:11 | |
| *** shardy_ has quit IRC | 19:12 | |
| *** shardy has joined #openstack-oslo | 19:12 | |
| *** e0ne has joined #openstack-oslo | 19:13 | |
| *** rpodolyaka1 has quit IRC | 19:19 | |
| dhellmann | jlvillal: we can close it for everything except oslo.messaging, where I want to create a nicer fix. I'll do that. | 19:26 |
| *** jgrimm is now known as zz_jgrimm | 19:26 | |
| directxman12 | dims__: I just created a project for oslo.reports, but during the project creation process I set the "Maintainer" as "Oslo Drivers", not realizing that I would be subsequently prevented from editing the project... Can I get transferred back to me to finish off the creation process? | 19:28 |
| dhellmann | directxman12: I can do that | 19:28 |
| directxman12 | dhellmann: thanks | 19:28 |
| * directxman12 is a bit tired today, apparently | 19:28 | |
| dhellmann | directxman12: just to make sure, your lp id is sross-7, right? | 19:29 |
| *** ozamiatin has joined #openstack-oslo | 19:29 | |
| directxman12 | dhellmann: yeah | 19:29 |
| dhellmann | directxman12: done | 19:29 |
| directxman12 | dhellmann: thanks | 19:29 |
| dims__ | directxman12: thanks! | 19:46 |
| *** crc32 has joined #openstack-oslo | 19:51 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging: replace rpc_response_timeout use in rabbit driver https://review.openstack.org/188163 | 19:57 |
| dhellmann | sileht: ^^ | 19:57 |
| *** flaper87 has quit IRC | 19:57 | |
| *** barra204 has joined #openstack-oslo | 19:58 | |
| *** flaper87 has joined #openstack-oslo | 19:59 | |
| *** ozamiatin has quit IRC | 19:59 | |
| *** barra204 has quit IRC | 20:03 | |
| dims__ | sileht: https://github.com/celery/py-amqp/pull/64 merged! | 20:03 |
| *** flaper87 has quit IRC | 20:03 | |
| harlowja | woot | 20:03 |
| harlowja | +10 for contributing to other communities/code-bases | 20:04 |
| dims__ | harlowja: this one was just cheer-leading :) | 20:04 |
| harlowja | +10 for cheer-leading | 20:05 |
| harlowja | lol | 20:05 |
| dims__ | :) | 20:05 |
| *** mtanino has quit IRC | 20:06 | |
| *** jecarey has joined #openstack-oslo | 20:06 | |
| *** amrith is now known as _amrith_ | 20:06 | |
| *** salv-orlando has quit IRC | 20:09 | |
| *** salv-orlando has joined #openstack-oslo | 20:09 | |
| *** e0ne is now known as e0ne_ | 20:09 | |
| *** e0ne_ is now known as e0ne | 20:14 | |
| *** e0ne has quit IRC | 20:14 | |
| *** flaper87 has joined #openstack-oslo | 20:16 | |
| *** alexpilotti has quit IRC | 20:17 | |
| stevemar | dhellmann, around-ish? | 20:18 |
| dhellmann | stevemar: ish | 20:18 |
| stevemar | dhellmann, i was trying to add heat-translator to global reqs, and apparently i dun broke everything, because it uses python-dateutil (which is not in GR) https://github.com/openstack/heat-translator/blob/master/requirements.txt#L4 | 20:19 |
| dhellmann | yeah, I was just chatting with AJaeger about that in -infra | 20:19 |
| stevemar | dhellmann, do you think it's worth trying to get python-dateutil into GR? or do you think oslo.utils time/date utils can cover it? | 20:20 |
| stevemar | apparently this is the only instance of it: https://github.com/openstack/heat-translator/blob/e5cddd4de6e1639ca779f5f5183de15265171872/translator/toscalib/elements/constraints.py#L252 | 20:20 |
| * dhellmann goes to see wha python-dateutil is | 20:20 | |
| stevemar | dhellmann, https://labix.org/python-dateutil#head-c0e81a473b647dfa787dc11e8c69557ec2c3ecd2 | 20:21 |
| dims__ | stevemar: simple enough to use oslo.utils i feel | 20:21 |
| stevemar | dims__, yeah, just trying to find the analogous in oslo.utils | 20:22 |
| dims__ | we have enough trouble with date/time already :) | 20:22 |
| dims__ | stevemar: parse_isotime/parse_strtime | 20:22 |
| dims__ | stevemar: both should throw exceptions if the string is not valid | 20:23 |
| dhellmann | stevemar: yeah, we have some parsing functions in http://git.openstack.org/cgit/openstack/oslo.utils/tree/oslo_utils/timeutils.py but they rely on the format being standardized | 20:23 |
| dhellmann | IIRC, dateutil figures out the format for you? | 20:23 |
| dims__ | dhellmann: stevemar: looks like you may have to consult the tosca schema for what's valid and what's not | 20:24 |
| dims__ | if it matches one of stuff we already have in oslo.utils...then we are good | 20:24 |
| dhellmann | dims__, jd__ : I wonder if this lib would help in our migration away from those date functions in oslo.utils | 20:25 |
| stevemar | blah, 1300 lines for parsing https://github.com/dateutil/dateutil/blob/master/dateutil/parser.py | 20:27 |
| dhellmann | stevemar: what do the timestamps being parsed in heat-translator look like? | 20:29 |
| stevemar | dhellmann, trying to find out, but i think it'll have to wait til tomorrow (i'm heading off and the heat-translator folks are not online it seems) | 20:30 |
| dhellmann | stevemar: maybe in the mean time submit a patch to remove heat-translator from projects.txt, and we can get all ducks in a row before going ahead again? | 20:31 |
| stevemar | dhellmann, seems like it | 20:32 |
| stevemar | i doubt yall want to add python-dateutils | 20:32 |
| stevemar | or whatever it is | 20:33 |
| dhellmann | stevemar: that package has a good history, so I wouldn't rule it out, but let's figure out the right solution in a Not Broken state | 20:33 |
| stevemar | dhellmann, thanks sir - reverting it here https://review.openstack.org/#/c/188174/ | 20:34 |
| stevemar | while i have your attention... https://review.openstack.org/#/c/188078/ | 20:34 |
| * stevemar is an opportunist | 20:34 | |
| dhellmann | stevemar: is there a feature in that version of keystone client that osc needs, or is it just a bug fix? | 20:36 |
| dhellmann | stevemar: IOW, is there some API missing from the earlier version that keystone client needs? | 20:36 |
| *** jamespage_ has joined #openstack-oslo | 20:38 | |
| stevemar | dhellmann, y, it's a feature that osc needs if we want to release again | 20:40 |
| dhellmann | stevemar: ok, because the commit message there makes it sound like a bug fix, and we don't usually bump just for bug fixes | 20:41 |
| stevemar | dhellmann, nah, just bad wording on my part | 20:41 |
| dhellmann | stevemar: ok, want to update that and then I'll +2? | 20:41 |
| stevemar | dhellmann, kk | 20:42 |
| *** jamespage_ has quit IRC | 20:42 | |
| dhellmann | dims__, jd__ : it would be nice if we could provide some sort of compatibility shim for projects moving away from this deprecated function instead of having everyone copy it back into their source tree :-( | 20:43 |
| dhellmann | dims__, jd__ : https://review.openstack.org/#/c/187751/ | 20:43 |
| stevemar | new wording ftw! | 20:43 |
| dims__ | dhellmann: ++ | 20:44 |
| openstackgerrit | Merged openstack/oslo-incubator: Guru Meditation Reports broken without version_string https://review.openstack.org/184199 | 20:44 |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/188114 | 20:49 |
| *** stevemar has quit IRC | 20:51 | |
| openstackgerrit | Merged openstack/tooz: Updated from global requirements https://review.openstack.org/188103 | 20:56 |
| *** gordc has quit IRC | 20:58 | |
| *** sabari has quit IRC | 21:03 | |
| *** tsekiyama has quit IRC | 21:05 | |
| *** cdent has quit IRC | 21:06 | |
| openstackgerrit | Merged openstack/futurist: Updated from global requirements https://review.openstack.org/187951 | 21:07 |
| mriedem | is the log notifier in oslo.messaging for sending a notification for every log record sent, or for logging every notification sent? | 21:14 |
| mriedem | someone was asking me if it's possible to log notification events from nova and i wasn't sure looking at the o.m docs | 21:14 |
| dhellmann | mriedem: it looks like it sends notifications for log messages | 21:15 |
| mriedem | yeah that's how i read it | 21:15 |
| *** sabari has joined #openstack-oslo | 21:18 | |
| *** alexpilotti has joined #openstack-oslo | 21:46 | |
| krotscheck | dhellmann: With all the CORS discussion happening on the spec, I'm starting to think that everyone's making the implicit assumption that it will support paste deploy | 21:55 |
| krotscheck | Which... It doesn't. | 21:55 |
| krotscheck | Is it worth going back and changing the middleware to do that? | 21:56 |
| *** mriedem has quit IRC | 21:57 | |
| *** tsekiyama has joined #openstack-oslo | 22:04 | |
| *** crc32 has quit IRC | 22:05 | |
| *** tsekiyama has quit IRC | 22:09 | |
| bknudson | krotscheck: why doesn't it support paste deploy? | 22:11 |
| krotscheck | bknudson: It takes an oslo_config isntance as a constructor argument. I've been told that pastedeploy doesn't really do taht. | 22:11 |
| * krotscheck doesn't know pastedeploy well enough to know if that's true or not. | 22:12 | |
| bknudson | I don't know of a way to pass oslo.config instance to the constructor in paste pipeline either | 22:12 |
| bknudson | auth_token middleware uses the global CONF object | 22:13 |
| bknudson | although there's a proposed change to make it work without the global CONF object... | 22:13 |
| harlowja | globals make me sad, ha | 22:14 |
| bknudson | https://review.openstack.org/#/c/143063/ | 22:14 |
| bknudson | hmm... that seems incomplete. | 22:15 |
| harlowja | ya, maybe missing some code that wasn't `git add'(ed) | 22:15 |
| bknudson | the paste middleware gets passed a config object, it's not oslo_config though | 22:16 |
| bknudson | so you could require the config provide the middleware the name of the conf to use | 22:16 |
| bknudson | or you could have some other middleware configure a config that the other middleware gets from the conf. | 22:17 |
| bknudson | we do that in auth_token... I'll see if I can find it. | 22:17 |
| bknudson | http://git.openstack.org/cgit/openstack/keystonemiddleware/tree/keystonemiddleware/auth_token/__init__.py#n260 | 22:18 |
| bknudson | then it does env.get -- http://git.openstack.org/cgit/openstack/keystonemiddleware/tree/keystonemiddleware/auth_token/_cache.py#n139 | 22:19 |
| harlowja | man, i also wonder if http://git.openstack.org/cgit/openstack/keystonemiddleware/tree/keystonemiddleware/auth_token/__init__.py#n237 should just be function arguments with docstrings (where the docstring is the help message); then people can just refer to docs generated via sphinx | 22:20 |
| harlowja | *always wonder if | 22:20 |
| *** jamielennox|away is now known as jamielennox | 22:20 | |
| bknudson | all those config options wind up in all the server's config files. | 22:21 |
| harlowja | ya, i know | 22:21 |
| harlowja | for better or worse imho | 22:21 |
| harlowja | ACTION just imagines that they could be arguments to functions, then these are nice reusable libraries that have nice docstrings with nice sphinx docs, and then something, if it so desires could extract the sphinx docstring from say __doc__ and make a config file out of it, orrrrr someone could just use the regular functions with arguments (as normally u would) maybe even taking advantage of https://www.python.org/dev/peps/pep-0484/ | 22:25 |
| * harlowja listopts and such... | 22:25 | |
| harlowja | one can dream, ha | 22:26 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:30 | |
| *** bknudson has quit IRC | 22:31 | |
| *** mriedem has joined #openstack-oslo | 22:34 | |
| *** mriedem has quit IRC | 22:37 | |
| *** mriedem has joined #openstack-oslo | 22:38 | |
| *** vilobhmm has quit IRC | 22:41 | |
| *** vilobhmm has joined #openstack-oslo | 22:41 | |
| *** vilobhmm1 has joined #openstack-oslo | 22:44 | |
| *** vilobhmm has quit IRC | 22:46 | |
| *** barra204 has joined #openstack-oslo | 22:48 | |
| *** dand has quit IRC | 22:49 | |
| *** barra204 has quit IRC | 22:53 | |
| *** jecarey has quit IRC | 23:06 | |
| dhellmann | krotscheck: I agree we should make it work with paste somehow, and it sounds like bknudson's example is a reasonable precedent. | 23:07 |
| krotscheck | dhellmann: I dunno, one of those feels a little too much like "So I heard you like middleware, so I put a middeware in your middleware so you can parse while you parse" | 23:10 |
| harlowja | ^ brain exploded | 23:13 |
| *** tsekiyama has joined #openstack-oslo | 23:25 | |
| *** sputnik13 has quit IRC | 23:27 | |
| *** sputnik13 has joined #openstack-oslo | 23:28 | |
| *** sputnik13 has quit IRC | 23:31 | |
| *** sputnik13 has joined #openstack-oslo | 23:33 | |
| *** sdake has quit IRC | 23:35 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Cache the individual atom schedulers at compile time https://review.openstack.org/187828 | 23:42 |
| *** dims_ has joined #openstack-oslo | 23:51 | |
| *** dims__ has quit IRC | 23:55 | |
| *** sputnik13 has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!