Tuesday, 2015-07-07

*** sdake_ has joined #openstack-oslo00:00
*** dims has joined #openstack-oslo00:01
*** sdake has quit IRC00:02
*** _amrith_ is now known as amrith00:07
*** sdake has joined #openstack-oslo00:09
*** sdake_ has quit IRC00:13
openstackgerritKevin Benton proposed openstack/oslo.messaging: Verify that version in 'prepare' is valid  https://review.openstack.org/19386700:18
*** sputnik13 has quit IRC00:22
*** manishg has quit IRC00:23
openstackgerritJoshua Harlow proposed openstack/oslo.service: Make the loopingcall code less dependent on eventlet  https://review.openstack.org/19447900:24
*** tsekiyama has quit IRC00:26
*** kgiusti has left #openstack-oslo00:32
*** zzzeek has quit IRC00:35
dimsharlowja: ping00:40
harlowjapong00:40
dimsharlowja: free for dinner tomorrow?00:40
harlowjahmmmm, usually do indoor rock climbing tommorow, how about wed?00:40
dimsharlowja: wed sounds good, but will confirm on wed morning00:41
harlowjaok dokie00:41
dimscool thanks00:42
harlowjanp00:42
*** dims has quit IRC00:50
*** dims has joined #openstack-oslo00:58
*** amotoki has joined #openstack-oslo01:02
openstackgerritJoshua Harlow proposed openstack/futurist: Add future waiting helper module  https://review.openstack.org/19626901:02
*** zz_dimtruck is now known as dimtruck01:03
openstackgerritJoshua Harlow proposed openstack/taskflow: Remove deprecated things now that we are in 1.x releases  https://review.openstack.org/19891401:06
openstackgerritJoshua Harlow proposed openstack/oslo.utils: Use monotonic library to avoid finding monotonic time function  https://review.openstack.org/19037701:12
*** achanda has joined #openstack-oslo01:13
*** mtanino has quit IRC01:22
openstackgerritJoshua Harlow proposed openstack/taskflow: Remove deprecated things now that we are in 1.x releases  https://review.openstack.org/19891401:26
openstackgerritJoshua Harlow proposed openstack/futurist: Add future waiting helper module  https://review.openstack.org/19626901:36
*** stevemar has joined #openstack-oslo01:41
lifelessharlowja: so we can't land those02:03
lifelessharlowja: can we? without creating 2.0 as the next release02:03
*** yamahata has quit IRC02:10
*** arnaud____ has joined #openstack-oslo02:13
*** rjaiswal has quit IRC02:14
*** arnaud____ has quit IRC02:21
openstackgerritChangBo Guo(gcb) proposed openstack/oslo.utils: versionutils: add version convert helper methods  https://review.openstack.org/19850002:34
*** stevemar has quit IRC02:54
*** stevemar has joined #openstack-oslo02:54
*** arnaud____ has joined #openstack-oslo02:57
harlowjalifeless sure, 2.0 as next release, doesn't matter to me :-P03:06
harlowja2.0 is the new 1.0 from what i hear anyway ;-P03:06
openstackgerritJoshua Harlow proposed openstack/taskflow: Remove deprecated things now that we are in 1.x releases  https://review.openstack.org/19891403:07
lifelessharlowja: well its more that we can't do a point release of 103:14
lifelessharlowja: because if there are API breaks in it03:14
harlowjai know03:14
lifelessk03:14
harlowjabut ya, sorta sucks, ha03:14
harlowjaoh well03:14
openstackgerritJoshua Harlow proposed openstack/futurist: Add future waiting helper module  https://review.openstack.org/19626903:23
harlowjadhellmann though wanted a 1.0 :-P so that happened, ha03:25
*** dims has quit IRC03:39
*** arnaud____ has quit IRC03:54
*** arnaud__ has joined #openstack-oslo04:14
*** manishg has joined #openstack-oslo04:14
openstackgerritMerged openstack/oslo.service: Remove usage of mox in test_eventlet_backdoor  https://review.openstack.org/19799104:36
*** dims has joined #openstack-oslo04:40
*** dims_ has joined #openstack-oslo04:41
openstackgerritMerged openstack/oslo.service: Add mock to test_requirements  https://review.openstack.org/19871004:43
*** dims has quit IRC04:45
*** dims_ has quit IRC04:46
tchaypolifeless: change 18432804:59
*** manishg has quit IRC04:59
tchaypothe commit message says “this is a bit of an example”, which suggests to me that this is not an actual intended-to-be-landed commit but just something to point people at for their edification05:00
tchaypois that the case?05:00
*** sputnik13 has joined #openstack-oslo05:12
*** exploreshaifali has joined #openstack-oslo05:17
*** rpodolyaka1 has joined #openstack-oslo05:17
*** e0ne has joined #openstack-oslo05:22
*** achanda has quit IRC05:23
*** nkrinner has joined #openstack-oslo05:24
*** exploreshaifali has quit IRC05:28
*** rpodolyaka1 has quit IRC05:43
*** rpodolyaka1 has joined #openstack-oslo05:43
*** e0ne has quit IRC05:44
*** sputnik13 has quit IRC05:48
*** yamahata has joined #openstack-oslo05:50
*** ig0r_ has joined #openstack-oslo05:51
*** ig0r__ has quit IRC05:55
*** rpodolyaka1 has quit IRC05:59
*** arnaud__ has quit IRC06:01
lifelesstchaypo: sorry which one is that ?06:05
tchaypo“refactor deps to use extras and env markers"06:15
tchaypoif it’s meant to land, it looks ready to land; if it’s just an example I won’t give it a +106:15
lifelesstchaypo: oslo.db ?06:18
lifelesstchaypo: its an exemplar, not an example06:18
lifelessfeel free to +1 it06:18
openstackgerritEric Brown proposed openstack/oslo.config: Expose min and max to IntOpt  https://review.openstack.org/19695506:27
openstackgerritMerged openstack-dev/pbr: This documents the use of comments that work between 2.6, 2.7 and 3.4  https://review.openstack.org/19392706:31
*** dimtruck is now known as zz_dimtruck06:34
openstackgerritFlavio Percoco proposed openstack/oslo.messaging: Make heartbeat the default  https://review.openstack.org/19898606:53
*** e0ne has joined #openstack-oslo06:57
*** rpodolyaka1 has joined #openstack-oslo06:57
*** stevemar has quit IRC06:59
*** stevemar has joined #openstack-oslo07:00
*** e0ne has quit IRC07:04
*** stevemar has quit IRC07:11
openstackgerritEric Brown proposed openstack/oslo.config: Expose min and max to IntOpt  https://review.openstack.org/19695507:12
*** rpodolyaka1 has quit IRC07:20
*** rpodolyaka1 has joined #openstack-oslo07:23
*** rpodolyaka1 has quit IRC07:30
*** cdent has joined #openstack-oslo07:33
*** browne has quit IRC07:33
*** e0ne has joined #openstack-oslo07:36
*** rpodolyaka1 has joined #openstack-oslo07:37
*** rpodolyaka1 has quit IRC07:41
*** dims has joined #openstack-oslo07:43
*** dims has quit IRC07:48
*** jaosorior has joined #openstack-oslo07:55
*** e0ne is now known as e0ne_08:01
*** exploreshaifali has joined #openstack-oslo08:02
*** e0ne_ is now known as e0ne08:03
*** stevemar has joined #openstack-oslo08:12
*** haypo has joined #openstack-oslo08:12
*** stevemar has quit IRC08:16
*** shardy has joined #openstack-oslo08:17
*** pblaho has joined #openstack-oslo08:30
*** rpodolyaka1 has joined #openstack-oslo08:33
*** yassine_ has joined #openstack-oslo08:40
*** shardy_ has joined #openstack-oslo09:00
*** shardy has quit IRC09:02
*** ozamiatin has joined #openstack-oslo09:03
*** shardy_ has quit IRC09:05
*** shardy has joined #openstack-oslo09:06
*** rpodolyaka1 has quit IRC09:07
*** rpodolyaka1 has joined #openstack-oslo09:08
*** e0ne is now known as e0ne_09:11
*** boris-42 has quit IRC09:22
*** e0ne_ is now known as e0ne09:24
*** rpodolyaka1 has quit IRC09:34
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.concurrency: Updated from global requirements  https://review.openstack.org/19902209:37
*** dims has joined #openstack-oslo09:44
*** dims_ has joined #openstack-oslo09:45
*** dims__ has joined #openstack-oslo09:46
*** rpodolyaka1 has joined #openstack-oslo09:47
*** rpodolyaka1 has quit IRC09:47
*** dims has quit IRC09:48
*** dims_ has quit IRC09:50
*** dims__ has quit IRC09:50
*** shardy_ has joined #openstack-oslo10:06
*** e0ne is now known as e0ne_10:07
*** shardy has quit IRC10:08
*** shardy_ has quit IRC10:12
*** shardy has joined #openstack-oslo10:13
*** e0ne_ is now known as e0ne10:21
*** viktors|afk is now known as viktors10:30
*** exploreshaifali has quit IRC10:32
*** ericksonsantos has joined #openstack-oslo10:40
*** dims has joined #openstack-oslo10:46
*** katyafervent_ is now known as katyafervent_awa10:48
*** ozamiatin has quit IRC10:49
*** rpodolyaka1 has joined #openstack-oslo10:50
*** katyafervent_awa is now known as katyafervent10:51
*** dims has quit IRC10:51
*** ihrachyshka has joined #openstack-oslo10:55
*** exploreshaifali has joined #openstack-oslo11:09
*** arnaud__ has joined #openstack-oslo11:15
*** e0ne is now known as e0ne_11:25
openstackgerritSean Dague proposed openstack-dev/pbr: Add wsgi_scripts support to PBR  https://review.openstack.org/19529211:35
*** e0ne_ is now known as e0ne11:45
*** prad has joined #openstack-oslo11:45
*** stevemar has joined #openstack-oslo11:50
*** rpodolyaka1 has quit IRC11:54
*** stevemar has quit IRC11:54
*** rpodolyaka1 has joined #openstack-oslo11:57
*** rpodolyaka1 has quit IRC12:00
*** dims has joined #openstack-oslo12:02
*** jaypipes has joined #openstack-oslo12:02
*** gordc has joined #openstack-oslo12:02
*** bknudson has quit IRC12:03
*** arnaud___ has joined #openstack-oslo12:04
*** amrith is now known as _amrith_12:04
*** rpodolyaka1 has joined #openstack-oslo12:06
*** arnaud__ has quit IRC12:07
*** dims has quit IRC12:07
*** ganso_ has joined #openstack-oslo12:14
*** ozamiatin has joined #openstack-oslo12:15
*** browne has joined #openstack-oslo12:18
*** arnaud___ has quit IRC12:23
*** rpodolyaka1 has quit IRC12:24
*** bknudson has joined #openstack-oslo12:27
*** kgiusti has joined #openstack-oslo12:28
*** rpodolyaka1 has joined #openstack-oslo12:33
openstackgerritSergey Nikitin proposed openstack/oslo.cache: Implemented DictCacheBackend  https://review.openstack.org/19826512:50
haypohey. i need some pbr skill to debug the error: pkg_resources.VersionConflict: (pbr 1.2.0 (/home/haypo/prog/openstack/swift/.tox/pep8/lib/python2.7/site-packages), Requirement.parse('pbr<1.0,>=0.5.21'))12:52
haypoi would like to write dnspython>=1.9.4; python_version < '3.0' in Swift requirements12:53
hayposo i added pbr<2.0,>=0.11 to requirements.txt, but it looks like _something_ requires pbr < 1.012:53
haypomy patch: https://review.openstack.org/#/c/199034/12:53
haypooh, it's hacking. swift uses an old version of hacking which requires pbr < 1.013:04
*** browne has quit IRC13:10
*** _amrith_ is now known as amrith13:11
*** manishg has joined #openstack-oslo13:14
*** manishg has quit IRC13:15
*** exploreshaifali has quit IRC13:15
*** manishg has joined #openstack-oslo13:16
*** dims has joined #openstack-oslo13:19
openstackgerritFlavio Percoco proposed openstack/oslo.messaging: Make heartbeat the default  https://review.openstack.org/19898613:24
*** claudiub has joined #openstack-oslo13:25
claudiubhello. I would require some information. What are the necessary steps to propose a new oslo library, besides the spec? (oslo_hyperv)13:26
*** mriedem_away is now known as mriedem13:27
*** browne has joined #openstack-oslo13:30
ttxdims: do you still plan to do an oslo.concurrency kilo release to unblock the stablke/kilo requirements conflict ?13:30
dimsttx: yes, i will take care of it today13:31
ttxdims: cool, thx13:31
*** mtanino has joined #openstack-oslo13:31
dimsttx was waiting for one more bug to land in master (and then backport), but its taking too long, so i'll just cut one to unblock the neutron jobs13:32
*** amotoki has quit IRC13:33
dimsjd__: flaper87: sileht: can you please bless https://review.openstack.org/#/c/195249/ (and backport - https://review.openstack.org/#/c/198511/)13:33
dhellmanngood morning13:33
*** boris-42 has joined #openstack-oslo13:33
dhellmanndims, harlowja : I missed the discussion of the taskflow versioning. I think lifeless is right that we should, overall, be more careful of API breaks.13:36
haypodims: i added a comment for windows :)13:36
*** e0ne is now known as e0ne_13:37
dimsdhellmann: Hi, yes, agree.13:37
dimshaypo: where?13:37
*** jecarey has joined #openstack-oslo13:38
*** stevemar has joined #openstack-oslo13:39
*** e0ne_ is now known as e0ne13:39
haypodims: https://review.openstack.org/#/c/195249/9/oslo_concurrency/processutils.py13:40
dimsgood point13:41
haypodims: subprocess raises a ValueError, https://hg.python.org/cpython/file/2f86a69c3220/Lib/subprocess.py#l86013:41
*** ccrouch has joined #openstack-oslo13:42
*** stevemar has quit IRC13:42
openstackgerritAlexander Tivelkov proposed openstack/oslo.versionedobjects: Adds value validation to the fields  https://review.openstack.org/19604113:42
*** manishg has quit IRC13:44
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute  https://review.openstack.org/19524913:44
*** ccrouch has left #openstack-oslo13:45
haypodims: what do you think of starting to use .. versionchanged:: 1.10  New parameter preexec_fn13:46
haypodims: for the doc13:46
*** rpodolyaka1 has quit IRC13:46
haypodims: it's annoying to have to dig git history to find when a new option was added13:46
haypo(1.10 is a random version, i don't know the current version of oslo.concurrency)13:46
haypodims: example, https://docs.python.org/dev/library/subprocess.html#subprocess.TimeoutExpired13:46
haypodims: my question is not specific to this change ;)13:47
hayporecently, i had to dig oslo.concurrency history to check when i added the binary option :-p13:47
dimslooks like there's a versionadded as well13:48
dimshaypo: +1 to come up with a small list of useful doc comments and tell everyone to start using it. i can't seem to find any projects using either of them13:49
haypodims: these tags are common and mandatory in python doc13:50
* dims dropping off to wake up and have coffee back in a bit13:50
dimshaypo: yes, i just can't see these 2 tags used in any of our openstack projects13:50
dimsback in a bit13:50
*** rpodolyaka1 has joined #openstack-oslo13:52
*** claudiub has quit IRC13:52
*** manishg has joined #openstack-oslo13:52
*** manishg has quit IRC13:52
*** manishg has joined #openstack-oslo13:53
haypodims: i propose to start using them to provide better documentations13:55
dhellmannhaypo: I like the idea. Maybe we should start a doc with hints/tips/suggestions for documenting oslo libs?13:55
dhellmannWe could put it in the policy section of our specs repo, with the other team-guide stuff13:55
haypodhellmann: well, it's already documented in sphinx doc: http://sphinx-doc.org/markup/para.html?highlight=versionadde#paragraph-level-markup13:56
haypowe can start to warn users in reviews13:56
*** sigmavirus24_awa is now known as sigmavirus2413:57
haypoi know that i will take time until all dev will take the habit of adding directly these tags to the doc13:57
dhellmannhaypo: I mean that we should suggest how/why to use it, as a guideline. That way we can point to our local doc in reviews when we ask for someone to add the tag13:58
*** zz_dimtruck is now known as dimtruck13:59
*** rpodolyaka3 has joined #openstack-oslo14:01
*** rpodolyaka1 has quit IRC14:01
*** ccrouch has joined #openstack-oslo14:02
haypodhellmann: what is our local doc?14:02
*** manishg has quit IRC14:02
*** Kennan2 has joined #openstack-oslo14:03
*** Kennan has quit IRC14:03
*** rpodolyaka3 has quit IRC14:04
*** rpodolyaka1 has joined #openstack-oslo14:05
*** dimtruck is now known as zz_dimtruck14:06
*** geguileo has quit IRC14:09
dhellmannhaypo: sorry, that was a poor choice of words on my part. I meant something we manage, instead of the sphinx documentation.14:12
haypodhellmann: hum, yes maybe. but i'm not interested to write such doc. only to harass developers on reviews until they document their API changes :)14:13
haypomaybe it will slow down API breaks :-S14:14
haypochanges*14:14
*** sdake has quit IRC14:14
dhellmannhaypo: consider it a way to avoid having to say the same thing on reviews over and over :-)14:14
*** sdake has joined #openstack-oslo14:15
haypodhellmann: i see14:15
openstackgerritAlexander Tivelkov proposed openstack/oslo.versionedobjects: Adds value validation to the fields  https://review.openstack.org/19604114:20
haypopbr, pip and requirements issues make me nervous. gate-tempest-dsvm-neutron-src-oslo.utils is still failing on "... upper-constraints.txt -- keystone ..." on my oslo.utils patch. https://review.openstack.org/#/c/198026/14:21
haypoit fails with: pkg_resources.RequirementParseError: Missing distribution spec /opt/stack/new/oslo.utils14:21
haypois someone aware of this issue?14:21
dhellmannhaypo: I think lifeless had a fix in the queue for that? dims, do you know?14:22
dhellmannhaypo: either way, yes, it's a known issue with the new requirements tools14:22
haypoyet another requirement nightmare :-p14:25
haypodhellmann: i lost 2 hours trying to upgrade pbr to >= 1.0 in swift, but it looks impossible because swift uses an old version of hacking which requires pbr<10.14:25
haypopbr<1.014:25
haypoand upgrading hacking looks complex. flake8 finds new issues, and it doesn't look to possible to ignore them14:26
dhellmannthat's unfortunate14:26
haypopep8 is stupid. you cannot select "E" but ignore "E121"!?14:26
dhellmannmaybe we should remove the pbr cap in the old hacking; I'm not sure why that's there14:26
haypo(flake8 is based on pep8, and upgrading hacking upgrades flake8, pep8, etc.)14:26
haypodhellmann: maybe we should stop using pbr. i hate pbr :)14:27
haypo(sorry, useless comment, but as i wrote, these tools make me nervous)14:29
haypodhellmann: i'm unable to find a fix from lifeless for my requirement issue14:30
openstackgerritKevin Benton proposed openstack/oslo.messaging: Verify that version in 'prepare' is valid  https://review.openstack.org/19386714:34
openstackgerritMerged openstack/oslo.concurrency: Updated from global requirements  https://review.openstack.org/19902214:40
dhellmannhaypo: I think it was in devstack-gate? or possibly in the requirements repo? iirc, it had something to do with the way requirements were being synced. Let me find it...14:54
*** ozamiatin has quit IRC14:56
dhellmannhaypo: see the depends-on at the bottom of the commit message for https://review.openstack.org/#/c/181961/14:56
dhellmannhaypo: both have merged14:56
*** achanda has joined #openstack-oslo14:56
ttxdims, dhellmann: I erceived various complaints from openstack-announce subscribers about the volume of oslo release announcements15:01
ttxnot sure it's fixable though, unless somehow we digest them into a single "oslo release day" email15:01
openstackgerritElena Ezhova proposed openstack/oslo.service: Move backdoor-related tests from test_service  https://review.openstack.org/19914115:02
ttxbut then arguably THEY should enable digest mode15:02
*** zzzeek has joined #openstack-oslo15:02
*** achanda has quit IRC15:02
*** rpodolyaka1 has quit IRC15:02
*** rpodolyaka1 has joined #openstack-oslo15:04
*** zz_dimtruck is now known as dimtruck15:06
dhellmannttx: yeah, I think at some point we need to just start expecting people to learn to manage their email15:09
dhellmannttx: because if we batch up the notices, then we'll get complaints from folks who are watching for particular libraries that it's harder to spot the releases15:09
dimsttx: i'll take any advice, we'll end up with folks unhappy either way15:09
dimsdhellmann: haypo: that requirements failure should have been fixed already, please run recheck15:10
haypodims: yes, i just scheduled a recheck on my patch https://review.openstack.org/#/c/198026/15:11
dimshaypo: need specific tags which we can tell people to use then make them mandatory in reviews15:11
haypowell, i'm no more convinced myself that my patch is required :)15:11
* dims dropping off again. sorry guys travelling this week, so will be off and on15:11
haypodims looks my wifi connection today!15:12
dimshaha15:12
dimshaypo: can you add a wiki or etherpad page with some suggested tags? we can take it to the team on monday?15:13
haypodims: versionadded & versionchanged are enough, no?15:15
dimshaypo: there's a deprecated (http://sphinx-doc.org/markup/para.html)15:16
*** e0ne is now known as e0ne_15:16
dimsdhellmann may know a few others that may be useful15:16
dimsback in a bit15:16
*** dims has quit IRC15:16
haypodims: hum, deprecated is already used no?15:16
*** manishg has joined #openstack-oslo15:17
haypoexample of usage: http://docs.openstack.org/developer/oslo.utils/api/timeutils.html#oslo_utils.timeutils.isotime15:17
haypoor maybe only jd__ uses it :)15:17
*** rpodolyaka1 has quit IRC15:18
haypoi'm writing an email to openstack-dev for versionchanged & cie15:18
*** tsekiyama has joined #openstack-oslo15:20
dhellmannhaypo: sounds good -- we could provide some short guidelines for when/how to use all of those directives15:21
*** stevemar has joined #openstack-oslo15:22
haypodhellmann: email sent. it's a first step ;)15:22
dhellmannhaypo: ++15:23
*** nkrinner is now known as nkrinner_afk15:23
*** e0ne_ is now known as e0ne15:26
*** cdent has quit IRC15:28
*** rpodolyaka1 has joined #openstack-oslo15:30
*** davidlenwell has quit IRC15:38
openstackgerritAlexander Tivelkov proposed openstack/oslo.versionedobjects: Compound Field validation (WiP)  https://review.openstack.org/19681915:38
*** shardy_ has joined #openstack-oslo15:40
*** shardy has quit IRC15:41
*** dims has joined #openstack-oslo15:43
*** shardy_ has quit IRC15:45
*** rpodolyaka1 has quit IRC15:45
*** shardy has joined #openstack-oslo15:46
*** sdake_ has joined #openstack-oslo15:48
*** sdake has quit IRC15:48
dimsbnemec: both me and haypo replied on https://review.openstack.org/#/c/195249/ - if we can get that in then i can do the backport and release a version needed to work with nova stable/kilo (security fixes)15:48
*** davidlenwell has joined #openstack-oslo15:53
*** davidlenwell is now known as daviddavid15:54
*** daviddavid is now known as davidlenwell15:54
*** rpodolyaka1 has joined #openstack-oslo15:57
*** davidlenwell has quit IRC15:58
*** davidlenwell has joined #openstack-oslo15:58
*** salv-orlando has joined #openstack-oslo15:58
*** mgarza_ has joined #openstack-oslo16:00
*** davidlenwell has quit IRC16:08
*** ashleighfarnham has joined #openstack-oslo16:08
*** davidlenwell has joined #openstack-oslo16:08
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute  https://review.openstack.org/19524916:08
*** ashleighfarnham has quit IRC16:08
*** ashleighfarnham has joined #openstack-oslo16:09
*** davidlenwell is now known as omnibus716:12
*** omnibus7 is now known as davidlenwell16:12
*** davidlenwell is now known as david_enwell16:12
*** kgiusti has left #openstack-oslo16:13
*** david_enwell is now known as davidlenwell16:19
*** davidlenwell has quit IRC16:20
*** davidlenwell has joined #openstack-oslo16:20
*** hogepodge has quit IRC16:21
*** davidlenwell has quit IRC16:23
*** davidlenwell has joined #openstack-oslo16:24
*** amrith is now known as _amrith_16:26
*** davidlenwell has quit IRC16:27
*** davidlenwell has joined #openstack-oslo16:28
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute  https://review.openstack.org/19524916:29
haypodims: hey, you sent too many versions of your patch per hours :-p16:30
dimshaypo: there was a extra space16:30
dimsreally want to get oslo.concurrency stable/kilo out today :)16:31
*** davidlenwell has quit IRC16:31
haypodims: you want to add this new parameter to a stable version?16:31
dimsyes16:31
haypodims: i can approve the patch without a second +2 if you want16:31
dimsnova needs it for a security fix16:31
dimsthanx, let's wait for master one to merge first16:32
*** e0ne has quit IRC16:33
haypodims: i mean approving https://review.openstack.org/19524916:34
*** exploreshaifali has joined #openstack-oslo16:35
*** sdake_ is now known as sdae16:35
*** davidlenwell has joined #openstack-oslo16:35
*** davidlenwell is now known as davidlenwell_16:36
dimshaypo: let's get another opinion. dhellmann do you have a few mins for https://review.openstack.org/#/c/195249/?16:37
*** davidlenwell_ is now known as davidlenwell16:38
*** haypo has quit IRC16:39
*** sdae is now known as sdake16:39
*** haypo has joined #openstack-oslo16:40
haypodims: i have to go, bye16:41
dimsbye haypo16:41
*** haypo has left #openstack-oslo16:41
dhellmanndims: looking16:52
dhellmanndims: the commit message is slightly out of date, now that you're calling both the built-in and the provided function16:53
dhellmanndims: I can fix that in gerrit and +2a since haypo already gave a +2 on the code16:53
dimsthanks dhellmann16:54
dhellmanndims: well, what about bnemec's point about that exception?16:54
dimsdhellmann: subprocess does the same (raises ValueError) so am ok with the code as-is16:55
dhellmanndims: if subprocess is going to raise the exception for us, why not let it?16:55
dimsdhellmann: works for me16:56
dimslet me rev16:56
bnemecMy thing is that this a convenience function, and it's not terribly convenient to push logic off on the caller when we can do the right thing easily.16:58
bnemecEspecially because this won't get caught in testing because we don't test on Windows.16:59
dimsbnemec: what's the right thing? (not sure i get it)16:59
bnemecdims: To not pass preexec_fn to Popen.17:00
bnemecI mean, isn't the calling code basically going to look like:17:00
dimsand fail silently?17:00
bnemecfn = some_func17:01
bnemecif os.name == 'nt':17:01
bnemec  fn = None17:01
bnemecprocessutils.execute(..., preexec_fn=fn, ...)17:01
dimsearlier, we were the only ones using preexec_fn so that was acceptable to set it to None, now that a developer is trying to use that functionality we should fail hard17:01
bnemecIs there any other way to handle that?17:02
dhellmanndims: if subprocess will fail for us, then if at some point in the future if the pre-exec function is supported on windows we won't need to make a change17:02
dimsdhellmann: ack, updated commit message and passing through preexec_fn on nt17:03
bnemecAlso a good reason to keep the logic in one place, instead of everywhere this gets called.17:03
dhellmanndims: k17:03
bnemecAs it stands, if this starts to work on windows we'll have to find every single call and remove the logic around whether to pass the function.17:04
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute  https://review.openstack.org/19524917:05
*** ihrachyshka has quit IRC17:05
dimsbnemec: dhellmann: ready ^^^17:05
* bnemec taps the mic17:05
bnemecIs this thing on?17:06
dims:)17:06
dhellmannbnemec: the current version looks ok to me, what are you proposing as a change? accept the arg and ignore it on windows?17:06
bnemecdhellmann: I'm saying that we shouldn't force callers to do this:17:07
bnemec<bnemec> fn = some_func17:07
bnemec<bnemec> if os.name == 'nt':17:07
bnemec<bnemec>   fn = None17:07
bnemec<bnemec> processutils.execute(..., preexec_fn=fn, ...)17:07
dhellmannI think I could support that, with a nice big warning in the docs17:07
dhellmannyeah, I can see your point17:07
dhellmanndims?17:07
bnemecWhen we can do that automatically in one place.17:07
*** ihrachyshka has joined #openstack-oslo17:07
*** rpodolyaka1 has quit IRC17:07
dimsso set to None for windows17:08
bnemecI think we need a big warning in the docstring regardless.17:08
*** salv-orl_ has joined #openstack-oslo17:08
dimsbnemec: ack17:08
dhellmannyeah, let's include a warning and the reasoning behind not throwing an error17:09
* bnemec apologizes for being so stubborn on this17:09
bnemecBut that doesn't mean I'm going to stop :-)17:09
*** e0ne has joined #openstack-oslo17:09
*** yamahata has quit IRC17:09
dhellmannbnemec: you made a good point17:09
* dhellmann makes a note to direct questions on this topic to bnemec 17:10
bnemecFair enough :-)17:10
dhellmann:-)17:10
dims:)17:11
*** salv-orlando has quit IRC17:11
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute  https://review.openstack.org/19524917:13
dimsbnemec: hopefully this will stick :) ^17:13
bnemecdims: +2!17:15
dhellmanndims: +2a17:15
dimsthanks bnemec, dhellmann - please bless the backport too - https://review.openstack.org/#/c/198511/17:16
*** zzzeek has quit IRC17:16
bnemecHmm, apparently I have +2 on stable now.  Not sure how I feel about that. ;-)17:18
*** e0ne is now known as e0ne_17:18
*** david-lyle has quit IRC17:19
bnemecOn a related note, I have a todo to follow up with dhellmann on making the tripleo projects work nicely with the relman tools.17:19
bnemecI think we needed to add something to the launchpad permissions?17:19
dhellmannbnemec: yep, can we discuss that in #openstack-relmgr-office?17:20
bnemecdhellmann: brt17:20
dhellmannbnemec: also, since dims is core on that project you can approve his stable backport with one +217:20
*** pradk has joined #openstack-oslo17:21
*** e0ne_ is now known as e0ne17:21
dimsbnemec: yay! :)17:21
dimsdhellmann: bnemec: thanks17:21
*** sputnik13 has joined #openstack-oslo17:22
*** browne has quit IRC17:22
*** _amrith_ is now known as amrith17:24
*** achanda has joined #openstack-oslo17:25
*** e0ne is now known as e0ne_17:26
*** e0ne_ is now known as e0ne17:27
*** e0ne is now known as e0ne_17:33
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.serialization: Drop stale test - test_jsonutils  https://review.openstack.org/19919117:34
*** zzzeek has joined #openstack-oslo17:35
*** e0ne_ is now known as e0ne17:39
*** yamahata has joined #openstack-oslo17:44
droyalI'm trying to add tests in oslo.messaging.17:59
droyalhow do I get more verbose output from tox?17:59
droyalor testr/subunit?17:59
*** browne has joined #openstack-oslo17:59
dimsdroyal: you can use testtools.run or pytest to run a single test18:00
*** mgarza_ has quit IRC18:00
dimshere's how i do it in nova, but the steps are the same - https://davanum.wordpress.com/2015/01/13/quickly-running-a-single-openstack-nova-test/18:00
droyali'm trying to help add/fix tests in the feature/zmq branch. everything runs fine the first time (with minor import tweaks) but the second run always fails18:01
droyalthe error message isn't very helpful18:01
dimsdroyal:  see if it's consistently passing with a single thread "tox -e py27 -- --concurrency=1"18:04
droyalno luck18:06
*** mgarza_ has joined #openstack-oslo18:06
droyali'll post the exception18:07
*** ihrachyshka has quit IRC18:07
droyalhttp://pastebin.com/7SZBFdEN18:07
droyalis there a hidden file/directory created somewhere?18:08
droyalI just got in touch with oleksii, he might be able to help18:09
*** hogepodge has joined #openstack-oslo18:11
*** kgiusti has joined #openstack-oslo18:16
*** e0ne is now known as e0ne_18:17
*** hogepodge has quit IRC18:20
*** salv-orl_ has quit IRC18:22
*** rpodolyaka1 has joined #openstack-oslo18:28
droyaldims, pytest gave me what I needed -- ran pytest on the whole dir18:29
droyali'm not very familure with test or subunit, so I assmed I was doing something wrong with those tools18:29
dimsyay!18:30
droyalpytest saves the day again :)18:30
droyaloh wait. crap! not trying to start a testing flame war. just happy I got what I needed18:31
*** sdake has quit IRC18:36
*** mgarza_ has quit IRC18:38
*** e0ne_ is now known as e0ne18:39
dims:)18:44
*** mgarza_ has joined #openstack-oslo18:45
*** salv-orlando has joined #openstack-oslo18:49
*** yassine_ has quit IRC18:49
*** e0ne has quit IRC18:50
*** achanda has quit IRC18:51
*** sdake has joined #openstack-oslo18:52
*** dims has quit IRC18:53
*** mriedem has quit IRC18:55
*** sdake_ has joined #openstack-oslo18:56
*** dims has joined #openstack-oslo18:58
*** sdake has quit IRC19:00
*** hogepodge has joined #openstack-oslo19:00
*** harlowja_ has joined #openstack-oslo19:02
*** harlowja has quit IRC19:03
dimslifeless: were you looking at travis-ci? i have a handful of jobs setup https://travis-ci.org/dims/19:05
*** Rockyg has joined #openstack-oslo19:06
*** mriedem has joined #openstack-oslo19:06
*** mgarza_ has quit IRC19:14
*** rpodolyaka1 has quit IRC19:16
dimsbknudson: stevemar: has anyone broached the subject of loading policy json from an alternate datasource? (i.e, not from a file)19:17
bknudsondims: that's all we talk about in keystone meetings.19:18
dimshaha19:18
dimswas hunting to see if there was an old spec19:19
*** ndipanov has quit IRC19:20
*** mgarza has joined #openstack-oslo19:24
*** mriedem has quit IRC19:25
openstackgerritAlexander Tivelkov proposed openstack/oslo.versionedobjects: Compound Field validation (WiP)  https://review.openstack.org/19681919:26
stevemardims: yeah, thats all we talk about these days19:28
harlowja_SpamapS i think i brought up that whole ack before/after consume a while ago, let me see what i can find19:28
stevemardims: don't expect anything working for a while, it's a major work item19:28
harlowja_its not the first time this has been questioned :-P19:28
dimsstevemar: i thought bknudson was kidding :)19:28
dimsstevemar: got a spec or something i can peek at?19:28
stevemardims: i have the same issue with bknudson19:29
dims:)19:29
stevemardims: https://review.openstack.org/#/q/status:open+project:openstack/keystone-specs+branch:master+topic:bp/dynamic-policy,n,z19:29
dimsthanks!19:29
*** mriedem has joined #openstack-oslo19:29
*** shardy_ has joined #openstack-oslo19:31
stevemarnp19:32
*** shardy has quit IRC19:32
openstackgerritMerged openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute  https://review.openstack.org/19524919:32
*** shardy_ has quit IRC19:36
lifelessdims: already use it for testtools, was adding mock to it19:37
*** achanda has joined #openstack-oslo19:37
dimscool lifeless19:37
*** shardy has joined #openstack-oslo19:37
openstackgerritSean Dague proposed openstack-dev/pbr: Add wsgi_scripts support to PBR  https://review.openstack.org/19529219:47
*** dims has quit IRC19:48
*** david-lyle has joined #openstack-oslo19:50
*** manishg has quit IRC19:53
*** e0ne has joined #openstack-oslo19:54
*** manishg has joined #openstack-oslo19:58
*** mgarza has quit IRC20:00
*** mgarza_ has joined #openstack-oslo20:03
*** spandhe has joined #openstack-oslo20:05
*** jaosorior has quit IRC20:06
*** amrith is now known as _amrith_20:11
*** manishg_ has joined #openstack-oslo20:15
*** manishg has quit IRC20:15
SpamapSharlowja_: I atually recall when you brought it up. But I think most people just aren't willing to act on design principles alone.. bug reports or nothing I guess.20:17
harlowja_SpamapS ya, i can't remmeber and/or find the conversation (google not finding it, lol)20:18
harlowja_but i swear its been talked about somewhere (maybe even by me, ha)20:18
*** salv-orlando has quit IRC20:20
*** kgiusti has left #openstack-oslo20:21
*** ganso_ has quit IRC20:28
*** jamielennox is now known as jamielennox|away20:41
*** e0ne has quit IRC20:44
*** jamielennox|away is now known as jamielennox20:52
*** exploreshaifali has quit IRC21:00
*** manishg_ has quit IRC21:07
*** dims has joined #openstack-oslo21:13
*** sdake_ is now known as sdake21:20
*** salv-orlando has joined #openstack-oslo21:22
*** salv-orlando has quit IRC21:29
*** salv-orlando has joined #openstack-oslo21:30
*** dims has quit IRC21:30
*** pradk has quit IRC21:32
*** dims has joined #openstack-oslo21:35
*** dims has quit IRC21:35
*** Guest7393 has joined #openstack-oslo21:35
*** mriedem is now known as mriedem_away21:37
*** _amrith_ is now known as amrith21:41
*** browne has quit IRC21:44
*** sdake_ has joined #openstack-oslo21:48
*** manishg has joined #openstack-oslo21:50
*** sdake has quit IRC21:52
*** mgarza_ has quit IRC21:57
openstackgerritJoshua Harlow proposed openstack/futurist: Add future waiting helper module  https://review.openstack.org/19626921:58
*** mgarza has joined #openstack-oslo21:59
harlowja_SpamapS how do we change the mindset of 'most people just aren't willing to act on design principles alone'22:01
harlowja_is that just a experience problem that can't be solved (until said people get experience?)22:01
*** zzzeek has quit IRC22:05
*** zzzeek has joined #openstack-oslo22:07
*** dimtruck is now known as zz_dimtruck22:09
*** jecarey has quit IRC22:13
*** manishg has quit IRC22:13
*** manishg has joined #openstack-oslo22:14
*** prad has quit IRC22:16
openstackgerritDavid Stanek proposed openstack/oslo.policy: Fixes up the API docs and module index  https://review.openstack.org/19932822:24
*** bknudson has quit IRC22:31
*** gordc has quit IRC22:36
*** browne has joined #openstack-oslo22:37
openstackgerritlifeless proposed openstack/oslo.db: Refactor deps to use extras and env markers.  https://review.openstack.org/18432822:39
openstackgerritJoshua Harlow proposed openstack/futurist: Ensure we check callback '_is_periodic' on add  https://review.openstack.org/19645722:39
openstackgerritJoshua Harlow proposed openstack/futurist: Ensure we check callback '_is_periodic' on add  https://review.openstack.org/19645722:42
*** Rockyg has quit IRC22:57
*** ashleighfarnham has quit IRC23:10
*** manishg has quit IRC23:21
*** salv-orlando has quit IRC23:26
*** stevemar has quit IRC23:40
*** sputnik13 has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!