*** sdake_ has joined #openstack-oslo | 00:00 | |
*** dims has joined #openstack-oslo | 00:01 | |
*** sdake has quit IRC | 00:02 | |
*** _amrith_ is now known as amrith | 00:07 | |
*** sdake has joined #openstack-oslo | 00:09 | |
*** sdake_ has quit IRC | 00:13 | |
openstackgerrit | Kevin Benton proposed openstack/oslo.messaging: Verify that version in 'prepare' is valid https://review.openstack.org/193867 | 00:18 |
---|---|---|
*** sputnik13 has quit IRC | 00:22 | |
*** manishg has quit IRC | 00:23 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Make the loopingcall code less dependent on eventlet https://review.openstack.org/194479 | 00:24 |
*** tsekiyama has quit IRC | 00:26 | |
*** kgiusti has left #openstack-oslo | 00:32 | |
*** zzzeek has quit IRC | 00:35 | |
dims | harlowja: ping | 00:40 |
harlowja | pong | 00:40 |
dims | harlowja: free for dinner tomorrow? | 00:40 |
harlowja | hmmmm, usually do indoor rock climbing tommorow, how about wed? | 00:40 |
dims | harlowja: wed sounds good, but will confirm on wed morning | 00:41 |
harlowja | ok dokie | 00:41 |
dims | cool thanks | 00:42 |
harlowja | np | 00:42 |
*** dims has quit IRC | 00:50 | |
*** dims has joined #openstack-oslo | 00:58 | |
*** amotoki has joined #openstack-oslo | 01:02 | |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Add future waiting helper module https://review.openstack.org/196269 | 01:02 |
*** zz_dimtruck is now known as dimtruck | 01:03 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove deprecated things now that we are in 1.x releases https://review.openstack.org/198914 | 01:06 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Use monotonic library to avoid finding monotonic time function https://review.openstack.org/190377 | 01:12 |
*** achanda has joined #openstack-oslo | 01:13 | |
*** mtanino has quit IRC | 01:22 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove deprecated things now that we are in 1.x releases https://review.openstack.org/198914 | 01:26 |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Add future waiting helper module https://review.openstack.org/196269 | 01:36 |
*** stevemar has joined #openstack-oslo | 01:41 | |
lifeless | harlowja: so we can't land those | 02:03 |
lifeless | harlowja: can we? without creating 2.0 as the next release | 02:03 |
*** yamahata has quit IRC | 02:10 | |
*** arnaud____ has joined #openstack-oslo | 02:13 | |
*** rjaiswal has quit IRC | 02:14 | |
*** arnaud____ has quit IRC | 02:21 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.utils: versionutils: add version convert helper methods https://review.openstack.org/198500 | 02:34 |
*** stevemar has quit IRC | 02:54 | |
*** stevemar has joined #openstack-oslo | 02:54 | |
*** arnaud____ has joined #openstack-oslo | 02:57 | |
harlowja | lifeless sure, 2.0 as next release, doesn't matter to me :-P | 03:06 |
harlowja | 2.0 is the new 1.0 from what i hear anyway ;-P | 03:06 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Remove deprecated things now that we are in 1.x releases https://review.openstack.org/198914 | 03:07 |
lifeless | harlowja: well its more that we can't do a point release of 1 | 03:14 |
lifeless | harlowja: because if there are API breaks in it | 03:14 |
harlowja | i know | 03:14 |
lifeless | k | 03:14 |
harlowja | but ya, sorta sucks, ha | 03:14 |
harlowja | oh well | 03:14 |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Add future waiting helper module https://review.openstack.org/196269 | 03:23 |
harlowja | dhellmann though wanted a 1.0 :-P so that happened, ha | 03:25 |
*** dims has quit IRC | 03:39 | |
*** arnaud____ has quit IRC | 03:54 | |
*** arnaud__ has joined #openstack-oslo | 04:14 | |
*** manishg has joined #openstack-oslo | 04:14 | |
openstackgerrit | Merged openstack/oslo.service: Remove usage of mox in test_eventlet_backdoor https://review.openstack.org/197991 | 04:36 |
*** dims has joined #openstack-oslo | 04:40 | |
*** dims_ has joined #openstack-oslo | 04:41 | |
openstackgerrit | Merged openstack/oslo.service: Add mock to test_requirements https://review.openstack.org/198710 | 04:43 |
*** dims has quit IRC | 04:45 | |
*** dims_ has quit IRC | 04:46 | |
tchaypo | lifeless: change 184328 | 04:59 |
*** manishg has quit IRC | 04:59 | |
tchaypo | the commit message says “this is a bit of an example”, which suggests to me that this is not an actual intended-to-be-landed commit but just something to point people at for their edification | 05:00 |
tchaypo | is that the case? | 05:00 |
*** sputnik13 has joined #openstack-oslo | 05:12 | |
*** exploreshaifali has joined #openstack-oslo | 05:17 | |
*** rpodolyaka1 has joined #openstack-oslo | 05:17 | |
*** e0ne has joined #openstack-oslo | 05:22 | |
*** achanda has quit IRC | 05:23 | |
*** nkrinner has joined #openstack-oslo | 05:24 | |
*** exploreshaifali has quit IRC | 05:28 | |
*** rpodolyaka1 has quit IRC | 05:43 | |
*** rpodolyaka1 has joined #openstack-oslo | 05:43 | |
*** e0ne has quit IRC | 05:44 | |
*** sputnik13 has quit IRC | 05:48 | |
*** yamahata has joined #openstack-oslo | 05:50 | |
*** ig0r_ has joined #openstack-oslo | 05:51 | |
*** ig0r__ has quit IRC | 05:55 | |
*** rpodolyaka1 has quit IRC | 05:59 | |
*** arnaud__ has quit IRC | 06:01 | |
lifeless | tchaypo: sorry which one is that ? | 06:05 |
tchaypo | “refactor deps to use extras and env markers" | 06:15 |
tchaypo | if it’s meant to land, it looks ready to land; if it’s just an example I won’t give it a +1 | 06:15 |
lifeless | tchaypo: oslo.db ? | 06:18 |
lifeless | tchaypo: its an exemplar, not an example | 06:18 |
lifeless | feel free to +1 it | 06:18 |
openstackgerrit | Eric Brown proposed openstack/oslo.config: Expose min and max to IntOpt https://review.openstack.org/196955 | 06:27 |
openstackgerrit | Merged openstack-dev/pbr: This documents the use of comments that work between 2.6, 2.7 and 3.4 https://review.openstack.org/193927 | 06:31 |
*** dimtruck is now known as zz_dimtruck | 06:34 | |
openstackgerrit | Flavio Percoco proposed openstack/oslo.messaging: Make heartbeat the default https://review.openstack.org/198986 | 06:53 |
*** e0ne has joined #openstack-oslo | 06:57 | |
*** rpodolyaka1 has joined #openstack-oslo | 06:57 | |
*** stevemar has quit IRC | 06:59 | |
*** stevemar has joined #openstack-oslo | 07:00 | |
*** e0ne has quit IRC | 07:04 | |
*** stevemar has quit IRC | 07:11 | |
openstackgerrit | Eric Brown proposed openstack/oslo.config: Expose min and max to IntOpt https://review.openstack.org/196955 | 07:12 |
*** rpodolyaka1 has quit IRC | 07:20 | |
*** rpodolyaka1 has joined #openstack-oslo | 07:23 | |
*** rpodolyaka1 has quit IRC | 07:30 | |
*** cdent has joined #openstack-oslo | 07:33 | |
*** browne has quit IRC | 07:33 | |
*** e0ne has joined #openstack-oslo | 07:36 | |
*** rpodolyaka1 has joined #openstack-oslo | 07:37 | |
*** rpodolyaka1 has quit IRC | 07:41 | |
*** dims has joined #openstack-oslo | 07:43 | |
*** dims has quit IRC | 07:48 | |
*** jaosorior has joined #openstack-oslo | 07:55 | |
*** e0ne is now known as e0ne_ | 08:01 | |
*** exploreshaifali has joined #openstack-oslo | 08:02 | |
*** e0ne_ is now known as e0ne | 08:03 | |
*** stevemar has joined #openstack-oslo | 08:12 | |
*** haypo has joined #openstack-oslo | 08:12 | |
*** stevemar has quit IRC | 08:16 | |
*** shardy has joined #openstack-oslo | 08:17 | |
*** pblaho has joined #openstack-oslo | 08:30 | |
*** rpodolyaka1 has joined #openstack-oslo | 08:33 | |
*** yassine_ has joined #openstack-oslo | 08:40 | |
*** shardy_ has joined #openstack-oslo | 09:00 | |
*** shardy has quit IRC | 09:02 | |
*** ozamiatin has joined #openstack-oslo | 09:03 | |
*** shardy_ has quit IRC | 09:05 | |
*** shardy has joined #openstack-oslo | 09:06 | |
*** rpodolyaka1 has quit IRC | 09:07 | |
*** rpodolyaka1 has joined #openstack-oslo | 09:08 | |
*** e0ne is now known as e0ne_ | 09:11 | |
*** boris-42 has quit IRC | 09:22 | |
*** e0ne_ is now known as e0ne | 09:24 | |
*** rpodolyaka1 has quit IRC | 09:34 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/199022 | 09:37 |
*** dims has joined #openstack-oslo | 09:44 | |
*** dims_ has joined #openstack-oslo | 09:45 | |
*** dims__ has joined #openstack-oslo | 09:46 | |
*** rpodolyaka1 has joined #openstack-oslo | 09:47 | |
*** rpodolyaka1 has quit IRC | 09:47 | |
*** dims has quit IRC | 09:48 | |
*** dims_ has quit IRC | 09:50 | |
*** dims__ has quit IRC | 09:50 | |
*** shardy_ has joined #openstack-oslo | 10:06 | |
*** e0ne is now known as e0ne_ | 10:07 | |
*** shardy has quit IRC | 10:08 | |
*** shardy_ has quit IRC | 10:12 | |
*** shardy has joined #openstack-oslo | 10:13 | |
*** e0ne_ is now known as e0ne | 10:21 | |
*** viktors|afk is now known as viktors | 10:30 | |
*** exploreshaifali has quit IRC | 10:32 | |
*** ericksonsantos has joined #openstack-oslo | 10:40 | |
*** dims has joined #openstack-oslo | 10:46 | |
*** katyafervent_ is now known as katyafervent_awa | 10:48 | |
*** ozamiatin has quit IRC | 10:49 | |
*** rpodolyaka1 has joined #openstack-oslo | 10:50 | |
*** katyafervent_awa is now known as katyafervent | 10:51 | |
*** dims has quit IRC | 10:51 | |
*** ihrachyshka has joined #openstack-oslo | 10:55 | |
*** exploreshaifali has joined #openstack-oslo | 11:09 | |
*** arnaud__ has joined #openstack-oslo | 11:15 | |
*** e0ne is now known as e0ne_ | 11:25 | |
openstackgerrit | Sean Dague proposed openstack-dev/pbr: Add wsgi_scripts support to PBR https://review.openstack.org/195292 | 11:35 |
*** e0ne_ is now known as e0ne | 11:45 | |
*** prad has joined #openstack-oslo | 11:45 | |
*** stevemar has joined #openstack-oslo | 11:50 | |
*** rpodolyaka1 has quit IRC | 11:54 | |
*** stevemar has quit IRC | 11:54 | |
*** rpodolyaka1 has joined #openstack-oslo | 11:57 | |
*** rpodolyaka1 has quit IRC | 12:00 | |
*** dims has joined #openstack-oslo | 12:02 | |
*** jaypipes has joined #openstack-oslo | 12:02 | |
*** gordc has joined #openstack-oslo | 12:02 | |
*** bknudson has quit IRC | 12:03 | |
*** arnaud___ has joined #openstack-oslo | 12:04 | |
*** amrith is now known as _amrith_ | 12:04 | |
*** rpodolyaka1 has joined #openstack-oslo | 12:06 | |
*** arnaud__ has quit IRC | 12:07 | |
*** dims has quit IRC | 12:07 | |
*** ganso_ has joined #openstack-oslo | 12:14 | |
*** ozamiatin has joined #openstack-oslo | 12:15 | |
*** browne has joined #openstack-oslo | 12:18 | |
*** arnaud___ has quit IRC | 12:23 | |
*** rpodolyaka1 has quit IRC | 12:24 | |
*** bknudson has joined #openstack-oslo | 12:27 | |
*** kgiusti has joined #openstack-oslo | 12:28 | |
*** rpodolyaka1 has joined #openstack-oslo | 12:33 | |
openstackgerrit | Sergey Nikitin proposed openstack/oslo.cache: Implemented DictCacheBackend https://review.openstack.org/198265 | 12:50 |
haypo | hey. i need some pbr skill to debug the error: pkg_resources.VersionConflict: (pbr 1.2.0 (/home/haypo/prog/openstack/swift/.tox/pep8/lib/python2.7/site-packages), Requirement.parse('pbr<1.0,>=0.5.21')) | 12:52 |
haypo | i would like to write dnspython>=1.9.4; python_version < '3.0' in Swift requirements | 12:53 |
haypo | so i added pbr<2.0,>=0.11 to requirements.txt, but it looks like _something_ requires pbr < 1.0 | 12:53 |
haypo | my patch: https://review.openstack.org/#/c/199034/ | 12:53 |
haypo | oh, it's hacking. swift uses an old version of hacking which requires pbr < 1.0 | 13:04 |
*** browne has quit IRC | 13:10 | |
*** _amrith_ is now known as amrith | 13:11 | |
*** manishg has joined #openstack-oslo | 13:14 | |
*** manishg has quit IRC | 13:15 | |
*** exploreshaifali has quit IRC | 13:15 | |
*** manishg has joined #openstack-oslo | 13:16 | |
*** dims has joined #openstack-oslo | 13:19 | |
openstackgerrit | Flavio Percoco proposed openstack/oslo.messaging: Make heartbeat the default https://review.openstack.org/198986 | 13:24 |
*** claudiub has joined #openstack-oslo | 13:25 | |
claudiub | hello. I would require some information. What are the necessary steps to propose a new oslo library, besides the spec? (oslo_hyperv) | 13:26 |
*** mriedem_away is now known as mriedem | 13:27 | |
*** browne has joined #openstack-oslo | 13:30 | |
ttx | dims: do you still plan to do an oslo.concurrency kilo release to unblock the stablke/kilo requirements conflict ? | 13:30 |
dims | ttx: yes, i will take care of it today | 13:31 |
ttx | dims: cool, thx | 13:31 |
*** mtanino has joined #openstack-oslo | 13:31 | |
dims | ttx was waiting for one more bug to land in master (and then backport), but its taking too long, so i'll just cut one to unblock the neutron jobs | 13:32 |
*** amotoki has quit IRC | 13:33 | |
dims | jd__: flaper87: sileht: can you please bless https://review.openstack.org/#/c/195249/ (and backport - https://review.openstack.org/#/c/198511/) | 13:33 |
dhellmann | good morning | 13:33 |
*** boris-42 has joined #openstack-oslo | 13:33 | |
dhellmann | dims, harlowja : I missed the discussion of the taskflow versioning. I think lifeless is right that we should, overall, be more careful of API breaks. | 13:36 |
haypo | dims: i added a comment for windows :) | 13:36 |
*** e0ne is now known as e0ne_ | 13:37 | |
dims | dhellmann: Hi, yes, agree. | 13:37 |
dims | haypo: where? | 13:37 |
*** jecarey has joined #openstack-oslo | 13:38 | |
*** stevemar has joined #openstack-oslo | 13:39 | |
*** e0ne_ is now known as e0ne | 13:39 | |
haypo | dims: https://review.openstack.org/#/c/195249/9/oslo_concurrency/processutils.py | 13:40 |
dims | good point | 13:41 |
haypo | dims: subprocess raises a ValueError, https://hg.python.org/cpython/file/2f86a69c3220/Lib/subprocess.py#l860 | 13:41 |
*** ccrouch has joined #openstack-oslo | 13:42 | |
*** stevemar has quit IRC | 13:42 | |
openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Adds value validation to the fields https://review.openstack.org/196041 | 13:42 |
*** manishg has quit IRC | 13:44 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute https://review.openstack.org/195249 | 13:44 |
*** ccrouch has left #openstack-oslo | 13:45 | |
haypo | dims: what do you think of starting to use .. versionchanged:: 1.10 New parameter preexec_fn | 13:46 |
haypo | dims: for the doc | 13:46 |
*** rpodolyaka1 has quit IRC | 13:46 | |
haypo | dims: it's annoying to have to dig git history to find when a new option was added | 13:46 |
haypo | (1.10 is a random version, i don't know the current version of oslo.concurrency) | 13:46 |
haypo | dims: example, https://docs.python.org/dev/library/subprocess.html#subprocess.TimeoutExpired | 13:46 |
haypo | dims: my question is not specific to this change ;) | 13:47 |
haypo | recently, i had to dig oslo.concurrency history to check when i added the binary option :-p | 13:47 |
dims | looks like there's a versionadded as well | 13:48 |
dims | haypo: +1 to come up with a small list of useful doc comments and tell everyone to start using it. i can't seem to find any projects using either of them | 13:49 |
haypo | dims: these tags are common and mandatory in python doc | 13:50 |
* dims dropping off to wake up and have coffee back in a bit | 13:50 | |
dims | haypo: yes, i just can't see these 2 tags used in any of our openstack projects | 13:50 |
dims | back in a bit | 13:50 |
*** rpodolyaka1 has joined #openstack-oslo | 13:52 | |
*** claudiub has quit IRC | 13:52 | |
*** manishg has joined #openstack-oslo | 13:52 | |
*** manishg has quit IRC | 13:52 | |
*** manishg has joined #openstack-oslo | 13:53 | |
haypo | dims: i propose to start using them to provide better documentations | 13:55 |
dhellmann | haypo: I like the idea. Maybe we should start a doc with hints/tips/suggestions for documenting oslo libs? | 13:55 |
dhellmann | We could put it in the policy section of our specs repo, with the other team-guide stuff | 13:55 |
haypo | dhellmann: well, it's already documented in sphinx doc: http://sphinx-doc.org/markup/para.html?highlight=versionadde#paragraph-level-markup | 13:56 |
haypo | we can start to warn users in reviews | 13:56 |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:57 | |
haypo | i know that i will take time until all dev will take the habit of adding directly these tags to the doc | 13:57 |
dhellmann | haypo: I mean that we should suggest how/why to use it, as a guideline. That way we can point to our local doc in reviews when we ask for someone to add the tag | 13:58 |
*** zz_dimtruck is now known as dimtruck | 13:59 | |
*** rpodolyaka3 has joined #openstack-oslo | 14:01 | |
*** rpodolyaka1 has quit IRC | 14:01 | |
*** ccrouch has joined #openstack-oslo | 14:02 | |
haypo | dhellmann: what is our local doc? | 14:02 |
*** manishg has quit IRC | 14:02 | |
*** Kennan2 has joined #openstack-oslo | 14:03 | |
*** Kennan has quit IRC | 14:03 | |
*** rpodolyaka3 has quit IRC | 14:04 | |
*** rpodolyaka1 has joined #openstack-oslo | 14:05 | |
*** dimtruck is now known as zz_dimtruck | 14:06 | |
*** geguileo has quit IRC | 14:09 | |
dhellmann | haypo: sorry, that was a poor choice of words on my part. I meant something we manage, instead of the sphinx documentation. | 14:12 |
haypo | dhellmann: hum, yes maybe. but i'm not interested to write such doc. only to harass developers on reviews until they document their API changes :) | 14:13 |
haypo | maybe it will slow down API breaks :-S | 14:14 |
haypo | changes* | 14:14 |
*** sdake has quit IRC | 14:14 | |
dhellmann | haypo: consider it a way to avoid having to say the same thing on reviews over and over :-) | 14:14 |
*** sdake has joined #openstack-oslo | 14:15 | |
haypo | dhellmann: i see | 14:15 |
openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Adds value validation to the fields https://review.openstack.org/196041 | 14:20 |
haypo | pbr, pip and requirements issues make me nervous. gate-tempest-dsvm-neutron-src-oslo.utils is still failing on "... upper-constraints.txt -- keystone ..." on my oslo.utils patch. https://review.openstack.org/#/c/198026/ | 14:21 |
haypo | it fails with: pkg_resources.RequirementParseError: Missing distribution spec /opt/stack/new/oslo.utils | 14:21 |
haypo | is someone aware of this issue? | 14:21 |
dhellmann | haypo: I think lifeless had a fix in the queue for that? dims, do you know? | 14:22 |
dhellmann | haypo: either way, yes, it's a known issue with the new requirements tools | 14:22 |
haypo | yet another requirement nightmare :-p | 14:25 |
haypo | dhellmann: i lost 2 hours trying to upgrade pbr to >= 1.0 in swift, but it looks impossible because swift uses an old version of hacking which requires pbr<10. | 14:25 |
haypo | pbr<1.0 | 14:25 |
haypo | and upgrading hacking looks complex. flake8 finds new issues, and it doesn't look to possible to ignore them | 14:26 |
dhellmann | that's unfortunate | 14:26 |
haypo | pep8 is stupid. you cannot select "E" but ignore "E121"!? | 14:26 |
dhellmann | maybe we should remove the pbr cap in the old hacking; I'm not sure why that's there | 14:26 |
haypo | (flake8 is based on pep8, and upgrading hacking upgrades flake8, pep8, etc.) | 14:26 |
haypo | dhellmann: maybe we should stop using pbr. i hate pbr :) | 14:27 |
haypo | (sorry, useless comment, but as i wrote, these tools make me nervous) | 14:29 |
haypo | dhellmann: i'm unable to find a fix from lifeless for my requirement issue | 14:30 |
openstackgerrit | Kevin Benton proposed openstack/oslo.messaging: Verify that version in 'prepare' is valid https://review.openstack.org/193867 | 14:34 |
openstackgerrit | Merged openstack/oslo.concurrency: Updated from global requirements https://review.openstack.org/199022 | 14:40 |
dhellmann | haypo: I think it was in devstack-gate? or possibly in the requirements repo? iirc, it had something to do with the way requirements were being synced. Let me find it... | 14:54 |
*** ozamiatin has quit IRC | 14:56 | |
dhellmann | haypo: see the depends-on at the bottom of the commit message for https://review.openstack.org/#/c/181961/ | 14:56 |
dhellmann | haypo: both have merged | 14:56 |
*** achanda has joined #openstack-oslo | 14:56 | |
ttx | dims, dhellmann: I erceived various complaints from openstack-announce subscribers about the volume of oslo release announcements | 15:01 |
ttx | not sure it's fixable though, unless somehow we digest them into a single "oslo release day" email | 15:01 |
openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Move backdoor-related tests from test_service https://review.openstack.org/199141 | 15:02 |
ttx | but then arguably THEY should enable digest mode | 15:02 |
*** zzzeek has joined #openstack-oslo | 15:02 | |
*** achanda has quit IRC | 15:02 | |
*** rpodolyaka1 has quit IRC | 15:02 | |
*** rpodolyaka1 has joined #openstack-oslo | 15:04 | |
*** zz_dimtruck is now known as dimtruck | 15:06 | |
dhellmann | ttx: yeah, I think at some point we need to just start expecting people to learn to manage their email | 15:09 |
dhellmann | ttx: because if we batch up the notices, then we'll get complaints from folks who are watching for particular libraries that it's harder to spot the releases | 15:09 |
dims | ttx: i'll take any advice, we'll end up with folks unhappy either way | 15:09 |
dims | dhellmann: haypo: that requirements failure should have been fixed already, please run recheck | 15:10 |
haypo | dims: yes, i just scheduled a recheck on my patch https://review.openstack.org/#/c/198026/ | 15:11 |
dims | haypo: need specific tags which we can tell people to use then make them mandatory in reviews | 15:11 |
haypo | well, i'm no more convinced myself that my patch is required :) | 15:11 |
* dims dropping off again. sorry guys travelling this week, so will be off and on | 15:11 | |
haypo | dims looks my wifi connection today! | 15:12 |
dims | haha | 15:12 |
dims | haypo: can you add a wiki or etherpad page with some suggested tags? we can take it to the team on monday? | 15:13 |
haypo | dims: versionadded & versionchanged are enough, no? | 15:15 |
dims | haypo: there's a deprecated (http://sphinx-doc.org/markup/para.html) | 15:16 |
*** e0ne is now known as e0ne_ | 15:16 | |
dims | dhellmann may know a few others that may be useful | 15:16 |
dims | back in a bit | 15:16 |
*** dims has quit IRC | 15:16 | |
haypo | dims: hum, deprecated is already used no? | 15:16 |
*** manishg has joined #openstack-oslo | 15:17 | |
haypo | example of usage: http://docs.openstack.org/developer/oslo.utils/api/timeutils.html#oslo_utils.timeutils.isotime | 15:17 |
haypo | or maybe only jd__ uses it :) | 15:17 |
*** rpodolyaka1 has quit IRC | 15:18 | |
haypo | i'm writing an email to openstack-dev for versionchanged & cie | 15:18 |
*** tsekiyama has joined #openstack-oslo | 15:20 | |
dhellmann | haypo: sounds good -- we could provide some short guidelines for when/how to use all of those directives | 15:21 |
*** stevemar has joined #openstack-oslo | 15:22 | |
haypo | dhellmann: email sent. it's a first step ;) | 15:22 |
dhellmann | haypo: ++ | 15:23 |
*** nkrinner is now known as nkrinner_afk | 15:23 | |
*** e0ne_ is now known as e0ne | 15:26 | |
*** cdent has quit IRC | 15:28 | |
*** rpodolyaka1 has joined #openstack-oslo | 15:30 | |
*** davidlenwell has quit IRC | 15:38 | |
openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Compound Field validation (WiP) https://review.openstack.org/196819 | 15:38 |
*** shardy_ has joined #openstack-oslo | 15:40 | |
*** shardy has quit IRC | 15:41 | |
*** dims has joined #openstack-oslo | 15:43 | |
*** shardy_ has quit IRC | 15:45 | |
*** rpodolyaka1 has quit IRC | 15:45 | |
*** shardy has joined #openstack-oslo | 15:46 | |
*** sdake_ has joined #openstack-oslo | 15:48 | |
*** sdake has quit IRC | 15:48 | |
dims | bnemec: both me and haypo replied on https://review.openstack.org/#/c/195249/ - if we can get that in then i can do the backport and release a version needed to work with nova stable/kilo (security fixes) | 15:48 |
*** davidlenwell has joined #openstack-oslo | 15:53 | |
*** davidlenwell is now known as daviddavid | 15:54 | |
*** daviddavid is now known as davidlenwell | 15:54 | |
*** rpodolyaka1 has joined #openstack-oslo | 15:57 | |
*** davidlenwell has quit IRC | 15:58 | |
*** davidlenwell has joined #openstack-oslo | 15:58 | |
*** salv-orlando has joined #openstack-oslo | 15:58 | |
*** mgarza_ has joined #openstack-oslo | 16:00 | |
*** davidlenwell has quit IRC | 16:08 | |
*** ashleighfarnham has joined #openstack-oslo | 16:08 | |
*** davidlenwell has joined #openstack-oslo | 16:08 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute https://review.openstack.org/195249 | 16:08 |
*** ashleighfarnham has quit IRC | 16:08 | |
*** ashleighfarnham has joined #openstack-oslo | 16:09 | |
*** davidlenwell is now known as omnibus7 | 16:12 | |
*** omnibus7 is now known as davidlenwell | 16:12 | |
*** davidlenwell is now known as david_enwell | 16:12 | |
*** kgiusti has left #openstack-oslo | 16:13 | |
*** david_enwell is now known as davidlenwell | 16:19 | |
*** davidlenwell has quit IRC | 16:20 | |
*** davidlenwell has joined #openstack-oslo | 16:20 | |
*** hogepodge has quit IRC | 16:21 | |
*** davidlenwell has quit IRC | 16:23 | |
*** davidlenwell has joined #openstack-oslo | 16:24 | |
*** amrith is now known as _amrith_ | 16:26 | |
*** davidlenwell has quit IRC | 16:27 | |
*** davidlenwell has joined #openstack-oslo | 16:28 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute https://review.openstack.org/195249 | 16:29 |
haypo | dims: hey, you sent too many versions of your patch per hours :-p | 16:30 |
dims | haypo: there was a extra space | 16:30 |
dims | really want to get oslo.concurrency stable/kilo out today :) | 16:31 |
*** davidlenwell has quit IRC | 16:31 | |
haypo | dims: you want to add this new parameter to a stable version? | 16:31 |
dims | yes | 16:31 |
haypo | dims: i can approve the patch without a second +2 if you want | 16:31 |
dims | nova needs it for a security fix | 16:31 |
dims | thanx, let's wait for master one to merge first | 16:32 |
*** e0ne has quit IRC | 16:33 | |
haypo | dims: i mean approving https://review.openstack.org/195249 | 16:34 |
*** exploreshaifali has joined #openstack-oslo | 16:35 | |
*** sdake_ is now known as sdae | 16:35 | |
*** davidlenwell has joined #openstack-oslo | 16:35 | |
*** davidlenwell is now known as davidlenwell_ | 16:36 | |
dims | haypo: let's get another opinion. dhellmann do you have a few mins for https://review.openstack.org/#/c/195249/? | 16:37 |
*** davidlenwell_ is now known as davidlenwell | 16:38 | |
*** haypo has quit IRC | 16:39 | |
*** sdae is now known as sdake | 16:39 | |
*** haypo has joined #openstack-oslo | 16:40 | |
haypo | dims: i have to go, bye | 16:41 |
dims | bye haypo | 16:41 |
*** haypo has left #openstack-oslo | 16:41 | |
dhellmann | dims: looking | 16:52 |
dhellmann | dims: the commit message is slightly out of date, now that you're calling both the built-in and the provided function | 16:53 |
dhellmann | dims: I can fix that in gerrit and +2a since haypo already gave a +2 on the code | 16:53 |
dims | thanks dhellmann | 16:54 |
dhellmann | dims: well, what about bnemec's point about that exception? | 16:54 |
dims | dhellmann: subprocess does the same (raises ValueError) so am ok with the code as-is | 16:55 |
dhellmann | dims: if subprocess is going to raise the exception for us, why not let it? | 16:55 |
dims | dhellmann: works for me | 16:56 |
dims | let me rev | 16:56 |
bnemec | My thing is that this a convenience function, and it's not terribly convenient to push logic off on the caller when we can do the right thing easily. | 16:58 |
bnemec | Especially because this won't get caught in testing because we don't test on Windows. | 16:59 |
dims | bnemec: what's the right thing? (not sure i get it) | 16:59 |
bnemec | dims: To not pass preexec_fn to Popen. | 17:00 |
bnemec | I mean, isn't the calling code basically going to look like: | 17:00 |
dims | and fail silently? | 17:00 |
bnemec | fn = some_func | 17:01 |
bnemec | if os.name == 'nt': | 17:01 |
bnemec | fn = None | 17:01 |
bnemec | processutils.execute(..., preexec_fn=fn, ...) | 17:01 |
dims | earlier, we were the only ones using preexec_fn so that was acceptable to set it to None, now that a developer is trying to use that functionality we should fail hard | 17:01 |
bnemec | Is there any other way to handle that? | 17:02 |
dhellmann | dims: if subprocess will fail for us, then if at some point in the future if the pre-exec function is supported on windows we won't need to make a change | 17:02 |
dims | dhellmann: ack, updated commit message and passing through preexec_fn on nt | 17:03 |
bnemec | Also a good reason to keep the logic in one place, instead of everywhere this gets called. | 17:03 |
dhellmann | dims: k | 17:03 |
bnemec | As it stands, if this starts to work on windows we'll have to find every single call and remove the logic around whether to pass the function. | 17:04 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute https://review.openstack.org/195249 | 17:05 |
*** ihrachyshka has quit IRC | 17:05 | |
dims | bnemec: dhellmann: ready ^^^ | 17:05 |
* bnemec taps the mic | 17:05 | |
bnemec | Is this thing on? | 17:06 |
dims | :) | 17:06 |
dhellmann | bnemec: the current version looks ok to me, what are you proposing as a change? accept the arg and ignore it on windows? | 17:06 |
bnemec | dhellmann: I'm saying that we shouldn't force callers to do this: | 17:07 |
bnemec | <bnemec> fn = some_func | 17:07 |
bnemec | <bnemec> if os.name == 'nt': | 17:07 |
bnemec | <bnemec> fn = None | 17:07 |
bnemec | <bnemec> processutils.execute(..., preexec_fn=fn, ...) | 17:07 |
dhellmann | I think I could support that, with a nice big warning in the docs | 17:07 |
dhellmann | yeah, I can see your point | 17:07 |
dhellmann | dims? | 17:07 |
bnemec | When we can do that automatically in one place. | 17:07 |
*** ihrachyshka has joined #openstack-oslo | 17:07 | |
*** rpodolyaka1 has quit IRC | 17:07 | |
dims | so set to None for windows | 17:08 |
bnemec | I think we need a big warning in the docstring regardless. | 17:08 |
*** salv-orl_ has joined #openstack-oslo | 17:08 | |
dims | bnemec: ack | 17:08 |
dhellmann | yeah, let's include a warning and the reasoning behind not throwing an error | 17:09 |
* bnemec apologizes for being so stubborn on this | 17:09 | |
bnemec | But that doesn't mean I'm going to stop :-) | 17:09 |
*** e0ne has joined #openstack-oslo | 17:09 | |
*** yamahata has quit IRC | 17:09 | |
dhellmann | bnemec: you made a good point | 17:09 |
* dhellmann makes a note to direct questions on this topic to bnemec | 17:10 | |
bnemec | Fair enough :-) | 17:10 |
dhellmann | :-) | 17:10 |
dims | :) | 17:11 |
*** salv-orlando has quit IRC | 17:11 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute https://review.openstack.org/195249 | 17:13 |
dims | bnemec: hopefully this will stick :) ^ | 17:13 |
bnemec | dims: +2! | 17:15 |
dhellmann | dims: +2a | 17:15 |
dims | thanks bnemec, dhellmann - please bless the backport too - https://review.openstack.org/#/c/198511/ | 17:16 |
*** zzzeek has quit IRC | 17:16 | |
bnemec | Hmm, apparently I have +2 on stable now. Not sure how I feel about that. ;-) | 17:18 |
*** e0ne is now known as e0ne_ | 17:18 | |
*** david-lyle has quit IRC | 17:19 | |
bnemec | On a related note, I have a todo to follow up with dhellmann on making the tripleo projects work nicely with the relman tools. | 17:19 |
bnemec | I think we needed to add something to the launchpad permissions? | 17:19 |
dhellmann | bnemec: yep, can we discuss that in #openstack-relmgr-office? | 17:20 |
bnemec | dhellmann: brt | 17:20 |
dhellmann | bnemec: also, since dims is core on that project you can approve his stable backport with one +2 | 17:20 |
*** pradk has joined #openstack-oslo | 17:21 | |
*** e0ne_ is now known as e0ne | 17:21 | |
dims | bnemec: yay! :) | 17:21 |
dims | dhellmann: bnemec: thanks | 17:21 |
*** sputnik13 has joined #openstack-oslo | 17:22 | |
*** browne has quit IRC | 17:22 | |
*** _amrith_ is now known as amrith | 17:24 | |
*** achanda has joined #openstack-oslo | 17:25 | |
*** e0ne is now known as e0ne_ | 17:26 | |
*** e0ne_ is now known as e0ne | 17:27 | |
*** e0ne is now known as e0ne_ | 17:33 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.serialization: Drop stale test - test_jsonutils https://review.openstack.org/199191 | 17:34 |
*** zzzeek has joined #openstack-oslo | 17:35 | |
*** e0ne_ is now known as e0ne | 17:39 | |
*** yamahata has joined #openstack-oslo | 17:44 | |
droyal | I'm trying to add tests in oslo.messaging. | 17:59 |
droyal | how do I get more verbose output from tox? | 17:59 |
droyal | or testr/subunit? | 17:59 |
*** browne has joined #openstack-oslo | 17:59 | |
dims | droyal: you can use testtools.run or pytest to run a single test | 18:00 |
*** mgarza_ has quit IRC | 18:00 | |
dims | here's how i do it in nova, but the steps are the same - https://davanum.wordpress.com/2015/01/13/quickly-running-a-single-openstack-nova-test/ | 18:00 |
droyal | i'm trying to help add/fix tests in the feature/zmq branch. everything runs fine the first time (with minor import tweaks) but the second run always fails | 18:01 |
droyal | the error message isn't very helpful | 18:01 |
dims | droyal: see if it's consistently passing with a single thread "tox -e py27 -- --concurrency=1" | 18:04 |
droyal | no luck | 18:06 |
*** mgarza_ has joined #openstack-oslo | 18:06 | |
droyal | i'll post the exception | 18:07 |
*** ihrachyshka has quit IRC | 18:07 | |
droyal | http://pastebin.com/7SZBFdEN | 18:07 |
droyal | is there a hidden file/directory created somewhere? | 18:08 |
droyal | I just got in touch with oleksii, he might be able to help | 18:09 |
*** hogepodge has joined #openstack-oslo | 18:11 | |
*** kgiusti has joined #openstack-oslo | 18:16 | |
*** e0ne is now known as e0ne_ | 18:17 | |
*** hogepodge has quit IRC | 18:20 | |
*** salv-orl_ has quit IRC | 18:22 | |
*** rpodolyaka1 has joined #openstack-oslo | 18:28 | |
droyal | dims, pytest gave me what I needed -- ran pytest on the whole dir | 18:29 |
droyal | i'm not very familure with test or subunit, so I assmed I was doing something wrong with those tools | 18:29 |
dims | yay! | 18:30 |
droyal | pytest saves the day again :) | 18:30 |
droyal | oh wait. crap! not trying to start a testing flame war. just happy I got what I needed | 18:31 |
*** sdake has quit IRC | 18:36 | |
*** mgarza_ has quit IRC | 18:38 | |
*** e0ne_ is now known as e0ne | 18:39 | |
dims | :) | 18:44 |
*** mgarza_ has joined #openstack-oslo | 18:45 | |
*** salv-orlando has joined #openstack-oslo | 18:49 | |
*** yassine_ has quit IRC | 18:49 | |
*** e0ne has quit IRC | 18:50 | |
*** achanda has quit IRC | 18:51 | |
*** sdake has joined #openstack-oslo | 18:52 | |
*** dims has quit IRC | 18:53 | |
*** mriedem has quit IRC | 18:55 | |
*** sdake_ has joined #openstack-oslo | 18:56 | |
*** dims has joined #openstack-oslo | 18:58 | |
*** sdake has quit IRC | 19:00 | |
*** hogepodge has joined #openstack-oslo | 19:00 | |
*** harlowja_ has joined #openstack-oslo | 19:02 | |
*** harlowja has quit IRC | 19:03 | |
dims | lifeless: were you looking at travis-ci? i have a handful of jobs setup https://travis-ci.org/dims/ | 19:05 |
*** Rockyg has joined #openstack-oslo | 19:06 | |
*** mriedem has joined #openstack-oslo | 19:06 | |
*** mgarza_ has quit IRC | 19:14 | |
*** rpodolyaka1 has quit IRC | 19:16 | |
dims | bknudson: stevemar: has anyone broached the subject of loading policy json from an alternate datasource? (i.e, not from a file) | 19:17 |
bknudson | dims: that's all we talk about in keystone meetings. | 19:18 |
dims | haha | 19:18 |
dims | was hunting to see if there was an old spec | 19:19 |
*** ndipanov has quit IRC | 19:20 | |
*** mgarza has joined #openstack-oslo | 19:24 | |
*** mriedem has quit IRC | 19:25 | |
openstackgerrit | Alexander Tivelkov proposed openstack/oslo.versionedobjects: Compound Field validation (WiP) https://review.openstack.org/196819 | 19:26 |
stevemar | dims: yeah, thats all we talk about these days | 19:28 |
harlowja_ | SpamapS i think i brought up that whole ack before/after consume a while ago, let me see what i can find | 19:28 |
stevemar | dims: don't expect anything working for a while, it's a major work item | 19:28 |
harlowja_ | its not the first time this has been questioned :-P | 19:28 |
dims | stevemar: i thought bknudson was kidding :) | 19:28 |
dims | stevemar: got a spec or something i can peek at? | 19:28 |
stevemar | dims: i have the same issue with bknudson | 19:29 |
dims | :) | 19:29 |
stevemar | dims: https://review.openstack.org/#/q/status:open+project:openstack/keystone-specs+branch:master+topic:bp/dynamic-policy,n,z | 19:29 |
dims | thanks! | 19:29 |
*** mriedem has joined #openstack-oslo | 19:29 | |
*** shardy_ has joined #openstack-oslo | 19:31 | |
stevemar | np | 19:32 |
*** shardy has quit IRC | 19:32 | |
openstackgerrit | Merged openstack/oslo.concurrency: Allow preexec_fn method for processutils.execute https://review.openstack.org/195249 | 19:32 |
*** shardy_ has quit IRC | 19:36 | |
lifeless | dims: already use it for testtools, was adding mock to it | 19:37 |
*** achanda has joined #openstack-oslo | 19:37 | |
dims | cool lifeless | 19:37 |
*** shardy has joined #openstack-oslo | 19:37 | |
openstackgerrit | Sean Dague proposed openstack-dev/pbr: Add wsgi_scripts support to PBR https://review.openstack.org/195292 | 19:47 |
*** dims has quit IRC | 19:48 | |
*** david-lyle has joined #openstack-oslo | 19:50 | |
*** manishg has quit IRC | 19:53 | |
*** e0ne has joined #openstack-oslo | 19:54 | |
*** manishg has joined #openstack-oslo | 19:58 | |
*** mgarza has quit IRC | 20:00 | |
*** mgarza_ has joined #openstack-oslo | 20:03 | |
*** spandhe has joined #openstack-oslo | 20:05 | |
*** jaosorior has quit IRC | 20:06 | |
*** amrith is now known as _amrith_ | 20:11 | |
*** manishg_ has joined #openstack-oslo | 20:15 | |
*** manishg has quit IRC | 20:15 | |
SpamapS | harlowja_: I atually recall when you brought it up. But I think most people just aren't willing to act on design principles alone.. bug reports or nothing I guess. | 20:17 |
harlowja_ | SpamapS ya, i can't remmeber and/or find the conversation (google not finding it, lol) | 20:18 |
harlowja_ | but i swear its been talked about somewhere (maybe even by me, ha) | 20:18 |
*** salv-orlando has quit IRC | 20:20 | |
*** kgiusti has left #openstack-oslo | 20:21 | |
*** ganso_ has quit IRC | 20:28 | |
*** jamielennox is now known as jamielennox|away | 20:41 | |
*** e0ne has quit IRC | 20:44 | |
*** jamielennox|away is now known as jamielennox | 20:52 | |
*** exploreshaifali has quit IRC | 21:00 | |
*** manishg_ has quit IRC | 21:07 | |
*** dims has joined #openstack-oslo | 21:13 | |
*** sdake_ is now known as sdake | 21:20 | |
*** salv-orlando has joined #openstack-oslo | 21:22 | |
*** salv-orlando has quit IRC | 21:29 | |
*** salv-orlando has joined #openstack-oslo | 21:30 | |
*** dims has quit IRC | 21:30 | |
*** pradk has quit IRC | 21:32 | |
*** dims has joined #openstack-oslo | 21:35 | |
*** dims has quit IRC | 21:35 | |
*** Guest7393 has joined #openstack-oslo | 21:35 | |
*** mriedem is now known as mriedem_away | 21:37 | |
*** _amrith_ is now known as amrith | 21:41 | |
*** browne has quit IRC | 21:44 | |
*** sdake_ has joined #openstack-oslo | 21:48 | |
*** manishg has joined #openstack-oslo | 21:50 | |
*** sdake has quit IRC | 21:52 | |
*** mgarza_ has quit IRC | 21:57 | |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Add future waiting helper module https://review.openstack.org/196269 | 21:58 |
*** mgarza has joined #openstack-oslo | 21:59 | |
harlowja_ | SpamapS how do we change the mindset of 'most people just aren't willing to act on design principles alone' | 22:01 |
harlowja_ | is that just a experience problem that can't be solved (until said people get experience?) | 22:01 |
*** zzzeek has quit IRC | 22:05 | |
*** zzzeek has joined #openstack-oslo | 22:07 | |
*** dimtruck is now known as zz_dimtruck | 22:09 | |
*** jecarey has quit IRC | 22:13 | |
*** manishg has quit IRC | 22:13 | |
*** manishg has joined #openstack-oslo | 22:14 | |
*** prad has quit IRC | 22:16 | |
openstackgerrit | David Stanek proposed openstack/oslo.policy: Fixes up the API docs and module index https://review.openstack.org/199328 | 22:24 |
*** bknudson has quit IRC | 22:31 | |
*** gordc has quit IRC | 22:36 | |
*** browne has joined #openstack-oslo | 22:37 | |
openstackgerrit | lifeless proposed openstack/oslo.db: Refactor deps to use extras and env markers. https://review.openstack.org/184328 | 22:39 |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Ensure we check callback '_is_periodic' on add https://review.openstack.org/196457 | 22:39 |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Ensure we check callback '_is_periodic' on add https://review.openstack.org/196457 | 22:42 |
*** Rockyg has quit IRC | 22:57 | |
*** ashleighfarnham has quit IRC | 23:10 | |
*** manishg has quit IRC | 23:21 | |
*** salv-orlando has quit IRC | 23:26 | |
*** stevemar has quit IRC | 23:40 | |
*** sputnik13 has quit IRC | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!