* dims peeks to see if we broke the WORLD yet | 00:06 | |
*** sputnik13 has quit IRC | 00:07 | |
harlowja | ha | 00:11 |
---|---|---|
dims | harlowja: https://review.openstack.org/#/c/205779/ is ready again | 00:14 |
harlowja | cool | 00:14 |
dims | adjusted the test case for a numeric level other than 5 | 00:14 |
harlowja | cools | 00:15 |
harlowja | let's see what happens with that review, ha | 00:15 |
dims | thank you sir | 00:15 |
harlowja | np | 00:16 |
dims | harlowja: getting greedy...i have a quick hit link with a handful of reviews in various oslo projects if you get a chance (http://bit.ly/oslo-quick-hits) | 00:18 |
dims | back in a bit! | 00:18 |
harlowja | sureee | 00:18 |
*** dims has quit IRC | 00:22 | |
*** mtanino_ has joined #openstack-oslo | 00:25 | |
*** mtanino has quit IRC | 00:26 | |
*** tsekiyam_ has joined #openstack-oslo | 00:27 | |
*** tsekiyama has quit IRC | 00:31 | |
*** dims has joined #openstack-oslo | 00:32 | |
*** salv-orlando has joined #openstack-oslo | 00:33 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.log: Define TRACE logging level https://review.openstack.org/205779 | 00:35 |
harlowja | dims soooo does https://github.com/openstack/oslotest/blob/master/oslotest/base.py#L46 get affected by ^ | 00:36 |
harlowja | should that by default now capture TRACE level? | 00:37 |
*** salv-orlando has quit IRC | 00:37 | |
openstackgerrit | Merged openstack/oslo-incubator: Updated from global requirements https://review.openstack.org/206166 | 00:44 |
*** openstackgerrit has quit IRC | 00:46 | |
*** openstackgerrit has joined #openstack-oslo | 00:47 | |
*** zz_dimtruck is now known as dimtruck | 00:49 | |
openstackgerrit | Joshua Harlow proposed openstack/oslotest: Allow TRACE and integer logging levels for 'OS_DEBUG' https://review.openstack.org/206270 | 00:54 |
harlowja | dims perhaps ^ follows your 205779 | 00:54 |
*** kevinbenton has quit IRC | 00:54 | |
harlowja | pretty sure that would also be useful for taskflow tests, since it already uses 5 | 00:55 |
*** kevinbenton has joined #openstack-oslo | 00:57 | |
openstackgerrit | Joshua Harlow proposed openstack/oslotest: Allow TRACE and integer logging levels for 'OS_DEBUG' https://review.openstack.org/206270 | 00:59 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Avoid adding 1 to a failure (if it gets triggered) https://review.openstack.org/206273 | 01:07 |
*** salv-orlando has joined #openstack-oslo | 01:44 | |
*** dimtruck is now known as zz_dimtruck | 01:45 | |
*** salv-orlando has quit IRC | 01:48 | |
*** jlvillal has quit IRC | 01:58 | |
*** jlvillal has joined #openstack-oslo | 01:59 | |
*** tsekiyam_ has quit IRC | 02:03 | |
*** mtanino_ has quit IRC | 02:06 | |
*** stevemar has joined #openstack-oslo | 02:07 | |
*** sigmavirus24 has quit IRC | 02:07 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Extend and improve failure logging (WIP) https://review.openstack.org/205903 | 02:17 |
*** dims has quit IRC | 02:35 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Extend and improve failure logging (WIP) https://review.openstack.org/205903 | 02:37 |
*** sputnik13 has joined #openstack-oslo | 02:44 | |
*** stevemar has quit IRC | 03:01 | |
*** zz_dimtruck is now known as dimtruck | 03:02 | |
*** Kennan2 has quit IRC | 03:20 | |
*** Kennan has joined #openstack-oslo | 03:20 | |
*** stevemar has joined #openstack-oslo | 03:50 | |
*** dimtruck is now known as zz_dimtruck | 03:51 | |
*** stevemar has quit IRC | 03:52 | |
*** jamespage has quit IRC | 04:05 | |
*** harlowja_at_home has joined #openstack-oslo | 04:32 | |
*** rpodolyaka1 has joined #openstack-oslo | 04:48 | |
*** yamahata has joined #openstack-oslo | 04:59 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Extend and improve failure logging https://review.openstack.org/205903 | 05:11 |
*** e0ne has joined #openstack-oslo | 05:14 | |
*** sputnik13 has quit IRC | 05:15 | |
*** harlowja_at_home has quit IRC | 05:32 | |
*** rpodolyaka1 has quit IRC | 05:34 | |
*** ihrachyshka has joined #openstack-oslo | 05:37 | |
*** e0ne has quit IRC | 05:42 | |
*** e0ne has joined #openstack-oslo | 05:44 | |
*** e0ne has quit IRC | 05:51 | |
*** jamielennox is now known as jamielennox|away | 05:52 | |
*** sputnik13 has joined #openstack-oslo | 05:55 | |
*** salv-orlando has joined #openstack-oslo | 05:55 | |
*** e0ne has joined #openstack-oslo | 05:55 | |
*** jamielennox|away is now known as jamielennox | 05:56 | |
*** sputnik13 has quit IRC | 05:57 | |
*** harlowja_at_home has joined #openstack-oslo | 06:04 | |
*** rpodolyaka1 has joined #openstack-oslo | 06:07 | |
*** ozamiatin has joined #openstack-oslo | 06:08 | |
*** e0ne has quit IRC | 06:13 | |
*** ihrachyshka has quit IRC | 06:20 | |
*** ozamiatin has quit IRC | 06:21 | |
*** harlowja_at_home has quit IRC | 06:23 | |
*** jamespage has joined #openstack-oslo | 06:24 | |
*** rpodolyaka1 has quit IRC | 06:34 | |
*** rossella_s has quit IRC | 06:37 | |
*** rossella_s has joined #openstack-oslo | 06:38 | |
*** jamespage_ has joined #openstack-oslo | 06:40 | |
*** nkrinner has joined #openstack-oslo | 06:42 | |
*** rpodolyaka1 has joined #openstack-oslo | 06:46 | |
-openstackstatus- NOTICE: zuul is stuck and about to undergo an emergency restart, please be patient as job results may take a long time | 06:46 | |
*** ChanServ changes topic to "zuul is stuck and about to undergo an emergency restart, please be patient as job results may take a long time" | 06:47 | |
*** jamespage_ has quit IRC | 06:48 | |
*** salv-orlando has quit IRC | 06:59 | |
*** cdent has joined #openstack-oslo | 07:02 | |
*** sdake has joined #openstack-oslo | 07:07 | |
*** achanda has quit IRC | 07:11 | |
*** achanda has joined #openstack-oslo | 07:18 | |
*** ozamiatin has joined #openstack-oslo | 07:23 | |
*** browne has quit IRC | 07:35 | |
*** achanda has quit IRC | 07:35 | |
*** e0ne has joined #openstack-oslo | 07:37 | |
*** rpodolyaka1 has quit IRC | 07:39 | |
*** yamahata has quit IRC | 07:44 | |
*** achanda has joined #openstack-oslo | 07:46 | |
*** salv-orlando has joined #openstack-oslo | 07:50 | |
*** sdake has quit IRC | 07:57 | |
*** achanda has quit IRC | 08:00 | |
*** achanda has joined #openstack-oslo | 08:01 | |
-openstackstatus- NOTICE: zuul has been restarted and queues restored. It may take some time to work through the backlog. | 08:03 | |
*** ChanServ changes topic to "#openstack-oslo" | 08:03 | |
*** achanda has quit IRC | 08:04 | |
*** achanda has joined #openstack-oslo | 08:11 | |
*** ndipanov has quit IRC | 08:12 | |
*** rpodolyaka1 has joined #openstack-oslo | 08:22 | |
*** ihrachyshka has joined #openstack-oslo | 08:28 | |
*** achanda has quit IRC | 08:32 | |
*** alexpilotti has joined #openstack-oslo | 08:34 | |
*** yassine__ has joined #openstack-oslo | 08:40 | |
openstackgerrit | Merged openstack/taskflow: Fix seven typos and one readability on taskflow documentation https://review.openstack.org/205892 | 08:42 |
openstackgerrit | Merged openstack/oslo.service: Activate pep8 check that _ is imported https://review.openstack.org/205309 | 08:43 |
openstackgerrit | Merged openstack/oslo.middleware: Added verbose debug logging to CORS https://review.openstack.org/200715 | 08:47 |
openstackgerrit | Merged openstack/oslo.config: preserve preformatted help text https://review.openstack.org/205708 | 08:48 |
*** achanda has joined #openstack-oslo | 08:51 | |
openstackgerrit | Merged openstack/oslo.service: Allow LoopingCall to continue on exception in callee https://review.openstack.org/193605 | 08:56 |
*** achanda has quit IRC | 09:00 | |
openstackgerrit | Merged openstack/oslotest: Allow TRACE and integer logging levels for 'OS_DEBUG' https://review.openstack.org/206270 | 09:01 |
openstackgerrit | Merged openstack/tooz: No longer need kazoo lock custom retry code https://review.openstack.org/182146 | 09:07 |
*** boris-42 has quit IRC | 09:10 | |
*** ndipanov has joined #openstack-oslo | 09:12 | |
*** achanda has joined #openstack-oslo | 09:17 | |
*** exploreshaifali has joined #openstack-oslo | 09:24 | |
openstackgerrit | Dmitry Tantsur proposed openstack/oslo.log: Set verbose to True and deprecate it https://review.openstack.org/206437 | 09:27 |
*** achanda has quit IRC | 09:33 | |
*** rpodolyaka1 has quit IRC | 09:57 | |
*** haypo has joined #openstack-oslo | 09:57 | |
openstackgerrit | Dmitry Tantsur proposed openstack/oslo.log: Set verbose to True and deprecate it https://review.openstack.org/206437 | 10:14 |
*** dims has joined #openstack-oslo | 10:31 | |
*** salv-orl_ has joined #openstack-oslo | 10:34 | |
*** salv-orlando has quit IRC | 10:37 | |
*** rossella_s has quit IRC | 10:37 | |
*** ruhe has left #openstack-oslo | 10:37 | |
*** rossella_s has joined #openstack-oslo | 10:38 | |
ozamiatin | droyal: hi, i'd like to merge this patch https://review.openstack.org/#/c/204736/ but tests are failing, could you please take look? | 10:40 |
*** salv-orl_ has quit IRC | 10:47 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.db: Fix test_migrations on Python 3 https://review.openstack.org/206476 | 10:50 |
*** salv-orlando has joined #openstack-oslo | 11:00 | |
*** salv-orl_ has joined #openstack-oslo | 11:01 | |
ozamiatin | sdague: around? | 11:04 |
*** salv-orlando has quit IRC | 11:05 | |
ozamiatin | sdague: hi, I need your help with devstack + zmq plugin | 11:05 |
ozamiatin | sdague: I'm running devstack from my forked branch: https://github.com/ozamiatin/devstack you can find stackrc and local.conf modified there | 11:06 |
ozamiatin | sdague: I'm trying to make it choose oslo.messaging feature/zmq branch but it takes old zmq driver anyway | 11:07 |
ozamiatin | sdague: what I'm doing wrong? | 11:08 |
sdague | ozamiatin: you are not specifying gitref | 11:09 |
sdague | gitref - an optional git ref (branch / ref / tag) that will be cloned. Defaults to master. | 11:09 |
sdague | http://docs.openstack.org/developer/devstack/plugins.html | 11:09 |
sdague | also, you'll have to specify branch for oslo.messaging, everything defaults to master | 11:10 |
ozamiatin | sdague: yeah, but gitref relates to plugin repo right? branch for oslo.messaging is specified in stackrc | 11:11 |
ozamiatin | sdague: https://github.com/ozamiatin/devstack/blob/master/stackrc#L362 | 11:12 |
ozamiatin | ozamiatin: I'm still missing something but don't understand what exactly (( | 11:14 |
ozamiatin | sdague: ^^ | 11:14 |
*** rpodolyaka1 has joined #openstack-oslo | 11:14 | |
ozamiatin | sdague: one more thing is that it clones the proper branch to /opt/stack/oslo.messaging but installs the default package | 11:16 |
sdague | ozamiatin: so something else might be installing a thing at a bad time, you'll have to debug that | 11:17 |
ozamiatin | sdague: ok, thanks, I'll try to figure it out | 11:25 |
*** jaosorior has joined #openstack-oslo | 11:37 | |
*** dguitarbite has quit IRC | 11:45 | |
*** kgiusti has joined #openstack-oslo | 12:06 | |
*** gordc has joined #openstack-oslo | 12:11 | |
*** rpodolyaka1 has quit IRC | 12:18 | |
*** rpodolyaka1 has joined #openstack-oslo | 12:18 | |
*** rpodolyaka1 has quit IRC | 12:19 | |
*** tdurakov has joined #openstack-oslo | 12:24 | |
tdurakov | harlowja; hi, are you around? | 12:26 |
dims | tdurakov: he is in the west coast so about 4 hours he'll be here | 12:27 |
tdurakov | dims, ok, thank you | 12:27 |
*** bknudson has joined #openstack-oslo | 12:30 | |
*** stevemar has joined #openstack-oslo | 12:31 | |
*** rpodolyaka1 has joined #openstack-oslo | 12:33 | |
*** rpodolyaka1 has quit IRC | 12:37 | |
*** stevemar has quit IRC | 12:38 | |
*** rpodolyaka1 has joined #openstack-oslo | 12:39 | |
*** ozamiatin has quit IRC | 12:44 | |
*** stevemar has joined #openstack-oslo | 12:45 | |
*** gordc is now known as gordc_meeting | 12:56 | |
*** bknudson has quit IRC | 12:59 | |
*** zz_dimtruck is now known as dimtruck | 13:08 | |
*** amotoki has joined #openstack-oslo | 13:08 | |
*** LimorStotland has joined #openstack-oslo | 13:13 | |
*** prad has joined #openstack-oslo | 13:15 | |
*** ganso_ has joined #openstack-oslo | 13:15 | |
*** zzzeek has joined #openstack-oslo | 13:17 | |
*** browne has joined #openstack-oslo | 13:19 | |
*** bknudson has joined #openstack-oslo | 13:20 | |
*** dguitarbite has joined #openstack-oslo | 13:28 | |
*** dguitarbite is now known as Guest11859 | 13:28 | |
*** stevemar has quit IRC | 13:50 | |
*** mriedem_away is now known as mriedem | 13:53 | |
*** sigmavirus24_awa has joined #openstack-oslo | 13:57 | |
*** stevemar has joined #openstack-oslo | 13:57 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:57 | |
*** rpodolyaka2 has joined #openstack-oslo | 14:02 | |
*** rpodolyaka1 has quit IRC | 14:02 | |
*** stevemar has quit IRC | 14:02 | |
*** yamahata has joined #openstack-oslo | 14:09 | |
*** boris-42 has joined #openstack-oslo | 14:10 | |
*** jecarey_ has joined #openstack-oslo | 14:14 | |
*** ozamiatin has joined #openstack-oslo | 14:15 | |
*** tsekiyama has joined #openstack-oslo | 14:21 | |
*** Guest11859 has quit IRC | 14:23 | |
*** jaypipes has joined #openstack-oslo | 14:29 | |
*** yamahata has quit IRC | 14:33 | |
*** rossella_s has quit IRC | 14:37 | |
*** rossella_s has joined #openstack-oslo | 14:37 | |
*** stevemar has joined #openstack-oslo | 14:38 | |
*** stevemar has quit IRC | 14:46 | |
*** rpodolyaka2 has quit IRC | 14:49 | |
*** rpodolyaka1 has joined #openstack-oslo | 14:49 | |
*** stevemar has joined #openstack-oslo | 14:54 | |
*** sdake has joined #openstack-oslo | 14:55 | |
*** achanda has joined #openstack-oslo | 14:56 | |
*** rpodolyaka1 has quit IRC | 14:58 | |
*** rpodolyaka1 has joined #openstack-oslo | 15:01 | |
*** rpodolyaka1 has quit IRC | 15:06 | |
*** rpodolyaka1 has joined #openstack-oslo | 15:07 | |
*** achanda has quit IRC | 15:09 | |
*** nkrinner has quit IRC | 15:10 | |
*** eezhova has quit IRC | 15:10 | |
*** eezhova has joined #openstack-oslo | 15:10 | |
*** gordc_meeting has quit IRC | 15:12 | |
*** mtanino has joined #openstack-oslo | 15:18 | |
*** exploreshaifali has quit IRC | 15:21 | |
*** browne has quit IRC | 15:32 | |
*** sdake has quit IRC | 15:35 | |
*** stevemar has quit IRC | 15:44 | |
*** gordc has joined #openstack-oslo | 15:45 | |
*** ozamiatin has quit IRC | 15:46 | |
*** alexpilotti has quit IRC | 15:47 | |
zzzeek | jd__: hey want to confirm gnocchi only makes *one* SQLAlchemyIndexer for a Python process, not for every request, right? | 15:50 |
openstackgerrit | Marian Horban proposed openstack/oslo.service: [WIP] Added class SignalHandler https://review.openstack.org/204972 | 16:02 |
*** ihrachyshka has quit IRC | 16:06 | |
*** ashleighfarnham has joined #openstack-oslo | 16:12 | |
*** ashleighfarnham has quit IRC | 16:16 | |
*** ashleighfarnham has joined #openstack-oslo | 16:17 | |
*** cdent has quit IRC | 16:18 | |
*** e0ne has quit IRC | 16:20 | |
*** LimorStotland has quit IRC | 16:20 | |
*** sdake has joined #openstack-oslo | 16:22 | |
*** browne has joined #openstack-oslo | 16:25 | |
*** rpodolyaka1 has quit IRC | 16:25 | |
jd__ | zzzeek: yes! | 16:39 |
*** dims has quit IRC | 16:52 | |
*** dims has joined #openstack-oslo | 16:52 | |
*** dims has quit IRC | 16:52 | |
*** dims has joined #openstack-oslo | 16:53 | |
tdurakov | is there any way to change value provided by store params in taskflow.engines.run? | 16:53 |
*** jaypipes has quit IRC | 16:54 | |
*** jaypipes has joined #openstack-oslo | 16:55 | |
tdurakov | here is snippet: http://paste.openstack.org/show/406108/ | 16:55 |
dims | harlowja: ^^^ | 16:56 |
*** haypo has left #openstack-oslo | 16:57 | |
*** ihrachyshka has joined #openstack-oslo | 16:59 | |
*** exploreshaifali has joined #openstack-oslo | 17:04 | |
*** sputnik13 has joined #openstack-oslo | 17:07 | |
*** jamespage_ has joined #openstack-oslo | 17:09 | |
*** jamespage_ has quit IRC | 17:18 | |
*** rpodolyaka1 has joined #openstack-oslo | 17:19 | |
*** rpodolyaka1 has quit IRC | 17:20 | |
*** boris-42 has quit IRC | 17:20 | |
*** stevemar has joined #openstack-oslo | 17:21 | |
*** jamespage_ has joined #openstack-oslo | 17:22 | |
*** boris-42 has joined #openstack-oslo | 17:22 | |
*** jamespage_ has quit IRC | 17:34 | |
*** yassine__ has quit IRC | 17:36 | |
*** achanda has joined #openstack-oslo | 17:42 | |
*** amotoki has quit IRC | 17:48 | |
openstackgerrit | Thang Pham proposed openstack/oslo.versionedobjects: Make direct call to object's obj_from_primitive https://review.openstack.org/206637 | 17:50 |
*** rpodolyaka1 has joined #openstack-oslo | 17:58 | |
*** mriedem is now known as mriedem_meeting | 18:00 | |
harlowja | i am around, was in meeting | 18:01 |
*** achanda has quit IRC | 18:02 | |
*** achanda has joined #openstack-oslo | 18:02 | |
harlowja | tdurakov whats up | 18:03 |
harlowja | tdurakov ah, change stored params, hmmm | 18:04 |
harlowja | yes that shoudl be possible, if u do it before run, using the load() call instead | 18:10 |
harlowja | <<< e = engines.load(f) | 18:10 |
harlowja | <<< e.prepare() | 18:10 |
harlowja | <<< e.storage.<do things with storage> | 18:10 |
harlowja | then | 18:10 |
harlowja | <<< e.run() | 18:10 |
harlowja | tdurakov ^ | 18:10 |
*** sputnik13 has quit IRC | 18:13 | |
*** sputnik13 has joined #openstack-oslo | 18:14 | |
openstackgerrit | lifeless proposed openstack-dev/pbr: Export ChangeLog and AUTHORS in install https://review.openstack.org/202339 | 18:19 |
lifeless | harlowja: care to eyeball ^ its two weeks old now, and getting it in a release is blocking getting current docs for mock on rtd | 18:21 |
harlowja | lifeless checking, thats cool, fixes i think the need for some files i have setup | 18:37 |
*** rossella_s has quit IRC | 18:37 | |
harlowja | ie https://github.com/openstack/taskflow/blob/master/ChangeLog (which if it doesn't exist, will cause sphinx to say WTFmate) | 18:37 |
*** rossella_s has joined #openstack-oslo | 18:38 | |
*** stevemar has quit IRC | 18:48 | |
*** rpodolyaka1 has quit IRC | 18:49 | |
harlowja | lifeless all done | 18:51 |
harlowja | lifeless let me know if u think i can then remove https://github.com/openstack/taskflow/blob/master/ChangeLog | 18:51 |
harlowja | pretty sure i can after that, but will try | 18:51 |
lifeless | i thunk so | 18:51 |
harlowja | cool | 18:52 |
harlowja | thunks | 18:52 |
harlowja | *not those kind of thunks* | 18:52 |
harlowja | lol | 18:52 |
harlowja | nm | 18:52 |
*** ozamiatin has joined #openstack-oslo | 18:56 | |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Support using the version manifest for obj_make_compatible() https://review.openstack.org/206657 | 18:59 |
*** e0ne has joined #openstack-oslo | 19:03 | |
*** rpodolyaka1 has joined #openstack-oslo | 19:05 | |
*** zzzeek has quit IRC | 19:06 | |
*** zzzeek has joined #openstack-oslo | 19:08 | |
harlowja | bknudson ok, will fix up those debtcollector stuff, as for the moved module attribute, that one i'm not entirely sure about :-P | 19:11 |
harlowja | possibly http://wrapt.readthedocs.org/en/latest/wrappers.html#object-proxy but not sure | 19:11 |
harlowja | to much crap can happen with random module properties | 19:12 |
bknudson | harlowja: that would be cool | 19:12 |
harlowja | bknudson like just accessing the property would warn? | 19:12 |
harlowja | or performing actions on the module attribute/property | 19:12 |
harlowja | or all the above :-P | 19:12 |
bknudson | I'd expect a warning if I had any code that did module1.HTTPClient | 19:13 |
bknudson | where HTTPClient had been renamed to Client or something | 19:13 |
bknudson | or HTTPClient had been removed | 19:14 |
harlowja | ya, thats accessing it, thats tough i think | 19:14 |
harlowja | but might be wrong, idk | 19:15 |
bknudson | you'd need to make module different so you can override getattr | 19:15 |
bknudson | I could have sworn I found an example somewhere | 19:16 |
*** exploreshaifali has quit IRC | 19:21 | |
*** mriedem_meeting is now known as mriedem | 19:27 | |
*** ozamiatin has quit IRC | 19:29 | |
*** tdurakov_ has joined #openstack-oslo | 19:31 | |
tdurakov_ | harlowja, ping | 19:33 |
harlowja | tdurakov_ whats up | 19:33 |
harlowja | bknudson ya, making the full module different just to change one attribute == scary, lol | 19:34 |
tdurakov_ | thanks for response) | 19:34 |
harlowja | np! | 19:34 |
bknudson | maybe it's used for lazy loading of imports? | 19:35 |
bknudson | e.g., http://git.openstack.org/cgit/openstack/python-keystoneclient/tree/keystoneclient/__init__.py#n52 | 19:35 |
tdurakov_ | http://paste.openstack.org/show/406108/ - look, if you run this snippet in execute of B task would be printed 'hello world' while i expected to see 'new param' as a result of A task execution | 19:36 |
tdurakov_ | harlowja^ | 19:36 |
bknudson | I don't know how I'd print out a warning for use of a renamed constant? | 19:37 |
bknudson | so I guess all I can do is docstring | 19:37 |
harlowja | tdurakov soooo, ya, i know whats up there | 19:37 |
tdurakov_ | and another question: is there any 'if/else' type flows in taskflow? | 19:37 |
harlowja | tdurakov http://docs.openstack.org/developer/taskflow/engines.html#scoping (so the param lookup is preferring the injected stuff) | 19:38 |
harlowja | which is the 'store={'param': 'hello world'}' | 19:38 |
harlowja | #3 and #4 in that scoping rule list | 19:38 |
harlowja | i've considered changing that, but it will break to many people | 19:38 |
harlowja | tdurakov http://paste.openstack.org/show/406132/ | 19:39 |
harlowja | try that | 19:39 |
harlowja | alters the start name, to be different | 19:39 |
tdurakov_ | harlowja: it would work:) | 19:40 |
lifeless | bknudson: you can but its very evil | 19:40 |
harlowja | tdurakov_ as for 'if else' there is somewhat like that, its not the same kind of if/else u would normally think of | 19:41 |
lifeless | bknudson: replace the module during import with a rich object that has __getattribute__ or __getattr__ and issues deprecation warnings | 19:41 |
harlowja | tdurakov_ https://github.com/openstack/taskflow/blob/master/taskflow/examples/switch_graph_flow.py | 19:41 |
harlowja | its called 'switches' | 19:41 |
bknudson | lifeless: do you have an example? | 19:41 |
tdurakov_ | i saw your patch) | 19:41 |
tdurakov_ | is there any way to get flow context vars in decider method? | 19:42 |
tdurakov_ | also to implement `if/else` i need 2 decider method one for each node, it seems strange | 19:42 |
tdurakov_ | harlowja^ | 19:43 |
harlowja | tdurakov_ flow programming is sorta different like this, although i'm def willing to see how to make it better | 19:43 |
harlowja | as for flow context vars, not currently, could be added | 19:43 |
tdurakov_ | ++ for context vars | 19:43 |
harlowja | or just providing the storage object to decider methods, ha | 19:44 |
harlowja | probably more flexible that way | 19:44 |
harlowja | then u lookup wahtever u want | 19:44 |
bknudson | here's an example from stackoverflow: http://stackoverflow.com/questions/2447353/getattr-on-a-module | 19:44 |
tdurakov_ | sure, anyway it would be more flexible) | 19:45 |
bknudson | I'm going to try it just to see what it looks like | 19:45 |
openstackgerrit | Thang Pham proposed openstack/oslo.versionedobjects: Fix ComparableVersionedObject in python 3.4 https://review.openstack.org/206679 | 19:45 |
tdurakov_ | <harlowja> tdurakov_ flow programming is sorta different like this, although i'm def willing to see how to make it better - what about new method with u,v,w, decider params | 19:46 |
*** ozamiatin has joined #openstack-oslo | 19:47 | |
harlowja | tdurakov_ hmmm how would that differ from what exists? | 19:47 |
tdurakov_ | where u - parent node, v,w - children and decider selects one from them | 19:47 |
tdurakov_ | it could be extended to the list of children | 19:47 |
tdurakov_ | harlowja, what do you think? | 19:47 |
harlowja | hmmm | 19:48 |
harlowja | thats buildable with the current stuff right? | 19:48 |
lifeless | bknudson: no :) its evil. | 19:48 |
harlowja | tdurakov although somewhat painful i guess | 19:48 |
lifeless | bknudson: do we really need to do that ? | 19:48 |
lifeless | bknudson: and yes - that stackoverflow | 19:49 |
tdurakov_ | yeah, there is a lot of overhead for this now | 19:49 |
harlowja | tdurakov maybe then just some utility helper functions vs new method? | 19:49 |
bknudson | lifeless: use warnings.warn() when using a constant that we're going to remove? | 19:49 |
tdurakov_ | if you decide to override link method you wouldn't break current api | 19:50 |
tdurakov_ | bu give a lot of flexibility for you lib users:) | 19:50 |
tdurakov_ | *but | 19:50 |
harlowja | hmmmm, tdurakov maybe u want to throw together an example, might make it more clear | 19:50 |
harlowja | sputnik13 ^ | 19:50 |
lifeless | bknudson: thats the use case, but do we need it badly enough to do the shenanigans involved? | 19:50 |
sputnik13 | ?? | 19:51 |
bknudson | lifeless: probably not | 19:51 |
harlowja | sputnik13 and the octavia people def wanted that decider tdurakov , so maybe they have some thoughts to | 19:51 |
tdurakov_ | harlowja, sure | 19:51 |
lifeless | bknudson: I mean, its a constant. we could leave it there forever with approximately zero cost. | 19:51 |
sputnik13 | oh | 19:51 |
harlowja | sputnik13 check backlog | 19:51 |
harlowja | decider stuff | 19:51 |
sputnik13 | kk | 19:51 |
harlowja | u probably interested in, i forget the other octavia people to, tdurakov but def maybe a simple POC would help | 19:51 |
lifeless | bknudson: probably more important would be to introduce a coding style guideline not to do module level constants | 19:51 |
bknudson | lifeless: the docstring should be adequate... also, I agree that we can just leave it. | 19:51 |
lifeless | [except if they reallllly will be forever] | 19:52 |
harlowja | foreverrr! | 19:52 |
harlowja | lol | 19:52 |
bknudson | lifeless: I like having the guideline since we've got a reason not to do it. | 19:52 |
tdurakov_ | ok, i'll create poc for that:) | 19:52 |
tdurakov_ | harlowja^ | 19:52 |
harlowja | tdurakov if we can just build ontop of the current link() method somehow, that'd be cool, making a helper that glues stuff together in a nice way would be cool | 19:52 |
harlowja | tdurakov great :) | 19:52 |
tdurakov_ | i'll push wip patch to gerrit and add you as reviewer | 19:53 |
harlowja | tdurakov great, and sputnik13 cause i'm sure he's interested :-P | 19:54 |
harlowja | anddd tdurakov maybe some of the folks in #openstack-lbaas (the octavia folks) | 19:56 |
tdurakov_ | kk, about scoping stuff, here is usecase from nova, i need to check 2 hosts in flow. i create class for this, initial check is made from host variable i pass in `store` dict to run method, few tasks later i need to run this again but with another host. | 19:56 |
harlowja | ya, tdurakov i'm thinking we might want to make it optional changeable, so that storage stuff is prefered 'last' | 19:57 |
harlowja | so storage provided values are more like 'global' scope | 19:57 |
harlowja | vs what it is now | 19:57 |
harlowja | ie instead of 1.. 6 http://docs.openstack.org/developer/taskflow/engines.html#scoping | 19:57 |
tdurakov_ | similiar to snippet i've send. scoping seems reasonable, but here is one thing to add | 19:57 |
harlowja | it could be | 19:58 |
harlowja | 1. | 19:58 |
harlowja | 2. | 19:58 |
harlowja | 5. | 19:58 |
harlowja | 6. | 19:58 |
harlowja | 3. | 19:58 |
harlowja | 4. | 19:58 |
harlowja | vs 1...6 | 19:58 |
harlowja | could make that selectable i guess | 19:58 |
harlowja | but don't want people to shoot themselves, lol | 19:58 |
harlowja | (cause people will always try to, lol) | 19:59 |
tdurakov_ | r = taskflow.engines.run(flow, store={'param': 'hello world'}) - r would be a a set of all values('hello world', 'new_param', 'c_param') | 19:59 |
harlowja | r? | 19:59 |
harlowja | oh | 19:59 |
harlowja | gotcha | 19:59 |
harlowja | yes, thats possible | 20:00 |
harlowja | vs the collapsed values its right now | 20:00 |
harlowja | *collapsed/flattened | 20:00 |
harlowja | https://github.com/openstack/taskflow/blob/master/taskflow/storage.py#L873 (can be provided a custom flattening function) | 20:01 |
harlowja | tdurakov ^ | 20:01 |
harlowja | right now as u see, it selects last | 20:01 |
harlowja | *first i mean, ha | 20:01 |
harlowja | but anyway, improvements welcome :) | 20:02 |
bknudson | lifeless: harlowja: here's an example https://review.openstack.org/#/c/205833/3/keystoneclient/httpclient.py | 20:02 |
tdurakov_ | instead of changing scope order we could return all possible values:) not sure this is good idea, configurable scope ordering seems better one:) | 20:02 |
harlowja | tdurakov could be either, i'm not sure either, scope ordering is really a 'advanced' feature (not sure how many people would have any idea wtf that is, lol) | 20:03 |
harlowja | ya, USER_AGENT global :( | 20:03 |
harlowja | bknudson sad face, lol | 20:03 |
harlowja | with proxy, hmmm | 20:03 |
lifeless | bknudson: that is how you do it | 20:03 |
tdurakov_ | harlowja, ok, thank you Joshua!:) | 20:04 |
harlowja | tdurakov_ lots of things we can try :) | 20:04 |
lifeless | bknudson: but still, evil | 20:04 |
harlowja | tdurakov_ are u working on nova stuff + taskflow + possiblities?? | 20:04 |
harlowja | (out of curosity) | 20:04 |
tdurakov_ | yep) | 20:04 |
harlowja | niceeee | 20:04 |
harlowja | +200 | 20:04 |
harlowja | :-P | 20:05 |
harlowja | tdurakov_ i can throw some kind of scoping order tweaking patch up | 20:05 |
*** alexpilotti has joined #openstack-oslo | 20:06 | |
harlowja | tdurakov_ https://review.openstack.org/#/c/187376/ refactors part of that, so that will make it easier to do this kind of stuff (if we want) | 20:06 |
harlowja | https://review.openstack.org/#/c/187376/ should make it 'cleaner' | 20:06 |
harlowja | *imho* | 20:06 |
harlowja | not perfect still, but cleaner :) | 20:06 |
tdurakov_ | harlowja, it would be great) | 20:07 |
harlowja | *never perfect!* :) | 20:07 |
harlowja | tdurakov_ cools | 20:07 |
openstackgerrit | Merged openstack-dev/pbr: Export ChangeLog and AUTHORS in install https://review.openstack.org/202339 | 20:07 |
harlowja | bknudson lifeless so ya, idk, should debtcollector provide such a pattern, unsure | 20:09 |
harlowja | i'll let u guys figure that out, i did my 5 patches , lol | 20:09 |
lifeless | I dunno | 20:11 |
lifeless | its just an awfully heavy hammer | 20:11 |
*** kgiusti has left #openstack-oslo | 20:11 | |
lifeless | probably ok... | 20:11 |
*** alexpilotti has quit IRC | 20:12 | |
*** dimtruck is now known as zz_dimtruck | 20:12 | |
*** e0ne has quit IRC | 20:19 | |
*** jaypipes has quit IRC | 20:20 | |
*** e0ne has joined #openstack-oslo | 20:21 | |
*** e0ne has quit IRC | 20:21 | |
*** mtanino has quit IRC | 20:23 | |
*** salv-orlando has joined #openstack-oslo | 20:31 | |
*** jaypipes has joined #openstack-oslo | 20:31 | |
*** haypo has joined #openstack-oslo | 20:32 | |
haypo | dhellmann: hi. could you please approved https://review.openstack.org/#/c/200416/ again (dnspython3)? | 20:33 |
haypo | dhellmann: i'm working on porting Swift to Python 3, and dnspython3 will help | 20:34 |
*** salv-orl_ has quit IRC | 20:34 | |
haypo | dhellmann, lifeless: FYI swift is still stuck at pbr < 1.0 because they still use hacking 0.8. i'm working on a patch to upgrade hacking to 0.10: https://review.openstack.org/#/c/205977/ | 20:35 |
lifeless | haypo: thanks | 20:35 |
haypo | lifeless: oh i didn't check before for pbr | 20:37 |
haypo | lifeless: i just checked: it's now possible to use pbr 1.3 | 20:37 |
haypo | lifeless: so i will be able to use environment markers in requirements to install dnspython3 on python 3, and dnspython on python 2 | 20:37 |
haypo | lifeless: are you now a core reviewer on requirements too? | 20:38 |
lifeless | I am | 20:38 |
haypo | lifeless: oh, i have a new victim to harass to get a review :) | 20:39 |
haypo | lifeless: hello! could you please review https://review.openstack.org/#/c/200416/ ? :-D | 20:39 |
*** ganso_ has quit IRC | 20:40 | |
*** mtanino has joined #openstack-oslo | 20:41 | |
lifeless | haypo: done (-2) :) | 20:41 |
haypo | lifeless: why not using "python_version < '3'" in global requirements instead of "python_version=='2.7' or python_version=='2.6'" or "python_version=='2.7'" | 20:41 |
*** gordc has quit IRC | 20:41 | |
haypo | lifeless: oh. i wasn't aware of https://review.openstack.org/#/c/196633/ | 20:42 |
*** alexpilotti has joined #openstack-oslo | 20:42 | |
haypo | it occurs me more and more often than i write a duplicate patch | 20:42 |
haypo | it's strange. why do people don't warn me that they are also working on python3? | 20:43 |
haypo | lifeless: ah! this patch uses python_version<'3.0' and python_version>='3.0' :-) | 20:43 |
haypo | by why not adding a space after ';' for readability? | 20:43 |
lifeless | haypo: I don't think it adds or removes anything | 20:44 |
haypo | lifeless: it adds readability | 20:46 |
lifeless | we don't anywhere else in the file | 20:47 |
lifeless | if we're going to say we care about this, we should auto-format it for folk | 20:47 |
lifeless | I'm not going to -1 a patch for being consistent with the current file | 20:47 |
haypo | lifeless: i voted +1 on https://review.openstack.org/#/c/196633/ | 20:48 |
haypo | lifeless: i'm not going to nitpick on this one, it blocks me a long chain of patches on swift :) | 20:49 |
haypo | dnspython3 (req) => hacking 0.10 (swift) => fix tox -e py34 (swift) | 20:50 |
haypo | it's amazing how much things i had to modify to add the most basic support of python 3 in swift | 20:51 |
*** alexpilotti has quit IRC | 20:52 | |
lifeless | yup | 20:57 |
*** rpodolyaka1 has quit IRC | 21:02 | |
*** jaypipes has quit IRC | 21:04 | |
openstackgerrit | Timofey Durakov proposed openstack/taskflow: .gitignore update https://review.openstack.org/206697 | 21:06 |
*** rpodolyaka1 has joined #openstack-oslo | 21:07 | |
*** rpodolyaka1 has quit IRC | 21:08 | |
lifeless | zzzeek: https://review.openstack.org/#/c/205201/ | 21:18 |
lifeless | zzzeek: I want to make sure you're not blocked: you're editing the wrong file in that proposal | 21:18 |
zzzeek | lifeless: so you said. did you see my response? | 21:19 |
zzzeek | ah you have one. let me read | 21:19 |
zzzeek | lifeless: so. i dont want to “require” this version. I just want it to be installable. otherwise, why does global-requirements have any < > signs at all? why not make it 100% “===“ signs ? | 21:20 |
zzzeek | lifeless: what is the point to having *two* files ? | 21:20 |
openstackgerrit | Joshua Harlow proposed openstack/debtcollector: Expose a top level 'deprecate' function https://review.openstack.org/206262 | 21:21 |
lifeless | zzzeek: if we pin in our releases we get deadlocked because we can't shift the version of anything | 21:22 |
lifeless | zzzeek: so we can't pin releases - and the tools that interact with PyPI are not designed to deal with hard-pins except in rare cases | 21:23 |
lifeless | e.g. if lots of things on PyPI have hard pins and upper bounds, dep resolution becomes ridiculously hard - its NP | 21:24 |
lifeless | zzzeek: but for CI stability we need insulation from releases, both of our code and of other code | 21:24 |
zzzeek | lifeless: but this upper-bounds file *is* an upper bound | 21:24 |
*** tdurakov_ has quit IRC | 21:24 | |
lifeless | zzzeek: and thus we have a separate file that is *not* reflected into setuptools metadata, that defines an exact set of packages that works | 21:25 |
lifeless | zzzeek: for CI. | 21:25 |
zzzeek | basiaclly what youre saying is, every time I release a new SQLAlchemy as 1.0.x that fixes something for an openstack app, we need to bump global reqiuresments to “sqlalchemy >1.0.X < 1.1.0”. it’s basically a hard pin | 21:25 |
lifeless | zzzeek: I am confused. You say that there is a bug fixed in 1.0.8 that affects everyone | 21:25 |
zzzeek | lifeless: it is a scalability improvement | 21:26 |
zzzeek | lifeless: certain errors ppl getting in their logs are alleviated | 21:26 |
lifeless | so, generally speaking you don't need to do anything. the proposal bot will. | 21:26 |
lifeless | e.g. https://review.openstack.org/#/c/206650/ | 21:26 |
lifeless | it recalculates whats installable and proposes it as a merge | 21:26 |
zzzeek | lifeless: great | 21:27 |
zzzeek | lifeless: so then I can abandon my thing :) | 21:27 |
lifeless | it was broken due to some infray things for a little bit | 21:27 |
lifeless | but its fixed again now | 21:27 |
lifeless | yes, I think you can. | 21:27 |
zzzeek | lifeless: ah. in which case i never would have seen the 1.0.6 being stuck and wouldnt have even been trying to do this :) | 21:28 |
lifeless | when the bot's proposed changes fail, it generally means something broke upstream and we need to blacklist a version (temporarily while we adjust, or permanently while they rectify) | 21:28 |
*** BAKfr has quit IRC | 21:30 | |
lifeless | fungi: https://review.openstack.org/#/c/203358/ +2A please | 21:31 |
*** BAKfr has joined #openstack-oslo | 21:36 | |
*** jamespage_ has joined #openstack-oslo | 21:38 | |
openstackgerrit | Merged openstack/taskflow: Remove legacy py2.6 backwards logging compat. code https://review.openstack.org/203441 | 21:40 |
*** jamespage_ has quit IRC | 21:40 | |
*** jaosorior has quit IRC | 21:41 | |
*** dims has quit IRC | 21:42 | |
*** gordc has joined #openstack-oslo | 21:42 | |
*** mriedem has quit IRC | 21:54 | |
*** bknudson has quit IRC | 21:59 | |
*** dims has joined #openstack-oslo | 22:02 | |
*** jecarey_ has quit IRC | 22:08 | |
*** zz_dimtruck is now known as dimtruck | 22:13 | |
*** gordc has quit IRC | 22:31 | |
*** ihrachyshka has quit IRC | 22:37 | |
*** rossella_s has quit IRC | 22:37 | |
*** rossella_s has joined #openstack-oslo | 22:37 | |
*** mriedem has joined #openstack-oslo | 22:47 | |
*** zzzeek has quit IRC | 22:56 | |
*** dims has quit IRC | 23:05 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:07 | |
*** dimtruck is now known as zz_dimtruck | 23:14 | |
openstackgerrit | Joshua Harlow proposed openstack/debtcollector: Add a 'removed_property' property https://review.openstack.org/206253 | 23:17 |
*** xek has quit IRC | 23:18 | |
*** xek has joined #openstack-oslo | 23:20 | |
*** dims has joined #openstack-oslo | 23:34 | |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Allow providing a callback to certain executors to reject new work https://review.openstack.org/205262 | 23:41 |
*** zz_dimtruck is now known as dimtruck | 23:42 | |
openstackgerrit | Joshua Harlow proposed openstack/futurist: Allow providing a callback to certain executors to reject new work https://review.openstack.org/205262 | 23:47 |
*** salv-orlando has quit IRC | 23:52 | |
*** sdake has quit IRC | 23:56 | |
*** ozamiatin has quit IRC | 23:58 | |
*** ozamiatin has joined #openstack-oslo | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!