Tuesday, 2015-10-06

openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Add warnings for deprecated IndirectionAPI methods  https://review.openstack.org/22486300:00
*** geoffarnold has quit IRC00:00
*** geoffarn_ has joined #openstack-oslo00:00
openstackgerritEric Brown proposed openstack/oslo.config: Add PortOpt for integer with range 1 to 65535  https://review.openstack.org/23125700:05
openstackgerritMerged openstack/automaton: Added code coverage section to tox  https://review.openstack.org/23109100:13
*** zz_dimtruck is now known as dimtruck00:16
*** tsekiyama has quit IRC00:17
openstackgerritJoshua Harlow proposed openstack/taskflow: Fix bad sphinx module reference  https://review.openstack.org/23125900:17
openstackgerritJoshua Harlow proposed openstack/taskflow: Have decider base class take atom and increase docstring usefulness  https://review.openstack.org/23125100:18
*** tsekiyama has joined #openstack-oslo00:18
*** geoffarn_ has quit IRC00:20
*** takedakn has joined #openstack-oslo00:21
*** geoffarnold has joined #openstack-oslo00:21
*** achanda has joined #openstack-oslo00:21
*** takedakn has quit IRC00:28
*** mtanino has quit IRC00:29
openstackgerritJoshua Harlow proposed openstack-dev/pbr: Escape some of the changelog RST messages  https://review.openstack.org/22756600:30
openstackgerritJoshua Harlow proposed openstack-dev/pbr: Ensure changelog complete is written even if it already exists  https://review.openstack.org/23126800:35
*** tsekiyama has quit IRC00:36
*** sputnik13 has quit IRC00:39
*** geoffarn_ has joined #openstack-oslo00:42
*** geoffarnold has quit IRC00:46
*** dims_ has joined #openstack-oslo00:50
*** dimtruck is now known as zz_dimtruck00:54
*** zz_dimtruck is now known as dimtruck00:55
*** dims_ has quit IRC00:55
*** browne has quit IRC00:57
openstackgerritMasaki Matsushita proposed openstack/oslo.config: Add URIOpt  https://review.openstack.org/22841400:58
*** dims_ has joined #openstack-oslo00:58
*** Guest71307 has quit IRC01:02
*** geoffarn_ has quit IRC01:03
*** geoffarnold has joined #openstack-oslo01:04
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add failure remoting best-of-breed spec (WIP)  https://review.openstack.org/22919401:13
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add failure remoting best-of-breed spec (WIP)  https://review.openstack.org/22919401:16
*** dimtruck is now known as zz_dimtruck01:21
*** haigang has joined #openstack-oslo01:22
*** haigang has quit IRC01:24
*** geoffarnold has quit IRC01:24
*** geoffarnold has joined #openstack-oslo01:25
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add failure remoting best-of-breed spec (WIP)  https://review.openstack.org/22919401:25
*** dims_ has quit IRC01:30
openstackgerritJoshua Harlow proposed openstack/oslo-specs: Add failure remoting best-of-breed spec (WIP)  https://review.openstack.org/22919401:34
*** mriedem_away has quit IRC01:35
*** tsekiyama has joined #openstack-oslo01:37
*** ViswaV_ has quit IRC01:41
*** tsekiyama has quit IRC01:42
openstackgerritMerged openstack/oslo.messaging: Updated from global requirements  https://review.openstack.org/23124001:44
*** geoffarn_ has joined #openstack-oslo01:46
*** geoffarnold has quit IRC01:46
*** stevemar_ has quit IRC01:59
*** stevemar_ has joined #openstack-oslo02:00
*** geoffarn_ has quit IRC02:07
*** geoffarnold has joined #openstack-oslo02:07
*** vilobhmm11 has quit IRC02:09
*** amrith is now known as _amrith_02:10
*** rlrossit has joined #openstack-oslo02:13
*** rlrossit has quit IRC02:13
*** yamahata has quit IRC02:15
*** geoffarnold has quit IRC02:26
*** browne has joined #openstack-oslo02:26
*** geoffarnold has joined #openstack-oslo02:29
*** stevemar_ has quit IRC02:41
*** stevemar_ has joined #openstack-oslo02:42
*** stevemar_ has quit IRC02:43
*** stevemar_ has joined #openstack-oslo02:43
*** sdake has joined #openstack-oslo02:49
*** achanda has quit IRC02:50
*** jamielennox has quit IRC02:51
*** vilobhmm11 has joined #openstack-oslo03:08
*** sdake has quit IRC03:09
*** sdake has joined #openstack-oslo03:10
*** vilobhmm111 has joined #openstack-oslo03:11
*** geoffarn_ has joined #openstack-oslo03:11
*** geoffarnold has quit IRC03:12
*** vilobhmm11 has quit IRC03:12
*** jamielennox has joined #openstack-oslo03:13
*** sdake has quit IRC03:13
*** harlowja_at_home has joined #openstack-oslo03:15
*** vilobhmm111 has quit IRC03:15
*** stevemar_ has quit IRC03:21
*** stevemar_ has joined #openstack-oslo03:22
*** vilobhmm11 has joined #openstack-oslo03:25
*** sdake has joined #openstack-oslo03:33
*** vilobhmm11 has quit IRC03:35
*** links has joined #openstack-oslo03:48
*** geoffarn_ has quit IRC03:53
*** geoffarnold has joined #openstack-oslo03:54
*** pballand_ has joined #openstack-oslo04:08
*** pballand has quit IRC04:10
*** pballand_ is now known as pballand04:10
*** geoffarnold has quit IRC04:14
*** harlowja_at_home has quit IRC04:15
*** geoffarnold has joined #openstack-oslo04:15
*** banix has quit IRC04:31
*** browne has quit IRC04:32
*** browne has joined #openstack-oslo04:32
*** geoffarn_ has joined #openstack-oslo04:36
*** amotoki has joined #openstack-oslo04:38
*** geoffarnold has quit IRC04:40
*** achanda has joined #openstack-oslo04:42
*** dims_ has joined #openstack-oslo04:46
*** geoffarn_ has quit IRC04:57
*** geoffarnold has joined #openstack-oslo04:58
*** subscope has joined #openstack-oslo05:01
*** morgan has quit IRC05:02
*** mhorban has quit IRC05:02
*** redrobot has quit IRC05:03
*** sdague has quit IRC05:03
*** tristanC has quit IRC05:04
*** tristanC has joined #openstack-oslo05:05
*** morgan has joined #openstack-oslo05:06
*** sdague has joined #openstack-oslo05:08
*** redrobot has joined #openstack-oslo05:08
*** redrobot is now known as Guest2867805:09
*** sdake_ has joined #openstack-oslo05:09
openstackgerritJoshua Harlow proposed openstack/taskflow: Use 'match_type' utility function instead of staticmethod  https://review.openstack.org/23130905:10
*** mhorban has joined #openstack-oslo05:10
*** geoffarnold has quit IRC05:11
*** droyal has quit IRC05:11
*** sdake has quit IRC05:13
*** vilobhmm11 has joined #openstack-oslo05:15
*** geoffarnold has joined #openstack-oslo05:19
*** yamahata has joined #openstack-oslo05:27
openstackgerritMerged openstack/oslo.service: Cleanup thread on thread done callback  https://review.openstack.org/22917105:29
*** sdake_ has quit IRC05:38
*** geoffarnold has quit IRC06:00
*** geoffarnold has joined #openstack-oslo06:02
*** e0ne has joined #openstack-oslo06:22
*** e0ne has quit IRC06:30
*** stevemar_ has quit IRC06:38
*** nkrinner has joined #openstack-oslo06:41
*** jamielennox is now known as jamielennox|away06:41
*** x3k has quit IRC06:42
*** geoffarnold has quit IRC06:43
*** geoffarnold has joined #openstack-oslo06:43
*** johnsom_ has quit IRC06:46
*** johnsom_ has joined #openstack-oslo06:47
*** vilobhmm11 has quit IRC06:51
*** ekarlso has quit IRC06:58
*** geoffarnold has quit IRC07:04
*** geoffarnold has joined #openstack-oslo07:04
*** achanda has quit IRC07:18
*** achanda has joined #openstack-oslo07:22
*** ekarlso has joined #openstack-oslo07:25
*** browne has quit IRC07:26
openstackgerritDivya K Konoor proposed openstack/pycadf: Change ceilometer endpoint name from telemetry to metering  https://review.openstack.org/23134307:36
*** tdurakov has joined #openstack-oslo07:46
*** geoffarn_ has joined #openstack-oslo07:47
*** geoffarnold has quit IRC07:50
*** yamahata has quit IRC07:50
*** tdurakov has quit IRC07:52
*** xek_ is now known as xek07:53
*** achanda has quit IRC07:57
*** yassine has joined #openstack-oslo08:00
*** _amrith_ is now known as amrith08:01
*** tdurakov has joined #openstack-oslo08:01
openstackgerritMasaki Matsushita proposed openstack/oslo.log: Implement FluentFormatter  https://review.openstack.org/23088508:05
*** achanda has joined #openstack-oslo08:05
*** geoffarn_ has quit IRC08:07
*** geoffarnold has joined #openstack-oslo08:08
*** droyal has joined #openstack-oslo08:09
*** amrith is now known as _amrith_08:10
*** achanda has quit IRC08:16
*** johnsom__ has joined #openstack-oslo08:17
*** johnsom_ has quit IRC08:20
*** geoffarnold has quit IRC08:29
*** geoffarnold has joined #openstack-oslo08:30
*** achanda has joined #openstack-oslo08:39
*** droyal has quit IRC08:43
*** droyal has joined #openstack-oslo08:44
*** geoffarnold has quit IRC08:50
*** achanda has quit IRC08:50
*** geoffarnold has joined #openstack-oslo08:51
*** geoffarnold has quit IRC09:11
*** geoffarnold has joined #openstack-oslo09:12
*** ozamiatin has joined #openstack-oslo09:17
*** geoffarnold has quit IRC09:33
*** geoffarn_ has joined #openstack-oslo09:34
*** exploreshaifali has joined #openstack-oslo09:52
*** pblaho has quit IRC09:53
*** geoffarn_ has quit IRC09:54
*** geoffarnold has joined #openstack-oslo09:55
*** yassine has quit IRC09:55
*** e0ne has joined #openstack-oslo10:03
*** jamielennox|away is now known as jamielennox10:14
*** kzaitsev1ws is now known as kzaitsev_ws10:15
*** geoffarnold has quit IRC10:15
*** geoffarnold has joined #openstack-oslo10:16
openstackgerritLucas Alvares Gomes proposed openstack/oslo.config: Case insensitiveness when comparing choices values  https://review.openstack.org/23139910:24
openstackgerritLucas Alvares Gomes proposed openstack/oslo.config: Case insensitiveness when comparing choices values  https://review.openstack.org/23139910:30
sdagueeezhova: just using kill instead of pkill -g doesn't seem to work10:32
sdagueeezhova: it was attempted here - https://review.openstack.org/#/c/231142/10:33
sdaguebut it seems to only kill the parent, and none of the children are killed off10:33
eezhovasdague, hmmm, I need to check whether cinder uses oslo.service10:36
*** geoffarnold has quit IRC10:36
eezhovasdague, there is another patch that tries the same thing https://review.openstack.org/#/c/208064/ but also kills services with SIGKILL after a timeout10:37
*** geoffarnold has joined #openstack-oslo10:37
*** ihrachys has joined #openstack-oslo10:37
eezhovasdague, it works ok for all services except nova compute10:37
eezhovasdague, and nova compute has problems because in .../n-cpu.pid it has pid of sg instead of pid n-cpu process itself10:39
sdagueright, I think part of that is the way libvirt is spawned10:39
sdaguehonestly, I don't remember all the magic in there10:39
sdaguecinder source code looks like it's running with oslo.service10:40
eezhovasdague, and sg doesn't pass signals to its children. making n-cpu write the correct pid to pid file (like that http://paste.openstack.org/show/475437/) should do the trick for it10:42
eezhovasdague, I'll investigate what's wrong with cinder10:43
eezhovasdague, meanwhile, no matter kill or pkill, Mitsuhiro's solution with SIGKILL after timeout should solve job failures10:44
eezhovasdague, what do you think?10:44
sdagueright, so we can do that, we can also just send kill twice10:47
sdagueright away10:47
sdaguefor the grenade case, that's good enough10:47
sdaguehowever, that does mean that we're going to tell all our users that's what they have to do10:48
sdaguethat seems troubling10:48
*** sdake has joined #openstack-oslo10:52
sdagueeezhova: https://review.openstack.org/#/c/230342 fixes it just the same10:52
sdaguefor instance10:52
eezhovasdague, I agree, perhaps oslo.service's behavior can be improved so that it can work both with kill and pkill10:54
eezhovasdague, why not SIGKILL to be 100% sure?10:54
sdagueyou don't need the sigkill, the second kill is pretty definitive for reasons that I forget right now10:55
sdagueok, so I guess I'll push in the work arounds, and once we're past the release we should figure out a test scenario to make it possible to build the proper fix here10:56
eezhovasdague, ok let's do like you suggested10:57
*** geoffarnold has quit IRC10:58
*** geoffarnold has joined #openstack-oslo10:59
sdagueok, I hit approve on those patches11:15
sdaguewill you be at the tokyo summit ?11:16
sdaguethat might be a good time to sort out some details here11:16
*** geoffarn_ has joined #openstack-oslo11:20
*** _amrith_ is now known as amrith11:20
*** yassine has joined #openstack-oslo11:23
*** geoffarnold has quit IRC11:23
*** amotoki has quit IRC11:24
*** tdurakov has quit IRC11:29
*** takedakn has joined #openstack-oslo11:41
*** gordc has joined #openstack-oslo11:46
*** pblaho has joined #openstack-oslo11:48
*** tdurakov has joined #openstack-oslo11:48
openstackgerritAlexey Yelistratov proposed openstack/oslo.messaging: Added matchmaker timeouts and retries  https://review.openstack.org/23110411:58
*** tdurakov has quit IRC12:02
gibilifeless: hi! I fixed your comment on https://review.openstack.org/#/c/216785/ could you please check it? Thanks!12:04
*** Horgix_ is now known as Horgix12:05
*** tdurakov has joined #openstack-oslo12:09
*** sdake has quit IRC12:09
*** sdake has joined #openstack-oslo12:10
*** kgiusti has joined #openstack-oslo12:11
eezhovasdague, no, I'm afraid I'm not coming12:12
*** exploreshaifali has quit IRC12:17
*** jecarey has quit IRC12:23
*** tdurakov has quit IRC12:24
*** geoffarnold has joined #openstack-oslo12:24
*** jecarey has joined #openstack-oslo12:24
*** geoffarn_ has quit IRC12:24
*** tdurakov has joined #openstack-oslo12:26
*** tdurakov has quit IRC12:29
*** tdurakov has joined #openstack-oslo12:31
*** amotoki has joined #openstack-oslo12:35
*** shardy has joined #openstack-oslo12:35
*** ekarlso has quit IRC12:38
*** takedakn has quit IRC12:39
*** ttx has quit IRC12:44
*** ttx has joined #openstack-oslo12:45
*** geoffarnold has quit IRC12:45
*** geoffarn_ has joined #openstack-oslo12:45
*** edmondsw has joined #openstack-oslo12:45
*** pradk has joined #openstack-oslo12:50
*** jaypipes has joined #openstack-oslo12:50
dims_eezhova: sorry that you wont make it!12:52
*** edleafe has quit IRC12:54
*** ekarlso has joined #openstack-oslo12:56
*** edleafe has joined #openstack-oslo12:57
*** rlrossit has joined #openstack-oslo12:57
openstackgerritMerged openstack/pycadf: Change ceilometer endpoint name from telemetry to metering  https://review.openstack.org/23134312:58
*** regXboi has joined #openstack-oslo12:59
*** amrith is now known as _amrith_13:02
*** geoffarn_ has quit IRC13:06
*** amotoki has quit IRC13:06
*** geoffarnold has joined #openstack-oslo13:07
*** fultonj has joined #openstack-oslo13:08
openstackgerritMerged openstack/pycadf: No need for Oslo Incubator Sync  https://review.openstack.org/23085113:08
*** sheeprine has quit IRC13:09
*** sheeprine has joined #openstack-oslo13:09
*** sdake has quit IRC13:09
*** thumpba has joined #openstack-oslo13:10
*** sdake has joined #openstack-oslo13:10
*** nkrinner has quit IRC13:11
*** sdake_ has joined #openstack-oslo13:12
*** nkrinner has joined #openstack-oslo13:14
*** sdake has quit IRC13:14
openstackgerritRonald Bradford proposed openstack/oslotest: Fix coverage configuration and execution  https://review.openstack.org/23049713:15
*** jecarey has quit IRC13:16
*** thangp has joined #openstack-oslo13:24
*** mriedem has joined #openstack-oslo13:24
openstackgerritMerged openstack/pycadf: Document and update existing hacking violations  https://review.openstack.org/23025513:25
*** geoffarnold has quit IRC13:27
*** geoffarnold has joined #openstack-oslo13:28
*** amotoki has joined #openstack-oslo13:29
*** amotoki has quit IRC13:33
openstackgerritKen Giusti proposed openstack/oslo.messaging: Use the hostname from the Transport for GSSAPI Authentication  https://review.openstack.org/23147913:38
*** amotoki has joined #openstack-oslo13:39
*** banix has joined #openstack-oslo13:44
*** pballand has quit IRC13:46
*** enikanorov has joined #openstack-oslo13:48
*** amotoki has quit IRC13:49
*** mriedem has quit IRC13:49
openstackgerritMerged openstack/oslo.concurrency: Fix coverage configuration and execution  https://review.openstack.org/22988313:56
*** amotoki has joined #openstack-oslo14:00
openstackgerritMerged openstack/oslo.versionedobjects: Fix coverage configuration and execution  https://review.openstack.org/23011014:01
*** mriedem has joined #openstack-oslo14:04
openstackgerritMerged openstack/oslo.policy: Fix coverage configuration and execution  https://review.openstack.org/22996814:04
haypodims_: hello. what's the process to request a release? i would like a release of oslo.serialization to get new functions14:09
*** sigmavirus24_awa is now known as sigmavirus2414:10
*** _amrith_ is now known as amrith14:11
*** Guest28678 is now known as redrobot14:13
*** zz_dimtruck is now known as dimtruck14:19
*** stevemar_ has joined #openstack-oslo14:28
*** jecarey has joined #openstack-oslo14:28
*** achanda has joined #openstack-oslo14:29
*** geoffarnold has quit IRC14:29
*** geoffarnold has joined #openstack-oslo14:30
*** jaypipes has quit IRC14:32
*** achanda has quit IRC14:37
*** geoffarnold has quit IRC14:50
*** geoffarnold has joined #openstack-oslo14:51
*** yamahata has joined #openstack-oslo14:55
*** yamahata has quit IRC14:56
*** browne has joined #openstack-oslo14:57
*** achanda has joined #openstack-oslo14:57
haypoi don't understand the oslo.db error "Parent instance <Snapshot at 0x7f35b76d9310> is not bound to a Session"14:58
haypoexample: https://bugs.launchpad.net/cinder/+bug/150183814:58
openstackLaunchpad bug 1501838 in Cinder "Tests: lazy load operation of attribute 'snapshot_metadata' cannot proceed" [Undecided,New]14:58
*** achanda has quit IRC15:01
*** david-ly_ is now known as david-lyle15:06
*** zzzeek has joined #openstack-oslo15:07
*** geoffarnold has quit IRC15:11
*** geoffarnold has joined #openstack-oslo15:12
dims_haypo: see example for taskflow which i released this morning - https://review.openstack.org/#/c/231152/15:13
dims_haypo: need a SHA and a release version # in the new openstack/releases repo15:13
*** shardy has quit IRC15:18
*** sdake_ is now known as sdake15:23
haypodims_: jd__ explained it me vocally :) see https://review.openstack.org/23154115:23
*** ozamiatin has quit IRC15:23
*** shardy has joined #openstack-oslo15:25
*** shardy has quit IRC15:26
*** dims_ has quit IRC15:27
*** dims_ has joined #openstack-oslo15:32
*** geoffarnold has quit IRC15:33
*** geoffarnold has joined #openstack-oslo15:34
*** davidlenwell has quit IRC15:36
*** davidlenwell has joined #openstack-oslo15:37
*** tdurakov has quit IRC15:39
*** tdurakov has joined #openstack-oslo15:40
*** links has quit IRC15:42
*** geoffarnold is now known as geoffarnoldX15:45
openstackgerritAlexey Yelistratov proposed openstack/oslo.messaging: Added matchmaker timeouts and retries  https://review.openstack.org/23110415:47
*** johnsom__ is now known as johnsom15:47
*** pblaho_ has joined #openstack-oslo15:48
*** ihrachys_ has joined #openstack-oslo15:48
*** ihrachys has quit IRC15:49
*** ihrachys has joined #openstack-oslo15:50
*** pblaho has quit IRC15:52
*** ihrachys_ has quit IRC15:53
*** pblaho_ has quit IRC15:53
*** pblaho has joined #openstack-oslo15:54
*** geoffarnoldX has quit IRC15:54
*** tdurakov has quit IRC15:54
*** geoffarnold has joined #openstack-oslo15:55
*** tdurakov has joined #openstack-oslo15:55
*** tdurakov has quit IRC15:55
*** dukhlov has quit IRC15:57
*** tdurakov has joined #openstack-oslo15:58
*** dukhlov has joined #openstack-oslo15:58
openstackgerritAlexey Yelistratov proposed openstack/oslo.messaging: Added matchmaker timeouts and retries  https://review.openstack.org/23110415:59
*** mtanino has joined #openstack-oslo15:59
*** tdurakov has quit IRC16:00
*** tdurakov has joined #openstack-oslo16:01
*** pballand has joined #openstack-oslo16:01
*** vilobhmm11 has joined #openstack-oslo16:02
*** e0ne has quit IRC16:08
*** ozamiatin has joined #openstack-oslo16:12
*** geoffarnold has quit IRC16:16
*** nkrinner has quit IRC16:16
*** thangp_ has joined #openstack-oslo16:16
*** geoffarnold has joined #openstack-oslo16:16
*** thangp has quit IRC16:18
*** amotoki has quit IRC16:20
*** tdurakov has quit IRC16:21
*** links has joined #openstack-oslo16:23
*** tdurakov has joined #openstack-oslo16:23
*** tsekiyama has joined #openstack-oslo16:29
*** banix has quit IRC16:30
*** ViswaV has joined #openstack-oslo16:32
*** dimtruck is now known as zz_dimtruck16:34
*** ViswaV has quit IRC16:37
*** geoffarnold has quit IRC16:37
*** ViswaV has joined #openstack-oslo16:37
*** dims_ has quit IRC16:37
*** geoffarnold has joined #openstack-oslo16:38
*** dims_ has joined #openstack-oslo16:41
*** dims_ has quit IRC16:41
*** dims_ has joined #openstack-oslo16:42
*** jaypipes has joined #openstack-oslo16:43
*** dims__ has joined #openstack-oslo16:44
*** dims_ has quit IRC16:45
*** vilobhmm111 has joined #openstack-oslo16:54
*** vilobhmm11 has quit IRC16:57
*** geoffarnold has quit IRC16:58
*** geoffarnold has joined #openstack-oslo16:59
*** enikanorov has quit IRC17:03
*** sdake has quit IRC17:03
*** sdake has joined #openstack-oslo17:05
openstackgerritJoshua Harlow proposed openstack/taskflow: Have decider base class take atom and increase docstring usefulness  https://review.openstack.org/23125117:05
*** tdurakov has quit IRC17:05
*** thumpba has quit IRC17:10
*** tdurakov has joined #openstack-oslo17:10
*** tdurakov has quit IRC17:10
*** browne has quit IRC17:11
*** banix has joined #openstack-oslo17:12
*** mriedem has quit IRC17:13
openstackgerritAlexey Yelistratov proposed openstack/oslo.messaging: Added matchmaker timeouts and retries  https://review.openstack.org/23110417:16
*** e0ne has joined #openstack-oslo17:16
jlvillaldhellmann: Or anyone else who knows about logging. Seeing an issue where mal-formed logging calls are not detected during unit tests. I have made an initial patch to fixtures to work around this: https://github.com/testing-cabal/fixtures/pull/1317:19
jlvillalBut even with the patch, mal-formed requests do not fail unit tests in Ironic.17:19
dhellmannjlvillal: "mal-formed requests"?17:20
jlvillalWe have a bug report about this: https://bugs.launchpad.net/ironic/+bug/150308617:20
openstackLaunchpad bug 1503086 in Ironic "Mis-formatted calls to log.* are not detected in unit tests" [Medium,In progress] - Assigned to John L. Villalovos (happycamp)17:20
jlvillaldhellmann: Like log.warning('foo', 'warn')17:20
*** david-ly_ has joined #openstack-oslo17:21
*** geoffarn_ has joined #openstack-oslo17:21
*** david-lyle has quit IRC17:21
dhellmannI don't think that's technically mal-formed, is it?17:21
*** mriedem has joined #openstack-oslo17:21
jlvillaldhellmann: I think it is. The logging module generates an exception.17:21
jlvillaldhellmann: Better details here: https://bugs.launchpad.net/python-fixtures/+bug/150304917:21
openstackLaunchpad bug 1503049 in Python Fixtures "Have FakeLogger detect bad calls to logger" [Medium,Triaged]17:21
dhellmannoh, ok, well if that's the case then we should definitely figure out why that's not happening in unit tests17:21
jlvillaldhellmann: Agreed. We don't actually find out until production time :(17:22
*** david-ly_ is now known as david-lyle17:22
openstackgerritMerged openstack/oslo.vmware: No need for Oslo Incubator Sync  https://review.openstack.org/23084917:22
jlvillaldhellmann: So I was hoping for maybe a hint on where to go looking :)17:22
dhellmannjlvillal: it sounds like you're on the right track with fixing the fixture17:23
jlvillalThe logging call for sure hits the fixture. And goes into emit.17:23
jlvillalBut then no exception is raised. So I'm confused.17:23
jlvillaldhellmann:  I'll keep plugging away at it.17:24
*** geoffarnold has quit IRC17:24
*** pballand has quit IRC17:24
dhellmannjlvillal: I wonder if one of our logging pieces is trapping the exception to prevent bad logging calls from causing problems. in production does the thing die, or does it log an error?17:24
*** achanda has joined #openstack-oslo17:24
*** harlowja has quit IRC17:25
jlvillaldhellmann: In production it just logs the exception but does not raise the exception.17:25
jlvillaldhellmann: My pull-request to fixtures changes the behavior to actually raise the exception. So we would hopefully see it during unit tests.17:25
dhellmannjlvillal: ok, I think that's what we want for production and in the unit test we probably want the exception thrown17:25
jlvillaldhellmann: Agreed.17:25
*** sputnik13 has joined #openstack-oslo17:25
jlvillaldhellmann: And in my simple test script it works and exception is thrown with the pull request. But not in Ironic unit tests.17:26
openstackgerritMerged openstack/mox3: Activate pep8 check that _ is imported  https://review.openstack.org/22284017:29
dhellmannjlvillal: I'm not familiar with the fakelogger implementation, but I wonder if the ironic tests are setting it up correctly so it's used everywhere17:29
*** dims_ has joined #openstack-oslo17:29
jlvillaldhellmann: I am seeing it calling the emit() method for the fakelogger.  I am running one single unit test17:31
jlvillaldhellmann: And hacking the code so I can see that it does get called.17:31
dhellmannjlvillal: and it's your patched version of the fake logger?17:31
jlvillaldhellmann: correct.17:31
jlvillaldhellmann: I added an 'emit' method to the new class I created.17:32
jlvillalAnd I see it getting called.17:32
dhellmannjlvillal: are you able to step through it with the debugger to see where the flow goes?17:32
jlvillaldhellmann: Now you got me. As I have never used the Python debugger. But maybe this is a good time for me to learn!17:32
*** dims__ has quit IRC17:32
* jlvillal has lived on print and writing to log files to debug...17:32
dhellmannjlvillal: you'll need a script from oslotest to make pdb work -- http://docs.openstack.org/developer/oslotest/debugging.html17:33
jlvillaldhellmann: Thanks.17:34
* dims_ in the same shoes as jlvillal :)17:34
jlvillal:)17:34
dhellmannjlvillal, dims_ : testr makes it a little tricky, but the script sets up everything you need17:35
jlvillaldhellmann: Does it matter if we now use 'os-testr'?17:35
*** harlowja has joined #openstack-oslo17:35
dhellmannjlvillal: I'm not sure17:35
jlvillalOkay17:35
jlvillalmtreinish: Do you know about pdb and os-testr?17:36
jlvillal^^^^^^17:36
jlvillaldhellmann: My theory is that this affects more than Ironic17:37
dhellmannjlvillal: quite likely17:37
dhellmannjlvillal: we should find what is trapping the exception as a first step17:37
jlvillaldhellmann: I think that is the Python logging module17:38
*** rlrossit has quit IRC17:38
jlvillalFrom looking at the code. Would be nice if there was an option to the logging module to say, raise those exceptions.17:38
*** yassine has quit IRC17:39
jlvillalAnd raiseExceptions is not it. It just means to print the raised exception. Not to actually raise it.17:39
mtreinishjlvillal: it should just work, you can use --pdb or -n/--no-discover to run ostestr with pdb17:39
*** vilobhmm111 has left #openstack-oslo17:41
mtreinishbut, I don't ever use pdb so I've not played with it firsthand. Although, I know jgriffith uses it a lot17:41
*** geoffarn_ has quit IRC17:41
jlvillalmtreinish: Okay.  so like  tox -epy27 -- --pdb17:41
*** geoffarnold has joined #openstack-oslo17:42
mtreinishjlvillal: and the thing you're testing17:42
jlvillalmtreinish: Okay.  so like  tox -epy27 -- --pdb -r 'dkdkdkdk'17:42
jlvillal:)17:42
mtreinishjlvillal: so tox -epy27 -- --pdb ironic.tests.unit.test_foo17:42
jlvillalmtreinish: Thanks17:43
mtreinishjlvillal: fwiw, it's in the docs: http://docs.openstack.org/developer/os-testr/ostestr.html#running-tests17:43
* mtreinish wishes there was a sane story for installing man pages with python17:44
*** abitha has joined #openstack-oslo17:45
*** zz_dimtruck is now known as dimtruck17:46
jlvillalmtreinish: Does that magically launch pdb or do I have to do something else? Sorry pdb newbie here.17:46
*** ViswaV has quit IRC17:50
*** exploreshaifali has joined #openstack-oslo17:50
*** rlrossit has joined #openstack-oslo17:50
*** dims_ has quit IRC17:53
*** browne has joined #openstack-oslo17:55
*** regXboi has quit IRC17:55
*** dims_ has joined #openstack-oslo18:01
*** ViswaV has joined #openstack-oslo18:02
*** geoffarnold has quit IRC18:02
*** geoffarnold has joined #openstack-oslo18:03
*** dims_ has quit IRC18:05
*** dims_ has joined #openstack-oslo18:06
*** ihrachys has quit IRC18:10
openstackgerritDan Smith proposed openstack/oslo.versionedobjects: Fix obj_to_primitive() when used with a manifest  https://review.openstack.org/23164818:11
*** links has quit IRC18:13
*** jaypipes has quit IRC18:14
*** tdurakov has joined #openstack-oslo18:19
*** amrith is now known as _amrith_18:22
*** _amrith_ is now known as amrith18:22
*** geoffarn_ has joined #openstack-oslo18:24
*** geoffarnold has quit IRC18:25
*** haigang has joined #openstack-oslo18:28
mtreinishjlvillal: nah, you got to set a pdb breakpoint or trace in the code. That'll just let it work18:32
jlvillalmtreinish: Ah. Thanks.18:32
mtreinishjlvillal: because testr launches subprocess for each test runner it intereferes with pdb. That flag just doesn't use testr18:33
mtreinishand calls the test runner directly18:33
jlvillalmtreinish: Okay. Thank you.18:33
*** geoffarn_ is now known as geoffarnold18:37
*** pballand has joined #openstack-oslo18:41
openstackgerritTom Cocozzello proposed openstack/oslo.middleware: Configure filter factories for PasteDeploy  https://review.openstack.org/23015618:42
*** geoffarnold has quit IRC18:45
*** geoffarnold has joined #openstack-oslo18:45
*** thumpba has joined #openstack-oslo19:06
*** johnsom_ has joined #openstack-oslo19:14
*** johnsom has quit IRC19:18
*** jecarey has quit IRC19:18
*** e0ne has quit IRC19:23
*** e0ne has joined #openstack-oslo19:32
*** jecarey has joined #openstack-oslo19:36
*** exploreshaifali has quit IRC19:40
*** amrith is now known as _amrith_19:48
*** haigang has quit IRC19:48
*** geoffarnold has quit IRC19:48
*** geoffarnold has joined #openstack-oslo19:49
openstackgerritMerged openstack/taskflow: Fix bad sphinx module reference  https://review.openstack.org/23125919:49
*** tsekiyama has quit IRC19:51
*** tsekiyama has joined #openstack-oslo19:57
*** kgiusti has left #openstack-oslo19:59
*** jaypipes has joined #openstack-oslo20:00
*** thumpba has quit IRC20:01
*** johnsom_ has quit IRC20:02
*** ViswaV has quit IRC20:02
*** tdurakov has quit IRC20:04
*** geoffarnold is now known as geoffarnoldX20:07
*** tsekiyama has quit IRC20:08
*** tsekiyama has joined #openstack-oslo20:09
*** geoffarnoldX has quit IRC20:09
*** geoffarnold has joined #openstack-oslo20:10
*** fultonj has left #openstack-oslo20:13
*** sdake has quit IRC20:27
openstackgerritMerged openstack/oslo.messaging: Added matchmaker timeouts and retries  https://review.openstack.org/23110420:28
*** sdake has joined #openstack-oslo20:28
openstackgerritEric Brown proposed openstack/oslo.config: Add PortOpt for integer with range 1 to 65535  https://review.openstack.org/23125720:31
*** Nakato has quit IRC20:39
*** tdurakov has joined #openstack-oslo20:40
*** Nakato has joined #openstack-oslo20:40
*** davidlenwell has quit IRC20:43
*** jamielennox has quit IRC20:43
*** zigo has quit IRC20:43
*** tonyb has quit IRC20:43
*** sontek has quit IRC20:43
*** DuncanT has quit IRC20:43
*** krotscheck has quit IRC20:43
*** gus has quit IRC20:43
*** sigmavirus24 has quit IRC20:43
*** jraim has quit IRC20:43
*** jroll has quit IRC20:43
*** lbragstad has quit IRC20:43
*** hockeynut has quit IRC20:43
*** otherwiseguy has quit IRC20:43
*** breton has quit IRC20:43
*** davidlenwell has joined #openstack-oslo20:46
*** jamielennox has joined #openstack-oslo20:46
*** zigo has joined #openstack-oslo20:46
*** tonyb has joined #openstack-oslo20:46
*** sontek has joined #openstack-oslo20:46
*** DuncanT has joined #openstack-oslo20:46
*** krotscheck has joined #openstack-oslo20:46
*** gus has joined #openstack-oslo20:46
*** sigmavirus24 has joined #openstack-oslo20:46
*** jraim has joined #openstack-oslo20:46
*** jroll has joined #openstack-oslo20:46
*** lbragstad has joined #openstack-oslo20:46
*** hockeynut has joined #openstack-oslo20:46
*** otherwiseguy has joined #openstack-oslo20:46
*** breton has joined #openstack-oslo20:46
*** pleia2 has quit IRC20:47
*** waynr has quit IRC20:47
*** waynr has joined #openstack-oslo20:50
*** geoffarnold has quit IRC20:52
*** morgan has quit IRC20:52
*** morgan has joined #openstack-oslo20:52
*** geoffarnold has joined #openstack-oslo20:52
*** sdake has quit IRC20:53
*** rlrossit has quit IRC20:54
*** pleia2 has joined #openstack-oslo20:56
*** sdake has joined #openstack-oslo20:58
*** _amrith_ is now known as amrith20:58
*** rlrossit has joined #openstack-oslo21:00
*** ViswaV has joined #openstack-oslo21:01
*** waynr has quit IRC21:02
*** waynr has joined #openstack-oslo21:02
*** geoffarnold has quit IRC21:13
*** geoffarnold has joined #openstack-oslo21:14
*** edmondsw has quit IRC21:14
*** rlrossit has left #openstack-oslo21:15
*** e0ne has quit IRC21:24
harlowjadims_ https://review.openstack.org/#/c/231721/21:29
harlowja^ needed so that ironic can start using i think21:30
harlowja*or thats what i hear21:30
*** geoffarnold has quit IRC21:35
*** geoffarnold has joined #openstack-oslo21:35
*** thangp_ has quit IRC21:41
*** banix has quit IRC21:44
*** mriedem has quit IRC21:45
*** harlowja has quit IRC21:46
*** thumpba has joined #openstack-oslo21:47
*** abitha has quit IRC21:53
*** abitha has joined #openstack-oslo21:53
*** stevemar_ has quit IRC21:55
*** stevemar_ has joined #openstack-oslo21:56
*** harlowja has joined #openstack-oslo21:57
*** stevemar_ has quit IRC21:58
*** gordc has quit IRC22:00
*** stevemar_ has joined #openstack-oslo22:07
*** dimtruck is now known as zz_dimtruck22:07
*** boris-42 has quit IRC22:09
*** thumpba has quit IRC22:11
*** thumpba has joined #openstack-oslo22:13
*** geoffarnold has quit IRC22:17
*** geoffarn_ has joined #openstack-oslo22:18
*** jaypipes has quit IRC22:19
*** tdurakov has quit IRC22:20
*** thumpba has quit IRC22:28
*** tdurakov has joined #openstack-oslo22:28
*** pradk has quit IRC22:28
*** thumpba has joined #openstack-oslo22:29
harlowjadims_ hey for https://etherpad.openstack.org/p/oslo-mikata-survey should we talk to ttx about that, or others, to avoid overlapping survey issues and stuff?22:30
*** pballand has quit IRC22:31
dims_harlowja: probably too late for him now. we can ping him tomorrow just as a heads up22:31
harlowjakk22:31
dims_never hurts to communicate :)22:33
harlowjadef22:33
*** ViswaV has quit IRC22:34
*** pballand has joined #openstack-oslo22:35
*** geoffarn_ is now known as geoffarnoldX22:37
*** geoffarnoldX has quit IRC22:38
*** geoffarnold has joined #openstack-oslo22:39
*** stevemar_ has quit IRC22:43
*** stevemar_ has joined #openstack-oslo22:43
*** stevemar_ has quit IRC22:46
*** pballand has quit IRC22:50
*** pballand has joined #openstack-oslo22:50
*** ViswaV has joined #openstack-oslo22:51
*** pballand has quit IRC22:52
*** tdurakov has quit IRC22:52
*** boris-42 has joined #openstack-oslo22:53
*** ozamiatin has quit IRC22:56
*** subscope has quit IRC22:59
*** geoffarnold has quit IRC23:00
*** thumpba has quit IRC23:00
*** geoffarnold has joined #openstack-oslo23:00
*** thumpba has joined #openstack-oslo23:13
*** pballand has joined #openstack-oslo23:14
*** sigmavirus24 is now known as sigmavirus24_awa23:16
*** pballand has quit IRC23:19
*** geoffarnold has quit IRC23:21
*** geoffarnold has joined #openstack-oslo23:21
*** ViswaV has quit IRC23:23
*** thumpba has quit IRC23:28
*** yamahata has joined #openstack-oslo23:34
*** sputnik13 has quit IRC23:35
*** tsekiyama has quit IRC23:35
*** thumpba has joined #openstack-oslo23:36
*** achanda_ has joined #openstack-oslo23:36
*** ViswaV has joined #openstack-oslo23:39
*** achanda has quit IRC23:40
*** achanda_ has quit IRC23:41
*** sdake_ has joined #openstack-oslo23:41
*** sdake has quit IRC23:43
*** geoffarn_ has joined #openstack-oslo23:43
*** thumpba_ has joined #openstack-oslo23:44
*** tsekiyama has joined #openstack-oslo23:44
*** thumpba has quit IRC23:44
*** thumpba has joined #openstack-oslo23:45
*** thumpba has quit IRC23:46
*** geoffarnold has quit IRC23:46
*** thumpba_ has quit IRC23:49
*** stevemar_ has joined #openstack-oslo23:50
*** takedakn has joined #openstack-oslo23:50
*** sdake_ has quit IRC23:52
*** tsekiyama has quit IRC23:54
*** tsekiyama has joined #openstack-oslo23:56
*** yamahata has quit IRC23:57

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!