Nakato | lifeless: Thanks, that gets me around why to drop the -U :) | 00:00 |
---|---|---|
*** geoffarnold has quit IRC | 00:02 | |
*** geoffarn_ has joined #openstack-oslo | 00:03 | |
*** yamahata has quit IRC | 00:04 | |
*** yamahata has joined #openstack-oslo | 00:06 | |
*** vilobhmm11 has quit IRC | 00:12 | |
*** gangil has joined #openstack-oslo | 00:17 | |
*** gangil has joined #openstack-oslo | 00:17 | |
*** vilobhmm11 has joined #openstack-oslo | 00:22 | |
*** vilobhmm11 has quit IRC | 00:22 | |
*** geoffarn_ has quit IRC | 00:23 | |
*** geoffarnold has joined #openstack-oslo | 00:24 | |
*** gangil has quit IRC | 00:27 | |
*** vilobhmm11 has joined #openstack-oslo | 00:33 | |
*** itisha has joined #openstack-oslo | 00:39 | |
lifeless | Nakato: we've flipped and flopped on the use of -U in the baseline env too, but thats a different discussion :) | 00:41 |
*** browne has quit IRC | 00:41 | |
*** sdake has joined #openstack-oslo | 00:43 | |
*** geoffarnold has quit IRC | 00:44 | |
*** geoffarnold has joined #openstack-oslo | 00:45 | |
*** haigang has joined #openstack-oslo | 00:45 | |
*** sputnik13 has quit IRC | 00:52 | |
*** links has joined #openstack-oslo | 00:53 | |
*** eliqiao has joined #openstack-oslo | 00:54 | |
*** sdake has quit IRC | 00:58 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock https://review.openstack.org/234372 | 00:59 |
*** eliqiao has quit IRC | 01:00 | |
*** sdake has joined #openstack-oslo | 01:03 | |
*** geoffarnold has quit IRC | 01:06 | |
*** geoffarnold has joined #openstack-oslo | 01:06 | |
dims | lifeless: can you please review https://review.openstack.org/#/c/234372/? it's a fix for ceilometer unit tests failures | 01:11 |
dims | harlowja: and sileht worked on it. i just added a closes-bug tag | 01:12 |
harlowja | all fixed :-P | 01:12 |
harlowja | ha | 01:12 |
harlowja | *for now* | 01:12 |
*** vilobhmm11 has quit IRC | 01:13 | |
lifeless | looking | 01:15 |
dims | thanks lifeless | 01:16 |
*** eliqiao has joined #openstack-oslo | 01:18 | |
lifeless | dims: you reset the votes :) | 01:27 |
*** geoffarnold has quit IRC | 01:27 | |
*** geoffarn_ has joined #openstack-oslo | 01:27 | |
dims | lifeless: on https://review.openstack.org/#/c/234372/ that's ok, want to wait till we get sileht's ok when he wakes up | 01:28 |
*** dims has quit IRC | 01:33 | |
*** dims has joined #openstack-oslo | 01:34 | |
*** gangil has joined #openstack-oslo | 01:37 | |
*** gangil has joined #openstack-oslo | 01:37 | |
*** gangil has quit IRC | 01:44 | |
*** geoffarn_ has quit IRC | 01:48 | |
*** geoffarnold has joined #openstack-oslo | 01:49 | |
*** shardy has quit IRC | 02:01 | |
*** sdake has quit IRC | 02:06 | |
*** geoffarnold has quit IRC | 02:10 | |
*** browne has joined #openstack-oslo | 02:19 | |
*** mtanino has quit IRC | 02:20 | |
*** boris-42 has quit IRC | 02:28 | |
*** yamahata has quit IRC | 02:40 | |
*** haigang has quit IRC | 02:45 | |
*** jecarey has joined #openstack-oslo | 02:47 | |
*** zz_dimtruck is now known as dimtruck | 02:47 | |
*** jecarey has quit IRC | 02:51 | |
*** achanda has joined #openstack-oslo | 02:57 | |
*** amotoki has joined #openstack-oslo | 03:14 | |
*** amotoki has quit IRC | 03:30 | |
*** amotoki has joined #openstack-oslo | 03:41 | |
*** dimtruck is now known as zz_dimtruck | 03:47 | |
*** amotoki has quit IRC | 03:50 | |
*** amotoki has joined #openstack-oslo | 03:55 | |
*** david-lyle has quit IRC | 04:01 | |
*** harlowja_at_home has joined #openstack-oslo | 04:16 | |
*** amotoki has quit IRC | 04:18 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock https://review.openstack.org/234372 | 04:24 |
*** amotoki has joined #openstack-oslo | 04:26 | |
*** Kennan2 has quit IRC | 04:40 | |
*** Kennan has joined #openstack-oslo | 04:41 | |
*** gangil has joined #openstack-oslo | 04:47 | |
*** gangil has joined #openstack-oslo | 04:47 | |
*** gangil has quit IRC | 04:49 | |
*** harlowja_at_home has quit IRC | 05:04 | |
*** ihrachys has joined #openstack-oslo | 05:10 | |
*** boris-42 has joined #openstack-oslo | 05:22 | |
*** tedross has joined #openstack-oslo | 05:34 | |
*** vilobhmm11 has joined #openstack-oslo | 05:34 | |
*** nikhil_k has joined #openstack-oslo | 05:42 | |
*** nikhil has quit IRC | 05:42 | |
*** nkrinner has joined #openstack-oslo | 06:05 | |
*** tedross has quit IRC | 06:08 | |
*** vilobhmm11 has quit IRC | 06:18 | |
*** vilobhmm11 has joined #openstack-oslo | 06:20 | |
*** vilobhmm11 has quit IRC | 06:45 | |
*** stevemar_ has quit IRC | 06:53 | |
*** stevemar_ has joined #openstack-oslo | 06:54 | |
*** cdent has joined #openstack-oslo | 06:56 | |
*** stevemar_ has quit IRC | 06:56 | |
*** shardy has joined #openstack-oslo | 06:57 | |
*** subscope has joined #openstack-oslo | 06:59 | |
*** openstackgerrit has quit IRC | 07:01 | |
*** openstackgerrit has joined #openstack-oslo | 07:01 | |
*** jecarey has joined #openstack-oslo | 07:11 | |
*** jecarey has quit IRC | 07:16 | |
*** markus_z has joined #openstack-oslo | 07:23 | |
*** browne has quit IRC | 07:24 | |
*** subscope has quit IRC | 07:26 | |
*** achanda has quit IRC | 07:26 | |
*** achanda has joined #openstack-oslo | 07:27 | |
*** achanda has quit IRC | 07:33 | |
*** david-lyle has joined #openstack-oslo | 07:57 | |
*** yassine has joined #openstack-oslo | 08:08 | |
*** ociuhandu has quit IRC | 08:15 | |
*** bapalm has quit IRC | 08:23 | |
*** bapalm has joined #openstack-oslo | 08:26 | |
*** ndipanov has joined #openstack-oslo | 08:27 | |
*** jamielennox is now known as jamielennox|away | 08:40 | |
*** stevemar_ has joined #openstack-oslo | 08:55 | |
*** stevemar_ has quit IRC | 08:58 | |
*** edmondsw has joined #openstack-oslo | 08:59 | |
*** dims_ has joined #openstack-oslo | 09:17 | |
*** dims has quit IRC | 09:20 | |
*** links has quit IRC | 09:22 | |
*** jecarey has joined #openstack-oslo | 09:23 | |
*** jecarey has quit IRC | 09:27 | |
mdbooth | dims_: You about? | 09:38 |
mdbooth | dims_: I was just about to -1 that patch you just +W'd | 09:38 |
mdbooth | dims_: In fact, I'm going to -1 it anyway :) I'll try to explain why and you can decide what to do about it subsequently. | 09:40 |
mdbooth | This looks like a tricky bit of code, and you might be rushing to a fix. | 09:40 |
dims_ | mdbooth: we spent the whole day yesterday working on it on several boxes on multiple set of tests. | 09:42 |
mdbooth | dims_: Right. The fix is a workaround, though. | 09:43 |
mdbooth | The problem is a deadlock. | 09:43 |
dims_ | mdbooth: the right fix is for all projects to honor the contract | 09:43 |
dims_ | so mdbooth i'd suggest evangelizing that :) | 09:43 |
mdbooth | dims_: You mean that wait is called after stop()? | 09:44 |
dims_ | yes | 09:44 |
mdbooth | Well, that's another matter | 09:44 |
dims_ | mdbooth: after all the LOG messages for a month or two. ZERO projects fixed their code | 09:44 |
mdbooth | Although based on other solutions, I would expect to be allowed to call wait() before stop() | 09:44 |
mdbooth | Still, if that's the contract... | 09:44 |
mdbooth | I discarded a review comment saying: why don't you just raise an exception here? ;) | 09:45 |
mdbooth | Anyway, I still think it's wrong | 09:45 |
dims_ | with this code multiple calls to wait/stop and combinations will still work | 09:45 |
dims_ | mdbooth: yes, that was the first review about 3 months ago :) | 09:45 |
mdbooth | Well, not wrong | 09:45 |
mdbooth | It's over-complicates instead of fixing the underlying issue | 09:46 |
mdbooth | Give me 10 minutes, I'll add my -1 with details. | 09:46 |
dims_ | mdbooth: this is the best we can do at the moment | 09:46 |
dims_ | mdbooth: ack thanks | 09:46 |
*** Kennan has quit IRC | 09:47 | |
*** Kennan has joined #openstack-oslo | 09:48 | |
mdbooth | dims_: Looks like jharlow was up late working on it :) | 09:48 |
mdbooth | dims_: -1 sent. I'll submit a patch, but only for discussion. | 09:57 |
dims_ | mdbooth: needs to get through o.m unit tests, o.m functional tests, dsvm+tempest and ceilometer tests :) | 09:58 |
mdbooth | dims_: Right, and I probably won't follow that through. However, it'll be simpler and more robust. | 09:59 |
dims_ | mdbooth: acl thanks | 09:59 |
mdbooth | dims_: I noted in that review, btw, that server.wait() doesn't honour its own contract | 10:01 |
mdbooth | Once it's finished, the underlying driver resources associated to this | 10:01 |
mdbooth | server are released (like closing useless network connections). | 10:01 |
mdbooth | This is only true for a maximum of 1 thread | 10:02 |
mdbooth | Hmm, actually no | 10:02 |
mdbooth | dims_: Ah, actually I think the new patch might introduce a regression... | 10:03 |
mdbooth | Do you want to stick a hold on it for a few minutes while I work that through? | 10:03 |
dims_ | sileht: around? | 10:03 |
sileht | dims_, yes | 10:03 |
dims_ | sileht: thanks, mdbooth is reviewing that patch we just pushed :) | 10:04 |
mdbooth | dims_: Yes, I think that's a regression | 10:04 |
mdbooth | I didn't comment on it originally because I didn't read the original code closely enough and thought it was there before | 10:05 |
mdbooth | Well, I did comment, but I didn't note it as a regression :) | 10:05 |
dims_ | mdbooth: whip up a follow up patch please? | 10:05 |
mdbooth | So, with the new patch a thread can call wait(), but not wait() | 10:06 |
mdbooth | i.e. its call to wait() can complete before the call to executor.wait() has completed | 10:06 |
mdbooth | Because it it being executed concurrently by another thread | 10:06 |
mdbooth | So if you've got threads A and B | 10:07 |
mdbooth | A: wait() | 10:07 |
mdbooth | B: wait() | 10:07 |
mdbooth | A will call the executor | 10:07 |
mdbooth | B will complete immediately | 10:07 |
dims_ | mdbooth: that's why the earlier incarnation tried to enforce that the only the thread that started should call wait/stop if i remember right | 10:09 |
mdbooth | I think you need both a state lock and a conditional | 10:10 |
mdbooth | The conditional will just be for the internal use of wait() | 10:10 |
sileht | I guess my version doesn't have this issue: https://review.openstack.org/#/c/234332/ | 10:11 |
mdbooth | I'd have left this in review, but it's currently wending its way through the gate | 10:11 |
mdbooth | dims_ sileht: Is there an underlying reason for the stop/wait ordering contract, btw? | 10:12 |
mdbooth | Or would everybody be happier if that just worked? | 10:13 |
mdbooth | Is it just because the implementation doesn't allow it? | 10:13 |
sileht | mdbooth, we must ensure nothing call stop/wait between driver init and executor start() | 10:16 |
*** albertw1 has joined #openstack-oslo | 10:18 | |
sileht | mdbooth, the original issue before the lock was introduced was: driver do IO before the first polling (like initial connection) that make greenlet switch and an other greenlet can call stop/wait, when we are back to the first greenlet we call execturo.start() on a already stopped/waitted server | 10:21 |
sileht | (we start polling on executor.start()) | 10:21 |
* mdbooth is on a call for about 1hr | 10:22 | |
mdbooth | biab | 10:22 |
markus_z | odyssey4me: Do you have a minute for me about https://bugs.launchpad.net/nova/+bug/1505677 ? | 10:40 |
openstack | Launchpad bug 1505677 in openstack-ansible "oslo.versionedobjects 0.11.0 causing KeyError: 'objects' in nova-conductor log" [Critical,Confirmed] - Assigned to Jesse Pretorius (jesse-pretorius) | 10:40 |
odyssey4me | markus_z sure | 10:41 |
odyssey4me | markus_z when I mentioned it yesterday, I was pointed to https://review.openstack.org/234166 as a fix from the nova team | 10:41 |
markus_z | odyssey4me: Oh, on a second thought, maybe I ask the nova folks directly, sorry :) | 10:41 |
odyssey4me | markus_z you can probably pick it up with sdague | 10:42 |
markus_z | odyssey4me: Right, I'll do that. | 10:42 |
*** Kennan has left #openstack-oslo | 10:44 | |
sdague | markus_z: yeh, I was working through a different liberty patch land independently. So the bug should be fixed now | 10:47 |
sdague | in rc3 | 10:48 |
sdague | it was a liberty only bug | 10:48 |
markus_z | sdague: OK, cool, that's what I wanted to know, thank you very much. | 10:48 |
*** ociuhandu has joined #openstack-oslo | 10:53 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: PoC: batch notification listener https://review.openstack.org/234716 | 10:53 |
*** shardy is now known as shardy_afk | 10:55 | |
*** stevemar_ has joined #openstack-oslo | 10:56 | |
*** e0ne has joined #openstack-oslo | 10:56 | |
*** stevemar_ has quit IRC | 10:59 | |
*** ociuhandu has quit IRC | 11:01 | |
*** albertw1 has quit IRC | 11:06 | |
*** ociuhandu has joined #openstack-oslo | 11:08 | |
mdbooth | sileht dims_: It seems to me that the issue with call ordering and wait is that you must call wait after start() | 11:10 |
mdbooth | stop() comes after start(), so that ordering is also correct, but it's over restrictive | 11:11 |
sileht | mdbooth, during server.stop(), we can have contextswitch() before executor.start() | 11:12 |
sileht | mdbooth, during server.start(), we can have contextswitch() before executor.start() | 11:12 |
sileht | (first sentence is wrong) | 11:12 |
mdbooth | I mean specifically that executor.wait() must come after executor.start() has completed | 11:13 |
sileht | mdbooth, stop() too | 11:13 |
mdbooth | sileht: I don't see a reason that it must come after stop() | 11:13 |
mdbooth | Is there one? | 11:13 |
sileht | mdbooth, that can come before and after but not during | 11:14 |
mdbooth | You mean you can't call wait() during stop()? | 11:15 |
* mdbooth has only looked at a single executor implementation, btw | 11:15 | |
openstackgerrit | Merged openstack/oslo.context: Fix coverage configuration and execution https://review.openstack.org/229885 | 11:15 |
openstackgerrit | Elena Ezhova proposed openstack/oslo.service: Document termination of children on SIGHUP https://review.openstack.org/234729 | 11:15 |
sileht | mdbooth, we can't call stop or wait during start | 11:15 |
mdbooth | sileht: Oh, right. Internal state is inconsistent until start() completes. | 11:16 |
mdbooth | So you were saying that you can't call stop() until start() completes? Which is consistent. | 11:16 |
sileht | yes | 11:17 |
mdbooth | Cool | 11:17 |
sileht | I think we can remove the warning about wait/stop ordering too (if we fix wait correctly) | 11:17 |
mdbooth | Yeah, that's what I was thinking | 11:18 |
mdbooth | I think I'll add a condition for that | 11:18 |
sileht | I have put the warning before the lock/condition exists, since we have a state into the server and we ensure consistency around it | 11:19 |
sileht | we can allow anything ordering | 11:19 |
sileht | mdbooth, are you working on a new patchset ? | 11:20 |
mdbooth | sileht: Yeah | 11:20 |
sileht | mdbooth, cool thanks | 11:20 |
mdbooth | Although given that jharlow's patch is merging anyway, I want to use a conditional, and he added DummyConditional, I'm going to base my patch on his | 11:21 |
openstackgerrit | Merged openstack/oslo.policy: Add cover test requirement https://review.openstack.org/234289 | 11:21 |
mdbooth | Although, as that patch introduces a race, I'm not so sure it should merge... | 11:22 |
sileht | it should not | 11:22 |
*** e0ne has quit IRC | 11:23 | |
*** _amrith_ is now known as amrith | 11:32 | |
openstackgerrit | Merged openstack/oslo.rootwrap: Fix Python 3 support for eventlet monkey-patching https://review.openstack.org/234412 | 11:38 |
*** zqfan has joined #openstack-oslo | 11:51 | |
*** albertw1 has joined #openstack-oslo | 11:52 | |
albertw1 | Hi, any idea why jenkins gave this a -1 verification, even though the checks were all successful? https://review.openstack.org/#/c/234271/ | 11:55 |
sileht | albertw1, you must change the requirements repo first | 12:07 |
*** gordc has joined #openstack-oslo | 12:10 | |
openstackgerrit | Merged openstack/oslo.versionedobjects: Updated from global requirements https://review.openstack.org/234677 | 12:15 |
ihrachys | sileht: have a min to talk about oslo.messaging cleanup? | 12:16 |
*** achanda has joined #openstack-oslo | 12:16 | |
sileht | ihrachys, sure | 12:16 |
ihrachys | sileht: I wonder whether it's feasible to clean up declared topics on connection close | 12:17 |
ihrachys | sileht: in neutron ovs agent, we create a connection, then declare consumers, then do some work; after that start consuming from topics | 12:17 |
*** achanda has quit IRC | 12:17 | |
*** achanda has joined #openstack-oslo | 12:18 | |
ihrachys | the problem is that if smth crashes after we declared those topics, no consumers are attached to the topics, so even though they are auto-delete, they are left sitting on the broker | 12:18 |
sileht | ihrachys, the current rabbitmq driver doesn't do that, fixing that is hard without breaking rolling upgrade | 12:18 |
ihrachys | sileht: how is rolling involved? | 12:19 |
sileht | ihrachys, because some change need to be done on topic/queue attributes that enforce to delete/recreate topic/queue | 12:19 |
ihrachys | sileht: can't we delete the topic explicitly? | 12:20 |
sileht | ihrachys, I don't think you can do this | 12:21 |
*** achanda has quit IRC | 12:22 | |
sileht | ihrachys, rabbitmq doesn't make difference between cleanly closed connection and the abruptily closed one, it just applies what you set on queue/topic/exchanges (auto_delete/expiration/...) | 12:22 |
sileht | ihrachys, the future pika driver should not suffer from this issue | 12:24 |
ihrachys | sileht: so how do we avoid the race? even though I move rpc code as near to the consumers start, there is still space for a race. | 12:24 |
sileht | ihrachys, the race exists since the begin of openstack I guess | 12:26 |
ihrachys | sileht: pika is still for rabbit? | 12:27 |
sileht | ihrachys, yes | 12:27 |
ihrachys | sileht: I am fine with the race, as long as I can explain there is no better fix than what I already have (moving rpc initialization closer to consumers start) | 12:28 |
sileht | ihrachys, but even with pika you will have this behavior but with more clearer error message | 12:28 |
ihrachys | we thought we could introduce an exit handler to clean that up, but since you say there is no safe way for that, I am fine | 12:28 |
sileht | ihrachys, nova-conductor for example got a timeout exception on startup and retries until consumer is present | 12:29 |
*** ociuhandu has quit IRC | 12:30 | |
ihrachys | sileht: but what will it retry when the conductor is restarted? then the fanout topic gets a new name (due to uuid being encoded into it) | 12:30 |
ihrachys | so a new queue is created, and old one is never delete | 12:31 |
sileht | fanout have autodelete so it should disapear | 12:31 |
sileht | replies have autodelete too | 12:32 |
ihrachys | sileht: it does not disappear before consumers are attached | 12:34 |
ihrachys | sileht: because broker thinks there will eventually be one | 12:35 |
sileht | ihrachys, oh I see, I wasn't thinking at this case | 12:39 |
*** shardy_a1k has joined #openstack-oslo | 12:39 | |
sileht | ihrachys, for sure pika will not have this behavior | 12:40 |
sileht | ihrachys, with pika only consumer creates topics | 12:40 |
sileht | ihrachys, so publisher can get error for none existing consumer quicker | 12:40 |
ihrachys | sileht: cool. yeah, lazy approach seems to be more fail-proof | 12:40 |
sileht | and not waiting the rpc_timeout | 12:41 |
*** shardy_afk has quit IRC | 12:41 | |
*** shardy_a1k has quit IRC | 12:45 | |
mdbooth | dims_ sileht: I have written something which I think might be good. Haven't even run tests against it yet, though. Grabbing lunch. | 12:46 |
*** shardy_afk has joined #openstack-oslo | 12:46 | |
mdbooth | I've kept jharlow's _state_cond, just formalised it | 12:48 |
*** rohit_ has joined #openstack-oslo | 12:51 | |
*** regXboi has joined #openstack-oslo | 12:56 | |
*** stevemar_ has joined #openstack-oslo | 12:57 | |
*** eliqiao has quit IRC | 12:57 | |
*** rlrossit has joined #openstack-oslo | 12:58 | |
*** stevemar_ has quit IRC | 13:00 | |
*** jecarey has joined #openstack-oslo | 13:00 | |
*** amotoki has quit IRC | 13:02 | |
*** amrith is now known as _amrith_ | 13:15 | |
*** amotoki has joined #openstack-oslo | 13:15 | |
*** jecarey has quit IRC | 13:18 | |
mdbooth | How long do the oslo.messaging tests typically take to run? | 13:20 |
mdbooth | Are we talking long or short pieces of string? | 13:20 |
*** itisha has quit IRC | 13:21 | |
*** jecarey has joined #openstack-oslo | 13:23 | |
*** mriedem has joined #openstack-oslo | 13:25 | |
*** amotoki has quit IRC | 13:32 | |
mdbooth | How do you run a single unit test in oslo.messaging in a manner which allows you to attach a debugger? | 13:34 |
mdbooth | NM, got it | 13:38 |
*** amotoki has joined #openstack-oslo | 13:40 | |
*** shardy_afk is now known as shardy | 13:47 | |
*** amotoki has quit IRC | 13:47 | |
*** pradk has joined #openstack-oslo | 13:52 | |
*** dims_ has quit IRC | 14:01 | |
*** dims has joined #openstack-oslo | 14:01 | |
*** amotoki has joined #openstack-oslo | 14:02 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 14:02 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: PoC: batch notification listener https://review.openstack.org/234716 | 14:05 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: PoC: batch notification listener https://review.openstack.org/234716 | 14:06 |
*** stevemar_ has joined #openstack-oslo | 14:07 | |
*** binarin has joined #openstack-oslo | 14:10 | |
dims | hi binarin! | 14:13 |
binarin | dims: hi | 14:14 |
dims | binarin: don't expect you to follow this, but the hot topic of the day is https://review.openstack.org/#/c/234372/ | 14:15 |
dims | binarin: and logs are here http://eavesdrop.openstack.org/irclogs/%23openstack-oslo/ | 14:16 |
*** ihrachys has quit IRC | 14:16 | |
dims | if you ever need it | 14:16 |
*** _amrith_ is now known as amrith | 14:17 | |
*** ihrachys has joined #openstack-oslo | 14:17 | |
dims | binarin: here's how to join the fun at openstack - https://wiki.openstack.org/wiki/Documentation/HowTo/FirstTimers | 14:20 |
*** browne has joined #openstack-oslo | 14:22 | |
openstackgerrit | Merged openstack/oslo.messaging: Use a condition (and/or a dummy one) instead of a lock https://review.openstack.org/234372 | 14:28 |
*** jecarey has quit IRC | 14:29 | |
*** jecarey has joined #openstack-oslo | 14:29 | |
*** zz_dimtruck is now known as dimtruck | 14:32 | |
*** jecarey has quit IRC | 14:34 | |
*** jecarey has joined #openstack-oslo | 14:36 | |
*** mriedem has quit IRC | 14:37 | |
*** ihrachys has quit IRC | 14:38 | |
*** mriedem has joined #openstack-oslo | 14:47 | |
*** stevemar_ has quit IRC | 14:50 | |
*** stevemar_ has joined #openstack-oslo | 14:51 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo-specs: Adds rabbitmq-pika-driver spec https://review.openstack.org/228992 | 14:52 |
*** stevemar_ has quit IRC | 14:52 | |
*** stevemar_ has joined #openstack-oslo | 14:52 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: PoC: batch notification listener https://review.openstack.org/234716 | 14:55 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: batch notification listener https://review.openstack.org/234716 | 14:56 |
*** shardy_ has joined #openstack-oslo | 14:56 | |
*** shardy has quit IRC | 14:57 | |
*** harlowja_at_home has joined #openstack-oslo | 15:01 | |
*** shardy_ has quit IRC | 15:01 | |
*** shardy has joined #openstack-oslo | 15:02 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Small grammar messaging fix https://review.openstack.org/234825 | 15:02 |
harlowja_at_home | sileht, dims ^ just a really small fix, noticed that, damn grammar, hahaha | 15:03 |
harlowja_at_home | someday i'll learn english :) | 15:03 |
mdbooth | With a new audience :) How long do you typically expect oslo.messaging tests to take when run locally | 15:03 |
harlowja_at_home | hmmm, i think i've seen like 5 minutes? | 15:04 |
sileht | harlowja_at_home, mdbooth will removes this restriction the message will become useless :) | 15:04 |
mdbooth | harlowja_at_home: If I can get the tests to run, I'm going to delete that message :) | 15:04 |
harlowja_at_home | lol | 15:04 |
harlowja_at_home | ok | 15:04 |
harlowja_at_home | guess nobody liked the periodic message, lol | 15:04 |
mdbooth | tox is very busy doing a lot of work and not producing any output | 15:05 |
harlowja_at_home | tox be a busy man | 15:05 |
mdbooth | If it were deadlocked, I'd expect it to be doing no work | 15:05 |
dims | mdbooth: try without your patch first :) baseline | 15:05 |
mdbooth | dims: True | 15:05 |
mdbooth | 1m7s, with 2 failures | 15:08 |
mdbooth | Worth doing :) | 15:08 |
sileht | mdbooth, that two failures are perhaps OK | 15:08 |
sileht | mdbooth, it's about amqp1.0 driver ? | 15:08 |
mdbooth | Yeah, I assumed as much | 15:08 |
sileht | mdbooth, that will pass on gate | 15:08 |
mdbooth | Does it use https://github.com/The-Compiler/pytest-vw ? | 15:09 |
sileht | lol | 15:09 |
sileht | mdbooth, I don't known yet which requirement need to raised to fix that issue in gate and locally | 15:10 |
mdbooth | nova is really verbose when running tox tests | 15:10 |
mdbooth | oslo.messaging is not | 15:10 |
mdbooth | Any idea what the difference might be? | 15:10 |
mdbooth | If it's stuck running a particular test or set of tests | 15:11 |
mdbooth | I would like to know what they are | 15:11 |
sileht | nova have a wrapper to print ongoing test | 15:11 |
*** albertw1 has left #openstack-oslo | 15:14 | |
harlowja_at_home | https://github.com/openstack/taskflow/blob/master/tools/pretty_tox.sh ? | 15:15 |
harlowja_at_home | i thought that was the wrapper (or similar) | 15:15 |
harlowja_at_home | did that get shared by everyone yet | 15:15 |
harlowja_at_home | ( which uses https://github.com/openstack/taskflow/blob/master/tools/subunit_trace.py or equivalent) | 15:16 |
*** amrith is now known as _amrith_ | 15:18 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo-specs: Adds rabbitmq-pika-driver spec https://review.openstack.org/228992 | 15:18 |
*** _amrith_ is now known as amrith | 15:20 | |
*** david-lyle has quit IRC | 15:25 | |
*** zqfan has quit IRC | 15:26 | |
mdbooth | Grr | 15:26 |
* mdbooth is yak shaving | 15:26 | |
mdbooth | I'd like to work out why these tests are failing | 15:26 |
mdbooth | But I don't know what tests are even running | 15:26 |
*** david-lyle has joined #openstack-oslo | 15:27 | |
mdbooth | All I know is that it's very busy, and doesn't complete | 15:27 |
harlowja_at_home | mdbooth, suck over pretty_tox.sh and subunit_trace.py and try them | 15:27 |
harlowja_at_home | might be helpful for u | 15:27 |
*** e0ne has joined #openstack-oslo | 15:27 | |
harlowja_at_home | suck/move over/copyover | 15:27 |
harlowja_at_home | lol | 15:27 |
mdbooth | That's the yak I'm trying to shave | 15:27 |
mdbooth | I know nothing of how tox works :( | 15:27 |
harlowja_at_home | in this case its probably not tox :) | 15:27 |
mdbooth | I'm also trying to keep it that way | 15:27 |
harlowja_at_home | but ya, testr output isn't so easy to figure out whats going on :( | 15:28 |
mdbooth | How do I get testr output? | 15:28 |
mdbooth | I get no output | 15:28 |
mdbooth | I can run a single test | 15:28 |
mdbooth | That's fine | 15:28 |
mdbooth | So I at least know that there are no import errors | 15:28 |
mdbooth | And the code is nominally sane in some conditions | 15:28 |
mdbooth | I don't mind running a complicated command line | 15:28 |
harlowja_at_home | some https://github.com/openstack/oslotest/blob/master/oslotest/base.py#L33 might be useful to u | 15:28 |
harlowja_at_home | export OS_STDERR_CAPTURE=0 | 15:29 |
mdbooth | export it to what? | 15:29 |
harlowja_at_home | export OS_STDOUT_CAPTURE=0 | 15:29 |
* mdbooth just want to know what the command line is | 15:29 | |
mdbooth | What command do I run to get some output? | 15:29 |
harlowja_at_home | export OS_DEBUG=5 | 15:29 |
mdbooth | Step back | 15:29 |
harlowja_at_home | k | 15:29 |
mdbooth | If I don't invoke tox, what tool do I run? | 15:29 |
harlowja_at_home | testr run | 15:30 |
* mdbooth tries that | 15:30 | |
harlowja_at_home | make sure u are in the virtualenv that tox creates though | 15:30 |
harlowja_at_home | before doing this | 15:30 |
harlowja_at_home | which is typically at .tox/py27/bin/activate | 15:30 |
*** yamahata has joined #openstack-oslo | 15:30 | |
mdbooth | Yeah, got that, thanks | 15:30 |
harlowja_at_home | k | 15:30 |
dims | mdbooth: why don't you upload a review? we can poke at it too | 15:33 |
harlowja_at_home | bb, heading into work | 15:34 |
*** harlowja_at_home has quit IRC | 15:34 | |
mdbooth | harlowja: I have output! :) | 15:34 |
mdbooth | It's not the output I'm looking for, but it's a step in the right direction :) | 15:35 |
mdbooth | dims: Intransigence :) | 15:35 |
dims | lol | 15:36 |
mdbooth | dims: Seriously, though, it might not be nice to the gate | 15:36 |
mdbooth | The tests seem to be spinning on something | 15:36 |
mdbooth | ERROR [oslo_messaging._drivers.impl_qpid] Unable to connect to AMQP server on {'username': None, 'host': 'host2:5672', 'password': None}: None. Sleeping 1 seconds | 15:37 |
mdbooth | Is that normal? | 15:37 |
mdbooth | Apparently it is | 15:41 |
*** jecarey has quit IRC | 15:43 | |
*** markus_z has quit IRC | 15:43 | |
*** jecarey has joined #openstack-oslo | 15:43 | |
* mdbooth just want the name of 1 test which fails | 15:44 | |
mdbooth | Any test | 15:44 |
mdbooth | The first one | 15:44 |
*** david-ly_ has joined #openstack-oslo | 15:46 | |
*** david-lyle has quit IRC | 15:47 | |
*** jecarey has quit IRC | 15:48 | |
*** jecarey has joined #openstack-oslo | 15:49 | |
dims | mdbooth: harlowja: sileht: got a gate-tempest-dsvm-full succeed with oslo.messaging-master (devstack review https://review.openstack.org/#/c/234811/) | 15:51 |
dims | mdbooth: harlowja: sileht: http://logs.openstack.org/11/234811/1/check/gate-tempest-dsvm-full/cb44f14//logs/testr_results.html.gz | 15:51 |
dims | mdbooth: paste.org? | 15:51 |
mdbooth | dims: Can do, but I'm moving again, now | 15:52 |
dims | ok | 15:52 |
mdbooth | Hopefully it's just a typo :) | 15:52 |
*** rohit_ has quit IRC | 15:54 | |
*** david-ly_ is now known as david-lyle | 15:54 | |
mdbooth | Eurgh | 15:54 |
mdbooth | In TestMultipleServers.test_multiple_servers | 15:54 |
mdbooth | How is self.exchange1 initialised? | 15:54 |
mdbooth | python -m testtools.run oslo_messaging.tests.rpc.test_server.TestMultipleServers.test_multiple_servers | 15:55 |
mdbooth | Doesn't do it | 15:55 |
mdbooth | Hmm, might be some python skulduggery going on there | 15:56 |
*** ihrachys has joined #openstack-oslo | 16:00 | |
openstackgerrit | Sriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run https://review.openstack.org/234858 | 16:00 |
*** sreshetn1ak has quit IRC | 16:01 | |
*** pkholkin has quit IRC | 16:01 | |
*** sreshetnyak has joined #openstack-oslo | 16:02 | |
mdbooth | Nope, so the TestMultipleServers tests definitely hang, but I can't work out how to describe one of them | 16:06 |
mdbooth | They seem to be using 'testscenarios' to generate multiple variants | 16:06 |
mdbooth | How do I specify 1 test from 1 variant? | 16:07 |
*** sputnik13 has joined #openstack-oslo | 16:07 | |
mdbooth | Actually, nm. I'll patch those tests out and try to find a failure elsewhere | 16:07 |
*** cdent has quit IRC | 16:08 | |
*** ihrachys has quit IRC | 16:14 | |
*** ihrachys has joined #openstack-oslo | 16:17 | |
*** jecarey has quit IRC | 16:18 | |
*** jecarey has joined #openstack-oslo | 16:19 | |
*** gangil has joined #openstack-oslo | 16:22 | |
*** gangil has joined #openstack-oslo | 16:22 | |
*** jecarey has quit IRC | 16:24 | |
*** shardy has quit IRC | 16:25 | |
mdbooth | Ah, ha! | 16:27 |
mdbooth | I'm not accounting for DummyCondition :) | 16:27 |
mdbooth | That means it ends up in a busy loop | 16:29 |
mdbooth | dims harlowja: Sorry, just received SIGWIFE. I now know what needs to be fixed, and I'll do it in the morning. Should be just a tweak. | 16:30 |
*** yassine has quit IRC | 16:31 | |
openstackgerrit | Greg Hill proposed openstack/taskflow: Update decider spec to allow specifying which atoms to skip https://review.openstack.org/231174 | 16:34 |
*** jasondotstar_ has joined #openstack-oslo | 16:39 | |
*** cburgess_ has joined #openstack-oslo | 16:44 | |
harlowja | dims cool, that loooks all green :-P | 16:45 |
harlowja | i like the green, ha | 16:45 |
dims | mdbooth: no worries. a paste would have helped :) | 16:46 |
dims | mdbooth: to see how far you got | 16:46 |
*** zzzeek_ has joined #openstack-oslo | 16:46 | |
*** e0ne_ has joined #openstack-oslo | 16:49 | |
*** ihrachys has quit IRC | 16:50 | |
*** e0ne has quit IRC | 16:50 | |
*** jaypipes has quit IRC | 16:50 | |
*** eezhova has quit IRC | 16:50 | |
*** zzzeek has quit IRC | 16:50 | |
*** cburgess has quit IRC | 16:50 | |
*** rakhmerov has quit IRC | 16:50 | |
*** sileht has quit IRC | 16:50 | |
*** SlickNik has quit IRC | 16:50 | |
*** jasondotstar has quit IRC | 16:50 | |
*** amrith has quit IRC | 16:50 | |
*** dulek has quit IRC | 16:50 | |
*** peterstac has quit IRC | 16:50 | |
*** dstanek has quit IRC | 16:50 | |
*** sreshetnyak has quit IRC | 16:50 | |
*** binarin has quit IRC | 16:50 | |
*** rlrossit has quit IRC | 16:50 | |
*** bapalm has quit IRC | 16:50 | |
*** lifeless has quit IRC | 16:50 | |
*** hogepodge has quit IRC | 16:50 | |
*** mtreinish has quit IRC | 16:50 | |
*** isq_ has quit IRC | 16:50 | |
*** amaurymedeiros has quit IRC | 16:50 | |
*** shardy has joined #openstack-oslo | 16:50 | |
*** gangil has left #openstack-oslo | 16:50 | |
harlowja | mdbooth cool | 16:52 |
dims | harlowja: hmm, i'd have really liked to see where mdbooth was headed :( | 16:53 |
harlowja | :-/ | 16:53 |
harlowja | to his wife? | 16:53 |
harlowja | lol | 16:53 |
dims | with his patch :) | 16:53 |
harlowja | probably | 16:54 |
harlowja | lol | 16:54 |
*** e0ne_ is now known as e0ne | 16:55 | |
*** sreshetnyak has joined #openstack-oslo | 16:59 | |
*** binarin has joined #openstack-oslo | 16:59 | |
*** rlrossit has joined #openstack-oslo | 16:59 | |
*** bapalm has joined #openstack-oslo | 16:59 | |
*** lifeless has joined #openstack-oslo | 16:59 | |
*** hogepodge has joined #openstack-oslo | 16:59 | |
*** mtreinish has joined #openstack-oslo | 16:59 | |
*** isq_ has joined #openstack-oslo | 16:59 | |
*** amaurymedeiros has joined #openstack-oslo | 16:59 | |
*** ihrachys has joined #openstack-oslo | 17:06 | |
*** sreshetnyak has quit IRC | 17:07 | |
*** binarin has quit IRC | 17:07 | |
*** rlrossit has quit IRC | 17:07 | |
*** bapalm has quit IRC | 17:07 | |
*** lifeless has quit IRC | 17:07 | |
*** hogepodge has quit IRC | 17:07 | |
*** mtreinish has quit IRC | 17:07 | |
*** isq_ has quit IRC | 17:07 | |
*** amaurymedeiros has quit IRC | 17:07 | |
*** eezhova has joined #openstack-oslo | 17:07 | |
*** amrith has joined #openstack-oslo | 17:07 | |
*** jaypipes has joined #openstack-oslo | 17:08 | |
*** sileht has joined #openstack-oslo | 17:08 | |
*** peterstac has joined #openstack-oslo | 17:08 | |
*** SlickNik has joined #openstack-oslo | 17:08 | |
*** sreshetnyak has joined #openstack-oslo | 17:10 | |
*** binarin has joined #openstack-oslo | 17:10 | |
*** rlrossit has joined #openstack-oslo | 17:10 | |
*** bapalm has joined #openstack-oslo | 17:10 | |
*** lifeless has joined #openstack-oslo | 17:10 | |
*** hogepodge has joined #openstack-oslo | 17:10 | |
*** mtreinish has joined #openstack-oslo | 17:10 | |
*** isq_ has joined #openstack-oslo | 17:10 | |
*** amaurymedeiros has joined #openstack-oslo | 17:10 | |
*** rakhmerov has joined #openstack-oslo | 17:13 | |
*** yamahata has quit IRC | 17:14 | |
*** shardy has quit IRC | 17:14 | |
*** amrith is now known as _amrith_ | 17:14 | |
*** browne has quit IRC | 17:15 | |
*** achanda has joined #openstack-oslo | 17:17 | |
*** dimtruck is now known as zz_dimtruck | 17:17 | |
*** vilobhmm11 has joined #openstack-oslo | 17:18 | |
*** jecarey has joined #openstack-oslo | 17:20 | |
*** mriedem has quit IRC | 17:21 | |
*** dstanek_ has joined #openstack-oslo | 17:22 | |
*** dstanek_ has quit IRC | 17:23 | |
*** dstanek has joined #openstack-oslo | 17:24 | |
*** jecarey has quit IRC | 17:24 | |
*** nkrinner has quit IRC | 17:28 | |
*** jecarey has joined #openstack-oslo | 17:28 | |
*** jecarey has quit IRC | 17:31 | |
*** jecarey has joined #openstack-oslo | 17:31 | |
*** sreshetnyak has quit IRC | 17:35 | |
*** jecarey has quit IRC | 17:36 | |
*** jecarey has joined #openstack-oslo | 17:37 | |
*** yamahata has joined #openstack-oslo | 17:38 | |
*** jasondotstar_ is now known as jasondotstar | 17:39 | |
*** zz_dimtruck is now known as dimtruck | 17:40 | |
*** mriedem has joined #openstack-oslo | 17:40 | |
*** sreshetnyak has joined #openstack-oslo | 17:45 | |
*** nikhil_k has quit IRC | 17:45 | |
*** rlrossit has quit IRC | 17:47 | |
*** thumpba has joined #openstack-oslo | 17:51 | |
*** rlrossit has joined #openstack-oslo | 17:52 | |
*** browne has joined #openstack-oslo | 17:55 | |
*** _amrith_ is now known as amrith | 18:00 | |
harlowja | dims sooo for the session titles, anyone want to look through a bunch of japanese hakiu ? | 18:01 |
harlowja | i think we should do all haiku, lol | 18:01 |
harlowja | * haiku | 18:01 |
harlowja | http://www.toyomasu.com/haiku/ :-P | 18:01 |
harlowja | seems relevant to the location of the summit, ha | 18:01 |
harlowja | 'From a bathing tub | 18:02 |
harlowja | I throw water into the lake - | 18:02 |
harlowja | slight muddiness appears.' lol | 18:02 |
harlowja | :-/ | 18:02 |
*** edmondsw has quit IRC | 18:09 | |
*** nikhil has joined #openstack-oslo | 18:15 | |
*** e0ne has quit IRC | 18:15 | |
*** e0ne has joined #openstack-oslo | 18:20 | |
*** ihrachys has quit IRC | 18:22 | |
*** achanda has quit IRC | 18:25 | |
*** edmondsw has joined #openstack-oslo | 18:28 | |
*** thumpba has quit IRC | 18:29 | |
*** jecarey_ has joined #openstack-oslo | 18:30 | |
*** jecarey__ has joined #openstack-oslo | 18:32 | |
*** jecarey has quit IRC | 18:33 | |
harlowja | lifeless https://review.openstack.org/234924 | 18:34 |
harlowja | fyi | 18:34 |
harlowja | going to integrate that into oslo.utils to avoid a hack that is showing up in taskflow | 18:34 |
*** david-lyle has quit IRC | 18:35 | |
*** jecarey_ has quit IRC | 18:35 | |
*** david-lyle has joined #openstack-oslo | 18:39 | |
*** david-ly_ has joined #openstack-oslo | 18:40 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Expose function signature fetching function https://review.openstack.org/234927 | 18:42 |
*** david-ly_ has quit IRC | 18:43 | |
*** david-ly_ has joined #openstack-oslo | 18:44 | |
*** david-lyle has quit IRC | 18:44 | |
*** david-ly_ is now known as david-lyle | 18:45 | |
*** david-lyle has quit IRC | 18:45 | |
*** david-lyle has joined #openstack-oslo | 18:47 | |
*** jecarey__ has quit IRC | 18:56 | |
*** jecarey has joined #openstack-oslo | 18:57 | |
*** david-lyle has quit IRC | 19:00 | |
amrith | dims, yt? | 19:01 |
amrith | downgraded to 2.5.0 | 19:02 |
amrith | and now trying | 19:02 |
*** dimtruck is now known as zz_dimtruck | 19:04 | |
amrith | dims, same problem with 2.5.0 | 19:04 |
amrith | not sure what else has been impacted | 19:04 |
dims | did you activate the venv and force an install of 2.5.0? | 19:04 |
*** thumpba has joined #openstack-oslo | 19:04 | |
dims | amrith: ^^ | 19:05 |
amrith | I deleted my .tox | 19:05 |
amrith | changed my requirements.txt | 19:05 |
amrith | and re-ran tox | 19:05 |
amrith | that recreates the venv | 19:05 |
dims | oslo.messaging===2.5.0 | 19:06 |
dims | ? | 19:06 |
amrith | oslo.messaging<2.6.0 got me 2.5.0 | 19:06 |
amrith | oslo.messaging!=1.17.0,!=1.17.1,>=1.16.0,<2.6.0 # Apache-2.0 | 19:06 |
amrith | amrith@amrith-work:/opt/stack/trove$ . .tox/py27/bin/activate | 19:07 |
amrith | (py27)amrith@amrith-work:/opt/stack/trove$ pip list | grep oslo.messaging | 19:07 |
amrith | oslo.messaging (2.5.0) | 19:07 |
amrith | (py27)amrith@amrith-work:/opt/stack/trove$ | 19:07 |
*** david-lyle has joined #openstack-oslo | 19:08 | |
dims | amrith: gotcha. then it's a different problem :* | 19:08 |
dims | :( | 19:08 |
amrith | yup | 19:08 |
lifeless | harlowja: ack | 19:09 |
*** achanda has joined #openstack-oslo | 19:09 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Expose function signature fetching function https://review.openstack.org/234927 | 19:09 |
openstackgerrit | Sriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run https://review.openstack.org/234858 | 19:09 |
harlowja | lifeless thx | 19:09 |
dims | amrith: let's track it as a bug please | 19:09 |
harlowja | lifeless https://review.openstack.org/234927 switches oslo_uils to using it | 19:09 |
harlowja | *oslo_utils | 19:09 |
*** zz_dimtruck is now known as dimtruck | 19:14 | |
*** david-lyle has quit IRC | 19:25 | |
*** david-ly_ has joined #openstack-oslo | 19:25 | |
lifeless | harlowja: you on twitter? | 19:34 |
harlowja | whats that crap, haha | 19:34 |
harlowja | nah | 19:34 |
* harlowja never got into tweeting | 19:34 | |
*** david-ly_ has quit IRC | 19:38 | |
*** david-lyle has joined #openstack-oslo | 19:38 | |
*** david-lyle has quit IRC | 19:39 | |
*** david-lyle has joined #openstack-oslo | 19:41 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Implements rabbit-pika driver https://review.openstack.org/229985 | 19:42 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.utils: Expose function signature fetching function https://review.openstack.org/234927 | 19:43 |
harlowja | sputnik13 since i think u have looked at that code also ^ | 19:46 |
harlowja | dhellmann https://review.openstack.org/#/c/233301/ should that be ok to unblock now? | 19:49 |
*** e0ne has quit IRC | 19:49 | |
*** jecarey has quit IRC | 19:54 | |
*** stevemar_ is now known as stevemar_jays | 19:55 | |
*** thumpba has quit IRC | 19:55 | |
*** david-lyle has quit IRC | 19:56 | |
*** jecarey_ has joined #openstack-oslo | 19:57 | |
*** david-lyle has joined #openstack-oslo | 19:58 | |
*** achanda has quit IRC | 20:00 | |
peterstac | hi all, in Trove we seem to be having a problem with oslo.utils 2.6.0 causing our tox tests to hang | 20:00 |
peterstac | any known issues we should be aware of? | 20:00 |
*** david-ly_ has joined #openstack-oslo | 20:01 | |
*** jecarey_ has quit IRC | 20:01 | |
openstackgerrit | Sriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run https://review.openstack.org/234858 | 20:01 |
lifeless | harlowja: https://sourceforge.net/p/pypi/support-requests/546/ | 20:02 |
peterstac | harlowja, dhellmann ^^^^ | 20:02 |
harlowja | hmmmm, oslo.utils causing tests to hang | 20:02 |
harlowja | peterstac any idea which part of code? | 20:02 |
harlowja | idk of any issues? | 20:02 |
harlowja | dims know of any/ | 20:02 |
harlowja | ? | 20:02 |
*** david-lyle has quit IRC | 20:03 | |
harlowja | lifeless looks good to me | 20:03 |
peterstac | harlowja, it seems to spin throwing the same msg into the log - one sec ... | 20:03 |
harlowja | hmm | 20:03 |
*** david-ly_ is now known as david-lyle__ | 20:03 | |
*** david-lyle__ is now known as david-lyle___ | 20:03 | |
dims | peterstac: haven't heard of anything | 20:03 |
peterstac | ok, just wondering | 20:04 |
dims | peterstac: open a bug yet? | 20:04 |
peterstac | not yet, we're still trying to investigate (wanted to make sure it wasn't us :D ) | 20:06 |
*** david-lyle has joined #openstack-oslo | 20:06 | |
*** david-lyle___ has quit IRC | 20:06 | |
peterstac | it fills the log with the following msg: http://paste.openstack.org/show/476304/ | 20:07 |
harlowja | lol | 20:08 |
harlowja | always sleep with a reason | 20:08 |
dims | weird :) | 20:08 |
harlowja | thou shall not sleep with no reason | 20:08 |
harlowja | so this 'fake_sleep' is raising an exception? | 20:09 |
harlowja | that seems sorta weird | 20:09 |
harlowja | doing that probably triggers https://github.com/openstack/oslo.utils/blob/master/oslo_utils/excutils.py#L227 | 20:09 |
harlowja | which now logs these kind of oddities | 20:09 |
*** amrith is now known as _amrith_ | 20:10 | |
harlowja | https://review.openstack.org/#/c/230619/4/oslo_utils/excutils.py will not suffer from this afaik | 20:11 |
dims | peterstac: possibly this change? https://github.com/openstack/oslo.utils/commit/6010fb3fff11fc961c5c8038543122b909e15666#diff-3cce8243cb5c7f567a816fe701341c50 | 20:11 |
harlowja | since it doesn't try to capture exceptions in sleep calls | 20:11 |
harlowja | feel free to try https://review.openstack.org/#/c/230619/ | 20:11 |
harlowja | which afaik won't have that exception being logged | 20:11 |
harlowja | the scope of that try, catch block is reduced in 230619 , likely to more of what it should be | 20:12 |
harlowja | feel free to try that out | 20:12 |
peterstac | ok, I'll give it a shot, thx | 20:13 |
harlowja | np | 20:13 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Add in-memory backend delete() in recursive/non-recursive modes https://review.openstack.org/189982 | 20:17 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Change engine 'self._check' into a decorator https://review.openstack.org/225266 | 20:23 |
*** rohit_ has joined #openstack-oslo | 20:34 | |
*** achanda has joined #openstack-oslo | 20:41 | |
*** achanda has quit IRC | 20:41 | |
*** dimtruck is now known as zz_dimtruck | 20:43 | |
*** achanda has joined #openstack-oslo | 20:44 | |
*** achanda has quit IRC | 20:56 | |
*** edmondsw has quit IRC | 21:01 | |
*** kgiusti has quit IRC | 21:02 | |
*** zz_dimtruck is now known as dimtruck | 21:04 | |
*** thumpba has joined #openstack-oslo | 21:05 | |
*** jecarey has joined #openstack-oslo | 21:10 | |
*** achanda has joined #openstack-oslo | 21:12 | |
*** dimtruck is now known as zz_dimtruck | 21:14 | |
*** regXboi has quit IRC | 21:38 | |
*** rlrossit has left #openstack-oslo | 21:40 | |
*** jecarey has quit IRC | 21:43 | |
*** jecarey has joined #openstack-oslo | 21:43 | |
*** zz_dimtruck is now known as dimtruck | 21:44 | |
*** jecarey has quit IRC | 21:48 | |
*** achanda has quit IRC | 21:48 | |
*** mriedem has quit IRC | 21:58 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:02 | |
openstackgerrit | Sriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run https://review.openstack.org/234858 | 22:07 |
*** jamielennox|away is now known as jamielennox | 22:07 | |
*** yassine has joined #openstack-oslo | 22:09 | |
*** yassine has quit IRC | 22:09 | |
*** achanda has joined #openstack-oslo | 22:15 | |
openstackgerrit | Sriram Madapusi Vasudevan proposed openstack/taskflow: feat: add max_dispatches arg to conductor's run https://review.openstack.org/234858 | 22:22 |
*** dimtruck is now known as zz_dimtruck | 22:26 | |
*** pradk has quit IRC | 22:41 | |
*** jecarey has joined #openstack-oslo | 22:44 | |
*** achanda has quit IRC | 22:45 | |
*** openstackgerrit has quit IRC | 22:46 | |
*** openstackgerrit has joined #openstack-oslo | 22:46 | |
*** achanda has joined #openstack-oslo | 22:47 | |
*** achanda has quit IRC | 22:47 | |
*** jecarey has quit IRC | 22:48 | |
*** pballand has joined #openstack-oslo | 23:06 | |
*** achanda has joined #openstack-oslo | 23:09 | |
*** dims_ has joined #openstack-oslo | 23:19 | |
*** pballand has quit IRC | 23:20 | |
*** dims has quit IRC | 23:22 | |
*** pballand has joined #openstack-oslo | 23:23 | |
*** _amrith_ is now known as amrith | 23:34 | |
amrith | dims_, yt? | 23:41 |
dims_ | amrith: pong | 23:41 |
amrith | hi ... just wanted to make sure you heard the latest on our findings and after I said YT, by buffer filled with stuff. looks like peterstac and you chatted. | 23:42 |
amrith | do you know if he entered a bug? | 23:42 |
amrith | I don't see one yet | 23:42 |
amrith | at this point it seems like we should back down to 2.4 or so of oslo.utils. | 23:43 |
dims_ | amrith: i believe harlowja asked peterstac to try https://review.openstack.org/#/c/230619/ | 23:45 |
dims_ | y don't see a bug yet | 23:45 |
harlowja | i'm 95% confident 230619 will do what u want | 23:45 |
harlowja | other 5% cause who the hell knows how software will actually work, ha | 23:45 |
sputnik13 | harlowja heeeellllllppp | 23:45 |
harlowja | hellpppp | 23:46 |
harlowja | 911 | 23:46 |
harlowja | if u have an emergency, pleas press 1 | 23:46 |
sputnik13 | that's what I'm doing, 911 == harlowja | 23:46 |
sputnik13 | :-D | 23:46 |
sputnik13 | 11111111 | 23:46 |
harlowja | for operator, please press 2 | 23:46 |
harlowja | u pressed 1, hi, this is the hospital | 23:46 |
harlowja | please hold | 23:46 |
harlowja | lol | 23:46 |
harlowja | sputnik13 whats up | 23:46 |
sputnik13 | http://paste.openstack.org/show/476319/ we're using tooz 0.14.0 and trying to use "zookeeper" coordinator | 23:47 |
sputnik13 | getting that | 23:47 |
sputnik13 | confuzd | 23:47 |
sputnik13 | there's a zookeeper driver, why it no likey | 23:47 |
harlowja | let's see | 23:47 |
harlowja | python setup.py develop | 23:47 |
harlowja | otherwise not find entrypoints | 23:47 |
harlowja | or pip install tooz | 23:47 |
harlowja | thats where i've seen that | 23:47 |
harlowja | when entrypoints are requested, but package isn't actually registered to provide them | 23:48 |
sputnik13 | hmmm | 23:48 |
amrith | ok, will check | 23:48 |
sputnik13 | ok | 23:48 |
harlowja | sputnik13 also check which tooz version | 23:48 |
sputnik13 | 0.14.0 | 23:48 |
harlowja | ah | 23:48 |
harlowja | ya, guess u said that | 23:48 |
harlowja | ha | 23:48 |
harlowja | sputnik13 https://github.com/openstack/tooz/blob/0.14.0/setup.cfg | 23:49 |
harlowja | soooo ya, in that version it was called kazoo | 23:49 |
sputnik13 | don't ask why 0.14.0, we might maybe talk about it over sake in tokyo | 23:49 |
harlowja | think i fixed that in a later version | 23:49 |
amrith | dumb question ... | 23:49 |
amrith | oslo.utils>=2.0.0,!=2.6.0 # Apache-2.0 | 23:49 |
amrith | should prevent oslo.utils v2.6.0, yes? | 23:49 |
harlowja | sputnik13 so 'kazoo' not 'zookeeper' | 23:49 |
amrith | I'm losing my mind | 23:49 |
dims_ | y | 23:49 |
amrith | it installs 2.6.0 with that line | 23:49 |
amrith | in requirements.txt | 23:49 |
harlowja | https://github.com/openstack/tooz/commit/9d8b146d7143e2762 | 23:49 |
harlowja | sputnik13 ^ | 23:49 |
amrith | even if I make it line 1 | 23:49 |
harlowja | amrith u might not be, pip is weird | 23:50 |
dims_ | amrith: typically, i just activate the venv and use "pip install oslo.utils===2.6.0" | 23:50 |
dims_ | or whichever version | 23:50 |
amrith | ok | 23:50 |
dims_ | and then rerun tox | 23:50 |
sputnik13 | harlowja fantastic, you rock, thank you | 23:50 |
harlowja | sputnik13 please forward your insurance so i can charge them, thx | 23:50 |
harlowja | thats 2000$ | 23:50 |
harlowja | ll | 23:50 |
harlowja | lol | 23:50 |
dims_ | holy moly i am in the wrong business :) | 23:51 |
harlowja | lol | 23:51 |
harlowja | def | 23:51 |
amrith | dims ... thanks, that worked | 23:52 |
amrith | will try the fix that harlowja suggested | 23:52 |
harlowja | :) | 23:52 |
amrith | am wondering how I'll do that | 23:52 |
amrith | but I'll figure it out | 23:53 |
amrith | I have enough beer at home | 23:53 |
harlowja | lol | 23:53 |
* harlowja didn't know beer installs things | 23:53 | |
harlowja | TIL | 23:53 |
amrith | harlowja, beer doesn't install things. beer instills confidence in person who then installs things. | 23:54 |
harlowja | haha | 23:54 |
harlowja | so beer is your catalyst i guess | 23:54 |
amrith | so I assume I just take the two files you are changing and drop them in the right place in my venv | 23:54 |
amrith | yes? | 23:54 |
harlowja | righto | 23:54 |
harlowja | or just 1 @ https://review.openstack.org/#/c/230619/4/oslo_utils/excutils.py | 23:54 |
harlowja | the other is a test | 23:54 |
amrith | beer is an "experience enhancer" | 23:54 |
harlowja | ha | 23:54 |
*** gordc has quit IRC | 23:55 | |
amrith | ok, just grab this excutils.py | 23:55 |
amrith | got it | 23:55 |
harlowja | right | 23:56 |
*** edmondsw has joined #openstack-oslo | 23:58 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!