| *** jerrygb has quit IRC | 00:00 | |
| *** jerrygb has joined #openstack-oslo | 00:02 | |
| *** salv-orl_ has quit IRC | 00:03 | |
| *** jamielennox|away is now known as jamielennox | 00:05 | |
| *** takedakn has quit IRC | 00:07 | |
| *** takedakn has joined #openstack-oslo | 00:07 | |
| *** salv-orlando has joined #openstack-oslo | 00:09 | |
| *** jerrygb has quit IRC | 00:18 | |
| *** jerrygb has joined #openstack-oslo | 00:18 | |
| *** I has joined #openstack-oslo | 00:19 | |
| *** I is now known as Guest3986 | 00:19 | |
| *** fultonj has quit IRC | 00:20 | |
| *** gordc has quit IRC | 00:22 | |
| *** jerrygb has quit IRC | 00:23 | |
| *** sabari has joined #openstack-oslo | 00:23 | |
| *** devananda has joined #openstack-oslo | 00:25 | |
| *** yamamoto has joined #openstack-oslo | 00:26 | |
| *** yamamoto_ has joined #openstack-oslo | 00:29 | |
| *** yamamoto has quit IRC | 00:32 | |
| *** yamamot__ has joined #openstack-oslo | 00:32 | |
| *** mtanino has quit IRC | 00:33 | |
| *** yamamoto_ has quit IRC | 00:34 | |
| *** dougwig has quit IRC | 00:35 | |
| *** dougwig has joined #openstack-oslo | 00:35 | |
| *** yamamot__ has quit IRC | 00:37 | |
| *** zz_dimtruck is now known as dimtruck | 00:38 | |
| *** jdandrea has quit IRC | 00:39 | |
| *** mc_nair_ has joined #openstack-oslo | 00:40 | |
| *** mc_nair has quit IRC | 00:40 | |
| *** jdandrea has joined #openstack-oslo | 00:40 | |
| *** takedakn has quit IRC | 00:43 | |
| *** alejandrito has quit IRC | 00:46 | |
| *** Guest3986 has quit IRC | 00:49 | |
| kevinbenton | zzzeek: ping. i need some relationship advice :) | 00:51 |
|---|---|---|
| *** kgiusti has joined #openstack-oslo | 00:54 | |
| *** EinstCrazy has joined #openstack-oslo | 00:56 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow for alterations in decider 'area of influence' (WIP) https://review.openstack.org/246051 | 01:12 |
| *** rohit_ has joined #openstack-oslo | 01:21 | |
| *** rohit_ has quit IRC | 01:23 | |
| *** rohit_ has joined #openstack-oslo | 01:23 | |
| *** nikhil_k has joined #openstack-oslo | 01:23 | |
| *** nikhil has quit IRC | 01:25 | |
| *** salv-orlando has quit IRC | 01:25 | |
| *** links has joined #openstack-oslo | 01:27 | |
| *** dimtruck is now known as zz_dimtruck | 01:28 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow for alterations in decider 'area of influence' (WIP) https://review.openstack.org/246051 | 01:30 |
| *** ozamiatin_ has quit IRC | 01:36 | |
| rohit_ | https://bugs.launchpad.net/oslo.utils/+bug/1523716 | 01:43 |
| openstack | Launchpad bug 1523716 in oslo.utils "oslo.utils upgrade breaks unit tests" [Undecided,New] | 01:43 |
| rohit_ | Is this going to be fixed or ceikometer can skip this version? | 01:44 |
| openstackgerrit | Merged openstack/oslo.utils: Revert "Move netifaces to extras" https://review.openstack.org/254379 | 01:45 |
| *** Yingxin_ has joined #openstack-oslo | 01:49 | |
| *** Yingxin has quit IRC | 01:53 | |
| *** Yingxin_ is now known as Yingxin | 01:53 | |
| *** jerrygb has joined #openstack-oslo | 02:14 | |
| *** jerrygb has quit IRC | 02:16 | |
| *** cprmrf has joined #openstack-oslo | 02:25 | |
| *** itisha has quit IRC | 02:26 | |
| *** yottatsa has joined #openstack-oslo | 02:39 | |
| *** browne has quit IRC | 02:39 | |
| *** vilobhmm11 has quit IRC | 02:41 | |
| *** vilobhmm11 has joined #openstack-oslo | 02:41 | |
| *** deray has joined #openstack-oslo | 02:45 | |
| *** yottatsa has quit IRC | 02:50 | |
| *** yamahata has quit IRC | 02:51 | |
| *** zz_dimtruck is now known as dimtruck | 03:05 | |
| *** edmondsw has quit IRC | 03:07 | |
| harlowja | dims dhellmann https://review.openstack.org/#/c/254523/ | 03:18 |
| dhellmann | harlowja : stevemar beat you to that oslo.utils request by a couple of minutes | 03:19 |
| harlowja | oh damn, i should not be talking | 03:19 |
| dhellmann | https://review.openstack.org/254519 | 03:19 |
| dhellmann | :-) | 03:19 |
| dhellmann | I | 03:19 |
| harlowja | lol | 03:19 |
| harlowja | talking/chatting | 03:19 |
| harlowja | lol | 03:19 |
| dhellmann | I'll give the jobs a few minutes to run and come back and do the release | 03:19 |
| harlowja | :-P | 03:19 |
| harlowja | k | 03:19 |
| *** deray has quit IRC | 03:23 | |
| *** browne has joined #openstack-oslo | 03:24 | |
| *** dimtruck is now known as zz_dimtruck | 03:24 | |
| dhellmann | harlowja, stevemar: any reason that's 3.2.0 instead of 3.1.1? | 03:27 |
| *** yamamoto has joined #openstack-oslo | 03:29 | |
| *** salv-orlando has joined #openstack-oslo | 03:29 | |
| *** salv-orlando has quit IRC | 03:34 | |
| *** cprmrf has quit IRC | 03:34 | |
| *** jerrygb has joined #openstack-oslo | 03:35 | |
| openstackgerrit | Vilobh Meshram proposed openstack/tooz: Add Consul Driver https://review.openstack.org/245362 | 03:38 |
| *** cprmrf has joined #openstack-oslo | 03:38 | |
| openstackgerrit | Vilobh Meshram proposed openstack/tooz: Add Consul Driver https://review.openstack.org/245362 | 03:38 |
| stevemar | dhellmann: it's a change to the requirements file, so bump to 3.2.0 instead of 3.1.1 no? | 03:39 |
| dhellmann | stevemar : we dropped a requirement that wasn't being used, so we probably don't need to, but it's fine | 03:40 |
| dhellmann | oh, wait, no, you're right, we restored something too didn't we | 03:40 |
| dhellmann | I was just looking at the babel change | 03:40 |
| * dhellmann should go back to his glass of wine | 03:40 | |
| *** deray has joined #openstack-oslo | 03:40 | |
| stevemar | yep, it went 3.0.0 -> 3.1.0 (drop netifaces), so i figured if we bring back netifaces, it should be 3.2.0 | 03:41 |
| *** vilobhmm11 has quit IRC | 03:42 | |
| *** cprmrf__ has joined #openstack-oslo | 03:49 | |
| *** jecarey has joined #openstack-oslo | 03:51 | |
| *** cprmrf has quit IRC | 03:51 | |
| *** jecarey has quit IRC | 03:56 | |
| *** jecarey has joined #openstack-oslo | 04:04 | |
| *** mc_nair_ has quit IRC | 04:09 | |
| openstackgerrit | Sachi King proposed openstack-dev/pbr: WIP: Handle markers to support sdist on pip < 6 https://review.openstack.org/253289 | 04:13 |
| *** cprmrf__ has quit IRC | 04:27 | |
| *** rohit_ has quit IRC | 04:30 | |
| *** ViswaV has quit IRC | 04:34 | |
| *** ViswaV has joined #openstack-oslo | 04:38 | |
| *** boris-42_ has quit IRC | 04:43 | |
| *** pratikmallya has joined #openstack-oslo | 04:43 | |
| *** deray has quit IRC | 04:51 | |
| *** yamahata has joined #openstack-oslo | 04:53 | |
| *** deray has joined #openstack-oslo | 04:59 | |
| *** amotoki has joined #openstack-oslo | 05:20 | |
| *** amotoki has quit IRC | 05:48 | |
| *** jerrygb has quit IRC | 05:50 | |
| *** jaypipes has joined #openstack-oslo | 05:57 | |
| *** dims has quit IRC | 05:57 | |
| *** yamahata has quit IRC | 05:58 | |
| *** yamahata has joined #openstack-oslo | 05:58 | |
| *** harlowja_at_home has joined #openstack-oslo | 06:03 | |
| *** yamahata has quit IRC | 06:04 | |
| *** yamahata has joined #openstack-oslo | 06:09 | |
| *** ildikov has quit IRC | 06:16 | |
| *** pratikmallya has quit IRC | 06:18 | |
| *** dims has joined #openstack-oslo | 06:20 | |
| dims | stevemar : harlowja : dhellmann : thanks for handling the netifaces break | 06:24 |
| stevemar | dims: my pleasure boss | 06:24 |
| dims | :) | 06:27 |
| *** amotoki has joined #openstack-oslo | 06:30 | |
| *** pballand has quit IRC | 06:32 | |
| *** e0ne has joined #openstack-oslo | 06:38 | |
| openstackgerrit | Merged openstack-dev/cookiecutter: Match locale dir to the current infra script https://review.openstack.org/252930 | 06:42 |
| openstackgerrit | Merged openstack/oslotest: Trival: Remove 'MANIFEST.in' https://review.openstack.org/253791 | 06:44 |
| *** e0ne has quit IRC | 06:45 | |
| *** salv-orlando has joined #openstack-oslo | 06:49 | |
| *** e0ne has joined #openstack-oslo | 06:49 | |
| openstackgerrit | Tan Lin proposed openstack/oslo.config: Make PortOpt accept choices parameter https://review.openstack.org/251729 | 06:50 |
| openstackgerrit | Tan Lin proposed openstack/oslo.config: Add new parameter `choices` to Integer type https://review.openstack.org/251700 | 06:50 |
| *** vilobhmm11 has joined #openstack-oslo | 06:50 | |
| *** e0ne has quit IRC | 06:52 | |
| *** salv-orlando has quit IRC | 06:54 | |
| *** e0ne has joined #openstack-oslo | 07:02 | |
| *** dims has quit IRC | 07:11 | |
| *** vilobhmm11 has quit IRC | 07:18 | |
| *** e0ne has quit IRC | 07:20 | |
| *** e0ne has joined #openstack-oslo | 07:21 | |
| *** nkrinner has joined #openstack-oslo | 07:22 | |
| openstackgerrit | Joshua Harlow proposed openstack/taskflow: Allow for alterations in decider 'area of influence' (WIP) https://review.openstack.org/246051 | 07:30 |
| *** harlowja_at_home has quit IRC | 07:30 | |
| *** dims has joined #openstack-oslo | 07:31 | |
| *** shardy has joined #openstack-oslo | 07:40 | |
| *** jaypipes has quit IRC | 07:44 | |
| openstackgerrit | Merged openstack/oslo.policy: Don't generate doc from test https://review.openstack.org/254061 | 07:46 |
| *** I has joined #openstack-oslo | 07:50 | |
| *** I is now known as Guest34932 | 07:50 | |
| *** dims has quit IRC | 07:52 | |
| *** e0ne has quit IRC | 07:56 | |
| *** ildikov has joined #openstack-oslo | 08:03 | |
| openstackgerrit | Eric Brown proposed openstack/oslo.config: Test equality of types.String choices as a set https://review.openstack.org/254599 | 08:03 |
| *** jerrygb has joined #openstack-oslo | 08:06 | |
| *** jerrygb has quit IRC | 08:12 | |
| openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Fix notifier options registration https://review.openstack.org/254604 | 08:15 |
| openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: batch notification listener https://review.openstack.org/234716 | 08:15 |
| openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: notif: Check the driver features in dispatcher https://review.openstack.org/251737 | 08:15 |
| openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: creates a dispatcher abstraction https://review.openstack.org/251736 | 08:15 |
| *** deray has quit IRC | 08:20 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.policy: Make sure item of policy_dirs is directory https://review.openstack.org/254607 | 08:25 |
| *** gcb has joined #openstack-oslo | 08:27 | |
| *** markus_z has joined #openstack-oslo | 08:37 | |
| *** ozamiatin_ has joined #openstack-oslo | 08:38 | |
| *** yamahata has quit IRC | 08:43 | |
| *** deray has joined #openstack-oslo | 08:50 | |
| *** links has quit IRC | 08:55 | |
| *** browne has quit IRC | 08:56 | |
| *** e0ne has joined #openstack-oslo | 09:03 | |
| *** dstufft has quit IRC | 09:04 | |
| *** dstufft has joined #openstack-oslo | 09:04 | |
| *** links has joined #openstack-oslo | 09:09 | |
| *** ndipanov has quit IRC | 09:12 | |
| *** ndipanov has joined #openstack-oslo | 09:13 | |
| *** shakamunyi has joined #openstack-oslo | 09:13 | |
| *** ildikov has quit IRC | 09:16 | |
| *** ildikov has joined #openstack-oslo | 09:18 | |
| *** yassine__ has joined #openstack-oslo | 09:21 | |
| *** shakamunyi has quit IRC | 09:23 | |
| openstackgerrit | zhangsong proposed openstack/oslo.utils: Fix the bug of can't get the desired image info https://review.openstack.org/254630 | 09:24 |
| *** pratikmallya has joined #openstack-oslo | 09:34 | |
| *** mhickey has joined #openstack-oslo | 09:38 | |
| *** andreaf has joined #openstack-oslo | 09:45 | |
| *** ildikov has quit IRC | 09:45 | |
| *** pratikmallya has quit IRC | 09:54 | |
| *** ildikov has joined #openstack-oslo | 09:59 | |
| *** Guest34932 has quit IRC | 10:04 | |
| *** dukhlov has joined #openstack-oslo | 10:05 | |
| dukhlov | sileht: hello | 10:06 |
| sileht | dukhlov, hi | 10:06 |
| dukhlov | sileht: we have discussion about batch_poll in gerrit. but I didn't get you | 10:07 |
| sileht | dukhlov, I have followed your idea | 10:08 |
| dukhlov | could you explain how this new approach provides us more performance? | 10:08 |
| sileht | dukhlov, it doesn't improve performance of oslo.messaging itself | 10:08 |
| sileht | dukhlov, but allow ceilometer to receive many messages into one callback call | 10:09 |
| sileht | dukhlov, so ceilometer can writte in batch all this message to the storage backend | 10:09 |
| sileht | dukhlov, instead of writting each message individually | 10:10 |
| sileht | dukhlov, also for kafka I guess we can use the prefectch capability to do that but that just a optimisation that I will do later | 10:11 |
| openstackgerrit | sonu proposed openstack/oslo.service: Delete python bytecode before every test run https://review.openstack.org/254655 | 10:17 |
| dukhlov | sileht: aha I see. I haven't seen you latest patch before asking, clear now | 10:22 |
| *** salv-orlando has joined #openstack-oslo | 10:25 | |
| *** gcb has quit IRC | 10:29 | |
| *** dukhlov has quit IRC | 10:29 | |
| *** salv-orlando has quit IRC | 10:30 | |
| *** gcb has joined #openstack-oslo | 10:31 | |
| *** cdent has joined #openstack-oslo | 10:37 | |
| *** links has quit IRC | 10:37 | |
| *** yamamoto has quit IRC | 10:48 | |
| *** ozamiatin_ has quit IRC | 10:53 | |
| *** ozamiatin_ has joined #openstack-oslo | 10:56 | |
| *** links has joined #openstack-oslo | 10:58 | |
| *** EinstCrazy has quit IRC | 10:59 | |
| *** openstackgerrit has quit IRC | 11:02 | |
| *** openstackgerrit has joined #openstack-oslo | 11:02 | |
| *** lucas-dinner is now known as lucasagomes | 11:04 | |
| *** salv-orlando has joined #openstack-oslo | 11:06 | |
| *** amotoki has quit IRC | 11:07 | |
| *** deray has quit IRC | 11:10 | |
| *** dguitarbite has quit IRC | 11:13 | |
| *** Kennan has quit IRC | 11:14 | |
| *** salv-orlando has quit IRC | 11:14 | |
| *** Kennan has joined #openstack-oslo | 11:17 | |
| *** EinstCrazy has joined #openstack-oslo | 11:24 | |
| *** dguitarbite has joined #openstack-oslo | 11:26 | |
| *** Kennan has quit IRC | 11:29 | |
| *** kzaitsev_ws has joined #openstack-oslo | 11:30 | |
| *** Kennan has joined #openstack-oslo | 11:32 | |
| *** yamamoto has joined #openstack-oslo | 11:36 | |
| *** Kennan has quit IRC | 11:39 | |
| *** yamamoto has quit IRC | 11:41 | |
| *** Kennan has joined #openstack-oslo | 11:42 | |
| jokke_ | hello | 11:43 |
| *** Kennan has quit IRC | 11:43 | |
| jokke_ | is the oslo.utils 3.2.0 supposed to fix these: "ImportError: No module named netifaces" ? | 11:44 |
| *** yamamoto has joined #openstack-oslo | 11:44 | |
| *** yamamoto has quit IRC | 11:44 | |
| *** mikal has quit IRC | 11:46 | |
| *** Kennan has joined #openstack-oslo | 11:46 | |
| *** yassine__ has quit IRC | 11:46 | |
| *** mikal has joined #openstack-oslo | 11:47 | |
| *** Kennan has quit IRC | 11:47 | |
| *** Kennan has joined #openstack-oslo | 11:50 | |
| *** yamamoto has joined #openstack-oslo | 11:53 | |
| *** yamamoto has quit IRC | 11:53 | |
| *** pratikmallya has joined #openstack-oslo | 11:57 | |
| *** e0ne has quit IRC | 12:03 | |
| *** jerrygb has joined #openstack-oslo | 12:09 | |
| *** e0ne has joined #openstack-oslo | 12:11 | |
| *** jerrygb has quit IRC | 12:13 | |
| *** Kennan has quit IRC | 12:20 | |
| *** Kennan has joined #openstack-oslo | 12:27 | |
| *** gordc has joined #openstack-oslo | 12:31 | |
| *** pc_m has joined #openstack-oslo | 12:33 | |
| *** EinstCra_ has joined #openstack-oslo | 12:35 | |
| *** links has quit IRC | 12:36 | |
| *** EinstCrazy has quit IRC | 12:37 | |
| *** Kennan has quit IRC | 12:48 | |
| *** yassine__ has joined #openstack-oslo | 12:49 | |
| *** yamamoto has joined #openstack-oslo | 12:51 | |
| *** jeckersb is now known as jeckersb_gone | 12:53 | |
| *** Kennan has joined #openstack-oslo | 12:54 | |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: Check devstack gate zmq https://review.openstack.org/229779 | 12:59 |
| *** shardy has quit IRC | 13:09 | |
| *** shardy has joined #openstack-oslo | 13:10 | |
| *** amotoki has joined #openstack-oslo | 13:15 | |
| *** dims has joined #openstack-oslo | 13:16 | |
| dhellmann | jokke_ : yes | 13:21 |
| *** rpodolyaka has quit IRC | 13:21 | |
| lxsli | morning dhellmann, can I enqueue https://review.openstack.org/#/c/253125/ to you please? | 13:22 |
| jokke_ | morning dhellmann and thanks | 13:28 |
| *** edmondsw has joined #openstack-oslo | 13:31 | |
| *** itisha has joined #openstack-oslo | 13:33 | |
| *** zz_dimtruck is now known as dimtruck | 13:34 | |
| *** jaypipes has joined #openstack-oslo | 13:35 | |
| *** yamamoto has quit IRC | 13:40 | |
| *** shardy is now known as shardy_afk | 13:41 | |
| *** jerrygb has joined #openstack-oslo | 13:44 | |
| *** yamamoto has joined #openstack-oslo | 13:46 | |
| *** dimtruck is now known as zz_dimtruck | 13:47 | |
| *** pratikmallya has quit IRC | 13:48 | |
| *** _crobertsrh is now known as crobertsrh | 13:49 | |
| *** regXboi has joined #openstack-oslo | 13:49 | |
| *** fultonj has joined #openstack-oslo | 13:53 | |
| *** kgiusti has joined #openstack-oslo | 13:57 | |
| *** yamamoto has quit IRC | 14:01 | |
| *** jeckersb_gone is now known as jeckersb | 14:01 | |
| *** yamamoto has joined #openstack-oslo | 14:02 | |
| *** nikhil_k is now known as nikhil | 14:05 | |
| *** rlrossit has joined #openstack-oslo | 14:07 | |
| *** crobertsrh has left #openstack-oslo | 14:08 | |
| *** haypo has joined #openstack-oslo | 14:10 | |
| *** pratikmallya has joined #openstack-oslo | 14:10 | |
| *** amrith is now known as _amrith_ | 14:12 | |
| *** rpodolyaka has joined #openstack-oslo | 14:15 | |
| *** yamamoto has quit IRC | 14:24 | |
| *** yamamoto has joined #openstack-oslo | 14:27 | |
| *** mriedem has joined #openstack-oslo | 14:28 | |
| *** lucasagomes is now known as lucas-hungry | 14:42 | |
| *** edmondsw has quit IRC | 14:48 | |
| *** dims_ has joined #openstack-oslo | 14:52 | |
| *** jecarey has quit IRC | 14:52 | |
| *** shardy_afk is now known as shardy | 14:52 | |
| *** dims has quit IRC | 14:55 | |
| *** zz_dimtruck is now known as dimtruck | 15:02 | |
| *** pratikmallya has quit IRC | 15:05 | |
| *** sigmavirus24_awa is now known as sigmavirus24 | 15:06 | |
| *** jerrygb has quit IRC | 15:09 | |
| *** jerrygb has joined #openstack-oslo | 15:10 | |
| *** edmondsw has joined #openstack-oslo | 15:13 | |
| *** jerrygb has quit IRC | 15:15 | |
| *** lucas-hungry is now known as lucasagomes | 15:17 | |
| *** jerrygb has joined #openstack-oslo | 15:24 | |
| openstackgerrit | Alexis Lee proposed openstack/oslo.log: Allow reload of 'debug' option https://review.openstack.org/254821 | 15:28 |
| openstackgerrit | Alexis Lee proposed openstack/oslo.config: Add 'mutable' param to Opt https://review.openstack.org/251471 | 15:30 |
| openstackgerrit | Alexis Lee proposed openstack/oslo.config: Allow parser and namespace modification https://review.openstack.org/253125 | 15:30 |
| *** mtanino has joined #openstack-oslo | 15:33 | |
| openstackgerrit | Alexis Lee proposed openstack/oslo.log: Allow reload of 'debug' option https://review.openstack.org/254821 | 15:33 |
| *** thangp has joined #openstack-oslo | 15:37 | |
| *** thumpba has joined #openstack-oslo | 15:39 | |
| *** _amrith_ is now known as amrith | 15:41 | |
| *** rpodolyaka has quit IRC | 15:41 | |
| *** pratikmallya has joined #openstack-oslo | 15:44 | |
| *** jecarey has joined #openstack-oslo | 15:46 | |
| *** mc_nair has joined #openstack-oslo | 15:52 | |
| *** nkrinner has quit IRC | 15:53 | |
| *** salv-orlando has joined #openstack-oslo | 16:03 | |
| *** salv-orlando has quit IRC | 16:03 | |
| *** salv-orlando has joined #openstack-oslo | 16:03 | |
| *** ozamiatin__ has joined #openstack-oslo | 16:03 | |
| *** yamamoto has quit IRC | 16:04 | |
| *** yamamoto has joined #openstack-oslo | 16:09 | |
| *** rpodolyaka has joined #openstack-oslo | 16:09 | |
| *** vilobhmm11 has joined #openstack-oslo | 16:12 | |
| *** browne has joined #openstack-oslo | 16:16 | |
| *** pradk has joined #openstack-oslo | 16:18 | |
| *** pratikmallya has quit IRC | 16:19 | |
| *** amrith is now known as _amrith_ | 16:21 | |
| *** mriedem is now known as rodermang | 16:23 | |
| *** rodermang is now known as mriedem | 16:23 | |
| *** salv-orl_ has joined #openstack-oslo | 16:26 | |
| *** salv-orlando has quit IRC | 16:29 | |
| *** pratikmallya has joined #openstack-oslo | 16:30 | |
| *** yamamoto has quit IRC | 16:37 | |
| *** boris-42_ has joined #openstack-oslo | 16:44 | |
| *** pballand has joined #openstack-oslo | 16:44 | |
| *** openstackgerrit has quit IRC | 16:47 | |
| *** openstackgerrit has joined #openstack-oslo | 16:47 | |
| *** fultonj has quit IRC | 16:52 | |
| *** alejandrito has joined #openstack-oslo | 16:55 | |
| *** yamahata has joined #openstack-oslo | 16:58 | |
| *** ildikov has quit IRC | 17:02 | |
| *** vilobhmm11 has quit IRC | 17:03 | |
| *** Yingxin has quit IRC | 17:04 | |
| *** Kennan has quit IRC | 17:06 | |
| *** Kennan has joined #openstack-oslo | 17:07 | |
| *** ozamiatin_ has quit IRC | 17:08 | |
| openstackgerrit | Julien Danjou proposed openstack/tooz: Make all locks operate the same when fetched from different coordinators https://review.openstack.org/252115 | 17:10 |
| openstackgerrit | Julien Danjou proposed openstack/tooz: etcd: driver with lock support https://review.openstack.org/246879 | 17:10 |
| *** Yingxin has joined #openstack-oslo | 17:11 | |
| *** amotoki has quit IRC | 17:14 | |
| *** jecarey has quit IRC | 17:16 | |
| *** salv-orl_ has quit IRC | 17:16 | |
| *** Yingxin has quit IRC | 17:26 | |
| *** yassine__ has quit IRC | 17:27 | |
| *** Yingxin has joined #openstack-oslo | 17:31 | |
| *** pratikmallya has quit IRC | 17:36 | |
| *** ViswaV has quit IRC | 17:44 | |
| *** ViswaV has joined #openstack-oslo | 17:47 | |
| *** e0ne has quit IRC | 17:50 | |
| *** _amrith_ is now known as amrith | 17:53 | |
| *** markus_z has quit IRC | 17:57 | |
| *** pratikmallya has joined #openstack-oslo | 18:07 | |
| *** jecarey has joined #openstack-oslo | 18:17 | |
| *** salv-orlando has joined #openstack-oslo | 18:17 | |
| *** alejandrito has quit IRC | 18:19 | |
| *** alejandrito has joined #openstack-oslo | 18:19 | |
| *** jecarey has quit IRC | 18:21 | |
| *** salv-orlando has quit IRC | 18:21 | |
| *** vilobhmm11 has joined #openstack-oslo | 18:25 | |
| *** thangp has quit IRC | 18:25 | |
| *** shakamunyi has joined #openstack-oslo | 18:25 | |
| *** mhickey has quit IRC | 18:26 | |
| *** jaypipes has quit IRC | 18:27 | |
| *** dims_ has quit IRC | 18:30 | |
| mriedem | lifeless: we have a stable branch backwards incompatible issue | 18:35 |
| mriedem | jroll: is there a bug for the ironic failure relatd to https://review.openstack.org/#/c/250571/ ? | 18:36 |
| jroll | context: oslo.messaging 3.1.0 breaking ironic stable/liberty unit tests http://logs.openstack.org/59/254759/1/check/gate-ironic-python27/9e4a526/console.html | 18:36 |
| mriedem | and why are ironic tests failing if oslo.messaging has only deprecated the thing but not removed it? | 18:37 |
| jroll | lucasagomes: ^ did you end up filing a bug for that? | 18:37 |
| jroll | 18:05:03 dims_ | jroll : oslo.messaging was using debtcollector to decorate the RequestContextSerializer as deprecated and ran into this debt collector bug (https://bugs.launchpad.net/debtcollector/+bug/1520397) so i requested this on ironic | 18:37 |
| openstack | Launchpad bug 1520397 in debtcollector "Problem with abstract classes" [Undecided,New] | 18:37 |
| mriedem | or that was the deprecation in 3.1.0 and they just removed it? | 18:37 |
| jroll | master (https://review.openstack.org/#/c/250571/) | 18:37 |
| jroll | that's how dims explained it to me | 18:38 |
| jroll | and recommended the backport | 18:38 |
| lucasagomes | jroll, I didn't, I an fill one up quickly | 18:38 |
| lucasagomes | I can* | 18:38 |
| jroll | so it's a debtcollector bug making this fail where it shouldn't | 18:38 |
| mriedem | jroll: b/c of the decorator? | 18:39 |
| *** jerrygb has quit IRC | 18:39 | |
| *** e0ne has joined #openstack-oslo | 18:39 | |
| jroll | so now that I'm thinking about it more, it's a known backwards compatibility fail, where ironic master was fixed ahead of the release, rather than not releasing a backward incompatible thing | 18:39 |
| jroll | which is... sketchy at best | 18:40 |
| jroll | mriedem: yeah, that decorator doesn't work with abstract classes it seems | 18:40 |
| mriedem | jroll: we should revert the o.m change and blacklist the o.m 3.1.0 version in g-r | 18:40 |
| mriedem | we need a bug reported | 18:41 |
| jroll | lucasagomes: are you doing that or should I? | 18:41 |
| lucasagomes | jroll, I'm on it... | 18:41 |
| jroll | thanks man | 18:41 |
| lucasagomes | jroll, for the stable releases it should be in the normal bug tracker right? | 18:42 |
| lucasagomes | (just mentioning it's in the stable branch) | 18:42 |
| jroll | lucasagomes: yep | 18:42 |
| lucasagomes | cool, 1 min | 18:42 |
| jroll | lucasagomes: the oslo.messaging bug tracker | 18:42 |
| lucasagomes | yeah | 18:43 |
| *** Kennan has quit IRC | 18:43 | |
| *** Kennan has joined #openstack-oslo | 18:44 | |
| *** cdent has quit IRC | 18:45 | |
| *** jerrygb has joined #openstack-oslo | 18:46 | |
| *** rlrossit has quit IRC | 18:46 | |
| mriedem | lucasagomes: jroll: this was the debtcollector bug https://bugs.launchpad.net/debtcollector/+bug/1520397 | 18:46 |
| openstack | Launchpad bug 1520397 in debtcollector "Problem with abstract classes" [Undecided,New] | 18:47 |
| *** jecarey has joined #openstack-oslo | 18:48 | |
| jroll | mriedem: yeah, I saw that | 18:49 |
| mriedem | just need a bug here guys | 18:49 |
| mriedem | then we can start the revert train | 18:50 |
| openstackgerrit | Jim Rollenhagen proposed openstack/oslo.messaging: Revert "serializer: deprecate RequestContextSerializer" https://review.openstack.org/254904 | 18:50 |
| jroll | yep, waiting... | 18:50 |
| *** david-ly_ has joined #openstack-oslo | 18:50 | |
| jroll | there's the revert, just need the bug added to commit msg | 18:50 |
| lucasagomes | mriedem, https://bugs.launchpad.net/oslo.messaging/+bug/1524041 | 18:51 |
| openstack | Launchpad bug 1524041 in oslo.messaging "oslo.messaging 3.1.0 breaking stable releases unit tests" [Undecided,New] | 18:51 |
| *** david-ly_ is now known as david-lyle_ | 18:52 | |
| jroll | thanks lucas | 18:52 |
| *** rlrossit has joined #openstack-oslo | 18:52 | |
| lucasagomes | np | 18:52 |
| *** pballand has quit IRC | 18:52 | |
| openstackgerrit | Jim Rollenhagen proposed openstack/oslo.messaging: Revert "serializer: deprecate RequestContextSerializer" https://review.openstack.org/254904 | 18:52 |
| jroll | added partial-bug there ^ | 18:53 |
| jroll | mriedem: most interesting part of this is that being deprecated AND removed in the same release... | 18:53 |
| mriedem | jroll: yeah, not going to happen | 18:53 |
| *** jecarey has quit IRC | 18:53 | |
| *** jecarey has joined #openstack-oslo | 18:53 | |
| *** david-lyle has quit IRC | 18:54 | |
| jroll | mriedem: it totally just did :P | 18:54 |
| mriedem | well, it's not removed yet | 18:54 |
| mriedem | but the debtcollector bug breaks everything | 18:54 |
| mriedem | but it can't be removed until liberty-eol | 18:54 |
| mriedem | b/c ironic in liberty is using it | 18:54 |
| mriedem | so either they wait to remove in liberty-eol, or we cap o.m in liberty, which lifeless and others are against | 18:55 |
| jroll | right | 18:55 |
| jroll | mhm | 18:55 |
| *** ildikov has joined #openstack-oslo | 18:55 | |
| jroll | mriedem: thanks for the help, man, I'll get the g-r changes up | 18:57 |
| *** jecarey_ has joined #openstack-oslo | 18:58 | |
| mriedem | just did | 18:59 |
| jroll | oh, thanks | 18:59 |
| mriedem | jd__: we either need this revert, or fix debtcollector and release a new required min version, or not use debtcollector and use the warnings module instead https://review.openstack.org/#/c/254904/ | 19:02 |
| *** jecarey has quit IRC | 19:02 | |
| * rlrossit is sad he just barely missed the o.vo release :( | 19:02 | |
| *** openstackgerrit has quit IRC | 19:02 | |
| *** openstackgerrit has joined #openstack-oslo | 19:02 | |
| *** jecarey has joined #openstack-oslo | 19:03 | |
| *** jecarey_ has quit IRC | 19:03 | |
| *** salv-orlando has joined #openstack-oslo | 19:04 | |
| *** salv-orlando has quit IRC | 19:11 | |
| *** david-lyle_ is now known as david-lyle | 19:14 | |
| *** pratikmallya has quit IRC | 19:33 | |
| *** pratikmallya has joined #openstack-oslo | 19:36 | |
| *** fultonj has joined #openstack-oslo | 19:37 | |
| *** harlowja has quit IRC | 19:38 | |
| *** harlowja has joined #openstack-oslo | 19:38 | |
| vipul | question about Oslo.policy -- was it intended to be used outside of the context of an API request? | 19:45 |
| vipul | i.e. are there use cases such as nova-scheduler or some other non-user facing service having to go through policy checks? | 19:45 |
| *** crc32 has joined #openstack-oslo | 19:50 | |
| *** mc_nair_ has joined #openstack-oslo | 19:51 | |
| *** mc_nair has quit IRC | 19:52 | |
| *** mhickey has joined #openstack-oslo | 19:55 | |
| *** jecarey has quit IRC | 20:01 | |
| openstackgerrit | Merged openstack/oslo.versionedobjects: Add a callable to gather extra data for fps https://review.openstack.org/252594 | 20:13 |
| *** lucasagomes is now known as lucas-dinner | 20:13 | |
| openstackgerrit | Merged openstack/oslo.db: Remove iso8601 in requirements.txt https://review.openstack.org/253767 | 20:14 |
| *** jecarey has joined #openstack-oslo | 20:14 | |
| openstackgerrit | Merged openstack/oslo.config: Add new parameter `choices` to Integer type https://review.openstack.org/251700 | 20:17 |
| openstackgerrit | Merged openstack/oslo.db: Trival: Remove 'MANIFEST.in' https://review.openstack.org/253766 | 20:18 |
| *** pballand has joined #openstack-oslo | 20:20 | |
| harlowja | mriedem seems ok with me, the debtcollector bug is more of a key issue, that i think just docs can note as its reasons are more fundamental | 20:29 |
| mriedem | harlowja: yeah, deprecation of things is fine, but we really can't remove this until liberty-eol | 20:30 |
| harlowja | right | 20:30 |
| mriedem | since we aren't capping libs in stable | 20:30 |
| harlowja | thats fine with me | 20:30 |
| mriedem | ok | 20:30 |
| *** haypo_ has joined #openstack-oslo | 20:46 | |
| *** haypo_ has quit IRC | 20:54 | |
| *** jecarey has quit IRC | 20:54 | |
| *** thumpba has quit IRC | 21:02 | |
| openstackgerrit | Brian Curtin proposed openstack/oslosphinx: Use proper decode function name. https://review.openstack.org/254963 | 21:28 |
| openstackgerrit | Matt Riedemann proposed openstack/oslo.db: Don't trace DB errors when we're retrying https://review.openstack.org/254964 | 21:30 |
| mriedem | kevinbenton: rpodolyaka: ^ | 21:31 |
| mriedem | i just wrote a new patch rather than revive the old one | 21:31 |
| *** dims has joined #openstack-oslo | 21:32 | |
| *** crc32 has quit IRC | 21:33 | |
| rlrossit | dims: do you plan on doing a weekly oslo release Monday? Or can I just push up a patch for a new release of o.vo (even though you did it yesterday? | 21:33 |
| *** crc32 has joined #openstack-oslo | 21:34 | |
| dims | rlrossit : did you see the other o.vo reviews in the queue? | 21:36 |
| rlrossit | oh dang there's other reviews in there. I didn't see those :) | 21:37 |
| kevinbenton | mriedem: makes me wonder if oslo db should log that at all | 21:38 |
| mriedem | kevinbenton: between retries? | 21:39 |
| mriedem | debug level w/o the stacktrace doesn't seem bad | 21:40 |
| kevinbenton | mriedem: no, once it fails completely | 21:40 |
| mriedem | oh | 21:40 |
| kevinbenton | mriedem: yeah, the debug is fine | 21:40 |
| kevinbenton | mriedem: i mean the LOG.exception | 21:40 |
| mriedem | in the unexpected case? | 21:40 |
| mriedem | or once we're done retrying? | 21:40 |
| kevinbenton | the caller will already have some exception handling path of some sort | 21:40 |
| mriedem | i wouldn't assume that | 21:40 |
| kevinbenton | done retrying | 21:40 |
| kevinbenton | and we re-raise | 21:40 |
| mriedem | i've seen some pretty bad code | 21:40 |
| mriedem | sorry API user, here is your 500 | 21:41 |
| kevinbenton | well in Neutron this will result in a double-log i think in most cases | 21:41 |
| kevinbenton | it's not the end of the world | 21:41 |
| mriedem | yeah, i'm not opposed to not tracing... | 21:42 |
| mriedem | nova doesn't do a lot of LOG.exception | 21:42 |
| mriedem | i guess i don't feel strongly enough about it to make that change in this change | 21:43 |
| mriedem | if that makes sense | 21:43 |
| dims | mriedem : jroll and i talked about the stable/liberty break. you probably saw that | 21:43 |
| dims | (for neutron) | 21:43 |
| mriedem | dims: nope | 21:44 |
| dims | (for ironic) :) | 21:44 |
| dims | mriedem : looks like you did not like https://review.openstack.org/#/c/254890 and are proposing a revert | 21:45 |
| dims | https://review.openstack.org/#/c/254890 was based off of what we fixed in neutron master | 21:46 |
| dims | it will work on both newer and older oslo.messaging versiosn | 21:46 |
| dims | but i guess it's your and jroll's call | 21:46 |
| mriedem | dims: the problem is the debtcollector bug in oslo.messaging | 21:46 |
| mriedem | that breaks that inheritance in ironic | 21:47 |
| dims | mriedem : we really really want to get rid of that class | 21:47 |
| mriedem | dims: you can't until liberty-eol | 21:47 |
| dims | jd__ : ^^ | 21:47 |
| dims | why not? | 21:47 |
| mriedem | dims: backwards compat | 21:47 |
| mriedem | we aren't capping things in stable | 21:47 |
| mriedem | i also have a block on o.m 3.1.0 here https://review.openstack.org/#/q/status:open+project:openstack/requirements+branch:master+topic:bug/1524041,n,z | 21:47 |
| dims | i mean if we get switch neutron stable to a copy of that class it would still work | 21:47 |
| dims | both with older oslo.messaging and newer oslo.messaging | 21:48 |
| mriedem | dims: that breaks anyone not using that version of ironic in stable | 21:48 |
| mriedem | i mean if you drop the class in o.m | 21:48 |
| mriedem | that breaks ironic in liberty GA, period | 21:48 |
| dims | but that's not what we are testing | 21:48 |
| dims | we are testing stable/liberty branch | 21:49 |
| mriedem | dims: exhibit A https://review.openstack.org/#/c/226157/ | 21:49 |
| dims | and if stable/liberty is good we are good | 21:49 |
| mriedem | dims: that's not how it works in real deployments | 21:49 |
| dims | mriedem : i know, i am trying to draw boundaries | 21:49 |
| dims | we can never make any progress otherwise | 21:49 |
| *** mhickey has quit IRC | 21:49 | |
| mriedem | honestly, if i could cap oslo.messaging at 2.5.0 in stable/liberty, i would have done that weeks ago | 21:49 |
| dims | mriedem that's not my call. we are trying to make progress for mitaka | 21:50 |
| *** salv-orlando has joined #openstack-oslo | 21:50 | |
| dims | that specific doc does not say anything about an ironic release in the field. it talks about stable/branches...no? | 21:50 |
| dims | why would a ironic release in the field use newer oslo.messaging anyway? | 21:51 |
| mriedem | security fixes? | 21:51 |
| dims | apvec on #openstack-stable was asking if liberty oslo.messaging would have any problems and we said no | 21:51 |
| dims | please check traffic on #openstack-stable | 21:51 |
| mriedem | i was on there, that's where i noticed this | 21:52 |
| mriedem | lifeless: ^ are you around for htis? | 21:52 |
| dims | i'll check scroll back when i wake up :) it's 1 AM here | 21:52 |
| mriedem | ok, i'm gone in an hour too | 21:53 |
| dims | i can only guarantee stable/* branches | 21:53 |
| dims | as we test it | 21:53 |
| dims | as long as we make sure we don't break it that's the line | 21:53 |
| dims | ack mriedem | 21:53 |
| dims | thanks | 21:53 |
| *** crc32 has quit IRC | 21:54 | |
| *** salv-orlando has quit IRC | 21:55 | |
| *** crc32 has joined #openstack-oslo | 21:55 | |
| lifeless | mriedem: hi | 21:58 |
| lifeless | mriedem: whatsup ? | 21:58 |
| mriedem | lifeless: questioning https://review.openstack.org/#/c/254911/ | 21:59 |
| *** dims has quit IRC | 21:59 | |
| mriedem | and https://review.openstack.org/#/c/254904/ | 21:59 |
| mriedem | oslo.messaging deprecated RequestContextSerializer in o.m 3.1.0, and does that with a debtcollector wrapper, | 22:00 |
| lifeless | mriedem: ok, reading and paging in | 22:00 |
| mriedem | the debtcollector wrapper has a bug which breaks ironic | 22:00 |
| mriedem | dims put out a fix for ironic on master | 22:00 |
| mriedem | https://review.openstack.org/#/c/250571/ | 22:00 |
| mriedem | that was proposed to stable/liberty also | 22:00 |
| devananda | this broke several projects' gates yesterday | 22:00 |
| devananda | this == the release of o.m 3.1.0 | 22:00 |
| mriedem | devananda: but for the same reason as it broke ironic or other reasons? | 22:01 |
| lifeless | ok so we really need the backward compat gate jobs :/ | 22:01 |
| mriedem | lifeless: so i guess the deprecation isn't a problem in itself, | 22:01 |
| devananda | the offending commit in o.m, for reference: https://github.com/openstack/oslo.utils/commit/2abbe1c3b19490f570c29502cd56ec92daf4ca45 | 22:01 |
| devananda | mriedem: same reason | 22:02 |
| mriedem | devananda: that's oslo.utils | 22:02 |
| mriedem | we're talking about oslo.messaging | 22:02 |
| devananda | ooh | 22:02 |
| mriedem | devananda: i could see how https://github.com/openstack/oslo.utils/commit/2abbe1c3b19490f570c29502cd56ec92daf4ca45 would break things yeah, that should have been a major version bump | 22:02 |
| mriedem | devananda: seems https://review.openstack.org/#/c/248364/ should also be reverted | 22:03 |
| devananda | mriedem: thanks. I didn't realize there was a second problem with oslo releases yesterday | 22:03 |
| mriedem | lifeless: so going back to o.m, | 22:03 |
| lifeless | mriedem: https://review.openstack.org/#/c/254379/ | 22:03 |
| mriedem | they want to remove this deprecated RequestContextSerializer | 22:03 |
| lifeless | mriedem: that was the revert I think | 22:03 |
| mriedem | ah good | 22:03 |
| mriedem | we should also blacklist oslo.utils 3.1.0 and 3.2.0 in g-r | 22:03 |
| lifeless | no dims either :/ | 22:04 |
| lifeless | no for hours | 22:04 |
| lifeless | [and he has a -2 on the patch] | 22:04 |
| mriedem | so anyway, my point was they shouldn't remove RequestContextSerializer since that's backwards incompatible with ironic in stable/liberty | 22:04 |
| mriedem | unless we do https://review.openstack.org/#/c/254890 | 22:05 |
| *** salv-orlando has joined #openstack-oslo | 22:05 | |
| mriedem | it was noted that o.m u-c in stable/liberty is 2.5.0 https://github.com/openstack/requirements/blob/stable/liberty/upper-constraints.txt#L195 | 22:06 |
| lifeless | mriedem: when was it deprecated ? | 22:06 |
| mriedem | lifeless: this week? | 22:06 |
| lifeless | ahahahah | 22:06 |
| lifeless | no | 22:06 |
| mriedem | https://review.openstack.org/#/c/244562/ | 22:06 |
| lifeless | if it was deprecated this week, it needs to stay to liberty mitaka EOL | 22:06 |
| lifeless | erm liberty/mitaka | 22:06 |
| mriedem | that's essentially what i was saying | 22:06 |
| lifeless | [depending on whether an independent server release in mitaka uses it | 22:07 |
| lifeless | thats crystal clear and we have broad consensus on that in the [not yet approved] backwards compat spec | 22:07 |
| mriedem | dims was thinking that as long as stable/liberty works with this version of o.m it's all good, | 22:07 |
| mriedem | but i was disagreeing that people that have deployed ironic before https://review.openstack.org/#/c/254890/ would be broken | 22:07 |
| mriedem | if they moved up to newer o.m | 22:07 |
| mriedem | *disagreeing with the assertion that as long as stable/liberty ironic is ok upstream for us, it's fine downstream | 22:08 |
| lifeless | so I don't know if we have the test bandwidth to test at-point-of-release *and* current-version | 22:08 |
| mriedem | well, furthermore, i think this was unit test only fail | 22:08 |
| lifeless | but the spirit of the backwards comapt exercise is to work with both | 22:08 |
| lifeless | and that clearly won't | 22:08 |
| mriedem | which doesn't currently adhere to constraints | 22:08 |
| lifeless | do you think the failure indicates a likely production fail? | 22:09 |
| lifeless | Or was it an oddity in unit tests? | 22:09 |
| mriedem | jroll: ^ | 22:09 |
| *** vilobhmm11 has quit IRC | 22:10 | |
| *** david-ly_ has joined #openstack-oslo | 22:10 | |
| *** vilobhmm11 has joined #openstack-oslo | 22:10 | |
| *** pratikma_ has joined #openstack-oslo | 22:10 | |
| mriedem | i am sort of wondering why the ironic dsvm jobs weren't fialing | 22:10 |
| mriedem | *failing | 22:10 |
| mriedem | devananda: ^ any ideas there? | 22:11 |
| devananda | mriedem: off hand, i'm familiar with the o.u bug, not the o.m bug. lemme see if I can reproduce real quick | 22:12 |
| *** david-lyle has quit IRC | 22:13 | |
| *** david-ly_ is now known as david-lyle | 22:13 | |
| *** gonzalo2kx has joined #openstack-oslo | 22:13 | |
| *** pratikmallya has quit IRC | 22:14 | |
| *** pratikma_ has quit IRC | 22:15 | |
| *** crc32 has quit IRC | 22:15 | |
| *** crc32 has joined #openstack-oslo | 22:16 | |
| lifeless | mriedem: they were constrained? | 22:18 |
| *** ViswaV has quit IRC | 22:18 | |
| mriedem | lifeless: yup | 22:20 |
| mriedem | that's it | 22:20 |
| *** ViswaV has joined #openstack-oslo | 22:20 | |
| *** ndipanov has quit IRC | 22:21 | |
| lifeless | ok so we do believe that this would break production ironic | 22:21 |
| lifeless | seems like worth blacklisting and pulling from pypi | 22:21 |
| mriedem | yeah i think so | 22:21 |
| mriedem | RequestContextSerializer is a global type in ironic rpc | 22:21 |
| devananda | mriedem: reproduced, and yes it would break production | 22:22 |
| devananda | http://paste.openstack.org/show/481251/ | 22:22 |
| devananda | I can not start the conductor process | 22:23 |
| mriedem | ok | 22:23 |
| mriedem | lifeless: so right now today, stable/liberty u-c for o.m is 2.5.0 | 22:23 |
| mriedem | https://github.com/openstack/requirements/blob/stable/liberty/upper-constraints.txt#L195 | 22:23 |
| mriedem | so deployments *today* should not move up to higher than 2.5.0 | 22:23 |
| devananda | that is in a fresh py27 env based on ironic stable/liberty, fwiw | 22:23 |
| mriedem | lifeless: i guess my next question is the ironic tested against the u-c generated constraints on stable/liberty | 22:24 |
| * devananda needs to run to catch a bus, bbl | 22:25 | |
| *** e0ne has quit IRC | 22:26 | |
| *** gonzalo2kx has quit IRC | 22:28 | |
| lifeless | mriedem: EPARSE your last | 22:29 |
| *** jeckersb is now known as jeckersb_gone | 22:30 | |
| mriedem | heh, wrong channel for my other comments | 22:30 |
| mriedem | because it doesn't run ironic in the tests for u-c bumps on master https://review.openstack.org/#/c/254571/ | 22:30 |
| mriedem | so my fear is the generated constraints patch on stable/liberty passes tests with o.m 3.1.0, we think sure it's good, and push it though, and then things are busted for ironic in stable/liberty | 22:31 |
| mriedem | which it does pass gate-tempest-dsvm-full on stable/liberty here https://review.openstack.org/#/c/246211/ | 22:31 |
| mriedem | so if we approved ^ and someone deployed o.m 3.1.0 in liberty, ironic would be broken | 22:31 |
| mriedem | why would someone deploy o.m 3.1.0 in liberty? idk - maybe for bug fixes or security fixes | 22:31 |
| mriedem | this is kind of exactly why i don't see us getting away from capping on major version boundaries in stable | 22:34 |
| mriedem | the test surface is just so big | 22:34 |
| *** crc32 has quit IRC | 22:36 | |
| *** crc32 has joined #openstack-oslo | 22:36 | |
| *** shardy has quit IRC | 22:41 | |
| *** rlrossit has quit IRC | 22:42 | |
| *** pratikmallya has joined #openstack-oslo | 22:43 | |
| *** crc32 has quit IRC | 22:44 | |
| kevinbenton | zzzeek: yo, have a sec? | 22:44 |
| lifeless | mriedem: we should do that | 22:47 |
| lifeless | mriedem: adding more coverage to g-r changes is a thing we want to do | 22:48 |
| lifeless | mriedem: we don't want to add *everything*, but getting representative things is 100% desired | 22:48 |
| lifeless | mriedem: fungi and I had a go with some neutron unit tests last week, foundered on ZUUL_PROJECT being set to requirements itself rather than neutron | 22:48 |
| zzzeek | kevinbenton: sure | 22:49 |
| fungi | lifeless: that was more just braindamage on my part | 22:50 |
| fungi | i should have known better | 22:50 |
| mriedem | lifeless: so i'm not sure how much i care about https://review.openstack.org/#/c/254890/ now, | 22:51 |
| mriedem | lifeless: o.m deprecated a thing, they didn't remove it (yet), | 22:51 |
| mriedem | the problem was the bug in the deprecation (in debtcollector) | 22:51 |
| kevinbenton | zzzeek: so we have this table in Neutron that doesn't have a relationship defined on it | 22:52 |
| mriedem | as long as https://review.openstack.org/#/c/254890/ works on stable/liberty ironic, it might also be ok for if/when o.m removes that thing | 22:52 |
| kevinbenton | zzzeek: https://github.com/openstack/neutron/blob/master/neutron/db/servicetype_db.py#L28-L33 | 22:52 |
| kevinbenton | zzzeek: because it can be associated with multiple resource types | 22:52 |
| zzzeek | kevinbenton: evil | 22:53 |
| kevinbenton | zzzeek: yes :) | 22:53 |
| *** fultonj has quit IRC | 22:53 | |
| lifeless | fungi: better than to try? | 22:53 |
| kevinbenton | zzzeek: so then the issue is that if someone calls this https://github.com/openstack/neutron/blob/master/neutron/db/servicetype_db.py#L81-L95 | 22:53 |
| kevinbenton | zzzeek: right after creating a resource | 22:53 |
| *** salv-orlando has quit IRC | 22:53 | |
| kevinbenton | zzzeek: the resource doesn't show that it has a provider association | 22:54 |
| *** salv-orlando has joined #openstack-oslo | 22:54 | |
| zzzeek | kevinbenton: where is Resource, by "Does not show", do you mean, Resource.some_attribute ? | 22:54 |
| kevinbenton | zzzeek: because i don't think sqlalchemy recognizes that the object in the session corresponds to that new record | 22:55 |
| kevinbenton | zzzeek: yep | 22:55 |
| zzzeek | kevinbenton: where's that ? | 22:55 |
| kevinbenton | zzzeek: one sec, looking for the code | 22:55 |
| kevinbenton | zzzeek: https://review.openstack.org/#/c/253884/3/neutron_lbaas/services/loadbalancer/plugin.py | 22:55 |
| fungi | lifeless: well, i should have known better than to assume it would be that trivial. we've been down that road before (cross-testing for oslo libs) | 22:55 |
| zzzeek | kevinbenton: that's not showing me what im asking for | 22:56 |
| fungi | and it was anything but simple to implement | 22:56 |
| zzzeek | kevinbenton: i need to see in code what "resource doesnt show it has a provider association" looks like. there's no relationship here, so how is this "association" manifested ? | 22:56 |
| *** sigmavirus24 is now known as sigmavirus24_awa | 22:56 | |
| zzzeek | kevinbenton: if its some memoized attribute, it needs to expire itself when the session flushes a related object | 22:57 |
| kevinbenton | zzzeek: ah, so L565 does this 'add_resource_allocation' which is the method i linked to above | 22:57 |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: WIP: [zmq] PUB-SUB pipeline. https://review.openstack.org/249326 | 22:57 |
| *** devananda has quit IRC | 22:57 | |
| kevinbenton | zzzeek: and then when get_loadbalancer is called, it's not present in the resulting dict it's converted to | 22:57 |
| kevinbenton | zzzeek: and the load balancer object is created right before add_resource_allocation | 22:58 |
| kevinbenton | zzzeek: hang on, i'll find the model definition for you for the load balancer | 22:58 |
| fungi | lifeless: though if we try to do a less generalized solution than oslotest's it's likely not as complicated to make work | 22:59 |
| *** amrith is now known as _amrith_ | 22:59 | |
| kevinbenton | zzzeek: https://github.com/openstack/neutron-lbaas/blob/master/neutron_lbaas/db/loadbalancer/models.py#L186-L196 | 22:59 |
| kevinbenton | zzzeek: sorry, took me a sec. not as familiar with the lbaas code | 22:59 |
| zzzeek | kevinbenton: you want .provider to just query every time? you can make it lazy='dynamic' | 23:01 |
| lifeless | fungi: I need to look closely at that | 23:01 |
| lifeless | fungi: it appeared more complex to me, but ENAIVE // dunning-krubar | 23:01 |
| jroll | lifeless: mriedem: so, I think https://review.openstack.org/#/c/254904 is still the right thing to do. while it isn't intended to be an API break, the debtcollector bug makes it one. it clearly breaks users of the library, even if we fixed the one *known* user, there may be more unknown users out there | 23:01 |
| lifeless | kruger | 23:02 |
| zzzeek | kevinbenton: otherwise you'd do expire_all(), which is way too heavyhanded, or maybe assign to it via a backref, but then that changes add_resource_association | 23:02 |
| fungi | krubar is more like foobar though | 23:02 |
| openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: WIP: [zmq] PUB-SUB pipeline. https://review.openstack.org/249326 | 23:02 |
| zzzeek | kevinbenton: you just need to look up the related object you care about and expire the .provider attribute | 23:02 |
| zzzeek | kevinbenton: or perhaps, just look in the identity map for it, that will tell you if its already loaded | 23:02 |
| zzzeek | kevinbenton: but not actually query for it | 23:03 |
| mriedem | jroll: yeah i think we need the g-r blacklist for that reason | 23:03 |
| mriedem | jroll: rather than revert, we could just not use debtcollector here too | 23:03 |
| mriedem | and just using the warnings module | 23:03 |
| mriedem | but it doesn't matter too much to me how it's actually fixed | 23:03 |
| kevinbenton | zzzeek: right, so we could just expire the object right after the add_resource_association call | 23:04 |
| jroll | mriedem: ditto, I'm not familiar with the warnings module and such, and I also don't want to get into the discussion of "when is the right time to remove this" if I change that deprecation | 23:04 |
| zzzeek | kevinbenton: yep | 23:04 |
| kevinbenton | zzzeek: i was just wondering if there was some magic thing we could put on that provider association table to tell sqlaclhemy to look for anything in memory with that id | 23:04 |
| lifeless | jroll: I agree | 23:04 |
| kevinbenton | zzzeek: and expire it | 23:04 |
| *** mriedem is now known as mriedem_away | 23:09 | |
| zzzeek | kevinbenton: there's events, you can catch those, then you can look in the identity map for the thing you want, then you can expire it | 23:14 |
| kevinbenton | oh, i guess we can look in the identity map right during that add_provider_association method | 23:15 |
| kevinbenton | zzzeek: since i think that's the only thing that creates them | 23:15 |
| kevinbenton | zzzeek: thanks for your help | 23:15 |
| zzzeek | kevinbenton: looking in the identity map is a little bit manual, you need to make an identity key | 23:16 |
| zzzeek | kevinbenton: probably there sohuld be a nicer way | 23:16 |
| kevinbenton | zzzeek: maybe it's easier to just call expire_all() then? | 23:16 |
| zzzeek | kevinbenton: thats very wasteful | 23:16 |
| kevinbenton | zzzeek: an expire doesn't trigger new lookups until something accesses the expired objects, or does it do it right then? | 23:18 |
| *** regXboi has quit IRC | 23:18 | |
| zzzeek | kevinbenton: an expire just empties it out, will load when next accessed | 23:18 |
| kevinbenton | zzzeek: right, so in this particular method it should be pretty cheap because the next call just reloads the object we are expiring anyway | 23:19 |
| kevinbenton | zzzeek: and returns to the user at that point | 23:19 |
| *** edmondsw has quit IRC | 23:21 | |
| *** ozamiatin_ has joined #openstack-oslo | 23:22 | |
| *** yamamoto has joined #openstack-oslo | 23:23 | |
| *** jeckersb_gone is now known as jeckersb | 23:33 | |
| *** pradk has quit IRC | 23:35 | |
| *** yamamoto has quit IRC | 23:40 | |
| *** gordc has quit IRC | 23:41 | |
| *** ViswaV_ has joined #openstack-oslo | 23:50 | |
| *** ViswaV has quit IRC | 23:51 | |
| *** Yingxin_ has joined #openstack-oslo | 23:53 | |
| *** ozamiatin_ has quit IRC | 23:53 | |
| *** jerrygb has quit IRC | 23:55 | |
| *** jerrygb has joined #openstack-oslo | 23:56 | |
| *** Yingxin has quit IRC | 23:56 | |
| *** Yingxin_ is now known as Yingxin | 23:56 | |
| *** takedakn has joined #openstack-oslo | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!