*** amotoki has joined #openstack-oslo | 00:00 | |
*** jecarey has joined #openstack-oslo | 00:01 | |
openstackgerrit | Vilobh Meshram proposed openstack/tooz: Add Consul Driver https://review.openstack.org/245362 | 00:03 |
---|---|---|
boris-42 | harlowja: oh nooo osprofiler bug | 00:04 |
harlowja | lol | 00:04 |
harlowja | ya, just use issues imho boris-42 | 00:04 |
harlowja | trace_cls scares me, lol | 00:05 |
*** jecarey has quit IRC | 00:06 | |
*** yamamoto_ has quit IRC | 00:06 | |
boris-42 | harlowja: Russian mafia code =) | 00:07 |
harlowja | def | 00:07 |
harlowja | boris-mafia | 00:07 |
harlowja | lol | 00:07 |
*** amotoki has quit IRC | 00:15 | |
*** salv-orl_ has quit IRC | 00:17 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Avoid process based executor task proxying-back ANY event https://review.openstack.org/272326 | 00:17 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Avoid process based executor task proxying-back ANY event https://review.openstack.org/272326 | 00:19 |
*** vilobhmm11 has quit IRC | 00:22 | |
*** vilobhmm11 has joined #openstack-oslo | 00:22 | |
*** EinstCrazy has quit IRC | 00:25 | |
*** zz_dimtruck is now known as dimtruck | 00:29 | |
openstackgerrit | Merged openstack/taskflow: Pass through run timeout in engine run() https://review.openstack.org/253131 | 00:30 |
*** zqfan has joined #openstack-oslo | 00:34 | |
*** david-lyle has joined #openstack-oslo | 00:42 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use the notifier library inside the oslo.messaging notifier https://review.openstack.org/272341 | 00:55 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use the notifier library inside the oslo.messaging notifier https://review.openstack.org/272341 | 00:56 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use the notifier library inside the oslo.messaging notifier https://review.openstack.org/272341 | 01:02 |
*** amotoki has joined #openstack-oslo | 01:04 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Use the notifier library inside the oslo.messaging notifier https://review.openstack.org/272341 | 01:05 |
*** salv-orlando has joined #openstack-oslo | 01:17 | |
*** salv-orlando has quit IRC | 01:20 | |
*** jecarey has joined #openstack-oslo | 01:22 | |
*** jecarey has quit IRC | 01:27 | |
*** mtanino__ has quit IRC | 01:30 | |
*** EinstCrazy has joined #openstack-oslo | 01:33 | |
*** salv-orlando has joined #openstack-oslo | 01:54 | |
*** EinstCrazy has quit IRC | 01:58 | |
*** salv-orlando has quit IRC | 01:59 | |
*** david-lyle has quit IRC | 02:05 | |
*** dimtruck is now known as zz_dimtruck | 02:09 | |
*** jecarey has joined #openstack-oslo | 02:10 | |
*** EinstCrazy has joined #openstack-oslo | 02:10 | |
*** davidlenwell has quit IRC | 02:14 | |
*** yamamoto_ has joined #openstack-oslo | 02:16 | |
*** davidlenwell has joined #openstack-oslo | 02:16 | |
*** salv-orlando has joined #openstack-oslo | 02:19 | |
*** salv-orlando has quit IRC | 02:27 | |
*** thumpba has joined #openstack-oslo | 02:29 | |
*** EinstCrazy has quit IRC | 02:30 | |
*** EinstCrazy has joined #openstack-oslo | 02:31 | |
*** salv-orlando has joined #openstack-oslo | 02:41 | |
*** yamamoto_ has quit IRC | 02:42 | |
*** salv-orlando has quit IRC | 02:48 | |
*** superflyy has joined #openstack-oslo | 02:50 | |
*** ansiwen_ has joined #openstack-oslo | 02:52 | |
*** EinstCrazy has quit IRC | 02:59 | |
*** EinstCrazy has joined #openstack-oslo | 03:00 | |
*** vilobhmm11 has quit IRC | 03:02 | |
*** pradk has quit IRC | 03:02 | |
*** ansiwen_ has quit IRC | 03:03 | |
*** ansiwen has joined #openstack-oslo | 03:03 | |
*** achanda has joined #openstack-oslo | 03:09 | |
openstackgerrit | Merged openstack/taskflow: Retrieve the store from flowdetails as well, if it exists https://review.openstack.org/239945 | 03:12 |
*** zz_dimtruck is now known as dimtruck | 03:13 | |
*** browne has quit IRC | 03:15 | |
*** pradk has joined #openstack-oslo | 03:16 | |
*** david-lyle has joined #openstack-oslo | 03:25 | |
*** yamamoto_ has joined #openstack-oslo | 03:28 | |
*** bnemec has quit IRC | 03:34 | |
openstackgerrit | Jamie Lennox proposed openstack/oslo.context: Standardize an oslo.policy credentials dictionary https://review.openstack.org/271929 | 03:37 |
openstackgerrit | Jamie Lennox proposed openstack/oslo.context: Add roles to context https://review.openstack.org/271928 | 03:37 |
*** bnemec has joined #openstack-oslo | 03:38 | |
*** amotoki_ has joined #openstack-oslo | 03:42 | |
*** yamahata has quit IRC | 03:43 | |
*** dims has joined #openstack-oslo | 03:49 | |
*** dims has quit IRC | 03:51 | |
*** mtanino has quit IRC | 03:51 | |
*** mtanino_ has quit IRC | 03:51 | |
*** harlowja has quit IRC | 03:54 | |
*** dims has joined #openstack-oslo | 03:56 | |
*** superflyy has quit IRC | 04:01 | |
*** EinstCrazy has quit IRC | 04:01 | |
*** dims has quit IRC | 04:05 | |
*** browne has joined #openstack-oslo | 04:05 | |
*** amotoki has quit IRC | 04:08 | |
*** amotoki_ has quit IRC | 04:20 | |
*** achanda has quit IRC | 04:23 | |
*** achanda has joined #openstack-oslo | 04:23 | |
*** amotoki has joined #openstack-oslo | 04:28 | |
*** achanda has quit IRC | 04:36 | |
*** dimtruck is now known as zz_dimtruck | 04:38 | |
*** stevemar has quit IRC | 04:47 | |
*** pradk has quit IRC | 04:56 | |
*** yamahata has joined #openstack-oslo | 04:56 | |
*** stevemar_znc has joined #openstack-oslo | 04:57 | |
*** pradk has joined #openstack-oslo | 05:08 | |
*** ansiwen has quit IRC | 05:16 | |
*** zqfan has quit IRC | 05:21 | |
*** yamamot__ has joined #openstack-oslo | 05:25 | |
*** yamamoto_ has quit IRC | 05:26 | |
*** EinstCrazy has joined #openstack-oslo | 05:41 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Avoid process based executor task proxying-back ANY event https://review.openstack.org/272326 | 05:57 |
*** EinstCrazy has quit IRC | 06:04 | |
*** amotoki has quit IRC | 06:19 | |
*** EinstCrazy has joined #openstack-oslo | 06:26 | |
*** redrobot has left #openstack-oslo | 06:26 | |
*** redrobot has joined #openstack-oslo | 06:27 | |
*** achanda has joined #openstack-oslo | 06:28 | |
*** thumpba has quit IRC | 06:29 | |
*** zqfan has joined #openstack-oslo | 06:31 | |
*** thumpba has joined #openstack-oslo | 06:34 | |
*** salv-orlando has joined #openstack-oslo | 06:38 | |
*** EinstCrazy has quit IRC | 06:40 | |
*** zqfan has quit IRC | 06:40 | |
*** EinstCrazy has joined #openstack-oslo | 06:41 | |
*** salv-orlando has quit IRC | 06:42 | |
*** rcernin has joined #openstack-oslo | 06:53 | |
*** salv-orlando has joined #openstack-oslo | 06:56 | |
*** thumpba has quit IRC | 07:05 | |
*** thumpba has joined #openstack-oslo | 07:06 | |
*** thumpba has quit IRC | 07:09 | |
*** vilobhmm11 has joined #openstack-oslo | 07:15 | |
*** nkrinner has joined #openstack-oslo | 07:24 | |
*** EinstCrazy has quit IRC | 07:26 | |
*** amotoki has joined #openstack-oslo | 07:27 | |
*** salv-orlando has quit IRC | 07:46 | |
*** EinstCrazy has joined #openstack-oslo | 08:00 | |
*** thumpba has joined #openstack-oslo | 08:08 | |
*** thumpba has quit IRC | 08:09 | |
*** vilobhmm11 has quit IRC | 08:10 | |
*** EinstCra_ has joined #openstack-oslo | 08:13 | |
*** EinstCrazy has quit IRC | 08:14 | |
*** zakora has joined #openstack-oslo | 08:22 | |
*** achanda has quit IRC | 08:23 | |
*** shardy has joined #openstack-oslo | 08:24 | |
*** amotoki has quit IRC | 08:28 | |
*** amotoki has joined #openstack-oslo | 08:29 | |
*** dtardivel has joined #openstack-oslo | 08:41 | |
*** salv-orlando has joined #openstack-oslo | 08:47 | |
*** salv-orlando has quit IRC | 09:01 | |
*** mriedem has joined #openstack-oslo | 09:01 | |
*** salv-orlando has joined #openstack-oslo | 09:03 | |
*** lucas-dinner is now known as lucasagomes | 09:12 | |
*** browne has quit IRC | 09:14 | |
*** ndipanov has joined #openstack-oslo | 09:16 | |
*** cdent has joined #openstack-oslo | 09:17 | |
*** ihrachys has joined #openstack-oslo | 09:18 | |
*** toabctl_ has quit IRC | 09:21 | |
*** yassine__ has joined #openstack-oslo | 09:21 | |
*** toabctl_ has joined #openstack-oslo | 09:22 | |
*** achanda has joined #openstack-oslo | 09:24 | |
*** jaypipes has joined #openstack-oslo | 09:25 | |
*** ihrachys has quit IRC | 09:26 | |
*** achanda has quit IRC | 09:30 | |
*** mhickey has joined #openstack-oslo | 09:32 | |
*** nihilifer has quit IRC | 09:35 | |
*** nihilifer has joined #openstack-oslo | 09:38 | |
*** EinstCra_ has quit IRC | 09:48 | |
openstackgerrit | Alexis Lee proposed openstack/oslo.config: Warn if immutable options change https://review.openstack.org/268088 | 10:02 |
openstackgerrit | Alexis Lee proposed openstack/oslo.config: Report mutated options https://review.openstack.org/268089 | 10:02 |
openstackgerrit | Alexis Lee proposed openstack/oslo.config: Fake attrs on _Namespace https://review.openstack.org/264847 | 10:02 |
openstackgerrit | Alexis Lee proposed openstack/oslo.config: Make _Namespace the value-holder https://review.openstack.org/264787 | 10:02 |
openstackgerrit | Alexis Lee proposed openstack/oslo.config: Add 'mutable' param to Opt https://review.openstack.org/251471 | 10:02 |
openstackgerrit | Alexis Lee proposed openstack/oslo.config: Make list_all_sections return a list https://review.openstack.org/270212 | 10:04 |
*** salv-orl_ has joined #openstack-oslo | 10:06 | |
*** cdent has quit IRC | 10:08 | |
*** salv-orlando has quit IRC | 10:08 | |
*** cdent has joined #openstack-oslo | 10:10 | |
*** jamielennox is now known as jamielennox|away | 10:15 | |
*** cdent has quit IRC | 10:18 | |
*** cdent has joined #openstack-oslo | 10:20 | |
*** jamielennox|away is now known as jamielennox | 10:25 | |
*** achanda has joined #openstack-oslo | 10:27 | |
*** yamamot__ has quit IRC | 10:27 | |
openstackgerrit | Dmitriy Ukhlov proposed openstack/oslo.messaging: Adds document and configuration guide https://review.openstack.org/272152 | 10:28 |
*** achanda has quit IRC | 10:33 | |
*** EinstCrazy has joined #openstack-oslo | 10:38 | |
*** yamahata has quit IRC | 10:44 | |
*** salv-orl_ has quit IRC | 10:45 | |
*** ihrachys has joined #openstack-oslo | 10:49 | |
*** yassine__ has quit IRC | 10:51 | |
*** ansiwen has joined #openstack-oslo | 10:59 | |
*** kertis has left #openstack-oslo | 11:01 | |
*** salv-orlando has joined #openstack-oslo | 11:01 | |
*** amotoki has quit IRC | 11:20 | |
*** ihrachys has quit IRC | 11:21 | |
*** ihrachys has joined #openstack-oslo | 11:24 | |
openstackgerrit | Javier Peña proposed openstack/oslo.config: Do not fail on funky config option help https://review.openstack.org/272476 | 11:25 |
openstackgerrit | Javier Peña proposed openstack/oslo.config: Do not fail on certain config option help strings https://review.openstack.org/272476 | 11:26 |
*** achanda has joined #openstack-oslo | 11:30 | |
*** achanda has quit IRC | 11:35 | |
*** amotoki has joined #openstack-oslo | 11:56 | |
*** pbourke has quit IRC | 12:02 | |
*** pbourke has joined #openstack-oslo | 12:03 | |
*** mkoderer_cloud has joined #openstack-oslo | 12:05 | |
*** salv-orlando has quit IRC | 12:11 | |
*** salv-orlando has joined #openstack-oslo | 12:13 | |
*** yamamoto has joined #openstack-oslo | 12:15 | |
*** _amrith_ is now known as amrith | 12:20 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Reduce proxy for direct messaging https://review.openstack.org/272085 | 12:21 |
*** yamamoto has quit IRC | 12:23 | |
*** yamamoto has joined #openstack-oslo | 12:24 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Reduce proxy for direct messaging https://review.openstack.org/272085 | 12:26 |
openstackgerrit | Yulia Portnova proposed openstack/oslo.messaging: Improve simulator.py https://review.openstack.org/272505 | 12:26 |
*** dims has joined #openstack-oslo | 12:28 | |
*** yamamoto has quit IRC | 12:28 | |
*** dims has quit IRC | 12:45 | |
*** pradk has quit IRC | 12:52 | |
*** yassine__ has joined #openstack-oslo | 12:55 | |
*** salv-orlando has quit IRC | 12:57 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Support KeyboardInterrupt for broker https://review.openstack.org/272512 | 13:00 |
*** lucasagomes is now known as lucas-hungry | 13:07 | |
*** dukhlov has joined #openstack-oslo | 13:16 | |
*** amrith is now known as _amrith_ | 13:16 | |
*** gordc has joined #openstack-oslo | 13:18 | |
*** edmondsw has joined #openstack-oslo | 13:18 | |
*** kgiusti has joined #openstack-oslo | 13:19 | |
*** zz_dimtruck is now known as dimtruck | 13:22 | |
*** takedakn has joined #openstack-oslo | 13:32 | |
*** dimtruck is now known as zz_dimtruck | 13:32 | |
*** achanda has joined #openstack-oslo | 13:32 | |
*** achanda has quit IRC | 13:38 | |
*** jaypipes has quit IRC | 13:44 | |
openstackgerrit | Julien Danjou proposed openstack/tooz: pgsql: fix hostname parsing https://review.openstack.org/272539 | 13:45 |
*** tedross has joined #openstack-oslo | 13:46 | |
*** tedross has left #openstack-oslo | 13:47 | |
*** salv-orlando has joined #openstack-oslo | 13:58 | |
*** jecarey has quit IRC | 14:01 | |
*** rlrossit has joined #openstack-oslo | 14:03 | |
*** salv-orlando has quit IRC | 14:03 | |
*** lucas-hungry is now known as lucasagomes | 14:06 | |
*** MVenesio has joined #openstack-oslo | 14:07 | |
*** amotoki has quit IRC | 14:09 | |
*** ansiwen has quit IRC | 14:11 | |
*** ansiwen has joined #openstack-oslo | 14:12 | |
*** ansiwen has quit IRC | 14:16 | |
*** ansiwen has joined #openstack-oslo | 14:16 | |
*** pblaho has quit IRC | 14:17 | |
*** takedakn has quit IRC | 14:18 | |
*** pblaho has joined #openstack-oslo | 14:18 | |
*** dims has joined #openstack-oslo | 14:27 | |
*** dims has quit IRC | 14:29 | |
*** dims has joined #openstack-oslo | 14:32 | |
*** mkoderer_cloud has quit IRC | 14:34 | |
*** pradk has joined #openstack-oslo | 14:34 | |
*** boris-42 has quit IRC | 14:34 | |
*** pblaho has quit IRC | 14:35 | |
*** boris-42 has joined #openstack-oslo | 14:35 | |
*** davidlenwell has quit IRC | 14:35 | |
*** mkoderer_cloud has joined #openstack-oslo | 14:36 | |
*** ansiwen has quit IRC | 14:37 | |
*** ansiwen has joined #openstack-oslo | 14:38 | |
*** ansiwen has quit IRC | 14:39 | |
*** pblaho has joined #openstack-oslo | 14:39 | |
dhellmann | dims : we should probably release this fix, if it's breaking folks' doc builds: https://review.openstack.org/#/c/272476 | 14:39 |
dims | dhellmann : +2A looks like a easy fix | 14:41 |
dhellmann | yeah, I should have made that catch Exception anyway | 14:41 |
*** zz_dimtruck is now known as dimtruck | 14:42 | |
*** _amrith_ is now known as amrith | 14:43 | |
dhellmann | dims : I can deal with the release, if you're busy this morning | 14:47 |
dims | dhellmann : yes, please. All day meetings today and tomorrow at a customer site. thanks! | 14:48 |
dhellmann | dims : np, I've got this one | 14:48 |
*** davidlenwell has joined #openstack-oslo | 14:49 | |
dims | @dukhlov : @ozamiatin : @yportnova : @dmitryme @sileht : are we ready for a oslo.messaging release later this week? | 14:51 |
sileht | why not | 14:51 |
dmitryme | yep, agree | 14:52 |
dukhlov | I need to fix one test for my latest code review, but I plan to do it today | 14:52 |
*** regXboi has joined #openstack-oslo | 14:54 | |
*** salv-orlando has joined #openstack-oslo | 14:54 | |
*** jaypipes has joined #openstack-oslo | 14:55 | |
*** salv-orlando has quit IRC | 14:57 | |
*** ansiwen has joined #openstack-oslo | 14:58 | |
*** mhickey has quit IRC | 15:01 | |
*** pblaho has quit IRC | 15:03 | |
*** mhickey has joined #openstack-oslo | 15:07 | |
*** amotoki has joined #openstack-oslo | 15:08 | |
*** salv-orlando has joined #openstack-oslo | 15:10 | |
*** salv-orlando has quit IRC | 15:11 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:11 | |
*** salv-orlando has joined #openstack-oslo | 15:11 | |
*** jecarey has joined #openstack-oslo | 15:15 | |
*** mtanino has joined #openstack-oslo | 15:21 | |
*** mtanino_ has joined #openstack-oslo | 15:22 | |
lxsli | morning dhellmann | 15:23 |
lxsli | I fixed the pep8 error in my chain :| | 15:23 |
*** mtanino__ has joined #openstack-oslo | 15:23 | |
openstackgerrit | Merged openstack/osprofiler: Move osprofiler tests into osprofiler https://review.openstack.org/271582 | 15:24 |
*** pblaho has joined #openstack-oslo | 15:24 | |
*** yamahata has joined #openstack-oslo | 15:29 | |
*** salv-orlando has quit IRC | 15:34 | |
*** salv-orlando has joined #openstack-oslo | 15:35 | |
*** pballand has quit IRC | 15:35 | |
*** achanda has joined #openstack-oslo | 15:36 | |
dhellmann | hi, lxsli | 15:38 |
openstackgerrit | Merged openstack/oslo.config: Do not fail on certain config option help strings https://review.openstack.org/272476 | 15:40 |
*** achanda has quit IRC | 15:41 | |
openstackgerrit | Ronald Bradford proposed openstack/oslo.config: Retain correct order of defined config options https://review.openstack.org/272289 | 15:47 |
*** dimtruck is now known as zz_dimtruck | 15:52 | |
*** shardy_ has joined #openstack-oslo | 15:53 | |
*** shardy has quit IRC | 15:54 | |
*** ihrachys has quit IRC | 15:59 | |
*** ihrachys has joined #openstack-oslo | 16:00 | |
lxsli | dhellmann: hi | 16:04 |
lxsli | dhellmann: https://review.openstack.org/#/c/264787/ if you'd be so kind | 16:04 |
dhellmann | lxsli : it's on my review list for today | 16:04 |
lxsli | awesome thank you | 16:05 |
*** salv-orl_ has joined #openstack-oslo | 16:06 | |
*** vilobhmm11 has joined #openstack-oslo | 16:08 | |
*** salv-orlando has quit IRC | 16:09 | |
*** amotoki has quit IRC | 16:16 | |
*** pratikmallya has joined #openstack-oslo | 16:22 | |
*** dims has quit IRC | 16:24 | |
*** pratikma_ has joined #openstack-oslo | 16:25 | |
*** pratikmallya has quit IRC | 16:27 | |
*** mhickey has quit IRC | 16:36 | |
*** e0ne has joined #openstack-oslo | 16:37 | |
*** stevemar_znc is now known as stevemar | 16:38 | |
dukhlov | dims: test was fixed and could be merged - https://review.openstack.org/#/c/272152/ | 16:38 |
openstackgerrit | Ronald Bradford proposed openstack/oslo.log: Remove deprecated use-syslog-rfc-format option https://review.openstack.org/263785 | 16:39 |
*** browne has joined #openstack-oslo | 16:44 | |
*** mhickey has joined #openstack-oslo | 16:48 | |
*** achanda has joined #openstack-oslo | 16:49 | |
therve | FWIW, I opened https://bugs.launchpad.net/nova/+bug/1538204 against nova, but I believe there may be a oslo.service issue | 16:49 |
openstack | Launchpad bug 1538204 in OpenStack Compute (nova) "Failed to stop nova-api in grenade tests" [Undecided,New] | 16:49 |
openstackgerrit | Ryan Rossiter proposed openstack/oslo.versionedobjects: Add ability to pass args/kwargs to obj_class init https://review.openstack.org/272641 | 16:49 |
therve | It looks related to recent changes around signal handlers | 16:49 |
*** dims has joined #openstack-oslo | 16:50 | |
*** zakora has quit IRC | 16:50 | |
*** nkrinner has quit IRC | 16:51 | |
*** pblaho has quit IRC | 16:53 | |
therve | Ah maybe not, maybe looks like the fixed https://bugs.launchpad.net/oslo.service/+bug/1524907 | 16:56 |
openstack | Launchpad bug 1524907 in oslo.service "Race condition in SIGTERM signal handler" [Undecided,Fix committed] | 16:56 |
therve | haypo, WDYT? | 16:56 |
*** dims has quit IRC | 16:56 | |
*** mriedem has quit IRC | 17:01 | |
*** ndipanov has quit IRC | 17:01 | |
*** EinstCra_ has joined #openstack-oslo | 17:04 | |
*** bogdando has quit IRC | 17:06 | |
*** EinstCrazy has quit IRC | 17:07 | |
*** stevemar has quit IRC | 17:07 | |
*** pblaho has joined #openstack-oslo | 17:08 | |
*** stevemar_znc has joined #openstack-oslo | 17:08 | |
*** jaypipes has quit IRC | 17:16 | |
*** cdent has quit IRC | 17:16 | |
*** openstackgerrit has quit IRC | 17:17 | |
*** openstackgerrit has joined #openstack-oslo | 17:17 | |
*** e0ne_ has joined #openstack-oslo | 17:18 | |
*** bogdando has joined #openstack-oslo | 17:19 | |
*** e0ne has quit IRC | 17:20 | |
*** stevemar_znc has quit IRC | 17:30 | |
*** haypo has quit IRC | 17:30 | |
*** haypo has joined #openstack-oslo | 17:30 | |
*** haypo has quit IRC | 17:30 | |
*** haypo has joined #openstack-oslo | 17:30 | |
*** EmilienM has quit IRC | 17:30 | |
*** e0ne_ has quit IRC | 17:31 | |
*** stevemar_znc has joined #openstack-oslo | 17:34 | |
*** EmilienM has joined #openstack-oslo | 17:34 | |
*** achanda has quit IRC | 17:40 | |
*** yassine__ has quit IRC | 17:48 | |
*** hockeynut is now known as hockeynut_otr | 17:51 | |
*** hockeynut_otr is now known as hockeynut | 17:52 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 17:59 | |
*** hockeynut_afk has joined #openstack-oslo | 18:00 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 18:03 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 18:04 | |
*** lucasagomes is now known as lucas-dinner | 18:04 | |
*** pratikma_ has quit IRC | 18:05 | |
*** hockeynut_afk has quit IRC | 18:05 | |
*** hockeynut_otr has joined #openstack-oslo | 18:06 | |
openstackgerrit | Merged openstack/oslo.config: Retain correct order of defined config options https://review.openstack.org/272289 | 18:09 |
*** achanda has joined #openstack-oslo | 18:10 | |
*** dguitarbite has quit IRC | 18:15 | |
*** dguitarbite has joined #openstack-oslo | 18:16 | |
*** harlowja has joined #openstack-oslo | 18:18 | |
*** mgarza has joined #openstack-oslo | 18:19 | |
*** vilobhmm11 has quit IRC | 18:19 | |
*** stevemar_znc is now known as stevemar | 18:20 | |
*** e0ne has joined #openstack-oslo | 18:21 | |
*** mhickey has quit IRC | 18:27 | |
*** hockeynut_otr has quit IRC | 18:28 | |
*** achanda has quit IRC | 18:29 | |
*** rlrossit has quit IRC | 18:37 | |
*** vilobhmm11 has joined #openstack-oslo | 18:46 | |
*** rlrossit has joined #openstack-oslo | 18:48 | |
*** achanda has joined #openstack-oslo | 18:48 | |
*** browne has quit IRC | 18:50 | |
*** EinstCra_ has quit IRC | 18:51 | |
*** ihrachys has quit IRC | 18:52 | |
*** cdent has joined #openstack-oslo | 18:56 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 18:57 | |
*** jaosorior_ has joined #openstack-oslo | 18:58 | |
*** pratikmallya has joined #openstack-oslo | 18:58 | |
*** pratikmallya has quit IRC | 19:03 | |
*** shardy_ has quit IRC | 19:04 | |
*** jeckersb is now known as jeckersb_gone | 19:06 | |
*** vilobhmm11 has quit IRC | 19:06 | |
*** vilobhmm11 has joined #openstack-oslo | 19:06 | |
*** vilobhmm111 has joined #openstack-oslo | 19:09 | |
*** vilobhmm111 has quit IRC | 19:09 | |
*** vilobhmm11 has quit IRC | 19:10 | |
openstackgerrit | Sven Anderson proposed openstack-dev/pbr: Extend compile_catalog command to compile all .po files https://review.openstack.org/271562 | 19:12 |
*** cdent has quit IRC | 19:13 | |
*** dims has joined #openstack-oslo | 19:13 | |
*** dkehn has quit IRC | 19:14 | |
*** cdent has joined #openstack-oslo | 19:15 | |
*** vilobhmm11 has joined #openstack-oslo | 19:16 | |
*** vilobhmm11 has quit IRC | 19:17 | |
*** vilobhmm11 has joined #openstack-oslo | 19:17 | |
*** dtardivel has quit IRC | 19:17 | |
haypo | therve: i backported my SIGTERM/SIGINT to Liberty, it was accepted, but it's not merged yet: https://review.openstack.org/#/c/256443/ | 19:20 |
haypo | therve: i see rechecks since january 4 | 19:20 |
*** dkehn has joined #openstack-oslo | 19:20 | |
*** achanda has quit IRC | 19:21 | |
*** achanda has joined #openstack-oslo | 19:23 | |
*** MVenesio has quit IRC | 19:24 | |
therve | haypo, Yeah I wonder if it's the same bug, as the symptoms are different | 19:24 |
*** dims has quit IRC | 19:24 | |
*** achanda has quit IRC | 19:25 | |
haypo | therve: where can i find the full traceback? | 19:26 |
therve | haypo, https://bugs.launchpad.net/nova/+bug/1538204 | 19:26 |
openstack | Launchpad bug 1538204 in oslo.service "Failed to stop nova-api in grenade tests" [Undecided,New] | 19:26 |
haypo | therve: that's the full traceback? | 19:26 |
therve | haypo, http://logs.openstack.org/25/272425/1/gate/gate-grenade-dsvm-heat/b32eda2/logs/old/screen-n-api.txt.gz?level=ERROR Sorry | 19:27 |
haypo | ah thanks | 19:27 |
*** browne has joined #openstack-oslo | 19:27 | |
haypo | therve: my traceback was different | 19:28 |
therve | haypo, If it was the same I wouldn't ask you :) | 19:29 |
harlowja | interesting | 19:29 |
haypo | therve: i have to find again all pieces of the issue, i lost the context | 19:29 |
* harlowja thought with primitives (sig is an int) that python handled size changes internally correctly | 19:29 | |
harlowja | or was that only with strings it handles that | 19:29 |
therve | harlowja, ? It's on a dict? | 19:30 |
harlowja | https://hg.python.org/cpython/file/tip/Objects/dictobject.c#l2946 | 19:30 |
harlowja | https://hg.python.org/cpython/file/tip/Objects/dictobject.c#l3029 | 19:31 |
haypo | therve: i don't understand how the code can work :) | 19:31 |
harlowja | both of those are the places where that happens | 19:31 |
haypo | therve: maybe it only fails when if has to handle two signals? | 19:31 |
*** mkoderer_cloud has quit IRC | 19:31 | |
haypo | therve: modifying a dict while iterating on it is a bad idea | 19:31 |
harlowja | or maybe it was only sets that handle (primitive) keys diseappering when iterating | 19:31 |
harlowja | or lists, can't remember, ha | 19:31 |
haypo | therve: to me, there is a design issue. we must schedule eventlet calls, not call directly signal handlers | 19:32 |
therve | haypo, Right, it probably means 2 handlers are called "at the same time" | 19:32 |
haypo | therve: otherwise, bad things happen | 19:32 |
haypo | therve: my issue was that the signal handler was called twice in a reentrant call | 19:32 |
haypo | therve: the code is not really reentrant-proof | 19:32 |
therve | Right, the issue here looks like we call them both in parallel, I'd think | 19:33 |
harlowja | ya there is a lot of 'self.signal_handler.clear()' in https://github.com/openstack/oslo.service/blob/master/oslo_service/service.py :-P | 19:33 |
haypo | therve: hum no, i don't think that they are called in parallel, but sequentially | 19:34 |
harlowja | haypo does the python interpreter buffer them (signals) up in a list before delivering to the process? | 19:34 |
therve | haypo, Sure nothing can happen in parallel in python. I mean that there is a context switching after the clear to another signal handler | 19:34 |
harlowja | signal handlers are probably different imho | 19:35 |
harlowja | depends on what the interpreter does for deliver of signals into user code | 19:35 |
harlowja | *for delivery | 19:36 |
therve | Right | 19:36 |
haypo | harlowja: the python signal handler can be called just *anytime, | 19:36 |
harlowja | right | 19:36 |
haypo | harlowja: the python signal handler can be called just *anytime*, between two python instructions | 19:36 |
harlowja | right | 19:36 |
therve | You generally need to make a "call into main thread" when in a signal handler | 19:36 |
haypo | harlowja: it's terrible. that's why it's much better to delay the final call using eventlet | 19:36 |
haypo | therve: yeah, exactly | 19:36 |
therve | Which we don't seem to do in oslo.service | 19:37 |
harlowja | ya, so put the signals gotten into some buffer/queue that the main thread handles in good time? | 19:37 |
*** jeckersb_gone is now known as jeckersb | 19:37 | |
haypo | harlowja: we should just use eventlet.spawn() | 19:38 |
haypo | harlowja: to "queue" the call | 19:38 |
harlowja | seems fair, if that works | 19:38 |
therve | That sounds right to me | 19:40 |
haypo | in the meanwhile, we may copy the list of callbacks in _handle_signals | 19:41 |
haypo | before iterating on the list | 19:41 |
haypo | therve: i'm not sure that i really understood your issue | 19:42 |
haypo | therve: it looks like a reentrant call to clear()? | 19:42 |
therve | haypo, Does it? We would see it in the traceback, no? | 19:42 |
haypo | therve: but if we change how signals are queued, the reentrant issue will go away | 19:42 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Spin off the handling of signals into an eventlet thread https://review.openstack.org/272707 | 19:43 |
harlowja | ^ perhaps | 19:43 |
haypo | therve: the problem is that self._signal_handlers dict is modified. only two methods change it: clear() & add_handler() | 19:43 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Spin off the handling of signals into an eventlet thread https://review.openstack.org/272707 | 19:43 |
harlowja | the other shitty part is that its a collections.DefaultDict | 19:44 |
harlowja | and that has slightly different iteration semantics afaik | 19:44 |
haypo | therve: hum sorry, add_handler() doesn't change the dict, only values. but modifying dict values in a loop iterating in dict keys is ok | 19:44 |
haypo | therve: it looks like clear() is called, and during the call, clear() is called again | 19:44 |
therve | haypo, It does change it as it's a default dict | 19:44 |
haypo | therve: well, i don't think that add_handler() is called at exit | 19:45 |
therve | No probably not | 19:45 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Spin off the handling of signals into an eventlet thread https://review.openstack.org/272707 | 19:46 |
harlowja | haypo ^ | 19:46 |
*** salv-orl_ has quit IRC | 19:46 | |
harlowja | (maybe should wait() though) | 19:47 |
harlowja | *shouldn't | 19:47 |
*** cdent has quit IRC | 19:47 | |
haypo | harlowja: it's unclear to me how we should handle two signals sent quickly. ignore the second signal? call the signal handler twice? | 19:48 |
harlowja | got me, ha | 19:49 |
haypo | harlowja: asyncio has an interesting feature. a callback can be cancelled | 19:50 |
harlowja | woah, thats useable in openstack in 15 years | 19:50 |
harlowja | lol | 19:50 |
haypo | harlowja: if you schedule a call to the signal handler, but then unregister the signal handler, the callback is cancelled | 19:50 |
haypo | harlowja: come on, i'm not proposing to switch to asyncio. just steal good ideas | 19:51 |
harlowja | lol | 19:51 |
*** cdent has joined #openstack-oslo | 19:52 | |
haypo | harlowja: (it's up to you to understand "we wouldn't have such race condition using asyncio" :-D) | 19:52 |
*** edmondsw has quit IRC | 19:53 | |
harlowja | asyncio fix it all | 19:53 |
harlowja | lol | 19:53 |
haypo | eventlet is broken by design :-D | 19:53 |
haypo | it looks like _sigterm() must only be called once | 19:56 |
haypo | otherwise, bad things can happen | 19:56 |
haypo | currently, _sigterm() starts by calling self.signal_handler.clear() to reduce the risk of race condition | 19:56 |
haypo | but it looks like it's not enough | 19:56 |
harlowja | ya, clear() is sprinkled all over that code | 19:57 |
harlowja | lol | 19:57 |
harlowja | more clear! | 19:57 |
harlowja | lol | 19:57 |
*** rcernin has quit IRC | 19:58 | |
harlowja | defaultdict < 3.5 afaik is also in python, so clear() probably isn't as atomic as people think it is there | 20:00 |
harlowja | or i thought that was the case | 20:01 |
harlowja | or was that ordereddict | 20:02 |
harlowja | guess defaultdict in c-code, nm | 20:02 |
*** kzaitsev_ws has quit IRC | 20:07 | |
*** kzaitsev_ws has joined #openstack-oslo | 20:07 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Spin off the handling of signals into an eventlet thread https://review.openstack.org/272707 | 20:11 |
harlowja | haypo ^ | 20:11 |
harlowja | updated with some ideas on how to reduce more issues | 20:11 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.service: Spin off the handling of signals into an eventlet thread https://review.openstack.org/272707 | 20:12 |
*** pradk has quit IRC | 20:14 | |
*** pradk_ has joined #openstack-oslo | 20:14 | |
*** pradk_ is now known as pradk | 20:14 | |
openstackgerrit | Victor Stinner proposed openstack/oslo.service: Fix race condition on handling signals https://review.openstack.org/272718 | 20:21 |
haypo | therve, harlowja ^^ ok, i tried something | 20:21 |
harlowja | ya, similar to 272707 | 20:21 |
harlowja | https://review.openstack.org/#/c/272707/5/oslo_service/service.py does something similar, either i guess is ok | 20:22 |
haypo | harlowja: your patch changes the behaviour of SIGTERM signal handlers | 20:22 |
harlowja | ya, thought u said SIGTERM stuff should never be called twice | 20:22 |
harlowja | so it won't be, lol | 20:22 |
haypo | harlowja: it starts by removing all handlers of SIGTERM. i'm not sure that it's part of the oslo.service API | 20:22 |
harlowja | right | 20:23 |
harlowja | i can have it follow the other path that re-adds them | 20:23 |
haypo | harlowja: yeah, in practice, people probably don't want to see their SIGTERM handler be called twice sequentially, or worse, reentrant call to the handler (which can happen currently) | 20:23 |
harlowja | ya, the .pop() and re-add under certain cases was for that | 20:23 |
haypo | harlowja: "i can have it follow the other path that re-adds them" you cannot with your design | 20:23 |
haypo | harlowja: _handle_signals() must be reentrant | 20:24 |
*** pratikmallya has joined #openstack-oslo | 20:24 | |
haypo | harlowja: you cannot start to play with a list or dict in a reentrant funciton | 20:24 |
*** mhickey has joined #openstack-oslo | 20:24 | |
harlowja | k, then i guess https://review.openstack.org/#/c/272718/ is fine (does enough, if it works, ha) | 20:25 |
haypo | harlowja: my change uses spawn() at a different level to reduce the risk of race condition. well, the largest part of my change are comments to explain the issue :-D | 20:26 |
harlowja | :-P | 20:26 |
harlowja | okie dokie then | 20:27 |
*** nikhil has quit IRC | 20:27 | |
haypo | harlowja: i'm still trying to understand your patch. but to me, it's obvious that it changes the current behaviour | 20:27 |
haypo | harlowja: but i don't know yet if it's ok or not :) | 20:27 |
harlowja | lol, np | 20:27 |
*** nikhil has joined #openstack-oslo | 20:28 | |
haypo | harlowja: for example, if a SIGPOLL signal handler does print("hello"). with your change, if you send quickly SIGPOLL twice, a signal can be lost | 20:28 |
harlowja | np, let's go with yours for now | 20:28 |
haypo | harlowja: signal handling is one of the most difficult part of UNIX :-p | 20:28 |
haypo | harlowja: i spent two years on fixing issues related to signals in python. each platform behaves differently and there are various kinds of funny race conditions | 20:29 |
harlowja | sux | 20:29 |
harlowja | sounds horrible, lol | 20:29 |
haypo | harlowja: for example, on FreeBSD, any thread can be called to handle a signal | 20:29 |
haypo | harlowja: on Linux, it's always the same thread | 20:29 |
haypo | harlowja: on Windows, you don't really have signals. just something emulated :) | 20:30 |
harlowja | weird, ha | 20:30 |
haypo | harlowja: openbsd < 5.2 didn't have a real implementation of threads, so signals+threads was simply a mess | 20:30 |
harlowja | lol | 20:30 |
haypo | harlowja: (threars were implemented in user space with funny hacks, like transparent non-blocking I/O) | 20:30 |
harlowja | eventlet++ | 20:30 |
harlowja | lol | 20:30 |
haypo | harlowja: for python, i wrote faulthandler: a C function dumping the Python traceback on a signal. i learnt the hard way how to write async-signal-safe C code. it's just crazy. no heap memory. no printf. nothing :) | 20:31 |
haypo | it's useful to get a traceback on a crash (SIGSEGV, SIGFPE: division by zero) | 20:32 |
harlowja | lol | 20:32 |
harlowja | ya | 20:32 |
*** rcernin has joined #openstack-oslo | 20:32 | |
harlowja | sounds like create a static buffer, and try to use that buffer to dump things into | 20:32 |
harlowja | avoid all printf or i/o | 20:33 |
openstackgerrit | Greg Hill proposed openstack/taskflow: Make conductor.stop stop the running engine gracefully https://review.openstack.org/270319 | 20:33 |
haypo | harlowja: well, i reimplemented my own very tiny printf :) | 20:35 |
*** harlowja_ has joined #openstack-oslo | 20:36 | |
*** harlowja has quit IRC | 20:37 | |
*** yamahata has quit IRC | 20:37 | |
*** fhermeni has joined #openstack-oslo | 20:38 | |
fhermeni | hello | 20:38 |
harlowja_ | yo | 20:39 |
fhermeni | hi harlowja_ | 20:43 |
harlowja_ | yo yo | 20:43 |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Avoid process based executor task proxying-back ANY event https://review.openstack.org/272326 | 20:43 |
openstackgerrit | Victor Stinner proposed openstack/oslo.service: Fix race condition on handling signals https://review.openstack.org/272718 | 20:44 |
*** cdent has quit IRC | 20:44 | |
*** harlowja has joined #openstack-oslo | 20:45 | |
*** harlowja_ has quit IRC | 20:45 | |
harlowja | ok, back to normal name, lol | 20:45 |
*** salv-orlando has joined #openstack-oslo | 20:47 | |
openstackgerrit | Joshua Harlow proposed openstack/taskflow: Fix process based executor task proxying-back events https://review.openstack.org/272326 | 20:47 |
*** pradk has quit IRC | 20:53 | |
*** yportnova_ has joined #openstack-oslo | 20:54 | |
*** pradk has joined #openstack-oslo | 20:54 | |
*** bknudson has joined #openstack-oslo | 20:55 | |
openstackgerrit | Vilobh Meshram proposed openstack/tooz: Add Consul Driver https://review.openstack.org/245362 | 20:55 |
*** pratikmallya has quit IRC | 20:56 | |
*** yportnova_ has quit IRC | 20:58 | |
*** salv-orlando has quit IRC | 21:00 | |
*** amrith is now known as _amrith_ | 21:11 | |
*** cdent has joined #openstack-oslo | 21:12 | |
*** cdent has quit IRC | 21:13 | |
*** kgiusti has left #openstack-oslo | 21:17 | |
*** boris-42 has quit IRC | 21:23 | |
*** achanda has joined #openstack-oslo | 21:27 | |
*** rcernin has quit IRC | 21:28 | |
*** salv-orlando has joined #openstack-oslo | 21:30 | |
*** achanda has quit IRC | 21:30 | |
*** EinstCrazy has joined #openstack-oslo | 21:32 | |
*** jaosorior_ has quit IRC | 21:39 | |
openstackgerrit | Merged openstack/oslo.messaging: [zmq] Reduce proxy for direct messaging https://review.openstack.org/272085 | 21:40 |
openstackgerrit | Merged openstack/oslo.messaging: [zmq] Support KeyboardInterrupt for broker https://review.openstack.org/272512 | 21:41 |
*** pratikmallya has joined #openstack-oslo | 21:45 | |
fhermeni | harlowja: It seems to me our proposal is stalling since a few weeks now :/ Don’t really know what to do | 21:46 |
openstackgerrit | Greg Hill proposed openstack/taskflow: Make sure exc_args can be serialized via JSON https://review.openstack.org/272748 | 21:50 |
openstackgerrit | Greg Hill proposed openstack/taskflow: Make conductor.stop stop the running engine gracefully https://review.openstack.org/270319 | 21:57 |
*** e0ne has quit IRC | 21:57 | |
*** yamahata has joined #openstack-oslo | 21:58 | |
*** yamahata has quit IRC | 22:01 | |
*** yamahata has joined #openstack-oslo | 22:01 | |
*** salv-orl_ has joined #openstack-oslo | 22:06 | |
*** regXboi has quit IRC | 22:06 | |
*** salv-orlando has quit IRC | 22:09 | |
*** mhickey has quit IRC | 22:15 | |
harlowja | fhermeni just how it goes, these things take time :) | 22:20 |
harlowja | especially around dec<->jan, cross project things are hard | 22:21 |
harlowja | and this one is imho even harder than my previous one that i worked on | 22:21 |
harlowja | in josh hardness level | 22:21 |
*** davidlenwell has quit IRC | 22:24 | |
*** davidlenwell has joined #openstack-oslo | 22:25 | |
*** rlrossit has quit IRC | 22:32 | |
*** e0ne has joined #openstack-oslo | 22:39 | |
openstackgerrit | Joshua Harlow proposed openstack/tooz: Add lock breaking https://review.openstack.org/266015 | 22:40 |
*** jecarey_ has joined #openstack-oslo | 22:50 | |
*** jecarey has quit IRC | 22:53 | |
*** boris-42 has joined #openstack-oslo | 22:54 | |
*** dims has joined #openstack-oslo | 22:55 | |
dims | harlowja : let's get https://review.openstack.org/#/c/261677/ and https://review.openstack.org/#/c/272152/ please, we should try to get a oslo.messaging release out this week | 22:57 |
harlowja | k | 22:58 |
*** achanda has joined #openstack-oslo | 22:58 | |
harlowja | lgtm | 22:59 |
*** pratikmallya has quit IRC | 23:01 | |
*** e0ne has quit IRC | 23:02 | |
dims | thanks harlowja | 23:03 |
harlowja | np | 23:03 |
dims | i'll ask dukhlov or ozamiatin to file a openstack/releases request tomorrow | 23:03 |
openstackgerrit | Joshua Harlow proposed openstack/automaton: Add a state-space machine building example https://review.openstack.org/271478 | 23:08 |
*** pratikmallya has joined #openstack-oslo | 23:09 | |
openstackgerrit | Vilobh Meshram proposed openstack/tooz: Add Consul Driver https://review.openstack.org/245362 | 23:09 |
*** zz_dimtruck is now known as dimtruck | 23:14 | |
*** jeckersb is now known as jeckersb_gone | 23:17 | |
*** fhermeni has quit IRC | 23:24 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:28 | |
*** dimtruck is now known as zz_dimtruck | 23:37 | |
*** zz_dimtruck is now known as dimtruck | 23:47 | |
*** dukhlov has quit IRC | 23:49 | |
openstackgerrit | Merged openstack/oslo.messaging: Trivial: Remove unused logging import https://review.openstack.org/261155 | 23:52 |
openstackgerrit | Merged openstack/oslo.messaging: rabbit: Add option to configure QoS prefetch count https://review.openstack.org/264911 | 23:52 |
*** dukhlov has joined #openstack-oslo | 23:53 | |
*** yamamoto_ has joined #openstack-oslo | 23:58 | |
openstackgerrit | Merged openstack/oslo.messaging: assertEquals is deprecated, use assertEqual https://review.openstack.org/271909 | 23:59 |
*** achanda has quit IRC | 23:59 | |
openstackgerrit | Merged openstack/oslo.messaging: Python 3 deprecated the logger.warn method in favor of warning https://review.openstack.org/261677 | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!