*** tonyb has joined #openstack-oslo | 00:10 | |
tonyb | Can anyone here help me with running the oslo.db unit tests (on kilo) | 00:11 |
---|---|---|
tonyb | I'm getting 'db type could not be determined' :( | 00:12 |
tonyb | I followed http://docs.openstack.org/developer/oslo.db/contributing.html#how-to-run-unit-tests but still no dice :/ | 00:13 |
*** openstackgerrit_ has quit IRC | 00:23 | |
*** openstackgerrit_ has joined #openstack-oslo | 00:24 | |
*** yamamoto_ has joined #openstack-oslo | 00:24 | |
*** bapalm has quit IRC | 00:24 | |
*** yamamoto_ has quit IRC | 00:28 | |
*** vilobhmm11 has quit IRC | 00:37 | |
*** suro-patz has quit IRC | 00:37 | |
*** bapalm has joined #openstack-oslo | 00:41 | |
*** openstackgerrit_ has quit IRC | 00:48 | |
*** openstackgerrit_ has joined #openstack-oslo | 00:49 | |
*** EinstCrazy has joined #openstack-oslo | 00:51 | |
*** browne has quit IRC | 00:51 | |
*** browne has joined #openstack-oslo | 00:52 | |
*** EinstCrazy has quit IRC | 00:54 | |
*** devkulkarni has joined #openstack-oslo | 01:01 | |
*** devkulkarni has quit IRC | 01:19 | |
*** vilobhmm11 has joined #openstack-oslo | 01:22 | |
*** vilobhmm11 has quit IRC | 01:25 | |
*** dimtruck is now known as zz_dimtruck | 01:39 | |
*** nikhil_k has quit IRC | 01:42 | |
*** mtanino has quit IRC | 02:02 | |
*** dims has quit IRC | 02:08 | |
*** bapalm has quit IRC | 02:11 | |
*** browne has quit IRC | 02:11 | |
gcb_ | rbradfor, yes, we need a plan to clean up oslo-incubator stuff, we can work together in next release :-) | 02:15 |
*** bapalm has joined #openstack-oslo | 02:16 | |
*** dims has joined #openstack-oslo | 02:17 | |
*** devkulkarni has joined #openstack-oslo | 02:19 | |
*** yamamoto_ has joined #openstack-oslo | 02:25 | |
*** nikhil has joined #openstack-oslo | 02:34 | |
*** devkulkarni has quit IRC | 02:39 | |
*** nikhil has quit IRC | 02:43 | |
*** yamamoto_ has quit IRC | 02:48 | |
*** dims has quit IRC | 02:58 | |
*** sputnik13 has quit IRC | 03:00 | |
*** suro-patz has joined #openstack-oslo | 03:11 | |
*** dims has joined #openstack-oslo | 03:13 | |
*** dims has quit IRC | 03:18 | |
*** barra204 has joined #openstack-oslo | 03:21 | |
*** jpena has joined #openstack-oslo | 03:23 | |
*** yamahata_ has joined #openstack-oslo | 03:25 | |
*** amauryme` has joined #openstack-oslo | 03:29 | |
*** mtreinish_ has joined #openstack-oslo | 03:29 | |
*** jpena|zzz has quit IRC | 03:30 | |
*** krotscheck has quit IRC | 03:30 | |
*** yamahata has quit IRC | 03:30 | |
*** shakamunyi has quit IRC | 03:30 | |
*** mtreinish has quit IRC | 03:30 | |
*** amaurymedeiros has quit IRC | 03:30 | |
*** mtreinish_ is now known as mtreinish | 03:30 | |
*** krotscheck has joined #openstack-oslo | 03:31 | |
*** zz_dimtruck is now known as dimtruck | 03:31 | |
*** yamamoto has joined #openstack-oslo | 03:36 | |
*** yamahata_ has quit IRC | 03:36 | |
*** suro-patz has quit IRC | 03:38 | |
openstackgerrit | javeme proposed openstack/oslo.vmware: Should not raise Exception before connection close https://review.openstack.org/281222 | 03:41 |
*** links has joined #openstack-oslo | 03:45 | |
*** dimtruck is now known as zz_dimtruck | 03:52 | |
*** nikhil has joined #openstack-oslo | 03:54 | |
*** nikhil_k has joined #openstack-oslo | 03:54 | |
*** Nakato_ is now known as Nakato | 03:56 | |
*** suro-patz has joined #openstack-oslo | 04:03 | |
*** browne has joined #openstack-oslo | 04:08 | |
*** amrith is now known as _amrith_ | 04:10 | |
*** suro-patz has quit IRC | 04:10 | |
openstackgerrit | Merged openstack/oslo.messaging: Ensure the json result type is bytes on Python 3 https://review.openstack.org/283968 | 04:10 |
*** suro-patz has joined #openstack-oslo | 04:28 | |
*** devkulkarni has joined #openstack-oslo | 04:54 | |
*** zz_dimtruck is now known as dimtruck | 04:57 | |
*** jamespage has quit IRC | 05:00 | |
*** jamespage has joined #openstack-oslo | 05:00 | |
*** nikhil has quit IRC | 05:23 | |
*** jdandrea has quit IRC | 05:33 | |
*** devkulkarni has quit IRC | 05:36 | |
*** jdandrea has joined #openstack-oslo | 05:40 | |
*** suro-patz has quit IRC | 05:42 | |
*** jdandrea_ has joined #openstack-oslo | 05:49 | |
*** cburgess has quit IRC | 05:49 | |
*** jdandrea has quit IRC | 05:50 | |
*** amotoki has joined #openstack-oslo | 05:50 | |
*** amotoki has quit IRC | 05:50 | |
*** melwitt has quit IRC | 05:51 | |
*** cburgess has joined #openstack-oslo | 05:52 | |
openstackgerrit | javeme proposed openstack/oslo.vmware: Refactor VmdkWriteHandle and VmdkReadHandle https://review.openstack.org/281250 | 05:52 |
*** dimtruck is now known as zz_dimtruck | 05:55 | |
*** browne has quit IRC | 05:56 | |
*** obondarev has quit IRC | 05:56 | |
*** dansmith has quit IRC | 05:56 | |
*** melwitt has joined #openstack-oslo | 05:57 | |
*** yamahata_ has joined #openstack-oslo | 05:59 | |
*** krotscheck has quit IRC | 06:01 | |
*** browne has joined #openstack-oslo | 06:02 | |
*** obondarev has joined #openstack-oslo | 06:02 | |
*** dansmith has joined #openstack-oslo | 06:02 | |
*** barra204 has quit IRC | 06:04 | |
*** obondarev_ has joined #openstack-oslo | 06:09 | |
*** krotscheck has joined #openstack-oslo | 06:09 | |
*** obondarev has quit IRC | 06:10 | |
*** yamahata_ has quit IRC | 06:10 | |
*** openstackgerrit_ has quit IRC | 06:17 | |
*** openstackgerrit_ has joined #openstack-oslo | 06:17 | |
*** Guest68942 has joined #openstack-oslo | 06:18 | |
*** EinstCrazy has joined #openstack-oslo | 06:20 | |
*** EinstCrazy has quit IRC | 06:23 | |
*** eezhova has quit IRC | 06:23 | |
*** eezhova has joined #openstack-oslo | 06:23 | |
openstackgerrit | Joshua Harlow proposed openstack/tooz: Add mysql table support (if provided a database) https://review.openstack.org/290178 | 06:30 |
openstackgerrit | javeme proposed openstack/oslo.messaging: Should send bytes message in kafka on Python 3 https://review.openstack.org/291563 | 06:36 |
*** rcernin has joined #openstack-oslo | 06:49 | |
*** nkrinner has joined #openstack-oslo | 06:50 | |
*** browne has quit IRC | 07:10 | |
*** dansmith has quit IRC | 07:10 | |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/oslo.config: Replace deprecated LOG.warn with LOG.warning https://review.openstack.org/291575 | 07:16 |
openstackgerrit | Swapnil Kulkarni (coolsvap) proposed openstack/oslo.messaging: Replace deprecated LOG.warn with LOG.warning https://review.openstack.org/291576 | 07:19 |
*** browne has joined #openstack-oslo | 07:21 | |
*** dansmith has joined #openstack-oslo | 07:21 | |
*** amotoki has joined #openstack-oslo | 07:29 | |
*** vilobhmm11 has joined #openstack-oslo | 07:39 | |
*** pkholkin__ has quit IRC | 07:42 | |
*** pkholkin__ has joined #openstack-oslo | 07:42 | |
*** Guest68942 has quit IRC | 07:45 | |
*** browne has quit IRC | 07:47 | |
*** dansmith has quit IRC | 07:47 | |
*** nikhil has joined #openstack-oslo | 07:47 | |
*** browne has joined #openstack-oslo | 07:54 | |
*** dansmith has joined #openstack-oslo | 07:54 | |
*** harlowja_at_home has quit IRC | 08:00 | |
haypo | hum. it looks like "Ensure the json result type is bytes on Python 3" change simply broke all tests on python3... https://review.openstack.org/#/c/283968/ | 08:18 |
patchbot | haypo: patch 283968 - oslo.messaging - Ensure the json result type is bytes on Python 3 (MERGED) | 08:18 |
*** e0ne has joined #openstack-oslo | 08:21 | |
*** ozamiatin__ has joined #openstack-oslo | 08:21 | |
*** jamielennox is now known as jamielennox|away | 08:23 | |
*** dtardivel has joined #openstack-oslo | 08:26 | |
*** shardy has joined #openstack-oslo | 08:35 | |
*** yamahata_ has joined #openstack-oslo | 08:35 | |
*** gcb_ has quit IRC | 08:35 | |
*** browne has quit IRC | 08:37 | |
*** pcaruana has joined #openstack-oslo | 08:41 | |
*** ihrachys has joined #openstack-oslo | 08:45 | |
*** gcb_ has joined #openstack-oslo | 08:47 | |
sileht | haypo, I feel your pain | 08:52 |
haypo | sileht: i'm still trying to understand the change since 1h... | 08:53 |
sileht | haypo, I have run tox -py34 on mate and tests pass | 08:53 |
sileht | mate/master | 08:54 |
haypo | sileht: kombu serializer calls json.dumps(). oslo messaging pass a dict where one value type is bytes | 08:54 |
haypo | json.dumps see bytes as a list of integers... | 08:54 |
sileht | lol | 08:54 |
haypo | sileht: "tests pass"?? | 08:54 |
haypo | sileht: master like commit 67c8987372180e16b62f968c5036a05a27a17bc3 ? | 08:55 |
sileht | haypo, wait my master wasn't up2date | 08:55 |
haypo | Merge "Ensure the json result type is bytes on Python 3" | 08:55 |
* sileht retries | 08:55 | |
haypo | sileht: yeah, the tests pass without this change | 08:55 |
haypo | the change is supposed to fix something on py3. before the change, tests pass on py3. after the change, tests fail on py3.... | 08:56 |
haypo | sileht: i checked the py34 gate because i wanted to make it voting again. i'm disappointed to see that it was broken this morning | 08:57 |
haypo | i hate you | 08:57 |
haypo | :) | 08:57 |
openstackgerrit | Victor Stinner proposed openstack/oslo.messaging: Revert "Ensure the json result type is bytes on Python 3" https://review.openstack.org/291609 | 09:00 |
haypo | sileht: ^^ | 09:00 |
*** vilobhmm11 has quit IRC | 09:00 | |
*** lucas-afk is now known as lucasagomes | 09:06 | |
*** salv-orlando has joined #openstack-oslo | 09:09 | |
haypo | lifeless: for me, pbr is a tool to build a package, not even to install a packaging, so it doesn't make sense to require it at runtime | 09:14 |
*** ozamiatin__ has quit IRC | 09:16 | |
*** salv-orlando has quit IRC | 09:25 | |
*** yamahata_ has quit IRC | 09:26 | |
haypo | sileht: oh. i used the [Revert] button in Jenkins to create the Revert change. i see that it doesn't wrap long lines in the commit message | 09:27 |
*** pblaho has joined #openstack-oslo | 09:27 | |
*** yassine__ has joined #openstack-oslo | 09:35 | |
*** permalac has joined #openstack-oslo | 09:37 | |
*** permalac has quit IRC | 09:37 | |
*** permalac_ has joined #openstack-oslo | 09:38 | |
*** yamamoto has quit IRC | 09:40 | |
*** ndipanov has joined #openstack-oslo | 09:51 | |
*** mhickey_ has joined #openstack-oslo | 09:53 | |
openstackgerrit | Merged openstack/oslo.messaging: test: Don't test message's reply timeout https://review.openstack.org/264621 | 10:16 |
*** ozamiatin__ has joined #openstack-oslo | 10:19 | |
*** ozamiatin__ has quit IRC | 10:20 | |
*** permalac_ has quit IRC | 10:29 | |
*** sdague has joined #openstack-oslo | 10:30 | |
gcb_ | tonyb, Did you get the error 'db type could not be determined' in py33 or py34 ? | 10:33 |
tonyb | gcb_: py34 | 10:42 |
gcb_ | yeah, you must run py26 or py27 before py34. just adjust the order in tox.ini, let me find the bug :-) | 10:43 |
gcb_ | it's tox's bug | 10:43 |
tonyb | Hmm I've closed the window now but I thought I was doing tox -epy34 | 10:43 |
tonyb | but perhaps I had run a plain tox at some point | 10:44 |
tonyb | pointer to the bug would be helpful | 10:44 |
tonyb | Oh You *must* run py27 first. so tox -epy34 will fail but tox -epy27,py34 shoudl be ok? | 10:45 |
haypo | tonyb: your must run py3 first | 10:46 |
gcb_ | tox py34 can't read the datbase generated by py26 | 10:46 |
gcb_ | database | 10:46 |
haypo | tonyb: testrepository uses dbm database. py3 database works on py2+py3. if you create the DB with py2, it only works on py2 | 10:47 |
haypo | one year ago, i heard that testrepository is going to get a more generic DB code to support sqlite | 10:47 |
haypo | but it looks like it still uses dbm in practice | 10:48 |
gcb_ | haypo, correct:-) | 10:48 |
haypo | (sqlite works on all python versions) | 10:48 |
tonyb | okay so I have a clean checkout of oslo.db (stable/kilo). How shoudl I run tox to actually test the py34 code paths | 10:50 |
tonyb | This is a little moot as I have a patch up that passes CI, I just couldn't do the tests locally | 10:50 |
*** ozamiatin__ has joined #openstack-oslo | 10:50 | |
haypo | "I have a clean checkout of oslo.db" just remove the .testrepository directory | 10:51 |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: Pika: fix sending fanout messages https://review.openstack.org/289430 | 10:52 |
tonyb | okay, and now tox -e py34,py27 work (and pass tests) :) | 10:52 |
gcb_ | cool, we had adjust the order in master in many projects | 10:53 |
*** dims has joined #openstack-oslo | 10:54 | |
-openstackstatus- NOTICE: Gerrit is going to be restarted due to bad performance | 10:54 | |
*** ChanServ changes topic to "Gerrit is going to be restarted due to bad performance" | 10:54 | |
tonyb | gcb_, haypo: Thanks | 10:56 |
*** ChanServ changes topic to "#openstack-oslo" | 10:59 | |
-openstackstatus- NOTICE: Gerrit has been restarted successfully | 10:59 | |
*** yamamoto has joined #openstack-oslo | 11:02 | |
*** yamamoto_ has joined #openstack-oslo | 11:06 | |
*** yamamoto has quit IRC | 11:09 | |
sileht | jd__, do you think file generated by the file Tooz driver must be compatible between py3 and py2 ? | 11:15 |
*** d0ugal has quit IRC | 11:16 | |
*** d0ugal has joined #openstack-oslo | 11:17 | |
*** e0ne has quit IRC | 11:23 | |
*** yamamoto_ has quit IRC | 11:25 | |
*** yamamoto has joined #openstack-oslo | 11:26 | |
*** e0ne has joined #openstack-oslo | 11:26 | |
*** salv-orlando has joined #openstack-oslo | 11:28 | |
*** yamamoto has quit IRC | 11:30 | |
*** tesseract has joined #openstack-oslo | 11:33 | |
*** tesseract has quit IRC | 11:34 | |
*** Guest16009 has joined #openstack-oslo | 11:34 | |
*** cdent has joined #openstack-oslo | 11:36 | |
*** nkrinner has quit IRC | 11:36 | |
*** Guest16009 has quit IRC | 11:37 | |
*** nkrinner has joined #openstack-oslo | 11:38 | |
*** salv-orlando has quit IRC | 11:39 | |
*** tesseract- has joined #openstack-oslo | 11:40 | |
*** yamamoto has joined #openstack-oslo | 11:42 | |
*** yamamoto has quit IRC | 11:43 | |
*** _amrith_ is now known as amrith | 11:44 | |
*** EinstCrazy has joined #openstack-oslo | 11:48 | |
openstackgerrit | javeme proposed openstack/oslo.vmware: Refactor VmdkWriteHandle and VmdkReadHandle https://review.openstack.org/281250 | 11:56 |
*** lucasagomes is now known as lucas-hungry | 12:07 | |
jd__ | sileht: yes since you could have different consumers with different python version running | 12:10 |
*** yassine__ has quit IRC | 12:17 | |
sileht | jd__, so I will open a bug :) | 12:29 |
*** yamamoto has joined #openstack-oslo | 12:31 | |
*** dims has quit IRC | 12:33 | |
*** amrith is now known as _amrith_ | 12:33 | |
sileht | jd__, I thought the python2 is buggy :( | 12:36 |
*** dims has joined #openstack-oslo | 12:36 | |
*** dguitarbite has quit IRC | 12:37 | |
*** yamamoto has quit IRC | 12:40 | |
*** ozamiatin__ has quit IRC | 12:40 | |
*** cdent_ has joined #openstack-oslo | 12:43 | |
*** cdent has quit IRC | 12:47 | |
*** cdent_ is now known as cdent | 12:47 | |
*** _amrith_ is now known as amrith | 12:47 | |
*** jpena is now known as jpena|lunch | 12:51 | |
*** e0ne has quit IRC | 12:54 | |
*** yamamoto has joined #openstack-oslo | 12:54 | |
*** e0ne has joined #openstack-oslo | 12:54 | |
*** amrith is now known as _amrith_ | 13:00 | |
*** itisha has joined #openstack-oslo | 13:01 | |
*** yamamoto has quit IRC | 13:01 | |
*** e0ne has quit IRC | 13:03 | |
*** dims_ has joined #openstack-oslo | 13:03 | |
*** e0ne has joined #openstack-oslo | 13:04 | |
*** dims has quit IRC | 13:04 | |
*** devkulkarni has joined #openstack-oslo | 13:12 | |
*** yamamoto has joined #openstack-oslo | 13:26 | |
*** pradk_ has joined #openstack-oslo | 13:26 | |
*** pradk_ has quit IRC | 13:26 | |
sileht | jd__, haypo, python3 issue https://bugs.launchpad.net/oslo.serialization/+bug/1556081 | 13:26 |
openstack | Launchpad bug 1556081 in tooz "file driver doesn't write the same data in file in python 2 and python3" [Undecided,New] | 13:26 |
sileht | I dunno what the best way to fix this | 13:27 |
*** lucas-hungry is now known as lucasagomes | 13:29 | |
*** bogdando has joined #openstack-oslo | 13:33 | |
*** links has quit IRC | 13:39 | |
*** links has joined #openstack-oslo | 13:42 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization https://review.openstack.org/291715 | 13:43 |
*** rlrossit has joined #openstack-oslo | 13:44 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization https://review.openstack.org/291715 | 13:46 |
*** kgiusti has joined #openstack-oslo | 13:55 | |
*** cdent has quit IRC | 13:57 | |
openstackgerrit | Piyush Raman Srivastava proposed openstack/oslo.config: Fix typo error in docstrings of oslo_config.cfg.py https://review.openstack.org/291722 | 14:03 |
openstackgerrit | Piyush Raman Srivastava proposed openstack/oslo.config: Fix typo error in docstrings of oslo_config.cfg.py https://review.openstack.org/291722 | 14:06 |
*** dims_ has quit IRC | 14:07 | |
*** yassine__ has joined #openstack-oslo | 14:08 | |
*** ozamiatin_ has quit IRC | 14:09 | |
*** ozamiatin__ has joined #openstack-oslo | 14:09 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization https://review.openstack.org/291715 | 14:12 |
*** rlrossit has quit IRC | 14:12 | |
*** devkulkarni has quit IRC | 14:14 | |
*** mriedem has joined #openstack-oslo | 14:14 | |
*** gordc has joined #openstack-oslo | 14:14 | |
*** dims has joined #openstack-oslo | 14:17 | |
*** links has quit IRC | 14:17 | |
*** cdent has joined #openstack-oslo | 14:20 | |
*** dims has quit IRC | 14:23 | |
openstackgerrit | Merged openstack/oslo.messaging: Revert "Ensure the json result type is bytes on Python 3" https://review.openstack.org/291609 | 14:25 |
mriedem | dhellmann: jd__: sileht: can we get this oslo.db kilo backport in? it fixes a blocker to land oslo.db changes on kilo which is blocking other projects in kilo https://review.openstack.org/#/c/291472/ | 14:25 |
patchbot | mriedem: patch 291472 - oslo.db (stable/kilo) - Fix tests to work under both pymsysql 0.6.2 and 0.7.x | 14:25 |
*** ericksonsantos has quit IRC | 14:26 | |
*** nikhil has quit IRC | 14:26 | |
*** ericksonsantos has joined #openstack-oslo | 14:27 | |
*** nikhil has joined #openstack-oslo | 14:27 | |
*** rlrossit has joined #openstack-oslo | 14:27 | |
dhellmann | mriedem : +2a | 14:31 |
mriedem | thanks | 14:32 |
*** _amrith_ is now known as amrith | 14:32 | |
*** rlrossit is now known as edit_ | 14:32 | |
*** dims has joined #openstack-oslo | 14:32 | |
*** mriedem is now known as dontrump | 14:32 | |
*** edit_ is now known as rlrooster | 14:33 | |
*** jpena|lunch is now known as jpena | 14:35 | |
*** dansmith is now known as superdan | 14:36 | |
*** zz_dimtruck is now known as dimtruck | 14:50 | |
*** MVenesio has joined #openstack-oslo | 14:52 | |
*** salv-orlando has joined #openstack-oslo | 15:00 | |
*** devkulkarni has joined #openstack-oslo | 15:04 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 15:06 | |
*** dims_ has joined #openstack-oslo | 15:07 | |
*** dims has quit IRC | 15:08 | |
*** dims_ has quit IRC | 15:11 | |
*** ndipanov has quit IRC | 15:13 | |
*** dims has joined #openstack-oslo | 15:14 | |
*** salv-orlando has quit IRC | 15:14 | |
*** salv-orlando has joined #openstack-oslo | 15:16 | |
*** ndipanov has joined #openstack-oslo | 15:17 | |
*** harlowja_at_home has joined #openstack-oslo | 15:17 | |
*** regXboi has joined #openstack-oslo | 15:34 | |
*** salv-orlando has quit IRC | 15:35 | |
haypo | sileht: i'm reading your issue | 15:38 |
haypo | sileht: i should chek how this issue is handled in the python stdlib | 15:38 |
haypo | check | 15:39 |
*** jaypipes is now known as leakypipes | 15:45 | |
*** yamahata_ has joined #openstack-oslo | 15:45 | |
*** devkulkarni has quit IRC | 15:46 | |
*** yamamoto has quit IRC | 15:49 | |
*** mtanino has joined #openstack-oslo | 15:49 | |
*** nkrinner has quit IRC | 15:49 | |
*** yamamoto has joined #openstack-oslo | 15:49 | |
*** yamamoto has quit IRC | 15:50 | |
*** yamamoto has joined #openstack-oslo | 15:51 | |
*** yamamoto has quit IRC | 15:56 | |
*** permalac has joined #openstack-oslo | 16:01 | |
*** browne has joined #openstack-oslo | 16:20 | |
*** nikhil has quit IRC | 16:37 | |
*** dims has quit IRC | 16:38 | |
*** pblaho has quit IRC | 16:42 | |
*** pcaruana has quit IRC | 16:50 | |
*** dims has joined #openstack-oslo | 16:50 | |
*** ozamiatin__ has quit IRC | 16:51 | |
*** salv-orlando has joined #openstack-oslo | 16:51 | |
openstackgerrit | Joshua Harlow proposed openstack/tooz: Add mysql table support (if provided a database) https://review.openstack.org/290178 | 16:52 |
*** tesseract- has quit IRC | 16:55 | |
*** cdent has quit IRC | 16:57 | |
*** dims_ has joined #openstack-oslo | 16:58 | |
*** dims has quit IRC | 16:59 | |
*** browne has quit IRC | 17:00 | |
*** rcernin has quit IRC | 17:01 | |
*** e0ne has quit IRC | 17:05 | |
openstackgerrit | Merged openstack/oslo.config: Replace deprecated LOG.warn with LOG.warning https://review.openstack.org/291575 | 17:05 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization https://review.openstack.org/291715 | 17:07 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization https://review.openstack.org/291715 | 17:08 |
*** dims_ has quit IRC | 17:08 | |
*** salv-orlando has quit IRC | 17:09 | |
*** suro-patz has joined #openstack-oslo | 17:12 | |
*** dims has joined #openstack-oslo | 17:13 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Fix Notification listener blocking behavior https://review.openstack.org/291824 | 17:16 |
*** sdague has quit IRC | 17:17 | |
*** cdent has joined #openstack-oslo | 17:19 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization https://review.openstack.org/291715 | 17:28 |
*** leakypipes has quit IRC | 17:30 | |
*** devkulkarni has joined #openstack-oslo | 17:30 | |
*** jaypipes has joined #openstack-oslo | 17:34 | |
*** krotscheck has quit IRC | 17:34 | |
*** pcaruana has joined #openstack-oslo | 17:35 | |
*** krotscheck has joined #openstack-oslo | 17:37 | |
*** ericksonsantos has quit IRC | 17:37 | |
openstackgerrit | Ronald Bradford proposed openstack/oslo.log: Corrected transposed AssertEqual(expected, actual) https://review.openstack.org/288756 | 17:38 |
*** vilobhmm11 has joined #openstack-oslo | 17:39 | |
*** vilobhmm111 has joined #openstack-oslo | 17:42 | |
*** browne has joined #openstack-oslo | 17:42 | |
*** vilobhmm111 has quit IRC | 17:43 | |
*** vilobhmm111 has joined #openstack-oslo | 17:43 | |
*** vilobhmm11 has quit IRC | 17:44 | |
*** mhickey_ has quit IRC | 17:44 | |
openstackgerrit | Merged openstack/oslo.vmware: Should not raise Exception before connection close https://review.openstack.org/281222 | 17:45 |
*** vilobhmm11 has joined #openstack-oslo | 17:49 | |
*** vilobhmm111 has quit IRC | 17:50 | |
*** lucasagomes is now known as lucas-afk | 17:51 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/tooz: file: make python2 payload readable from python3 https://review.openstack.org/291836 | 17:51 |
*** e0ne has joined #openstack-oslo | 17:56 | |
*** vilobhmm11 has quit IRC | 17:59 | |
*** vilobhmm11 has joined #openstack-oslo | 18:00 | |
*** yamahata_ has quit IRC | 18:01 | |
*** gcb_ has quit IRC | 18:02 | |
*** dims_ has joined #openstack-oslo | 18:04 | |
*** dims has quit IRC | 18:04 | |
*** vilobhmm11 has quit IRC | 18:04 | |
*** gcb_ has joined #openstack-oslo | 18:05 | |
*** ihrachys has quit IRC | 18:06 | |
*** mriedem has joined #openstack-oslo | 18:12 | |
*** EinstCrazy has quit IRC | 18:13 | |
*** dontrump has quit IRC | 18:13 | |
*** shardy has quit IRC | 18:13 | |
*** gcb_ has quit IRC | 18:15 | |
*** gcb_ has joined #openstack-oslo | 18:19 | |
*** devkulkarni has quit IRC | 18:26 | |
*** permalac has quit IRC | 18:35 | |
*** dtardivel has quit IRC | 18:38 | |
*** MVenesio has quit IRC | 18:40 | |
*** yamahata_ has joined #openstack-oslo | 18:41 | |
*** rlrooster has quit IRC | 18:42 | |
openstackgerrit | Joshua Harlow proposed openstack/tooz: Add mysql table support (if provided a database) https://review.openstack.org/290178 | 18:43 |
*** sputnik13 has joined #openstack-oslo | 18:43 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.config: Fix isinstance call https://review.openstack.org/291857 | 18:44 |
dims_ | zigo : can you try that? hopefully will see a better error? | 18:44 |
dims_ | zigo : ^^ | 18:44 |
dims_ | dhellmann : ^^ | 18:44 |
*** rlrooste_ has joined #openstack-oslo | 18:46 | |
*** rlrooste_ is now known as rlrossit | 18:47 | |
zigo | dims_: Will do after dinner, thanks! | 18:49 |
dhellmann | dims_ : sheesh, who wrote this thing? | 18:51 |
dims_ | haha | 18:51 |
*** yassine__ has quit IRC | 18:52 | |
lifeless | haypo: thats what it is for you, but it is not what it is. | 18:55 |
lifeless | haypo: it is a centralisation of the packaging related thing in openstack to avoid duplication, and some of those things are runtime, some are buildtime. | 18:55 |
*** vilobhmm11 has joined #openstack-oslo | 19:00 | |
*** suro-patz has quit IRC | 19:02 | |
*** e0ne_ has joined #openstack-oslo | 19:13 | |
*** e0ne has quit IRC | 19:14 | |
*** suro-patz has joined #openstack-oslo | 19:21 | |
*** devkulkarni has joined #openstack-oslo | 19:22 | |
*** amrith is now known as _amrith_ | 19:38 | |
*** e0ne_ has quit IRC | 19:40 | |
rbradfor | krotscheck, question about oslo.middleware.cors and its dependency on neutron? | 20:00 |
*** fhermeni has joined #openstack-oslo | 20:05 | |
fhermeni | hello | 20:05 |
*** cdent_ has joined #openstack-oslo | 20:07 | |
kevinbenton | zzzeek: around for a quick question about the core commit event? (http://docs.sqlalchemy.org/en/latest/core/events.html#sqlalchemy.events.ConnectionEvents.commit) | 20:08 |
zzzeek | kevinbenton: hey | 20:09 |
kevinbenton | zzzeek: hey. if i have a subscriber to that just throw a random exception, will that rollback the commit? | 20:09 |
kevinbenton | zzzeek: or do i need to call something specific on the connection passed in to trigger a rollback? | 20:09 |
*** cdent has quit IRC | 20:10 | |
*** cdent_ is now known as cdent | 20:10 | |
zzzeek | kevinbenton: within a flush, an exception that's raised has kind of a nested effect | 20:10 |
zzzeek | the flush emits a ROLLBACK and rolls back the "nested" transaction that's local to the flush | 20:10 |
zzzeek | but the Session itself is in a more enclosing transaction, the application needs to rollback() that as well, explicitly | 20:11 |
zzzeek | if anyone emits a rollback, there | 20:11 |
zzzeek | there's no commit() called. | 20:11 |
fhermeni | harlowja_at_home: ping ? | 20:11 |
zzzeek | kevinbenton: oh ok , if they raise in the event handler | 20:12 |
zzzeek | ummm...let me check | 20:12 |
kevinbenton | zzzeek: right. to give some context, i have this kind of wonky test in neutron to simulate a failure to commit after IP allocation is inserted | 20:12 |
kevinbenton | zzzeek: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/test_plugin.py#L791-L829 | 20:12 |
zzzeek | and thats the conection-level event not the ORM one, OK | 20:12 |
*** nikhil_k has quit IRC | 20:12 | |
zzzeek | kevinbenton: the commit connection event is called before the DB commit is called | 20:13 |
zzzeek | so if you raise, it wont commit | 20:13 |
zzzeek | but, not sure if that will emit a rollback | 20:13 |
zzzeek | in core it's not automatic | 20:14 |
kevinbenton | zzzeek: ok. so the strange behavior i'm seeing is that there still seem to be objects in the session after that exception goes all of the way up to the api layer and starts the proces over | 20:14 |
zzzeek | kevinbenton: well "objects in the session" can mean a lot of things | 20:14 |
kevinbenton | zzzeek: i suspected you would want real terminology :) | 20:14 |
zzzeek | kevinbenton: can you make a proof case | 20:15 |
kevinbenton | FlushError: New instance <IPAllocation at 0x7fd98001ce50> with identity key (<class 'neutron.db.models_v2.IPAllocation'>, (u'10.0.0.2', u'70dfccfd-f18a-423b-9323-095a38b301a9', u'4e0d6054-6f90-450d-87d6-fb86fa194a91')) conflicts with persistent instance <IPAllocation at 0x7fd9805aa910> | 20:15 |
zzzeek | code > terminology | 20:15 |
kevinbenton | zzzeek: so the ip allocation object that was created from the first time stuck around | 20:15 |
kevinbenton | zzzeek: i'm not sure if its because a reference to it leaked somewhere else in the code, or if its just that i'm not triggering a db failure in the way i think | 20:16 |
zzzeek | ok well the objects in the session are distinct from the transaction to a large degree | 20:16 |
zzzeek | that's a pending instance | 20:17 |
zzzeek | a pending instance should be kicked out if you call session.rollback() but otherwise it will still be sitting there | 20:17 |
kevinbenton | zzzeek: the persistent one, right? | 20:17 |
zzzeek | the error is because ther's both at the same time | 20:18 |
kevinbenton | zzzeek: right | 20:18 |
zzzeek | kevinbenton: i'd need to see the specific sequence of calls to really know what's happening | 20:18 |
kevinbenton | zzzeek: so an explicit call to rollback might do the trick then? | 20:18 |
zzzeek | kevinbenton: yes | 20:18 |
kevinbenton | zzzeek: ok. let me mess around a bit and then i'll try to distill it down if i can't straighten it out | 20:19 |
zzzeek | kevinbenton: ther's ORM level commit events you ight want to stick w/ those | 20:19 |
kevinbenton | zzzeek: IIRC i had an issue using those, but i can't remember why now | 20:19 |
kevinbenton | zzzeek: i'll try a switch to those first | 20:19 |
zzzeek | kevinbenton: that's possilre, thorwing an exception in the event handler might not do what you want | 20:19 |
*** ihrachys has joined #openstack-oslo | 20:21 | |
*** vilobhmm11 has quit IRC | 20:26 | |
*** vilobhmm11 has joined #openstack-oslo | 20:27 | |
*** vilobhmm11 has quit IRC | 20:27 | |
dhellmann | dims_ : https://review.openstack.org/#/q/I6a8c7d44b9db9325003ff2fdb667b0ced7739e96,n,z | 20:34 |
*** MVenesio has joined #openstack-oslo | 20:35 | |
dims_ | dhellmann : ouch ok | 20:36 |
dhellmann | dims_ : I'm looking at the oslo.config docs now to see how to make the name rule more clear | 20:36 |
dims_ | thanks dhellmann | 20:38 |
openstackgerrit | Doug Hellmann proposed openstack/oslo.config: improve documentation about registering entry points for config generator https://review.openstack.org/291904 | 20:41 |
dhellmann | dims_ : ^^ | 20:41 |
dims_ | +2 dhellmann | 20:45 |
*** cdent has quit IRC | 20:48 | |
*** cdent has joined #openstack-oslo | 20:49 | |
krotscheck | dhellmann: Checking. | 20:52 |
*** cdent has quit IRC | 20:54 | |
krotscheck | rbradfor, dhellmann: Hrm. Ok, I'll go ahead and update the patches that haven't landed yet first, the move on to the ones y'all haven't covered yet | 20:55 |
dhellmann | krotscheck : I grepped for the cors middleware in openstack/* and found 10 | 20:55 |
dhellmann | do you have others? | 20:55 |
krotscheck | dhellmann: There should be 22 | 20:55 |
dhellmann | if so, please use the same topic name so we can track them together | 20:56 |
dhellmann | krotscheck : ok, I'm only finding 14 that even set oslo.config.opts.defaults | 20:56 |
krotscheck | dhellmann: https://review.openstack.org/#/q/branch:master+topic:bug/1551836 | 20:56 |
dhellmann | ah, some haven't merged | 20:57 |
krotscheck | THere's 20 there. Ironic does its own thing. Barbican, trove, and designate don't use config gen. | 20:57 |
krotscheck | Cloudkitty hasn't merged it yet because they havent' released liberty yet. | 20:57 |
*** itisha has quit IRC | 20:59 | |
*** vilobhmm11 has joined #openstack-oslo | 21:01 | |
*** vilobhmm11 has quit IRC | 21:01 | |
*** vilobhmm11 has joined #openstack-oslo | 21:02 | |
*** vilobhmm11 has quit IRC | 21:02 | |
krotscheck | dhellmann: Ok, so just to be _absolutely_ clear. | 21:02 |
dhellmann | krotscheck : ah, some use oslo.middleware not just oslo.middleware.cors | 21:03 |
krotscheck | dhellmann: The name of the hook is the name of the config file? | 21:03 |
krotscheck | dhellmann: And it's only supposed to be _one_ function? | 21:03 |
krotscheck | Instead of one per entry in the genconfig config? | 21:03 |
dhellmann | krotscheck : the name of the hook needs to be unique. it should be named based on the application, or some entry point in oslo.config.opts defined by the application. | 21:03 |
dhellmann | so, I just fixed nova by renaming it from oslo.middleware to nova.api | 21:04 |
*** vilobhmm11 has joined #openstack-oslo | 21:04 | |
dhellmann | and yeah, the idea was that there would be one function used to override the defaults emitted for a sample config for each application within a project (nova api, conductor, etc.) | 21:04 |
dhellmann | and each of those application functions might call a bunch of other functions in the libraries that it needs to initialize | 21:05 |
*** sigmavirus24 is now known as sigmavirus24_awa | 21:05 | |
krotscheck | oookaaaaay | 21:05 |
* krotscheck may be a little grump that he has to do _het another_ set of patches for cors. | 21:06 | |
krotscheck | *yet | 21:06 |
zigo | dims_: So, your patch fixed the issue (ie: the files are now correctly generated), however, I still get some warnings when running oslo-config-generator: http://paste.openstack.org/show/490258/ | 21:06 |
dhellmann | the problem is, with all of the services installed together, the config generator sees all of the functions registered under oslo.config.opts.defaults, and then it loads the ones with the names that match the entries in the current config file, which means it loads foo from whereever it lives, and if it lives in the wrong app, you're crossing the streams | 21:06 |
zigo | dims_: This is version 2.1.0 of keystoneauth | 21:06 |
dhellmann | krotscheck : I think I've fixed all of the ones that already had the bad value land | 21:06 |
*** vilobhmm11 has quit IRC | 21:06 | |
*** gordc has quit IRC | 21:06 | |
zigo | dims_: Should I try upgrading to version 2.3.0 ? | 21:07 |
zigo | dims_: At least, I can go further in my Tempest CI run, that's already super useful... :P | 21:07 |
zigo | I'll ignore the warnings until you can reply to me if I *must* upgrade keystoneauth now, or if this can wait. | 21:08 |
krotscheck | dhellmann: Much appreciated. | 21:08 |
zigo | dims_: I'd also suggest releasing a new oslo.config with this patch of yours. As always, I'm the one and only person in the whole community to test config files in projects! :D | 21:09 |
zigo | dims_: Whatever happens, *thanks so much* !!! :) | 21:10 |
*** suro-patz has joined #openstack-oslo | 21:12 | |
rbradfor | zigo, re your pastebin. I was looking into a problem about option names in keystoneauth1, and I found out for example, it's user-id (that's dash). See also domain-id http://git.openstack.org/cgit/openstack/keystoneauth/tree/keystoneauth1/loading/identity.py#n77 Wonder if related in any way? | 21:16 |
dims_ | zigo : in general, my advice is to pick up versions from upper-constraints.txt as those are the ones thoroughly tested | 21:17 |
krotscheck | dhellmann: Ok, I've updated the patches still in-flight. Are there any remaining ones that have already landed that need to be updated? | 21:17 |
dims_ | zigo : y, will figure out when we can ship this patch in generator | 21:17 |
*** kgiusti has quit IRC | 21:20 | |
*** sigmavirus24_awa is now known as sigmavirus24 | 21:22 | |
dhellmann | krotscheck : I think I've caught all of the variations, but you could double check the list against https://review.openstack.org/#/q/topic:fix-config-default | 21:23 |
zigo | dims_: Yeah, that's what I've done, ie I took a snapshot of the global-requirements.txt and upper-constraints.txt when Mitaka b3 was out. | 21:23 |
krotscheck | dhellmann: WIlldo. | 21:23 |
dims_ | zigo : ack, we have been holding the line on g-c and u-c for a week or so now. it may be a good idea to do a diff. i think we pushed some libs out | 21:24 |
zigo | dims_: I usually make it all work for b3, make my Tempest CI to work, and *THEN* upgrade components as much as possible, until the final release. | 21:25 |
dims_ | zigo sounds like a good plan | 21:25 |
krotscheck | dhellmann: You missed mistral. On it. | 21:26 |
zigo | dims_: FYI, that's how I found out: https://mitaka-jessie.pkgs.mirantis.com/job/openstack-tempest-ci/33/console | 21:26 |
zigo | :) | 21:26 |
dhellmann | krotscheck : written but not submitted: https://review.openstack.org/291917 | 21:26 |
krotscheck | DOH | 21:26 |
krotscheck | :) | 21:26 |
krotscheck | beat me to it. | 21:27 |
zigo | dims_: I got a new server with 32 GB of RAM just to do these tempest tests. That's a way more efficient than running on my good old 4GB RAM Xen VM which was even failing tests because of the lack of RAM. | 21:27 |
zigo | :) | 21:27 |
dhellmann | the problem with doing 15 patches quickly... | 21:27 |
krotscheck | dhellmann: No kididng | 21:27 |
krotscheck | dhellmann: Ok, I think we're covered at this point. | 21:27 |
zigo | dims_: I run Debian Live there (booted over network), then I just ssh into it, and install an all-in-one OpenStack, on which I run tempest. | 21:27 |
dhellmann | krotscheck : thanks for double checking, I would have missed a bunch if I didn't realize there were variations on the theme | 21:27 |
zigo | dims_: So, everything runs in a RAMdisk. | 21:27 |
zigo | Fun... | 21:27 |
krotscheck | The only question I have is wehther I should try to land cors in some of the newer API's like freezer. | 21:27 |
zigo | Reinstall everything? Just reset the server ... :P | 21:27 |
zigo | 1min 30, it's rebooted, and ready to reinstall OpenStack. | 21:28 |
dhellmann | krotscheck : at this point, if it isn't in it's a risk to making the RC1 tags next week, so I think those will have to wait for newton to open up | 21:28 |
krotscheck | dhellmann: No worries, thanks for jumping in and doing those patches while I was covered in diapers. | 21:28 |
*** nikhil_k has joined #openstack-oslo | 21:28 | |
* dhellmann tries to get that image out of his head | 21:28 | |
krotscheck | dhellmann: It's the new trend in engineer couture. | 21:28 |
dhellmann | we just have hipster food courts down here in my area | 21:29 |
krotscheck | dhellmann: branded tshirt and jeans are out, cloth diapers and baby drool are in. | 21:29 |
dhellmann | pass | 21:29 |
dhellmann | but, you know, enjoy :-) | 21:29 |
krotscheck | Ok, I'm off to deal with mr. fussy | 21:29 |
krotscheck | ping me if something else comes up. | 21:29 |
dhellmann | I'm taking off shortly, too, so we'll see how things look monday | 21:29 |
*** MVenesio has quit IRC | 21:33 | |
*** mriedem has quit IRC | 21:36 | |
openstackgerrit | Miguel Angel Ajo proposed openstack/oslo.versionedobjects: Add BaseEnumField valid_values introspection https://review.openstack.org/287106 | 21:41 |
*** vilobhmm11 has joined #openstack-oslo | 21:57 | |
*** fhermeni has quit IRC | 21:57 | |
*** e0ne has joined #openstack-oslo | 21:59 | |
*** suro-patz has quit IRC | 22:01 | |
*** suro-patz has joined #openstack-oslo | 22:01 | |
kevinbenton | zzzeek: intestingly when i attach the debugger that persistent instance goes away :/ | 22:02 |
*** jaypipes has quit IRC | 22:02 | |
zzzeek | kevinbenton: OK perhaps a gc.collect() would do it | 22:02 |
zzzeek | kevinbenton: sometimes instances are associated with a stack trace and not being GC'ed | 22:03 |
kevinbenton | zzzeek: ah. that makes sense | 22:03 |
kevinbenton | zzzeek: because when i tried to convert it to a merge just to see if they would play nice, it would complain about it being deleted | 22:03 |
zzzeek | kevinbenton: make a strong reference to it, if possible | 22:04 |
kevinbenton | zzzeek: well i actually want it to be dead | 22:04 |
kevinbenton | zzzeek: i was confused about why it was still around | 22:04 |
zzzeek | ok | 22:04 |
*** e0ne has quit IRC | 22:04 | |
zzzeek | well strogn refernce then expunge() it, perhaps | 22:04 |
kevinbenton | zzzeek: this was on a complete failure and start over scenario | 22:04 |
zzzeek | right | 22:04 |
zzzeek | if the session is rolled back it should be out | 22:04 |
kevinbenton | zzzeek: is there a known reference to that issue with garbage collection? just so i can put a pointer to something in my commit | 22:05 |
zzzeek | kevinbenton: again since i dont see what you're doing i cant really make any observations | 22:09 |
zzzeek | there's all kinds of surprises with garbage collection in general | 22:09 |
kevinbenton | zzzeek: i see. it's just a side effect of the session haveing a weakref to it, not anything in particular with how sqlalchemy handles gc | 22:10 |
kevinbenton | ? | 22:10 |
zzzeek | kevinbenton: there sohuld always be a path such that whether GC happened or not is not getting in your way | 22:11 |
zzzeek | kevinbenton: e.g. if you have a Session and you've done a rollback, anything that's not supposed to be there would be pushed out | 22:11 |
*** rlrossit has quit IRC | 22:13 | |
kevinbenton | zzzeek: ack. let me see if i can find out the root cause. may be an exception handler grabbing onto something | 22:13 |
kevinbenton | zzzeek: thanks for your help | 22:13 |
*** melwitt has quit IRC | 22:18 | |
*** melwitt has joined #openstack-oslo | 22:18 | |
*** regXboi has quit IRC | 22:21 | |
openstackgerrit | Merged openstack/oslo.config: Fix isinstance call https://review.openstack.org/291857 | 22:31 |
*** melwitt has quit IRC | 22:36 | |
*** melwitt has joined #openstack-oslo | 22:36 | |
*** andymaier has joined #openstack-oslo | 22:37 | |
*** david-lyle has quit IRC | 22:37 | |
*** andymaier has quit IRC | 22:37 | |
*** devkulkarni has quit IRC | 22:40 | |
openstackgerrit | Merged openstack/oslo.config: improve documentation about registering entry points for config generator https://review.openstack.org/291904 | 22:43 |
*** dimtruck is now known as zz_dimtruck | 22:46 | |
*** rcernin has joined #openstack-oslo | 22:47 | |
*** ihrachys has quit IRC | 22:53 | |
*** amotoki has quit IRC | 23:04 | |
*** rcernin has quit IRC | 23:06 | |
*** rcernin has joined #openstack-oslo | 23:08 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 23:22 | |
*** rcernin has quit IRC | 23:31 | |
*** ndipanov has quit IRC | 23:38 | |
*** vilobhmm11 has quit IRC | 23:46 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!