Friday, 2016-03-11

*** tonyb has joined #openstack-oslo00:10
tonybCan anyone here help me with running the oslo.db unit tests (on kilo)00:11
tonybI'm getting 'db type could not be determined' :(00:12
tonybI followed http://docs.openstack.org/developer/oslo.db/contributing.html#how-to-run-unit-tests but still no dice :/00:13
*** openstackgerrit_ has quit IRC00:23
*** openstackgerrit_ has joined #openstack-oslo00:24
*** yamamoto_ has joined #openstack-oslo00:24
*** bapalm has quit IRC00:24
*** yamamoto_ has quit IRC00:28
*** vilobhmm11 has quit IRC00:37
*** suro-patz has quit IRC00:37
*** bapalm has joined #openstack-oslo00:41
*** openstackgerrit_ has quit IRC00:48
*** openstackgerrit_ has joined #openstack-oslo00:49
*** EinstCrazy has joined #openstack-oslo00:51
*** browne has quit IRC00:51
*** browne has joined #openstack-oslo00:52
*** EinstCrazy has quit IRC00:54
*** devkulkarni has joined #openstack-oslo01:01
*** devkulkarni has quit IRC01:19
*** vilobhmm11 has joined #openstack-oslo01:22
*** vilobhmm11 has quit IRC01:25
*** dimtruck is now known as zz_dimtruck01:39
*** nikhil_k has quit IRC01:42
*** mtanino has quit IRC02:02
*** dims has quit IRC02:08
*** bapalm has quit IRC02:11
*** browne has quit IRC02:11
gcb_rbradfor, yes, we need a plan to clean up oslo-incubator stuff, we can work together in next release :-)02:15
*** bapalm has joined #openstack-oslo02:16
*** dims has joined #openstack-oslo02:17
*** devkulkarni has joined #openstack-oslo02:19
*** yamamoto_ has joined #openstack-oslo02:25
*** nikhil has joined #openstack-oslo02:34
*** devkulkarni has quit IRC02:39
*** nikhil has quit IRC02:43
*** yamamoto_ has quit IRC02:48
*** dims has quit IRC02:58
*** sputnik13 has quit IRC03:00
*** suro-patz has joined #openstack-oslo03:11
*** dims has joined #openstack-oslo03:13
*** dims has quit IRC03:18
*** barra204 has joined #openstack-oslo03:21
*** jpena has joined #openstack-oslo03:23
*** yamahata_ has joined #openstack-oslo03:25
*** amauryme` has joined #openstack-oslo03:29
*** mtreinish_ has joined #openstack-oslo03:29
*** jpena|zzz has quit IRC03:30
*** krotscheck has quit IRC03:30
*** yamahata has quit IRC03:30
*** shakamunyi has quit IRC03:30
*** mtreinish has quit IRC03:30
*** amaurymedeiros has quit IRC03:30
*** mtreinish_ is now known as mtreinish03:30
*** krotscheck has joined #openstack-oslo03:31
*** zz_dimtruck is now known as dimtruck03:31
*** yamamoto has joined #openstack-oslo03:36
*** yamahata_ has quit IRC03:36
*** suro-patz has quit IRC03:38
openstackgerritjaveme proposed openstack/oslo.vmware: Should not raise Exception before connection close  https://review.openstack.org/28122203:41
*** links has joined #openstack-oslo03:45
*** dimtruck is now known as zz_dimtruck03:52
*** nikhil has joined #openstack-oslo03:54
*** nikhil_k has joined #openstack-oslo03:54
*** Nakato_ is now known as Nakato03:56
*** suro-patz has joined #openstack-oslo04:03
*** browne has joined #openstack-oslo04:08
*** amrith is now known as _amrith_04:10
*** suro-patz has quit IRC04:10
openstackgerritMerged openstack/oslo.messaging: Ensure the json result type is bytes on Python 3  https://review.openstack.org/28396804:10
*** suro-patz has joined #openstack-oslo04:28
*** devkulkarni has joined #openstack-oslo04:54
*** zz_dimtruck is now known as dimtruck04:57
*** jamespage has quit IRC05:00
*** jamespage has joined #openstack-oslo05:00
*** nikhil has quit IRC05:23
*** jdandrea has quit IRC05:33
*** devkulkarni has quit IRC05:36
*** jdandrea has joined #openstack-oslo05:40
*** suro-patz has quit IRC05:42
*** jdandrea_ has joined #openstack-oslo05:49
*** cburgess has quit IRC05:49
*** jdandrea has quit IRC05:50
*** amotoki has joined #openstack-oslo05:50
*** amotoki has quit IRC05:50
*** melwitt has quit IRC05:51
*** cburgess has joined #openstack-oslo05:52
openstackgerritjaveme proposed openstack/oslo.vmware: Refactor VmdkWriteHandle and VmdkReadHandle  https://review.openstack.org/28125005:52
*** dimtruck is now known as zz_dimtruck05:55
*** browne has quit IRC05:56
*** obondarev has quit IRC05:56
*** dansmith has quit IRC05:56
*** melwitt has joined #openstack-oslo05:57
*** yamahata_ has joined #openstack-oslo05:59
*** krotscheck has quit IRC06:01
*** browne has joined #openstack-oslo06:02
*** obondarev has joined #openstack-oslo06:02
*** dansmith has joined #openstack-oslo06:02
*** barra204 has quit IRC06:04
*** obondarev_ has joined #openstack-oslo06:09
*** krotscheck has joined #openstack-oslo06:09
*** obondarev has quit IRC06:10
*** yamahata_ has quit IRC06:10
*** openstackgerrit_ has quit IRC06:17
*** openstackgerrit_ has joined #openstack-oslo06:17
*** Guest68942 has joined #openstack-oslo06:18
*** EinstCrazy has joined #openstack-oslo06:20
*** EinstCrazy has quit IRC06:23
*** eezhova has quit IRC06:23
*** eezhova has joined #openstack-oslo06:23
openstackgerritJoshua Harlow proposed openstack/tooz: Add mysql table support (if provided a database)  https://review.openstack.org/29017806:30
openstackgerritjaveme proposed openstack/oslo.messaging: Should send bytes message in kafka on Python 3  https://review.openstack.org/29156306:36
*** rcernin has joined #openstack-oslo06:49
*** nkrinner has joined #openstack-oslo06:50
*** browne has quit IRC07:10
*** dansmith has quit IRC07:10
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/oslo.config: Replace deprecated LOG.warn with LOG.warning  https://review.openstack.org/29157507:16
openstackgerritSwapnil Kulkarni (coolsvap) proposed openstack/oslo.messaging: Replace deprecated LOG.warn with LOG.warning  https://review.openstack.org/29157607:19
*** browne has joined #openstack-oslo07:21
*** dansmith has joined #openstack-oslo07:21
*** amotoki has joined #openstack-oslo07:29
*** vilobhmm11 has joined #openstack-oslo07:39
*** pkholkin__ has quit IRC07:42
*** pkholkin__ has joined #openstack-oslo07:42
*** Guest68942 has quit IRC07:45
*** browne has quit IRC07:47
*** dansmith has quit IRC07:47
*** nikhil has joined #openstack-oslo07:47
*** browne has joined #openstack-oslo07:54
*** dansmith has joined #openstack-oslo07:54
*** harlowja_at_home has quit IRC08:00
haypohum. it looks like "Ensure the json result type is bytes on Python 3" change simply broke all tests on python3... https://review.openstack.org/#/c/283968/08:18
patchbothaypo: patch 283968 - oslo.messaging - Ensure the json result type is bytes on Python 3 (MERGED)08:18
*** e0ne has joined #openstack-oslo08:21
*** ozamiatin__ has joined #openstack-oslo08:21
*** jamielennox is now known as jamielennox|away08:23
*** dtardivel has joined #openstack-oslo08:26
*** shardy has joined #openstack-oslo08:35
*** yamahata_ has joined #openstack-oslo08:35
*** gcb_ has quit IRC08:35
*** browne has quit IRC08:37
*** pcaruana has joined #openstack-oslo08:41
*** ihrachys has joined #openstack-oslo08:45
*** gcb_ has joined #openstack-oslo08:47
silehthaypo, I feel your pain08:52
hayposileht: i'm still trying to understand the change since 1h...08:53
silehthaypo, I have run tox -py34 on mate and tests pass08:53
silehtmate/master08:54
hayposileht: kombu serializer calls json.dumps(). oslo messaging pass a dict where one value type is bytes08:54
haypojson.dumps see bytes as a list of integers...08:54
silehtlol08:54
hayposileht: "tests pass"??08:54
hayposileht: master like commit 67c8987372180e16b62f968c5036a05a27a17bc3 ?08:55
silehthaypo, wait my master wasn't up2date08:55
haypoMerge "Ensure the json result type is bytes on Python 3"08:55
* sileht retries08:55
hayposileht: yeah, the tests pass without this change08:55
haypothe change is supposed to fix something on py3. before the change, tests pass on py3. after the change, tests fail on py3....08:56
hayposileht: i checked the py34 gate because i wanted to make it voting again. i'm disappointed to see that it was broken this morning08:57
haypoi hate you08:57
haypo:)08:57
openstackgerritVictor Stinner proposed openstack/oslo.messaging: Revert "Ensure the json result type is bytes on Python 3"  https://review.openstack.org/29160909:00
hayposileht: ^^09:00
*** vilobhmm11 has quit IRC09:00
*** lucas-afk is now known as lucasagomes09:06
*** salv-orlando has joined #openstack-oslo09:09
haypolifeless: for me, pbr is a tool to build a package, not even to install a packaging, so it doesn't make sense to require it at runtime09:14
*** ozamiatin__ has quit IRC09:16
*** salv-orlando has quit IRC09:25
*** yamahata_ has quit IRC09:26
hayposileht: oh. i used the [Revert] button in Jenkins to create the Revert change. i see that it doesn't wrap long lines in the commit message09:27
*** pblaho has joined #openstack-oslo09:27
*** yassine__ has joined #openstack-oslo09:35
*** permalac has joined #openstack-oslo09:37
*** permalac has quit IRC09:37
*** permalac_ has joined #openstack-oslo09:38
*** yamamoto has quit IRC09:40
*** ndipanov has joined #openstack-oslo09:51
*** mhickey_ has joined #openstack-oslo09:53
openstackgerritMerged openstack/oslo.messaging: test: Don't test message's reply timeout  https://review.openstack.org/26462110:16
*** ozamiatin__ has joined #openstack-oslo10:19
*** ozamiatin__ has quit IRC10:20
*** permalac_ has quit IRC10:29
*** sdague has joined #openstack-oslo10:30
gcb_tonyb, Did you get the error 'db type could not be determined' in py33 or py34 ?10:33
tonybgcb_: py3410:42
gcb_yeah, you must run py26 or py27 before py34.  just adjust the order in tox.ini, let me find the bug :-)10:43
gcb_it's tox's bug10:43
tonybHmm I've closed the window now but I thought I was doing tox -epy3410:43
tonybbut perhaps I had run a plain tox at some point10:44
tonybpointer to the bug would be helpful10:44
tonybOh You *must* run py27 first.  so tox -epy34 will fail but tox -epy27,py34 shoudl be ok?10:45
haypotonyb: your must run py3 first10:46
gcb_tox py34 can't  read the datbase generated by py2610:46
gcb_database10:46
haypotonyb: testrepository uses dbm database. py3 database works on py2+py3. if you create the DB with py2, it only works on py210:47
haypoone year ago, i heard that testrepository is going to get a more generic DB code to support sqlite10:47
haypobut it looks like it still uses dbm in practice10:48
gcb_haypo, correct:-)10:48
haypo(sqlite works on all python versions)10:48
tonybokay so I have a clean checkout of oslo.db (stable/kilo).  How shoudl I run tox to actually test the py34 code paths10:50
tonybThis is a little moot as I have a patch up that passes CI, I just couldn't do the tests locally10:50
*** ozamiatin__ has joined #openstack-oslo10:50
haypo"I have a clean checkout of oslo.db" just remove the .testrepository directory10:51
openstackgerritGevorg Davoian proposed openstack/oslo.messaging: Pika: fix sending fanout messages  https://review.openstack.org/28943010:52
tonybokay, and now tox -e py34,py27 work (and pass tests) :)10:52
gcb_cool, we had adjust the order in master in many projects10:53
*** dims has joined #openstack-oslo10:54
-openstackstatus- NOTICE: Gerrit is going to be restarted due to bad performance10:54
*** ChanServ changes topic to "Gerrit is going to be restarted due to bad performance"10:54
tonybgcb_, haypo: Thanks10:56
*** ChanServ changes topic to "#openstack-oslo"10:59
-openstackstatus- NOTICE: Gerrit has been restarted successfully10:59
*** yamamoto has joined #openstack-oslo11:02
*** yamamoto_ has joined #openstack-oslo11:06
*** yamamoto has quit IRC11:09
silehtjd__, do you think file generated by the file Tooz driver must be compatible between py3 and py2 ?11:15
*** d0ugal has quit IRC11:16
*** d0ugal has joined #openstack-oslo11:17
*** e0ne has quit IRC11:23
*** yamamoto_ has quit IRC11:25
*** yamamoto has joined #openstack-oslo11:26
*** e0ne has joined #openstack-oslo11:26
*** salv-orlando has joined #openstack-oslo11:28
*** yamamoto has quit IRC11:30
*** tesseract has joined #openstack-oslo11:33
*** tesseract has quit IRC11:34
*** Guest16009 has joined #openstack-oslo11:34
*** cdent has joined #openstack-oslo11:36
*** nkrinner has quit IRC11:36
*** Guest16009 has quit IRC11:37
*** nkrinner has joined #openstack-oslo11:38
*** salv-orlando has quit IRC11:39
*** tesseract- has joined #openstack-oslo11:40
*** yamamoto has joined #openstack-oslo11:42
*** yamamoto has quit IRC11:43
*** _amrith_ is now known as amrith11:44
*** EinstCrazy has joined #openstack-oslo11:48
openstackgerritjaveme proposed openstack/oslo.vmware: Refactor VmdkWriteHandle and VmdkReadHandle  https://review.openstack.org/28125011:56
*** lucasagomes is now known as lucas-hungry12:07
jd__sileht: yes since you could have different consumers with different python version running12:10
*** yassine__ has quit IRC12:17
silehtjd__, so I will open a bug :)12:29
*** yamamoto has joined #openstack-oslo12:31
*** dims has quit IRC12:33
*** amrith is now known as _amrith_12:33
silehtjd__, I thought the python2 is buggy :(12:36
*** dims has joined #openstack-oslo12:36
*** dguitarbite has quit IRC12:37
*** yamamoto has quit IRC12:40
*** ozamiatin__ has quit IRC12:40
*** cdent_ has joined #openstack-oslo12:43
*** cdent has quit IRC12:47
*** cdent_ is now known as cdent12:47
*** _amrith_ is now known as amrith12:47
*** jpena is now known as jpena|lunch12:51
*** e0ne has quit IRC12:54
*** yamamoto has joined #openstack-oslo12:54
*** e0ne has joined #openstack-oslo12:54
*** amrith is now known as _amrith_13:00
*** itisha has joined #openstack-oslo13:01
*** yamamoto has quit IRC13:01
*** e0ne has quit IRC13:03
*** dims_ has joined #openstack-oslo13:03
*** e0ne has joined #openstack-oslo13:04
*** dims has quit IRC13:04
*** devkulkarni has joined #openstack-oslo13:12
*** yamamoto has joined #openstack-oslo13:26
*** pradk_ has joined #openstack-oslo13:26
*** pradk_ has quit IRC13:26
silehtjd__, haypo, python3 issue https://bugs.launchpad.net/oslo.serialization/+bug/155608113:26
openstackLaunchpad bug 1556081 in tooz "file driver doesn't write the same data in file in python 2 and python3" [Undecided,New]13:26
silehtI dunno what the best way to fix this13:27
*** lucas-hungry is now known as lucasagomes13:29
*** bogdando has joined #openstack-oslo13:33
*** links has quit IRC13:39
*** links has joined #openstack-oslo13:42
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization  https://review.openstack.org/29171513:43
*** rlrossit has joined #openstack-oslo13:44
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization  https://review.openstack.org/29171513:46
*** kgiusti has joined #openstack-oslo13:55
*** cdent has quit IRC13:57
openstackgerritPiyush Raman Srivastava proposed openstack/oslo.config: Fix typo error in docstrings of oslo_config.cfg.py  https://review.openstack.org/29172214:03
openstackgerritPiyush Raman Srivastava proposed openstack/oslo.config: Fix typo error in docstrings of oslo_config.cfg.py  https://review.openstack.org/29172214:06
*** dims_ has quit IRC14:07
*** yassine__ has joined #openstack-oslo14:08
*** ozamiatin_ has quit IRC14:09
*** ozamiatin__ has joined #openstack-oslo14:09
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization  https://review.openstack.org/29171514:12
*** rlrossit has quit IRC14:12
*** devkulkarni has quit IRC14:14
*** mriedem has joined #openstack-oslo14:14
*** gordc has joined #openstack-oslo14:14
*** dims has joined #openstack-oslo14:17
*** links has quit IRC14:17
*** cdent has joined #openstack-oslo14:20
*** dims has quit IRC14:23
openstackgerritMerged openstack/oslo.messaging: Revert "Ensure the json result type is bytes on Python 3"  https://review.openstack.org/29160914:25
mriedemdhellmann: jd__: sileht: can we get this oslo.db kilo backport in? it fixes a blocker to land oslo.db changes on kilo which is blocking other projects in kilo https://review.openstack.org/#/c/291472/14:25
patchbotmriedem: patch 291472 - oslo.db (stable/kilo) - Fix tests to work under both pymsysql 0.6.2 and 0.7.x14:25
*** ericksonsantos has quit IRC14:26
*** nikhil has quit IRC14:26
*** ericksonsantos has joined #openstack-oslo14:27
*** nikhil has joined #openstack-oslo14:27
*** rlrossit has joined #openstack-oslo14:27
dhellmannmriedem : +2a14:31
mriedemthanks14:32
*** _amrith_ is now known as amrith14:32
*** rlrossit is now known as edit_14:32
*** dims has joined #openstack-oslo14:32
*** mriedem is now known as dontrump14:32
*** edit_ is now known as rlrooster14:33
*** jpena|lunch is now known as jpena14:35
*** dansmith is now known as superdan14:36
*** zz_dimtruck is now known as dimtruck14:50
*** MVenesio has joined #openstack-oslo14:52
*** salv-orlando has joined #openstack-oslo15:00
*** devkulkarni has joined #openstack-oslo15:04
*** sigmavirus24_awa is now known as sigmavirus2415:06
*** dims_ has joined #openstack-oslo15:07
*** dims has quit IRC15:08
*** dims_ has quit IRC15:11
*** ndipanov has quit IRC15:13
*** dims has joined #openstack-oslo15:14
*** salv-orlando has quit IRC15:14
*** salv-orlando has joined #openstack-oslo15:16
*** ndipanov has joined #openstack-oslo15:17
*** harlowja_at_home has joined #openstack-oslo15:17
*** regXboi has joined #openstack-oslo15:34
*** salv-orlando has quit IRC15:35
hayposileht: i'm reading your issue15:38
hayposileht: i should chek how this issue is handled in the python stdlib15:38
haypocheck15:39
*** jaypipes is now known as leakypipes15:45
*** yamahata_ has joined #openstack-oslo15:45
*** devkulkarni has quit IRC15:46
*** yamamoto has quit IRC15:49
*** mtanino has joined #openstack-oslo15:49
*** nkrinner has quit IRC15:49
*** yamamoto has joined #openstack-oslo15:49
*** yamamoto has quit IRC15:50
*** yamamoto has joined #openstack-oslo15:51
*** yamamoto has quit IRC15:56
*** permalac has joined #openstack-oslo16:01
*** browne has joined #openstack-oslo16:20
*** nikhil has quit IRC16:37
*** dims has quit IRC16:38
*** pblaho has quit IRC16:42
*** pcaruana has quit IRC16:50
*** dims has joined #openstack-oslo16:50
*** ozamiatin__ has quit IRC16:51
*** salv-orlando has joined #openstack-oslo16:51
openstackgerritJoshua Harlow proposed openstack/tooz: Add mysql table support (if provided a database)  https://review.openstack.org/29017816:52
*** tesseract- has quit IRC16:55
*** cdent has quit IRC16:57
*** dims_ has joined #openstack-oslo16:58
*** dims has quit IRC16:59
*** browne has quit IRC17:00
*** rcernin has quit IRC17:01
*** e0ne has quit IRC17:05
openstackgerritMerged openstack/oslo.config: Replace deprecated LOG.warn with LOG.warning  https://review.openstack.org/29157517:05
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization  https://review.openstack.org/29171517:07
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization  https://review.openstack.org/29171517:08
*** dims_ has quit IRC17:08
*** salv-orlando has quit IRC17:09
*** suro-patz has joined #openstack-oslo17:12
*** dims has joined #openstack-oslo17:13
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.messaging: Fix Notification listener blocking behavior  https://review.openstack.org/29182417:16
*** sdague has quit IRC17:17
*** cdent has joined #openstack-oslo17:19
openstackgerritMehdi Abaakouk (sileht) proposed openstack/oslo.serialization: msgpack: fix datetime serialization  https://review.openstack.org/29171517:28
*** leakypipes has quit IRC17:30
*** devkulkarni has joined #openstack-oslo17:30
*** jaypipes has joined #openstack-oslo17:34
*** krotscheck has quit IRC17:34
*** pcaruana has joined #openstack-oslo17:35
*** krotscheck has joined #openstack-oslo17:37
*** ericksonsantos has quit IRC17:37
openstackgerritRonald Bradford proposed openstack/oslo.log: Corrected transposed AssertEqual(expected, actual)  https://review.openstack.org/28875617:38
*** vilobhmm11 has joined #openstack-oslo17:39
*** vilobhmm111 has joined #openstack-oslo17:42
*** browne has joined #openstack-oslo17:42
*** vilobhmm111 has quit IRC17:43
*** vilobhmm111 has joined #openstack-oslo17:43
*** vilobhmm11 has quit IRC17:44
*** mhickey_ has quit IRC17:44
openstackgerritMerged openstack/oslo.vmware: Should not raise Exception before connection close  https://review.openstack.org/28122217:45
*** vilobhmm11 has joined #openstack-oslo17:49
*** vilobhmm111 has quit IRC17:50
*** lucasagomes is now known as lucas-afk17:51
openstackgerritMehdi Abaakouk (sileht) proposed openstack/tooz: file: make python2 payload readable from python3  https://review.openstack.org/29183617:51
*** e0ne has joined #openstack-oslo17:56
*** vilobhmm11 has quit IRC17:59
*** vilobhmm11 has joined #openstack-oslo18:00
*** yamahata_ has quit IRC18:01
*** gcb_ has quit IRC18:02
*** dims_ has joined #openstack-oslo18:04
*** dims has quit IRC18:04
*** vilobhmm11 has quit IRC18:04
*** gcb_ has joined #openstack-oslo18:05
*** ihrachys has quit IRC18:06
*** mriedem has joined #openstack-oslo18:12
*** EinstCrazy has quit IRC18:13
*** dontrump has quit IRC18:13
*** shardy has quit IRC18:13
*** gcb_ has quit IRC18:15
*** gcb_ has joined #openstack-oslo18:19
*** devkulkarni has quit IRC18:26
*** permalac has quit IRC18:35
*** dtardivel has quit IRC18:38
*** MVenesio has quit IRC18:40
*** yamahata_ has joined #openstack-oslo18:41
*** rlrooster has quit IRC18:42
openstackgerritJoshua Harlow proposed openstack/tooz: Add mysql table support (if provided a database)  https://review.openstack.org/29017818:43
*** sputnik13 has joined #openstack-oslo18:43
openstackgerritDavanum Srinivas (dims) proposed openstack/oslo.config: Fix isinstance call  https://review.openstack.org/29185718:44
dims_zigo : can you try that? hopefully will see a better error?18:44
dims_zigo : ^^18:44
dims_dhellmann : ^^18:44
*** rlrooste_ has joined #openstack-oslo18:46
*** rlrooste_ is now known as rlrossit18:47
zigodims_: Will do after dinner, thanks!18:49
dhellmanndims_ : sheesh, who wrote this thing?18:51
dims_haha18:51
*** yassine__ has quit IRC18:52
lifelesshaypo: thats what it is for you, but it is not what it is.18:55
lifelesshaypo: it is a centralisation of the packaging related thing in openstack to avoid duplication, and some of those things are runtime, some are buildtime.18:55
*** vilobhmm11 has joined #openstack-oslo19:00
*** suro-patz has quit IRC19:02
*** e0ne_ has joined #openstack-oslo19:13
*** e0ne has quit IRC19:14
*** suro-patz has joined #openstack-oslo19:21
*** devkulkarni has joined #openstack-oslo19:22
*** amrith is now known as _amrith_19:38
*** e0ne_ has quit IRC19:40
rbradforkrotscheck, question about oslo.middleware.cors and its dependency on neutron?20:00
*** fhermeni has joined #openstack-oslo20:05
fhermenihello20:05
*** cdent_ has joined #openstack-oslo20:07
kevinbentonzzzeek: around for a quick question about the core commit event? (http://docs.sqlalchemy.org/en/latest/core/events.html#sqlalchemy.events.ConnectionEvents.commit)20:08
zzzeekkevinbenton: hey20:09
kevinbentonzzzeek: hey. if i have a subscriber to that just throw a random exception, will that rollback the commit?20:09
kevinbentonzzzeek: or do i need to call something specific on the connection passed in to trigger a rollback?20:09
*** cdent has quit IRC20:10
*** cdent_ is now known as cdent20:10
zzzeekkevinbenton: within a flush, an exception that's raised has kind of a nested effect20:10
zzzeekthe flush emits a ROLLBACK and rolls back the "nested" transaction that's local to the flush20:10
zzzeekbut the Session itself is in a more enclosing transaction, the application needs to rollback() that as well, explicitly20:11
zzzeekif anyone emits a rollback, there20:11
zzzeekthere's no commit() called.20:11
fhermeniharlowja_at_home: ping ?20:11
zzzeekkevinbenton: oh ok , if they raise in the event handler20:12
zzzeekummm...let me check20:12
kevinbentonzzzeek: right. to give some context, i have this kind of wonky test in neutron to simulate a failure to commit after IP allocation is inserted20:12
kevinbentonzzzeek: https://github.com/openstack/neutron/blob/master/neutron/tests/unit/plugins/ml2/test_plugin.py#L791-L82920:12
zzzeekand thats the conection-level event not the ORM one, OK20:12
*** nikhil_k has quit IRC20:12
zzzeekkevinbenton: the commit connection event is called before the DB commit is called20:13
zzzeekso if you raise, it wont commit20:13
zzzeekbut, not sure if that will emit a rollback20:13
zzzeekin core it's not automatic20:14
kevinbentonzzzeek: ok. so the strange behavior i'm seeing is that there still seem to be objects in the session after that exception goes all of the way up to the api layer and starts the proces over20:14
zzzeekkevinbenton: well "objects in the session" can mean a lot of things20:14
kevinbentonzzzeek: i suspected you would want real terminology :)20:14
zzzeekkevinbenton: can you make a proof case20:15
kevinbentonFlushError: New instance <IPAllocation at 0x7fd98001ce50> with identity key (<class 'neutron.db.models_v2.IPAllocation'>, (u'10.0.0.2', u'70dfccfd-f18a-423b-9323-095a38b301a9', u'4e0d6054-6f90-450d-87d6-fb86fa194a91')) conflicts with persistent instance <IPAllocation at 0x7fd9805aa910>20:15
zzzeekcode > terminology20:15
kevinbentonzzzeek: so the ip allocation object that was created from the first time stuck around20:15
kevinbentonzzzeek: i'm not sure if its because a reference to it leaked somewhere else in the code, or if its just that i'm not triggering a db failure in the way i think20:16
zzzeekok well the objects in the session are distinct from the transaction to a large degree20:16
zzzeekthat's a pending instance20:17
zzzeeka pending instance should be kicked out if you call session.rollback() but otherwise it will still be sitting there20:17
kevinbentonzzzeek: the persistent one, right?20:17
zzzeekthe error is because ther's both at the same time20:18
kevinbentonzzzeek: right20:18
zzzeekkevinbenton: i'd need to see the specific sequence of calls to really know what's happening20:18
kevinbentonzzzeek: so an explicit call to rollback might do the trick then?20:18
zzzeekkevinbenton: yes20:18
kevinbentonzzzeek: ok. let me mess around a bit and then i'll try to distill it down if i can't straighten it out20:19
zzzeekkevinbenton: ther's ORM level commit events you ight want to stick w/ those20:19
kevinbentonzzzeek: IIRC i had an issue using those, but i can't remember why now20:19
kevinbentonzzzeek: i'll try a switch to those first20:19
zzzeekkevinbenton: that's possilre, thorwing an exception in the event handler might not do what you want20:19
*** ihrachys has joined #openstack-oslo20:21
*** vilobhmm11 has quit IRC20:26
*** vilobhmm11 has joined #openstack-oslo20:27
*** vilobhmm11 has quit IRC20:27
dhellmanndims_ : https://review.openstack.org/#/q/I6a8c7d44b9db9325003ff2fdb667b0ced7739e96,n,z20:34
*** MVenesio has joined #openstack-oslo20:35
dims_dhellmann : ouch ok20:36
dhellmanndims_ : I'm looking at the oslo.config docs now to see how to make the name rule more clear20:36
dims_thanks dhellmann20:38
openstackgerritDoug Hellmann proposed openstack/oslo.config: improve documentation about registering entry points for config generator  https://review.openstack.org/29190420:41
dhellmanndims_ : ^^20:41
dims_+2 dhellmann20:45
*** cdent has quit IRC20:48
*** cdent has joined #openstack-oslo20:49
krotscheckdhellmann: Checking.20:52
*** cdent has quit IRC20:54
krotscheckrbradfor, dhellmann: Hrm. Ok, I'll go ahead and update the patches that haven't landed yet first, the move on to the ones y'all haven't covered yet20:55
dhellmannkrotscheck : I grepped for the cors middleware in openstack/* and found 1020:55
dhellmanndo you have others?20:55
krotscheckdhellmann: There should be 2220:55
dhellmannif so, please use the same topic name so we can track them together20:56
dhellmannkrotscheck : ok, I'm only finding 14 that even set oslo.config.opts.defaults20:56
krotscheckdhellmann: https://review.openstack.org/#/q/branch:master+topic:bug/155183620:56
dhellmannah, some haven't merged20:57
krotscheckTHere's 20 there. Ironic does its own thing. Barbican, trove, and designate don't use config gen.20:57
krotscheckCloudkitty hasn't merged it yet because they havent' released liberty yet.20:57
*** itisha has quit IRC20:59
*** vilobhmm11 has joined #openstack-oslo21:01
*** vilobhmm11 has quit IRC21:01
*** vilobhmm11 has joined #openstack-oslo21:02
*** vilobhmm11 has quit IRC21:02
krotscheckdhellmann: Ok, so just to be _absolutely_ clear.21:02
dhellmannkrotscheck : ah, some use oslo.middleware not just oslo.middleware.cors21:03
krotscheckdhellmann: The name of the hook is the name of the config file?21:03
krotscheckdhellmann: And it's only supposed to be _one_ function?21:03
krotscheckInstead of one per entry in the genconfig config?21:03
dhellmannkrotscheck : the name of the hook needs to be unique. it should be named based on the application, or some entry point in oslo.config.opts defined by the application.21:03
dhellmannso, I just fixed nova by renaming it from oslo.middleware to nova.api21:04
*** vilobhmm11 has joined #openstack-oslo21:04
dhellmannand yeah, the idea was that there would be one function used to override the defaults emitted for a sample config for each application within a project (nova api, conductor, etc.)21:04
dhellmannand each of those application functions might call a bunch of other functions in the libraries that it needs to initialize21:05
*** sigmavirus24 is now known as sigmavirus24_awa21:05
krotscheckoookaaaaay21:05
* krotscheck may be a little grump that he has to do _het another_ set of patches for cors.21:06
krotscheck*yet21:06
zigodims_: So, your patch fixed the issue (ie: the files are now correctly generated), however, I still get some warnings when running oslo-config-generator: http://paste.openstack.org/show/490258/21:06
dhellmannthe problem is, with all of the services installed together, the config generator sees all of the functions registered under oslo.config.opts.defaults, and then it loads the ones with the names that match the entries in the current config file, which means it loads foo from whereever it lives, and if it lives in the wrong app, you're crossing the streams21:06
zigodims_: This is version 2.1.0 of keystoneauth21:06
dhellmannkrotscheck : I think I've fixed all of the ones that already had the bad value land21:06
*** vilobhmm11 has quit IRC21:06
*** gordc has quit IRC21:06
zigodims_: Should I try upgrading to version 2.3.0 ?21:07
zigodims_: At least, I can go further in my Tempest CI run, that's already super useful... :P21:07
zigoI'll ignore the warnings until you can reply to me if I *must* upgrade keystoneauth now, or if this can wait.21:08
krotscheckdhellmann: Much appreciated.21:08
zigodims_: I'd also suggest releasing a new oslo.config with this patch of yours. As always, I'm the one and only person in the whole community to test config files in projects! :D21:09
zigodims_: Whatever happens, *thanks so much* !!! :)21:10
*** suro-patz has joined #openstack-oslo21:12
rbradforzigo, re your pastebin.  I was looking into a problem about option names in keystoneauth1, and I found out for example, it's user-id (that's dash). See also domain-id http://git.openstack.org/cgit/openstack/keystoneauth/tree/keystoneauth1/loading/identity.py#n77  Wonder if related in any way?21:16
dims_zigo : in general, my advice is to pick up versions from upper-constraints.txt as those are the ones thoroughly tested21:17
krotscheckdhellmann: Ok, I've updated the patches still in-flight. Are there any remaining ones that have already landed that need to be updated?21:17
dims_zigo : y, will figure out when we can ship this patch in generator21:17
*** kgiusti has quit IRC21:20
*** sigmavirus24_awa is now known as sigmavirus2421:22
dhellmannkrotscheck : I think I've caught all of the variations, but you could double check the list against https://review.openstack.org/#/q/topic:fix-config-default21:23
zigodims_: Yeah, that's what I've done, ie I took a snapshot of the global-requirements.txt and upper-constraints.txt when Mitaka b3 was out.21:23
krotscheckdhellmann: WIlldo.21:23
dims_zigo : ack, we have been holding the line on g-c and u-c for a week or so now. it may be a good idea to do a diff. i think we pushed some libs out21:24
zigodims_: I usually make it all work for b3, make my Tempest CI to work, and *THEN* upgrade components as much as possible, until the final release.21:25
dims_zigo sounds like a good plan21:25
krotscheckdhellmann: You missed mistral. On it.21:26
zigodims_: FYI, that's how I found out: https://mitaka-jessie.pkgs.mirantis.com/job/openstack-tempest-ci/33/console21:26
zigo:)21:26
dhellmannkrotscheck : written but not submitted: https://review.openstack.org/29191721:26
krotscheckDOH21:26
krotscheck:)21:26
krotscheckbeat me to it.21:27
zigodims_: I got a new server with 32 GB of RAM just to do these tempest tests. That's a way more efficient than running on my good old 4GB RAM Xen VM which was even failing tests because of the lack of RAM.21:27
zigo:)21:27
dhellmannthe problem with doing 15 patches quickly...21:27
krotscheckdhellmann: No kididng21:27
krotscheckdhellmann: Ok, I think we're covered at this point.21:27
zigodims_: I run Debian Live there (booted over network), then I just ssh into it, and install an all-in-one OpenStack, on which I run tempest.21:27
dhellmannkrotscheck : thanks for double checking, I would have missed a bunch if I didn't realize there were variations on the theme21:27
zigodims_: So, everything runs in a RAMdisk.21:27
zigoFun...21:27
krotscheckThe only question I have is wehther I should try to land cors in some of the newer API's like freezer.21:27
zigoReinstall everything? Just reset the server ... :P21:27
zigo1min 30, it's rebooted, and ready to reinstall OpenStack.21:28
dhellmannkrotscheck : at this point, if it isn't in it's a risk to making the RC1 tags next week, so I think those will have to wait for newton to open up21:28
krotscheckdhellmann: No worries, thanks for jumping in and doing those patches while I was covered in diapers.21:28
*** nikhil_k has joined #openstack-oslo21:28
* dhellmann tries to get that image out of his head21:28
krotscheckdhellmann: It's the new trend in engineer couture.21:28
dhellmannwe just have hipster food courts down here in my area21:29
krotscheckdhellmann: branded tshirt and jeans are out, cloth diapers and baby drool are in.21:29
dhellmannpass21:29
dhellmannbut, you know, enjoy :-)21:29
krotscheckOk, I'm off to deal with mr. fussy21:29
krotscheckping me if something else comes up.21:29
dhellmannI'm taking off shortly, too, so we'll see how things look monday21:29
*** MVenesio has quit IRC21:33
*** mriedem has quit IRC21:36
openstackgerritMiguel Angel Ajo proposed openstack/oslo.versionedobjects: Add BaseEnumField valid_values introspection  https://review.openstack.org/28710621:41
*** vilobhmm11 has joined #openstack-oslo21:57
*** fhermeni has quit IRC21:57
*** e0ne has joined #openstack-oslo21:59
*** suro-patz has quit IRC22:01
*** suro-patz has joined #openstack-oslo22:01
kevinbentonzzzeek: intestingly when i attach the debugger that persistent instance goes away :/22:02
*** jaypipes has quit IRC22:02
zzzeekkevinbenton: OK perhaps a gc.collect() would do it22:02
zzzeekkevinbenton: sometimes instances are associated with a stack trace and not being GC'ed22:03
kevinbentonzzzeek: ah. that makes sense22:03
kevinbentonzzzeek: because when i tried to convert it to a merge just to see if they would play nice, it would complain about it being deleted22:03
zzzeekkevinbenton: make a strong reference to it, if possible22:04
kevinbentonzzzeek: well i actually want it to be dead22:04
kevinbentonzzzeek: i was confused about why it was still around22:04
zzzeekok22:04
*** e0ne has quit IRC22:04
zzzeekwell strogn refernce then expunge() it, perhaps22:04
kevinbentonzzzeek: this was on a complete failure and start over scenario22:04
zzzeekright22:04
zzzeekif the session is rolled back it should be out22:04
kevinbentonzzzeek: is there a known reference to that issue with garbage collection? just so i can put a pointer to something in my commit22:05
zzzeekkevinbenton: again since i dont see what you're doing i cant really make any observations22:09
zzzeekthere's all kinds of surprises with garbage collection in general22:09
kevinbentonzzzeek: i see. it's just a side effect of the session haveing a weakref to it, not anything in particular with how sqlalchemy handles gc22:10
kevinbenton?22:10
zzzeekkevinbenton: there sohuld always be a path such that whether GC happened or not is not getting in your way22:11
zzzeekkevinbenton: e.g. if you have a Session and you've done a rollback, anything that's not supposed to be there would be pushed out22:11
*** rlrossit has quit IRC22:13
kevinbentonzzzeek: ack. let me see if i can find out the root cause. may be an exception handler grabbing onto something22:13
kevinbentonzzzeek: thanks for your help22:13
*** melwitt has quit IRC22:18
*** melwitt has joined #openstack-oslo22:18
*** regXboi has quit IRC22:21
openstackgerritMerged openstack/oslo.config: Fix isinstance call  https://review.openstack.org/29185722:31
*** melwitt has quit IRC22:36
*** melwitt has joined #openstack-oslo22:36
*** andymaier has joined #openstack-oslo22:37
*** david-lyle has quit IRC22:37
*** andymaier has quit IRC22:37
*** devkulkarni has quit IRC22:40
openstackgerritMerged openstack/oslo.config: improve documentation about registering entry points for config generator  https://review.openstack.org/29190422:43
*** dimtruck is now known as zz_dimtruck22:46
*** rcernin has joined #openstack-oslo22:47
*** ihrachys has quit IRC22:53
*** amotoki has quit IRC23:04
*** rcernin has quit IRC23:06
*** rcernin has joined #openstack-oslo23:08
*** sigmavirus24 is now known as sigmavirus24_awa23:22
*** rcernin has quit IRC23:31
*** ndipanov has quit IRC23:38
*** vilobhmm11 has quit IRC23:46

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!