*** superdan is now known as dansmith | 00:08 | |
*** amrith is now known as _amrith_ | 00:12 | |
*** amotoki has joined #openstack-oslo | 00:22 | |
*** _amrith_ is now known as amrith | 00:23 | |
*** amotoki has quit IRC | 00:27 | |
*** suro-patz has quit IRC | 00:29 | |
*** yamamoto has joined #openstack-oslo | 00:56 | |
*** zz_dimtruck is now known as dimtruck | 01:13 | |
*** EinstCrazy has joined #openstack-oslo | 01:19 | |
*** dimtruck is now known as zz_dimtruck | 01:22 | |
*** amotoki has joined #openstack-oslo | 01:23 | |
*** amotoki has quit IRC | 01:28 | |
*** yamamoto has quit IRC | 01:31 | |
*** EinstCra_ has joined #openstack-oslo | 01:48 | |
*** EinstCrazy has quit IRC | 01:50 | |
openstackgerrit | Merged openstack-dev/pbr: Correct the indentation in the classifiers example https://review.openstack.org/294500 | 01:53 |
---|---|---|
*** EinstCrazy has joined #openstack-oslo | 02:00 | |
*** EinstCra_ has quit IRC | 02:03 | |
*** zz_dimtruck is now known as dimtruck | 02:19 | |
*** amotoki has joined #openstack-oslo | 02:24 | |
*** amotoki has quit IRC | 02:28 | |
*** yamamoto has joined #openstack-oslo | 02:32 | |
*** yamamoto has quit IRC | 02:41 | |
*** dimtruck is now known as zz_dimtruck | 02:51 | |
*** amrith is now known as _amrith_ | 02:59 | |
*** zz_dimtruck is now known as dimtruck | 03:19 | |
*** amotoki has joined #openstack-oslo | 03:25 | |
*** amotoki has quit IRC | 03:29 | |
*** yamamoto has joined #openstack-oslo | 03:36 | |
*** suro-patz has joined #openstack-oslo | 03:52 | |
openstackgerrit | Joshua Harlow proposed openstack/tooz: coordination: expose a heartbeat loop methods (2) https://review.openstack.org/295075 | 03:58 |
openstackgerrit | Brian Stajkowski proposed openstack/oslo.config: Add Suggested Option https://review.openstack.org/295076 | 03:59 |
*** links has joined #openstack-oslo | 04:03 | |
*** doffm has quit IRC | 04:03 | |
openstackgerrit | Brian Stajkowski proposed openstack/oslo.config: Add Suggested Option https://review.openstack.org/294387 | 04:04 |
*** doffm has joined #openstack-oslo | 04:05 | |
*** yamamoto has quit IRC | 04:13 | |
*** dimtruck is now known as zz_dimtruck | 04:23 | |
*** amotoki has joined #openstack-oslo | 04:25 | |
*** amotoki has quit IRC | 04:30 | |
*** yamamoto has joined #openstack-oslo | 04:34 | |
*** yamamoto has quit IRC | 04:37 | |
*** suro-patz has quit IRC | 04:37 | |
*** yamamoto has joined #openstack-oslo | 04:40 | |
*** yamamoto has quit IRC | 04:42 | |
*** sputnik13 has joined #openstack-oslo | 04:56 | |
*** harlowja_at_home has quit IRC | 04:57 | |
*** EinstCra_ has joined #openstack-oslo | 04:57 | |
*** EinstCrazy has quit IRC | 04:59 | |
*** sputnik13 has quit IRC | 05:08 | |
*** _stowa has joined #openstack-oslo | 05:11 | |
*** barra204 has quit IRC | 05:13 | |
*** amotoki has joined #openstack-oslo | 05:26 | |
*** yamamoto has joined #openstack-oslo | 05:29 | |
*** amotoki has quit IRC | 05:31 | |
openstackgerrit | Angus Lees proposed openstack/oslo.privsep: Switch to msgpack for serialization https://review.openstack.org/295083 | 05:46 |
*** yamamoto has quit IRC | 05:52 | |
*** yamamoto has joined #openstack-oslo | 05:59 | |
*** pcaruana has quit IRC | 06:02 | |
*** suro-patz has joined #openstack-oslo | 06:13 | |
*** openstackgerrit has quit IRC | 06:17 | |
*** openstackgerrit_ is now known as openstackgerrit | 06:17 | |
*** openstackgerrit_ has joined #openstack-oslo | 06:18 | |
*** openstackgerrit_ is now known as openstackgerrit | 06:18 | |
*** openstackgerrit_ has joined #openstack-oslo | 06:19 | |
*** rcernin has joined #openstack-oslo | 06:20 | |
*** yamamoto has quit IRC | 06:22 | |
*** amotoki has joined #openstack-oslo | 06:27 | |
*** suro-patz has quit IRC | 06:30 | |
*** achanda has quit IRC | 06:31 | |
*** amotoki has quit IRC | 06:31 | |
*** achanda has joined #openstack-oslo | 06:34 | |
*** achanda has quit IRC | 06:36 | |
*** yamamoto has joined #openstack-oslo | 06:41 | |
*** nkrinner has joined #openstack-oslo | 06:44 | |
*** ihrachys has joined #openstack-oslo | 06:48 | |
*** itisha has quit IRC | 06:49 | |
*** ihrachys has quit IRC | 06:49 | |
openstackgerrit | Bhagyashri Shewale proposed openstack/oslo.db: Add new filter for DBDataError exception https://review.openstack.org/295096 | 07:13 |
*** amotoki has joined #openstack-oslo | 07:28 | |
*** amotoki has quit IRC | 07:32 | |
*** achanda has joined #openstack-oslo | 07:36 | |
*** achanda has quit IRC | 07:42 | |
*** ihrachys has joined #openstack-oslo | 07:42 | |
*** ihrachys has quit IRC | 07:42 | |
*** andymaier has joined #openstack-oslo | 07:44 | |
*** tesseract has joined #openstack-oslo | 07:50 | |
*** tesseract is now known as Guest9441 | 07:51 | |
*** dtardivel has joined #openstack-oslo | 07:57 | |
*** yamamoto has quit IRC | 08:01 | |
*** yamamoto has joined #openstack-oslo | 08:02 | |
*** yamamoto has quit IRC | 08:17 | |
*** amotoki has joined #openstack-oslo | 08:28 | |
*** amotoki has quit IRC | 08:33 | |
*** amotoki has joined #openstack-oslo | 08:35 | |
*** permalac has joined #openstack-oslo | 08:40 | |
*** ndipanov has joined #openstack-oslo | 08:46 | |
*** ozamiatin__ has joined #openstack-oslo | 08:46 | |
*** ndipanov has quit IRC | 08:51 | |
openstackgerrit | Ilya Tyaptin proposed openstack/oslo.messaging: Use only unique topics for the Kafka driver https://review.openstack.org/291178 | 08:55 |
*** ndipanov has joined #openstack-oslo | 08:57 | |
*** takedakn has joined #openstack-oslo | 09:00 | |
*** achanda has joined #openstack-oslo | 09:00 | |
*** achanda has quit IRC | 09:01 | |
*** shardy has joined #openstack-oslo | 09:02 | |
openstackgerrit | Ilya Tyaptin proposed openstack/oslo.messaging: [Kafka] Ensure a topics before consume messages https://review.openstack.org/295147 | 09:04 |
*** permalac has quit IRC | 09:05 | |
*** permalac has joined #openstack-oslo | 09:05 | |
*** shardy_ has joined #openstack-oslo | 09:06 | |
*** yamamoto has joined #openstack-oslo | 09:18 | |
*** pasquier-s has quit IRC | 09:22 | |
*** rpodolyaka has quit IRC | 09:23 | |
*** ozamiatin__ has quit IRC | 09:23 | |
*** rpodolyaka has joined #openstack-oslo | 09:24 | |
*** pasquier-s has joined #openstack-oslo | 09:25 | |
*** ozamiatin__ has joined #openstack-oslo | 09:25 | |
*** yamamoto has quit IRC | 09:25 | |
*** permalac has quit IRC | 09:26 | |
*** amotoki has quit IRC | 09:35 | |
*** ozamiatin__ has quit IRC | 09:36 | |
*** yassine has joined #openstack-oslo | 09:36 | |
*** yassine is now known as Guest62439 | 09:37 | |
*** e0ne has joined #openstack-oslo | 09:52 | |
*** sdague has joined #openstack-oslo | 09:54 | |
openstackgerrit | garyk proposed openstack/oslo.log: Enable log_method_call to work on static method https://review.openstack.org/295169 | 09:56 |
*** ozamiatin__ has joined #openstack-oslo | 09:57 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Refactoring consumer side https://review.openstack.org/283049 | 10:02 |
*** sputnik13 has joined #openstack-oslo | 10:14 | |
*** Guest62439 is now known as yass | 10:18 | |
*** EinstCra_ has quit IRC | 10:27 | |
*** cdent has joined #openstack-oslo | 10:31 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Refactoring consumer side https://review.openstack.org/283049 | 10:46 |
*** takedakn has quit IRC | 10:49 | |
*** dims has joined #openstack-oslo | 10:49 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Refactoring consumer side https://review.openstack.org/283049 | 10:51 |
*** yamahata has quit IRC | 10:51 | |
*** purplerbot has quit IRC | 10:51 | |
*** purplerbot has joined #openstack-oslo | 10:51 | |
*** purplerbot has quit IRC | 10:53 | |
*** purplerbot has joined #openstack-oslo | 10:53 | |
*** purplerbot has quit IRC | 10:54 | |
*** purplerbot has joined #openstack-oslo | 10:54 | |
*** yass has quit IRC | 10:59 | |
*** sputnik13 has quit IRC | 11:00 | |
*** yamamoto has joined #openstack-oslo | 11:01 | |
*** achanda has joined #openstack-oslo | 11:01 | |
*** achanda has quit IRC | 11:01 | |
*** yamamoto has quit IRC | 11:04 | |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Reduce number of connections https://review.openstack.org/287094 | 11:06 |
*** yamamoto has joined #openstack-oslo | 11:10 | |
*** ozamiatin__ has quit IRC | 11:12 | |
*** ihrachys has joined #openstack-oslo | 11:22 | |
*** shardy has quit IRC | 11:23 | |
*** shardy_ has quit IRC | 11:23 | |
*** edmondsw has joined #openstack-oslo | 11:27 | |
*** shardy has joined #openstack-oslo | 11:27 | |
*** jaypipes has joined #openstack-oslo | 11:28 | |
openstackgerrit | garyk proposed openstack/oslo.log: Enable log_method_call to work on static method https://review.openstack.org/295169 | 11:31 |
*** yamamoto has quit IRC | 11:39 | |
*** cdent has quit IRC | 11:44 | |
*** gordc has joined #openstack-oslo | 11:47 | |
openstackgerrit | Bhagyashri Shewale proposed openstack/oslo.db: Add new filter for DBDataError exception https://review.openstack.org/295096 | 11:51 |
*** takedakn has joined #openstack-oslo | 11:52 | |
*** yamamoto has joined #openstack-oslo | 11:56 | |
*** Kiall has quit IRC | 11:56 | |
*** tedross has joined #openstack-oslo | 11:57 | |
*** tedross has left #openstack-oslo | 11:58 | |
*** Kiall has joined #openstack-oslo | 11:59 | |
*** yamamoto has quit IRC | 12:02 | |
*** ozamiatin has joined #openstack-oslo | 12:03 | |
*** cdent has joined #openstack-oslo | 12:06 | |
openstackgerrit | Ilya Tyaptin proposed openstack/oslo.messaging: Use only unique topics for the Kafka driver https://review.openstack.org/291178 | 12:06 |
openstackgerrit | Merged openstack/oslo.messaging: [Kafka] Ensure a topics before consume messages https://review.openstack.org/295147 | 12:12 |
*** MVenesio has joined #openstack-oslo | 12:19 | |
*** _amrith_ is now known as amrith | 12:28 | |
*** jecarey_ has joined #openstack-oslo | 12:30 | |
*** EinstCrazy has joined #openstack-oslo | 12:30 | |
*** jecarey_ has quit IRC | 12:30 | |
*** jecarey has quit IRC | 12:33 | |
*** rlrossit has joined #openstack-oslo | 12:55 | |
*** mfranc213 has joined #openstack-oslo | 13:05 | |
*** yassine has joined #openstack-oslo | 13:07 | |
*** yassine is now known as Guest39784 | 13:08 | |
*** mriedem has joined #openstack-oslo | 13:13 | |
*** kgiusti has joined #openstack-oslo | 13:13 | |
*** yamamoto has joined #openstack-oslo | 13:18 | |
*** lucasagomes has quit IRC | 13:19 | |
*** lucasagomes has joined #openstack-oslo | 13:24 | |
*** links has quit IRC | 13:28 | |
*** lucasagomes is now known as lucas-hungry | 13:29 | |
*** permalac has joined #openstack-oslo | 13:34 | |
*** mfranc213 has quit IRC | 13:34 | |
*** dims_ has joined #openstack-oslo | 13:34 | |
*** dims has quit IRC | 13:36 | |
*** jdandrea has joined #openstack-oslo | 13:41 | |
kgiusti | flaper87: gnocchi seems offended by something I said | 13:44 |
kgiusti | flaper87: I've tried sending flowers and chocolates, no deal. | 13:44 |
*** cdent has quit IRC | 13:46 | |
*** cdent has joined #openstack-oslo | 13:48 | |
flaper87 | kgiusti: what have you done? | 13:49 |
* flaper87 facepalm | 13:49 | |
flaper87 | :P | 13:49 |
kgiusti | flaper87: caught red-handed patching oslo.messaging behind gnocchi's back. I said we were only friends, but... | 13:49 |
kgiusti | flaper87: crap - failed again. | 13:50 |
*** sigmavirus24_awa is now known as sigmavirus24 | 13:51 | |
kgiusti | flaper87: oh, wait - that was non-voting grenade-dsvm | 13:51 |
*** jecarey has joined #openstack-oslo | 14:03 | |
*** takedakn has quit IRC | 14:03 | |
*** pcaruana has joined #openstack-oslo | 14:05 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Support python3 in simulator.py https://review.openstack.org/295299 | 14:06 |
*** mtanino has joined #openstack-oslo | 14:08 | |
*** boris-42 has joined #openstack-oslo | 14:12 | |
*** lucas-hungry is now known as lucasagomes | 14:12 | |
*** alejandrito has joined #openstack-oslo | 14:18 | |
*** yamamoto has quit IRC | 14:23 | |
openstackgerrit | Merged openstack/oslo.messaging: [zmq] Refactoring consumer side https://review.openstack.org/283049 | 14:25 |
openstackgerrit | Merged openstack/oslo.messaging: Use only unique topics for the Kafka driver https://review.openstack.org/291178 | 14:25 |
dansmith | do any oslo people know about this? http://logs.openstack.org/58/294758/3/check/gate-nova-python34/4c00439/console.html.gz#_2016-03-18_22_15_28_248 | 14:28 |
dansmith | fails on py34 in the gate, not on py27 and seems to pass locally for people | 14:28 |
*** zz_dimtruck is now known as dimtruck | 14:33 | |
*** yamamoto has joined #openstack-oslo | 14:35 | |
rpodolyaka | dansmith: looking | 14:36 |
haypo | dansmith: i saw https://bugs.launchpad.net/nova/+bug/1558105 => https://review.openstack.org/#/c/294568/ | 14:36 |
openstack | Launchpad bug 1558105 in OpenStack Compute (nova) "In python3 test_fixtures.TestOSAPIFixture.test_responds_to_version stalls in epoll()" [Undecided,In progress] - Assigned to Chris Dent (cdent) | 14:36 |
patchbot | haypo: patch 294568 - nova - Blacklist TestOSAPIFixture.test_responds_to_versio... (MERGED) | 14:36 |
openstackgerrit | Dmitriy Ukhlov proposed openstack/oslo.messaging: Small fixes https://review.openstack.org/294916 | 14:36 |
haypo | dansmith: (fix merged) | 14:36 |
haypo | http://logs.openstack.org/58/294758/3/check/gate-nova-python34/4c00439/console.html.gz#_2016-03-18_22_15_28_248 takes forever to be downloaded :-p | 14:36 |
dansmith | haypo: you think that's why I'm getting a mismatch of arguments? | 14:36 |
haypo | dansmith: i didn't see your issue yet, firefox is downloaded :) | 14:37 |
haypo | TypeError: _flavor_create() takes 2 positional arguments but 3 were given | 14:37 |
dansmith | haypo: 'TypeError: _flavor_create() takes 2 positional arguments but 3 were given' | 14:37 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Support python3 in simulator.py https://review.openstack.org/295299 | 14:37 |
dansmith | it's on a db method using @api_context_manager.writer | 14:37 |
haypo | dansmith: the same test pass on py2? | 14:38 |
dansmith | haypo: yes | 14:38 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: [WIP] try python3 for functional test https://review.openstack.org/295325 | 14:39 |
haypo | dansmith's change: https://review.openstack.org/#/c/294758/ | 14:40 |
patchbot | haypo: patch 294758 - nova - Make Flavor create() and destroy() work against AP... | 14:40 |
dansmith | haypo: ....that's the one | 14:41 |
haypo | dansmith: maybe you should write @staticmethod after @db_api.api_context_manager.writer in https://review.openstack.org/#/c/294758/4/nova/objects/flavor.py | 14:42 |
patchbot | haypo: patch 294758 - nova - Make Flavor create() and destroy() work against AP... | 14:43 |
dansmith | haypo: that doesn't work | 14:43 |
dansmith | haypo: the db context manager fails if you do that (on py2 anyway) | 14:43 |
dansmith | ah, did something change this morning? now I'm getting this on all the patches below as well: https://jenkins03.openstack.org/job/gate-nova-python34-db/12/console | 14:44 |
alaski | dansmith: running the full test suite does make it fail locally, but running the one test doesn't | 14:44 |
dansmith | note that py2 works fine on the same patch: https://jenkins02.openstack.org/job/gate-nova-python27-db/10/console | 14:44 |
dansmith | alaski: ...really? | 14:44 |
dansmith | alaski: my py34 local run never finished, so.. | 14:44 |
alaski | dansmith: you need https://review.openstack.org/#/c/294568/1 | 14:45 |
patchbot | alaski: patch 294568 - nova - Blacklist TestOSAPIFixture.test_responds_to_versio... (MERGED) | 14:45 |
dansmith | I thought I had it, but maybe not | 14:45 |
*** rpodolyaka has left #openstack-oslo | 14:47 | |
*** yamamoto has quit IRC | 14:48 | |
dims_ | flaper87 : kgiusti : how much performance testing has the QPid/Proton + pyngus driver gone through? (i have not tried it at all) | 14:49 |
dims_ | flaper87 : kgiusti : viable replacement for rabbitmq? (as default) | 14:50 |
*** achanda has joined #openstack-oslo | 14:50 | |
haypo | alaski: ah, that's the one i mentioned before | 14:50 |
kgiusti | dims_: been using the simulator tool to verify patches don't affect performance | 14:50 |
alaski | haypo: yeah. it just allows the tests to finish in a reasonable timeframe. But doesn't help with the issue dansmith is asking about | 14:50 |
kgiusti | dims_: using that as a simplistic benchmark, the performance is on par if not a bit better. | 14:50 |
kgiusti | dims_: amqp better, that is | 14:51 |
alaski | dansmith: got a test run with args being printed, it's definitely passing in 'self'. | 14:51 |
dims_ | kgiusti : are there any TODO(s) around say HA, persistence (notifications?), failover? | 14:52 |
kgiusti | dims_: as far a 'replacement', amqp is missing notification pool feature at this time so that would impact replacement | 14:52 |
alaski | dansmith: http://pastebin.com/UZrZ6xu8 | 14:52 |
dansmith | alaski: so, it seems to me that something must have changed, because the patches at the bottom of the queue were passing py34 last week, now the jobs are called "py34-unit-db" or something, and they are all failing now | 14:52 |
dims_ | kgiusti : logged as a bug? | 14:53 |
kgiusti | dims_: yup, on launchpad: https://bugs.launchpad.net/oslo.messaging/+bug/1434538 | 14:53 |
openstack | Launchpad bug 1434538 in oslo.messaging "AMQP 1.0 driver does not support notification pools" [Undecided,Triaged] - Assigned to Ken Giusti (kgiusti) | 14:54 |
*** links has joined #openstack-oslo | 14:54 | |
dansmith | alaski: well, actually maybe the timeout bug was just covering up noticing it | 14:54 |
dansmith | haypo: but still, there must be some py3 detail we're overlooking here right? | 14:54 |
dims_ | kgiusti : thanks! | 14:54 |
kgiusti | dims_: the catch for that one is the solution would have to be broker-specific since there is no 'in-band' way of creating a shared subscription. | 14:55 |
dims_ | kgiusti : needed by say ceilometer? | 14:55 |
kgiusti | dims_: that's my understanding, yes. Again, not impossible - we could fast track support for qpidd if there is a need. Dispatch router, ActiveMQ would take some research. | 14:57 |
dansmith | alaski: super weird that it doesn't happen if you run the test on its own, right? | 14:57 |
dims_ | kgiusti : ack, trying to compare options we have... zmq, pika, kafka etc... | 14:58 |
alaski | dansmith: yeah, that's the strangest thing here. makes it impossible to trace easily. I'm wondering if something is getting permanently mocked/modified in the test runs | 14:58 |
dansmith | alaski: that's what is happening, because check this out: | 14:59 |
dansmith | alaski: http://logs.openstack.org/13/294313/1/check/gate-nova-python34/e17ee80/console.html.gz#_2016-03-17_23_08_18_822 | 14:59 |
dansmith | alaski: that _get_projects_from_db() method only exists in the test tree | 14:59 |
dansmith | ah | 14:59 |
dansmith | using self.stub_out | 14:59 |
alaski | dansmith: https://review.openstack.org/#/c/295318/ btw | 15:00 |
patchbot | alaski: patch 295318 - nova - Replace topic with topics for messaging.Notifier | 15:00 |
dansmith | alaski: got it | 15:00 |
dansmith | alaski: actually, I lied, that method does exist outside the test tree, but grep doesn't show it unless you ... include the rest of nova :D | 15:02 |
alaski | heh | 15:02 |
*** links has quit IRC | 15:02 | |
*** yamamoto has joined #openstack-oslo | 15:08 | |
*** BAKfr has quit IRC | 15:09 | |
*** yamamoto has quit IRC | 15:09 | |
*** yamamoto has joined #openstack-oslo | 15:10 | |
*** yamamoto has quit IRC | 15:10 | |
*** yamahata has joined #openstack-oslo | 15:11 | |
dansmith | alaski: haypo: so calling MyClass.foo() instead of self.foo() seems to make it better.. surely seems like some py3 detail I'm missing? | 15:15 |
*** fesp has joined #openstack-oslo | 15:17 | |
*** EinstCrazy has quit IRC | 15:18 | |
*** BAKfr has joined #openstack-oslo | 15:18 | |
alaski | dansmith: very odd | 15:18 |
*** achanda has quit IRC | 15:19 | |
*** harlowja_at_home has joined #openstack-oslo | 15:26 | |
*** EinstCrazy has joined #openstack-oslo | 15:26 | |
haypo | dansmith: bounded class methods don't exist anymore in python 3. they are now regular functions | 15:27 |
haypo | dansmith: but MyClass().foo is still a bounded method | 15:27 |
dims_ | hmm, hope our new PTL wakes up in time for the meeting :) | 15:28 |
dims_ | harlowja_at_home : ^^ | 15:28 |
harlowja_at_home | lol | 15:28 |
harlowja_at_home | sup | 15:28 |
dims_ | just checking :) | 15:28 |
dansmith | haypo: okay I guess that explains why making it a classmethod helps, but that's not really a solution | 15:28 |
harlowja_at_home | am i PTL yet, or is that in a few weeks, idk, lol | 15:28 |
dansmith | haypo: is there something in that decorator that is doing a wrong thing in py3? | 15:28 |
dims_ | harlowja_at_home : why wait? :) | 15:29 |
harlowja_at_home | :-P | 15:29 |
haypo | dansmith: see http://paste.openstack.org/show/491298/ | 15:29 |
dansmith | haypo: yeah, I get that | 15:33 |
*** EinstCrazy has quit IRC | 15:33 | |
dansmith | haypo: not sure how that affects staticmethod, nor how it affects the path forward here | 15:33 |
dansmith | haypo: I would have liked for this to be not a staticmethod, but the oslo_db context manager doesn't allow that either, because it assumes context is the first parameter | 15:33 |
alaski | dansmith: https://review.openstack.org/#/c/294283/ | 15:34 |
patchbot | alaski: patch 294283 - oslo.db - Let enginefacade._TransactionContextManager look f... | 15:34 |
dansmith | alaski: sigh | 15:35 |
alaski | yeah | 15:35 |
dims_ | +2A on that one dansmith and alaski | 15:37 |
*** yamamoto has joined #openstack-oslo | 15:37 | |
dansmith | dims_: thanks, but in order to use this we need a oslo_db release, requirements bump, etc, etc right? | 15:37 |
dims_ | dansmith : yep | 15:37 |
dansmith | I still don't understand why this is broken under py3 | 15:38 |
dansmith | making these non-static is cool and all, but it's still weirdly broken, IMHO | 15:38 |
haypo | alaski: you can write ... in ('self', 'cls'), but your code is fine ;) | 15:38 |
alaski | haypo: ah yeah. should have gone that way | 15:40 |
dansmith | testing on py3, staticmethod seems to behave the same way I would expect, no self parameter first | 15:40 |
*** yamahata has quit IRC | 15:41 | |
*** yamamoto has quit IRC | 15:41 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Add a py34 functional test for rabbit https://review.openstack.org/295363 | 15:41 |
harlowja_at_home | jd__, sooo maybe something in the middle between https://review.openstack.org/#/c/295075/ and https://review.openstack.org/#/c/293894/ ? | 15:42 |
patchbot | harlowja_at_home: patch 295075 - tooz - coordination: expose a heartbeat loop methods (2) | 15:42 |
patchbot | harlowja_at_home: patch 293894 - tooz - coordination: expose a heartbeat loop methods | 15:42 |
*** yamamoto has joined #openstack-oslo | 15:42 | |
harlowja_at_home | jd__, ummm where are u, on a train that is broken? | 15:44 |
harlowja_at_home | lol | 15:44 |
dansmith | haypo: this is how it breaks if you reverse the staticmethod and db decorators: http://pastebin.com/8T79XrJM | 15:46 |
*** alejandrito has quit IRC | 15:47 | |
*** nkrinner has quit IRC | 15:48 | |
*** alejandrito has joined #openstack-oslo | 15:49 | |
*** fesp has quit IRC | 15:50 | |
*** rpodolyaka has joined #openstack-oslo | 15:50 | |
*** sputnik13 has joined #openstack-oslo | 15:53 | |
*** yamamoto has quit IRC | 15:56 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Always set all socket timeouts https://review.openstack.org/294074 | 15:56 |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Add a py34 functional test for rabbit https://review.openstack.org/295363 | 15:56 |
harlowja_at_home | jd__, https://twitter.com/juldanjou/status/711901686491652096 wtf, lol | 15:57 |
*** alejandrito has quit IRC | 15:57 | |
*** sputnik13 has quit IRC | 15:57 | |
*** alejandrito has joined #openstack-oslo | 15:59 | |
*** rcernin has quit IRC | 15:59 | |
harlowja_at_home | 1 minute to some meeting somewhere, lol | 15:59 |
harlowja_at_home | *in openstack-meeting-alt | 15:59 |
harlowja_at_home | dims_, shall i run it or u ? :-P | 16:00 |
dims_ | please go for it harlowja_at_home | 16:00 |
harlowja_at_home | k | 16:00 |
dims_ | harlowja_at_home : cheat sheet https://etherpad.openstack.org/p/oslo-meeting-agenda | 16:00 |
*** yamamoto has joined #openstack-oslo | 16:00 | |
*** browne has joined #openstack-oslo | 16:01 | |
harlowja_at_home | nice, that's a little different than the txt file on my computer, ha | 16:01 |
jd__ | harlowja_at_home: now i'm at a train station | 16:07 |
openstackgerrit | Merged openstack/oslo.messaging: Do not leak Listeners on failover https://review.openstack.org/288554 | 16:07 |
jd__ | maybe I'll be home by the end of the day | 16:08 |
*** yamamoto has quit IRC | 16:08 | |
*** yamahata has joined #openstack-oslo | 16:09 | |
*** itisha has joined #openstack-oslo | 16:12 | |
*** thingee has left #openstack-oslo | 16:17 | |
*** yamamoto has joined #openstack-oslo | 16:24 | |
*** pcaruana has quit IRC | 16:25 | |
*** yamamoto has quit IRC | 16:28 | |
*** Guest9441 has quit IRC | 16:30 | |
openstackgerrit | Merged openstack/oslo.db: Let enginefacade._TransactionContextManager look for context https://review.openstack.org/294283 | 16:33 |
harlowja_at_home | jd__, lol | 16:40 |
harlowja_at_home | get some beef cuts at least | 16:40 |
harlowja_at_home | lol | 16:40 |
haypo | harlowja_at_home: lol | 16:43 |
haypo | (i read the story about the train butcher) | 16:43 |
*** ihrachys has quit IRC | 16:47 | |
*** achanda has joined #openstack-oslo | 16:49 | |
*** mriedem is now known as mriedem_lunch | 16:51 | |
dims_ | haypo you mean jd__ 's train :) | 16:53 |
harlowja_at_home | jd__, aka, the train butcher | 16:54 |
*** purplerbot has quit IRC | 16:55 | |
*** Guest39784 has quit IRC | 16:55 | |
sileht | amrith, harlowja_at_home about credentials for oslo.messaging that already exists via transport.get_transport(conf, url=rabbit://foo:bar@host/vhost) | 16:55 |
*** purplerbot has joined #openstack-oslo | 16:55 | |
*** purplerbot has quit IRC | 16:55 | |
*** purplerbot has joined #openstack-oslo | 16:56 | |
*** achanda has quit IRC | 16:57 | |
harlowja_at_home | thx sileht | 16:57 |
harlowja_at_home | brb, gotta run over to home depot | 16:59 |
haypo | harlowja_at_home: my crazy contrib to the wiki page, a moose :-) https://wiki.openstack.org/wiki/Oslo | 16:59 |
harlowja_at_home | lol | 17:00 |
harlowja_at_home | haypo, thx | 17:00 |
harlowja_at_home | i'll add some more in a little | 17:00 |
*** amrith is now known as _amrith_ | 17:02 | |
*** cdent has quit IRC | 17:03 | |
*** sputnik13 has joined #openstack-oslo | 17:11 | |
*** ihrachys has joined #openstack-oslo | 17:12 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Support python3 in simulator.py https://review.openstack.org/295299 | 17:13 |
*** bnemec has quit IRC | 17:17 | |
*** e0ne has quit IRC | 17:21 | |
*** cdent has joined #openstack-oslo | 17:27 | |
*** yamamoto has joined #openstack-oslo | 17:29 | |
*** yamamoto has quit IRC | 17:35 | |
*** yamamoto has joined #openstack-oslo | 17:36 | |
*** yamamoto has quit IRC | 17:37 | |
*** gonzalo2kx has joined #openstack-oslo | 17:42 | |
*** dimtruck is now known as zz_dimtruck | 17:44 | |
*** gonzalo2kx has left #openstack-oslo | 17:49 | |
*** bnemec has joined #openstack-oslo | 17:50 | |
*** achanda has joined #openstack-oslo | 17:58 | |
*** yamamoto has joined #openstack-oslo | 17:59 | |
*** lucasagomes is now known as lucas-dinner | 17:59 | |
*** salv-orlando has joined #openstack-oslo | 18:02 | |
*** sputnik13 has quit IRC | 18:10 | |
*** yamamoto has quit IRC | 18:13 | |
dansmith | dims_: so I assume we can't get that oslo.db change available to nova for a couple weeks because of freeze right? | 18:21 |
*** achanda has quit IRC | 18:24 | |
*** sputnik13 has joined #openstack-oslo | 18:29 | |
*** sputnik13 has quit IRC | 18:30 | |
*** sputnik13 has joined #openstack-oslo | 18:31 | |
*** achanda has joined #openstack-oslo | 18:35 | |
dims_ | dansmith : yep | 18:36 |
*** _amrith_ is now known as amrith | 18:36 | |
dansmith | dims_: that's ...unfortunate | 18:37 |
dansmith | dims_: I'd still like to know why this is only a problem on py3 | 18:37 |
dims_ | dansmith : you are talking about this one right? https://review.openstack.org/#/c/294283/2/oslo_db/sqlalchemy/enginefacade.py | 18:41 |
patchbot | dims_: patch 294283 - oslo.db - Let enginefacade._TransactionContextManager look f... (MERGED) | 18:41 |
dansmith | dims_: that's a workaround | 18:41 |
dansmith | dims_: the issue is that apparently that contextmanager thing breaks only on py3 if you're applying it to staticmethods | 18:42 |
dansmith | and I don't understand why | 18:42 |
dansmith | that patch would let me make them not static and hopefully behave the same under py2 and py3, | 18:42 |
dansmith | but that's not really the solution, IMHO | 18:42 |
dansmith | dims_: http://logs.openstack.org/58/294758/2/check/gate-nova-python34/3f33331/console.html.gz#_2016-03-18_20_04_26_461 | 18:43 |
dims_ | i was just about to ask you that :) | 18:43 |
dansmith | dims_: so I guess I have to move all of these out to be not on the object to make progress without waiting for the oslo_db thing, | 18:46 |
dansmith | but the weird py3 interaction seems strange to me | 18:47 |
dims_ | dansmith : haypo mentioned the difference between py2x and py3x - http://eavesdrop.openstack.org/irclogs/%23openstack-oslo/%23openstack-oslo.2016-03-21.log.html#t2016-03-21T15:27:32 that causes this problem | 18:53 |
dansmith | dims_: on classmethods | 18:54 |
dansmith | dims_: which explains what I said which was that making these calls by class does change it | 18:54 |
dansmith | dims_: staticmethods don't seem to behave any differently, and converting to call these by class isn't an option | 18:54 |
alaski | what confuses the issue further is that running the test on its own passes. It's not an obvious py2/py3 difference | 18:55 |
dansmith | yeah | 18:55 |
*** e0ne has joined #openstack-oslo | 18:55 | |
dansmith | alaski: but you printed out something inside the actual method to see that it's not running a stale mock right? | 18:55 |
alaski | I had a stack trace at one point, the line numbers and method calls didn't indicate a mock | 18:56 |
dims_ | alaski : dansmith : last i remember running into this problem, i was reading about it here - http://stackoverflow.com/questions/3589311/get-defining-class-of-unbound-method-object-in-python-3 - especially examples | 18:56 |
dims_ | alaski : y that would be weird | 18:56 |
*** zz_dimtruck is now known as dimtruck | 18:56 | |
dims_ | if it is a py2/3 difference it should fail always | 18:56 |
alaski | it always fails on a full test run for py34, and never on py27 | 18:57 |
dims_ | oh and here http://www.resolvinghere.com/sof/8408910.shtml | 18:57 |
dansmith | dims_: are you saying there's something I'm doing wrong? because if so, just tell me what it is and I'll change :) | 18:57 |
dims_ | dansmith : no, i mean we have to be able to support the existing way (in py27) somehow in py34 even though internals have changed somewhat | 18:58 |
dims_ | we should definitely track this as a separate bug | 18:59 |
dansmith | alaski: so I guess to avoid being blocked on this I will move these all out to module-level functions and roll | 18:59 |
dansmith | alaski: it will mean we can't easily override this class if we wanted to | 18:59 |
dansmith | but we can fold it back in later | 18:59 |
alaski | yeah, once the olso.db bug fix is available in nova | 19:00 |
dansmith | that will be weeks I thik | 19:00 |
dims_ | dansmith : unfreeze is as soon as swift ships. by end of this week. so we can do a oslo.db release next week and a g-r change | 19:01 |
dims_ | best case scenario | 19:01 |
dansmith | dims_: yeah | 19:01 |
alaski | dansmith: I've been running the tests for about two hours now with --analyze-isolation and it hasn't converged on a problematic set of tests | 19:02 |
dansmith | alaski: me too and neither I | 19:02 |
dansmith | ohg | 19:04 |
dansmith | dims_: can I use this as a context manager and get a session? | 19:04 |
dansmith | with api_context_manager(context) as session | 19:04 |
dansmith | ? | 19:04 |
dansmith | or something? | 19:04 |
dansmith | seems like not | 19:08 |
alaski | I've only seen a decorator defined | 19:09 |
*** sputnik13 has quit IRC | 19:09 | |
openstackgerrit | Merged openstack/oslo.messaging: Small fixes https://review.openstack.org/294916 | 19:09 |
*** sputnik13 has joined #openstack-oslo | 19:11 | |
*** mriedem_lunch is now known as mriedem | 19:12 | |
dims_ | dansmith : closest to that syntax in a test case is - http://git.openstack.org/cgit/openstack/oslo.db/tree/oslo_db/tests/sqlalchemy/test_enginefacade.py#n954 | 19:12 |
dims_ | back in a bit. need to pick up kid from school | 19:13 |
dansmith | okay, just moving them out and back in is the least destructive I think, so I'll just do that | 19:13 |
*** yamamoto has joined #openstack-oslo | 19:14 | |
*** yamamoto has quit IRC | 19:21 | |
*** dtardivel has quit IRC | 19:28 | |
*** gordc has quit IRC | 19:28 | |
*** achanda has quit IRC | 19:28 | |
bknudson | I'm confused as to how test_base works with enginefacade... test_base has an engine and so does enginefacade... I need them to use the same engine to be able to test correctly | 19:52 |
*** achanda has joined #openstack-oslo | 19:52 | |
bknudson | actually, now I'm seeing that test_base sets test.enginefacade... so maybe I can inject that. | 19:53 |
*** harlowja_at_home has quit IRC | 19:53 | |
*** harlowja_at_home has joined #openstack-oslo | 19:54 | |
*** andymaier has quit IRC | 19:58 | |
*** gordc has joined #openstack-oslo | 20:10 | |
*** e0ne has quit IRC | 20:17 | |
*** ihrachys has quit IRC | 20:18 | |
*** pcaruana has joined #openstack-oslo | 20:21 | |
*** alejandrito has quit IRC | 20:25 | |
*** alejandrito has joined #openstack-oslo | 20:31 | |
*** boden has joined #openstack-oslo | 20:36 | |
*** MVenesio has quit IRC | 20:37 | |
*** regXboi has joined #openstack-oslo | 20:40 | |
bknudson | according to the comments it says I shouldn't need to inject since _TestTransactionFactory does that, but I'm getting a different engine when I test... maybe because keystone uses enginefacade.transaction_context() and not the global | 20:42 |
*** ihrachys has joined #openstack-oslo | 20:56 | |
*** alejandrito has quit IRC | 20:57 | |
*** alejandrito has joined #openstack-oslo | 20:58 | |
*** amotoki has joined #openstack-oslo | 21:02 | |
*** mfranc213 has joined #openstack-oslo | 21:02 | |
*** kgiusti has left #openstack-oslo | 21:13 | |
dims_ | harlowja_at_home : bknudson : one of you please bless this? so i can go ahead with project-config changes | 21:17 |
dims_ | harlowja_at_home : bknudson : https://review.openstack.org/#/c/295363/ | 21:17 |
patchbot | dims_: patch 295363 - oslo.messaging - Add a py34 functional test for rabbit | 21:17 |
*** rlrossit has quit IRC | 21:18 | |
bknudson | dims_: what sets PYTHON? tox? | 21:19 |
*** regXboi has quit IRC | 21:20 | |
dims_ | bknudson : snippet in project-config will set it. if it's not set then it defaults to py27 | 21:26 |
dims_ | bknudson : i'll get that change ready as well if you want to look at that | 21:26 |
bknudson | dims_: I'd look at it | 21:27 |
bknudson | dims_: do you need to passenv = PYTHON? | 21:29 |
bknudson | for some reason this file has "passend" instead of "passenv" | 21:30 |
dims_ | bknudson : weird, we'll have to fix that | 21:34 |
dims_ | bknudson : something like this - https://review.openstack.org/295531 - still have to make sure that the jobs complete | 21:35 |
*** amrith is now known as _amrith_ | 21:35 | |
*** achanda has quit IRC | 21:35 | |
openstackgerrit | Davanum Srinivas (dims) proposed openstack/oslo.messaging: Fix typo passend should be passenv https://review.openstack.org/295533 | 21:36 |
dims_ | bknudson : ^^ | 21:37 |
*** achanda has joined #openstack-oslo | 21:47 | |
*** boden has quit IRC | 21:53 | |
*** cdent has quit IRC | 21:56 | |
*** amotoki has quit IRC | 22:00 | |
*** pcaruana has quit IRC | 22:06 | |
*** jecarey has quit IRC | 22:08 | |
*** jecarey has joined #openstack-oslo | 22:11 | |
*** sigmavirus24 is now known as sigmavirus24_awa | 22:13 | |
*** jecarey has quit IRC | 22:16 | |
*** achanda has quit IRC | 22:18 | |
*** dimtruck is now known as zz_dimtruck | 22:23 | |
*** ihrachys has quit IRC | 22:23 | |
*** shardy has quit IRC | 22:25 | |
*** alejandrito has quit IRC | 22:32 | |
*** zqfan has joined #openstack-oslo | 22:36 | |
*** MVenesio has joined #openstack-oslo | 22:38 | |
*** MVenesio has quit IRC | 22:42 | |
openstackgerrit | Merged openstack/oslo.messaging: Add a py34 functional test for rabbit https://review.openstack.org/295363 | 22:52 |
*** edmondsw has quit IRC | 22:59 | |
*** openstackgerrit has quit IRC | 23:03 | |
*** openstackgerrit_ is now known as openstackgerrit | 23:03 | |
*** openstackgerrit has quit IRC | 23:03 | |
*** openstackgerrit_ has joined #openstack-oslo | 23:03 | |
*** boris-42 has quit IRC | 23:04 | |
*** openstackgerrit_ is now known as openstackgerrit | 23:04 | |
*** _amrith_ is now known as amrith | 23:05 | |
*** openstackgerrit_ has joined #openstack-oslo | 23:08 | |
*** dims_ has quit IRC | 23:09 | |
*** dims has joined #openstack-oslo | 23:09 | |
*** sdague has quit IRC | 23:12 | |
*** achanda has joined #openstack-oslo | 23:20 | |
*** dims has quit IRC | 23:21 | |
*** dims has joined #openstack-oslo | 23:22 | |
*** achanda has quit IRC | 23:27 | |
*** dims has quit IRC | 23:27 | |
*** dims has joined #openstack-oslo | 23:28 | |
*** ozamiatin has quit IRC | 23:29 | |
*** amrith is now known as _amrith_ | 23:31 | |
*** dims has quit IRC | 23:33 | |
*** gordc has quit IRC | 23:33 | |
*** achanda has joined #openstack-oslo | 23:49 | |
*** ozamiatin has joined #openstack-oslo | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!