*** thumpba_ has joined #openstack-oslo | 00:03 | |
*** snizar_ has quit IRC | 00:03 | |
*** snizar has quit IRC | 00:03 | |
*** thumpba has quit IRC | 00:05 | |
*** snizar has joined #openstack-oslo | 00:10 | |
*** snizar_ has joined #openstack-oslo | 00:10 | |
zzzeek | Bknudson: oh it's migrate ? Ugh yeah much more quirks w engines... Big reason I wrote alembic | 00:12 |
---|---|---|
*** code-R_ has quit IRC | 00:22 | |
*** sdake has joined #openstack-oslo | 00:35 | |
openstackgerrit | Merged openstack/oslo.messaging: Fix the help info format https://review.openstack.org/352667 | 00:37 |
*** dimtruck is now known as zz_dimtruck | 00:45 | |
bknudson | zzzeek: migrate didn't like that the scripts had the same name... for some reason migrate was getting the wrong object from its object cache. | 00:48 |
*** jamielennox is now known as jamielennox|away | 00:48 | |
bknudson | easy workaround is to rename the scripts | 00:48 |
*** gus has joined #openstack-oslo | 00:48 | |
bknudson | also, yes, we should have switched to alembic a while ago but we don't take care of debt in keystone, only add more. | 00:48 |
*** itisha has quit IRC | 00:50 | |
*** spzala has joined #openstack-oslo | 00:59 | |
*** sdake has quit IRC | 00:59 | |
*** sdake has joined #openstack-oslo | 01:02 | |
*** spzala has quit IRC | 01:03 | |
*** jamielennox|away is now known as jamielennox | 01:04 | |
*** snizar has quit IRC | 01:04 | |
*** snizar_ has quit IRC | 01:04 | |
harlowja | ok folks i proposed https://review.openstack.org/#/c/356822/ | 01:05 |
patchbot | harlowja: patch 356822 - releases - Oslo weekly release for week of aug 15th, 2016 | 01:05 |
harlowja | it should have our needed stuff for this week (that isn't already being released via different reviews) | 01:06 |
*** jecarey has quit IRC | 01:08 | |
harlowja | sorry for being a little late there | 01:08 |
*** code-R has joined #openstack-oslo | 01:09 | |
*** sdake has quit IRC | 01:11 | |
*** spzala has joined #openstack-oslo | 01:15 | |
*** jeckersb_gone is now known as jeckersb | 01:20 | |
*** zz_dimtruck is now known as dimtruck | 01:31 | |
*** code-R has quit IRC | 01:37 | |
*** spzala has quit IRC | 01:38 | |
*** spzala has joined #openstack-oslo | 01:39 | |
*** edmondsw has quit IRC | 01:40 | |
*** hockeynut has joined #openstack-oslo | 01:42 | |
*** spzala has quit IRC | 01:43 | |
*** takedakn has joined #openstack-oslo | 01:44 | |
*** takedakn has quit IRC | 01:51 | |
*** thumpba_ has quit IRC | 01:52 | |
*** tbarron is now known as tbarron|afk | 02:00 | |
*** thumpba has joined #openstack-oslo | 02:23 | |
*** eandersson_ has joined #openstack-oslo | 02:40 | |
*** jamielennox is now known as jamielennox|away | 02:42 | |
*** takedakn has joined #openstack-oslo | 02:46 | |
*** eandersson_ has quit IRC | 02:47 | |
openstackgerrit | Jinxing Fang proposed openstack/oslo.messaging: Change the rabbit_max_retries default value https://review.openstack.org/356840 | 02:49 |
openstackgerrit | Jinxing Fang proposed openstack/oslo.messaging: Change the rabbit_max_retries default value https://review.openstack.org/356840 | 02:51 |
*** spzala has joined #openstack-oslo | 03:00 | |
*** spzala has quit IRC | 03:05 | |
*** hockeynut has quit IRC | 03:06 | |
*** jamielennox|away is now known as jamielennox | 03:07 | |
*** yamahata has quit IRC | 03:07 | |
*** thumpba has quit IRC | 03:15 | |
openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.log: Default use_stderr to False https://review.openstack.org/351283 | 03:16 |
*** tonytan4ever has joined #openstack-oslo | 03:36 | |
*** code-R has joined #openstack-oslo | 03:38 | |
*** code-R has quit IRC | 03:43 | |
*** links has joined #openstack-oslo | 03:45 | |
*** takedakn has quit IRC | 03:46 | |
*** code-R has joined #openstack-oslo | 03:47 | |
*** code-R_ has joined #openstack-oslo | 03:50 | |
*** code-R has quit IRC | 03:52 | |
*** spzala has joined #openstack-oslo | 04:01 | |
*** code-R_ has quit IRC | 04:04 | |
*** tonytan4ever has quit IRC | 04:05 | |
*** spzala has quit IRC | 04:07 | |
*** code-R has joined #openstack-oslo | 04:25 | |
*** amotoki has joined #openstack-oslo | 04:33 | |
*** amotoki has quit IRC | 04:38 | |
*** code-R has quit IRC | 04:38 | |
*** code-R has joined #openstack-oslo | 04:38 | |
*** code-R has quit IRC | 04:59 | |
*** spzala has joined #openstack-oslo | 05:00 | |
*** amotoki has joined #openstack-oslo | 05:00 | |
*** amotoki has quit IRC | 05:05 | |
*** spzala has quit IRC | 05:06 | |
*** tonytan4ever has joined #openstack-oslo | 05:06 | |
*** tonytan4ever has quit IRC | 05:11 | |
*** code-R has joined #openstack-oslo | 05:15 | |
*** eandersson_ has joined #openstack-oslo | 05:24 | |
*** amotoki has joined #openstack-oslo | 05:28 | |
*** amotoki has quit IRC | 05:32 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.config: Updated from global requirements https://review.openstack.org/356935 | 05:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.log: Updated from global requirements https://review.openstack.org/354462 | 05:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.messaging: Updated from global requirements https://review.openstack.org/356936 | 05:55 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.service: Updated from global requirements https://review.openstack.org/356937 | 05:56 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.utils: Updated from global requirements https://review.openstack.org/356938 | 05:56 |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/356939 | 05:56 |
*** spzala has joined #openstack-oslo | 06:03 | |
*** code-R has quit IRC | 06:05 | |
*** spzala has quit IRC | 06:07 | |
*** eandersson_ has quit IRC | 06:07 | |
*** code-R has joined #openstack-oslo | 06:08 | |
*** rcernin has joined #openstack-oslo | 06:12 | |
*** lpetrut has joined #openstack-oslo | 06:18 | |
*** yamamoto has quit IRC | 06:21 | |
*** amotoki has joined #openstack-oslo | 06:22 | |
*** amotoki has quit IRC | 06:26 | |
*** amotoki has joined #openstack-oslo | 06:29 | |
*** code-R_ has joined #openstack-oslo | 06:34 | |
*** code-R has quit IRC | 06:36 | |
*** takedakn has joined #openstack-oslo | 06:44 | |
*** takedakn has quit IRC | 06:49 | |
*** amotoki has quit IRC | 06:51 | |
*** pcaruana has joined #openstack-oslo | 06:52 | |
*** code-R_ has quit IRC | 06:53 | |
*** takedakn has joined #openstack-oslo | 06:56 | |
*** amotoki has joined #openstack-oslo | 06:56 | |
*** yamamoto has joined #openstack-oslo | 07:00 | |
*** amotoki has quit IRC | 07:04 | |
*** xek__ has quit IRC | 07:08 | |
*** lpetrut has quit IRC | 07:11 | |
*** tesseract- has joined #openstack-oslo | 07:17 | |
*** e0ne has joined #openstack-oslo | 07:18 | |
*** yamamoto has quit IRC | 07:38 | |
*** nkrinner_afk has quit IRC | 07:39 | |
*** nkrinner_afk has joined #openstack-oslo | 07:51 | |
*** amotoki has joined #openstack-oslo | 07:55 | |
*** amotoki_ has joined #openstack-oslo | 07:57 | |
*** zzzeek has quit IRC | 08:00 | |
*** amotoki has quit IRC | 08:00 | |
*** zzzeek has joined #openstack-oslo | 08:01 | |
*** cdent has joined #openstack-oslo | 08:04 | |
*** spzala has joined #openstack-oslo | 08:04 | |
*** ihrachys has joined #openstack-oslo | 08:08 | |
*** spzala has quit IRC | 08:08 | |
*** mhickey has joined #openstack-oslo | 08:09 | |
*** eandersson_ has joined #openstack-oslo | 08:26 | |
*** ihrachys has quit IRC | 08:36 | |
*** takedakn has quit IRC | 08:37 | |
*** yamamoto has joined #openstack-oslo | 08:39 | |
openstackgerrit | Julien Danjou proposed openstack/tooz: file: move _read_{group,member}_id to staticmethod-s https://review.openstack.org/347841 | 08:40 |
openstackgerrit | Julien Danjou proposed openstack/tooz: file: move _load_and_validate to a method https://review.openstack.org/347842 | 08:40 |
openstackgerrit | Julien Danjou proposed openstack/tooz: file: return converted voluptuous data https://review.openstack.org/347843 | 08:40 |
openstackgerrit | Julien Danjou proposed openstack/tooz: file: update .metadata atomically https://review.openstack.org/347844 | 08:40 |
*** yamamoto has quit IRC | 08:52 | |
*** yamamoto has joined #openstack-oslo | 08:56 | |
*** yamamoto has quit IRC | 08:56 | |
*** yamamoto has joined #openstack-oslo | 08:56 | |
*** dkehn_ has quit IRC | 09:00 | |
*** dkehn has quit IRC | 09:00 | |
*** spzala has joined #openstack-oslo | 09:04 | |
*** e0ne has quit IRC | 09:07 | |
*** dkehn has joined #openstack-oslo | 09:07 | |
*** d0ugal has quit IRC | 09:08 | |
*** spzala has quit IRC | 09:09 | |
*** yamamoto has quit IRC | 09:10 | |
*** ihrachys has joined #openstack-oslo | 09:10 | |
*** yamamoto has joined #openstack-oslo | 09:12 | |
*** d0ugal has joined #openstack-oslo | 09:12 | |
*** yamamoto has quit IRC | 09:12 | |
*** d0ugal_ has joined #openstack-oslo | 09:17 | |
*** d0ugal_ has quit IRC | 09:18 | |
*** d0ugal_ has joined #openstack-oslo | 09:18 | |
*** dkehn_ has joined #openstack-oslo | 09:18 | |
*** dtardivel has joined #openstack-oslo | 09:19 | |
*** d0ugal has quit IRC | 09:20 | |
*** d0ugal_ has quit IRC | 09:20 | |
*** d0ugal has joined #openstack-oslo | 09:20 | |
*** ihrachys has quit IRC | 09:24 | |
*** sambetts|afk is now known as sambetts | 09:25 | |
*** lpetrut has joined #openstack-oslo | 09:29 | |
*** yamamoto has joined #openstack-oslo | 09:30 | |
*** yamamoto has quit IRC | 09:30 | |
*** yamamoto has joined #openstack-oslo | 09:30 | |
*** yamamoto has quit IRC | 09:30 | |
*** yamamoto has joined #openstack-oslo | 09:31 | |
openstackgerrit | Merged openstack-dev/pbr: Replace OpenStack LLC with OpenStack Foundation https://review.openstack.org/347299 | 09:31 |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Implement retries for unacknowledged CALLs https://review.openstack.org/353529 | 09:33 |
*** yamamoto has quit IRC | 09:36 | |
*** ozamiatin has joined #openstack-oslo | 09:49 | |
openstackgerrit | Merged openstack/oslo.config: Updated from global requirements https://review.openstack.org/356935 | 09:51 |
*** ihrachys has joined #openstack-oslo | 09:56 | |
*** d0ugal has quit IRC | 09:58 | |
openstackgerrit | Merged openstack/oslo.utils: Updated from global requirements https://review.openstack.org/356938 | 10:00 |
*** yamamoto has joined #openstack-oslo | 10:01 | |
*** yamamoto has quit IRC | 10:01 | |
*** gcb_ has quit IRC | 10:02 | |
*** d0ugal has joined #openstack-oslo | 10:04 | |
openstackgerrit | Merged openstack/oslo.log: Updated from global requirements https://review.openstack.org/354462 | 10:05 |
*** spzala has joined #openstack-oslo | 10:05 | |
*** sdague has joined #openstack-oslo | 10:06 | |
*** ihrachys has quit IRC | 10:07 | |
*** spzala has quit IRC | 10:10 | |
*** amotoki_ has quit IRC | 10:14 | |
*** amotoki has joined #openstack-oslo | 10:18 | |
openstackgerrit | Merged openstack/oslo.vmware: Updated from global requirements https://review.openstack.org/356939 | 10:26 |
*** ozamiatin_ has joined #openstack-oslo | 10:29 | |
*** yamamoto has joined #openstack-oslo | 10:32 | |
*** code-R has joined #openstack-oslo | 10:33 | |
*** ociuhandu has quit IRC | 10:33 | |
*** boden has joined #openstack-oslo | 10:33 | |
*** yamamoto has quit IRC | 10:37 | |
*** code-R_ has joined #openstack-oslo | 10:40 | |
*** yamamoto has joined #openstack-oslo | 10:41 | |
*** lpetrut1 has joined #openstack-oslo | 10:43 | |
*** code-R has quit IRC | 10:43 | |
*** lpetrut has quit IRC | 10:45 | |
*** lpetrut1 is now known as lpetrut | 10:45 | |
*** amotoki has quit IRC | 10:45 | |
*** amotoki_ has joined #openstack-oslo | 10:46 | |
openstackgerrit | Merged openstack/oslo.privsep: Use default value for undefined caps in fmt_caps https://review.openstack.org/340524 | 10:47 |
openstackgerrit | Merged openstack/oslo.vmware: Fix TypeError:six.StringIO(resp.content) must be str or None, not bytes. https://review.openstack.org/351601 | 10:53 |
*** code-R_ has quit IRC | 10:57 | |
*** code-R has joined #openstack-oslo | 10:57 | |
*** ozamiatin_ has quit IRC | 10:59 | |
*** spzala has joined #openstack-oslo | 11:06 | |
*** spzala has quit IRC | 11:11 | |
*** lucasagomes is now known as lucas-hungry | 11:13 | |
*** cdent has quit IRC | 11:17 | |
*** spzala has joined #openstack-oslo | 11:23 | |
*** spzala has quit IRC | 11:23 | |
*** takedakn has joined #openstack-oslo | 11:34 | |
*** code-R has quit IRC | 11:38 | |
*** code-R has joined #openstack-oslo | 11:38 | |
*** takedakn has quit IRC | 11:39 | |
*** ociuhandu has joined #openstack-oslo | 11:39 | |
*** cdent has joined #openstack-oslo | 11:48 | |
*** code-R has quit IRC | 11:49 | |
*** boden has quit IRC | 11:54 | |
*** jpena is now known as jpena|lunch | 12:00 | |
*** code-R has joined #openstack-oslo | 12:03 | |
*** jeckersb is now known as jeckersb_gone | 12:04 | |
*** boden has joined #openstack-oslo | 12:05 | |
*** e0ne has joined #openstack-oslo | 12:09 | |
*** edmondsw has joined #openstack-oslo | 12:15 | |
*** ansmith has joined #openstack-oslo | 12:15 | |
*** lucas-hungry is now known as lucasagomes | 12:19 | |
*** ihrachys has joined #openstack-oslo | 12:20 | |
*** spzala has joined #openstack-oslo | 12:24 | |
*** code-R has quit IRC | 12:24 | |
*** gordc has joined #openstack-oslo | 12:27 | |
*** spzala has quit IRC | 12:29 | |
*** pradk has joined #openstack-oslo | 12:31 | |
*** ihrachys has quit IRC | 12:31 | |
*** ihrachys has joined #openstack-oslo | 12:32 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/oslo.privsep: Updated from global requirements https://review.openstack.org/350914 | 12:39 |
*** jeckersb_gone is now known as jeckersb | 12:50 | |
*** e0ne has quit IRC | 12:52 | |
*** kgiusti has joined #openstack-oslo | 12:52 | |
*** e0ne has joined #openstack-oslo | 12:55 | |
*** jpena|lunch is now known as jpena | 12:55 | |
*** rlrossit has joined #openstack-oslo | 12:59 | |
*** ihrachys has quit IRC | 12:59 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Implement retries for unacknowledged CALLs https://review.openstack.org/353529 | 12:59 |
*** amotoki_ has quit IRC | 13:00 | |
openstackgerrit | Kirill Bespalov proposed openstack/oslo.messaging: Fix socket getting in the set_transport_socket_timeout() https://review.openstack.org/357189 | 13:00 |
*** ihrachys has joined #openstack-oslo | 13:02 | |
*** code-R has joined #openstack-oslo | 13:05 | |
*** amotoki has joined #openstack-oslo | 13:06 | |
*** jecarey has joined #openstack-oslo | 13:07 | |
kgiusti | harlowja: dude - I need a favor... | 13:07 |
*** code-R_ has joined #openstack-oslo | 13:09 | |
*** code-R has quit IRC | 13:13 | |
*** ihrachys has quit IRC | 13:13 | |
*** mhickey has quit IRC | 13:14 | |
*** ihrachys has joined #openstack-oslo | 13:16 | |
*** links has quit IRC | 13:16 | |
*** thumpba has joined #openstack-oslo | 13:17 | |
*** ihrachys has quit IRC | 13:18 | |
*** amotoki has quit IRC | 13:27 | |
*** mhickey has joined #openstack-oslo | 13:28 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Host name and target in socket identity https://review.openstack.org/356451 | 13:36 |
*** amotoki has joined #openstack-oslo | 13:37 | |
*** dimtruck is now known as zz_dimtruck | 13:41 | |
*** zz_dimtruck is now known as dimtruck | 13:41 | |
*** spzala has joined #openstack-oslo | 13:42 | |
*** ihrachys has joined #openstack-oslo | 13:47 | |
*** ihrachys has quit IRC | 13:50 | |
*** dimtruck is now known as zz_dimtruck | 13:51 | |
*** cdent has quit IRC | 13:52 | |
*** ihrachys has joined #openstack-oslo | 13:53 | |
*** itisha has joined #openstack-oslo | 13:57 | |
jschwarz | jd__, hey | 13:58 |
jd__ | jschwarz: oy | 13:58 |
jschwarz | jd__, how's life? | 13:58 |
jd__ | jschwarz: good and ya? | 13:58 |
jschwarz | jd__, good, good | 13:59 |
jschwarz | jd__, so I'm starting to look into tooz' adoption for Neutorn during Ocata | 13:59 |
jschwarz | jd__, I had a couple of questions.. the first regards the API of tooz | 13:59 |
jschwarz | jd__, if for example I wish to move all the exceptions from https://github.com/openstack/tooz/blob/master/tooz/coordination.py#L648 to a new file (exceptions.py), is that something that can be done? | 14:00 |
jd__ | jschwarz: possibly | 14:02 |
jschwarz | jd__, yey :) | 14:02 |
jd__ | moving code around for moving code around is not my cup of tea | 14:02 |
jd__ | but if you got compelling argument and want to do it… I can be sold | 14:02 |
jschwarz | jd__, it's not for the sake of moving around - most other projects have exceptions.py and we don't want coordination.py to be too crowded | 14:02 |
jschwarz | jd__, so consistency and organisation are my selling points :) | 14:03 |
*** abashmak has left #openstack-oslo | 14:03 | |
jschwarz | jd__, the second question regards https://github.com/openstack/cinder/tree/master/cinder/coordination.py#L60 | 14:03 |
jschwarz | jd__, basically I'm thinking of copying that from cinder to tooz so that it can be used throughout (as it's quite generic) | 14:04 |
jschwarz | jd__, although some of it could go into DriverManager | 14:04 |
jschwarz | jd__, what do you think? | 14:04 |
jd__ | hm | 14:05 |
jd__ | most of it is already in tooz, the heartbeat thread part | 14:05 |
jschwarz | jd__, really? where? | 14:05 |
jd__ | jschwarz: http://docs.openstack.org/developer/tooz/developers.html#tooz.coordination.CoordinationDriver.start | 14:06 |
jd__ | start_heart=True | 14:06 |
jd__ | that does it for ya | 14:06 |
jd__ | maybe the reconnect part of Cinder could be useful, I don't think we have that | 14:06 |
jschwarz | jd__, I see | 14:07 |
jschwarz | jd__, the Heart class is newer than the Cinder code so I think that's why | 14:08 |
jschwarz | jd__, so adapting Cinder code instead of copy-pasting - roger that | 14:08 |
jschwarz | jd__, what about Cinder's Lock and @synchronized (same file I linked earlier)? | 14:09 |
*** zz_dimtruck is now known as dimtruck | 14:10 | |
*** e0ne has quit IRC | 14:10 | |
*** ihrachys has quit IRC | 14:11 | |
jd__ | jschwarz: it is newer indeed, Cinder should be updated agreed | 14:12 |
jd__ | jschwarz: let me check | 14:12 |
jd__ | jschwarz: I don't think Lock is useful, it's mainly a hack to have a global variable named COORDINATOR, we don't want that in a lib (nor in a program if you ask me lol) | 14:14 |
*** ihrachys has joined #openstack-oslo | 14:14 | |
jd__ | jschwarz: synchronized, why not | 14:14 |
*** e0ne has joined #openstack-oslo | 14:14 | |
jd__ | though I'm not sure having a decorator that can't rely on a global variable is that useful | 14:15 |
jschwarz | jd__, though, Cinder's Lock also supports "Lock('foo-{volume.id}, {'volume': ...,})" | 14:15 |
openstackgerrit | Dan Smith proposed openstack/oslo.versionedobjects: Fix remotable object change tracking https://review.openstack.org/355981 | 14:15 |
jschwarz | which I'm not sure if yours do or not | 14:15 |
*** ihrachys has quit IRC | 14:16 | |
jd__ | I don't follow, which feature is useful here? | 14:16 |
jd__ | the name of the lock? tooz has | 14:16 |
jschwarz | jd__, the "inspect the lock name in order to retrieve variable lock names" | 14:16 |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Implement retries for unacknowledged CALLs https://review.openstack.org/353529 | 14:17 |
jschwarz | jd__, so if I have a Lock on a volume with an id '111', it will produce a Lock that is automatically unique to that volume.id | 14:17 |
jd__ | so you mean lock_name.format(**lock_data) ? | 14:17 |
jschwarz | jd__, yes | 14:17 |
jd__ | I don't think it's really useful in tooz TBH | 14:17 |
jschwarz | jd__, why not? | 14:18 |
jd__ | everyone picks its naming convention | 14:18 |
jd__ | we don't really care | 14:18 |
jschwarz | jd__, aye, but that naming convention is quite useful IMO | 14:18 |
jd__ | it's a one line function in each app that wants to implement its naming convention based on its workflow | 14:18 |
*** ihrachys has joined #openstack-oslo | 14:18 | |
jschwarz | and not providing a naming convention at all (except for some pre-determined string) will only cause each project to define its own naming scheme | 14:19 |
jschwarz | jd__, which is code duplication that can be avoided in most cases | 14:19 |
jd__ | well, when we'll identify that code duplication, maybe | 14:19 |
jschwarz | "hey, here's our default, useful naming convention you can use. if you don't want what most projects use, define your own" | 14:20 |
jd__ | until then, I can tell that it won't apply e.g to any of telemetry projects | 14:20 |
jschwarz | jd__, I can identify the code duplication right now actually | 14:20 |
jd__ | why Cinder does not use the volume uuid for the lock name? | 14:20 |
jschwarz | jd__, because if that naming scheme isn't in Tooz, I'm gonna copy it from Cinder to Neutron | 14:21 |
jschwarz | jd__, I don't know. would it matter if they did? | 14:21 |
jd__ | well, I don't see what code you need in tooz if you do that, like we do in telemetry it's just self.coordinator.get_lock(resource.id) | 14:22 |
jd__ | and you get a lock for your resource | 14:22 |
jd__ | do they need anything more? | 14:22 |
jd__ | or Neutron | 14:22 |
jschwarz | jd__, it would be extremely helpful to put that information (the lock name) as a decorator | 14:22 |
jd__ | as a decorator? WDYM? | 14:23 |
jschwarz | jd__, but a decorator doesn't normally has access to 'resource', unless it can inspect the lock_data as Cinder does | 14:23 |
jschwarz | jd__, let me find a code example | 14:23 |
jd__ | sure go ahead :) | 14:23 |
jschwarz | jd__, https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/glusterfs.py#L188 | 14:24 |
* jd__ eyes start bleeding | 14:25 | |
jschwarz | jd__, this is extremely usefull IMO - they can ensure the function executes only when it has the lock and they don't need to call "self.coordinator.get_lock()" and try-except blocks every time | 14:25 |
jschwarz | jd__, no! don't bleed! | 14:25 |
jschwarz | >.< | 14:25 |
*** mpotdar_ has joined #openstack-oslo | 14:26 | |
jd__ | you don't need a try block, just a with self.coord.get_lock(volume.id) | 14:26 |
jd__ | it's just one line, like the decorator | 14:26 |
jschwarz | jd__, well technically it's more than one | 14:26 |
jschwarz | because you then need to release it | 14:27 |
jd__ | with does that… | 14:27 |
jd__ | the lock work as context managers | 14:27 |
jschwarz | jd__, so you either use a 'with' block on the entire function (which is meh), or you add a 'lock.release()' before each return | 14:27 |
jd__ | no | 14:27 |
jschwarz | ? | 14:27 |
jd__ | google python context manager :P | 14:28 |
jd__ | let me show you | 14:28 |
jschwarz | lol, I know how to use context managers | 14:28 |
jschwarz | well, I hope :P | 14:28 |
jd__ | the locks in tooz are defined as context managers: https://github.com/openstack/tooz/blob/master/tooz/locking.py#L37 | 14:29 |
jd__ | so you can do with thelock: <anything> | 14:29 |
jd__ | as soon as you quit the with block in _any_ way: return, raise, whatever | 14:29 |
jschwarz | jd__, yes | 14:29 |
jd__ | the __exit__ function is called | 14:29 |
jd__ | which does a release of the lock | 14:29 |
jschwarz | jd__, but that increases the indentation of the entire function, which is meh :P | 14:29 |
jd__ | … | 14:29 |
jd__ | I have a rule, I stop arguing when it goes out of technical scope such as coding style, etc, I'm sorry :-) | 14:30 |
jschwarz | jd__, consider a 30-lines function - you now have to increase its indentation (take care of pep8) or create a pass-through function, which is basically a decorator | 14:30 |
jd__ | jschwarz: example in Gnocchi https://github.com/openstack/gnocchi/blob/master/gnocchi/storage/_carbonara.py#L222 | 14:30 |
jschwarz | jd__, it's not strictly coding styles, it's usability as well | 14:31 |
jd__ | jschwarz: you're free to create a decorator wrapper with a "with lock:" (like @synchronized) if you wish – but without a global variable I think it'll be clunky | 14:31 |
jschwarz | if you consider how people are going to use coordinator.get_lock(), a decorator that automatically acquires and releases it is acceptable | 14:31 |
jd__ | jschwarz: I won't break my rule, I'm sorry | 14:32 |
jd__ | :) | 14:32 |
jschwarz | jd__, okay then | 14:32 |
jschwarz | I'll find a way to make it non-clunky :) | 14:32 |
jd__ | jschwarz: but you can't do that without a global variable I think, what you want to do | 14:32 |
jd__ | which is a no-go | 14:32 |
jschwarz | jd__, well | 14:32 |
jschwarz | jd__, you could have it decorate a class method, so the inner function will accept 'self' as first argument and refer to 'self.coordinator' | 14:33 |
jd__ | we already suffered too much of oslo_config.cfg.CONF | 14:33 |
jschwarz | it'll work but it'll suck ;-) | 14:33 |
jd__ | jschwarz: it is hackish indeed… | 14:33 |
*** mhickey has quit IRC | 14:34 | |
jschwarz | jd__, well, thanks for your time indeed :) | 14:35 |
jd__ | no problem jschwarz | 14:36 |
*** cdent has joined #openstack-oslo | 14:37 | |
*** d0ugal has quit IRC | 14:41 | |
*** mhickey has joined #openstack-oslo | 14:47 | |
*** ihrachys has quit IRC | 14:47 | |
*** eeiden has quit IRC | 14:47 | |
*** d0ugal has joined #openstack-oslo | 14:48 | |
*** d0ugal has quit IRC | 14:48 | |
*** d0ugal has joined #openstack-oslo | 14:48 | |
*** syjulian has quit IRC | 14:49 | |
*** syjulian has joined #openstack-oslo | 14:50 | |
*** dmellado|off is now known as dmellado | 14:52 | |
*** tonytan4ever has joined #openstack-oslo | 14:57 | |
*** kgiusti is now known as kgiusti|meeting | 14:59 | |
*** tbarron|afk is now known as tbarron | 15:00 | |
*** salv-orlando has joined #openstack-oslo | 15:00 | |
*** yamamoto has quit IRC | 15:01 | |
*** hockeynut has joined #openstack-oslo | 15:04 | |
*** yamamoto has joined #openstack-oslo | 15:04 | |
*** d0ugal has quit IRC | 15:09 | |
*** yamamoto has quit IRC | 15:09 | |
*** eeiden has joined #openstack-oslo | 15:15 | |
*** ihrachys has joined #openstack-oslo | 15:21 | |
*** rcernin has quit IRC | 15:22 | |
*** ihrachys has quit IRC | 15:22 | |
*** d0ugal has joined #openstack-oslo | 15:24 | |
*** mhickey has quit IRC | 15:24 | |
*** e0ne has quit IRC | 15:30 | |
*** ozamiatin_ has joined #openstack-oslo | 15:32 | |
*** mhickey has joined #openstack-oslo | 15:36 | |
*** ozamiatin_ has quit IRC | 15:36 | |
*** ozamiatin_ has joined #openstack-oslo | 15:40 | |
*** kgiusti|meeting is now known as kgiusti | 15:41 | |
*** mpotdar_ has quit IRC | 15:45 | |
*** mpotdar_ has joined #openstack-oslo | 15:45 | |
*** tonytan4ever has quit IRC | 16:00 | |
*** tonytan4ever has joined #openstack-oslo | 16:01 | |
*** yamamoto has joined #openstack-oslo | 16:06 | |
*** yamamoto has quit IRC | 16:11 | |
*** yamahata has joined #openstack-oslo | 16:13 | |
*** ihrachys has joined #openstack-oslo | 16:16 | |
*** mtanino has joined #openstack-oslo | 16:20 | |
*** tesseract- has quit IRC | 16:26 | |
*** sambetts is now known as sambetts|afk | 16:27 | |
*** ihrachys has quit IRC | 16:36 | |
*** thumpba_ has joined #openstack-oslo | 16:37 | |
*** ihrachys has joined #openstack-oslo | 16:38 | |
*** mhickey has quit IRC | 16:39 | |
*** thumpba has quit IRC | 16:39 | |
*** amotoki has quit IRC | 16:40 | |
*** itisha has quit IRC | 16:40 | |
*** ihrachys has quit IRC | 16:41 | |
*** code-R_ has quit IRC | 16:41 | |
*** lucasagomes is now known as lucas-dinner | 16:42 | |
*** ihrachys has joined #openstack-oslo | 16:44 | |
*** sdague has quit IRC | 16:49 | |
*** srini has joined #openstack-oslo | 16:52 | |
*** d34dh0r53 is now known as RichardLongus | 16:52 | |
srini | Is there a way to force oslo_db to reconnect mysql connections with new config? For e.g. there is a password change. Are is there a better strategy for handling password changes in case of a security threat | 16:53 |
*** eandersson_ has quit IRC | 16:54 | |
*** RichardLongus is now known as d34dh0r53 | 16:58 | |
*** ihrachys has quit IRC | 16:58 | |
*** yamahata has quit IRC | 17:00 | |
*** yamahata has joined #openstack-oslo | 17:00 | |
*** mpotdar_ has quit IRC | 17:03 | |
*** tonytan_brb has joined #openstack-oslo | 17:04 | |
*** sdague has joined #openstack-oslo | 17:06 | |
*** tonytan4ever has quit IRC | 17:06 | |
kgiusti | dims: ping - would you be able to help me create a merge patch for the amqp1-dispatch-router feature branch? | 17:11 |
kgiusti | dims: I don't have the perms: http://paste.openstack.org/show/560798/ | 17:11 |
*** ozamiatin_ has quit IRC | 17:14 | |
harlowja | kgiusti let me make that | 17:14 |
kgiusti | harlowja: you da man! | 17:14 |
harlowja | np sir | 17:15 |
*** tonytan_brb is now known as tonytan4ever | 17:25 | |
*** gsilvis has joined #openstack-oslo | 17:31 | |
*** lpetrut has quit IRC | 17:31 | |
openstackgerrit | Alexander Makarov proposed openstack/oslo.cache: Store cache invalidation timestamps on region backend https://review.openstack.org/354831 | 17:36 |
harlowja | let see if i can do this, ha | 17:36 |
kgiusti | harlowja: I used this: http://docs.openstack.org/infra/manual/drivers.html | 17:38 |
kgiusti | harlowja: it was trivial, until I tried the git review -R, which bombed out | 17:39 |
harlowja | :-P | 17:39 |
harlowja | k | 17:39 |
kgiusti | harlowja: take note of the .gitreview checkout in that manual - I initially missed that! | 17:39 |
gsilvis | In oslo-cache, 'get_memoization_decorator' takes a 'group' parameter, saying where in the config file it should look to get the caching configuration... but 'configure' only loads the configuration in the section named 'cache' | 17:39 |
gsilvis | This seems odd to me, but I'm not sure quite what was intended there | 17:40 |
harlowja | kgiusti kk, almost to that step, ha | 17:40 |
* kgiusti crosses fingers, toes, eyes | 17:41 | |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Merge branch 'amqp-dispatch-router' into merge-amqp1-dispatch-router https://review.openstack.org/357370 | 17:41 |
harlowja | kgiusti ^ | 17:41 |
kgiusti | harlowja: YOWZA! | 17:41 |
harlowja | hmmm | 17:41 |
harlowja | is that right, ha | 17:41 |
harlowja | weird | 17:42 |
harlowja | lol | 17:42 |
kgiusti | harlowja: hrm - I would've expected a bit more :) | 17:42 |
harlowja | lol | 17:42 |
harlowja | ya | 17:42 |
kgiusti | one sec.. | 17:43 |
harlowja | k, pasting the commands i did | 17:43 |
*** hockeynut has quit IRC | 17:44 | |
harlowja | http://paste.openstack.org/show/560838/ | 17:44 |
harlowja | nothing special | 17:44 |
harlowja | but ya, the review seems sorta ummm, small | 17:45 |
harlowja | lol | 17:45 |
kgiusti | harlowja: ah, I did it a bit differently | 17:45 |
kgiusti | harlowja: one sec... | 17:45 |
harlowja | though when i look at `git log` it seems to show all your stuff | 17:45 |
harlowja | odd, ha | 17:46 |
*** ekcs has left #openstack-oslo | 17:46 | |
kgiusti | harlowja: I did the merge of the upstream branch (not a local one) e.g.: git merge --no-ff origin/feature/amqp-dispatch-router | 17:48 |
harlowja | right | 17:48 |
harlowja | should be the same | 17:48 |
harlowja | but let me try that approach | 17:48 |
kgiusti | harlowja: not aware of why there's no other stuff showing up | 17:48 |
harlowja | see if anything chages, ha | 17:48 |
kgiusti | harlowja: hrm... when I resync the branch to master, the review only showed where I had to fix conflicts | 17:50 |
openstackgerrit | Joshua Harlow proposed openstack/oslo.messaging: Merge remote-tracking branch 'origin/feature/amqp-dispatch-router' into merge-amqp1-dispatch-router https://review.openstack.org/357376 | 17:50 |
kgiusti | harlowja: not all the changes that merged in | 17:50 |
harlowja | lol, ya doing what u did the same thing :-P | 17:50 |
kgiusti | harlowja: crap | 17:50 |
harlowja | maybe this is how it works :-/ | 17:50 |
harlowja | let me try one other approach, ha | 17:51 |
kgiusti | harlowja: doesn't seem to helpful, review-wise, eh? | 17:51 |
*** rcernin has joined #openstack-oslo | 17:51 | |
harlowja | lol | 17:52 |
harlowja | maybe thats how its supposed to be? | 17:52 |
harlowja | so kgiusti https://review.openstack.org/#/c/357382/ is what i do without any git-review thing | 17:53 |
patchbot | harlowja: patch 357382 - oslo.messaging (feature/amqp-dispatch-router) - Merge remote-tracking branch 'origin/feature/amqp-... | 17:53 |
harlowja | pretty much a blank review | 17:53 |
harlowja | thats via http://paste.openstack.org/show/560840/ | 17:54 |
harlowja | so i'm thinking this is just the normal way this works | 17:54 |
harlowja | @fungi u got a sec? | 17:54 |
kgiusti | ugh | 17:54 |
fungi | catching up | 17:55 |
harlowja | thx fungi , basically just a merge feature branch question | 17:55 |
harlowja | wondering if the result of http://paste.openstack.org/show/560838/ (which ends up as https://review.openstack.org/#/c/357376/ ) is correct | 17:55 |
patchbot | harlowja: patch 357376 - oslo.messaging - Merge remote-tracking branch 'origin/feature/amqp-... | 17:55 |
kgiusti | harlowja: seems like the same wrt the pika merge: https://review.openstack.org/#/c/264768/ | 17:55 |
patchbot | kgiusti: patch 264768 - oslo.messaging - Merge remote-tracking branch 'origin/feature/pika'... (MERGED) | 17:55 |
fungi | i can probably answer this by saying that what gerrit's webui diff view shows is not the difference between the parents in the merge commit, but any merge conflict resolution involved in the merge commit | 17:55 |
harlowja | okie dokie | 17:55 |
harlowja | fungi k | 17:56 |
harlowja | which would be the .gitreview file i guess | 17:56 |
kgiusti | 'zactly what I saw when I resync the branch to master | 17:56 |
fungi | the best way to validate it is to retrieve that from review.o.o yourself and git diff things like HEAD and the previous branch state, or the parent commits of the merge, or whatever you're worried about | 17:56 |
harlowja | right, looked at git log | 17:57 |
harlowja | and it seemed right | 17:57 |
harlowja | guess its just UI weirdness then | 17:57 |
fungi | yeah, it's an intentional design choice on the part of gerrit's dev team, fwiw | 17:57 |
fungi | but everyone i know finds it confusing | 17:57 |
harlowja | okie dokie | 17:59 |
harlowja | thx fungi | 17:59 |
harlowja | alright kgiusti i guess https://review.openstack.org/#/c/357376/ is the winner then :-P | 17:59 |
patchbot | harlowja: patch 357376 - oslo.messaging - Merge remote-tracking branch 'origin/feature/amqp-... | 17:59 |
kgiusti | harlowja: well that's a quick review then | 17:59 |
kgiusti | :P | 17:59 |
harlowja | ha | 17:59 |
fungi | any time harlowja! | 18:00 |
fungi | i'm full of fun stories about gerrit's intentional design shortcomings ;) | 18:00 |
harlowja | fungi i bet | 18:03 |
harlowja | i can tell u some stuff about jenkins pipelines now :-P | 18:04 |
harlowja | collecting my fun stories about that, ha | 18:04 |
harlowja | its intersting | 18:04 |
harlowja | like 80% functional imho | 18:04 |
fungi | luckily i can enjoy jenkins horror stories now rather than spend my time checking whether we're appropriately mitigating them | 18:04 |
harlowja | ;) | 18:07 |
harlowja | u can just listen in fungi | 18:07 |
harlowja | ha | 18:07 |
*** mpotdar_ has joined #openstack-oslo | 18:09 | |
*** yamahata has quit IRC | 18:10 | |
kgiusti | harlowja: thanks for the help. | 18:11 |
kgiusti | harlowja: hopefully zuul won't be as grumpy as it has lately... | 18:11 |
harlowja | kgiusti :) | 18:11 |
harlowja | np | 18:11 |
*** jecarey has quit IRC | 18:13 | |
*** jecarey has joined #openstack-oslo | 18:15 | |
harlowja | SpamapS why u not in #openstack-architecture | 18:21 |
harlowja | jeez | 18:21 |
harlowja | u mr.architect | 18:22 |
harlowja | lol | 18:22 |
SpamapS | hahaha | 18:22 |
SpamapS | there's an architecture channel? | 18:22 |
SpamapS | join #openstack-architecture | 18:22 |
harlowja | :-p | 18:22 |
*** mpotdar_ has quit IRC | 18:24 | |
*** mpotdar_ has joined #openstack-oslo | 18:25 | |
dansmith | harlowja: dims: I have my grubby fingers all over this, but it's good to go and we should get it for newton: https://review.openstack.org/#/c/355981/ | 18:25 |
patchbot | dansmith: patch 355981 - oslo.versionedobjects - Fix remotable object change tracking | 18:25 |
dansmith | if you or others could/would +2, that would be cool | 18:26 |
harlowja | dansmith cool, checking out | 18:32 |
harlowja | dansmith u should write a little book on oslo.versionedobjects | 18:33 |
harlowja | like one of those pocket guides :-P | 18:33 |
harlowja | i'd buy it | 18:33 |
dansmith | I could write on microfiche and make it a nano guide | 18:33 |
harlowja | that'd work | 18:33 |
dansmith | heh | 18:33 |
harlowja | u must have really tiny fingers to write on microfiche | 18:33 |
harlowja | :-P | 18:33 |
harlowja | nanofingers | 18:34 |
dansmith | heh | 18:34 |
harlowja | with a really small pen | 18:34 |
dansmith | I already do this: https://xkcd.com/378/ | 18:34 |
dansmith | needles are small | 18:34 |
harlowja | :-P | 18:35 |
*** hockeynut has joined #openstack-oslo | 18:36 | |
*** mpotdar_ has quit IRC | 18:38 | |
*** mpotdar_ has joined #openstack-oslo | 18:38 | |
openstackgerrit | Brant Knudson proposed openstack/oslo.cache: Correct help text for backend option https://review.openstack.org/357407 | 18:40 |
*** yamahata has joined #openstack-oslo | 18:46 | |
*** dtardivel has quit IRC | 18:47 | |
*** lpetrut has joined #openstack-oslo | 18:47 | |
*** ociuhandu has quit IRC | 18:47 | |
openstackgerrit | George Silvis, III proposed openstack/oslo.cache: Expand usage example (WIP) https://review.openstack.org/357412 | 18:52 |
*** rlrossit has quit IRC | 18:52 | |
*** mpotdar_ has quit IRC | 18:54 | |
*** mpotdar_ has joined #openstack-oslo | 18:54 | |
*** rlrossi__ has joined #openstack-oslo | 18:55 | |
openstackgerrit | Giridhar Jayavelu proposed openstack/oslo.vmware: Improve logging for task updates https://review.openstack.org/350218 | 18:58 |
*** jecarey has quit IRC | 19:05 | |
*** ozamiatin_ has joined #openstack-oslo | 19:05 | |
*** jecarey has joined #openstack-oslo | 19:11 | |
*** jecarey has quit IRC | 19:11 | |
*** jecarey has joined #openstack-oslo | 19:12 | |
*** salv-orl_ has joined #openstack-oslo | 19:15 | |
*** salv-orlando has quit IRC | 19:18 | |
openstackgerrit | George Silvis, III proposed openstack/oslo.cache: Add usage example to documentation https://review.openstack.org/357412 | 19:29 |
*** thumpba_ has quit IRC | 19:29 | |
*** e0ne has joined #openstack-oslo | 19:34 | |
*** thumpba has joined #openstack-oslo | 19:39 | |
openstackgerrit | Patrick East proposed openstack/oslo.concurrency: Add info for shared lock_path config in description https://review.openstack.org/355269 | 19:42 |
*** ociuhandu has joined #openstack-oslo | 19:45 | |
*** srini has quit IRC | 19:45 | |
*** mpotdar_ has quit IRC | 19:56 | |
*** mpotdar_ has joined #openstack-oslo | 19:57 | |
openstackgerrit | George Silvis, III proposed openstack/oslo.cache: Add usage example to documentation https://review.openstack.org/357412 | 19:59 |
*** thumpba has quit IRC | 20:04 | |
*** mpotdar_ has quit IRC | 20:12 | |
*** mpotdar_ has joined #openstack-oslo | 20:12 | |
*** mpotdar_ has quit IRC | 20:12 | |
*** mpotdar_ has joined #openstack-oslo | 20:13 | |
harlowja | sputnik13 do u know if the cue jobs that are failing @ http://logs.openstack.org/periodic/periodic-cue-py27-with-oslo-master/1949588/ will be fixed? should we turn off that periodic job? | 20:22 |
harlowja | seems oslo.context releated | 20:23 |
*** kgiusti has left #openstack-oslo | 20:25 | |
openstackgerrit | George Silvis, III proposed openstack/oslo.cache: Fix docstring for get_memoization_decorator https://review.openstack.org/357460 | 20:29 |
*** hemanthm is now known as hemanthm|afk | 20:29 | |
*** jeckersb is now known as jeckersb_gone | 20:34 | |
*** rlrossi__ has quit IRC | 20:44 | |
*** ansmith has quit IRC | 20:49 | |
*** rlrossit has joined #openstack-oslo | 20:55 | |
*** spzala has quit IRC | 20:56 | |
*** jecarey has quit IRC | 20:59 | |
*** e0ne has quit IRC | 21:04 | |
*** yamamoto has joined #openstack-oslo | 21:09 | |
*** yamamoto has quit IRC | 21:09 | |
*** boden has quit IRC | 21:11 | |
*** hockeynut has quit IRC | 21:12 | |
*** edmondsw has quit IRC | 21:25 | |
*** rlrossit has quit IRC | 21:31 | |
*** cdent has quit IRC | 21:33 | |
*** ozamiatin has quit IRC | 21:37 | |
*** ozamiatin_ has quit IRC | 21:38 | |
*** pradk has quit IRC | 21:45 | |
*** lpetrut has quit IRC | 21:55 | |
*** tbarron is now known as tbarron|afk | 22:02 | |
*** gordc has quit IRC | 22:02 | |
*** jeckersb_gone is now known as jeckersb | 22:05 | |
*** mpotdar_ has quit IRC | 22:11 | |
*** mpotdar_ has joined #openstack-oslo | 22:11 | |
*** john51 has quit IRC | 22:36 | |
*** john51 has joined #openstack-oslo | 22:39 | |
*** mpotdar_ has quit IRC | 22:40 | |
*** yamamoto has joined #openstack-oslo | 22:42 | |
*** tonytan4ever has quit IRC | 22:47 | |
*** mpotdar_ has joined #openstack-oslo | 23:04 | |
*** mpotdar__ has joined #openstack-oslo | 23:04 | |
*** dimtruck is now known as zz_dimtruck | 23:06 | |
*** mpotdar_ has quit IRC | 23:06 | |
*** sdague has quit IRC | 23:14 | |
sputnik13 | harlowja didn't know those were on... yes they will be fixed | 23:15 |
sputnik13 | "soon" | 23:15 |
harlowja | sputnik13 cool | 23:15 |
sputnik13 | :) | 23:15 |
sputnik13 | don't ask me what "soon" means | 23:15 |
sputnik13 | :) | 23:15 |
harlowja | depends on your timescale, ha | 23:16 |
openstackgerrit | Jamie Lennox proposed openstack/oslo.context: Fix X-User and X-Tenant deprecated headers in from_environ https://review.openstack.org/357537 | 23:19 |
*** rcernin has quit IRC | 23:32 | |
*** syjulian has quit IRC | 23:39 | |
*** eeiden has quit IRC | 23:40 | |
*** eeiden has joined #openstack-oslo | 23:40 | |
*** tonytan4ever has joined #openstack-oslo | 23:47 | |
*** tonytan4ever has quit IRC | 23:53 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!