*** dimtruck is now known as zz_dimtruck | 00:43 | |
*** tommylikehu_ has joined #openstack-oslo | 00:48 | |
*** mtanino has quit IRC | 00:59 | |
*** tovin07_ has quit IRC | 01:16 | |
*** spzala has quit IRC | 01:27 | |
openstackgerrit | int32bit proposed openstack/oslo.db: Check if an index on given columns exists. https://review.openstack.org/402128 | 01:31 |
---|---|---|
tommylikehu_ | hey anybody here, could you spend some time on this patch? https://review.openstack.org/#/c/404272/ | 01:40 |
*** zhangguoqing has joined #openstack-oslo | 01:45 | |
*** ansmith has joined #openstack-oslo | 01:48 | |
*** gcb has joined #openstack-oslo | 01:50 | |
*** ansmith has quit IRC | 02:10 | |
*** tovin07 has joined #openstack-oslo | 02:16 | |
*** tovin07_ has joined #openstack-oslo | 02:18 | |
*** stevemar__ has joined #openstack-oslo | 02:29 | |
*** browne has quit IRC | 02:52 | |
*** zz_dimtruck is now known as dimtruck | 02:53 | |
*** zhenq has quit IRC | 03:08 | |
*** code-R has joined #openstack-oslo | 03:20 | |
*** code-R_ has joined #openstack-oslo | 03:21 | |
*** code-R has quit IRC | 03:25 | |
*** code-R_ has quit IRC | 03:25 | |
*** code-R has joined #openstack-oslo | 03:25 | |
*** links has joined #openstack-oslo | 03:28 | |
*** tommylikehu_ has quit IRC | 03:51 | |
*** nicolasbock has quit IRC | 03:57 | |
*** code-R_ has joined #openstack-oslo | 04:04 | |
*** code-R has quit IRC | 04:07 | |
*** stevemar__ has quit IRC | 04:19 | |
*** stevemar__ has joined #openstack-oslo | 04:19 | |
*** stevemar__ has quit IRC | 04:24 | |
*** yamamoto_ has quit IRC | 04:24 | |
*** yamahata has quit IRC | 04:35 | |
openstackgerrit | Merged openstack/stevedore: Add Apache 2.0 license to source file https://review.openstack.org/403517 | 04:36 |
*** dimtruck is now known as zz_dimtruck | 04:47 | |
*** zz_dimtruck is now known as dimtruck | 04:47 | |
*** dimtruck is now known as zz_dimtruck | 05:01 | |
*** tommylikehu_ has joined #openstack-oslo | 05:07 | |
*** yamamoto_ has joined #openstack-oslo | 05:08 | |
*** code-R_ has quit IRC | 05:26 | |
*** gcb has quit IRC | 05:54 | |
*** chenying_ has quit IRC | 05:54 | |
openstackgerrit | Thomas Bechtold proposed openstack/oslo.config: Add defaults for config-dir https://review.openstack.org/400667 | 05:57 |
toabctl | dhellmann, I had to update https://review.openstack.org/#/c/400667 again (pep8 failed). Could you please readd your +2? | 05:58 |
*** gcb has joined #openstack-oslo | 06:07 | |
*** code-R has joined #openstack-oslo | 06:08 | |
*** yamahata has joined #openstack-oslo | 06:26 | |
*** code-R_ has joined #openstack-oslo | 06:26 | |
*** stevemar__ has joined #openstack-oslo | 06:29 | |
*** code-R has quit IRC | 06:30 | |
*** stevemar__ has quit IRC | 06:33 | |
*** tsufiev has quit IRC | 06:35 | |
*** tsufiev has joined #openstack-oslo | 06:39 | |
*** code-R_ has quit IRC | 06:42 | |
openstackgerrit | int32bit proposed openstack/oslo.db: Check if an index on given columns exists. https://review.openstack.org/402128 | 06:43 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: DNM: Revert "Add Constraints support" https://review.openstack.org/404577 | 06:47 |
*** oanson has joined #openstack-oslo | 07:01 | |
*** nkrinner_afk is now known as nkrinner | 07:04 | |
*** e0ne has joined #openstack-oslo | 07:16 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Revert "Add Constraints support" https://review.openstack.org/404577 | 07:19 |
*** hoonetorg has quit IRC | 07:21 | |
*** hoonetorg has joined #openstack-oslo | 07:21 | |
*** hoonetorg has quit IRC | 07:24 | |
*** hoonetorg has joined #openstack-oslo | 07:24 | |
*** eezhova has joined #openstack-oslo | 07:27 | |
*** rcernin has joined #openstack-oslo | 07:28 | |
*** mkoderer has joined #openstack-oslo | 07:30 | |
haypo | harlowja: asynchronous programming is hard :) | 07:45 |
sileht | (with monkeypatching) | 07:45 |
sileht | :p | 07:46 |
haypo | sileht: hi. harlowja asked me "why is asyncio so complicated :-P" ;-) | 07:47 |
sileht | haypo, because it works on non-posix platform ? | 07:47 |
haypo | sileht: saying that asynchronous programming is easy is just a lie :) see https://docs.python.org/dev/library/asyncio-dev.html for example of corner cases ;) | 07:47 |
*** eezhova has quit IRC | 07:49 | |
*** gcb has quit IRC | 07:51 | |
sileht | haypo, very interesting | 07:52 |
*** gcb has joined #openstack-oslo | 07:53 | |
*** tsufiev has quit IRC | 07:54 | |
haypo | sileht: no, it's not a side effect of portability | 07:55 |
haypo | sileht: asyncio API is mostly OS-agnostic | 07:55 |
sileht | haypo, I was kidding | 07:55 |
haypo | sileht: hehe | 07:55 |
*** eezhova has joined #openstack-oslo | 07:56 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Remove small job timeout https://review.openstack.org/404615 | 07:58 |
*** tsufiev has joined #openstack-oslo | 07:58 | |
openstackgerrit | int32bit proposed openstack/oslo.db: Strip prefix `migrate_` in parameter `migrate_engine` https://review.openstack.org/404618 | 08:00 |
*** shardy has joined #openstack-oslo | 08:04 | |
*** links has quit IRC | 08:06 | |
haypo | sileht: ah, FYI I just added socket.TCP_USER_TIMEOUT constant to Python 3.6 ;-) i missed that someone proposed a patch a few months ago | 08:07 |
haypo | sileht: i didn't know that Python didn't have the constant! | 08:07 |
sileht | haypo, this is a recent socket change and kernel change | 08:08 |
haypo | "recent"... | 08:08 |
haypo | sileht: Linux 2.6.37 | 08:08 |
haypo | sileht: Fedora 25 uses Linux 4.8 | 08:08 |
*** amotoki has joined #openstack-oslo | 08:08 | |
*** amotoki has quit IRC | 08:08 | |
therve | haypo, You can still use it without python having it, no? | 08:09 |
haypo | Linux 2.6.37 released 4 January, 2011. | 08:09 |
haypo | therve: sure | 08:09 |
sileht | 2.6.37 ? I have thought is was more recent | 08:09 |
haypo | therve: i prefer to avoid hardcoded constants, i'm never confident that constants are "portable". CLOCK_MONOTONIC was a pain: it was different between openbsd, freebsd, mac os x and linux :-/ | 08:10 |
haypo | that's why i added time.monotonic(), to avoid the "if sys.platform ..." mess ;) | 08:10 |
haypo | sileht: which part of oslo.messaging uses OS_TEST_TIMEOUT ? | 08:11 |
sileht | haypo, all | 08:11 |
sileht | haypo, that's a oslotest thing | 08:11 |
haypo | sileht: i don't see the constant uses directly | 08:11 |
sileht | haypo, this is the per test timeout | 08:11 |
haypo | ah ok | 08:12 |
sileht | haypo, the default is located in .testr.conf | 08:12 |
sileht | haypo, this is used by oslotest timeoutfixture | 08:12 |
haypo | sileht: +2a for me, the fix seems well contained and safe | 08:13 |
sileht | haypo, thx! | 08:13 |
haypo | increasing a timeout shouldn't make tests failing | 08:13 |
haypo | anyway, if something goes wrong, it will be your fault | 08:13 |
haypo | ! | 08:13 |
sileht | yeah I known | 08:13 |
*** dtardivel has joined #openstack-oslo | 08:16 | |
*** links has joined #openstack-oslo | 08:18 | |
*** eezhova has quit IRC | 08:19 | |
*** jpena|off is now known as jpena | 08:22 | |
*** amoralej|off is now known as amoralej | 08:25 | |
*** stevemar__ has joined #openstack-oslo | 08:30 | |
*** stevemar__ has quit IRC | 08:34 | |
*** e0ne has quit IRC | 08:35 | |
*** eezhova has joined #openstack-oslo | 08:43 | |
*** zzzeek has quit IRC | 09:00 | |
*** zzzeek has joined #openstack-oslo | 09:00 | |
*** yamahata has quit IRC | 09:09 | |
*** lpetrut has joined #openstack-oslo | 09:10 | |
tommylikehu_ | ping harlowja | 09:18 |
*** lei-zh has joined #openstack-oslo | 09:22 | |
*** lei-zh has left #openstack-oslo | 09:22 | |
*** lei-zh has joined #openstack-oslo | 09:22 | |
haypo | tommylikehu_: he lives in australia, so he is probably sleeping ;) | 09:23 |
*** lei-zh has quit IRC | 09:23 | |
haypo | tommylikehu_: moreover, please don't use naked ping, but leave a message ;) | 09:23 |
*** lei-zh has joined #openstack-oslo | 09:23 | |
*** lei-zh has quit IRC | 09:27 | |
*** lei-zh has joined #openstack-oslo | 09:27 | |
tommylikehu_ | haypo: thanks for your reminder~ | 09:28 |
*** lei-zh has quit IRC | 09:30 | |
*** lei-zh has joined #openstack-oslo | 09:30 | |
tommylikehu_ | harlowja: could you take a look at this patch when you available? https://review.openstack.org/#/c/404620/ | 09:32 |
*** yassine has joined #openstack-oslo | 09:32 | |
*** lucas-afk is now known as lucasagomes | 09:33 | |
*** yassine is now known as Guest62009 | 09:33 | |
*** tommylikehu_ has quit IRC | 09:51 | |
*** tommylikehu_ has joined #openstack-oslo | 09:51 | |
*** tommylikehu_ has quit IRC | 09:51 | |
*** tommylikehu_ has joined #openstack-oslo | 09:52 | |
*** lpetrut has quit IRC | 09:55 | |
*** tommylikehu_ has quit IRC | 09:56 | |
*** lei-zh has quit IRC | 09:58 | |
*** tovin07_ has quit IRC | 10:02 | |
*** lpetrut has joined #openstack-oslo | 10:03 | |
*** code-R has joined #openstack-oslo | 10:04 | |
*** links has quit IRC | 10:05 | |
*** code-R_ has joined #openstack-oslo | 10:07 | |
*** snikitin has joined #openstack-oslo | 10:07 | |
*** code-R has quit IRC | 10:10 | |
*** hoonetorg has quit IRC | 10:15 | |
snikitin | harlowja: Hi! yesterday this patch https://review.openstack.org/#/c/404357/ was merged in oslo.policy. It improves the performance of Nova unit tests almost in 2 times and it will be very useful for nova team to get it. So I wanted to ask when new oslo.policy release is expected? | 10:15 |
*** andreaf has quit IRC | 10:17 | |
*** ihrachys has joined #openstack-oslo | 10:17 | |
*** andreaf has joined #openstack-oslo | 10:18 | |
*** pkholkin_ has joined #openstack-oslo | 10:18 | |
*** e0ne has joined #openstack-oslo | 10:18 | |
*** pkholkin has quit IRC | 10:19 | |
*** pkholkin_ is now known as pkholkin | 10:19 | |
*** zz_dimtruck has quit IRC | 10:19 | |
*** ogelbukh has quit IRC | 10:19 | |
*** bnemec has quit IRC | 10:19 | |
*** johndperkins has quit IRC | 10:19 | |
*** DinaBelova has quit IRC | 10:19 | |
*** jschwarz has quit IRC | 10:19 | |
*** mfisch has quit IRC | 10:19 | |
*** dhellmann has quit IRC | 10:19 | |
*** lpetrut has quit IRC | 10:20 | |
*** bnemec has joined #openstack-oslo | 10:21 | |
*** e0ne has quit IRC | 10:21 | |
*** DinaBelova has joined #openstack-oslo | 10:21 | |
*** e0ne has joined #openstack-oslo | 10:21 | |
*** links has joined #openstack-oslo | 10:22 | |
*** ogelbukh has joined #openstack-oslo | 10:22 | |
*** mfisch has joined #openstack-oslo | 10:23 | |
*** mfisch has quit IRC | 10:23 | |
*** mfisch has joined #openstack-oslo | 10:23 | |
*** dhellmann has joined #openstack-oslo | 10:23 | |
*** hoonetorg has joined #openstack-oslo | 10:24 | |
*** zz_dimtruck has joined #openstack-oslo | 10:25 | |
*** boris-42 has quit IRC | 10:25 | |
*** code-R_ has quit IRC | 10:25 | |
*** zz_dimtruck is now known as dimtruck | 10:25 | |
*** code-R has joined #openstack-oslo | 10:26 | |
*** jschwarz has joined #openstack-oslo | 10:26 | |
*** boris-42 has joined #openstack-oslo | 10:28 | |
*** johndperkins has joined #openstack-oslo | 10:30 | |
openstackgerrit | Alexis Lee proposed openstack/oslo.config: List comprehensions https://review.openstack.org/400751 | 10:35 |
*** pcaruana has joined #openstack-oslo | 10:35 | |
*** e0ne has quit IRC | 10:36 | |
*** e0ne has joined #openstack-oslo | 10:36 | |
*** cdent has joined #openstack-oslo | 10:37 | |
*** lpetrut has joined #openstack-oslo | 10:55 | |
*** lpetrut has quit IRC | 11:01 | |
*** links has quit IRC | 11:07 | |
*** links has joined #openstack-oslo | 11:08 | |
*** sdague has joined #openstack-oslo | 11:27 | |
*** ansmith has joined #openstack-oslo | 11:36 | |
*** boden has joined #openstack-oslo | 11:37 | |
*** rtheis has joined #openstack-oslo | 11:49 | |
openstackgerrit | Julien Danjou proposed openstack/tooz: zookeeper: switch to standard group membership watching https://review.openstack.org/399162 | 11:52 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Add partitioner implementation https://review.openstack.org/398604 | 11:52 |
openstackgerrit | Julien Danjou proposed openstack/tooz: coordination: add __repr__ for join/leave events https://review.openstack.org/398350 | 11:52 |
openstackgerrit | Julien Danjou proposed openstack/tooz: coordination: renforce event based testing https://review.openstack.org/398349 | 11:52 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Use the internal group of list rather than listing the groups https://review.openstack.org/399161 | 11:52 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Add a hashring implementation https://review.openstack.org/397264 | 11:52 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Factorize member_id in the base coordinator class https://review.openstack.org/397772 | 11:52 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Move the cached-based watcher implementation into its own class https://review.openstack.org/397263 | 11:52 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Do not re-set the members cache for watchers by default https://review.openstack.org/398352 | 11:52 |
*** szaher has quit IRC | 11:56 | |
*** ansmith has quit IRC | 11:58 | |
*** nicolasbock has joined #openstack-oslo | 12:11 | |
*** links has quit IRC | 12:34 | |
*** amoralej is now known as amoralej|lunch | 12:50 | |
*** lucasagomes is now known as lucas-hungry | 12:54 | |
*** gcb has quit IRC | 12:58 | |
*** yamamoto_ has quit IRC | 12:59 | |
*** code-R_ has joined #openstack-oslo | 13:22 | |
*** ansmith has joined #openstack-oslo | 13:22 | |
*** code-R has quit IRC | 13:24 | |
*** lei-zh has joined #openstack-oslo | 13:25 | |
*** links has joined #openstack-oslo | 13:36 | |
*** links has quit IRC | 13:36 | |
*** edmondsw has joined #openstack-oslo | 13:36 | |
*** stevemar__ has joined #openstack-oslo | 13:37 | |
*** zhangguoqing has quit IRC | 13:39 | |
*** mhickey has joined #openstack-oslo | 13:40 | |
*** rasca has joined #openstack-oslo | 13:40 | |
*** oanson has quit IRC | 13:43 | |
*** jeckersb is now known as jeckersb_gone | 13:45 | |
*** yamamoto has joined #openstack-oslo | 13:45 | |
therve | jd__, Started getting this failure yesterday night: http://logs.openstack.org/40/404340/1/check/gate-heat-dsvm-functional-convg-mysql-lbaasv2-centos-7-amqp1-nv/689d26a/logs/screen-s-proxy.txt.gz | 13:46 |
therve | Any idea what's going on? | 13:46 |
therve | It's in the qpid gate | 13:47 |
jd__ | therve: not a clue, sileht maybe? | 13:47 |
*** jpena is now known as jpena|lunch | 13:48 | |
sileht | therve, no idea | 13:49 |
therve | It's weird, I can't see where the change comes from | 13:50 |
*** lucas-hungry is now known as lucasagomes | 13:51 | |
sileht | therve, in http://logs.openstack.org/40/404340/1/check/gate-heat-dsvm-functional-convg-mysql-lbaasv2-centos-7-amqp1-nv/689d26a/logs/etc/swift/proxy-server.conf.txt.gz | 13:51 |
sileht | therve, the url is obvious wrong | 13:51 |
sileht | therve, "url = amqp://:@10.12.39.254:/" | 13:51 |
sileht | empty is not a valid port :) | 13:51 |
sileht | therve, we can fix it in oslo.messaging | 13:52 |
sileht | therve, but something else put ':' without a port | 13:52 |
therve | sileht, https://review.openstack.org/#/c/399166/ maybe? | 13:54 |
sileht | therve, indeed | 13:54 |
therve | I haven't spotted the error just yet :) | 13:55 |
therve | Ah yeah the $port doesn't have a default value | 13:56 |
rasca | haypo, dhellmann, rpodolyaka, dims, hi everybody guys, what else needs to be done to have this https://review.openstack.org/#/c/404289/ merged and finally get the package? Is Joshua the only one in charge of this? | 13:56 |
*** szaher has joined #openstack-oslo | 13:56 | |
therve | ansmith, Hi, around? I have a question with https://review.openstack.org/#/c/399166/ | 13:56 |
openstackgerrit | Julien Danjou proposed openstack/tooz: zookeeper: switch to standard group membership watching https://review.openstack.org/399162 | 13:58 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Add partitioner implementation https://review.openstack.org/398604 | 13:58 |
openstackgerrit | Julien Danjou proposed openstack/tooz: coordination: add __repr__ for join/leave events https://review.openstack.org/398350 | 13:58 |
openstackgerrit | Julien Danjou proposed openstack/tooz: coordination: renforce event based testing https://review.openstack.org/398349 | 13:58 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Use the internal group of list rather than listing the groups https://review.openstack.org/399161 | 13:58 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Add a hashring implementation https://review.openstack.org/397264 | 13:58 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Factorize member_id in the base coordinator class https://review.openstack.org/397772 | 13:58 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Move the cached-based watcher implementation into its own class https://review.openstack.org/397263 | 13:58 |
openstackgerrit | Julien Danjou proposed openstack/tooz: Do not re-set the members cache for watchers by default https://review.openstack.org/398352 | 13:58 |
therve | sileht, Thanks for your help :) | 13:58 |
rpodolyaka | rasca: +1'ed the patch, but we'll need someone from the stable team or harlowja to approve it | 13:59 |
sileht | therve, I have written a fix | 13:59 |
sileht | therve, does your job use amqp1.0 driver ? | 14:00 |
therve | sileht, Yep | 14:00 |
sileht | therve, cool ! | 14:00 |
sileht | therve, I fix the oslo.messaging port bug but I have nothing to test the amqp1.0 plugin | 14:01 |
therve | sileht, I mean, you don't have to change oslo messaging frankly. Maybe just have a better error, but it's a broken setup | 14:03 |
sileht | therve, the url is self is valid | 14:04 |
therve | I guess | 14:04 |
sileht | therve, TransportUrl object try to mimic urlparse | 14:05 |
*** code-R has joined #openstack-oslo | 14:05 | |
sileht | therve, urlparse raise ValueError for incorrect port too | 14:05 |
sileht | for this particular case, empty is not an invalid error | 14:05 |
sileht | error/value | 14:05 |
*** kgiusti has joined #openstack-oslo | 14:06 | |
*** tongli has joined #openstack-oslo | 14:07 | |
*** code-R_ has quit IRC | 14:08 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: Fix transport url with empty port https://review.openstack.org/404783 | 14:09 |
*** shardy has quit IRC | 14:09 | |
sileht | therve, https://review.openstack.org/404783 | 14:09 |
therve | sileht, What will happen when None bubbles up later on? There is a real default? | 14:11 |
sileht | therve, None means driver default | 14:11 |
*** amoralej|lunch is now known as amoralej | 14:11 | |
therve | Cool, makes sense | 14:12 |
zzzeek | hey all i need https://review.openstack.org/#/c/404443/ and https://review.openstack.org/#/c/404453/ to go in, if we release oslo.db w/o then neutron test suite will break, and we need an oslo.db release for a different mysql issue | 14:13 |
kgiusti | sileht: hey - any chance we can get some sileht love for https://review.openstack.org/#/c/402753/ ? | 14:15 |
kgiusti | sileht: seeing zeromq timeouts http://logs.openstack.org/11/403911/2/check/gate-oslo.messaging-dsvm-functional-py27-zeromq/e87cfd1/console.html#_2016-11-29_21_24_28_163380 | 14:15 |
sileht | kgiusti, I have found that too: https://review.openstack.org/#/c/404615/ | 14:16 |
kgiusti | sileht: yeah - I was just looking at that one. :) | 14:17 |
sileht | kgiusti, I'm planning to pass voting the rabbit one | 14:17 |
sileht | kgiusti, I wonder why it have been disabled | 14:17 |
sileht | kgiusti, the commit (8 months old) said for 'instable' reason | 14:18 |
kgiusti | sileht: good question - I wondered about that too. | 14:18 |
sileht | but I don't see any failure with logstash since 3 months | 14:18 |
sileht | (3 months is the max retention of logs) | 14:18 |
kgiusti | +1 to making it voting | 14:18 |
*** pradk has quit IRC | 14:24 | |
*** mriedem has quit IRC | 14:25 | |
*** tsufiev has quit IRC | 14:33 | |
*** gcb has joined #openstack-oslo | 14:33 | |
*** tsufiev has joined #openstack-oslo | 14:37 | |
*** jeckersb_gone is now known as jeckersb | 14:38 | |
openstackgerrit | Merged openstack/oslo.config: Add defaults for config-dir https://review.openstack.org/400667 | 14:41 |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Support message versions for rolling upgrades https://review.openstack.org/390517 | 14:41 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests https://review.openstack.org/404802 | 14:41 |
sileht | Let's see what the gate thing, but that one should fix our py3 jobs : https://review.openstack.org/404802 | 14:42 |
sileht | kgiusti, ^ | 14:42 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests https://review.openstack.org/404802 | 14:42 |
sileht | oups I have missed a file | 14:42 |
*** mtanino has joined #openstack-oslo | 14:43 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Support message versions for rolling upgrades https://review.openstack.org/390517 | 14:44 |
*** jpena|lunch is now known as jpena | 14:44 | |
*** spzala has joined #openstack-oslo | 14:50 | |
kgiusti | sileht: 'test_fafka.py' fafka - I like that! | 14:53 |
sileht | kgiusti, I have just split the existing one to not run functional kafka tests on rabbit job :) | 14:53 |
jeckersb | fafka sounds like it should be a drink... like fanta | 14:54 |
gcb | :) | 14:55 |
*** mriedem has joined #openstack-oslo | 14:56 | |
sileht | On my side, I see 'Kafta' | 14:56 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests https://review.openstack.org/404802 | 14:57 |
sileht | kgiusti, I have renamed it | 14:57 |
kgiusti | sileht: np - but I think the testenv you added into tox.ini is misnamed (should be -kafka, not -pika) - is that correct? | 14:58 |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests https://review.openstack.org/404802 | 14:58 |
sileht | kgiusti, thx (I have copy/paste) | 14:59 |
kgiusti | :D - been there many times myself | 14:59 |
*** Rockyg has joined #openstack-oslo | 14:59 | |
sileht | kgiusti, I wonder if someone use this driver | 15:00 |
*** yamamoto has quit IRC | 15:00 | |
sileht | kgiusti, the code comes from 1 commit the 01/12/2015 | 15:00 |
sileht | and still no functional tests in gate | 15:01 |
kgiusti | sileht: yeah - perhaps it should be deprecated in pike? See if anyone steps forward to own it? | 15:01 |
sileht | kgiusti, I will send a mail on the ML for this | 15:02 |
sileht | kgiusti, it still use the old/deprecated python-kafka api | 15:02 |
openstackgerrit | Oleksii Zamiatin proposed openstack/oslo.messaging: [zmq] Fix non voting gate jobs https://review.openstack.org/404815 | 15:04 |
kgiusti | sileht: mmm... that doesn't look good. | 15:04 |
*** shardy has joined #openstack-oslo | 15:05 | |
*** yamamoto has joined #openstack-oslo | 15:06 | |
amrith | hi guys ... https://review.openstack.org/#/c/404783/1 | 15:07 |
amrith | before you approve the change, please see my comment there. | 15:07 |
amrith | sileht, kgiusti | 15:07 |
amrith | ^^ | 15:08 |
kgiusti | amrith: kk | 15:08 |
amrith | kgiusti, thx | 15:08 |
ozamiatin | kgiusti: hi, i've read yesterday conversation today sorry ... | 15:09 |
kgiusti | ozamiatin: np dude :O | 15:10 |
kgiusti | :) | 15:10 |
ozamiatin | kgiusti: this patch is going to fix those failing jobs ... will see :) https://review.openstack.org/404815 | 15:10 |
kgiusti | dansmith: ozamiatin to the rescue! | 15:13 |
*** lei-zh has quit IRC | 15:13 | |
dansmith | woot | 15:13 |
*** oanson has joined #openstack-oslo | 15:13 | |
*** stevemar__ has quit IRC | 15:18 | |
*** stevemar__ has joined #openstack-oslo | 15:19 | |
*** eezhova has quit IRC | 15:19 | |
*** jeckersb is now known as jeckersb_gone | 15:25 | |
*** pradk has joined #openstack-oslo | 15:27 | |
openstackgerrit | Mehdi Abaakouk (sileht) proposed openstack/oslo.messaging: kafka separate unit/functionnal tests https://review.openstack.org/404802 | 15:27 |
*** jeckersb_gone is now known as jeckersb | 15:28 | |
openstackgerrit | Merged openstack/oslo.messaging: [zmq] Fix zmq-specific f-tests from periodic hangs https://review.openstack.org/402753 | 15:31 |
amrith | kgiusti, any thoughts on https://review.openstack.org/#/c/404783/ ? | 15:32 |
amrith | sileht, ^^ | 15:33 |
kgiusti | amrith: yeah - I was going to follow up on the review. But discussing it here is fine too. | 15:33 |
*** gordc has joined #openstack-oslo | 15:33 | |
*** pblaho has quit IRC | 15:34 | |
amrith | thx kgiusti I ask because I'm midway through reviewing a change in trove about specifying the transport URL | 15:34 |
kgiusti | amrith: you're correct - the hostname: no-port is technically invalid according to all the amqp related tech I've seen (rabbitmq qpid stuff, activemq) | 15:34 |
amrith | and wanted to reflect what we discuss here. | 15:34 |
amrith | kgiusti, I'll go further and say a : with no port number is invalid as a generic URI | 15:34 |
amrith | irrespective of the smaller domain of amqp. | 15:34 |
*** pblaho has joined #openstack-oslo | 15:34 | |
amrith | it would be invalid for http, gopher, telnet, ... | 15:34 |
kgiusti | amrith: so flagging it as illegal is perfectly reasonable | 15:35 |
kgiusti | amrith: true that | 15:35 |
sileht | amrith, I just mimic urlparse.urlparse I haven't checked the RFC | 15:35 |
kgiusti | amrith: ..but... (there's always a but) should we still allow it and assume the default port of 5672? | 15:35 |
kgiusti | amrith: IOW: be liberal in what we accept? | 15:36 |
amrith | kgiusti, I would not | 15:36 |
amrith | if you want to assume port 5672, don't put a : | 15:36 |
amrith | so, amqp://hostname.domain.org/ should be analogous to amqp://hostname.domain.org:5672/ | 15:37 |
amrith | that is what https://tools.ietf.org/html/rfc3986.html#section-3.2.3 says | 15:37 |
kgiusti | amrith: which it is - no argument there. | 15:37 |
amrith | I note that they state "URI producers and | 15:37 |
amrith | normalizers should omit the port component and its ":" delimiter if | 15:37 |
amrith | port is empty or if its value would be the same as that of the | 15:37 |
amrith | scheme's default." | 15:37 |
kgiusti | amrith: so, from the 'being liberal' argument POV let me ask - what is the harm in assuming ':' with no port == port 5672 implied? | 15:39 |
amrith | being liberal with a specification leads to incompatibilities | 15:39 |
amrith | especially when there is a mechanism to specify a default already. | 15:40 |
*** syjulian has joined #openstack-oslo | 15:40 | |
amrith | just like a programming language (grammar) saying they'll be liberal about things. | 15:40 |
*** gcb has quit IRC | 15:40 | |
amrith | let me ask the other way; what about allowing a "," there instead of only a : | 15:40 |
amrith | be liberal about that too, after all / is the path delimiter | 15:41 |
amrith | so why not accept amqp://hostname.domain.org,5671/ | 15:41 |
amrith | it is unambiguous (today) | 15:41 |
amrith | a ',' can't be used in a fqdn | 15:41 |
amrith | so let's do that too :) | 15:41 |
amrith | and to respond to sileht what you are doing is NOT the same as urlparse.urlparse. See: https://gist.github.com/anonymous/8504f160ff90649890b5a2a82f8028b0 | 15:43 |
amrith | it is not throwing an error, but it is treating the : as part of the hostname | 15:43 |
kgiusti | amrith: hey - you just reminded me: our transport url parser allows for 'amqp://hostport[,hostport]*/...' | 15:43 |
amrith | what you are doing is silently dropping the : | 15:43 |
kgiusti | amrith: which IIRC is completely illegal also :D | 15:43 |
amrith | kgiusti, I didn't make the example up ... I know we do that. | 15:43 |
amrith | and I hate it | 15:44 |
amrith | because now all projects have to support these extensions | 15:44 |
sileht | amrith, please, port is None that why you don't see it... | 15:46 |
sileht | amrith, currently we raise ValueError, while urlparse ignore the ':' | 15:46 |
amrith | and sileht the : remains in the URI | 15:46 |
amrith | it does NOT ignore the : | 15:46 |
amrith | it respects it and leaves it in the host identifier | 15:46 |
sileht | amrith, it's not host its netloc ... | 15:47 |
amrith | anyway, y'all do what you wish; i'll just observe that what you are doing isn't what the RFC says. yes it is sileht see the gist I posted. | 15:47 |
therve | amrith, Not it's netloc, not hostname | 15:48 |
sileht | amrith, so urlparse is not RFC compliant ... | 15:48 |
sileht | amrith, __repr__ doesn't means anything this is a object text represention ... | 15:48 |
amrith | sileht, therve that doesn't make it right. but as I said, y'all do what you wish. | 15:49 |
*** yamamoto has quit IRC | 15:49 | |
therve | kgiusti, At any rate, if you could fix the devstack plugin so that it specified the port, that'd be great :) | 15:53 |
kgiusti | therve: oh - the amqp1 plugin? | 15:54 |
therve | kgiusti, Yeah introduced by https://review.openstack.org/#/c/399166/ | 15:54 |
therve | kgiusti, $port is not always specified, which led to the patch we're talking about | 15:55 |
kgiusti | therve: GAH! | 15:55 |
kgiusti | therve: <expletive> - yes I'll fix that immediately - so sorry I missed that. | 15:56 |
therve | kgiusti, No problem. My gate is non-voting for now :D | 15:56 |
kgiusti | ansmith: ^^^ | 15:57 |
kgiusti | ansmith: I'm going to take that one | 15:57 |
*** rcernin has quit IRC | 16:02 | |
*** code-R has quit IRC | 16:02 | |
*** edmondsw has quit IRC | 16:02 | |
*** yamamoto has joined #openstack-oslo | 16:06 | |
kgiusti | sileht: I didn't realize that patch was to get around a bug in the plugin. | 16:08 |
sileht | kgiusti, you show up a real bug | 16:09 |
kgiusti | sileht: not intentional by any means :) | 16:09 |
openstackgerrit | Merged openstack/oslo.messaging: Remove small job timeout https://review.openstack.org/404615 | 16:12 |
openstackgerrit | Ken Giusti proposed openstack/devstack-plugin-amqp1: Use 5672 as the default port if none specified https://review.openstack.org/404854 | 16:13 |
*** ihrachys has quit IRC | 16:14 | |
*** yamahata has joined #openstack-oslo | 16:26 | |
*** miqui has joined #openstack-oslo | 16:26 | |
*** code-R has joined #openstack-oslo | 16:27 | |
openstackgerrit | Gevorg Davoian proposed openstack/oslo.messaging: [zmq] Support message versions for rolling upgrades https://review.openstack.org/390517 | 16:30 |
haypo | rasca: thierry wrote "We could also use Joshua's +1 on it as PTL/releaseman" | 16:30 |
haypo | rasca: releases require a +1 from the PTL | 16:31 |
*** code-R has quit IRC | 16:35 | |
openstackgerrit | Henry Gessau proposed openstack/oslo.tools: electrocucaracha is the new liaison for Neutron https://review.openstack.org/404866 | 16:41 |
rasca | haypo, ok, so we depend here from harlowja, understood. | 16:52 |
*** dimtruck is now known as zz_dimtruck | 17:01 | |
*** e0ne has quit IRC | 17:03 | |
*** code-R has joined #openstack-oslo | 17:06 | |
*** zz_dimtruck is now known as dimtruck | 17:10 | |
*** nkrinner is now known as nkrinner_afk | 17:13 | |
*** yamamoto has quit IRC | 17:14 | |
*** yamamoto has joined #openstack-oslo | 17:15 | |
*** yamamoto has quit IRC | 17:17 | |
*** code-R has quit IRC | 17:17 | |
*** yamamoto has joined #openstack-oslo | 17:18 | |
*** pcaruana has quit IRC | 17:23 | |
*** code-R has joined #openstack-oslo | 17:25 | |
*** spzala has quit IRC | 17:25 | |
*** tongli has quit IRC | 17:30 | |
*** yamamoto has quit IRC | 17:34 | |
*** shardy has quit IRC | 17:35 | |
*** yamamoto has joined #openstack-oslo | 17:46 | |
*** lucasagomes is now known as lucas-afk | 17:48 | |
*** yamamoto has quit IRC | 17:51 | |
*** dimtruck is now known as zz_dimtruck | 17:51 | |
*** yamahata has quit IRC | 17:51 | |
openstackgerrit | Merged openstack/tooz: coordination: make get_members() return a set https://review.openstack.org/398351 | 17:54 |
*** mriedem1 has joined #openstack-oslo | 17:54 | |
*** mriedem has quit IRC | 17:56 | |
*** mriedem1 is now known as mriedem | 17:59 | |
*** spzala has joined #openstack-oslo | 17:59 | |
*** spzala has quit IRC | 18:03 | |
harlowja | rasca whats up | 18:08 |
openstackgerrit | int32bit proposed openstack/oslo.db: Check if an index on given columns exists. https://review.openstack.org/402128 | 18:08 |
*** zz_dimtruck is now known as dimtruck | 18:10 | |
*** eezhova has joined #openstack-oslo | 18:13 | |
dansmith | harlowja: this seems to fix the thing that is blocking my thing from becoming a real thing: https://review.openstack.org/#/c/404815/ | 18:15 |
dansmith | i can haz? | 18:15 |
harlowja | sureee | 18:15 |
*** ihrachys has joined #openstack-oslo | 18:15 | |
harlowja | is redhat going more with zeromq now-a-days :-P | 18:16 |
dansmith | no, I just can't land my thing because the job is broken | 18:16 |
harlowja | kk | 18:16 |
*** mriedem has quit IRC | 18:27 | |
*** e0ne has joined #openstack-oslo | 18:27 | |
*** mriedem has joined #openstack-oslo | 18:30 | |
*** ihrachys has quit IRC | 18:31 | |
*** snikitin_ has joined #openstack-oslo | 18:33 | |
*** yamahata has joined #openstack-oslo | 18:34 | |
snikitin_ | harlowja: Hi! yesterday this patch https://review.openstack.org/#/c/404357/ was merged in oslo.policy. It improves the performance of Nova unit tests almost in 2 times and it will be very useful for nova team to get it. So I wanted to ask when new oslo.policy release is expected? | 18:34 |
harlowja | today :) | 18:35 |
snikitin_ | great! | 18:35 |
*** oanson has quit IRC | 18:36 | |
*** jpena is now known as jpena|off | 18:37 | |
*** spzala has joined #openstack-oslo | 18:43 | |
*** mhickey has quit IRC | 18:46 | |
*** dharinic is now known as dharinic|lunch | 18:47 | |
*** spzala has quit IRC | 18:47 | |
*** amoralej is now known as amoralej|off | 18:47 | |
*** spzala has joined #openstack-oslo | 18:47 | |
openstackgerrit | Merged openstack/tooz: Factorize group quit on stop() https://review.openstack.org/399160 | 18:48 |
*** eezhova has quit IRC | 18:55 | |
*** eezhova has joined #openstack-oslo | 19:01 | |
zzzeek | dims / harlowja : any +2's for https://review.openstack.org/#/c/404443/ https://review.openstack.org/#/c/404453/ , these have to be in before next oslo.db release | 19:05 |
kgiusti | ansmith: I've opened https://bugs.launchpad.net/oslo.messaging/+bug/1646208 to track the changes to the amqp1 plugin | 19:06 |
openstack | Launchpad bug 1646208 in oslo.messaging "[AMQP 1.0] amqp1 devstack plugin should set the transport url using env variables" [Undecided,New] | 19:06 |
ansmith | kgiusti: taking it... | 19:07 |
kgiusti | ansmith: you da man. | 19:08 |
harlowja | zzzeek will do | 19:09 |
dims | zzzeek : ack will look in a little bit | 19:12 |
stevemar__ | harlowja, always giving the people what they want! | 19:18 |
harlowja | :-p | 19:18 |
harlowja | slowly but surely | 19:18 |
harlowja | lol | 19:18 |
*** snikitin_ has quit IRC | 19:25 | |
*** eezhova has quit IRC | 19:26 | |
*** SpamapS has quit IRC | 19:26 | |
*** dharinic|lunch is now known as dharinic | 19:28 | |
*** mkoderer has quit IRC | 19:33 | |
*** SpamapS has joined #openstack-oslo | 19:42 | |
openstackgerrit | Merged openstack/devstack-plugin-amqp1: Use 5672 as the default port if none specified https://review.openstack.org/404854 | 19:42 |
*** eezhova has joined #openstack-oslo | 20:13 | |
*** lpetrut has joined #openstack-oslo | 20:14 | |
*** ihrachys has joined #openstack-oslo | 20:15 | |
*** Guest62009 has quit IRC | 20:22 | |
*** browne has joined #openstack-oslo | 20:31 | |
*** rcernin has joined #openstack-oslo | 20:37 | |
dansmith | kgiusti: hah, that fix failed zmq also | 20:39 |
dansmith | would sure love to land my bugfix :/ | 20:39 |
kgiusti | dansmith: yeah. grrrr :) | 20:39 |
*** gangil has joined #openstack-oslo | 20:43 | |
*** dtardivel has quit IRC | 20:44 | |
*** spzala has quit IRC | 20:54 | |
*** rajathagasthya has joined #openstack-oslo | 20:59 | |
*** dimtruck is now known as zz_dimtruck | 21:09 | |
*** rtheis has quit IRC | 21:10 | |
*** zz_dimtruck is now known as dimtruck | 21:14 | |
*** ihrachys has quit IRC | 21:16 | |
*** amoralej|off is now known as amoralej | 21:21 | |
*** e0ne has quit IRC | 21:22 | |
*** e0ne has joined #openstack-oslo | 21:23 | |
*** e0ne has quit IRC | 21:24 | |
*** e0ne has joined #openstack-oslo | 21:24 | |
*** e0ne has quit IRC | 21:24 | |
*** e0ne has joined #openstack-oslo | 21:25 | |
*** e0ne has quit IRC | 21:25 | |
*** e0ne has joined #openstack-oslo | 21:25 | |
*** e0ne has quit IRC | 21:26 | |
*** e0ne has joined #openstack-oslo | 21:26 | |
*** e0ne has quit IRC | 21:27 | |
*** e0ne has joined #openstack-oslo | 21:27 | |
*** e0ne has quit IRC | 21:27 | |
*** e0ne has joined #openstack-oslo | 21:28 | |
*** e0ne has quit IRC | 21:28 | |
*** e0ne has joined #openstack-oslo | 21:29 | |
*** e0ne has quit IRC | 21:29 | |
*** ansmith has quit IRC | 21:46 | |
*** kgiusti has quit IRC | 21:49 | |
openstackgerrit | JiaJunsu proposed openstack/oslo.middleware: Filter X-Auth-Token in catch_errors https://review.openstack.org/404980 | 22:00 |
*** lpetrut has quit IRC | 22:01 | |
*** rajathagasthya has quit IRC | 22:09 | |
*** dimtruck is now known as zz_dimtruck | 22:11 | |
*** pblaho` has joined #openstack-oslo | 22:14 | |
*** pblaho has quit IRC | 22:16 | |
rasca | harlowja, you still there? | 22:19 |
rasca | harlowja, I just made a package request and would like to know if we can move on from there | 22:19 |
openstackgerrit | Merged openstack/oslo.db: Don't run LegacyBaseClass provision test for unavailable database https://review.openstack.org/404443 | 22:19 |
openstackgerrit | Merged openstack/oslo.db: Ensure provision_new_database is True by default https://review.openstack.org/404453 | 22:19 |
*** rasca has quit IRC | 22:20 | |
*** amoralej is now known as amoralej|off | 22:22 | |
*** jeckersb is now known as jeckersb_gone | 22:31 | |
*** code-R_ has joined #openstack-oslo | 22:33 | |
*** code-R has quit IRC | 22:33 | |
*** mriedem has quit IRC | 22:39 | |
*** mnaser has quit IRC | 22:41 | |
*** mnaser has joined #openstack-oslo | 22:50 | |
*** eezhova has quit IRC | 22:54 | |
*** browne has quit IRC | 23:04 | |
*** boden has quit IRC | 23:06 | |
*** gordc has quit IRC | 23:13 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/tooz: Updated from global requirements https://review.openstack.org/346782 | 23:16 |
*** spzala has joined #openstack-oslo | 23:21 | |
*** szaher has quit IRC | 23:25 | |
*** spzala has quit IRC | 23:26 | |
*** rcernin has quit IRC | 23:26 | |
*** szaher has joined #openstack-oslo | 23:28 | |
*** spzala has joined #openstack-oslo | 23:36 | |
*** sdague has quit IRC | 23:38 | |
*** pradk has quit IRC | 23:43 | |
harlowja | release wave starting! | 23:52 |
harlowja | begin release waveeee | 23:52 |
*** mriedem has joined #openstack-oslo | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!