| *** purplerbot has quit IRC | 00:34 | |
| *** purplerbot has joined #openstack-oslo | 00:34 | |
| *** tovin07 has joined #openstack-oslo | 00:48 | |
| *** zhangguoqing has joined #openstack-oslo | 00:58 | |
| *** ansmith has quit IRC | 01:05 | |
| *** Nakato has quit IRC | 01:14 | |
| *** jamielennox is now known as jamielennox|away | 01:33 | |
| *** yamamoto has quit IRC | 01:33 | |
| *** yamamoto has joined #openstack-oslo | 01:33 | |
| *** amotoki has quit IRC | 01:36 | |
| *** jamielennox|away is now known as jamielennox | 01:44 | |
| *** Nakato has joined #openstack-oslo | 01:56 | |
| *** dimtruck is now known as zz_dimtruck | 02:02 | |
| *** zz_dimtruck is now known as dimtruck | 02:02 | |
| *** yamamoto has quit IRC | 02:03 | |
| *** kiseok7 has joined #openstack-oslo | 02:05 | |
| *** dimtruck is now known as zz_dimtruck | 02:12 | |
| *** nicolasbock has quit IRC | 02:21 | |
| *** yamamoto has joined #openstack-oslo | 02:28 | |
| *** yamamoto has quit IRC | 02:50 | |
| *** yamamoto has joined #openstack-oslo | 02:53 | |
| *** yamamoto has quit IRC | 03:04 | |
| *** salv-orlando has joined #openstack-oslo | 03:07 | |
| *** salv-orlando has quit IRC | 03:12 | |
| *** tovin07_ has joined #openstack-oslo | 03:27 | |
| *** dave-mccowan has quit IRC | 03:37 | |
| *** shyama has joined #openstack-oslo | 03:51 | |
| *** Dinesh_Bhor has joined #openstack-oslo | 04:06 | |
| *** yamamoto has joined #openstack-oslo | 04:07 | |
| *** salv-orlando has joined #openstack-oslo | 04:08 | |
| *** salv-orlando has quit IRC | 04:13 | |
| *** oomichi has quit IRC | 04:46 | |
| *** salv-orlando has joined #openstack-oslo | 04:57 | |
| *** gcb has joined #openstack-oslo | 05:13 | |
| *** shyama has quit IRC | 06:03 | |
| *** shyama has joined #openstack-oslo | 06:03 | |
| *** Dinesh_Bhor has quit IRC | 06:13 | |
| *** Dinesh_Bhor has joined #openstack-oslo | 06:27 | |
| *** shardy has joined #openstack-oslo | 06:42 | |
| *** salv-orlando has quit IRC | 06:50 | |
| *** syjulian has quit IRC | 07:23 | |
| *** pcaruana has joined #openstack-oslo | 07:24 | |
| *** syjulian has joined #openstack-oslo | 07:24 | |
| *** lpetrut has joined #openstack-oslo | 07:26 | |
| *** shardy has quit IRC | 07:28 | |
| *** jaosorior has joined #openstack-oslo | 07:33 | |
| *** shardy has joined #openstack-oslo | 07:40 | |
| *** rcernin has joined #openstack-oslo | 07:43 | |
| *** lpetrut has quit IRC | 07:43 | |
| *** d0ugal has joined #openstack-oslo | 07:50 | |
| *** d0ugal has quit IRC | 07:50 | |
| *** d0ugal has joined #openstack-oslo | 07:50 | |
| *** salv-orlando has joined #openstack-oslo | 07:58 | |
| *** zzzeek has quit IRC | 08:00 | |
| *** zzzeek has joined #openstack-oslo | 08:00 | |
| *** lpetrut has joined #openstack-oslo | 08:12 | |
| *** amotoki has joined #openstack-oslo | 08:18 | |
| *** oanson has quit IRC | 08:23 | |
| *** rcernin has quit IRC | 08:23 | |
| *** oanson has joined #openstack-oslo | 08:24 | |
| *** yassine has joined #openstack-oslo | 08:25 | |
| *** yassine is now known as Guest55762 | 08:25 | |
| *** e0ne has joined #openstack-oslo | 08:26 | |
| *** cdent has joined #openstack-oslo | 08:35 | |
| *** lpetrut has quit IRC | 09:24 | |
| *** pooja_jadhav has joined #openstack-oslo | 09:41 | |
| *** Guest55762 has quit IRC | 09:45 | |
| *** sambetts|afk is now known as sambetts | 09:47 | |
| *** salv-orl_ has joined #openstack-oslo | 09:49 | |
| *** salv-orlando has quit IRC | 09:52 | |
| *** Guest55762 has joined #openstack-oslo | 10:02 | |
| *** nicolasbock has joined #openstack-oslo | 10:06 | |
| *** tovin07_ has quit IRC | 10:18 | |
| *** Guest55762 has quit IRC | 10:25 | |
| *** oanson has quit IRC | 10:37 | |
| *** oanson has joined #openstack-oslo | 10:37 | |
| *** sdague has joined #openstack-oslo | 10:38 | |
| *** lucasagomes is now known as lucas-hungry | 11:06 | |
| *** dave-mccowan has joined #openstack-oslo | 11:09 | |
| *** salv-orl_ has quit IRC | 11:15 | |
| *** oanson has quit IRC | 11:28 | |
| *** oanson has joined #openstack-oslo | 11:29 | |
| *** Guest70675 is now known as rook | 11:33 | |
| *** gordc has joined #openstack-oslo | 11:33 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.tools master: Add Oslo review dashboard config files https://review.openstack.org/459247 | 11:36 |
|---|---|---|
| *** lpetrut has joined #openstack-oslo | 11:38 | |
| *** lpetrut_ has joined #openstack-oslo | 11:48 | |
| *** nkrinner has joined #openstack-oslo | 11:59 | |
| *** salv-orlando has joined #openstack-oslo | 12:00 | |
| *** lpetrut_ has quit IRC | 12:01 | |
| *** lpetrut_ has joined #openstack-oslo | 12:03 | |
| *** lpetrut_ has quit IRC | 12:03 | |
| *** lpetrut_ has joined #openstack-oslo | 12:03 | |
| *** nkrinner has quit IRC | 12:07 | |
| *** yassine has joined #openstack-oslo | 12:09 | |
| *** yassine is now known as Guest31890 | 12:09 | |
| *** lucas-hungry is now known as lucasagomes | 12:11 | |
| *** lpetrut_ has quit IRC | 12:19 | |
| *** lpetrut_ has joined #openstack-oslo | 12:19 | |
| *** ansmith has joined #openstack-oslo | 12:31 | |
| *** salv-orlando has quit IRC | 12:47 | |
| *** cdent has quit IRC | 12:47 | |
| *** kgiusti has joined #openstack-oslo | 12:48 | |
| *** cdent has joined #openstack-oslo | 12:53 | |
| *** lpetrut_ has quit IRC | 12:54 | |
| *** lpetrut has quit IRC | 12:57 | |
| *** boden has joined #openstack-oslo | 12:58 | |
| *** ihrachys has joined #openstack-oslo | 13:02 | |
| *** jerrygb has joined #openstack-oslo | 13:02 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/mox3 master: Python 3.5 is added https://review.openstack.org/442477 | 13:07 |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.tools master: Add Oslo review dashboard config files https://review.openstack.org/459247 | 13:24 |
| *** amotoki has quit IRC | 13:27 | |
| *** lpetrut has joined #openstack-oslo | 13:28 | |
| *** lpetrut has quit IRC | 13:34 | |
| openstackgerrit | Andy Smith proposed openstack/oslo.messaging master: Add get_rpc_transport call https://review.openstack.org/454194 | 13:37 |
| *** hongbin has joined #openstack-oslo | 13:41 | |
| *** d0ugal_ has joined #openstack-oslo | 13:46 | |
| *** superdan is now known as dansmith | 13:47 | |
| *** d0ugal has quit IRC | 13:48 | |
| gcb | weekly meeting in 5 minutes at #openstack-meeting-3 | 13:54 |
| *** d0ugal_ has quit IRC | 13:55 | |
| *** eck`gone is now known as eck` | 13:58 | |
| *** d0ugal has joined #openstack-oslo | 13:59 | |
| *** d0ugal has quit IRC | 14:01 | |
| *** zz_dimtruck is now known as dimtruck | 14:15 | |
| *** beekneemech is now known as bnemec | 14:20 | |
| *** amotoki has joined #openstack-oslo | 14:28 | |
| *** d0ugal has joined #openstack-oslo | 14:32 | |
| *** amotoki has quit IRC | 14:33 | |
| *** zhangguoqing has quit IRC | 14:34 | |
| *** lpetrut has joined #openstack-oslo | 14:35 | |
| *** yamahata_ has joined #openstack-oslo | 14:43 | |
| *** lpetrut has quit IRC | 14:57 | |
| *** salv-orlando has joined #openstack-oslo | 15:02 | |
| openstackgerrit | ChangBo Guo(gcb) proposed openstack/oslo.cache master: Remove unused/duplicated logging import https://review.openstack.org/435271 | 15:18 |
| *** david-lyle has joined #openstack-oslo | 15:29 | |
| *** gcb has quit IRC | 15:37 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log master: add the line number to log messages https://review.openstack.org/459352 | 15:41 |
| *** salv-orl_ has joined #openstack-oslo | 15:49 | |
| *** shyama has quit IRC | 15:51 | |
| *** shyama has joined #openstack-oslo | 15:51 | |
| *** salv-orlando has quit IRC | 15:52 | |
| *** amotoki has joined #openstack-oslo | 15:56 | |
| *** e0ne has quit IRC | 16:11 | |
| *** jerrygb has quit IRC | 16:16 | |
| *** Guest31890 has quit IRC | 16:21 | |
| *** lucasagomes is now known as lucas-afk | 16:24 | |
| *** efried has quit IRC | 16:25 | |
| *** salv-orl_ has quit IRC | 16:26 | |
| openstackgerrit | Merged openstack/mox3 master: Python 3.5 is added https://review.openstack.org/442477 | 16:30 |
| *** jerrygb has joined #openstack-oslo | 16:33 | |
| *** jaosorior is now known as jaosorior_away | 16:59 | |
| *** ansmith has quit IRC | 17:04 | |
| *** shyama has quit IRC | 17:05 | |
| *** e0ne has joined #openstack-oslo | 17:13 | |
| *** shyama has joined #openstack-oslo | 17:14 | |
| *** ihrachys has quit IRC | 17:15 | |
| *** jdandrea has quit IRC | 17:16 | |
| *** ihrachys has joined #openstack-oslo | 17:17 | |
| *** ansmith has joined #openstack-oslo | 17:19 | |
| *** yamahata_ has quit IRC | 17:20 | |
| *** ihrachys_ has joined #openstack-oslo | 17:26 | |
| *** ihrachys has quit IRC | 17:27 | |
| *** salv-orlando has joined #openstack-oslo | 17:38 | |
| *** cdent has quit IRC | 17:52 | |
| *** amotoki has quit IRC | 17:54 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log master: add the line number to log messages https://review.openstack.org/459352 | 17:55 |
| *** yamahata_ has joined #openstack-oslo | 17:56 | |
| *** jdandrea has joined #openstack-oslo | 18:07 | |
| *** ansmith has quit IRC | 18:08 | |
| *** ansmith has joined #openstack-oslo | 18:19 | |
| *** cdent has joined #openstack-oslo | 18:39 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log master: add the line number to log messages https://review.openstack.org/459352 | 18:42 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log master: add exception summaries to the main log line https://review.openstack.org/459424 | 18:42 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log master: add exception summaries to the main log line https://review.openstack.org/459424 | 18:44 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log master: add the line number to log messages https://review.openstack.org/459426 | 18:44 |
| *** salv-orlando has quit IRC | 18:45 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log master: add exception summaries to the main log line https://review.openstack.org/459424 | 18:47 |
| *** e0ne has quit IRC | 19:05 | |
| *** e0ne has joined #openstack-oslo | 19:05 | |
| *** e0ne has quit IRC | 19:10 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.log master: add exception summaries to the main log line https://review.openstack.org/459424 | 19:10 |
| *** shyama has quit IRC | 19:23 | |
| *** shardy has quit IRC | 19:33 | |
| *** shardy has joined #openstack-oslo | 19:34 | |
| *** dimtruck is now known as zz_dimtruck | 19:35 | |
| *** salv-orlando has joined #openstack-oslo | 19:35 | |
| *** shardy has quit IRC | 19:39 | |
| *** jerrygb has quit IRC | 19:42 | |
| *** cdent has quit IRC | 19:52 | |
| *** sambetts is now known as sambetts|afk | 20:01 | |
| *** pcaruana has quit IRC | 20:01 | |
| *** harlowja has quit IRC | 20:03 | |
| *** ihrachys_ is now known as ihrachys | 20:08 | |
| *** jamielennox is now known as jamielennox|away | 20:13 | |
| *** jerrygb has joined #openstack-oslo | 20:17 | |
| *** jamielennox|away is now known as jamielennox | 20:20 | |
| *** jerrygb has quit IRC | 20:21 | |
| *** zz_dimtruck is now known as dimtruck | 20:31 | |
| *** ansmith has quit IRC | 20:53 | |
| *** harlowja has joined #openstack-oslo | 20:59 | |
| *** efried has joined #openstack-oslo | 21:06 | |
| efried | Howdy folks. (dhellmann bnemec sfinucan mtreinish) Looking for a little help on config opt deprecation. I want to do something wicked clever (read: possibly overcomplicated). | 21:12 |
| dhellmann | do tell | 21:13 |
| efried | So I'm working on implementing https://blueprints.launchpad.net/nova/+spec/use-service-catalog-for-endpoints | 21:14 |
| efried | The idea will be for certain conf-group-specific opts, like [glance]api_servers and [ironic]api_endpoint, to be deprecated | 21:14 |
| efried | And in their place, each of the affected conf groups will instead get service_type and service_interface options. | 21:14 |
| dhellmann | ok | 21:15 |
| efried | So I want to a) define those two opts in a common place where I can incorporate them into the affected conf groups. | 21:15 |
| efried | Kind of like keystone lets you do for auth opts. | 21:15 |
| dhellmann | yep | 21:15 |
| efried | And then I also want to provide a similar one-stop shop for those opts in those individual groups to pull in deprecation kwargs. | 21:16 |
| efried | I've got a start on it... | 21:16 |
| efried | https://review.openstack.org/#/c/458257/3/nova/conf/endpoint.py | 21:16 |
| dhellmann | "to pull in deprecation kwargs"? | 21:16 |
| efried | Yeah, check out ^^ | 21:16 |
| dhellmann | I see | 21:16 |
| efried | and example of how it's used https://review.openstack.org/#/c/458257/3/nova/conf/ironic.py@40 | 21:17 |
| efried | Sooo.. this is _almost_ working the way I want it. | 21:17 |
| *** eck` is now known as eck`gone | 21:17 | |
| efried | Except that it's printing the warning the wrong way around. | 21:17 |
| efried | Option "service_type" from group "ironic" is deprecated. Use option "api_endpoint" from group "ironic". | 21:17 |
| efried | That's when I remove the deprecated_for_removal, btw | 21:18 |
| dhellmann | I think the deprecated_name is meant to be the old name of the option for a rename | 21:18 |
| dhellmann | in this case you're not really renaming | 21:18 |
| dhellmann | you're removing one option and adding 2 others with different types of values | 21:18 |
| efried | Well, no, but the message still applies. | 21:18 |
| efried | Okay, so that's fair enough; I think what I really want to do is: | 21:18 |
| bnemec | Yeah, deprecated_name is supposed to be the old name, which you set on the new opt. | 21:18 |
| dhellmann | I think you want to leave deprecated_name out and just add the information about which new options to be set in the deprecated_reason description | 21:19 |
| efried | If you have the deprecated opt in your config (but not if you don't) I want to emit a message that says, "[glance]api_servers is deprecated. Use [glance]service_type and/or [glance]service_interface instead. Or, ya know, just leave 'em blank and we'll figure it out." | 21:19 |
| *** dimtruck is now known as zz_dimtruck | 21:19 | |
| *** zz_dimtruck is now known as dimtruck | 21:19 | |
| efried | Okay, so do I still want deprecated_for_removal=True? | 21:20 |
| dhellmann | yeah, I think so | 21:20 |
| dhellmann | your application code will have to look at the old option value to see if it's set | 21:20 |
| dhellmann | I would expect that access to trigger the log message, but you'll want to try that | 21:21 |
| bnemec | Yeah, except I think deprecated_for_removal will just log that the opt is being removed, not what you should use instead. | 21:21 |
| efried | What I observed was that, with deprecated_for_removal=True, it emitted the (generic) warning regardless of whether the option was specified. | 21:21 |
| dhellmann | bnemec : you're right, I found where it does that | 21:21 |
| dhellmann | it doesn't mention the reason there | 21:22 |
| efried | How 'bout this: is there a way I can try this stuff out in a nice isolated environment? Little script plus conf file? | 21:22 |
| dhellmann | oh, so it emits the warning even if the value isn't defined in the file? | 21:22 |
| efried | dhellmann That's what I observed, yes. | 21:22 |
| bnemec | Are the existing names consistent? Maybe you could just add deprecated_name='api_endpoint' to the service_type opt definition. | 21:22 |
| dhellmann | sure, just write a little script that sets up cfg.CONF with some options | 21:22 |
| efried | bnemec Different for every conf group ;-) | 21:23 |
| efried | The new ones are the same for every conf group, which is kinda the point (no pun intended) | 21:23 |
| dhellmann | that's ok, just instantiate different Opt instances for each group | 21:23 |
| efried | Right, can't reuse the same ones, figured that out. | 21:23 |
| dhellmann | although doing that is going to make it more complicated for you to tell if the value is set using the old name or the new name | 21:23 |
| dhellmann | so I'm not sure you do want to do that | 21:23 |
| bnemec | I believe it will default the deprecated_group to whatever the group where the opt is registered, so it will handle different groups fine. | 21:24 |
| efried | dhellmann Well, the formats of the values are also totally different. | 21:24 |
| efried | bnemec Yeah, that's what I've observed. | 21:24 |
| dhellmann | I feel like this has come up before and we said something this complex was application-level logic, but since it has come up more than once maybe we want to extend Opt to handle the case | 21:24 |
| bnemec | Hmm, except deprecated_name doesn't take a list. | 21:24 |
| efried | bnemec Does deprecated_name get validated as being a real conf option somewhere? Or can I pass in an arbitrary string ("service_type and service_interface")? | 21:25 |
| efried | 'cept again, that's the wrong way around, gr. | 21:25 |
| bnemec | efried: No, it doesn't get validated, but you can't use an arbitrary string either. | 21:25 |
| dhellmann | if the value is not present under the new name, the deprecated_name is used as a lookup | 21:25 |
| bnemec | You have to use the actual name of the old opt or it won't detect if the deprecated opt was used. | 21:26 |
| dhellmann | right | 21:26 |
| efried | Gotcha. "Validated" in a broader sense. | 21:26 |
| bnemec | I wonder if deprecated_opts could be used. That does take a list. | 21:26 |
| efried | Right, that's where I was looking. | 21:26 |
| efried | But the docs I found were kinda light as to how that guy actually works. | 21:27 |
| dhellmann | bnemec : I think most of that deprecation stuff expects a 1:1 rename | 21:27 |
| dhellmann | which is not really what's going on here, iiuc | 21:28 |
| dhellmann | I think deprecated_opts is mostly for the sample generator, isn't it? | 21:28 |
| dhellmann | is it used for lookups, too? | 21:28 |
| dhellmann | oh, yeah, it is | 21:29 |
| bnemec | Mmm, yeah it doesn't look like that has any way to default it to the new opt's group like deprecated_name does. | 21:29 |
| dhellmann | but you don't need a list | 21:29 |
| dhellmann | you want to look at the old value and see if it's set. if it is, emit the warning and use it. if not, look for the 2 new values. | 21:29 |
| dhellmann | so there's only 1 deprecated thing | 21:30 |
| efried | Sometimes there's more than one "old value" ;-) | 21:30 |
| dhellmann | yeah. this is application-level logic. | 21:30 |
| efried | Yeah, I'm definitely going to be doing app-level logic as well. | 21:30 |
| efried | I was just hoping for cfg-level logic to emit the warnings in a helpful way. | 21:30 |
| bnemec | Yeah, I was just looking for a way to enumerate the old names in the new opt so it could automatically handle that. | 21:30 |
| dhellmann | if you figure out a way to abstract it, we might be able to put a helper function into oslo.config | 21:30 |
| efried | Okay, so I'd like to write a mini-script to play with this. But I've only ever used oslo.config from the context of openstack drivers that already set it up, so I don't actually know how to get the whole thing bootstrapped (e.g. pass in the file path). Is there a sample somewhere? | 21:31 |
| bnemec | My thought was to have them all point at the new service_type opt, which could then have something in its description that explains you might need to set service_interface too. | 21:31 |
| efried | bnemec Yeah, that would work for me. | 21:31 |
| efried | "related options" in the help seems to be a thing. | 21:31 |
| dhellmann | efried : the docs should have some example scripts https://docs.openstack.org/developer/oslo.config/cfg.html | 21:32 |
| efried | dhellmann bnemec Thanks guys, will play. | 21:35 |
| *** salv-orl_ has joined #openstack-oslo | 21:49 | |
| *** boden has quit IRC | 21:51 | |
| *** salv-orlando has quit IRC | 21:51 | |
| *** efried has quit IRC | 21:59 | |
| *** gordc has quit IRC | 22:09 | |
| *** eck`gone is now known as eck` | 22:16 | |
| *** sdague has quit IRC | 23:03 | |
| *** dimtruck is now known as zz_dimtruck | 23:10 | |
| *** salv-orl_ has quit IRC | 23:10 | |
| *** dave-mccowan has quit IRC | 23:30 | |
| *** ansmith has joined #openstack-oslo | 23:31 | |
| *** zz_dimtruck is now known as dimtruck | 23:36 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!