Tuesday, 2017-06-06

« Monday, 2017-06-05 Index Wednesday, 2017-06-07 »
*** tovin07_ has joined #openstack-oslo01:07
*** yamahata has quit IRC01:14
*** jamielennox is now known as jamielennox|away01:17
*** jamielennox|away is now known as jamielennox01:34
*** gomarivera has joined #openstack-oslo01:38
openstackgerritlan proposed openstack/oslo.db master: Using assertIsNone(xxx) instead of assertEqual(None, xxx)  https://review.openstack.org/47118101:55
*** aselius has quit IRC01:56
openstackgerritlan proposed openstack/oslo.db master: Using assertIsNone(xxx) instead of assertEqual(None, xxx)  https://review.openstack.org/47118102:01
openstackgerritVu Cong Tuan proposed openstack/oslo.config master: Fix html_last_updated_fmt for Python3  https://review.openstack.org/47065402:14
*** links has joined #openstack-oslo02:27
*** chenying has quit IRC02:28
*** chenying has joined #openstack-oslo02:28
*** links has quit IRC02:30
*** links has joined #openstack-oslo02:30
*** chenying has quit IRC02:54
*** chenying has joined #openstack-oslo02:54
openstackgerritVu Cong Tuan proposed openstack/taskflow master: Fix html_last_updated_fmt for Python3  https://review.openstack.org/47066002:55
*** dimtruck is now known as zz_dimtruck03:01
*** gomarivera has quit IRC03:21
openstackgerritMerged openstack/oslo.messaging master: Fix serializer tests  https://review.openstack.org/47108603:21
*** gomarivera has joined #openstack-oslo03:22
*** gomarivera has quit IRC03:23
*** gomarivera has joined #openstack-oslo03:23
*** yamamoto_ has joined #openstack-oslo03:25
*** gomarivera has quit IRC03:34
*** gomarivera has joined #openstack-oslo03:34
*** gomarivera has quit IRC03:38
*** gomarivera has joined #openstack-oslo03:44
*** ihrachys has joined #openstack-oslo03:53
*** david-lyle has left #openstack-oslo03:56
*** ihrachys has quit IRC04:04
*** ihrachys has joined #openstack-oslo04:23
*** salv-orlando has joined #openstack-oslo04:26
*** salv-orlando has quit IRC04:31
*** ihrachys has quit IRC04:50
*** salv-orlando has joined #openstack-oslo05:00
*** yamamoto_ has quit IRC05:07
*** jaosorior_away is now known as jaosorior05:44
*** yamamoto has joined #openstack-oslo05:51
openstackgerritMerged openstack/oslo.config master: Cast generator_options to dict  https://review.openstack.org/47105605:55
openstackgerritMerged openstack/automaton master: Remove support for py34  https://review.openstack.org/47083306:00
*** gomarivera has quit IRC06:01
*** gomarivera has joined #openstack-oslo06:01
*** gomarivera has quit IRC06:06
*** rcernin has joined #openstack-oslo06:10
openstackgerritOpenStack Proposal Bot proposed openstack/oslo.messaging master: Updated from global requirements  https://review.openstack.org/47053006:10
*** salv-orlando has quit IRC06:13
*** salv-orlando has joined #openstack-oslo06:13
*** salv-orlando has quit IRC06:17
*** pcaruana has joined #openstack-oslo06:39
*** jaosorior is now known as jaosorior_away06:41
*** yamamoto has quit IRC06:46
*** yamamoto has joined #openstack-oslo06:47
*** yamahata has joined #openstack-oslo06:47
*** mmasaki has quit IRC06:48
*** amrith has quit IRC06:48
*** mmasaki has joined #openstack-oslo06:49
*** amrith has joined #openstack-oslo06:49
*** salv-orlando has joined #openstack-oslo07:01
*** aarefiev has joined #openstack-oslo07:03
openstackgerritMerged openstack/oslo.messaging master: deprecated blocking executor  https://review.openstack.org/46980507:04
*** eliqiao has quit IRC07:09
*** eliqiao has joined #openstack-oslo07:10
*** tesseract has joined #openstack-oslo07:13
openstackgerritlan proposed openstack/oslo.db master: Using assertIsNone(xxx) instead of assertEqual(None, xxx)  https://review.openstack.org/47118107:22
*** yamahata has quit IRC07:23
*** salv-orl_ has joined #openstack-oslo07:28
openstackgerritVu Cong Tuan proposed openstack/osprofiler master: Replace oslo.messaging.get_transport with get_notification_transport  https://review.openstack.org/47123207:29
*** salv-orlando has quit IRC07:31
*** nicolasbock has joined #openstack-oslo07:31
*** fnordahl has quit IRC07:32
*** fnordahl has joined #openstack-oslo07:39
*** oanson_ has joined #openstack-oslo07:42
*** oanson_ has quit IRC07:50
*** zzzeek has quit IRC08:00
*** zzzeek has joined #openstack-oslo08:00
*** links has quit IRC08:02
*** gomarivera has joined #openstack-oslo08:02
*** gomarivera has quit IRC08:07
openstackgerritChangBo Guo(gcb) proposed openstack/oslo.messaging master: Fix rabbitmq driver with blocking executor  https://review.openstack.org/46980608:11
*** e0ne has joined #openstack-oslo08:13
openstackgerritLingyong Xu proposed openstack/oslo.utils master: Replace oslo_utils.timeutils.isotime  https://review.openstack.org/46977708:17
*** links has joined #openstack-oslo08:19
*** lucas-afk is now known as lucasagomes08:26
*** hoonetorg has quit IRC08:51
*** oanson_ has joined #openstack-oslo08:51
*** jaosorior_away is now known as jaosorior08:53
*** nicolasbock has quit IRC09:03
*** jaosorior has quit IRC09:04
*** hoonetorg has joined #openstack-oslo09:09
*** sambetts|afk is now known as sambetts09:24
*** links has quit IRC09:25
openstackgerritLingyong Xu proposed openstack/oslo.utils master: Replace oslo_utils.timeutils.isotime  https://review.openstack.org/46977709:27
*** links has joined #openstack-oslo09:42
*** sdague has joined #openstack-oslo09:44
openstackgerritMerged openstack/oslo.messaging master: Updated from global requirements  https://review.openstack.org/47053009:46
*** shardy has joined #openstack-oslo09:55
*** oanson_ has quit IRC09:55
*** cdent has joined #openstack-oslo09:57
*** lpetrut has joined #openstack-oslo10:03
*** jamielennox is now known as jamielennox|away10:10
*** tovin07_ has quit IRC10:11
*** jamielennox|away is now known as jamielennox10:16
*** purplerbot has quit IRC10:33
*** purplerbot has joined #openstack-oslo10:33
*** boden has joined #openstack-oslo10:34
*** nicolasbock has joined #openstack-oslo10:44
*** yamamoto has quit IRC10:52
*** raildo has joined #openstack-oslo10:52
*** salv-orl_ has quit IRC11:16
*** lucasagomes is now known as lucas-hungry11:16
*** shardy is now known as shardy_afk11:21
*** ansmith has quit IRC11:23
*** rcernin has quit IRC11:52
*** pcaruana has quit IRC11:53
*** jaosorior has joined #openstack-oslo11:56
*** yamamoto has joined #openstack-oslo11:56
*** rcernin has joined #openstack-oslo12:07
*** pcaruana has joined #openstack-oslo12:09
*** shardy_afk is now known as shardy12:10
*** dave-mccowan has joined #openstack-oslo12:15
*** lucas-hungry is now known as lucasagomes12:16
*** yamamoto has quit IRC12:21
*** MVenesio has joined #openstack-oslo12:27
*** ansmith has joined #openstack-oslo12:32
*** yamamoto has joined #openstack-oslo12:38
*** gordc has joined #openstack-oslo12:39
*** links has quit IRC12:56
*** eck`gone is now known as eck`13:06
*** ihrachys has joined #openstack-oslo13:09
*** yamamoto has quit IRC13:10
*** yamamoto has joined #openstack-oslo13:11
*** gomarivera has joined #openstack-oslo13:17
*** yamamoto has quit IRC13:21
*** yamamoto has joined #openstack-oslo13:23
*** gomarivera has quit IRC13:30
*** eck` is now known as eck`gone13:30
*** eck`gone has quit IRC13:31
*** eck`gone has joined #openstack-oslo13:32
*** eck`gone is now known as eck`13:32
*** pcaruana has quit IRC13:34
*** rcernin has quit IRC13:36
*** zz_dimtruck is now known as dimtruck13:41
*** rcernin has joined #openstack-oslo13:49
*** pcaruana has joined #openstack-oslo13:51
*** janzian has joined #openstack-oslo13:55
*** pcaruana has quit IRC13:59
*** pcaruana has joined #openstack-oslo14:00
*** salv-orlando has joined #openstack-oslo14:04
*** rcernin has quit IRC14:04
*** rcernin has joined #openstack-oslo14:05
*** rcernin has quit IRC14:07
*** rcernin has joined #openstack-oslo14:07
*** links has joined #openstack-oslo14:12
*** links has quit IRC14:17
*** MVenesio has quit IRC14:25
*** hongbin has joined #openstack-oslo14:28
*** ihrachys is now known as ihrachys|afk14:31
zzzeekis there any way when folks are looking to be useful w/ micro-patches like https://review.openstack.org/#/c/471181/, they could come around and ask how they might be useful to us?  b.c. i can think of some oslo.db things that are more important than this14:43
*** rcernin has quit IRC14:54
*** yamamoto has quit IRC14:55
*** dimtruck is now known as zz_dimtruck14:58
*** salv-orlando has quit IRC14:59
*** salv-orlando has joined #openstack-oslo15:00
*** salv-orlando has quit IRC15:04
*** gomarivera has joined #openstack-oslo15:05
*** aselius has joined #openstack-oslo15:15
*** gomarivera has quit IRC15:22
*** gomarivera has joined #openstack-oslo15:22
*** e0ne has quit IRC15:32
openstackgerritBalazs Gibizer proposed openstack/oslo.versionedobjects master: Fixed JSONSchema Enum and IPV4AndV6Address  https://review.openstack.org/41911415:39
*** jaosorior is now known as jaosorior_away15:47
*** lucasagomes is now known as lucas-afk15:58
*** ihrachys|afk is now known as ihrachys16:01
*** dfisher has joined #openstack-oslo16:13
*** yamahata has joined #openstack-oslo16:15
*** yamamoto has joined #openstack-oslo16:26
*** jamielennox is now known as jamielennox|away16:26
*** dfisher has left #openstack-oslo16:26
*** yamamoto has quit IRC16:31
*** tesseract has quit IRC16:32
*** mriedem has joined #openstack-oslo16:32
mriedemis there a way for nova to override oslo_messaging_notifications.driver for unit tests using the oslo_messaging.conffixture?16:33
mriedemi've tried something like this http://paste.openstack.org/show/611533/16:33
mriedembut that doesn't work16:33
mriedemwhere self.notification_drivers = ['noop']16:33
mriedemi see that ConfFixture.transport_driver is a property on the fixture, would i need to do similar for something like notification_drivers?16:34
*** pcaruana has quit IRC16:34
*** lpetrut has quit IRC16:36
dimsmriedem : nova seems to be fixing up transport_driver already (http://git.openstack.org/cgit/openstack/nova/tree/nova/tests/fixtures.py#n686) wanna add the notification_driver there too?16:37
mriedemdims: but transport_driver is already a property on the messaging ConfFixture16:38
mriedemhttps://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/conffixture.py#L12616:39
mriedemsimilar thing for notification_driver(s) doesn't exist16:39
mriedemthat's why i'm wondering if i'd have to add that to the ConfFixture,16:39
mriedemor if there is another way16:39
dimsah looks like we need to add that16:39
dimsmriedem : neutron seems to be doing another way http://codesearch.openstack.org/?q=notification_driver.*fake&i=nope&files=&repos=16:40
mriedemnova also has a fake notifier, so it could be i'm doing the fixture in the wrong place16:42
mriedemgibi: have you ever figured out a way to configure oslo.messaging for the noop notification driver during nova unit tests?16:43
mriedemi'm trying to test NOTIFIER.is_enabled without using mock,16:43
mriedemi.e. i'd like to actually configure oslo.messaging to use the noop notifier16:44
gibimriedem: I think the reason I went with a mock in the original unit test is that it seemed easier16:45
mriedemyeah i'm doing mock on is_enabled too16:45
mriedembut i don't feel good about it16:46
gibilet me check how this was tested on oslo.messaging side16:46
gibihttps://review.openstack.org/#/c/441221/1/oslo_messaging/tests/notify/test_notifier.py16:47
gibibut I guess it doesn't in the nova case16:48
gibimriedem: do you want to setup the unit test in a way that you have a real, but noop notifier? Do you want to add some notification client that assert that there is no notification on the rpc?16:50
gibias far as I know we don't have a notification client in nova16:52
mriedemi'm writing a test for https://review.openstack.org/#/c/459923/23/nova/notifications/base.py@22016:53
*** ihrachys is now known as ihrachys|afk16:54
*** ihrachys|afk is now known as ihrachys16:55
gibimriedem: I think these tests are ensures that the decoratore is noop if notification is not enabled https://review.openstack.org/#/c/428260/7/nova/tests/unit/test_rpc.py16:55
gibiand NOTIFIER.is_enabled is verified on oslo side16:55
mriedemi just did https://review.openstack.org/#/c/459923/24/nova/tests/unit/notifications/test_base.py16:56
gibimriedem: I think the generic test cases I linked above I covering your case16:58
gibimriedem: except that you want to avoid mocking the is_enabled16:58
gibimriedem: https://review.openstack.org/#/c/428260/7/nova/tests/unit/test_rpc.py@545 seems functionally equivalent with https://review.openstack.org/#/c/459923/24/nova/tests/unit/notifications/test_base.py@5817:00
mriedemgibi: it doesn't test that the decorator is used on that one method though, which was the point of my test17:01
mriedemanyway...17:01
mriedemi'm giving up on it for now17:01
gibimriedem: ohh I see, so you want to see that the decorator is placed on the function17:01
mriedemyes17:02
mriedemso dims doesn't remove it in a year during some crazy dims refactor frenzy17:02
gibimriedem: OK, that make sense17:02
*** zz_dimtruck is now known as dimtruck17:02
dimsLOL17:03
*** jamielennox|away is now known as jamielennox17:05
*** kgiusti has quit IRC17:08
*** jlvillal is now known as jlvacation17:10
*** sambetts is now known as sambetts|afk17:16
*** mriedem has left #openstack-oslo17:35
*** nicolasbock has quit IRC17:41
*** nicolasbock has joined #openstack-oslo17:42
*** yamamoto has joined #openstack-oslo18:29
*** cdent has quit IRC18:31
*** yamamoto has quit IRC18:34
*** mordred has quit IRC18:47
*** mordred has joined #openstack-oslo18:48
*** pcaruana has joined #openstack-oslo18:56
*** salv-orlando has joined #openstack-oslo19:03
*** mriedem has joined #openstack-oslo19:03
mriedemdhellmann: i think there is a problem with the error summary stuff in oslo.log tha went into 3.2819:03
mriedemwe're seeing ": NotImplementedError" showing up at the end of log messages which aren't for errors in n-cpu19:04
mriedemhttp://logs.openstack.org/82/471082/1/gate/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/796acb7/logs/screen-n-cpu.txt.gz#_Jun_06_13_14_02_21087919:04
mriedemthat's the wrong one19:04
mriedemhttp://logs.openstack.org/82/471082/1/gate/gate-novaclient-dsvm-functional-neutron-ubuntu-xenial/796acb7/logs/screen-n-cpu.txt.gz#_Jun_06_13_14_02_59429219:04
mriedem"Shutting down instance from state 1: NotImplementedError"19:04
mriedemhttps://bugs.launchpad.net/oslo.log/+bug/169621319:09
openstackLaunchpad bug 1696213 in oslo.log "error summary formatter is putting ": NotImplementedError" in non-error log messages" [Undecided,New]19:09
*** harlowja has quit IRC19:29
*** yamamoto has joined #openstack-oslo19:31
dhellmannmriedem : we found that python 2 does not clear sys.exc_info() if an exception is raised and caught during module import. Could that be the case here?19:32
dhellmannwe could add NotImplementedError to the set of exceptions that are ignored by default19:32
*** pcaruana has quit IRC19:33
mriedemwas that ihar's recent change?19:36
mriedemfor ImportError?19:36
dhellmannyeah19:36
dhellmannthat doesn't seem to be the issue here, though19:36
dhellmannI'm looking for the patchset19:36
mriedemi don't know where the NotImplementedError is coming from19:36
*** yamamoto has quit IRC19:36
dhellmannmy line numbers don't match what's in the log there19:36
mriedemyeah b/c something merged19:37
mriedemin the bug report i noted it's coming from https://github.com/openstack/nova/blob/e01ae75d52900d96355dfcb39ef9b136f0c0d5c4/nova/virt/libvirt/driver.py#L252019:37
dhellmannyeah19:37
mriedembut it's really all over the nova-compute logs19:37
dhellmannoh, I see the "direct_snapshot() is not implemented" messages now19:38
dhellmannin driver.py I see direct_snapshot() called in the snapshot() method, and that NotImplementedError is caught and handled with a bunch of logic19:40
dhellmannI imagine some of the log messages are coming from there19:40
dhellmannthere are a couple of ways to handle this, I think19:40
dhellmannwe could add a sys.exc_clear() call in the exception handler19:41
dhellmannwe could add NotImplementedError as an ignored exception19:41
dhellmann(those aren't mutually exclusive)19:41
* dhellmann thinks19:41
mriedemyeah nova has some flow control for NotImplementedError unfortunately19:42
dhellmannwe could also change oslo.log so the first time it sees an exception it logs it, and later it doesn't19:42
mriedemi tried to clean that up once but it was a mess19:42
dhellmannwe could cache just the id() value to keep it manageable19:43
dhellmannand maybe use an lru cache with a fixed limit so we don't have a memory issue19:43
dhellmannthat feels a bit complicated, though19:43
dhellmannand I thought it would be useful to have the error message attached to the log messages associated with the cleanup, too19:43
dhellmannso I'm not sure I like the idea, but it's an option19:43
dhellmannmriedem : if we ignore NotImplementedError, what happens if one of those other errors, like Forbidden, happens? we'd see the same error repeated for those cleanup calls19:44
dhellmannwould that be more ok?19:44
dhellmanni.e., is it the error type that makes this ugly, or the repetition in general?19:44
mriedemthe repetition firstly19:46
mriedemsince it's all over the logs19:46
dhellmannok19:46
mriedem73 matches on ": NotImplementedError" in there19:46
dhellmannso then the question is should we only log exceptions at warning or error level? or should we log at any level but only one time?19:47
dhellmannmaybe I'll try the first way, since I think that would be easier to implement19:48
*** harlowja has joined #openstack-oslo19:50
dhellmannafter the tc meeting, though19:50
mriedemmaybe i can somehow work this into the postgresql discussion19:51
mriedemand just totally derail everything19:51
dhellmannoh, please do19:52
*** cdent has joined #openstack-oslo19:58
*** shardy has quit IRC20:05
*** salv-orl_ has joined #openstack-oslo20:06
*** salv-orlando has quit IRC20:08
*** eck` is now known as eck`gone20:18
*** kgiusti has joined #openstack-oslo20:22
*** raildo has quit IRC20:32
*** yamamoto has joined #openstack-oslo20:32
*** jamielennox has quit IRC20:34
*** nicolasbock has quit IRC20:35
*** yamamoto has quit IRC20:37
*** jamielennox has joined #openstack-oslo20:38
*** eck`gone is now known as eck`21:02
*** dave-mccowan has quit IRC21:06
*** ansmith has quit IRC21:06
*** mriedem has left #openstack-oslo21:24
*** yamamoto has joined #openstack-oslo21:33
*** yamamoto has quit IRC21:37
*** gordc has quit IRC21:45
*** gomarivera has quit IRC21:57
*** gomarivera has joined #openstack-oslo21:58
*** dimtruck is now known as zz_dimtruck21:59
*** gomarivera has quit IRC22:02
*** sdague has quit IRC22:18
*** boden has quit IRC22:19
*** lbragstad has quit IRC22:30
*** yamamoto_ has joined #openstack-oslo22:34
*** yamamoto_ has quit IRC22:40
*** gomarivera has joined #openstack-oslo22:43
*** gomarivera has quit IRC22:47
*** hongbin has quit IRC22:59
*** cdent has quit IRC23:03
*** yamamoto_ has joined #openstack-oslo23:36
*** yamamoto_ has quit IRC23:42
*** janzian has quit IRC23:43
*** zz_dimtruck is now known as dimtruck23:58
« Monday, 2017-06-05 Index Wednesday, 2017-06-07 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!