| *** salv-orlando has joined #openstack-oslo | 00:30 | |
| *** oanson has quit IRC | 00:34 | |
| *** salv-orlando has quit IRC | 00:35 | |
| *** dave-mcc_ has joined #openstack-oslo | 00:37 | |
| *** oanson has joined #openstack-oslo | 00:42 | |
| *** kiseok7 has joined #openstack-oslo | 01:05 | |
| *** dave-mcc_ has quit IRC | 01:23 | |
| *** salv-orlando has joined #openstack-oslo | 01:31 | |
| *** salv-orlando has quit IRC | 01:36 | |
| *** cfriesen has joined #openstack-oslo | 01:54 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/pycadf master: Updated from global requirements https://review.openstack.org/470137 | 01:59 |
|---|---|---|
| *** dave-mccowan has joined #openstack-oslo | 02:00 | |
| openstackgerrit | IWAMOTO Toshihiro proposed openstack/oslo.rootwrap master: Protect rootwrap daemon socket against multiple threads https://review.openstack.org/514547 | 02:00 |
| *** salv-orlando has joined #openstack-oslo | 02:32 | |
| *** cfriesen has quit IRC | 02:35 | |
| *** salv-orlando has quit IRC | 02:37 | |
| *** cfriesen has joined #openstack-oslo | 02:42 | |
| *** dave-mccowan has quit IRC | 02:46 | |
| *** daidv has joined #openstack-oslo | 02:46 | |
| *** dave-mccowan has joined #openstack-oslo | 02:54 | |
| *** shardy has joined #openstack-oslo | 02:58 | |
| *** yamamoto has joined #openstack-oslo | 03:03 | |
| *** d0ugal has quit IRC | 03:14 | |
| *** namnh has joined #openstack-oslo | 03:14 | |
| *** dave-mccowan has quit IRC | 03:18 | |
| *** shardy has quit IRC | 03:21 | |
| *** cfriesen has quit IRC | 03:22 | |
| *** cfriesen has joined #openstack-oslo | 03:27 | |
| *** dave-mccowan has joined #openstack-oslo | 03:30 | |
| *** dave-mccowan has quit IRC | 03:58 | |
| *** pooja_jadhav has joined #openstack-oslo | 03:58 | |
| *** pooja-jadhav has joined #openstack-oslo | 03:58 | |
| *** dave-mccowan has joined #openstack-oslo | 04:03 | |
| *** cfriesen has quit IRC | 04:07 | |
| *** cfriesen has joined #openstack-oslo | 04:13 | |
| *** salv-orlando has joined #openstack-oslo | 04:34 | |
| *** salv-orlando has quit IRC | 04:38 | |
| *** jbadiapa_ has quit IRC | 04:41 | |
| *** gcb has joined #openstack-oslo | 04:43 | |
| *** cfriesen has quit IRC | 04:55 | |
| *** dave-mccowan has quit IRC | 04:56 | |
| openstackgerrit | Merged openstack/oslo.messaging master: Remove stable/newton from zuul settings https://review.openstack.org/516185 | 04:59 |
| *** gcb has quit IRC | 05:04 | |
| *** dave-mccowan has joined #openstack-oslo | 05:12 | |
| *** gcb has joined #openstack-oslo | 05:18 | |
| *** jaosorior has joined #openstack-oslo | 05:27 | |
| *** gcb has quit IRC | 05:51 | |
| *** yamamoto_ has joined #openstack-oslo | 06:09 | |
| *** salv-orlando has joined #openstack-oslo | 06:10 | |
| *** dave-mccowan has quit IRC | 06:12 | |
| *** purplerbot has quit IRC | 06:13 | |
| *** purplerbot_ has joined #openstack-oslo | 06:13 | |
| *** purplerbot_ is now known as purplerbot__ | 06:13 | |
| *** purplerbot__ is now known as purplerbot | 06:13 | |
| *** yamamoto has quit IRC | 06:14 | |
| *** aspiers has quit IRC | 06:14 | |
| *** clayton has quit IRC | 06:14 | |
| *** clayton has joined #openstack-oslo | 06:14 | |
| *** aspiers has joined #openstack-oslo | 06:19 | |
| *** pooja-jadhav has quit IRC | 06:25 | |
| *** openstackgerrit has quit IRC | 06:31 | |
| *** zzzeek has quit IRC | 06:31 | |
| *** john51 has quit IRC | 06:31 | |
| *** toabctl has quit IRC | 06:31 | |
| *** john51 has joined #openstack-oslo | 06:32 | |
| *** jbadiapa has joined #openstack-oslo | 06:34 | |
| *** d0ugal has joined #openstack-oslo | 06:38 | |
| *** pooja_jadhav has quit IRC | 07:08 | |
| *** spectr has joined #openstack-oslo | 07:09 | |
| *** openstackgerrit has joined #openstack-oslo | 07:12 | |
| *** zzzeek has joined #openstack-oslo | 07:12 | |
| *** toabctl has joined #openstack-oslo | 07:12 | |
| *** john51 has quit IRC | 07:14 | |
| *** john51 has joined #openstack-oslo | 07:19 | |
| *** pcaruana has joined #openstack-oslo | 07:47 | |
| *** salv-orlando has quit IRC | 07:57 | |
| *** salv-orlando has joined #openstack-oslo | 07:58 | |
| *** salv-orlando has quit IRC | 08:02 | |
| *** e0ne has joined #openstack-oslo | 08:08 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Add option to use JSON formatter https://review.openstack.org/517882 | 08:13 |
| jaosorior | Tengu: this is what I have so far ^^ gotta add some tests and such | 08:13 |
| Tengu | reading it right now :). Seems pretty simple in the end. Easier than the "long fastidious way" I proposed with the complete logging.conf file. | 08:14 |
| jaosorior | Tengu: haha I never said it was fastidious | 08:15 |
| Tengu | nope, but it is ;) | 08:15 |
| *** ralonsoh has joined #openstack-oslo | 08:16 | |
| *** tesseract has joined #openstack-oslo | 08:17 | |
| Tengu | jaosorior: apparently oslo.log will require some changes for its JSON output, as it might cause issues when we feed them to an ELK: the multi-line shouldn't be in a "list" format, more as a "string" with "\n" printed in it :/. | 08:19 |
| Tengu | jaosorior: not directly related to your proposal of course. | 08:19 |
| Tengu | the list issue is a bit more annoying, because one can argue "not valid json", and it's true. but also too dogmatic. anyway. will see how to get something clean on that one, might request a new configuration parameter for that specific part. | 08:20 |
| Tengu | something like json_multiline = list // string | 08:20 |
| jaosorior | Tengu: we could probably fix that though | 08:20 |
| jaosorior | right, could be one or several configuration options | 08:21 |
| jaosorior | maybe just having a enable_elk_friendly_json or something of the sort | 08:21 |
| Tengu | I can open an issue for that. | 08:21 |
| Tengu | jaosorior: checking with a colleague if other things might create issues in an ELK, and I'll open an issue in oslo.log project for that. | 08:23 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Add option to use JSON formatter https://review.openstack.org/517882 | 08:29 |
| *** AlexeyAbashkin has joined #openstack-oslo | 08:33 | |
| *** AlexeyAbashkin has quit IRC | 08:51 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 08:51 | |
| *** salv-orlando has joined #openstack-oslo | 08:57 | |
| *** yamamoto_ has quit IRC | 09:06 | |
| *** lucas-afk is now known as lucasagomes | 09:07 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Use retrieved context instead of entry in the record's 'extra' https://review.openstack.org/517894 | 09:12 |
| jaosorior | Tengu: seems we need that too ^^ | 09:12 |
| jaosorior | Tengu: on top of those we can start enabling/disabling things to make it ELK friendly | 09:13 |
| Tengu | ah, cool ! | 09:13 |
| Tengu | as said we'll check what the ELK complains about and create an issue with those information so that we're complete. | 09:14 |
| jaosorior | Tengu: so, one of them, as you told me, was the stacktrace being a list, we can change that, let me know what other changes are needed when you can | 09:14 |
| jaosorior | Tengu: ah, great great | 09:14 |
| Tengu | :) | 09:14 |
| *** openstackgerrit has quit IRC | 09:18 | |
| *** pblaho has joined #openstack-oslo | 09:19 | |
| *** openstackgerrit has joined #openstack-oslo | 09:19 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Use retrieved context instead of entry in the record's 'extra' https://review.openstack.org/517894 | 09:19 |
| *** dansmith has quit IRC | 09:39 | |
| *** dansmith has joined #openstack-oslo | 09:40 | |
| *** dansmith is now known as Guest17053 | 09:40 | |
| *** lpetrut has joined #openstack-oslo | 09:41 | |
| *** AlexeyAbashkin has quit IRC | 10:00 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 10:02 | |
| *** pblaho has quit IRC | 10:03 | |
| *** namnh has quit IRC | 10:05 | |
| *** yamamoto has joined #openstack-oslo | 10:06 | |
| *** AlexeyAbashkin has quit IRC | 10:06 | |
| *** yamamoto has quit IRC | 10:15 | |
| *** yamamoto has joined #openstack-oslo | 10:21 | |
| *** yamamoto has quit IRC | 10:29 | |
| *** yamamoto has joined #openstack-oslo | 10:40 | |
| *** pblaho has joined #openstack-oslo | 10:46 | |
| *** pblaho has quit IRC | 10:51 | |
| *** yamamoto has quit IRC | 11:00 | |
| *** pblaho has joined #openstack-oslo | 11:04 | |
| *** pbourke has quit IRC | 11:04 | |
| *** pblaho has quit IRC | 11:06 | |
| *** pblaho has joined #openstack-oslo | 11:06 | |
| *** pbourke has joined #openstack-oslo | 11:06 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 11:06 | |
| *** yamamoto has joined #openstack-oslo | 11:19 | |
| *** sdague has joined #openstack-oslo | 11:29 | |
| *** hoonetorg has quit IRC | 11:32 | |
| *** hoonetorg has joined #openstack-oslo | 11:48 | |
| *** AlexeyAbashkin has quit IRC | 11:52 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 11:55 | |
| *** salv-orlando has quit IRC | 11:56 | |
| *** salv-orlando has joined #openstack-oslo | 11:56 | |
| *** AlexeyAbashkin has quit IRC | 12:00 | |
| *** salv-orlando has quit IRC | 12:01 | |
| *** raildo has joined #openstack-oslo | 12:02 | |
| *** nicolasbock has joined #openstack-oslo | 12:07 | |
| *** pooja_jadhav has joined #openstack-oslo | 12:10 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 12:13 | |
| *** lucasagomes is now known as lucas-hungry | 12:16 | |
| *** yamamoto has quit IRC | 12:17 | |
| *** ansmith has quit IRC | 12:19 | |
| *** salv-orlando has joined #openstack-oslo | 12:24 | |
| *** AlexeyAbashkin has quit IRC | 12:34 | |
| *** pblaho has quit IRC | 12:43 | |
| openstackgerrit | Merged openstack/tooz master: Zuul: add file extension to playbook path https://review.openstack.org/516114 | 12:48 |
| *** gordc has joined #openstack-oslo | 12:52 | |
| *** eck`gone is now known as eck` | 12:58 | |
| *** salv-orlando has quit IRC | 13:01 | |
| *** salv-orlando has joined #openstack-oslo | 13:01 | |
| *** salv-orlando has quit IRC | 13:05 | |
| *** catintheroof has joined #openstack-oslo | 13:06 | |
| *** pcaruana has quit IRC | 13:08 | |
| *** pblaho has joined #openstack-oslo | 13:11 | |
| *** catintheroof has quit IRC | 13:12 | |
| *** lucas-hungry is now known as lucasagomes | 13:14 | |
| *** catintheroof has joined #openstack-oslo | 13:14 | |
| *** yamamoto has joined #openstack-oslo | 13:18 | |
| *** pcaruana has joined #openstack-oslo | 13:20 | |
| *** geekinutah has quit IRC | 13:23 | |
| *** samueldmq has quit IRC | 13:23 | |
| *** geekinutah has joined #openstack-oslo | 13:24 | |
| *** samueldmq has joined #openstack-oslo | 13:24 | |
| *** yamamoto has quit IRC | 13:27 | |
| *** jaosorior has quit IRC | 13:40 | |
| *** jaosorior has joined #openstack-oslo | 13:42 | |
| *** kgiusti has joined #openstack-oslo | 13:43 | |
| *** salv-orlando has joined #openstack-oslo | 13:45 | |
| *** ansmith has joined #openstack-oslo | 13:47 | |
| *** janzian has joined #openstack-oslo | 13:51 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 14:02 | |
| *** pcaruana has quit IRC | 14:05 | |
| *** AlexeyAbashkin has quit IRC | 14:16 | |
| *** pcaruana has joined #openstack-oslo | 14:17 | |
| openstackgerrit | Merged openstack/devstack-plugin-amqp1 master: Move project specific tests in repo https://review.openstack.org/517092 | 14:18 |
| *** spectr has quit IRC | 14:29 | |
| *** nug- is now known as cFouts | 14:30 | |
| *** spectr has joined #openstack-oslo | 14:30 | |
| *** spilla has joined #openstack-oslo | 14:41 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 14:51 | |
| *** d0ugal has quit IRC | 15:08 | |
| *** AlexeyAbashkin has quit IRC | 15:15 | |
| *** d0ugal has joined #openstack-oslo | 15:33 | |
| *** d0ugal has quit IRC | 15:34 | |
| *** d0ugal has joined #openstack-oslo | 15:34 | |
| *** kmalloc has joined #openstack-oslo | 15:37 | |
| jaosorior | bnemec: hey, could you check this out https://review.openstack.org/#/c/517882/ ? | 15:43 |
| bnemec | jaosorior: Can you add a unit test to verify that the output is JSON formatted? | 15:49 |
| bnemec | Otherwise lgtm. | 15:49 |
| *** salv-orlando has quit IRC | 15:54 | |
| *** salv-orlando has joined #openstack-oslo | 15:55 | |
| jaosorior | bnemec: sure.... uhm... where would that go? | 15:55 |
| jaosorior | bnemec: there is a unit test that checks the JSON formatter itself | 15:56 |
| bnemec | jaosorior: I'm thinking something like https://github.com/openstack/oslo.log/blob/master/oslo_log/tests/unit/test_log.py#L617 | 15:58 |
| bnemec | Except do a self.config(use_json=True), log a message, then assert that the log output is JSON. | 15:58 |
| *** salv-orlando has quit IRC | 15:59 | |
| bnemec | jaosorior: And not testing everything that class does. I just used that as an example since it seems to have test cases that do something similar. | 15:59 |
| jaosorior | bnemec: soo... it's not as trivial. The syslog and journal handles mock the calls to the backends. and the contextformatter test that you linked doesn't use the setup function which actually reads configurations | 16:06 |
| jaosorior | if I want to test that I can set the handler myself, I'll end up replicating this test https://github.com/openstack/oslo.log/blob/master/oslo_log/tests/unit/test_log.py#L410 | 16:06 |
| jaosorior | which actually tests if there's JSON output | 16:07 |
| *** Guest30702 has quit IRC | 16:15 | |
| bnemec | jaosorior: Okay, what about this: https://github.com/openstack/oslo.log/blob/master/oslo_log/tests/unit/test_log.py#L1548 ? | 16:16 |
| jaosorior | bnemec: I hadn't found that one, great | 16:17 |
| bnemec | I'm just looking for something to hit that code path in the unit tests so we don't accidentally break it in the future if we refactor the logic or something. | 16:17 |
| *** aselius has joined #openstack-oslo | 16:18 | |
| *** catintheroof has quit IRC | 16:19 | |
| jaosorior | bnemec: I understand. trust me, I want this tested as well :D just didn't know how | 16:20 |
| bnemec | jaosorior: Yeah, a lot of times figuring out the best way to test the code takes longer than actually writing it. :-) | 16:22 |
| *** ralonsoh has quit IRC | 16:25 | |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Add option to use JSON formatter https://review.openstack.org/517882 | 16:27 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Use retrieved context instead of entry in the record's 'extra' https://review.openstack.org/517894 | 16:27 |
| jaosorior | bnemec: what about this? ^^ | 16:27 |
| bnemec | jaosorior: Did you mean to leave the stuff at line 526 in test_log? I'm a little confused by it since that output looks like not JSON. | 16:51 |
| jaosorior | bnemec: I didn't | 16:52 |
| jaosorior | that was a previous attempt that didn't work | 16:52 |
| bnemec | jaosorior: Okay, I thought maybe that's what happened. :-) | 16:52 |
| bnemec | The other new test lgtm though. | 16:52 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Add option to use JSON formatter https://review.openstack.org/517882 | 16:53 |
| openstackgerrit | Juan Antonio Osorio Robles proposed openstack/oslo.log master: Use retrieved context instead of entry in the record's 'extra' https://review.openstack.org/517894 | 16:53 |
| *** salv-orlando has joined #openstack-oslo | 16:56 | |
| *** salv-orlando has quit IRC | 17:00 | |
| *** janzian has quit IRC | 17:00 | |
| *** pcaruana has quit IRC | 17:01 | |
| *** e0ne has quit IRC | 17:05 | |
| *** tesseract has quit IRC | 17:10 | |
| *** catintheroof has joined #openstack-oslo | 17:12 | |
| *** rmascena has joined #openstack-oslo | 17:13 | |
| *** raildo has quit IRC | 17:14 | |
| *** catintheroof has quit IRC | 17:17 | |
| *** janzian has joined #openstack-oslo | 17:18 | |
| *** lucasagomes is now known as lucas-afk | 17:27 | |
| *** miqui has joined #openstack-oslo | 17:28 | |
| *** catintheroof has joined #openstack-oslo | 17:37 | |
| *** catintheroof has quit IRC | 17:41 | |
| jaosorior | bnemec: thanks! | 17:42 |
| bnemec | jaosorior: np, thanks for doing the implementation on this! | 17:43 |
| jaosorior | bnemec: I might poke you for this one https://review.openstack.org/#/c/517894/4 soon but first I want some feedback. | 17:45 |
| *** e0ne has joined #openstack-oslo | 17:51 | |
| *** lpetrut has quit IRC | 17:53 | |
| *** catintheroof has joined #openstack-oslo | 17:56 | |
| *** e0ne has quit IRC | 17:56 | |
| *** salv-orlando has joined #openstack-oslo | 17:58 | |
| *** e0ne has joined #openstack-oslo | 17:59 | |
| *** rmascena has quit IRC | 18:04 | |
| *** raildo has joined #openstack-oslo | 18:04 | |
| *** harlowja has joined #openstack-oslo | 18:19 | |
| *** lpetrut has joined #openstack-oslo | 19:00 | |
| *** ihrachys_ has joined #openstack-oslo | 19:06 | |
| *** pooja-jadhav has joined #openstack-oslo | 19:07 | |
| *** ihrachys_ has quit IRC | 19:07 | |
| *** ihrachys has quit IRC | 19:07 | |
| *** ihrachys_ has joined #openstack-oslo | 19:07 | |
| *** ihrachys_ is now known as ihrachys | 19:09 | |
| *** pooja_jadhav has quit IRC | 19:09 | |
| *** d0ugal has quit IRC | 19:52 | |
| *** e0ne has quit IRC | 19:53 | |
| *** pcaruana has joined #openstack-oslo | 19:57 | |
| *** pcaruana has quit IRC | 20:03 | |
| *** d0ugal has joined #openstack-oslo | 20:16 | |
| *** Guest17053 has quit IRC | 20:18 | |
| *** dansmith has joined #openstack-oslo | 20:20 | |
| *** dansmith is now known as Guest71388 | 20:20 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 21:00 | |
| *** AlexeyAbashkin has quit IRC | 21:04 | |
| openstackgerrit | Merged openstack/oslo.log master: Add option to use JSON formatter https://review.openstack.org/517882 | 21:19 |
| *** kgiusti has left #openstack-oslo | 21:24 | |
| *** ansmith has quit IRC | 21:35 | |
| *** dave-mccowan has joined #openstack-oslo | 21:51 | |
| *** dave-mccowan has quit IRC | 21:51 | |
| *** catintheroof has quit IRC | 21:51 | |
| *** dave-mccowan has joined #openstack-oslo | 22:01 | |
| *** dave-mcc_ has joined #openstack-oslo | 22:05 | |
| *** dave-mccowan has quit IRC | 22:06 | |
| *** janzian has quit IRC | 22:25 | |
| *** spilla has quit IRC | 22:26 | |
| *** ansmith has joined #openstack-oslo | 22:31 | |
| *** lpetrut has quit IRC | 22:56 | |
| *** dave-mcc_ has quit IRC | 22:56 | |
| *** ihrachys has quit IRC | 23:11 | |
| *** yassine has joined #openstack-oslo | 23:20 | |
| *** yassine is now known as Guest27242 | 23:20 | |
| *** ihrachys has joined #openstack-oslo | 23:22 | |
| *** salv-orlando has quit IRC | 23:31 | |
| *** salv-orlando has joined #openstack-oslo | 23:31 | |
| *** salv-orlando has quit IRC | 23:36 | |
| *** dave-mccowan has joined #openstack-oslo | 23:39 | |
| *** raildo has quit IRC | 23:55 | |
| *** gordc has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!