| *** yamamoto has joined #openstack-oslo | 00:43 | |
| *** dave-mccowan has joined #openstack-oslo | 00:46 | |
| *** yamamoto has quit IRC | 00:48 | |
| *** sakhd has quit IRC | 00:59 | |
| *** harlowja has quit IRC | 01:14 | |
| *** salv-orl_ has joined #openstack-oslo | 01:14 | |
| *** salv-orlando has quit IRC | 01:17 | |
| *** yikun has joined #openstack-oslo | 01:20 | |
| *** dkehn has joined #openstack-oslo | 01:33 | |
| *** eck` is now known as eck`gone | 01:35 | |
| *** yamamoto has joined #openstack-oslo | 01:44 | |
| *** yamamoto has quit IRC | 01:50 | |
| *** nicolasbock has quit IRC | 02:14 | |
| *** ianychoi has quit IRC | 02:35 | |
| *** eandersson has joined #openstack-oslo | 02:36 | |
| *** yamamoto has joined #openstack-oslo | 02:47 | |
| *** yamamoto has quit IRC | 02:52 | |
| *** sambetts|afk has quit IRC | 02:53 | |
| *** sambetts_ has joined #openstack-oslo | 02:54 | |
| *** dave-mccowan has quit IRC | 02:56 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/oslo.db master: Improve exponential backoff for wrap_db_retry https://review.openstack.org/527362 | 03:07 |
|---|---|---|
| *** ianychoi has joined #openstack-oslo | 03:19 | |
| *** vipul has quit IRC | 03:33 | |
| *** dikonoor has joined #openstack-oslo | 03:48 | |
| *** yamamoto has joined #openstack-oslo | 03:48 | |
| *** yamamoto has quit IRC | 03:53 | |
| *** jaosorior has joined #openstack-oslo | 04:21 | |
| *** harlowja has joined #openstack-oslo | 04:23 | |
| *** chhagarw has joined #openstack-oslo | 04:34 | |
| *** yamamoto has joined #openstack-oslo | 04:50 | |
| *** yamamoto has quit IRC | 04:55 | |
| *** d0ugal has quit IRC | 05:16 | |
| *** dikonoor has quit IRC | 05:24 | |
| *** d0ugal has joined #openstack-oslo | 05:26 | |
| *** links has joined #openstack-oslo | 05:29 | |
| *** harlowja has quit IRC | 05:35 | |
| *** yamamoto has joined #openstack-oslo | 05:52 | |
| *** yamamoto has quit IRC | 05:57 | |
| *** janzian has quit IRC | 06:01 | |
| *** dikonoor has joined #openstack-oslo | 06:18 | |
| *** dikonoor has quit IRC | 06:24 | |
| *** jhesketh_ is now known as jhesketh | 06:29 | |
| *** yamamoto has joined #openstack-oslo | 06:53 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 06:54 | |
| *** AlexeyAbashkin has quit IRC | 06:55 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 06:56 | |
| *** AlexeyAbashkin has quit IRC | 06:57 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 06:57 | |
| *** yamamoto has quit IRC | 06:59 | |
| *** rcernin has quit IRC | 07:06 | |
| *** yamamoto has joined #openstack-oslo | 07:08 | |
| *** shardy has joined #openstack-oslo | 07:14 | |
| *** tesseract has joined #openstack-oslo | 07:28 | |
| *** gcb has joined #openstack-oslo | 07:30 | |
| *** yamamoto has quit IRC | 07:49 | |
| *** lucas-afk is now known as lucasagomes | 08:11 | |
| *** pcaruana has joined #openstack-oslo | 08:13 | |
| *** yamamoto has joined #openstack-oslo | 08:13 | |
| *** yamamoto has quit IRC | 08:15 | |
| *** yamamoto has joined #openstack-oslo | 08:19 | |
| *** msimonin has joined #openstack-oslo | 08:39 | |
| *** ianychoi has quit IRC | 08:42 | |
| *** yamamoto has quit IRC | 08:54 | |
| *** yamamoto has joined #openstack-oslo | 08:56 | |
| *** yamamoto has quit IRC | 08:58 | |
| *** yamamoto has joined #openstack-oslo | 08:58 | |
| *** msimonin has quit IRC | 09:00 | |
| *** pblaho has joined #openstack-oslo | 09:08 | |
| *** lpetrut has joined #openstack-oslo | 09:16 | |
| *** msimonin has joined #openstack-oslo | 09:30 | |
| *** msimonin has quit IRC | 09:31 | |
| *** yamamoto has quit IRC | 09:43 | |
| *** yamamoto has joined #openstack-oslo | 09:44 | |
| *** AlexeyAbashkin has quit IRC | 09:44 | |
| *** ianychoi has joined #openstack-oslo | 09:46 | |
| *** msimonin has joined #openstack-oslo | 09:51 | |
| *** msimonin has quit IRC | 10:05 | |
| *** pbourke has joined #openstack-oslo | 10:14 | |
| yikun | @bnemec, https://review.openstack.org/#/c/527362/, take a look again when you have time, thanks! : ) | 10:24 |
| *** lpetrut has quit IRC | 10:27 | |
| *** lpetrut has joined #openstack-oslo | 10:30 | |
| openstackgerrit | Merged openstack/oslo.reports master: Document workaround for AccessDenied error https://review.openstack.org/558858 | 10:33 |
| *** shardy is now known as shardy_afk | 10:36 | |
| *** nicolasbock has joined #openstack-oslo | 10:37 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 10:40 | |
| openstackgerrit | Merged openstack/oslo.config master: Add bindep.txt file to prevent fallback to generic list https://review.openstack.org/554588 | 10:42 |
| *** e0ne has joined #openstack-oslo | 10:54 | |
| *** shardy_afk is now known as shardy | 11:04 | |
| *** e0ne has quit IRC | 11:04 | |
| *** ansmith has quit IRC | 11:11 | |
| *** yamamoto has quit IRC | 11:18 | |
| *** e0ne has joined #openstack-oslo | 11:20 | |
| *** yamamoto has joined #openstack-oslo | 11:25 | |
| *** sambetts_ is now known as sambetts | 11:28 | |
| *** yamamoto has quit IRC | 11:30 | |
| *** msimonin has joined #openstack-oslo | 11:32 | |
| *** msimonin has left #openstack-oslo | 11:33 | |
| *** yamamoto has joined #openstack-oslo | 11:34 | |
| *** yamamoto has quit IRC | 11:39 | |
| openstackgerrit | Nguyen Hai proposed openstack/oslo.cache master: Fix incompatible requirement https://review.openstack.org/560379 | 11:41 |
| bhagyashris | gcb: Hi, I just want to know about the spec https://docs.openstack.org/oslo.config/latest/reference/mutable.html which basically give the provision to make the conf parameter as mutable | 11:49 |
| bhagyashris | gcb: so on which basis or what are the criteria to make the conf parameter as mutable in any project | 11:50 |
| openstackgerrit | Nguyen Hai proposed openstack/oslo.cache master: Fix incompatible requirement in lower constraints https://review.openstack.org/560379 | 11:52 |
| gcb | bhagyashris: It depends on the usage of the configuration option, in generally it has benefit if we make it mutable | 11:53 |
| bhagyashris | gcb: yeah but is there any specific criteria or we can say that for this usages we can say that this parameter should be mutable | 11:56 |
| bhagyashris | gcb: is there any example ? | 11:57 |
| *** raildo has joined #openstack-oslo | 11:58 | |
| gcb | bhagyashris, check https://review.openstack.org/#/c/319203/ that's an example for Nova | 12:00 |
| gcb | just check https://review.openstack.org/#/q/owner:%22Alexis+Lee%22+status:merged which includes patches from the author of mutable config option | 12:01 |
| *** edmondsw has joined #openstack-oslo | 12:08 | |
| bhagyashris | gcb: Thank you :) | 12:11 |
| *** eck`gone is now known as eck` | 12:12 | |
| *** yamamoto has joined #openstack-oslo | 12:21 | |
| *** msimonin has joined #openstack-oslo | 12:24 | |
| *** yamamoto has quit IRC | 12:25 | |
| *** AlexeyAbashkin has quit IRC | 12:25 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 12:25 | |
| *** gcb has quit IRC | 12:27 | |
| *** AlexeyAbashkin has quit IRC | 12:30 | |
| *** eck` is now known as eck`gone | 12:31 | |
| *** spilla has joined #openstack-oslo | 12:33 | |
| *** yamamoto has joined #openstack-oslo | 12:34 | |
| *** AlexeyAbashkin has joined #openstack-oslo | 12:34 | |
| *** dave-mccowan has joined #openstack-oslo | 12:35 | |
| *** salv-orl_ has quit IRC | 12:54 | |
| *** kgiusti has joined #openstack-oslo | 12:55 | |
| *** ansmith has joined #openstack-oslo | 12:57 | |
| openstackgerrit | Raildo Mascena proposed openstack/oslo.config master: Base class for a configuration driver https://review.openstack.org/560027 | 13:01 |
| *** bobh has joined #openstack-oslo | 13:01 | |
| *** eck`gone is now known as eck` | 13:08 | |
| *** ansmith has quit IRC | 13:32 | |
| *** gcb has joined #openstack-oslo | 13:33 | |
| *** pblaho has quit IRC | 13:35 | |
| *** msimonin has quit IRC | 13:38 | |
| *** msimonin has joined #openstack-oslo | 13:38 | |
| *** ansmith has joined #openstack-oslo | 13:38 | |
| *** msimonin has quit IRC | 13:39 | |
| *** msimonin has joined #openstack-oslo | 13:42 | |
| *** janzian has joined #openstack-oslo | 13:51 | |
| *** msimonin has quit IRC | 13:53 | |
| *** ttx has quit IRC | 13:55 | |
| *** ttx has joined #openstack-oslo | 13:57 | |
| *** links has quit IRC | 13:58 | |
| *** msimonin has joined #openstack-oslo | 14:01 | |
| *** daidv has joined #openstack-oslo | 14:03 | |
| *** daidv has left #openstack-oslo | 14:03 | |
| openstackgerrit | Sean McGinnis proposed openstack/oslo.cache master: Avoid use of autodoc_tree_index_modules https://review.openstack.org/555080 | 14:12 |
| *** salv-orlando has joined #openstack-oslo | 14:13 | |
| *** msimonin has quit IRC | 14:22 | |
| *** bobh has quit IRC | 14:25 | |
| *** msimonin has joined #openstack-oslo | 14:35 | |
| *** msimonin has quit IRC | 14:49 | |
| *** bobh has joined #openstack-oslo | 14:57 | |
| dims | bnemec : dhellmann : we have consensus to try this patch again in oslo.service - can you please take a look? https://review.openstack.org/#/c/558206/ | 15:12 |
| *** msimonin has joined #openstack-oslo | 15:15 | |
| *** msimonin has quit IRC | 15:15 | |
| *** msimonin has joined #openstack-oslo | 15:32 | |
| *** lpetrut_ has joined #openstack-oslo | 15:34 | |
| *** bobh has quit IRC | 15:36 | |
| *** bobh_ has joined #openstack-oslo | 15:36 | |
| *** lpetrut has quit IRC | 15:36 | |
| *** edmondsw has quit IRC | 15:39 | |
| *** lucasagomes is now known as lucas-afk | 15:59 | |
| openstackgerrit | Doug Hellmann proposed openstack/futurist master: uncap eventlet https://review.openstack.org/560489 | 16:00 |
| *** pblaho has joined #openstack-oslo | 16:01 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.concurrency master: uncap eventlet https://review.openstack.org/560529 | 16:02 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.db master: uncap eventlet https://review.openstack.org/560530 | 16:02 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging master: uncap eventlet https://review.openstack.org/560531 | 16:02 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.privsep master: uncap eventlet https://review.openstack.org/560532 | 16:02 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.reports master: uncap eventlet https://review.openstack.org/560533 | 16:02 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.rootwrap master: uncap eventlet https://review.openstack.org/560534 | 16:02 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.vmware master: uncap eventlet https://review.openstack.org/560535 | 16:02 |
| openstackgerrit | Doug Hellmann proposed openstack/taskflow master: uncap eventlet https://review.openstack.org/560546 | 16:05 |
| *** harlowja has joined #openstack-oslo | 16:05 | |
| *** msimonin has quit IRC | 16:08 | |
| *** bobh_ has quit IRC | 16:09 | |
| *** AlexeyAbashkin has quit IRC | 16:22 | |
| *** msimonin has joined #openstack-oslo | 16:28 | |
| *** dikonoor has joined #openstack-oslo | 16:30 | |
| openstackgerrit | Lance Bragstad proposed openstack/oslo-specs master: A specification for additional enforcement attributes https://review.openstack.org/552045 | 16:33 |
| *** lpetrut has joined #openstack-oslo | 16:51 | |
| *** lpetrut_ has quit IRC | 16:51 | |
| *** lpetrut has quit IRC | 16:57 | |
| *** tesseract has quit IRC | 16:59 | |
| *** e0ne has quit IRC | 16:59 | |
| openstackgerrit | John Eckersberg proposed openstack/oslo.utils master: eventletutils: Fix behavior discrepency when reusing Events https://review.openstack.org/558879 | 17:02 |
| *** AlexeyAbashkin has joined #openstack-oslo | 17:07 | |
| *** harlowja has quit IRC | 17:07 | |
| *** yamamoto has quit IRC | 17:29 | |
| *** dikonoor has quit IRC | 17:38 | |
| *** lpetrut has joined #openstack-oslo | 17:40 | |
| *** yamamoto has joined #openstack-oslo | 17:49 | |
| *** e0ne has joined #openstack-oslo | 17:50 | |
| *** yamamoto has quit IRC | 17:50 | |
| *** yamamoto has joined #openstack-oslo | 17:50 | |
| *** harlowja has joined #openstack-oslo | 17:52 | |
| *** sambetts is now known as sambetts|afk | 17:55 | |
| *** yamamoto has quit IRC | 17:57 | |
| *** edmondsw has joined #openstack-oslo | 17:59 | |
| *** cburgess_ is now known as cburgess | 18:13 | |
| *** yamamoto has joined #openstack-oslo | 18:16 | |
| *** yamamoto has quit IRC | 18:18 | |
| *** yamamoto has joined #openstack-oslo | 18:25 | |
| openstackgerrit | Merged openstack/oslo.cache master: Fix incompatible requirement in lower constraints https://review.openstack.org/560379 | 18:29 |
| *** yamamoto has quit IRC | 18:34 | |
| *** yamamoto has joined #openstack-oslo | 18:38 | |
| *** yamamoto has quit IRC | 18:40 | |
| *** pcaruana has quit IRC | 18:55 | |
| *** chhagarw has quit IRC | 18:58 | |
| *** salv-orlando has quit IRC | 19:07 | |
| *** salv-orlando has joined #openstack-oslo | 19:07 | |
| *** salv-orlando has quit IRC | 19:11 | |
| dims | bnemec : dhellmann : this is ready to merge https://review.openstack.org/#/c/558206/ (got ok from vitrage, trove and heat teams) | 19:13 |
| openstackgerrit | Doug Hellmann proposed openstack/futurist master: uncap eventlet https://review.openstack.org/560489 | 19:18 |
| openstackgerrit | Doug Hellmann proposed openstack/futurist master: fix lower constraints https://review.openstack.org/560583 | 19:18 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.concurrency master: uncap eventlet https://review.openstack.org/560529 | 19:23 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.concurrency master: fix lower constraints https://review.openstack.org/560586 | 19:23 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging master: uncap eventlet https://review.openstack.org/560531 | 19:24 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.messaging master: fix lower constraints https://review.openstack.org/560587 | 19:24 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.privsep master: uncap eventlet https://review.openstack.org/560532 | 19:26 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.privsep master: fix lower constraints https://review.openstack.org/560588 | 19:26 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.reports master: uncap eventlet https://review.openstack.org/560533 | 19:27 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.reports master: fix lower constraints https://review.openstack.org/560590 | 19:27 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.rootwrap master: uncap eventlet https://review.openstack.org/560534 | 19:27 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.rootwrap master: fix lower constraints https://review.openstack.org/560591 | 19:27 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.vmware master: uncap eventlet https://review.openstack.org/560535 | 19:28 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.vmware master: fix lower constraints https://review.openstack.org/560592 | 19:28 |
| openstackgerrit | Doug Hellmann proposed openstack/taskflow master: uncap eventlet https://review.openstack.org/560546 | 19:30 |
| openstackgerrit | Doug Hellmann proposed openstack/taskflow master: fix lower constraints https://review.openstack.org/560593 | 19:30 |
| dhellmann | bnemec : we have several other libs that cap eventlet. I've tried to fix up those patches so they will land. Can you put them on your review priority list, please? https://review.openstack.org/#/q/topic:uncap-eventlet+(status:open+OR+status:merged) | 19:43 |
| *** edmondsw has quit IRC | 19:47 | |
| bnemec | dhellmann: Sure | 19:49 |
| bnemec | dims: Did you see dhellmann's comment? | 19:50 |
| dims | oops! will check bnemec | 19:50 |
| *** salv-orlando has joined #openstack-oslo | 19:56 | |
| *** bobh has joined #openstack-oslo | 19:58 | |
| *** Hagaricus has quit IRC | 20:08 | |
| *** geekinutah_ has joined #openstack-oslo | 20:21 | |
| *** NobodyCam_ has joined #openstack-oslo | 20:21 | |
| *** kmalloc_ has joined #openstack-oslo | 20:21 | |
| *** ansmith has quit IRC | 20:23 | |
| *** kmalloc_ has quit IRC | 20:25 | |
| *** kmalloc_ has joined #openstack-oslo | 20:25 | |
| *** Hagaricus has joined #openstack-oslo | 20:25 | |
| *** kmalloc_ is now known as notmorgan | 20:26 | |
| *** notmorgan has quit IRC | 20:26 | |
| *** notmorgan has joined #openstack-oslo | 20:26 | |
| *** notmorgan has quit IRC | 20:26 | |
| *** notmorgan has joined #openstack-oslo | 20:26 | |
| *** kmalloc has quit IRC | 20:27 | |
| *** andreaf_ has joined #openstack-oslo | 20:27 | |
| *** notmorgan is now known as kmalloc | 20:27 | |
| *** aspiers[m] has quit IRC | 20:28 | |
| *** mordred has quit IRC | 20:28 | |
| *** andreaf has quit IRC | 20:28 | |
| *** NobodyCam has quit IRC | 20:28 | |
| *** geekinutah has quit IRC | 20:28 | |
| *** johnsom has quit IRC | 20:28 | |
| *** geekinutah_ is now known as geekinutah | 20:28 | |
| *** NobodyCam_ is now known as NobodyCam | 20:28 | |
| *** johnsom has joined #openstack-oslo | 20:29 | |
| *** andreaf_ is now known as andreaf | 20:29 | |
| smcginnis | I think there may be an issue with the latest OVO release. | 20:30 |
| smcginnis | I would expect this to pass: https://github.com/openstack/cinder/blob/master/cinder/tests/unit/volume/drivers/dell_emc/vmax/test_vmax.py#L3455 | 20:30 |
| smcginnis | But it fails on a unicode comparison: http://logs.openstack.org/46/560346/1/check/cross-cinder-py27/074d9aa/testr_results.html.gz | 20:30 |
| *** mordred has joined #openstack-oslo | 20:30 | |
| smcginnis | That seems to be from here: https://github.com/openstack/oslo.versionedobjects/compare/1.32.0...1.33.0#diff-594e9ad3a9f264d03a2f35571f8970ceR367 | 20:31 |
| smcginnis | Shouldn't that just be using six.text_type instead of forcing unicode? | 20:31 |
| *** aspiers[m] has joined #openstack-oslo | 20:32 | |
| *** raildo has quit IRC | 20:47 | |
| *** yamamoto has joined #openstack-oslo | 20:52 | |
| *** edmondsw has joined #openstack-oslo | 20:54 | |
| *** yamamoto has quit IRC | 20:56 | |
| *** edmondsw has quit IRC | 20:59 | |
| bnemec | smcginnis: six.text_type is unicode: | 21:00 |
| bnemec | >>> six.text_type | 21:00 |
| bnemec | <type 'unicode'> | 21:00 |
| bnemec | At least on python 2. | 21:00 |
| bnemec | smcginnis: I think the issue is probably that the type actually did change so it wouldn't blow up on unicode inputs. | 21:01 |
| bnemec | Although given that UUIDs should never contain unicode characters, we should probably change that so it returns a str again. | 21:03 |
| openstackgerrit | Sean McGinnis proposed openstack/oslo.versionedobjects master: Don't force unicode strings for UUID coercion https://review.openstack.org/560639 | 21:05 |
| smcginnis | bnemec: It is on py3. | 21:06 |
| smcginnis | bnemec: Actually, I see what you're saying there. That's a little confusing, since I know we use that in many, many places in Cinder to be compatible with either 2 or 3. | 21:08 |
| smcginnis | bnemec: But using "%s" will just do what's right on either one. | 21:08 |
| bnemec | smcginnis: Yeah, I think we shouldn't have changed the return type. I believe the original goal of that change was to just prevent it from raising an exception if unicode data was passed in. | 21:09 |
| smcginnis | bnemec: I've tested that change with both versions to make sure, and it should be good. | 21:10 |
| *** AlexeyAbashkin has quit IRC | 21:10 | |
| bnemec | Yeah, there's a unit test to exercise this behavior too, so it's covered in the gate. | 21:12 |
| smcginnis | bnemec: The OVO tests must have passed before, but I tested the change against the Cinder test that the current release broke. | 21:16 |
| bnemec | smcginnis: Oh, I bet the problem is we used assertRegex for some reason in those unit tests. It probably hid the type mismatch. | 21:20 |
| smcginnis | bnemec: Ah, maybe that's it. | 21:21 |
| bnemec | Well, some tests used regex. Others are assertEqual, so I'm not sure how this passed. | 21:25 |
| bnemec | Oh, unless assertEqual also ignores unicode/str mismatches. The failing cinder test was comparing dicts. | 21:26 |
| smcginnis | I didn't think it did. | 21:27 |
| bnemec | A straight comparison does: | 21:28 |
| bnemec | >>> u'foo' == 'foo' | 21:28 |
| bnemec | True | 21:28 |
| bnemec | But they were casting a dict to unicode in the cinder test, so they ended up with an extra u character in the result. | 21:29 |
| smcginnis | bnemec: Looks like maybe we aren't really testing that code? https://github.com/openstack/oslo.versionedobjects/blob/5774995c3cfc3b6393f1175680d44662b2d9e2e4/oslo_versionedobjects/tests/test_fields.py#L33 | 21:29 |
| smcginnis | >>> {'test': u'test'} == {'test': 'test'} | 21:30 |
| smcginnis | True | 21:30 |
| smcginnis | How about we just drop py2 support and forget about all this? :) | 21:30 |
| bnemec | Yeah, but that's not what they did. They tested that six.text_type(some_dict) == six.text_type(some_dict_with_unicode) | 21:30 |
| bnemec | smcginnis: TestUUID overrides that fake field: https://github.com/openstack/oslo.versionedobjects/blob/5774995c3cfc3b6393f1175680d44662b2d9e2e4/oslo_versionedobjects/tests/test_fields.py#L269 | 21:31 |
| smcginnis | OK, good. | 21:31 |
| bnemec | I know the unit test was failing without the fix because I tested it locally. | 21:31 |
| bnemec | The whole u'%s' % value thing threw me off a bit. | 21:31 |
| smcginnis | Yeah, I probably wouldn't have noticed without the failure and that we've run into other unicode/string oddities in cinder before. | 21:32 |
| *** kgiusti has left #openstack-oslo | 21:32 | |
| bnemec | Unfortunately this got backported to queens too, so we'll need to backport your fix. | 21:33 |
| smcginnis | Yeah... | 21:33 |
| bnemec | Fortunately I'd bet there haven't been any releases of the stable oslo branches in a long time, so it's not out in the wild yet. :-) | 21:33 |
| smcginnis | On the bright side, we caught it right away on the requirements update, so that's good. :) | 21:34 |
| smcginnis | Right | 21:34 |
| bnemec | Yeah, upper-constraints doing its job. | 21:34 |
| bnemec | I'm actually surprised they don't have more trouble with that unit test. Casting what looks like a dict to a string seems like it would be prone to non-deterministic ordering issues. | 21:36 |
| *** ansmith has joined #openstack-oslo | 21:37 | |
| *** salv-orlando has quit IRC | 21:38 | |
| *** salv-orlando has joined #openstack-oslo | 21:38 | |
| bnemec | Hmm, my zuul-status page is getting {u'message': u"Tenant openstack isn't ready", u'code': 204} from the status endpoint. | 21:40 |
| clarkb | bnemec: zuul was just restarted to pick up fixes | 21:41 |
| clarkb | should be back now | 21:41 |
| clarkb | or at least on its way back | 21:41 |
| bnemec | clarkb: Okay, thanks. Was just reading the infra channel and figured it was that. | 21:42 |
| *** salv-orlando has quit IRC | 21:43 | |
| *** rcernin has joined #openstack-oslo | 21:49 | |
| * bnemec takes this opportunity to improve the error reporting of his app | 21:51 | |
| *** lpetrut has quit IRC | 21:56 | |
| *** e0ne has quit IRC | 22:20 | |
| -openstackstatus- NOTICE: zuul was restarted to updated to the latest code; you may need to recheck changes uploaded or approvals added between 21:30 and 21:45 | 22:30 | |
| *** salv-orlando has joined #openstack-oslo | 22:39 | |
| *** bobh has quit IRC | 22:40 | |
| *** bobh has joined #openstack-oslo | 22:42 | |
| *** edmondsw has joined #openstack-oslo | 22:43 | |
| *** d0ugal has quit IRC | 22:43 | |
| *** salv-orlando has quit IRC | 22:43 | |
| *** yamamoto has joined #openstack-oslo | 22:46 | |
| *** d0ugal has joined #openstack-oslo | 22:48 | |
| *** edmondsw has quit IRC | 22:48 | |
| *** yamamoto has quit IRC | 22:50 | |
| *** tobasco has quit IRC | 22:50 | |
| *** yamamoto has joined #openstack-oslo | 22:51 | |
| *** yamamoto has quit IRC | 22:56 | |
| *** yamamoto has joined #openstack-oslo | 22:57 | |
| *** tobasco has joined #openstack-oslo | 22:58 | |
| *** yamamoto has quit IRC | 23:01 | |
| *** yamamoto has joined #openstack-oslo | 23:03 | |
| *** spilla has quit IRC | 23:18 | |
| *** salv-orlando has joined #openstack-oslo | 23:40 | |
| *** salv-orlando has quit IRC | 23:45 | |
| *** yamamoto has quit IRC | 23:47 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!