*** shardy has joined #openstack-oslo | 00:45 | |
*** dave-mccowan has joined #openstack-oslo | 00:47 | |
*** yamamoto has joined #openstack-oslo | 01:20 | |
*** edmondsw has joined #openstack-oslo | 01:32 | |
*** edmondsw has quit IRC | 01:36 | |
*** yamamoto has quit IRC | 01:54 | |
*** links has joined #openstack-oslo | 02:17 | |
*** namnh has joined #openstack-oslo | 02:18 | |
openstackgerrit | Tovin Seven proposed openstack/osprofiler master: OSprofiler with Jaeger Tracing as backend https://review.openstack.org/480018 | 02:28 |
---|---|---|
*** bobh has joined #openstack-oslo | 02:31 | |
openstackgerrit | Tovin Seven proposed openstack/osprofiler master: OSprofiler with Jaeger Tracing as backend https://review.openstack.org/480018 | 02:39 |
*** yamamoto has joined #openstack-oslo | 02:41 | |
*** EvilienM is now known as EmilienM | 02:45 | |
openstackgerrit | wangxiyuan proposed openstack/oslo.limit master: Init repo https://review.openstack.org/556744 | 03:07 |
*** shardy has quit IRC | 03:12 | |
*** shardy has joined #openstack-oslo | 03:18 | |
*** edmondsw has joined #openstack-oslo | 03:20 | |
*** dave-mccowan has quit IRC | 03:23 | |
*** edmondsw has quit IRC | 03:24 | |
*** yamamoto has quit IRC | 03:25 | |
*** yamamoto has joined #openstack-oslo | 03:37 | |
*** shardy has quit IRC | 03:40 | |
*** pooja_jadhav has joined #openstack-oslo | 03:45 | |
*** bobh has quit IRC | 03:55 | |
*** bobh has joined #openstack-oslo | 04:00 | |
*** threestrands has joined #openstack-oslo | 04:04 | |
*** jaosorior has joined #openstack-oslo | 04:05 | |
*** bobh has quit IRC | 04:05 | |
*** namnh has quit IRC | 04:08 | |
*** namnh has joined #openstack-oslo | 04:09 | |
*** gyankum has joined #openstack-oslo | 04:10 | |
*** bobh has joined #openstack-oslo | 04:11 | |
*** bobh has quit IRC | 04:16 | |
*** bobh has joined #openstack-oslo | 04:23 | |
*** bobh has quit IRC | 04:27 | |
*** bobh has joined #openstack-oslo | 04:34 | |
*** bobh has quit IRC | 04:39 | |
*** bobh has joined #openstack-oslo | 04:50 | |
*** Guest47185 has quit IRC | 04:52 | |
*** bobh has quit IRC | 04:55 | |
*** Guest47185 has joined #openstack-oslo | 04:57 | |
*** bobh has joined #openstack-oslo | 05:02 | |
*** bobh has quit IRC | 05:06 | |
*** hoonetorg has quit IRC | 05:07 | |
*** bobh has joined #openstack-oslo | 05:12 | |
*** bobh has quit IRC | 05:17 | |
*** hoonetorg has joined #openstack-oslo | 05:20 | |
*** bobh has joined #openstack-oslo | 05:22 | |
*** bobh has quit IRC | 05:27 | |
*** bobh has joined #openstack-oslo | 05:33 | |
*** bobh has quit IRC | 05:37 | |
*** bobh has joined #openstack-oslo | 05:42 | |
*** bobh has quit IRC | 05:47 | |
*** jbadiapa has joined #openstack-oslo | 05:56 | |
*** pcaruana has joined #openstack-oslo | 06:02 | |
*** yamamoto has quit IRC | 06:03 | |
*** bobh has joined #openstack-oslo | 06:10 | |
*** yamamoto has joined #openstack-oslo | 06:14 | |
*** bobh has quit IRC | 06:15 | |
*** shardy has joined #openstack-oslo | 06:16 | |
*** bobh has joined #openstack-oslo | 06:22 | |
*** bobh has quit IRC | 06:27 | |
*** bobh has joined #openstack-oslo | 06:39 | |
*** bobh has quit IRC | 06:43 | |
*** bobh has joined #openstack-oslo | 06:50 | |
*** Guest47185 has quit IRC | 06:54 | |
openstackgerrit | Tovin Seven proposed openstack/osprofiler master: OSprofiler with Jaeger Tracing as backend https://review.openstack.org/480018 | 06:54 |
*** bobh has quit IRC | 06:54 | |
*** edmondsw has joined #openstack-oslo | 06:56 | |
*** Guest47185 has joined #openstack-oslo | 06:58 | |
*** edmondsw has quit IRC | 07:00 | |
*** yamamoto has quit IRC | 07:04 | |
*** bobh has joined #openstack-oslo | 07:05 | |
*** bobh has quit IRC | 07:10 | |
*** yamamoto has joined #openstack-oslo | 07:11 | |
*** toabctl has quit IRC | 07:18 | |
*** toabctl has joined #openstack-oslo | 07:22 | |
*** shardy has quit IRC | 07:37 | |
*** bobh has joined #openstack-oslo | 07:39 | |
*** threestrands has quit IRC | 07:39 | |
*** bobh has quit IRC | 07:43 | |
*** bobh has joined #openstack-oslo | 07:44 | |
*** bobh has quit IRC | 07:49 | |
*** yamamoto has quit IRC | 08:04 | |
*** yamamoto has joined #openstack-oslo | 08:07 | |
*** bobh has joined #openstack-oslo | 08:20 | |
*** bobh has quit IRC | 08:25 | |
*** edmondsw has joined #openstack-oslo | 08:44 | |
*** bobh has joined #openstack-oslo | 08:45 | |
*** edmondsw has quit IRC | 08:49 | |
*** pblaho has joined #openstack-oslo | 08:49 | |
*** bobh has quit IRC | 08:50 | |
*** bobh has joined #openstack-oslo | 08:50 | |
*** bobh has quit IRC | 08:55 | |
*** bobh has joined #openstack-oslo | 09:04 | |
*** e0ne has joined #openstack-oslo | 09:07 | |
*** bobh has quit IRC | 09:08 | |
*** jaosorior has quit IRC | 09:17 | |
*** bobh has joined #openstack-oslo | 09:18 | |
*** jaosorior has joined #openstack-oslo | 09:19 | |
*** bobh has quit IRC | 09:23 | |
*** Guest47185 has quit IRC | 09:33 | |
*** bobh has joined #openstack-oslo | 09:34 | |
openstackgerrit | Tovin Seven proposed openstack/osprofiler master: OSprofiler with Jaeger Tracing as backend https://review.openstack.org/480018 | 09:36 |
*** bobh has quit IRC | 09:39 | |
*** bobh has joined #openstack-oslo | 09:40 | |
*** bobh has quit IRC | 09:45 | |
*** Guest47185 has joined #openstack-oslo | 09:47 | |
*** bobh has joined #openstack-oslo | 10:07 | |
*** bobh has quit IRC | 10:12 | |
*** namnh has quit IRC | 10:15 | |
*** bobh has joined #openstack-oslo | 10:22 | |
*** bobh has quit IRC | 10:27 | |
*** edmondsw has joined #openstack-oslo | 10:32 | |
*** bobh has joined #openstack-oslo | 10:36 | |
*** edmondsw has quit IRC | 10:36 | |
*** bobh has quit IRC | 10:40 | |
*** bobh has joined #openstack-oslo | 10:42 | |
*** bobh has quit IRC | 10:47 | |
*** bobh has joined #openstack-oslo | 10:50 | |
*** bobh has quit IRC | 10:55 | |
openstackgerrit | Claudiu Belu proposed openstack/oslotest master: mock: Perform patch's autospec checks on __enter__ https://review.openstack.org/561581 | 10:58 |
openstackgerrit | Claudiu Belu proposed openstack/oslotest master: mock: Perform patch's autospec checks on __enter__ https://review.openstack.org/561581 | 10:59 |
*** dave-mccowan has joined #openstack-oslo | 11:14 | |
*** bobh has joined #openstack-oslo | 11:15 | |
*** bobh has quit IRC | 11:20 | |
*** bobh has joined #openstack-oslo | 11:23 | |
openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.config master: Base class for a configuration driver https://review.openstack.org/560027 | 11:25 |
openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.config master: ConfigurationSource base class https://review.openstack.org/559389 | 11:25 |
openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.config master: Create INI file ConfigurationSourceDriver. https://review.openstack.org/562746 | 11:25 |
*** dave-mccowan has quit IRC | 11:26 | |
*** dave-mccowan has joined #openstack-oslo | 11:27 | |
*** bobh has quit IRC | 11:28 | |
*** bobh has joined #openstack-oslo | 11:32 | |
*** bobh has quit IRC | 11:32 | |
*** ansmith has quit IRC | 11:42 | |
*** jaosorior has quit IRC | 11:49 | |
*** jroll has quit IRC | 11:56 | |
*** jroll has joined #openstack-oslo | 11:57 | |
*** yamamoto has quit IRC | 11:59 | |
*** yamamoto has joined #openstack-oslo | 12:02 | |
*** raildo has joined #openstack-oslo | 12:04 | |
*** nicolasbock has joined #openstack-oslo | 12:09 | |
*** yamamoto has quit IRC | 12:29 | |
*** edmondsw has joined #openstack-oslo | 12:32 | |
*** edmondsw has quit IRC | 12:36 | |
*** edmondsw has joined #openstack-oslo | 12:38 | |
*** edmondsw has quit IRC | 12:42 | |
openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.config master: Create INI file ConfigurationSourceDriver. https://review.openstack.org/562746 | 12:44 |
*** edmondsw has joined #openstack-oslo | 12:44 | |
*** kgiusti has joined #openstack-oslo | 12:47 | |
*** edmondsw has quit IRC | 12:48 | |
*** edmondsw has joined #openstack-oslo | 12:49 | |
*** yamamoto has joined #openstack-oslo | 12:52 | |
*** jaosorior has joined #openstack-oslo | 12:54 | |
*** ansmith has joined #openstack-oslo | 12:55 | |
*** bhagyashri_s has joined #openstack-oslo | 13:01 | |
*** jokke__ has joined #openstack-oslo | 13:05 | |
*** links has quit IRC | 13:05 | |
*** lbragstad has joined #openstack-oslo | 13:06 | |
*** zigo_ has joined #openstack-oslo | 13:08 | |
*** shardy has joined #openstack-oslo | 13:08 | |
*** eck`` has joined #openstack-oslo | 13:08 | |
*** cburgess_ has joined #openstack-oslo | 13:09 | |
*** bhagyashris has quit IRC | 13:11 | |
*** openstackgerrit has quit IRC | 13:11 | |
*** cburgess has quit IRC | 13:11 | |
*** zigo has quit IRC | 13:11 | |
*** eck` has quit IRC | 13:11 | |
*** rybridges has quit IRC | 13:11 | |
*** jokke_ has quit IRC | 13:11 | |
*** rybridges has joined #openstack-oslo | 13:17 | |
*** AlexeyAbashkin has joined #openstack-oslo | 13:28 | |
*** yamamoto has quit IRC | 13:35 | |
*** yamamoto has joined #openstack-oslo | 13:36 | |
*** superdan is now known as dansmith | 13:40 | |
*** bobh has joined #openstack-oslo | 13:49 | |
*** janzian has joined #openstack-oslo | 13:51 | |
*** lpetrut has joined #openstack-oslo | 13:51 | |
*** openstackgerrit has joined #openstack-oslo | 13:53 | |
openstackgerrit | Moisés Guimarães de Medeiros proposed openstack/oslo.config master: Create INI file ConfigurationSourceDriver. https://review.openstack.org/562746 | 13:53 |
*** chhagarw has joined #openstack-oslo | 13:53 | |
*** shardy has quit IRC | 13:55 | |
*** spilla has joined #openstack-oslo | 13:57 | |
*** chhagarw has quit IRC | 14:00 | |
*** chhagarw has joined #openstack-oslo | 14:00 | |
moguimar | dhellmann: Hi Doug, thanks for the feedback, I think I have addressed and/or answered all your comments by now. | 14:03 |
*** gyankum has quit IRC | 14:05 | |
*** chhagarw has quit IRC | 14:06 | |
*** bobh has quit IRC | 14:23 | |
*** AlexeyAbashkin has quit IRC | 14:36 | |
*** yamamoto has quit IRC | 14:37 | |
*** eck`` is now known as eck`gone | 14:39 | |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging master: Convert legacy zuul jobs to v3 https://review.openstack.org/566603 | 14:40 |
*** eck`gone is now known as eck` | 14:41 | |
*** pblaho has quit IRC | 14:48 | |
*** yamamoto has joined #openstack-oslo | 14:49 | |
*** lpetrut has quit IRC | 14:50 | |
*** yamamoto has quit IRC | 14:52 | |
*** yamamoto has joined #openstack-oslo | 14:53 | |
*** yamamoto has quit IRC | 14:58 | |
*** beekneemech is now known as bnemec | 15:00 | |
bnemec | #startmeeting oslo | 15:00 |
openstack | Meeting started Mon May 7 15:00:55 2018 UTC and is due to finish in 60 minutes. The chair is bnemec. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
*** openstack changes topic to " (Meeting topic: oslo)" | 15:00 | |
openstack | The meeting name has been set to 'oslo' | 15:01 |
bnemec | courtesy ping for amotoki, amrith, ansmith, bnemec, dansmith, dhellmann, dims | 15:01 |
bnemec | courtesy ping for dougwig, e0ne, electrocucaracha, flaper87, garyk, gcb, haypo | 15:01 |
bnemec | courtesy ping for jd__, johnsom, jungleboyj, kgiusti, kragniz, lhx_, raildo | 15:01 |
bnemec | courtesy ping for redrobot, sileht, spamaps, sreshetnyak, stephenfin, stevemar, therve | 15:01 |
bnemec | courtesy ping for thinrichs, toabctl, zhiyan, zxy, zzzeek | 15:01 |
e0ne | hi | 15:01 |
ansmith | o/ | 15:01 |
kgiusti | o/ | 15:01 |
jungleboyj | o/ | 15:01 |
dhellmann | o/ | 15:03 |
bnemec | #topic Red flags for/from liaisons | 15:03 |
*** openstack changes topic to "Red flags for/from liaisons (Meeting topic: oslo)" | 15:03 | |
bnemec | I'm not aware of anything from the Oslo side. | 15:04 |
bnemec | Seems pretty quiet, so we'll move on. | 15:05 |
bnemec | #topic Releases for Rocky | 15:05 |
*** openstack changes topic to "Releases for Rocky (Meeting topic: oslo)" | 15:05 | |
jungleboyj | Nothing from Cinder. :-) | 15:05 |
bnemec | Business as usual, except for an extra oslo.policy release last week for the multiple input/output files change. | 15:06 |
smcginnis | ./ | 15:06 |
vstinner | i'm sorry to spam the meeting, but if you would like to be pay to maintain Oslo, Red Hat is looking for someone to replace me ;-) https://global-redhat.icims.com/jobs/63064/senior-software-engineer---openstack-oslo-project/job?hub=7 | 15:06 |
vstinner | be paid* | 15:06 |
bnemec | #link https://global-redhat.icims.com/jobs/63064/senior-software-engineer---openstack-oslo-project/job?hub=7 | 15:07 |
bnemec | vstinner: No problem, that's good to advertise. | 15:08 |
bnemec | We can always use more contributors. :-) | 15:08 |
*** bobh has joined #openstack-oslo | 15:08 | |
bnemec | #topic Action items from last meeting | 15:08 |
*** openstack changes topic to "Action items from last meeting (Meeting topic: oslo)" | 15:08 | |
bnemec | "bnemec to release Oslo stable branches" | 15:09 |
bnemec | Not done, but still on my list. | 15:09 |
*** pcaruana has quit IRC | 15:09 | |
bnemec | I wrapped up some significant non-Oslo work last week so I'm hoping to have a little more time this week. | 15:09 |
bnemec | "kgiusti remove pip-check-reqs from tox.ini" | 15:09 |
bnemec | I saw a bunch of patches. | 15:10 |
kgiusti | https://etherpad.openstack.org/p/pip_(missing|check)_reqs | 15:10 |
kgiusti | I think we're all set from the Oslo perspective | 15:10 |
kgiusti | stephenfin and tosky have jumped in too | 15:10 |
bnemec | Cool | 15:10 |
bnemec | oslo.versionedobjects has no assignee, is that an oversight? | 15:11 |
kgiusti | ? one sec | 15:11 |
kgiusti | whoopsie - missed that one | 15:11 |
kgiusti | I'll hit that up today - good catch. | 15:12 |
bnemec | That's the good thing about having a list. :-) | 15:12 |
bnemec | kgiusti: Thanks for taking care of this. | 15:12 |
kgiusti | Yep, so says my wife. | 15:12 |
bnemec | :-) | 15:13 |
kgiusti | my pleasure (removing code is so relaxing....) | 15:13 |
bnemec | "kgiusti to do a recruiting drive" <- Any bites? | 15:13 |
kgiusti | Well stephenfin and tosky bit. | 15:14 |
kgiusti | But nothing from the other affected projects. | 15:14 |
bnemec | Okay. Hopefully some of the folks doing the other cross-project cleanup changes will jump in at some point. | 15:16 |
kgiusti | yep | 15:16 |
bnemec | It's practically free commits for anyone judged on those metrics. ;-) | 15:16 |
* bnemec dangles the carrot enticingly | 15:16 | |
bnemec | "investigate if anyone is using oslo.service wsgi module" | 15:17 |
bnemec | I didn't get to this either. oslo.service is still on my todo list too though. | 15:17 |
bnemec | Definitely need to get that cleaned up. | 15:17 |
*** bobh has quit IRC | 15:18 | |
bnemec | That's it for action items from last meeting. | 15:18 |
bnemec | #topic Vancouver project update | 15:18 |
*** openstack changes topic to "Vancouver project update (Meeting topic: oslo)" | 15:18 | |
bnemec | So this starts in two weeks. | 15:18 |
bnemec | If you have anything you worked on in Queens that you'd like included in the presentation, please let me know. | 15:19 |
*** yamamoto has joined #openstack-oslo | 15:19 | |
bnemec | Hopefully I'm aware enough of what's going on in Rocky to come up with the future list myself, but I'm happy to take reminders for that too. | 15:20 |
bnemec | I need to get together with gcb and discuss too. I know he wanted to be involved since he was PTL last cycle. | 15:20 |
bnemec | #action bnemec to sync up with gcb about Vancouver project update | 15:20 |
bnemec | I guess I should action the other part too. | 15:21 |
kgiusti | bnemec: did you have an epad for the topics you plan to cover? gcb would make one available for review/feedback | 15:21 |
bnemec | #action Oslo contributors to contact bnemec with any project updates they'd like included | 15:21 |
bnemec | kgiusti: Ah, good idea. | 15:22 |
kgiusti | gcb's actually... But I'm happy to take credit! :) | 15:22 |
*** shardy has joined #openstack-oslo | 15:22 | |
bnemec | Okay, let's use this: | 15:23 |
bnemec | #link https://etherpad.openstack.org/p/oslo-project-update-rocky | 15:23 |
kgiusti | thanks | 15:24 |
kgiusti | got a link to the scheduled time slot? | 15:25 |
bnemec | I believe it was Wednesday. Let me find it again. | 15:26 |
bnemec | #link https://www.openstack.org/summit/vancouver-2018/summit-schedule/events/21617/oslo-project-update | 15:26 |
* bnemec notes that he needs to update his OpenStack profile | 15:26 | |
* bnemec also notes that his profile picture was taken in Vancouver the last time | 15:27 | |
smcginnis | :) | 15:27 |
bnemec | Also a reminder that we have an onboarding session on Tuesday. | 15:27 |
bnemec | #link https://www.openstack.org/summit/vancouver-2018/summit-schedule/events/21645/oslo-project-onboarding | 15:27 |
bnemec | Okay, I think that's it for this topic. We can circle back next week and see where it stands. | 15:29 |
bnemec | #topic Open discussion | 15:29 |
*** openstack changes topic to "Open discussion (Meeting topic: oslo)" | 15:29 | |
*** vstinner has left #openstack-oslo | 15:29 | |
bnemec | I guess a couple of quick notes from me: | 15:30 |
bnemec | 1) I started to re-review the config migrator, but didn't quite get all the way through. Will finish it up this week. | 15:30 |
bnemec | 2) I saw some more updates on the config plugin side, haven't had a chance to look at those patches yet though. | 15:30 |
*** pbourke has quit IRC | 15:30 | |
*** pbourke has joined #openstack-oslo | 15:32 | |
bnemec | Okay, sounds like that's it for this week. Thanks for joining everyone. | 15:34 |
bnemec | #endmeeting | 15:35 |
*** openstack changes topic to "OpenStack Common Libraries | https://wiki.openstack.org/wiki/Oslo" | 15:35 | |
openstack | Meeting ended Mon May 7 15:35:01 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:35 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/oslo/2018/oslo.2018-05-07-15.00.html | 15:35 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/oslo/2018/oslo.2018-05-07-15.00.txt | 15:35 |
openstack | Log: http://eavesdrop.openstack.org/meetings/oslo/2018/oslo.2018-05-07-15.00.log.html | 15:35 |
jungleboyj | Thanks! | 15:35 |
dhellmann | bnemec : as the release liaison, I can take those stable releases off your todo list if you want | 15:45 |
dhellmann | sorry, we had a small dishwasher emergency just as the meeting started so I missed most of it | 15:46 |
bnemec | dhellmann: Oops. As long as it didn't turn into a big dishwasher emergency, I guess. :-) | 15:48 |
bnemec | dhellmann: If you want to propose them that's fine with me. | 15:49 |
bnemec | I'm not even sure how many are needed. | 15:49 |
bnemec | We don't do a ton of backports, but the stable branches haven't been released in months either, from what I can tell. | 15:49 |
dhellmann | bnemec : no leaks, just a bad smell. We think some vinegar will fix it. | 15:49 |
* dhellmann crosses his fingers | 15:49 | |
dhellmann | yeah, let me run the report | 15:49 |
bnemec | dhellmann: Ah, I would Lysol the heck out of it too. | 15:52 |
bnemec | I had a small fridge emergency a few years ago and none of the smell removal stuff helped until I got it good and disinfected. | 15:52 |
dhellmann | ah, good to know | 15:52 |
dhellmann | if this doesn't work, we'll bring out the lysol | 15:52 |
dhellmann | it looks like we're ok for ocata (ci changes but no bug fixes) http://paste.openstack.org/show/720496/ | 15:53 |
dhellmann | for pike it looks like we want to release oslo.versionedobjects: http://paste.openstack.org/show/720498/ | 15:54 |
dhellmann | for queens I think we want oslo.concurrency, oslo.db, and oslo.versionedobjects | 15:56 |
dhellmann | oh, maybe tooz | 15:56 |
*** yamamoto has quit IRC | 16:06 | |
*** e0ne has quit IRC | 16:13 | |
*** yamamoto has joined #openstack-oslo | 16:19 | |
*** openstackgerrit has quit IRC | 16:19 | |
*** lpetrut has joined #openstack-oslo | 16:20 | |
*** finucannot is now known as stephenfin | 16:20 | |
*** bobh has joined #openstack-oslo | 16:32 | |
*** shardy has quit IRC | 16:33 | |
*** bobh has quit IRC | 16:43 | |
*** spilla has quit IRC | 16:46 | |
*** yamamoto has quit IRC | 16:46 | |
*** openstackgerrit has joined #openstack-oslo | 16:47 | |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging master: Convert legacy zuul jobs to v3 https://review.openstack.org/566603 | 16:47 |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging master: Convert legacy zuul jobs to v3 https://review.openstack.org/566603 | 16:52 |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging master: Convert legacy zuul jobs to v3 https://review.openstack.org/566603 | 16:54 |
*** spilla has joined #openstack-oslo | 16:56 | |
openstackgerrit | Ben Nemec proposed openstack-dev/cookiecutter master: Add support for storyboard https://review.openstack.org/482262 | 16:57 |
bnemec | ^ is a pretty simple change that has been open a very long time | 16:58 |
*** yamamoto has joined #openstack-oslo | 16:59 | |
bnemec | I only rebased it. | 16:59 |
openstackgerrit | Ken Giusti proposed openstack/oslo.versionedobjects master: Remove stale pip-missing-reqs tox test https://review.openstack.org/566684 | 17:04 |
*** jaosorior has quit IRC | 17:26 | |
*** jaosorior has joined #openstack-oslo | 17:28 | |
*** e0ne has joined #openstack-oslo | 17:35 | |
*** bobh has joined #openstack-oslo | 17:37 | |
jroll | so I seem to remember oslo.log doing some automatic log sanitization, but I can't find it now, am I remembering wrong and we just have strutils.mask_password available to use when projects need it? | 17:39 |
*** yamamoto has quit IRC | 17:50 | |
*** bobh has quit IRC | 18:12 | |
*** mvenesio has joined #openstack-oslo | 18:18 | |
*** yamamoto has joined #openstack-oslo | 18:25 | |
*** dave-mccowan has quit IRC | 18:36 | |
*** dave-mcc_ has joined #openstack-oslo | 18:36 | |
*** yamamoto has quit IRC | 18:39 | |
*** dave-mccowan has joined #openstack-oslo | 19:05 | |
*** e0ne_ has joined #openstack-oslo | 19:07 | |
*** dave-mcc_ has quit IRC | 19:07 | |
*** e0ne has quit IRC | 19:11 | |
smcginnis | jroll: Are you thinking with config options? https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L326 | 19:27 |
jroll | smcginnis: nah, mask_password used to be directly in the log module, and somehow I had it in my head that it ran on logging, I'm pretty sure I'm wrong now | 19:30 |
openstackgerrit | Zane Bitter proposed openstack/oslo.service master: Python 3: Fix eventlet wakeup after signal https://review.openstack.org/566714 | 19:32 |
smcginnis | jroll: I think you are right (about being wrong) :) | 19:32 |
smcginnis | Just based on what I've seen. | 19:32 |
jroll | heh, ok :) | 19:32 |
jroll | thanks smcginnis | 19:32 |
*** yamamoto has joined #openstack-oslo | 19:39 | |
*** yamamoto has quit IRC | 19:49 | |
openstackgerrit | Zane Bitter proposed openstack/oslo.service master: Python 3: Fix eventlet wakeup after signal https://review.openstack.org/566714 | 19:53 |
*** lpetrut has quit IRC | 19:54 | |
*** spilla has quit IRC | 20:26 | |
*** raildo has quit IRC | 20:26 | |
*** mvenesio has quit IRC | 20:38 | |
*** mvenesio has joined #openstack-oslo | 20:39 | |
*** NobodyCam_ has joined #openstack-oslo | 20:46 | |
*** kgiusti has left #openstack-oslo | 20:46 | |
*** vdrok_ has joined #openstack-oslo | 20:47 | |
*** knikolla_ has joined #openstack-oslo | 20:47 | |
*** HenryG_ has joined #openstack-oslo | 20:47 | |
*** szaher_ has joined #openstack-oslo | 20:48 | |
*** janzian has quit IRC | 20:49 | |
*** mvenesio has quit IRC | 20:53 | |
*** NobodyCam has quit IRC | 20:53 | |
*** vdrok has quit IRC | 20:53 | |
*** knikolla has quit IRC | 20:53 | |
*** HenryG has quit IRC | 20:53 | |
*** szaher has quit IRC | 20:53 | |
*** vdrok_ is now known as vdrok | 20:53 | |
*** knikolla_ is now known as knikolla | 20:53 | |
*** NobodyCam_ is now known as NobodyCam | 20:53 | |
*** ansmith has quit IRC | 20:56 | |
dhellmann | jroll : it looks like oslo.concurrency uses mask_password before logging some commands it was running, and I think oslo.messaging does something similar before sending notifications | 21:01 |
dhellmann | maybe those are what you were thinking of (since there's a logging notifier)? | 21:02 |
openstackgerrit | Merged openstack/oslo.versionedobjects master: Remove stale pip-missing-reqs tox test https://review.openstack.org/566684 | 21:05 |
*** edmondsw has quit IRC | 21:15 | |
*** edmondsw has joined #openstack-oslo | 21:15 | |
lbragstad | does anyone know if this is a known issue with oslo.config and python3? https://bugs.launchpad.net/keystone/+bug/1768498 | 21:17 |
openstack | Launchpad bug 1768498 in oslo.config "config generation(yaml/json) broken with python3" [Undecided,New] | 21:17 |
dhellmann | lbragstad : my guess is that would fail on python 2 as well unless somehow the json module there knows how to turn a HostAddress into a string | 21:19 |
lbragstad | interesting | 21:19 |
dhellmann | although the reporter says it does work on 2, so who knows | 21:19 |
lbragstad | right... i was able to recreate it with python3 | 21:20 |
dhellmann | oh "unhashable type" | 21:20 |
dhellmann | that's not the error I was thinking of | 21:20 |
dhellmann | I don't know what a HostAddress is so I'm not sure why it can't be hased | 21:20 |
dhellmann | hashed | 21:20 |
*** edmondsw has quit IRC | 21:20 | |
lbragstad | http://paste.openstack.org/raw/720521/ yeah - that's the full paste i have | 21:21 |
lbragstad | ah... | 21:21 |
lbragstad | i think it's because keystone is using https://github.com/openstack/keystone/blob/ac9c0dc03492dc71398ccab6aafa8eb0d966c899/keystone/conf/eventlet_server.py#L53 | 21:22 |
lbragstad | https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L1567 | 21:23 |
dhellmann | ah, that code is expecting a class and it's getting an instance | 21:23 |
dhellmann | HostAddressOpt sets the type to a HostAddress() instance with the version (v6 or v4 I presume) | 21:24 |
lbragstad | ahh | 21:24 |
dhellmann | if you give the HostAddress type a type_name attribute that should fix it | 21:25 |
lbragstad | is keystone using that option wrong then? | 21:25 |
dhellmann | no, it's just that they aren't widely used and we haven't seen this before | 21:25 |
dhellmann | probably because no one uses the generator under python 3 :-) | 21:26 |
lbragstad | probably | 21:26 |
dhellmann | I don't know why the class is not hashable | 21:26 |
dhellmann | it doesn't define a __hash__ method but it shouldn't have to | 21:26 |
dhellmann | you could make type_name a property method and fill in the version number | 21:27 |
lbragstad | yeah - and other things subclass Opt, so nothing about HostAddressOpt looks out of the ordinary compared to the rest of the module | 21:27 |
dhellmann | so we'd get "ipv4 address" or "ipv6 address" | 21:27 |
openstackgerrit | Vipin Balachandran proposed openstack/oslo.vmware master: Refactor _start_transfer https://review.openstack.org/566743 | 21:28 |
lbragstad | judging by the example and default, we're assuming an ipv4 address | 21:28 |
dhellmann | right, but the HostAddress class doesn't make that assumption | 21:28 |
dhellmann | that's the class in oslo.config that needs to be updated | 21:29 |
openstackgerrit | Vipin Balachandran proposed openstack/oslo.vmware master: Refactor _start_transfer https://review.openstack.org/566743 | 21:29 |
dhellmann | we should probably have tests that verify all of our option types can be formatted properly | 21:30 |
lbragstad | it looks like it defaults to a dummy string? https://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L821 | 21:31 |
lbragstad | but would expect a real ipv4 or ipv6 address when calling out to netaddr | 21:32 |
dhellmann | lbragstad : but that value isn't being stored anywhere | 21:32 |
dhellmann | well, not in a valid way | 21:32 |
dhellmann | it goes into the ip_address field but nothing looks for it there | 21:32 |
lbragstad | hmm | 21:34 |
dhellmann | I'm not sure why it's being passed to that class | 21:35 |
lbragstad | it looks like the version checking bits in IPAddress are storing boolean values? | 21:35 |
lbragstad | based on the naming of the variables? | 21:35 |
dhellmann | IPAddress needs the value when it is used directly, but nothing about HostAddress does anything to pull the value out | 21:36 |
dhellmann | I'm not sure what you mean by "the version checking bits" | 21:36 |
lbragstad | https://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L709-L715 | 21:36 |
lbragstad | i was trying to parse that and figure out what it was doing | 21:37 |
dhellmann | that's a switch statement to decide which check method to use based on the version | 21:37 |
dhellmann | see line 717 | 21:37 |
dhellmann | the whitespace in this code is confusing | 21:37 |
dhellmann | oh! | 21:38 |
dhellmann | the base class for HostAddress is not being initialized | 21:38 |
dhellmann | that's the real issue | 21:38 |
dhellmann | if that was in place, passing type_name down to it would resolve the problem | 21:38 |
lbragstad | ahhh | 21:39 |
dhellmann | but since it's not being initialized we don't even have a default | 21:39 |
dhellmann | lbragstad : do you want to propose the fix so I can +2, or do you want me to do it and then we can train you up to be core on this library so you can +2 it? | 21:39 |
lbragstad | oh - so self.version_checker isn't actually initialized? | 21:40 |
dhellmann | HostAddress isn't derived from IPAddress, it contains one | 21:40 |
dhellmann | HostAddress is derived directly from ConfigType, and does not initialize ConfigType in it's __init__ | 21:40 |
dhellmann | so around line 825 we need a super() call to do the rest of the initialization | 21:41 |
lbragstad | oh! | 21:41 |
dhellmann | there's probably some other stuff we could clean up in there (__repr__ looks odd, as does __eq__) | 21:42 |
dhellmann | but one bug at a time | 21:43 |
openstackgerrit | Vipin Balachandran proposed openstack/oslo.vmware master: Fix session re-establish failure with PBM APIs https://review.openstack.org/566746 | 21:44 |
lbragstad | doing some tests locally quick | 21:44 |
openstackgerrit | Lance Bragstad proposed openstack/oslo.config master: WIP: Properly initialize HostAddress https://review.openstack.org/566748 | 21:46 |
lbragstad | so - that fixes it for me locally when i install that with keystone | 21:47 |
lbragstad | but, i might need an idea on how to test it properly | 21:47 |
dhellmann | yep, that's what I expect | 21:47 |
dhellmann | (the fix that is) | 21:47 |
dhellmann | for testing, let me think | 21:47 |
dhellmann | I wonder if you could instantiate an _OptFormatter() and ask it to format the help for 1 HostAddressOpt | 21:48 |
dhellmann | it looks like that takes a writable stream as an argument, so you could use a StringIO | 21:48 |
dhellmann | if you set up one test class with 1 method doing that, then we can extend it later with other types | 21:49 |
dhellmann | we could even file that as a low-hanging-fruit bug for a new contributor | 21:49 |
*** ansmith has joined #openstack-oslo | 21:49 | |
*** e0ne_ has quit IRC | 21:50 | |
lbragstad | +++ | 21:50 |
*** dave-mccowan has quit IRC | 22:01 | |
dhellmann | alright, that's enough for one day for me | 22:01 |
openstackgerrit | Lance Bragstad proposed openstack/oslo.config master: Properly initialize HostAddress https://review.openstack.org/566748 | 22:05 |
lbragstad | dhellmann: ^ really rough test.. but it recreates the unhashable type error | 22:05 |
dhellmann | lbragstad : you caught me lingering, so I left 2 comments, but now I'm really going to see about dinner | 22:07 |
lbragstad | #thanks dhellmann for helping fix a python3 bug with keystone config generation | 22:07 |
lbragstad | o/ | 22:07 |
openstackstatus | lbragstad: Added your thanks to Thanks page (https://wiki.openstack.org/wiki/Thanks) | 22:07 |
openstackgerrit | Vipin Balachandran proposed openstack/oslo.vmware master: Fix session re-establish failure with PBM APIs https://review.openstack.org/566746 | 22:16 |
openstackgerrit | Lance Bragstad proposed openstack/oslo.config master: Properly initialize HostAddress https://review.openstack.org/566748 | 22:21 |
*** rcernin has joined #openstack-oslo | 22:25 | |
*** dave-mccowan has joined #openstack-oslo | 22:55 | |
-openstackstatus- NOTICE: Any devstack job failure due to rsync errors related to tripleo-incubator can safely be rechecked now | 22:57 | |
*** pooja_jadhav has quit IRC | 23:28 | |
*** pooja_jadhav has joined #openstack-oslo | 23:28 | |
*** shardy has joined #openstack-oslo | 23:45 | |
*** shardy has quit IRC | 23:58 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!