openstackgerrit | wangxiyuan proposed openstack/oslo.limit master: [WIP]Add limit check func https://review.openstack.org/596520 | 01:27 |
---|---|---|
*** Kvisle_ has quit IRC | 01:29 | |
*** mmethot has quit IRC | 02:20 | |
*** ducnv has joined #openstack-oslo | 04:50 | |
*** e0ne has joined #openstack-oslo | 05:34 | |
*** e0ne has quit IRC | 06:16 | |
*** ducnv has quit IRC | 06:44 | |
*** ducnv has joined #openstack-oslo | 06:48 | |
*** pcaruana has joined #openstack-oslo | 06:49 | |
*** links has joined #openstack-oslo | 06:59 | |
*** dmellado has quit IRC | 07:00 | |
*** dmellado has joined #openstack-oslo | 07:02 | |
*** mattgo has joined #openstack-oslo | 07:29 | |
*** rcernin has quit IRC | 07:31 | |
*** d0ugal has joined #openstack-oslo | 07:54 | |
openstackgerrit | wangxiyuan proposed openstack/oslo.limit master: [WIP]Add limit check func https://review.openstack.org/596520 | 08:20 |
openstackgerrit | Oleg Bondarev proposed openstack/oslo.messaging master: Use default exchange for direct messaging https://review.openstack.org/596661 | 08:22 |
*** flaper87 has joined #openstack-oslo | 08:38 | |
*** e0ne has joined #openstack-oslo | 08:48 | |
*** cdent has joined #openstack-oslo | 08:59 | |
*** r-mibu has joined #openstack-oslo | 09:01 | |
*** jaosorior has joined #openstack-oslo | 10:25 | |
*** pcaruana has quit IRC | 10:32 | |
*** pcaruana has joined #openstack-oslo | 10:32 | |
*** threestrands has quit IRC | 11:05 | |
*** moguimar has joined #openstack-oslo | 11:06 | |
*** nicolasbock has joined #openstack-oslo | 11:13 | |
*** cdent has quit IRC | 11:17 | |
*** cdent has joined #openstack-oslo | 11:18 | |
openstackgerrit | Merged openstack/automaton master: add lib-forward-testing-python3 test job https://review.openstack.org/591175 | 11:38 |
*** snapiri has joined #openstack-oslo | 11:39 | |
openstackgerrit | Merged openstack/oslo.i18n master: add lib-forward-testing-python3 test job https://review.openstack.org/591184 | 11:39 |
*** jroll has quit IRC | 11:43 | |
*** jroll has joined #openstack-oslo | 11:44 | |
openstackgerrit | Merged openstack/oslo.config master: add lib-forward-testing-python3 test job https://review.openstack.org/591181 | 11:46 |
openstackgerrit | Merged openstack/oslo.serialization master: add lib-forward-testing-python3 test job https://review.openstack.org/591193 | 11:49 |
openstackgerrit | Merged openstack/oslo.cache master: add lib-forward-testing-python3 test job https://review.openstack.org/591179 | 11:49 |
openstackgerrit | Merged openstack/debtcollector master: add lib-forward-testing-python3 test job https://review.openstack.org/591176 | 11:49 |
openstackgerrit | Merged openstack/oslo.context master: add lib-forward-testing-python3 test job https://review.openstack.org/591182 | 11:51 |
openstackgerrit | Merged openstack-dev/pbr master: add lib-forward-testing-python3 test job https://review.openstack.org/591177 | 11:53 |
openstackgerrit | Merged openstack/oslo.db master: add lib-forward-testing-python3 test job https://review.openstack.org/591183 | 11:54 |
openstackgerrit | Merged openstack/oslo.concurrency master: add lib-forward-testing-python3 test job https://review.openstack.org/591180 | 11:55 |
openstackgerrit | Merged openstack/oslo.vmware master: add lib-forward-testing-python3 test job https://review.openstack.org/591197 | 11:56 |
openstackgerrit | Merged openstack/oslo.versionedobjects master: add lib-forward-testing-python3 test job https://review.openstack.org/591196 | 11:58 |
*** raildo has joined #openstack-oslo | 11:59 | |
openstackgerrit | Merged openstack/oslo.privsep master: add lib-forward-testing-python3 test job https://review.openstack.org/591190 | 12:01 |
*** sean-k-mooney has quit IRC | 12:08 | |
*** sean-k-mooney has joined #openstack-oslo | 12:08 | |
openstackgerrit | Merged openstack/oslo.utils master: add lib-forward-testing-python3 test job https://review.openstack.org/591195 | 12:10 |
*** kgiusti has joined #openstack-oslo | 12:47 | |
*** links has quit IRC | 12:57 | |
*** ansmith has joined #openstack-oslo | 13:18 | |
*** lbragstad has joined #openstack-oslo | 13:47 | |
openstackgerrit | Chuck Short proposed openstack/oslo.config master: Replace assertRaisesRegexp with assertRaisesRegex https://review.openstack.org/596732 | 13:48 |
*** raildo_ has joined #openstack-oslo | 14:03 | |
*** raildo has quit IRC | 14:03 | |
*** rmascena__ has joined #openstack-oslo | 14:06 | |
*** raildo_ has quit IRC | 14:09 | |
dhellmann | stephenfin : you're right, it wouldn't hurt to have a release note for https://review.openstack.org/#/c/590066/ | 14:11 |
stephenfin | dhellmann: Should I put one together? | 14:13 |
dhellmann | if you have a few minutes, sure | 14:13 |
dhellmann | maybe add Wei Tie as a reviewer just as a heads-up | 14:14 |
openstackgerrit | Stephen Finucane proposed openstack-dev/pbr master: Add release note for fix to bug 1786306 https://review.openstack.org/596755 | 14:22 |
openstack | bug 1786306 in PBR "pbr doesn't work when there's subdirectory in url " [Undecided,Fix released] https://launchpad.net/bugs/1786306 - Assigned to Wei T (nuaafe) | 14:22 |
openstackgerrit | Claudiu Belu proposed openstack/oslotest master: WIP: mock: Makes _AutospecMagicMock a subclass of _AutospecMock https://review.openstack.org/596758 | 14:24 |
dhellmann | stephenfin | 14:30 |
dhellmann | oops | 14:30 |
dhellmann | stephenfin : can you mix italics and link markup like that? `*pip* ..`_ | 14:31 |
dhellmann | unless they've changed it, that will come out with the * in the link title text | 14:31 |
stephenfin | Ah, correct. Other way round | 14:31 |
stephenfin | Good spot | 14:31 |
dhellmann | I think it's fine to just have it be a link, without extra markup | 14:32 |
*** ducnv_ has joined #openstack-oslo | 14:33 | |
stephenfin | Yeah, I'll do that | 14:33 |
openstackgerrit | Stephen Finucane proposed openstack-dev/pbr master: Add release note for fix to bug 1786306 https://review.openstack.org/596755 | 14:33 |
openstack | bug 1786306 in PBR "pbr doesn't work when there's subdirectory in url " [Undecided,Fix released] https://launchpad.net/bugs/1786306 - Assigned to Wei T (nuaafe) | 14:33 |
*** ianychoi has quit IRC | 14:36 | |
openstackgerrit | Merged openstack-dev/pbr master: Move pbr-installation jobs in-tree https://review.openstack.org/571571 | 14:39 |
*** ianychoi has joined #openstack-oslo | 14:42 | |
*** gcb_ has joined #openstack-oslo | 14:56 | |
bnemec | #startmeeting oslo | 15:01 |
openstack | Meeting started Mon Aug 27 15:01:20 2018 UTC and is due to finish in 60 minutes. The chair is bnemec. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:01 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:01 |
*** openstack changes topic to " (Meeting topic: oslo)" | 15:01 | |
openstack | The meeting name has been set to 'oslo' | 15:01 |
bnemec | courtesy ping for amotoki, amrith, ansmith, bnemec, dansmith, dhellmann, dims | 15:01 |
bnemec | courtesy ping for dougwig, e0ne, electrocucaracha, flaper87, garyk, gcb, haypo | 15:01 |
bnemec | courtesy ping for jd__, johnsom, jungleboyj, kgiusti, kragniz, lhx_, njohnston | 15:01 |
bnemec | courtesy ping for raildo, redrobot, sileht, spamaps, sreshetnyak, stephenfin, stevemar | 15:01 |
bnemec | courtesy ping for therve, thinrichs, toabctl, zhiyan, zxy, zzzeek | 15:01 |
jungleboyj | o/ | 15:01 |
jungleboyj | Kind of here. | 15:01 |
kgiusti | o/ | 15:02 |
ansmith | o/ | 15:02 |
gcb_ | o/ | 15:02 |
bnemec | #link https://wiki.openstack.org/wiki/Meetings/Oslo#Agenda_for_Next_Meeting | 15:03 |
dhellmann | o/ | 15:03 |
bnemec | #topic Red flags for/from liaisons | 15:04 |
*** openstack changes topic to "Red flags for/from liaisons (Meeting topic: oslo)" | 15:04 | |
bnemec | Nothing that I'm aware of from last week. | 15:05 |
*** bobh has joined #openstack-oslo | 15:05 | |
bnemec | #topic Releases | 15:06 |
*** openstack changes topic to "Releases (Meeting topic: oslo)" | 15:06 | |
bnemec | We released castellan last week as an FFE. | 15:06 |
bnemec | Otherwise that was it. | 15:07 |
bnemec | I guess now that we're past the rc date we can start releasing stein? | 15:07 |
*** phuongnh has joined #openstack-oslo | 15:08 | |
kgiusti | bnemec: there are a few deprecations that are due to land | 15:08 |
kgiusti | bnemec: they need to be done earlier rather than later | 15:08 |
kgiusti | I'm assuming it's ok to start that process now on master, no? | 15:09 |
bnemec | kgiusti: deprecations or removals? | 15:09 |
kgiusti | bnemec: gah - deprecated things that are due for removal, sorry | 15:09 |
kgiusti | bnemec: remove them now? | 15:09 |
openstackgerrit | Chuck Short proposed openstack/oslo.privsep master: Replace assertRaisesRegexp with assertRaisesRegex https://review.openstack.org/596793 | 15:10 |
bnemec | kgiusti: Yeah, that's good to do early. | 15:10 |
kgiusti | ok thanks | 15:11 |
bnemec | And I'll take a todo to figure out if we're good to start releasing stein versions of things. | 15:13 |
bnemec | #action bnemec check if we can release stein libraries | 15:13 |
bnemec | #topic Action items from last meeting | 15:14 |
*** openstack changes topic to "Action items from last meeting (Meeting topic: oslo)" | 15:14 | |
bnemec | "Review patches listed in http://paste.openstack.org/show/727932/" | 15:14 |
bnemec | I believe we got through some of them, at least. | 15:14 |
bnemec | Have spent a lot of time chasing broken repos though. | 15:15 |
bnemec | We made progress on that too, fortunately. | 15:15 |
dhellmann | here's a new list, it's much shorter: | 15:15 |
dhellmann | #link http://paste.openstack.org/show/728832 | 15:15 |
dhellmann | looks like 23 left, if I'm doing math right | 15:15 |
bnemec | Okay, thanks. | 15:16 |
bnemec | #action review patches listed in http://paste.openstack.org/show/728832/ | 15:16 |
bnemec | "add moguimar to core ACL after review period ends" | 15:17 |
bnemec | Done | 15:17 |
bnemec | "review stestr migration backports" | 15:18 |
bnemec | I have one more that still needs to go in. | 15:18 |
bnemec | #link https://review.openstack.org/#/c/588060/ | 15:18 |
*** e0ne has quit IRC | 15:19 | |
bnemec | Oh, there's also one for taskflow. | 15:19 |
bnemec | #link https://review.openstack.org/#/c/594439/ | 15:19 |
bnemec | So let's get those landed. | 15:20 |
bnemec | Otherwise that was it for action items. | 15:20 |
bnemec | #topic PTG planning etherpad | 15:21 |
*** openstack changes topic to "PTG planning etherpad (Meeting topic: oslo)" | 15:21 | |
bnemec | #link https://etherpad.openstack.org/p/oslo-stein-ptg-planning | 15:21 |
dhellmann | bnemec : it looks like https://review.openstack.org/#/c/594439/2 depends on a patch I rolled into another one, so it might need a rebase | 15:21 |
bnemec | This is probably the final reminder of that. | 15:21 |
bnemec | dhellmann: Those two actually work as plain backports without combining anything. | 15:22 |
dhellmann | looking at the "related changes" list, it appears to be stacked in a series? | 15:23 |
bnemec | (at least I think they were both passing) | 15:23 |
dhellmann | sorry, I didn't notice there was a literal depends-on too | 15:23 |
dhellmann | the depends-on links to a master patch | 15:23 |
dhellmann | that has been merged | 15:23 |
dhellmann | so I'm talking about https://review.openstack.org/#/c/591245/1 | 15:24 |
bnemec | Oh, I should have removed that. | 15:24 |
bnemec | Although it should be a noop since it's stacked on the backport of the master patch. | 15:24 |
dhellmann | so we want that one instead of my jumbo patch? | 15:24 |
bnemec | It feels a little cleaner if we don't have to squash patches. | 15:25 |
dhellmann | I guess it does pass, so +2 | 15:25 |
dhellmann | agreed | 15:25 |
bnemec | Apparently the stestr migration isn't strictly necessary for this repo, but I think it's a good thing to do anyway. | 15:25 |
*** rmascena__ is now known as raildo | 15:26 | |
bnemec | Okay, I approved the pydot backport too so that should land now. | 15:26 |
bnemec | Thanks | 15:26 |
*** r-mibu has quit IRC | 15:27 | |
bnemec | I think that takes care of the broken repos topic too. | 15:27 |
bnemec | There may be others, but we'll fix them as we find them. | 15:28 |
bnemec | #topic PTG team photo | 15:28 |
*** openstack changes topic to "PTG team photo (Meeting topic: oslo)" | 15:28 | |
bnemec | Specifically, does anyone want to do one? | 15:28 |
bnemec | I don't think we have in the past for this team, but I got the email about signing up last week. | 15:28 |
dhellmann | I'll join in if we do one, but won't push folks to do it if there's not much interest | 15:29 |
*** pcaruana has quit IRC | 15:29 | |
bnemec | I'm not much of a picture person, so I probably won't sign us up unless someone specifically asks. :-) | 15:30 |
openstackgerrit | Merged openstack/devstack-plugin-pika master: import zuul job settings from project-config https://review.openstack.org/588686 | 15:30 |
dhellmann | maybe we can get some body doubles to stand in for us | 15:30 |
bnemec | I like that plan. :-D | 15:32 |
bnemec | Anyway, contact me if you want a team picture from the PTG and I can ask about open time slots. | 15:32 |
bnemec | #topic VMT? | 15:33 |
*** openstack changes topic to "VMT? (Meeting topic: oslo)" | 15:33 | |
bnemec | This came up last week. | 15:33 |
bnemec | Apparently the Oslo projects aren't vulnerability managed by the OpenStack VMT. | 15:33 |
bnemec | I can't remember if there was a reason for that or if it was just an oversight. | 15:33 |
dhellmann | I imagine that initially they focused on the services | 15:34 |
bnemec | It _seems_ like we would want to be managed. | 15:34 |
dhellmann | I agree, if they have the capacity to do it | 15:34 |
bnemec | The services are only as secure as the libraries they use. | 15:35 |
bnemec | Okay, I'll look into whether they would be willing to take us on. | 15:35 |
dhellmann | yeah, we may just need to ask | 15:35 |
bnemec | #action bnemec to check with VMT about Oslo libraries | 15:35 |
openstackgerrit | Merged openstack/devstack-plugin-zmq master: import zuul job settings from project-config https://review.openstack.org/595988 | 15:35 |
bnemec | #topic uuidsentinel | 15:36 |
*** openstack changes topic to "uuidsentinel (Meeting topic: oslo)" | 15:36 | |
bnemec | This spawned quite the mailing list thread, so I thought I'd bring it up here in case we wanted to pull some more people into the meeting and have a more direct conversation. | 15:37 |
dhellmann | sorry for throwing a wrench in that right before taking a day off | 15:37 |
openstackgerrit | Merged openstack/devstack-plugin-pika master: import zuul job settings from project-config https://review.openstack.org/595987 | 15:38 |
dhellmann | it seems like the main feature of this thing is the simple API, so making a fixture would make it harder to use | 15:38 |
dhellmann | so we have 2 ways to handle the global | 15:38 |
dhellmann | 1. we take the class, and nova keeps the global. The benefit there is adopting it in nova wouldn't require so many updates to imports. I'm not sure how much of a real benefit that is. | 15:39 |
dhellmann | 2. we take the class and add a global. That makes it easier to document how to use it and the adoption can just import the instance from oslo.utils | 15:40 |
dhellmann | I'm not counting the idea of adding the global to sys.modules because I don't want us to do that. | 15:40 |
bnemec | I guess 1 would be like i18n, where the classes live in oslo but each project has an integration module. | 15:40 |
dhellmann | yeah | 15:40 |
dhellmann | that seems heavy for this case | 15:41 |
dhellmann | there's no special configuration to do, like in i18n | 15:41 |
bnemec | Yeah | 15:41 |
bnemec | I guess I'm more comfortable with the global if it's in oslotest so it can't accidentally be abused in production code. | 15:42 |
bnemec | Mock has this pattern too, but AIUI mock is only used for testing. | 15:43 |
bnemec | (although I've been wrong about that kind of thing before) | 15:43 |
dhellmann | ok, I guess I can go along with putting it in oslotest | 15:44 |
bnemec | I know Eric wanted it in utils because of uuidutils, but the fact that they share a name isn't a strong technical argument to me. | 15:46 |
bnemec | oslo.utils is a runtime library and this is a test module. | 15:46 |
dhellmann | I don't think we want oslotest to depend on oslo.utils, so if we reimplement this to just call the uuid module directly that should be ok | 15:46 |
bnemec | There's precedent to have test fixtures in runtime libs, but if we're not going to do this as a fixture then I'm less comfortable with it. | 15:47 |
dhellmann | yeah | 15:47 |
bnemec | Oh, that's right. There was the dependency thing too. | 15:47 |
dhellmann | I guess we could also put it into oslo_utils.fixture | 15:47 |
*** gcb_ has quit IRC | 15:48 | |
*** nicolasbock has quit IRC | 15:49 | |
dhellmann | so either a new module in oslotest or oslo_utils.fixture works for me | 15:50 |
dhellmann | I don't have a very strong opinion about either | 15:50 |
dhellmann | I would probably lean slightly towards the latter | 15:50 |
bnemec | I suppose we could add it as a fixture but also provide the global for projects that are okay with that pattern? | 15:51 |
dhellmann | oh, I meant just add the global in oslo_utils.fixture as a way to indicate that it's test code | 15:51 |
dhellmann | so take all of efried's code and put it in that module and then nova's tests can import the instance of the global from there | 15:52 |
bnemec | Yeah, I'm just thinking that if we do both then we don't force that choice on anyone. | 15:52 |
dhellmann | sure, though I can't imagine anyone using the more cumbersome API if they have the easy one | 15:52 |
openstackgerrit | Clint 'SpamapS' Byrum proposed openstack/oslo.tools master: Remove spamaps from pings https://review.openstack.org/596828 | 15:52 |
bnemec | Well, some people really dislike globals. :-) | 15:52 |
dhellmann | sure | 15:52 |
dhellmann | we could always add the fixture later if someone wants it | 15:53 |
dhellmann | or now if you do :-) | 15:53 |
openstackgerrit | Merged openstack/oslo.tools master: Remove spamaps from pings https://review.openstack.org/596828 | 15:53 |
bnemec | No, I don't feel anywhere near that strongly about it. | 15:53 |
dhellmann | I jumped in early with an opinion, but it's not very strongly held, so as long as folks are happy with the thing it's fine with me | 15:54 |
bnemec | This seems like a pretty harmless use of globals. | 15:54 |
dhellmann | yeah | 15:54 |
dhellmann | my anti-pattern detector has a hair trigger :-) | 15:54 |
bnemec | I've never really believed in absolute rules for programming. | 15:54 |
bnemec | It's a code smell for sure. | 15:54 |
SpamapS | I have one absolute rule for programming. No rules. Ever. | 15:54 |
bnemec | :-) | 15:55 |
phuongnh | :) | 15:55 |
bnemec | dhellmann: Do you want to propose that on the list then? | 15:56 |
* bnemec can't remember exactly where that discussion ended up | 15:56 | |
bnemec | Other than the proposal to resurrect incubator. ;-) | 15:57 |
dhellmann | so I'll propose we add eric's code to oslo_utils.fixture? | 15:57 |
openstackgerrit | Merged openstack/oslo.service master: Skips signal handling on Windows https://review.openstack.org/593897 | 15:57 |
bnemec | Yeah | 15:57 |
dhellmann | ok | 15:58 |
bnemec | #action dhellmann to respond to uuidsentinel thread | 15:59 |
bnemec | Okay, we're just about out of time | 15:59 |
bnemec | #topic Open discussion | 15:59 |
*** openstack changes topic to "Open discussion (Meeting topic: oslo)" | 15:59 | |
dhellmann | #link http://lists.openstack.org/pipermail/openstack-dev/2018-August/133861.html | 15:59 |
bnemec | I guess the one thing would be that next Monday is a US holiday, so I won't be around to run the meeting. | 16:00 |
bnemec | I suspect a lot of our team won't be either. | 16:00 |
dhellmann | I will be off | 16:00 |
bnemec | So I'm thinking we just cancel? | 16:00 |
dhellmann | wfm | 16:00 |
kgiusti | +1 | 16:01 |
bnemec | The PTG is the next week so we'll just have to finish any last-minute scheduling asynchronously. | 16:01 |
bnemec | #action bnemec cancel oslo meeting for next week | 16:01 |
bnemec | Okay, we're over time. Thanks for joining everyone! | 16:02 |
bnemec | #endmeeting | 16:02 |
*** openstack changes topic to "OpenStack Common Libraries | https://wiki.openstack.org/wiki/Oslo" | 16:02 | |
openstack | Meeting ended Mon Aug 27 16:02:39 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:02 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/oslo/2018/oslo.2018-08-27-15.01.html | 16:02 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/oslo/2018/oslo.2018-08-27-15.01.txt | 16:02 |
openstack | Log: http://eavesdrop.openstack.org/meetings/oslo/2018/oslo.2018-08-27-15.01.log.html | 16:02 |
phuongnh | hi bnemec, I am Phuong from Fujitsu, I and my colleague will continue maintaining the "Handle config mapping changes" patchset | 16:03 |
phuongnh | https://review.openstack.org/#/c/526314/ | 16:03 |
dhellmann | hi, phuongnh | 16:03 |
phuongnh | bnemec: could you please tell me what should we do next? Updating spec based on your and dhellmann's comments? | 16:04 |
phuongnh | hi dhellmann | 16:04 |
dhellmann | I still need to review that for you. I apologize that it has taken me so long to respond. | 16:04 |
bnemec | It's a big review. I had a hard time getting through the whole thing in one sitting. | 16:05 |
phuongnh | oh, sorry dhellmann, it is not to remind you, I would like to know which action after that | 16:05 |
dhellmann | phuongnh : I think right now you are waiting for us and there is nothing for you to do, yet. | 16:06 |
phuongnh | dhellmann: thanks, I would like to get this feature merged soon so if I need to do anything, please tell me | 16:08 |
dhellmann | phuongnh : I definitely will. I will try to review things this week. | 16:08 |
phuongnh | bnemec, dhellmann: thank you a lot | 16:09 |
ducnv_ | hi bnemec, dhellmann I'm Phuong's colleague. Thanks you a lot | 16:11 |
*** cdent has quit IRC | 16:11 | |
dhellmann | hi, ducnv_ | 16:12 |
ducnv_ | I look forward to receiving your review soon , dhellmann :)) | 16:15 |
*** cdent has joined #openstack-oslo | 16:16 | |
*** ducnv_ has quit IRC | 16:23 | |
*** pcaruana has joined #openstack-oslo | 16:26 | |
*** raildo_ has joined #openstack-oslo | 16:31 | |
*** raildo has quit IRC | 16:32 | |
*** bobh has quit IRC | 16:36 | |
*** jlviva-viva is now known as jlvillal | 16:40 | |
*** raildo_ is now known as raildo | 16:41 | |
*** e0ne has joined #openstack-oslo | 16:41 | |
openstackgerrit | Eric Fried proposed openstack/oslo.utils master: UUID sentinel https://review.openstack.org/594179 | 16:43 |
*** raildo has quit IRC | 16:48 | |
*** raildo has joined #openstack-oslo | 16:48 | |
*** phuongnh has quit IRC | 16:55 | |
*** raildo_ has joined #openstack-oslo | 17:03 | |
*** openstackgerrit has quit IRC | 17:04 | |
*** raildo has quit IRC | 17:05 | |
*** bobh has joined #openstack-oslo | 17:11 | |
*** rmascena__ has joined #openstack-oslo | 17:16 | |
*** raildo has joined #openstack-oslo | 17:18 | |
*** raildo_ has quit IRC | 17:18 | |
*** rmascena__ has quit IRC | 17:21 | |
*** raildo_ has joined #openstack-oslo | 17:22 | |
*** raildo has quit IRC | 17:23 | |
*** openstackgerrit has joined #openstack-oslo | 17:25 | |
openstackgerrit | Merged openstack/taskflow stable/rocky: Add pydot test dependency https://review.openstack.org/591245 | 17:25 |
*** raildo_ has quit IRC | 17:28 | |
*** bobh has quit IRC | 17:29 | |
*** bobh has joined #openstack-oslo | 17:29 | |
openstackgerrit | Merged openstack/oslo.config master: Replace assertRaisesRegexp with assertRaisesRegex https://review.openstack.org/596732 | 17:31 |
openstackgerrit | Merged openstack/taskflow stable/rocky: Switch to use stestr for unit test https://review.openstack.org/594439 | 17:39 |
*** raildo has joined #openstack-oslo | 17:40 | |
dhellmann | bnemec : after I abandoned all of the redundant python3-first patches for oslo repos, we're down to 3 left to land: https://review.openstack.org/588780 https://review.openstack.org/591801 and https://review.openstack.org/596008 | 17:46 |
dhellmann | kgiusti : should we just remove the failing test jobs for the kafka plugin in stable/queens ? https://review.openstack.org/591801 | 17:46 |
bnemec | dhellmann: Ah, nice. | 17:47 |
*** mattgo has quit IRC | 17:47 | |
dhellmann | yeah, I wondered why that number was still so high | 17:48 |
openstackgerrit | Eric Fried proposed openstack/oslo.utils master: UUID sentinel https://review.openstack.org/594179 | 17:50 |
openstackgerrit | Ben Nemec proposed openstack-dev/pbr master: Add release note for fix to bug 1786306 https://review.openstack.org/596755 | 17:51 |
openstack | bug 1786306 in PBR "pbr doesn't work when there's subdirectory in url " [Undecided,Fix released] https://launchpad.net/bugs/1786306 - Assigned to Wei T (nuaafe) | 17:51 |
openstackgerrit | Ben Nemec proposed openstack/oslo.log master: Filter args dict in JSONFormatter https://review.openstack.org/596850 | 17:54 |
bnemec | dhellmann: kgiusti: ^ | 17:54 |
bnemec | I'm going to make those bugs public now that we've got all the patches up. | 17:55 |
kgiusti | dhellmann: sorry in meeting: yes it's just noise ^^^ ansmith agreed? | 17:56 |
dhellmann | kgiusti : ok, I'll update that patch to drop the jobs that fail | 17:56 |
kgiusti | ah, crap - I have another meeting... | 17:57 |
dhellmann | we have to have some test running there to ever land a patch on that branch, so I guess I'll leave bashat3 | 17:57 |
kgiusti | bnemec: https://review.openstack.org/#/q/topic:bug/1787214+(status:open+OR+status:merged) | 17:57 |
kgiusti | bnemec: these are the backports of that fix that need to land as well - need some reviews (hint hint) | 17:58 |
dhellmann | there are a lot of non-voting jobs on some of our stable branches; we should clean those up | 17:58 |
bnemec | kgiusti: Yep, thanks. I hadn't seen that the backports were up. | 17:58 |
kgiusti | dhellmann: there are some non-voting jobs that really should be voting - esp in the amqp1 driver case | 17:58 |
kgiusti | dhellmann: need to run - back in an hour fyi | 17:59 |
dhellmann | kgiusti : ack, "clean up" not "remove" | 17:59 |
bnemec | kgiusti: I think the backport pulled in some comments that don't make sense on the stable branches. | 18:01 |
bnemec | (I left a comment on https://review.openstack.org/#/c/595338) | 18:02 |
openstackgerrit | Eric Fried proposed openstack/oslo.utils master: UUID sentinel https://review.openstack.org/594179 | 18:11 |
*** cdent has quit IRC | 18:28 | |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging stable/ocata: Avoid logging passwords on connection events https://review.openstack.org/595343 | 18:41 |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging stable/pike: Avoid logging passwords on connection events https://review.openstack.org/595341 | 18:42 |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging stable/queens: Avoid logging passwords on connection events https://review.openstack.org/595338 | 18:43 |
kgiusti | bnemec: removed the offending comment from ocata, pike, and queens patches | 18:45 |
bnemec | kgiusti: Thanks! | 18:50 |
dhellmann | dansmith : if you have a second, I'd like to talk about the uuidsentinel thing. I think there's some detail I'm missing. | 19:07 |
dansmith | dhellmann: a detail you're missing with the current version of the patch or the previous one? | 19:08 |
dhellmann | if you're happy with the current version, then I am | 19:08 |
dhellmann | I thought you were saying that importing an instance wouldn't work | 19:08 |
dansmith | dhellmann: aside from the long import line, I think the current version behaves like it should | 19:08 |
dhellmann | ok, cool | 19:08 |
dansmith | we're not supposed to be able to import an instance, so I dunno if pep8 will allow us to do this | 19:08 |
dhellmann | you can tell flake8 to ignore that rule for specific symbols | 19:09 |
dhellmann | we had to do that with the i18n stuff | 19:09 |
dansmith | ack | 19:09 |
dhellmann | dansmith : a +1 from you would help ensure that's approved quickly | 19:11 |
*** pcaruana has quit IRC | 19:13 | |
*** e0ne has quit IRC | 19:27 | |
*** e0ne has joined #openstack-oslo | 19:29 | |
openstackgerrit | Merged openstack-dev/pbr master: Add release note for fix to bug 1786306 https://review.openstack.org/596755 | 19:44 |
openstack | bug 1786306 in PBR "pbr doesn't work when there's subdirectory in url " [Undecided,Fix released] https://launchpad.net/bugs/1786306 - Assigned to Wei T (nuaafe) | 19:44 |
*** e0ne has quit IRC | 19:44 | |
*** e0ne has joined #openstack-oslo | 20:00 | |
openstackgerrit | Andy Smith proposed openstack/oslo.messaging master: Remove the deprecated ZeroMQ driver https://review.openstack.org/596882 | 20:03 |
*** kgiusti has left #openstack-oslo | 20:21 | |
*** nicolasbock has joined #openstack-oslo | 20:30 | |
*** raildo has quit IRC | 20:32 | |
*** ansmith has quit IRC | 20:37 | |
*** e0ne has quit IRC | 20:37 | |
openstackgerrit | Claudiu Belu proposed openstack/oslotest master: WIP: mock: Fixes missing _autospec key issue https://review.openstack.org/596892 | 20:45 |
*** raildo has joined #openstack-oslo | 20:54 | |
*** raildo has quit IRC | 20:54 | |
*** mriedem has joined #openstack-oslo | 21:00 | |
mriedem | is there a way to refer to a config option group like :oslo.config:option:`placement` but need to tell the tooling that it's not assumed to be in the DEFAULT group? | 21:00 |
mriedem | i.e. i'm getting KeyError: 'DEFAULT.placement' | 21:01 |
mriedem | but [placement] is the group name | 21:01 |
mriedem | oh i see | 21:02 |
mriedem | :oslo.config:group:`placement` | 21:02 |
* mriedem leaves in shame | 21:02 | |
*** mriedem has left #openstack-oslo | 21:02 | |
openstackgerrit | Zane Bitter proposed openstack/oslo.service stable/rocky: Add Python 3.5 jobs https://review.openstack.org/596897 | 21:09 |
*** rcernin has joined #openstack-oslo | 21:51 | |
*** bobh has quit IRC | 22:07 | |
*** nicolasbock has quit IRC | 22:39 | |
*** pbourke has quit IRC | 22:40 | |
*** pbourke has joined #openstack-oslo | 22:41 | |
tommylikehu | hey, bnemec, could you review these patches again? https://review.openstack.org/#/c/593561 | 22:43 |
tommylikehu | https://review.openstack.org/#/c/593556/, thanks:) | 22:43 |
*** nicolasbock has joined #openstack-oslo | 22:44 | |
bnemec | tommylikehu: It's the end of my day here, but I'll take a look tomorrow. | 22:47 |
*** bnemec has quit IRC | 23:00 | |
*** bnemec has joined #openstack-oslo | 23:01 | |
*** nicolasbock has quit IRC | 23:07 | |
*** rha has quit IRC | 23:24 | |
openstackgerrit | Merged openstack/oslo.service stable/rocky: import zuul job settings from project-config https://review.openstack.org/596008 | 23:37 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!