*** jaosorior has quit IRC | 00:05 | |
*** hoonetorg has quit IRC | 00:09 | |
*** tosky has quit IRC | 00:13 | |
*** hoonetorg has joined #openstack-oslo | 00:22 | |
*** Liang__ has joined #openstack-oslo | 00:27 | |
*** sean-k-mooney has quit IRC | 00:44 | |
openstackgerrit | Agate Wang proposed openstack/oslo-specs master: Add placeholder for Train specs https://review.openstack.org/617911 | 00:58 |
---|---|---|
*** sean-k-mooney has joined #openstack-oslo | 00:58 | |
*** Liang__ is now known as LiangFang | 01:31 | |
*** bobh has joined #openstack-oslo | 02:36 | |
*** zaneb has quit IRC | 02:41 | |
*** bobh has quit IRC | 02:41 | |
*** bobh has joined #openstack-oslo | 03:08 | |
*** bobh has quit IRC | 03:12 | |
*** cdent has quit IRC | 03:28 | |
*** chhagarw has joined #openstack-oslo | 03:59 | |
*** hoangcx has joined #openstack-oslo | 04:11 | |
*** lpetrut has joined #openstack-oslo | 04:51 | |
*** pcaruana has joined #openstack-oslo | 05:09 | |
*** lpetrut has quit IRC | 05:28 | |
*** e0ne has joined #openstack-oslo | 05:37 | |
*** e0ne has quit IRC | 05:42 | |
*** e0ne has joined #openstack-oslo | 05:44 | |
*** e0ne has quit IRC | 05:45 | |
*** jaosorior has joined #openstack-oslo | 06:36 | |
*** rcernin has quit IRC | 06:57 | |
*** Luzi has joined #openstack-oslo | 07:00 | |
*** moguimar has joined #openstack-oslo | 07:02 | |
*** LiangFang has quit IRC | 07:50 | |
*** e0ne has joined #openstack-oslo | 07:54 | |
*** e0ne has quit IRC | 08:37 | |
*** hberaud|gone is now known as hberaud | 08:43 | |
*** tosky has joined #openstack-oslo | 08:51 | |
*** shardy has joined #openstack-oslo | 09:10 | |
openstackgerrit | Yikun Jiang proposed openstack/oslo.config master: Add PositiveFloat type https://review.openstack.org/620547 | 10:01 |
*** dougsz has joined #openstack-oslo | 10:08 | |
*** Liang__ has joined #openstack-oslo | 10:10 | |
*** cdent has joined #openstack-oslo | 10:11 | |
*** e0ne has joined #openstack-oslo | 10:14 | |
*** Liang__ has quit IRC | 10:48 | |
*** hberaud is now known as hberaud|lunch | 10:56 | |
*** raildo has joined #openstack-oslo | 11:48 | |
*** hberaud|lunch is now known as hberaud | 12:01 | |
*** e0ne has quit IRC | 12:09 | |
*** ansmith has quit IRC | 12:17 | |
*** takamatsu has quit IRC | 12:37 | |
*** takamatsu has joined #openstack-oslo | 12:43 | |
*** e0ne has joined #openstack-oslo | 13:05 | |
*** Liang__ has joined #openstack-oslo | 13:13 | |
*** takamatsu has quit IRC | 13:29 | |
*** takamatsu has joined #openstack-oslo | 13:30 | |
*** takamatsu has quit IRC | 13:44 | |
*** takamatsu has joined #openstack-oslo | 13:48 | |
*** kgiusti has joined #openstack-oslo | 13:51 | |
*** zaneb has joined #openstack-oslo | 14:00 | |
*** ansmith has joined #openstack-oslo | 14:16 | |
*** bobh has joined #openstack-oslo | 15:03 | |
lbragstad | bnemec thanks for the review on https://review.openstack.org/#/c/613635/ | 15:27 |
lbragstad | think it will be possible to get that into the next release? | 15:27 |
bnemec | lbragstad: If we can get dhellmann or kgiusti to approve it. :-) | 15:30 |
bnemec | (it's a two line change + unit tests) | 15:30 |
lbragstad | sweet | 15:30 |
kgiusti | bnemec summons kgiusti.... | 15:32 |
*** pbourke has quit IRC | 15:37 | |
*** pbourke has joined #openstack-oslo | 15:38 | |
openstackgerrit | Yikun Jiang proposed openstack/oslo.config master: Add PositiveFloat type https://review.openstack.org/620547 | 15:42 |
dhellmann | bnemec , zaneb , hberaud : did you all work out what to do with that oslo.service backport while I was out sick? | 15:52 |
zaneb | I think we're close | 15:52 |
bnemec | I've voted on all the patches and replied to the list thread last night. | 15:53 |
hberaud | I think we need to adopt the #4 proposed solution http://lists.openstack.org/pipermail/openstack-discuss/2018-November/000179.html | 15:53 |
hberaud | dhellmann: me too I've +1 elected solution | 15:54 |
zaneb | we *need* to adopt #3, but it's a good idea to do #4 as well | 15:55 |
bnemec | Agreed^ | 15:55 |
zaneb | anyhow, I removed the debtcollector dependency (but kept the warnings), so there should be no obstacle to merging #3 | 15:57 |
zaneb | and tests are passing, although clearly we need to look at that (unrelated) flaky test | 15:58 |
*** dougsz has left #openstack-oslo | 15:58 | |
hberaud | so... we can adopt the both? | 15:59 |
dhellmann | where can I help with reviews? | 16:00 |
hberaud | #4 only have +1 | 16:00 |
zaneb | dhellmann: https://review.openstack.org/#/c/619342/ | 16:00 |
hberaud | dhellmann: https://review.openstack.org/#/c/619360/ | 16:01 |
dhellmann | zaneb : in https://review.openstack.org/#/c/619342/4 I'm struggling to understand when those warnings would ever be emitted. | 16:03 |
dhellmann | the problem was code mocking out those functions, right? | 16:03 |
zaneb | dhellmann: the problem was code mocking out the wait() function | 16:04 |
zaneb | so those implementations are not even needed | 16:04 |
dhellmann | so this is just the belt-and-braces approach? | 16:05 |
zaneb | to be sure, to be sure | 16:05 |
dhellmann | k | 16:05 |
zaneb | s/function/method/ | 16:06 |
dhellmann | +2a on 619342 and +2 on 619360 | 16:06 |
zaneb | dhellmann: thanks! | 16:07 |
zaneb | bnemec: do you happen to remember if that flaky test is only flaky on stable/rocky, or also master? | 16:08 |
bnemec | zaneb: Based on the bug I linked, I suspect it's been flaky for as long as we've been testing py3 in oslo.service. | 16:10 |
* bnemec doesn't remember when that started though | 16:10 | |
zaneb | from memory it was during rocky | 16:10 |
zaneb | because I was the one who enabled it | 16:11 |
*** zbitter has joined #openstack-oslo | 16:12 | |
*** zaneb has quit IRC | 16:15 | |
*** Luzi has quit IRC | 16:15 | |
*** zbitter is now known as zaneb | 16:16 | |
*** Liang__ has quit IRC | 16:18 | |
lbragstad | thanks kgiusti! | 16:28 |
kgiusti | lbragstad: my pleasure! | 16:36 |
*** lbragstad has quit IRC | 17:02 | |
*** e0ne has quit IRC | 17:02 | |
*** pcaruana has quit IRC | 17:03 | |
*** lbragstad has joined #openstack-oslo | 17:05 | |
*** bobh has quit IRC | 17:13 | |
openstackgerrit | Merged openstack/oslo.context master: Implement domain-scope for context objects https://review.openstack.org/613635 | 17:25 |
openstackgerrit | Merged openstack/oslo.service stable/rocky: Maintain private interface for loopingcall._ThreadingEvent https://review.openstack.org/619342 | 18:03 |
*** hberaud is now known as hberaud|gone | 18:07 | |
*** shardy has quit IRC | 18:11 | |
*** chhagarw has quit IRC | 18:41 | |
*** e0ne has joined #openstack-oslo | 19:07 | |
*** lbragstad has quit IRC | 19:08 | |
*** lbragstad has joined #openstack-oslo | 19:12 | |
*** lbragstad has quit IRC | 19:12 | |
*** lbragstad has joined #openstack-oslo | 19:14 | |
*** lbragstad has quit IRC | 19:14 | |
*** e0ne has quit IRC | 19:15 | |
*** lbragstad has joined #openstack-oslo | 19:16 | |
*** lbragstad has quit IRC | 19:16 | |
*** cdent has quit IRC | 19:17 | |
*** e0ne has joined #openstack-oslo | 19:17 | |
*** e0ne has quit IRC | 19:18 | |
openstackgerrit | Ben Nemec proposed openstack/oslo.utils master: Support non-dict mappings in mask_dict_password https://review.openstack.org/620686 | 19:40 |
*** e0ne has joined #openstack-oslo | 20:19 | |
*** e0ne has quit IRC | 20:20 | |
*** zaneb has quit IRC | 20:26 | |
*** zaneb has joined #openstack-oslo | 20:27 | |
*** lbragstad has joined #openstack-oslo | 20:30 | |
*** openstackgerrit has quit IRC | 20:36 | |
*** e0ne has joined #openstack-oslo | 20:40 | |
*** e0ne has quit IRC | 20:49 | |
*** raildo has quit IRC | 20:54 | |
zaneb | bnemec: https://review.openstack.org/#/c/619342/ merged, so we need to do a new release from stable/rocky, since the last one was blacklisted | 20:57 |
bnemec | zaneb: Ack. I'll check if there are any other Rocky releases needed too. | 21:03 |
*** openstackgerrit has joined #openstack-oslo | 21:14 | |
openstackgerrit | Zane Bitter proposed openstack/oslo.utils master: Fix race condition in eventletutils Event https://review.openstack.org/618482 | 21:14 |
*** e0ne has joined #openstack-oslo | 21:21 | |
*** e0ne has quit IRC | 21:21 | |
*** e0ne has joined #openstack-oslo | 21:26 | |
*** e0ne has quit IRC | 21:27 | |
*** lbragstad has quit IRC | 21:37 | |
*** lbragstad has joined #openstack-oslo | 21:37 | |
*** rcernin has joined #openstack-oslo | 21:50 | |
*** ansmith has quit IRC | 21:59 | |
*** rcernin has quit IRC | 22:03 | |
*** rcernin has joined #openstack-oslo | 22:12 | |
*** kgiusti has left #openstack-oslo | 22:20 | |
*** mdomke has joined #openstack-oslo | 22:22 | |
mdomke | I created a merge request a couple of days ago to the pbr repository. It is only a minor change that fixes the version derivation from SemVer compliant git tags. I wonder if somebody could have a look at it https://review.openstack.org/#/c/618569/2. Thanks in advance! | 22:22 |
*** mdomke has quit IRC | 22:37 | |
*** pbourke has quit IRC | 23:30 | |
*** pbourke has joined #openstack-oslo | 23:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!