| *** moguimar has quit IRC | 00:12 | |
| *** tosky has quit IRC | 00:21 | |
| *** Liang__ has joined #openstack-oslo | 00:54 | |
| *** gmann_pto is now known as gmann | 01:07 | |
| *** bobh has joined #openstack-oslo | 02:39 | |
| *** bobh has quit IRC | 02:43 | |
| *** raildo has quit IRC | 02:51 | |
| *** d0ugal has quit IRC | 03:19 | |
| *** gus has quit IRC | 03:19 | |
| *** gus has joined #openstack-oslo | 03:20 | |
| *** d0ugal has joined #openstack-oslo | 03:33 | |
| *** lpetrut has joined #openstack-oslo | 04:46 | |
| *** lbragstad has quit IRC | 05:12 | |
| *** lpetrut has quit IRC | 05:15 | |
| *** Liang__ has quit IRC | 05:58 | |
| *** Liang__ has joined #openstack-oslo | 06:01 | |
| *** dave-mccowan has quit IRC | 06:41 | |
| *** rcernin has quit IRC | 06:44 | |
| *** rcernin has joined #openstack-oslo | 06:44 | |
| *** rcernin has quit IRC | 07:03 | |
| *** lpetrut has joined #openstack-oslo | 07:04 | |
| *** Luzi has joined #openstack-oslo | 07:35 | |
| *** tosky has joined #openstack-oslo | 07:49 | |
| *** pcaruana has joined #openstack-oslo | 07:51 | |
| *** Liang__ has quit IRC | 08:05 | |
| *** Liang__ has joined #openstack-oslo | 08:11 | |
| *** hberaud has joined #openstack-oslo | 08:24 | |
| *** nsmeds has quit IRC | 08:51 | |
| *** shardy has joined #openstack-oslo | 09:10 | |
| *** shardy has quit IRC | 09:13 | |
| *** shardy has joined #openstack-oslo | 09:13 | |
| *** bobh has joined #openstack-oslo | 09:19 | |
| *** Liang__ has quit IRC | 09:32 | |
| *** e0ne has joined #openstack-oslo | 09:33 | |
| *** mmethot has quit IRC | 09:55 | |
| *** mmethot has joined #openstack-oslo | 09:56 | |
| *** jaosorior has quit IRC | 10:00 | |
| *** bobh has quit IRC | 10:19 | |
| *** hberaud has quit IRC | 10:32 | |
| *** hberaud has joined #openstack-oslo | 10:33 | |
| *** yan0s has joined #openstack-oslo | 10:45 | |
| *** e0ne has quit IRC | 10:47 | |
| *** e0ne has joined #openstack-oslo | 10:50 | |
| *** jaosorior has joined #openstack-oslo | 11:01 | |
| *** openstackgerrit has quit IRC | 11:05 | |
| *** pbourke has quit IRC | 11:11 | |
| *** pbourke has joined #openstack-oslo | 11:13 | |
| *** shardy has quit IRC | 11:14 | |
| *** shardy has joined #openstack-oslo | 11:46 | |
| *** pbourke has left #openstack-oslo | 11:51 | |
| *** aojea has joined #openstack-oslo | 12:05 | |
| *** openstackgerrit has joined #openstack-oslo | 12:10 | |
| openstackgerrit | Merged openstack/oslo.concurrency master: Stop using setup.py build_sphinx https://review.openstack.org/629682 | 12:10 |
|---|---|---|
| *** cdent has joined #openstack-oslo | 12:16 | |
| *** raildo has joined #openstack-oslo | 12:29 | |
| *** raildo has quit IRC | 13:13 | |
| *** dave-mccowan has joined #openstack-oslo | 13:18 | |
| *** raildo has joined #openstack-oslo | 13:24 | |
| *** e0ne has quit IRC | 13:30 | |
| *** ansmith_ has joined #openstack-oslo | 13:41 | |
| *** dave-mccowan has quit IRC | 13:48 | |
| *** dave-mccowan has joined #openstack-oslo | 13:50 | |
| *** lbragstad has joined #openstack-oslo | 13:55 | |
| *** lbragstad has quit IRC | 13:56 | |
| *** lbragstad has joined #openstack-oslo | 13:58 | |
| *** Liang__ has joined #openstack-oslo | 14:02 | |
| *** Liang__ is now known as LiangFang | 14:02 | |
| *** Luzi has quit IRC | 14:05 | |
| *** e0ne has joined #openstack-oslo | 14:10 | |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.config stable/queens: sphinxext: Separate parsing of group and opts https://review.openstack.org/629868 | 14:16 |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.config stable/queens: sphinxext: Start parsing 'Opt.help' as rST https://review.openstack.org/629869 | 14:16 |
| stephenfin | bnemec: I'm not sure if those qualify for stable/queens now, but they should help improve docs for projects like nova and fix bugs like I had to address in this backport https://review.openstack.org/#/c/629597/ | 14:17 |
| stephenfin | bnemec: (see the end of the second NOTE in the commit message) | 14:17 |
| *** kgiusti has joined #openstack-oslo | 14:17 | |
| bnemec | stephenfin: On the one hand, it does seem a bit like a feature, but on the other it is what people expect and it looks like the patch is basically just formatting tweaks. | 14:40 |
| bnemec | What actually triggers the parsing as RST? | 14:40 |
| bnemec | Does Sphinx do that automatically because we're passing in properly formatted input now? | 14:41 |
| stephenfin | The crucial bit is just this https://review.openstack.org/#/c/629869/1/oslo_config/sphinxext.py@153 | 14:41 |
| stephenfin | (the splitting of lines) | 14:41 |
| stephenfin | and the rest of the changes were necessary because they were generating invalid rST that wasn't being parsed before and therefore didn't cause issues | 14:42 |
| bnemec | Okay, given that it's basically just formatting changes to allow Sphinx to parse thing properly I feel like it's okay to backport. | 14:46 |
| *** shardy_ has joined #openstack-oslo | 14:57 | |
| *** shardy has quit IRC | 15:00 | |
| *** LiangFang has quit IRC | 15:03 | |
| *** moguimar has joined #openstack-oslo | 15:03 | |
| *** moguimar has quit IRC | 15:05 | |
| *** moguimar has joined #openstack-oslo | 15:05 | |
| *** lpetrut has quit IRC | 16:17 | |
| *** nsmeds has joined #openstack-oslo | 16:37 | |
| *** e0ne has quit IRC | 16:38 | |
| *** hberaud has quit IRC | 16:41 | |
| stephenfin | bnemec, kgiusti: should we look at taking openstack/sqlalchemy-migrate under oslo governance? I ask because it looks like nothing has been merged in a rather long time https://review.openstack.org/#/q/project:openstack/sqlalchemy-migrate | 16:42 |
| stephenfin | I'm not sure what it's under at the moment | 16:42 |
| bnemec | stephenfin: zzzeek can correct me if I'm wrong, but that project was sort of supposed to be abandoned in favor of alembic. | 16:44 |
| bnemec | Unfortunately I think a lot of projects didn't actually switch. | 16:44 |
| bnemec | stephenfin: Might want to discuss it with mriedem too. | 16:45 |
| stephenfin | bnemec: Oh, I wasn't aware of that. I might put something up about that on openstack-discuss | 16:47 |
| stephenfin | If so, nova, for one, hasn't switched over yet | 16:47 |
| bnemec | Yeah, I think migrate worked well enough for people that they didn't want the hassle. | 16:50 |
| bnemec | But it's been years since I last saw a discussion on this, so I think it would be totally fair to bring it up again. | 16:51 |
| zzzeek | bnemec: this is correct | 16:52 |
| zzzeek | bnemec: when nova split off placement, placement moved to alembic | 16:52 |
| zzzeek | bnemec: which was great. i had to help a little bit on that | 16:52 |
| stephenfin | zzzeek: I assume you're somewhat knowledgeable on all things sqlalchemy-migrate/alembic so? :) | 16:54 |
| zzzeek | stephenfin: I'm the creator/maintainer of alembic, I helped sqalhcemy-migrate when it was first created but I don't know it very well | 16:54 |
| stephenfin | zzzeek: Excellent | 16:54 |
| zzzeek | stephenfin: when I actualyl had to use sqlalhcemy-migrate, it was so crappy that I wrote alembic :) | 16:55 |
| stephenfin | zzzeek: So I'd be more than willing to work on migrating nova across, but I have no idea where to start | 16:55 |
| stephenfin | If you did some work on the placement migration, what's the chances of getting an etherpad with notes on how to do it? | 16:55 |
| zzzeek | stephenfin: ah! OK. lets do it. | 16:55 |
| stephenfin | \o/ | 16:55 |
| stephenfin | Happy to turn it into a doc against sqlalchemy-migrate, assuming you didn't want to do it yourself | 16:56 |
| stephenfin | Followed swiftly by a big deprecated warning in the README/docs | 16:56 |
| zzzeek | stephenfin: well, I think ed leafe might have been the person that actually did it. I think the hard part is, what do you do with old versions of nova installed that have sqlalhcemy-migrate revisions set up | 16:56 |
| stephenfin | That...I'm not so sure about. My knowledge of migration tooling does not extend outside of Django's migration framework | 16:57 |
| zzzeek | stephenfin: i think we'd want to see what other projects did, neutron comes to mind | 16:58 |
| stephenfin | OK, so we have an example to work of | 16:58 |
| zzzeek | stephenfin: but a minute of thought is giving me the basic steps: | 16:58 |
| stephenfin | *off | 16:59 |
| zzzeek | stephenfin: 1. add the code infra to be able to run alembic and remove the migrate code, so this is like nova/db/alembic (not sure of path) being added with env.py and the versions/ directory | 16:59 |
| openstackgerrit | Ben Nemec proposed openstack/oslo.config master: fix formatting of sample defaults https://review.openstack.org/607690 | 16:59 |
| zzzeek | stephenfin: then in versions/ you need to make an initial version script that represents the state of the nova database within this version. that's the initial rev | 17:00 |
| zzzeek | stephenfin: this can be generated by alembic to start then needs to be edited | 17:00 |
| zzzeek | stephenfin: then there probably needs to be a stub of some kind that will force this first version to be skipped in the case that you are migrating a sqlalchemy-migrate based nova installation | 17:01 |
| stephenfin | ^ that's what happens with placement, iirc | 17:01 |
| zzzeek | stephenfin: yah, it has to work that way | 17:01 |
| stephenfin | cool | 17:02 |
| zzzeek | stephenfin: so here: https://review.openstack.org/#/q/project:openstack/placement+branch:master+topic:alembic | 17:02 |
| zzzeek | stephenfin: that's all of it | 17:02 |
| stephenfin | zzzeek: Sweet | 17:03 |
| *** yan0s has quit IRC | 17:03 | |
| stephenfin | So I'll start tinkering with that and generate the sqlalchemy-migrate -> alembic migration doc as I go | 17:04 |
| zzzeek | stephenfin: yes keep me posted | 17:28 |
| *** kgiusti has left #openstack-oslo | 17:29 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.privsep master: Expose privsep options for config-generator https://review.openstack.org/629906 | 17:45 |
| *** shardy_ has quit IRC | 17:53 | |
| *** aojea has quit IRC | 17:58 | |
| *** e0ne has joined #openstack-oslo | 19:00 | |
| *** moguimar has quit IRC | 19:26 | |
| *** moguimar has joined #openstack-oslo | 19:27 | |
| *** moguimar has quit IRC | 19:32 | |
| *** moguimar has joined #openstack-oslo | 19:36 | |
| *** cdent has quit IRC | 19:38 | |
| *** moguimar has quit IRC | 19:41 | |
| *** moguimar has joined #openstack-oslo | 19:43 | |
| *** moguimar has quit IRC | 19:48 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.privsep master: Expose privsep options for config-generator https://review.openstack.org/629906 | 19:56 |
| openstackgerrit | Ben Nemec proposed openstack/oslo.config master: fix formatting of sample defaults https://review.openstack.org/607690 | 19:58 |
| *** openstackgerrit has quit IRC | 20:50 | |
| *** e0ne has quit IRC | 21:13 | |
| *** bobh has joined #openstack-oslo | 21:25 | |
| *** e0ne has joined #openstack-oslo | 21:30 | |
| *** bobh has quit IRC | 21:33 | |
| *** e0ne has quit IRC | 21:33 | |
| *** ansmith_ has quit IRC | 21:40 | |
| *** pcaruana has quit IRC | 21:46 | |
| *** openstackgerrit has joined #openstack-oslo | 22:06 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.service master: Use eventletutils Event class https://review.openstack.org/614809 | 22:06 |
| *** bobh has joined #openstack-oslo | 22:09 | |
| *** bobh has quit IRC | 22:15 | |
| openstackgerrit | Merged openstack/oslo.service stable/rocky: Restore correct signal handling in Python3 https://review.openstack.org/626398 | 22:23 |
| *** rcernin has joined #openstack-oslo | 22:38 | |
| *** e0ne has joined #openstack-oslo | 22:55 | |
| *** e0ne has quit IRC | 22:58 | |
| *** jbadiapa has quit IRC | 23:10 | |
| *** ansmith_ has joined #openstack-oslo | 23:11 | |
| *** edmondsw has quit IRC | 23:23 | |
| *** edmondsw has joined #openstack-oslo | 23:39 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!