| *** eandersson has quit IRC | 00:16 | |
| *** ansmith has joined #openstack-oslo | 00:22 | |
| openstackgerrit | Merged openstack/oslo.messaging stable/queens: Mark telemetry tests nv and remove from gate https://review.openstack.org/639126 | 00:23 |
|---|---|---|
| *** tosky has quit IRC | 00:23 | |
| *** ansmith has quit IRC | 00:27 | |
| *** jaosorior has quit IRC | 01:20 | |
| *** jaosorior has joined #openstack-oslo | 01:32 | |
| *** lbragstad has quit IRC | 02:44 | |
| *** dave-mccowan has quit IRC | 04:44 | |
| *** lbragstad has joined #openstack-oslo | 04:53 | |
| *** Luzi has joined #openstack-oslo | 06:54 | |
| *** aojea has joined #openstack-oslo | 07:35 | |
| *** lbragstad has quit IRC | 07:44 | |
| *** rcernin has quit IRC | 07:56 | |
| *** shardy has joined #openstack-oslo | 08:16 | |
| *** Luzi has quit IRC | 08:18 | |
| *** hberaud|gone is now known as hberaud | 08:31 | |
| *** Luzi has joined #openstack-oslo | 08:32 | |
| *** pcaruana has joined #openstack-oslo | 08:35 | |
| *** tosky has joined #openstack-oslo | 08:39 | |
| *** shardy has quit IRC | 08:54 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Fix memcache issue due to the __new__ attribute reassign. https://review.openstack.org/634457 | 09:01 |
| *** e0ne has joined #openstack-oslo | 09:25 | |
| *** FlorianFa has quit IRC | 09:30 | |
| *** ebbex has quit IRC | 09:30 | |
| *** FlorianFa has joined #openstack-oslo | 09:35 | |
| *** ebbex has joined #openstack-oslo | 09:36 | |
| *** yan0s has joined #openstack-oslo | 10:35 | |
| *** hberaud is now known as hberaud|lunch | 11:29 | |
| *** Luzi has quit IRC | 11:54 | |
| *** Luzi has joined #openstack-oslo | 11:55 | |
| *** raildo has joined #openstack-oslo | 12:16 | |
| *** aojeagarcia has joined #openstack-oslo | 12:25 | |
| *** shachar has joined #openstack-oslo | 12:26 | |
| *** dmellado_ has joined #openstack-oslo | 12:28 | |
| *** beekneemech has joined #openstack-oslo | 12:29 | |
| *** jlvillal has quit IRC | 12:30 | |
| *** dmellado has quit IRC | 12:30 | |
| *** zzzeek has quit IRC | 12:30 | |
| *** aojea has quit IRC | 12:30 | |
| *** bnemec has quit IRC | 12:30 | |
| *** snapiri has quit IRC | 12:30 | |
| *** sum12 has quit IRC | 12:30 | |
| *** openstackgerrit has quit IRC | 12:30 | |
| *** dmellado_ is now known as dmellado | 12:30 | |
| *** zzzeek has joined #openstack-oslo | 12:31 | |
| *** sum12 has joined #openstack-oslo | 12:31 | |
| *** jlvillal has joined #openstack-oslo | 12:31 | |
| *** hberaud|lunch is now known as hberaud | 12:48 | |
| *** agopi has quit IRC | 13:29 | |
| *** ansmith has joined #openstack-oslo | 13:35 | |
| *** dave-mccowan has joined #openstack-oslo | 13:54 | |
| *** agopi has joined #openstack-oslo | 13:58 | |
| *** beekneemech is now known as bnemec | 13:59 | |
| *** zaneb has quit IRC | 14:04 | |
| *** zaneb has joined #openstack-oslo | 14:07 | |
| *** kgiusti has joined #openstack-oslo | 14:21 | |
| *** dave-mccowan has quit IRC | 14:34 | |
| *** lbragstad has joined #openstack-oslo | 14:40 | |
| *** e0ne has quit IRC | 15:16 | |
| *** Luzi has quit IRC | 15:17 | |
| *** Aramis has joined #openstack-oslo | 15:19 | |
| *** yan0s has quit IRC | 15:26 | |
| *** e0ne has joined #openstack-oslo | 15:53 | |
| hberaud | bnemec: are you around? | 15:58 |
| hberaud | bnemec: do you want I rebase/cherry-pick my memcache fix (https://review.openstack.org/#/c/634457/) on your https://review.openstack.org/#/c/638788/7 ? | 16:00 |
| bnemec | hberaud: I think so. I'm pretty convinced at this point that we should just remove the test. | 16:01 |
| bnemec | (I think your second link is not what you intended, but I'm pretty sure I know which review you mean) | 16:01 |
| hberaud | bnemec: yeah good catch lol! I speak about https://review.openstack.org/#/c/638732/ | 16:03 |
| hberaud | bnemec: FYI rebase done | 16:15 |
| *** pcaruana has quit IRC | 16:32 | |
| *** moguimar has quit IRC | 16:59 | |
| *** e0ne has quit IRC | 17:24 | |
| *** aojeagarcia__ has joined #openstack-oslo | 17:37 | |
| *** aojeagarcia has quit IRC | 17:40 | |
| hberaud | bnemec: FYI => https://github.com/sqlalchemy/dogpile.cache/issues/144 | 18:06 |
| bnemec | hberaud: Okay, thanks. I need to wrap my head around the proposed fix there. | 18:10 |
| bnemec | hberaud: Hey, you haven't been able to reproduce the object takes no arguments error outside of TripleO, have you? | 18:11 |
| hberaud | bnemec: no | 18:11 |
| bnemec | I'm trying to come up with a backportable fix and have an idea, but I'm not sure how to verify that it fixes the problem when I can't reproduce it easily. | 18:11 |
| bnemec | Bleh. So weird. | 18:12 |
| *** openstackgerrit has joined #openstack-oslo | 18:25 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: fix dogpile.cache issue due to the new usage of decorate in the lib https://review.openstack.org/638788 | 18:25 |
| hberaud | bnemec: I've modify my proposed patch to introduce the zzzeek approach described there https://github.com/sqlalchemy/dogpile.cache/issues/144 | 18:26 |
| hberaud | bnemec: lets me know if you want to continue on the remove way or on the fix way | 18:28 |
| bnemec | hberaud: I think zzzeek is saying he's happy with the new dogpile behavior and we can remove the test because it's actually testing a bunch of stuff outside oslo.cache. | 18:38 |
| bnemec | "in short I think oslo.cache can remove the test case here as indicated in https://review.openstack.org/#/c/638732/, because you are not only testing dogpile, you're testing plain python / the decorator module." | 18:38 |
| bnemec | On https://bugs.launchpad.net/oslo.cache/+bug/1817032 | 18:38 |
| openstack | Launchpad bug 1817032 in oslo.cache "Unit test fails during cache region testing" [High,In progress] - Assigned to Herve Beraud (herveberaud) | 18:38 |
| hberaud | bnemec: yeah | 18:38 |
| zzzeek | bnemec: do you agree the @decoaator behavior is nicer at least ? preserves the function signature of the original fn | 18:39 |
| bnemec | zzzeek: I'm obviously not an expert, but I haven't found any problems with the new behavior so I'm good with it. | 18:41 |
| bnemec | I guess the new behavior is that you only need the kwarg decorator if you accept arbitrary lists of kwargs through a ** parameter, whereas before it was needed for any call that passed _any_ arg as a kwarg. | 18:42 |
| hberaud | bnemec: as I said in https://review.openstack.org/#/c/638732 feel free to choose your prefered way (remove/fix) we have the both | 18:42 |
| bnemec | hberaud: I'm thinking we should make sure dogpile has a test that verifies this behavior and then remove it from oslo.cache. | 18:45 |
| bnemec | It's out of our scope, but I do think it's useful to test. | 18:45 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: fix dogpile.cache issue due to the new usage of decorate in the lib https://review.openstack.org/638788 | 18:46 |
| *** aojeagarcia__ has quit IRC | 18:46 | |
| hberaud | bnemec: I personaly prefer to keep this test until dogpile has a dedicated test for this | 18:47 |
| hberaud | bnemec: I personaly prefer to keep this test until dogpile has not a dedicated test for this | 18:47 |
| bnemec | hberaud: I'm okay with that. | 18:47 |
| bnemec | So our steps would be: 1) Fix oslo.cache test, 2) add/verify test in dogpile, 3) remove test from oslo.cache | 18:48 |
| hberaud | bnemec: ack | 18:48 |
| hberaud | 1.2) rebase memcache on mine | 18:48 |
| hberaud | bnemec: this one https://review.openstack.org/#/c/634457/ | 18:49 |
| bnemec | Yeah, that could save some time. | 18:49 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Fix memcache issue due to the __new__ attribute reassign. https://review.openstack.org/634457 | 18:50 |
| bnemec | Huh: https://github.com/sqlalchemy/dogpile.cache/blob/master/tests/cache/test_decorator.py#L211 | 18:51 |
| bnemec | That seems like it's the case that is failing for us. | 18:52 |
| *** e0ne has joined #openstack-oslo | 19:26 | |
| hberaud | bnemec: yeah and my original patch was inspired from this one | 19:42 |
| hberaud | but he doesn't use region but util | 19:43 |
| hberaud | bnemec: I guess we also need to stay closer from cache_on_arguments decorator | 19:44 |
| hberaud | bnemec: if I'm right this test case doesn't use region who is at the origin of the issue due to `decorator` added to it (region) | 19:45 |
| hberaud | bnemec: and util isn't impacted by decorator | 19:45 |
| *** e0ne has quit IRC | 19:46 | |
| bnemec | hberaud: Right, but it's testing the base functionality, which is that if the decorator gets passed a kwarg it will fail. | 19:46 |
| hberaud | bnemec: I've submit some new test case to dogpile => https://github.com/sqlalchemy/dogpile.cache/pull/145 | 19:46 |
| bnemec | It's actually a better unit test because it doesn't test a whole bunch of other code in between too. | 19:46 |
| *** e0ne has joined #openstack-oslo | 19:46 | |
| hberaud | bnemec: yeah no inception in util test | 19:46 |
| bnemec | Part of the problem here was the number of layers between our test and the actual thing it was testing. | 19:47 |
| hberaud | bnemec: yep | 19:47 |
| hberaud | bnemec: sorry I need to go see you tomorrow if needed | 19:48 |
| *** hberaud is now known as hberaud|gone | 19:48 | |
| bnemec | hberaud|gone: Sounds good, thanks for all your work on this. | 19:48 |
| hberaud|gone | bnemec: my pleasure | 19:49 |
| *** eandersson_ has joined #openstack-oslo | 20:10 | |
| *** e0ne has quit IRC | 20:31 | |
| *** takamatsu_ has quit IRC | 20:48 | |
| *** takamatsu_ has joined #openstack-oslo | 20:50 | |
| *** e0ne has joined #openstack-oslo | 21:28 | |
| *** ansmith has quit IRC | 21:31 | |
| *** raildo has quit IRC | 21:33 | |
| *** kgiusti has left #openstack-oslo | 21:33 | |
| *** eandersson_ is now known as eandersson | 21:40 | |
| *** e0ne has quit IRC | 22:03 | |
| *** rcernin has joined #openstack-oslo | 22:05 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo.cache master: Remove dogpile kwarg test https://review.openstack.org/638732 | 22:28 |
| openstackgerrit | Ben Nemec proposed openstack/oslo.cache master: Fix memcache pool client in monkey-patched environments https://review.openstack.org/639457 | 22:28 |
| openstackgerrit | Ben Nemec proposed openstack/oslo.cache master: TEST: Enable eventlet monkey-patching in tests https://review.openstack.org/639458 | 22:28 |
| *** agopi has quit IRC | 22:59 | |
| *** ansmith has joined #openstack-oslo | 23:09 | |
| *** dave-mccowan has joined #openstack-oslo | 23:20 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!