*** bobh has joined #openstack-oslo | 00:02 | |
*** bnemec has joined #openstack-oslo | 00:16 | |
*** bobh has quit IRC | 00:35 | |
*** bnemec has quit IRC | 00:35 | |
*** bobh has joined #openstack-oslo | 00:52 | |
*** ianychoi has quit IRC | 00:57 | |
*** ianychoi has joined #openstack-oslo | 00:59 | |
*** bobh has quit IRC | 01:54 | |
*** bobh has joined #openstack-oslo | 02:53 | |
*** bobh has quit IRC | 02:56 | |
*** larainema has joined #openstack-oslo | 03:09 | |
*** jaosorior has quit IRC | 04:34 | |
*** dave-mccowan has quit IRC | 05:21 | |
*** jaosorior has joined #openstack-oslo | 05:49 | |
*** jaosorior has quit IRC | 06:21 | |
*** ianychoi has quit IRC | 06:34 | |
*** ianychoi has joined #openstack-oslo | 06:34 | |
*** ianychoi has quit IRC | 07:00 | |
*** ianychoi has joined #openstack-oslo | 07:01 | |
*** jaosorior has joined #openstack-oslo | 07:04 | |
*** trident has quit IRC | 07:10 | |
*** rcernin has quit IRC | 07:14 | |
*** trident has joined #openstack-oslo | 07:17 | |
*** ralonsoh has joined #openstack-oslo | 07:52 | |
*** e0ne has joined #openstack-oslo | 07:56 | |
*** jaosorior has quit IRC | 08:00 | |
*** ianychoi has quit IRC | 08:32 | |
*** ianychoi has joined #openstack-oslo | 08:33 | |
*** jaosorior has joined #openstack-oslo | 09:19 | |
*** raildo has joined #openstack-oslo | 11:21 | |
*** larainema has quit IRC | 12:29 | |
*** larainema has joined #openstack-oslo | 12:43 | |
openstackgerrit | Gabriele Santomaggio proposed openstack/oslo.messaging master: Add the mandatory flag for direct send https://review.opendev.org/672073 | 12:47 |
---|---|---|
*** kgiusti has joined #openstack-oslo | 12:58 | |
*** lbragstad has joined #openstack-oslo | 13:00 | |
*** tesseract has joined #openstack-oslo | 13:22 | |
*** tesseract has quit IRC | 13:22 | |
gsantomaggio | hi @kgiusti | 13:42 |
gsantomaggio | about https://review.opendev.org/#/c/672073/ | 13:42 |
gsantomaggio | I don't know the queue name | 13:42 |
gsantomaggio | so I can't delete it | 13:43 |
gsantomaggio | reply_q is generated automatically | 13:44 |
gsantomaggio | https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/amqpdriver.py#L123 | 13:44 |
kgiusti | gsantomaggio: hey bud! | 13:49 |
kgiusti | gsantomaggio: hmmmm.... | 13:50 |
kgiusti | gsantomaggio: ah, right - reply q's don't auto-delete immediately on rabbitmq (correct me if I'm wrong). | 13:50 |
gsantomaggio | @kgiusti exactly | 13:51 |
kgiusti | gsantomaggio: bummah | 13:51 |
gsantomaggio | @kgiusti even you put an high sleep, higher than TTL, the queue will be created again | 13:52 |
kgiusti | gsantomaggio: re-created by the sender? Ouch. | 13:52 |
gsantomaggio | @kgiusti by kombu.. somewhere :D | 13:53 |
gsantomaggio | @kgiusti I can test i manuatlly by adding: | 13:55 |
gsantomaggio | ``` | 13:55 |
gsantomaggio | self.reply_q = "no_queue" | 13:55 |
gsantomaggio | conn.direct_send(self.reply_q, rpc_common.serialize_msg(msg)) | 13:55 |
gsantomaggio | ``` | 13:55 |
*** bnemec has joined #openstack-oslo | 13:55 | |
gsantomaggio | `self.reply_q = "no_queue"` | 13:55 |
kgiusti | gsantomaggio: +1 | 13:56 |
gsantomaggio | @kgiusti the problem is that I had to modify the amqpdrider.py | 13:56 |
gsantomaggio | @kgiusti here: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/_drivers/amqpdriver.py#L123 | 13:57 |
gsantomaggio | @kgiusti I don't know how to do that outside `amqpdriver.py` | 13:57 |
kgiusti | gsantomaggio: what did you need to change in amqpdriver.py? And btw amqpdriver.py is rabbitmq only IIRC so changing it for rabbit's benefit is ok | 13:59 |
gsantomaggio | @kgiusti had to change: | 14:01 |
gsantomaggio | ``` | 14:01 |
gsantomaggio | conn.direct_send(self.reply_q, rpc_common.serialize_msg(msg)) | 14:01 |
gsantomaggio | ``` | 14:01 |
gsantomaggio | to | 14:01 |
gsantomaggio | ``` | 14:01 |
gsantomaggio | self.reply_q = "no_queue" | 14:01 |
gsantomaggio | conn.direct_send(self.reply_q, rpc_common.serialize_msg(msg)) | 14:01 |
gsantomaggio | ``` | 14:01 |
gsantomaggio | but this is only for test | 14:01 |
kgiusti | gsantomaggio: oh - I see, yeah, can do that for debug testing but not "for reals" | 14:03 |
gsantomaggio | @kgiusti yep ! | 14:04 |
kgiusti | gsantomaggio: hey - just a question on https://review.opendev.org/#/c/672073/ ... this last patch (3) seems to be only heartbeat-in-thread related | 14:07 |
kgiusti | gsantomaggio: oh crap - wrong patch (nevermind) | 14:08 |
gsantomaggio | @kgiusti :) | 14:08 |
kgiusti | gsantomaggio: apparently I left my brain at the beach... :P | 14:08 |
gsantomaggio | @kgiusti last patch, == rebase | 14:08 |
kgiusti | gsantomaggio: +1 | 14:08 |
kgiusti | gsantomaggio: kk https://review.opendev.org/#/c/672073/ LGTM - let's wait for Zuul to bless it before I +2 | 14:11 |
gsantomaggio | @kgiusti ok ty | 14:11 |
*** coreycb has quit IRC | 14:14 | |
*** dougwig has quit IRC | 14:15 | |
*** kmalloc has quit IRC | 14:15 | |
*** dhellmann_ has joined #openstack-oslo | 14:15 | |
*** dhellmann has quit IRC | 14:16 | |
*** mgagne has quit IRC | 14:16 | |
*** gus has quit IRC | 14:16 | |
*** logan- has quit IRC | 14:16 | |
*** dhellmann_ is now known as dhellmann | 14:16 | |
*** irclogbot_1 has quit IRC | 14:17 | |
*** gus has joined #openstack-oslo | 14:17 | |
*** logan_ has joined #openstack-oslo | 14:17 | |
*** mgagne has joined #openstack-oslo | 14:17 | |
*** ebbex has quit IRC | 14:18 | |
*** irclogbot_0 has joined #openstack-oslo | 14:18 | |
*** ebbex has joined #openstack-oslo | 14:18 | |
*** dougwig has joined #openstack-oslo | 14:18 | |
*** logan_ is now known as logan- | 14:18 | |
*** coreycb has joined #openstack-oslo | 14:18 | |
*** kmalloc has joined #openstack-oslo | 14:19 | |
openstackgerrit | Andy Smith proposed openstack/oslo.messaging master: Setup backend scenarios for functional tests https://review.opendev.org/677744 | 14:41 |
*** jaosorior has quit IRC | 14:41 | |
gsantomaggio | thank you @bnemec , @kgiusti | 14:45 |
bnemec | gsantomaggio: Thank YOU for all of your contributions! | 14:45 |
kgiusti | gsantomaggio: +1 - you're a great addition to the team! | 14:46 |
*** lbragstad has quit IRC | 14:52 | |
*** bobh has joined #openstack-oslo | 15:05 | |
openstackgerrit | Alfredo Moralejo proposed openstack/oslo.utils master: Add digestmod when using hmac https://review.opendev.org/677770 | 15:53 |
*** mgagne has quit IRC | 15:54 | |
*** mgagne has joined #openstack-oslo | 15:55 | |
*** larainema has quit IRC | 15:59 | |
openstackgerrit | Alfredo Moralejo proposed openstack/oslo.utils master: Add digestmod when using hmac https://review.opendev.org/677770 | 16:02 |
openstackgerrit | Andy Smith proposed openstack/oslo.messaging master: Setup backend scenarios for functional tests https://review.opendev.org/677744 | 16:06 |
openstackgerrit | Ben Nemec proposed openstack/oslo.utils master: Use sha1 for generating test data https://review.opendev.org/677783 | 16:27 |
openstackgerrit | Alfredo Moralejo proposed openstack/oslo.utils master: Add digestmod when using hmac https://review.opendev.org/677770 | 16:29 |
*** e0ne has quit IRC | 16:30 | |
*** bobh has quit IRC | 17:01 | |
*** lbragstad has joined #openstack-oslo | 17:24 | |
*** e0ne has joined #openstack-oslo | 17:49 | |
*** bobh has joined #openstack-oslo | 17:52 | |
*** e0ne has quit IRC | 18:01 | |
*** lbragstad_ has joined #openstack-oslo | 18:04 | |
*** lbragstad_ has quit IRC | 18:04 | |
*** bobh has quit IRC | 18:10 | |
*** ralonsoh has quit IRC | 18:35 | |
*** ralonsoh has joined #openstack-oslo | 18:35 | |
*** e0ne has joined #openstack-oslo | 18:44 | |
*** dkehn has quit IRC | 18:45 | |
*** ralonsoh has quit IRC | 19:05 | |
*** e0ne has quit IRC | 19:32 | |
*** e0ne has joined #openstack-oslo | 19:33 | |
*** e0ne has quit IRC | 20:10 | |
*** e0ne has joined #openstack-oslo | 20:12 | |
*** e0ne has quit IRC | 20:44 | |
*** bobh has joined #openstack-oslo | 20:55 | |
*** bobh has quit IRC | 21:00 | |
*** altlogbot_2 has quit IRC | 21:16 | |
*** kgiusti has left #openstack-oslo | 21:17 | |
*** rcernin has joined #openstack-oslo | 21:27 | |
*** bobh has joined #openstack-oslo | 21:32 | |
*** raildo has quit IRC | 21:36 | |
*** altlogbot_2 has joined #openstack-oslo | 21:37 | |
*** altlogbot_2 has quit IRC | 21:38 | |
*** altlogbot_3 has joined #openstack-oslo | 21:41 | |
*** altlogbot_3 has quit IRC | 21:42 | |
*** bnemec has quit IRC | 21:59 | |
*** bobh has quit IRC | 22:22 | |
*** bobh has joined #openstack-oslo | 22:22 | |
*** bobh has quit IRC | 22:27 | |
*** threestrands has joined #openstack-oslo | 22:34 | |
*** rcernin has quit IRC | 22:40 | |
*** rcernin has joined #openstack-oslo | 22:43 | |
*** bobh has joined #openstack-oslo | 23:28 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!