*** tosky has quit IRC | 00:22 | |
*** larainema has joined #openstack-oslo | 01:59 | |
*** zaneb has joined #openstack-oslo | 05:51 | |
*** Luzi has joined #openstack-oslo | 05:58 | |
*** lpetrut has quit IRC | 06:21 | |
*** rcernin has quit IRC | 07:12 | |
*** zaneb has quit IRC | 07:21 | |
*** pcaruana has joined #openstack-oslo | 07:27 | |
*** tosky has joined #openstack-oslo | 07:31 | |
*** zaneb has joined #openstack-oslo | 07:47 | |
*** zaneb has quit IRC | 07:51 | |
*** ansmith_ has quit IRC | 07:52 | |
*** ansmith has joined #openstack-oslo | 07:52 | |
*** iurygregory has joined #openstack-oslo | 08:16 | |
*** iurygregory has quit IRC | 08:40 | |
*** hberaud|gone is now known as hberaud | 08:41 | |
*** ralonsoh has joined #openstack-oslo | 08:45 | |
*** iurygregory has joined #openstack-oslo | 08:57 | |
openstackgerrit | Dougal Matthews proposed openstack/oslo.utils master: Ignore the .eggs directory https://review.opendev.org/695384 | 10:07 |
---|---|---|
openstackgerrit | Dougal Matthews proposed openstack/oslo.utils master: Lower the sanitize keys on load https://review.opendev.org/695385 | 10:10 |
openstackgerrit | Dougal Matthews proposed openstack/oslo.utils master: Lower the sanitize keys on load https://review.opendev.org/695385 | 10:12 |
openstackgerrit | Dougal Matthews proposed openstack/oslo.utils master: Verify the sanitize keys are lowered https://review.opendev.org/695385 | 10:37 |
openstackgerrit | Dougal Matthews proposed openstack/oslo.utils master: Verify the sanitize keys are lowered https://review.opendev.org/695385 | 10:38 |
openstackgerrit | Dougal Matthews proposed openstack/oslo.utils master: Verify the sanitize keys are lowered https://review.opendev.org/695385 | 10:40 |
d0ugal | bnemec / hberaud: I am curious to know if you prefer patchset 2 or patchset 5 :) https://review.opendev.org/#/c/695385/ | 10:41 |
hberaud | d0ugal: I will take a look | 10:43 |
d0ugal | hberaud: thanks, there is no rush. Just a follow up to the feedback on my last patch | 10:43 |
openstackgerrit | Dougal Matthews proposed openstack/oslo.utils master: Verify the sanitize keys are lowered https://review.opendev.org/695385 | 10:43 |
d0ugal | ^ just made the wording consistent in PS6 | 10:43 |
hberaud | ok | 10:44 |
*** hberaud is now known as hberaud|lunch | 11:02 | |
*** hberaud|lunch is now known as hberaud | 12:13 | |
*** raildo has joined #openstack-oslo | 12:26 | |
*** ansmith has quit IRC | 12:43 | |
openstackgerrit | Radomir Dopieralski proposed openstack/oslo.utils master: Fix invalid escapes in regular expression strings https://review.opendev.org/695428 | 13:21 |
*** mmethot has quit IRC | 13:36 | |
*** ansmith has joined #openstack-oslo | 13:39 | |
*** kgiusti has joined #openstack-oslo | 14:10 | |
*** tosky_ has joined #openstack-oslo | 14:31 | |
*** tosky has quit IRC | 14:32 | |
*** tosky_ is now known as tosky | 14:33 | |
*** hberaud has quit IRC | 14:34 | |
*** hberaud has joined #openstack-oslo | 14:42 | |
*** mmethot has joined #openstack-oslo | 14:43 | |
*** goldyfruit has joined #openstack-oslo | 14:46 | |
*** Luzi has quit IRC | 14:46 | |
*** tosky has quit IRC | 14:54 | |
*** tosky has joined #openstack-oslo | 14:57 | |
*** pcaruana has quit IRC | 15:02 | |
*** pcaruana has joined #openstack-oslo | 15:20 | |
*** larainema has quit IRC | 15:27 | |
openstackgerrit | John Garbutt proposed openstack/oslo.limit master: Add flat enforcer https://review.opendev.org/695310 | 16:11 |
hberaud | d0ugal: hey, any opinions about this => https://review.opendev.org/#/c/695428/ | 16:32 |
hberaud | ? | 16:32 |
d0ugal | Damn | 16:33 |
d0ugal | How did we miss that | 16:33 |
*** jaosorior has joined #openstack-oslo | 16:33 | |
hberaud | d0ugal: these changes sound legit, I'm in favor to remove the prefix 'r', some feedbacks? | 16:38 |
*** jaosorior has quit IRC | 16:38 | |
*** jaosorior has joined #openstack-oslo | 16:39 | |
d0ugal | hberaud: Agreed, it makes sense. I am trying to understand if there is a issue now or they are just being added to be safe | 16:39 |
bnemec | hberaud: We can't remove the r prefix. It's necessary to prevent errors from what Python considers invalid escape sequences. | 16:39 |
bnemec | ISTR it's a Python 3.8 thing. Right now it just triggers deprecation warnings. | 16:39 |
hberaud | bnemec: good catch | 16:39 |
bnemec | Once we have a py38 gate it will be easier to avoid this kind of thing. | 16:40 |
d0ugal | so many things break for me locally in 3.8. I had to change my default back to 3.7 :( | 16:41 |
bnemec | I feel like there is an argument that some of the recent py3 point releases should have been 4.0. | 16:42 |
bnemec | Semver says if you make breaking changes then that's a new major version, and there have definitely been breaking changes in Python lately. | 16:43 |
d0ugal | Agreed | 16:43 |
hberaud | +1 | 16:43 |
d0ugal | I think everyone is a bit scared by a Python major version change now :) | 16:43 |
bnemec | Yeah, understandably. :-) | 16:44 |
hberaud | bnemec: but these strings was not prefixed with 'r' before https://github.com/openstack/oslo.utils/commit/b41268417cecb12d1d5955ee3107067edf050221 => https://github.com/openstack/oslo.utils/blob/c08b1006ef0f40331394d3176a29196d8a5b992c/oslo_utils/strutils.py | 16:46 |
bnemec | hberaud: But they should have been. We just missed that when the regex linebreaks changed in d0ugal's patch. | 16:49 |
hberaud | bnemec: agree make sense | 16:50 |
openstackgerrit | John Garbutt proposed openstack/oslo.limit master: WIP: Two level limit enforcer https://review.opendev.org/695527 | 16:54 |
*** jaosorior has quit IRC | 17:00 | |
*** goldyfruit_ has joined #openstack-oslo | 17:14 | |
*** goldyfruit has quit IRC | 17:17 | |
*** pcaruana has quit IRC | 17:51 | |
*** hberaud is now known as hberaud|lunch | 18:03 | |
*** pcaruana has joined #openstack-oslo | 18:14 | |
*** iurygregory is now known as iurygregory_afk | 18:19 | |
openstackgerrit | Merged openstack/oslo.utils master: Fix invalid escapes in regular expression strings https://review.opendev.org/695428 | 18:27 |
*** iurygregory_afk has quit IRC | 18:28 | |
*** tosky has quit IRC | 18:29 | |
*** gmann is now known as gmann_afk | 18:38 | |
*** pcaruana has quit IRC | 18:42 | |
*** ralonsoh has quit IRC | 18:55 | |
*** pcaruana has joined #openstack-oslo | 19:06 | |
*** openstackstatus has quit IRC | 19:50 | |
*** openstackstatus has joined #openstack-oslo | 19:51 | |
*** ChanServ sets mode: +v openstackstatus | 19:51 | |
*** gmann_afk is now known as gmann | 20:45 | |
*** openstack has joined #openstack-oslo | 21:17 | |
*** ChanServ sets mode: +o openstack | 21:17 | |
*** dave-mccowan has joined #openstack-oslo | 21:21 | |
*** pcaruana has quit IRC | 21:25 | |
*** ansmith has quit IRC | 21:39 | |
*** kgiusti has left #openstack-oslo | 21:52 | |
*** rcernin has joined #openstack-oslo | 22:09 | |
*** ansmith has joined #openstack-oslo | 22:17 | |
*** harlowja has quit IRC | 22:23 | |
*** raildo has quit IRC | 22:27 | |
*** tosky has joined #openstack-oslo | 22:35 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!