| openstackgerrit | Kendall Nelson proposed openstack/cookiecutter master: Update CONTRIBUTING.rst template https://review.opendev.org/696001 | 01:26 |
|---|---|---|
| *** goldyfruit_ has joined #openstack-oslo | 01:27 | |
| *** mmethot has quit IRC | 01:36 | |
| *** mmethot has joined #openstack-oslo | 01:47 | |
| *** larainema has joined #openstack-oslo | 01:49 | |
| *** rcernin has quit IRC | 01:53 | |
| *** dave-mccowan has joined #openstack-oslo | 02:00 | |
| *** goldyfruit_ has quit IRC | 02:15 | |
| *** goldyfruit_ has joined #openstack-oslo | 02:15 | |
| *** goldyfruit_ has quit IRC | 02:40 | |
| *** rcernin has joined #openstack-oslo | 02:54 | |
| *** dave-mccowan has quit IRC | 02:55 | |
| *** dansmith has quit IRC | 05:10 | |
| *** dansmith has joined #openstack-oslo | 05:14 | |
| *** ianychoi has joined #openstack-oslo | 05:32 | |
| *** pcaruana has joined #openstack-oslo | 06:09 | |
| *** ianychoi_ has joined #openstack-oslo | 07:08 | |
| *** tosky has joined #openstack-oslo | 07:09 | |
| *** ianychoi has quit IRC | 07:11 | |
| *** lpetrut has joined #openstack-oslo | 07:18 | |
| *** gibi_off is now known as gibi | 07:44 | |
| *** tesseract has joined #openstack-oslo | 07:57 | |
| *** hberaud|gone is now known as hberaud | 08:17 | |
| *** pcaruana has quit IRC | 08:22 | |
| *** ralonsoh has joined #openstack-oslo | 08:55 | |
| *** iurygregory has joined #openstack-oslo | 09:02 | |
| *** rcernin has quit IRC | 09:50 | |
| *** ianychoi_ has quit IRC | 09:56 | |
| *** farhanjamil has joined #openstack-oslo | 09:59 | |
| *** farhanjamil has quit IRC | 10:07 | |
| openstackgerrit | Stephen Finucane proposed openstack/oslo.privsep master: Add functional tests https://review.opendev.org/638467 | 10:26 |
| *** hberaud is now known as hberaud|school-r | 10:58 | |
| *** hberaud|school-r is now known as hberaud | 11:05 | |
| *** ansmith_ has joined #openstack-oslo | 11:08 | |
| *** ansmith has quit IRC | 11:10 | |
| *** raildo has joined #openstack-oslo | 11:32 | |
| *** pcaruana has joined #openstack-oslo | 11:36 | |
| *** ianychoi has joined #openstack-oslo | 11:49 | |
| *** sean-k-mooney is now known as skm | 11:55 | |
| *** skm is now known as sean-k-mooney | 11:55 | |
| *** larainema has quit IRC | 12:01 | |
| *** hberaud is now known as hberaud|lunch | 12:43 | |
| *** ansmith_ has quit IRC | 12:44 | |
| stephenfin | hberaud|lunch: You have any idea what might be going on here? https://review.opendev.org/698473 | 13:11 |
| stephenfin | (if you have time to look, that is) | 13:11 |
| *** mmethot has quit IRC | 13:13 | |
| *** goldyfruit_ has joined #openstack-oslo | 13:17 | |
| *** mmethot has joined #openstack-oslo | 13:17 | |
| *** ansmith has joined #openstack-oslo | 13:36 | |
| *** hberaud|lunch is now known as hberaud | 13:39 | |
| * hberaud take a look (stephenfin) | 13:45 | |
| hberaud | stephenfin: weird... seems to work on https://review.opendev.org/#/c/651566/2 and pep8 tests fails here => https://review.opendev.org/#/c/698473/ | 13:47 |
| *** kgiusti has joined #openstack-oslo | 13:50 | |
| *** bnemec has joined #openstack-oslo | 14:01 | |
| *** goldyfruit_ has quit IRC | 14:02 | |
| stephenfin | hberaud: It's because I've bumped the flake8 version. flake8 3.x has totally different internals | 14:23 |
| hberaud | stephenfin: I currently writing a bunch a comment on yours | 14:23 |
| stephenfin | hberaud: I'm more curious about why I get the results I was expecting when I run the command manually but not from the test, even though they should be doing the same thing | 14:23 |
| stephenfin | ack | 14:23 |
| hberaud | s/a/of/ | 14:23 |
| hberaud | I think the issue is https://docs.python.org/3/library/tempfile.html#tempfile.NamedTemporaryFile which open file in binary mode | 14:42 |
| hberaud | stephenfin: ^^ | 14:42 |
| hberaud | stephenfin: and you pass a str | 14:42 |
| hberaud | stephenfin: if the mode is not specified then it will open a file in 'w+b' | 14:42 |
| hberaud | (mode) | 14:43 |
| hberaud | stephenfin: see my latest comment on https://review.opendev.org/#/c/698473 (related to the CI error) | 14:48 |
| stephenfin | ohh, I'll take a look now. Thanks! | 14:55 |
| hberaud | stephenfin: you are welcome, just tell me if we gotcha something here | 14:58 |
| *** lpetrut has quit IRC | 15:32 | |
| openstackgerrit | Michael Bayer proposed openstack/oslo.db master: Use regex to compare SQL strings with IN https://review.opendev.org/698521 | 16:07 |
| *** hberaud is now known as hberaud|gone | 16:07 | |
| *** lbragstad_ has joined #openstack-oslo | 16:12 | |
| *** lbragstad has quit IRC | 16:15 | |
| openstackgerrit | Merged openstack/oslo.messaging master: Revert "Add RPC incoming and reply log" https://review.opendev.org/698090 | 16:25 |
| *** jaosorior has joined #openstack-oslo | 16:25 | |
| *** guimaraes has quit IRC | 16:46 | |
| *** moguimar has joined #openstack-oslo | 16:47 | |
| *** moguimar has quit IRC | 16:47 | |
| stephenfin | hberaud|gone: Figured it out https://review.opendev.org/#/c/651565/ | 16:50 |
| stephenfin | hberaud|gone: Turns out I need to close the file for flake8 to be able to read it. Guess there is some buffering going on or something | 16:50 |
| stephenfin | that was driving me *nuts* | 16:50 |
| *** iurygregory has quit IRC | 16:56 | |
| *** dougwig has quit IRC | 17:08 | |
| *** dougwig has joined #openstack-oslo | 17:08 | |
| stephenfin | bnemec: I've already stuck you on the reviews, but care to send these through so I can push a hacking 2.0 release? https://review.opendev.org/#/q/topic:bump-flake8 | 17:25 |
| *** yan0s has quit IRC | 17:26 | |
| bnemec | stephenfin: Yep, will take a look. | 17:29 |
| stephenfin | thanks | 17:29 |
| *** jaosorior has quit IRC | 18:27 | |
| *** tosky has quit IRC | 18:44 | |
| *** ralonsoh has quit IRC | 18:55 | |
| *** goldyfruit_ has joined #openstack-oslo | 19:26 | |
| *** lpetrut has joined #openstack-oslo | 19:33 | |
| *** iurygregory has joined #openstack-oslo | 19:34 | |
| *** tesseract has quit IRC | 19:46 | |
| *** lpetrut has quit IRC | 19:46 | |
| *** lbragstad has joined #openstack-oslo | 20:03 | |
| *** harlowja has joined #openstack-oslo | 20:07 | |
| *** iurygregory has quit IRC | 20:45 | |
| *** rcernin has joined #openstack-oslo | 21:23 | |
| *** raildo has quit IRC | 21:31 | |
| *** dkehn has joined #openstack-oslo | 21:33 | |
| *** lbragstad has quit IRC | 21:34 | |
| *** ansmith has quit IRC | 21:38 | |
| *** kgiusti has left #openstack-oslo | 21:38 | |
| *** pcaruana has quit IRC | 21:38 | |
| *** tosky has joined #openstack-oslo | 22:15 | |
| *** ansmith has joined #openstack-oslo | 22:16 | |
| *** mmethot has quit IRC | 23:31 | |
| *** mmethot has joined #openstack-oslo | 23:36 | |
| *** tosky has quit IRC | 23:40 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!