| *** kgiusti has left #openstack-oslo | 00:34 | |
| *** rcernin has quit IRC | 03:10 | |
| *** rcernin has joined #openstack-oslo | 03:25 | |
| *** mnasiadka has quit IRC | 05:10 | |
| *** Anticimex has quit IRC | 05:10 | |
| *** mnasiadka has joined #openstack-oslo | 05:15 | |
| *** Anticimex has joined #openstack-oslo | 05:15 | |
| *** jhesketh has quit IRC | 07:04 | |
| *** rpittau|afk is now known as rpittau | 07:19 | |
| *** tosky has joined #openstack-oslo | 07:30 | |
| *** ralonsoh has joined #openstack-oslo | 07:38 | |
| *** threestrands has quit IRC | 07:56 | |
| *** tkajinam has quit IRC | 08:51 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/oslo.upgradecheck master: Remove Babel from requirements https://review.opendev.org/720674 | 09:44 |
|---|---|---|
| *** rpittau is now known as rpittau|bbl | 10:30 | |
| *** szaher has joined #openstack-oslo | 10:34 | |
| *** tkajinam has joined #openstack-oslo | 11:56 | |
| *** tkajinam has quit IRC | 12:04 | |
| *** rcernin has quit IRC | 12:11 | |
| *** rpittau|bbl is now known as rpittau | 12:19 | |
| *** raildo has joined #openstack-oslo | 12:23 | |
| *** kgiusti has joined #openstack-oslo | 13:20 | |
| openstackgerrit | Dmitry Tantsur proposed openstack/oslo-cookiecutter master: Remove Babel from requirements https://review.opendev.org/720716 | 13:44 |
| *** moguimar has joined #openstack-oslo | 14:09 | |
| openstackgerrit | Merged openstack/oslo-cookiecutter master: Remove Babel from requirements https://review.opendev.org/720716 | 14:41 |
| openstackgerrit | Merged openstack/oslo.upgradecheck master: Remove Babel from requirements https://review.opendev.org/720674 | 14:50 |
| *** moguimar has quit IRC | 15:24 | |
| *** moguimar has joined #openstack-oslo | 15:26 | |
| openstackgerrit | Merged openstack/oslo.messaging master: Imported Translations from Zanata https://review.opendev.org/720389 | 15:30 |
| hberaud | bnemec, stephenfin, smcginnis, moguimar: hey o/, what do you think about introducing `pre-commit` on oslo's project? | 15:32 |
| hberaud | (just to avoid to spend time on it if y'all think isn't a good idea or something useful) | 15:33 |
| stephenfin | Fine by me. If we were to introduce it, I'd like to do it for one project, settle on the checkers we want to use and then work from there | 15:33 |
| hberaud | stephenfin: yep I agree this is the path that I want to follow too | 15:34 |
| smcginnis | hberaud: What would you want to add to the pre-commit hook? | 15:34 |
| hberaud | my main concern is mainly about duplicate test stuff between tox and pre-commit... I would try to call tox from pre-commit | 15:35 |
| hberaud | smcginnis: I want to introduce black in a second time | 15:35 |
| hberaud | smcginnis: driven by pre-commit | 15:35 |
| smcginnis | You had me until "black". | 15:35 |
| smcginnis | In that case, hell no. :) | 15:36 |
| hberaud | smcginnis: but anyway it could be useful to run test | 15:36 |
| hberaud | smcginnis: even if we skip the black stuff | 15:36 |
| smcginnis | Some quick checks would be good. | 15:36 |
| hberaud | smcginnis: my main goal is to avoid back and forth with patches | 15:37 |
| hberaud | smcginnis: so if pre-commit could help us to catch things before pushing then we'll reduce the CI usages | 15:37 |
| hberaud | or some parts of the usage | 15:37 |
| smcginnis | We wouldn't want to do too much with pre-commit hooks, but it could catch some common things. | 15:37 |
| hberaud | yep this is the idea | 15:38 |
| stephenfin | We have it in nova at the moment | 15:38 |
| smcginnis | Other projects have had success with hacking checks and things like sphinx-import-order and other add-ons to help get rid of the back and forth due to diffing opinions and just have some objective enforce policies. | 15:38 |
| smcginnis | stephenfin: black? | 15:38 |
| stephenfin | god no | 15:38 |
| stephenfin | :D | 15:38 |
| stephenfin | pre-commit | 15:38 |
| smcginnis | Whew, good. :D | 15:38 |
| stephenfin | (though I've nothing against black for _new_ projects, fwiw) | 15:39 |
| stephenfin | https://github.com/openstack/nova/blob/master/.pre-commit-config.yaml | 15:39 |
| smcginnis | Nice | 15:39 |
| bnemec | +1 to all of this. From stephenfin's discussion on pre-commit previously it sounds fine, and we as a community pretty much rejected moving to black a while back. | 15:39 |
| bnemec | Too much churn for too little benefit at this point. | 15:40 |
| hberaud | wack | 15:40 |
| hberaud | ack | 15:40 |
| smcginnis | stephenfin: That could probably be sped up with the fast8 hook in cinder: https://github.com/openstack/cinder/blob/master/tools/fast8.sh | 15:40 |
| bnemec | lol | 15:40 |
| stephenfin | smcginnis: what's "that" (that could be sped up) | 15:40 |
| bnemec | I kind of like wack, actually. ;-) | 15:40 |
| smcginnis | stephenfin: Just seeing that the nova pre-commit runs flake8. | 15:41 |
| *** sean-k-mooney has quit IRC | 15:41 | |
| stephenfin | smcginnis: Ah, it's very clever - it only runs it on the changed files | 15:41 |
| smcginnis | Makes it a lot less intrusive. | 15:41 |
| stephenfin | and actually usable | 15:41 |
| stephenfin | if it did all files, every commit would take ~10 minutes | 15:41 |
| stephenfin | also, fwiw we have our own fast8 thing in nova https://github.com/openstack/nova/blob/master/tox.ini#L52-L57 | 15:42 |
| stephenfin | but I don't use it anymore since pre-commit was introduced | 15:42 |
| smcginnis | Oh nice. | 15:42 |
| hberaud | stephenfin: thanks for the links I'll base my patch on that to begin this topic | 15:44 |
| hberaud | and thanks y'all for your feedback | 15:45 |
| stephenfin | hberaud: Sweet. FYI, the newer version of pre-commit (2.6.0 I think) has deprecated the flake8 plugin in favour of the one from gitlab.com/pycqa/flake8 so watch out for that | 15:49 |
| hberaud | stephenfin: ack | 15:49 |
| hberaud | stephenfin: FYI it's 2.5.0 => https://github.com/pre-commit/pre-commit-hooks/commit/1057813c2ff113312dafe793061cdb100db67f54 | 15:53 |
| hberaud | stephenfin: and the nova's pre-commit config use 2.4.0 | 15:54 |
| openstackgerrit | Vishakha Agarwal proposed openstack/pycadf master: Remove Babel as requirement https://review.opendev.org/720763 | 16:00 |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Introducing usage of pre-commit https://review.opendev.org/720771 | 16:14 |
| hberaud | stephenfin, smcginnis, bnemec: a first try ^^^^^ | 16:15 |
| *** rpittau is now known as rpittau|afk | 16:17 | |
| *** ianychoi_ has joined #openstack-oslo | 16:29 | |
| *** ianychoi has quit IRC | 16:31 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Introducing usage of pre-commit https://review.opendev.org/720771 | 16:38 |
| *** ralonsoh has quit IRC | 17:53 | |
| openstackgerrit | Ben Nemec proposed openstack/oslo-specs master: Add branch request to end of cycle activities https://review.opendev.org/720068 | 17:55 |
| openstackgerrit | Merged openstack/oslo.config master: Use unittest.mock instead of third party mock https://review.opendev.org/716393 | 19:02 |
| *** moguimar has quit IRC | 19:22 | |
| *** raildo has quit IRC | 19:30 | |
| *** raildo has joined #openstack-oslo | 19:50 | |
| *** raildo has quit IRC | 21:35 | |
| *** dkehn has quit IRC | 21:52 | |
| *** kgiusti has left #openstack-oslo | 22:09 | |
| *** tosky has quit IRC | 23:21 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!