*** hamalq has joined #openstack-oslo | 05:21 | |
*** hamalq has quit IRC | 05:25 | |
*** Luzi has joined #openstack-oslo | 05:37 | |
*** rcernin has quit IRC | 06:02 | |
*** rcernin has joined #openstack-oslo | 06:11 | |
*** tosky has joined #openstack-oslo | 06:39 | |
*** ralonsoh has joined #openstack-oslo | 07:19 | |
*** rcernin has quit IRC | 08:06 | |
*** hamalq has joined #openstack-oslo | 08:17 | |
*** hamalq_ has joined #openstack-oslo | 08:18 | |
*** hamalq has quit IRC | 08:21 | |
*** hamalq_ has quit IRC | 08:23 | |
*** dtantsur|afk is now known as dtantsur | 08:34 | |
*** moguimar has joined #openstack-oslo | 09:08 | |
*** rcernin has joined #openstack-oslo | 09:53 | |
*** rcernin has quit IRC | 10:03 | |
*** rcernin has joined #openstack-oslo | 10:07 | |
*** rcernin has quit IRC | 10:40 | |
*** finucannot is now known as stephenfin | 10:57 | |
*** giblet is now known as gibi | 11:17 | |
*** hamalq has joined #openstack-oslo | 11:19 | |
*** hamalq has quit IRC | 11:24 | |
*** hamalq has joined #openstack-oslo | 11:35 | |
*** tkajinam has quit IRC | 11:37 | |
moguimar | stephenfin, thanks for the reviews =D | 11:40 |
---|---|---|
*** hamalq has quit IRC | 11:40 | |
*** raildo has joined #openstack-oslo | 11:56 | |
*** adriant has quit IRC | 11:58 | |
*** adriant has joined #openstack-oslo | 11:59 | |
*** hberaud has quit IRC | 12:01 | |
*** hberaud has joined #openstack-oslo | 12:03 | |
*** dave-mccowan has joined #openstack-oslo | 12:10 | |
*** dave-mccowan has quit IRC | 12:15 | |
*** ralonsoh has quit IRC | 12:43 | |
*** ralonsoh has joined #openstack-oslo | 12:44 | |
*** kgiusti has joined #openstack-oslo | 12:49 | |
*** lbragstad_ is now known as lbragstad | 12:51 | |
*** zombieJulia is now known as TheJulia | 13:06 | |
*** sean-k-mooney has quit IRC | 13:27 | |
*** irclogbot_1 has quit IRC | 13:27 | |
*** gibi has quit IRC | 13:27 | |
*** sean-k-mooney has joined #openstack-oslo | 13:28 | |
*** irclogbot_1 has joined #openstack-oslo | 13:28 | |
*** gibi has joined #openstack-oslo | 13:28 | |
*** Luzi has quit IRC | 14:00 | |
openstackgerrit | Merged openstack/stevedore master: sphinxext: fix warning message for detailed list https://review.opendev.org/740596 | 14:20 |
dansmith | beekneemech: can I do an *or* type operation in a policy rule? | 14:31 |
dansmith | beekneemech: also, is there a more appropriate policy guru I should be asking? | 14:31 |
*** beekneemech is now known as bnemec | 14:38 | |
bnemec | dansmith: Yes. I believe the boolean ops are all just their literal name: and, or, not. | 14:39 |
dansmith | oh really? | 14:39 |
dansmith | did I just assume obscurity? :) | 14:39 |
bnemec | I can't imagine why. ;-) | 14:39 |
bnemec | Also, the keystone folks are more clued in about writing policy rules. They're the ones who had to figure out how to write all of these fancy policy rules in the first place. | 14:40 |
dansmith | ah okay | 14:41 |
*** cognifloyd has quit IRC | 14:51 | |
*** cognifloyd has joined #openstack-oslo | 14:55 | |
bnemec | #startmeeting oslo | 15:00 |
bnemec | Courtesy ping for bnemec, smcginnis, moguimar, johnsom, stephenfin, bcafarel, kgiusti, jungleboyj | 15:00 |
bnemec | #link https://wiki.openstack.org/wiki/Meetings/Oslo#Agenda_for_Next_Meeting | 15:00 |
openstack | Meeting started Mon Jul 13 15:00:47 2020 UTC and is due to finish in 60 minutes. The chair is bnemec. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
*** openstack changes topic to " (Meeting topic: oslo)" | 15:00 | |
openstack | The meeting name has been set to 'oslo' | 15:00 |
johnsom | o/ | 15:01 |
kgiusti | o/ | 15:01 |
tosky | hi from your friendly zuulv3 community goal volunteer | 15:01 |
moguimar | o/ | 15:02 |
bnemec | o/ tosky! | 15:02 |
bnemec | #topic Red flags for/from liaisons | 15:04 |
*** openstack changes topic to "Red flags for/from liaisons (Meeting topic: oslo)" | 15:04 | |
johnsom | Nothing from the Octavia team | 15:04 |
bnemec | We had a major release of stevedore last week that broke something. | 15:04 |
bnemec | There's a fix slated for release today. | 15:04 |
moguimar | all fine in Barbican land | 15:05 |
smcginnis | o/ | 15:05 |
bnemec | Okay, I think that's all of the liaisons, so we can move on. | 15:06 |
bnemec | #topic Releases | 15:06 |
*** openstack changes topic to "Releases (Meeting topic: oslo)" | 15:06 | |
bnemec | hberaud has been handling most of these lately, so I'm a little out of the loop. | 15:07 |
bnemec | Generally speaking, I think our releases should be pretty current though. | 15:07 |
smcginnis | I think that is accurate. | 15:09 |
bnemec | Hmm, no action items for one-off topics. | 15:09 |
bnemec | And my VM that hosts reviewstats seems to be down, so weekly wayward review is problematic. | 15:10 |
moguimar | I have some | 15:10 |
bnemec | #topic Open discussion | 15:10 |
*** openstack changes topic to "Open discussion (Meeting topic: oslo)" | 15:10 | |
tosky | if I may :) | 15:10 |
moguimar | go on tosky | 15:11 |
bnemec | moguimar: A review or a topic? | 15:11 |
moguimar | I'll bring mine after | 15:11 |
moguimar | I need to colect some links | 15:11 |
bnemec | Sounds good. | 15:11 |
tosky | I'm here for the Zuul v3 porting goal; the overall status of oslo is good, but there are still a few jobs that needs some porting | 15:12 |
bnemec | Cool. Do you have a list? | 15:12 |
tosky | I haven't sent a proper report yet (drafting it right now) but I can share this as a special preview: https://etherpad.opendev.org/p/goal-victoria-native-zuulv3-migration | 15:12 |
tosky | oslo ones are around line 197 | 15:13 |
bnemec | We can just kill that zmq job. We don't support that driver anymore and haven't for a while. | 15:14 |
tosky | if I've got all of them, there are 10 legacy jobs, and 4 of them are grenade (which got their native zuul v3 version only recently) | 15:14 |
bnemec | I assume there's a known migration path for grenade? | 15:14 |
tosky | oh, kill the job or close the repository, whatever works for you; I'm fine as long as the job is not around :) | 15:14 |
tosky | yes, grenade job received a native job just before branching ussuri thanks to, uhm | 15:15 |
*** hamalq has joined #openstack-oslo | 15:15 | |
tosky | this one https://review.opendev.org/#/c/548936/ | 15:15 |
tosky | if you look for merged patches with topic:native-zuulv3-migration, you will see a few grenade ones, even pretty complex (see ironic) | 15:16 |
*** hamalq has quit IRC | 15:17 | |
bnemec | Okay, I doubt we're doing anything crazy with it, so hopefully those won't be too hard. | 15:17 |
tosky | just a few random grenade jobs: https://review.opendev.org/#/c/726790/ https://review.opendev.org/#/c/729860/ https://review.opendev.org/#/c/703098/ | 15:17 |
*** hamalq has joined #openstack-oslo | 15:17 | |
tosky | I haven't checked what these jobs do, but I think they won't be complicated to port as well | 15:17 |
tosky | if you have any question please feel free to ping me (and add me as reviewer) | 15:17 |
bnemec | Looking at the list, the ones that may require some Oslo-specific work are the messaging and pbr ones. | 15:17 |
kgiusti | bnemec: I'll take a crack at the messaging ones. | 15:18 |
bnemec | kgiusti: Awesome, thanks! | 15:18 |
tosky | the messaging ones may be easy, if the only things they do is to use oslo.messaging from source | 15:18 |
bnemec | #action kgiusti to look at migrating messaging jobs to zuulv3. | 15:18 |
tosky | just add oslo.messaging to required-projects | 15:18 |
tosky | but again I haven't checked the job in details :) | 15:18 |
kgiusti | tosky: I'll take a look and get back to you with questions | 15:19 |
tosky | sure! | 15:19 |
kgiusti | tosky: thanks :D | 15:19 |
*** hamalq_ has joined #openstack-oslo | 15:20 | |
tosky | you probably know that already, but the migration to zuulv3 provides most of the work for the other community goal, the port from bionic to focal | 15:20 |
bnemec | Okay, I've added this topic to the agenda for next week too so hopefully we won't lose track of it like we did with the docs goal... | 15:20 |
bnemec | We'll probably find some obscure deps for one of our drivers that doesn't exist on focal. :-) | 15:21 |
tosky | once the base jobs switch the ubuntu version, all native zuul v3 job are switched as well (which may bring some breakages in tests, but at least the general part is done) | 15:21 |
tosky | eh | 15:21 |
tosky | that's the project-specific part | 15:21 |
bnemec | Yep. We'll whack those moles when they pop their heads up. | 15:22 |
moguimar | you're done tosky ? | 15:23 |
tosky | I think that's it from my side for now, yes | 15:23 |
tosky | thanks! | 15:23 |
moguimar | ack | 15:23 |
bnemec | Thanks tosky! | 15:23 |
moguimar | I was working with herve last week on https://review.opendev.org/#/c/720771/ | 15:23 |
*** hamalq has quit IRC | 15:23 | |
moguimar | pre-commit is very good as a tool, but I have my doubts that it will be as effective as a git hook | 15:25 |
moguimar | so while anyone can install the hooks locally, I think we should also enforce pre-commit at gate | 15:26 |
moguimar | usually when you run pre-commit, it will only consider modified/staged files | 15:26 |
moguimar | so at the gate we can either run on all source or in the last commit | 15:26 |
bnemec | If we don't have it in the gate it will most likely get broken over time. | 15:26 |
moguimar | and I think it should go in the pep8 check | 15:27 |
bnemec | Last commit should be fine in the gate, at least once we get the whole project compliant in the first place. | 15:27 |
bnemec | Would you propose adding it to the pep8 tox env then? | 15:28 |
moguimar | in a following patch | 15:28 |
moguimar | replacing the flake8 like | 15:28 |
moguimar | as flake8 is also included in pre-commit checks | 15:29 |
moguimar | https://review.opendev.org/#/c/720771/6/tox.ini | 15:29 |
moguimar | basically replace line 27 with line 35 in a followup patch | 15:29 |
moguimar | with an intermediate patch making everything compliant | 15:29 |
moguimar | so 1st, I need some one else to review this patch, 2nd, get to an agreement for gating | 15:30 |
moguimar | 2nd point shouds positive so far | 15:30 |
bnemec | I don't have any strong objections. It looks like the stuff pre-commit is checking is all sane. | 15:30 |
moguimar | yup, I'd +2 it but then I made some changes on it | 15:31 |
moguimar | with herve's consent | 15:31 |
bnemec | stephenfin: ^might be relevant to your interests since I believe you were advocating for pre-commit too | 15:31 |
moguimar | 3rd point on this is a raise dead from the discuss list | 15:31 |
moguimar | I'd like to, in yet another patch, introduce black through pre-commit | 15:32 |
bnemec | That I object to. | 15:32 |
moguimar | the impact on oslo.cache is around 18 files at first | 15:32 |
bnemec | We've discussed black in the past and didn't want to deal with the churn it would cause. | 15:33 |
moguimar | that was for big projects like openstack sdk | 15:33 |
moguimar | I was looking at the options | 15:33 |
moguimar | we cound have 80 lines and ignore "" vs '' | 15:33 |
smcginnis | Please no black. | 15:33 |
bnemec | I mean, we have 40 projects. Collectively I think that qualifies as "big". | 15:33 |
moguimar | ok, so lets stick to points 1 and 2 then | 15:34 |
* stephenfin is in another meeting but agrees with pre-commit integration (reviewed it this morning). Integrating it into the gate seems sound though we didn't bother doing it for nova since pep8 was the only one we really cared about and that was already validated | 15:34 | |
moguimar | so do we have a tribute to review https://review.opendev.org/#/c/720771 and I will work on the gating patch? | 15:36 |
bnemec | I've approved that patch. | 15:37 |
moguimar | ach, thanks Ben | 15:37 |
bnemec | We can discuss how to handle the gating on the followup. | 15:37 |
moguimar | I think we can watch pre-commit during this cycle and then decide on applying it to other projects next cycle | 15:38 |
bnemec | I can't remember if there were any objections to gating on it when it was discussed previously. | 15:38 |
moguimar | like a topic in the retrospective or so | 15:38 |
bnemec | I would even make it a standalone topic for the next PTG. | 15:39 |
moguimar | ok | 15:39 |
bnemec | It'll be easier to have that discussion not in the context of the overall retrospective. | 15:40 |
bnemec | #action moguimar to propose patch integrating pre-commit to the gate for oslo.cache | 15:40 |
bnemec | Anything else on this topic for now? | 15:41 |
moguimar | nope | 15:41 |
moguimar | and I don't have anything else | 15:41 |
bnemec | Okay, anything else this week? | 15:42 |
bnemec | Looks like "no". :-) | 15:44 |
bnemec | Thanks for joining, everyone! | 15:44 |
bnemec | #endmeeting | 15:44 |
*** openstack changes topic to "OpenStack Common Libraries | https://wiki.openstack.org/wiki/Oslo" | 15:44 | |
openstack | Meeting ended Mon Jul 13 15:44:24 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:44 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/oslo/2020/oslo.2020-07-13-15.00.html | 15:44 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/oslo/2020/oslo.2020-07-13-15.00.txt | 15:44 |
openstack | Log: http://eavesdrop.openstack.org/meetings/oslo/2020/oslo.2020-07-13-15.00.log.html | 15:44 |
smcginnis | bnemec: https://review.opendev.org/#/c/740704/ was updated based on Doug's feedback. | 15:44 |
bnemec | That's what I get for not actually looking at the patch. ;-) | 15:45 |
smcginnis | I didn't really think it would be considered a new feature, but probably safer that way. | 15:45 |
bnemec | Yeah, a feature bump isn't a big deal. | 15:46 |
openstackgerrit | Merged openstack/oslo.messaging stable/queens: Simplify tools/test-setup.sh https://review.opendev.org/739922 | 16:14 |
*** sean-k-mooney has quit IRC | 17:01 | |
openstackgerrit | Merged openstack/oslo.cache master: Introducing usage of pre-commit https://review.opendev.org/720771 | 17:10 |
*** dtantsur is now known as dtantsur|afk | 17:15 | |
*** ralonsoh has quit IRC | 17:23 | |
zaneb | kgiusti: it appears we are having an issue in Heat where we continue to send messages to a queue that only one engine is listening on, so that when it gets shut down we lose messages: http://eavesdrop.openstack.org/irclogs/%23heat/%23heat.2020-07-13.log.html#t2020-07-13T19:04:42 | 19:53 |
zaneb | is there any documentation anywhere on how you're supposed to set queues up for these various purposes? | 19:54 |
kgiusti | zaneb: ping - sorry in a meeting. IIRC the 'amqp_auto_delete' configuration setting in [oslo_messaging_rabbit] controls what gets passed into kombu when a queue is created: https://docs.openstack.org/oslo.messaging/latest/configuration/opts.html#oslo-messaging-rabbit | 20:26 |
*** raildo has quit IRC | 21:10 | |
*** raildo has joined #openstack-oslo | 21:11 | |
*** raildo has quit IRC | 21:17 | |
*** hamalq_ has quit IRC | 22:02 | |
*** hamalq has joined #openstack-oslo | 22:03 | |
*** tosky has quit IRC | 22:42 | |
*** tkajinam has joined #openstack-oslo | 22:54 | |
*** rcernin has joined #openstack-oslo | 23:05 | |
*** rcernin has quit IRC | 23:05 | |
*** rcernin has joined #openstack-oslo | 23:08 | |
*** hoonetorg has quit IRC | 23:24 | |
*** adriant has quit IRC | 23:32 | |
*** adriant has joined #openstack-oslo | 23:33 | |
*** hoonetorg has joined #openstack-oslo | 23:39 | |
*** hamalq has quit IRC | 23:50 | |
*** moguimar has quit IRC | 23:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!