*** irclogbot_1 has quit IRC | 00:16 | |
*** irclogbot_0 has joined #openstack-oslo | 00:20 | |
*** rcernin has quit IRC | 03:02 | |
*** rcernin has joined #openstack-oslo | 03:21 | |
*** rcernin has quit IRC | 03:25 | |
*** rcernin has joined #openstack-oslo | 03:26 | |
openstackgerrit | yatin proposed openstack/oslo.policy master: [DNM] unit tests not working with stevedore > 2.0.1 https://review.opendev.org/741869 | 04:55 |
---|---|---|
*** Luzi has joined #openstack-oslo | 07:02 | |
*** rcernin has quit IRC | 07:24 | |
*** dtantsur|afk is now known as dtantsur | 07:27 | |
*** tosky has joined #openstack-oslo | 07:34 | |
*** rcernin has joined #openstack-oslo | 07:38 | |
*** rcernin has quit IRC | 07:44 | |
*** ralonsoh has joined #openstack-oslo | 07:55 | |
*** ralonsoh_ has joined #openstack-oslo | 08:53 | |
*** ralonsoh has quit IRC | 08:55 | |
*** rcernin has joined #openstack-oslo | 09:10 | |
*** rcernin has quit IRC | 09:15 | |
*** tosky has quit IRC | 10:08 | |
*** Luzi has quit IRC | 10:08 | |
*** irclogbot_0 has quit IRC | 10:08 | |
*** tosky has joined #openstack-oslo | 10:10 | |
*** Luzi has joined #openstack-oslo | 10:10 | |
*** irclogbot_0 has joined #openstack-oslo | 10:10 | |
*** tkajinam has quit IRC | 10:29 | |
*** trident has quit IRC | 10:35 | |
*** trident has joined #openstack-oslo | 10:36 | |
*** raildo has joined #openstack-oslo | 11:38 | |
*** kgiusti has joined #openstack-oslo | 13:00 | |
*** moguimar has joined #openstack-oslo | 13:02 | |
*** zbitter is now known as zaneb | 13:07 | |
*** rcernin has joined #openstack-oslo | 13:07 | |
*** moguimar has quit IRC | 13:09 | |
*** rcernin has quit IRC | 13:12 | |
*** lbragstad has joined #openstack-oslo | 13:16 | |
*** dave-mccowan has joined #openstack-oslo | 13:16 | |
ralonsoh_ | dhellmann, hi | 13:21 |
ralonsoh_ | can I ask you about I8b08f289d446f4775eac1e1a91997fa96f25f641 ? | 13:21 |
ralonsoh_ | I think there is a circular reference there | 13:22 |
ralonsoh_ | oslo_config is calling stevedore | 13:22 |
ralonsoh_ | stevedore importlib_metadata | 13:22 |
*** cognifloyd has joined #openstack-oslo | 13:22 | |
ralonsoh_ | this one oslo_log | 13:22 |
ralonsoh_ | and this one oslo_config cfg | 13:23 |
ralonsoh_ | http://paste.openstack.org/show/796122/ | 13:23 |
ralonsoh_ | that's why oslo_config.cfg has no attribute CONF, is still loading it | 13:23 |
dhellmann | it does look like something is trying to log before logging is set up | 13:25 |
dhellmann | what is being imported on line 61 of that pastebin? | 13:25 |
ralonsoh_ | dhellmann, I need to check that | 13:26 |
ralonsoh_ | but I think oslo_service.__init__ | 13:26 |
ralonsoh_ | is importing oslo_log unnecessarily | 13:26 |
ralonsoh_ | it instantiate LOG = logging.getLogger(__name__) | 13:27 |
ralonsoh_ | but is not used there | 13:27 |
dhellmann | that's possible. removing that may fix this case, but still leave the circular import. ensuring that logging is configured before any dynamic code is loaded should solve the problem more completely. | 13:28 |
ralonsoh_ | dhellmann, I'll check that | 13:28 |
ralonsoh_ | this is happening in a functional test | 13:28 |
ralonsoh_ | while loading a testing module | 13:28 |
ralonsoh_ | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9c1/735802/3/check/neutron-functional/9c1f55b/testr_results.html | 13:28 |
dhellmann | it looks like the test imports neutron_lib which imports oslo_concurrency which imports oslo_config which uses stevedore to load config extensions. Then for some reason one of those plugins does some eventlet stuff? Or maybe that's just a side-effect of eventlet's stack hacking. And then you're right I see oslo_service being imported. | 13:30 |
dhellmann | Why would a plugin load oslo_service? | 13:30 |
*** moguimar has joined #openstack-oslo | 13:30 | |
dhellmann | figuring out what that call to importlib.import_module() is doing should help | 13:31 |
ralonsoh_ | checking now | 13:32 |
*** bnemec has joined #openstack-oslo | 13:32 | |
dtantsur | hey folks, looks like something went wrong in the CI https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_de8/739725/3/check/tooz-tox-py36-mysql/de86bcd/testr_results.html | 13:32 |
dtantsur | this is tooz, and it looks like the mysql driver is broken | 13:32 |
dtantsur | "Context manager interface is removed from Connection. It will be added with different meaning." | 13:35 |
dtantsur | thank you pymysql, we hate you as well :) https://github.com/PyMySQL/PyMySQL/blob/master/CHANGELOG.md | 13:35 |
dtantsur | anyone wants to beat me to fixing it? | 13:35 |
*** moguimar has quit IRC | 13:42 | |
dtantsur | okay, I'm on it | 13:42 |
openstackgerrit | Dmitry Tantsur proposed openstack/tooz master: Fix breakage with PyMySQL 0.10.0 https://review.opendev.org/741945 | 13:43 |
ralonsoh_ | dhellmann, hi again, sorry for the interruption | 13:46 |
ralonsoh_ | but I'm having the same circular import | 13:47 |
*** moguimar has joined #openstack-oslo | 13:47 | |
ralonsoh_ | before executing anything, I import the neutron config library | 13:47 |
ralonsoh_ | from neutron.conf.agent import common as config | 13:47 |
ralonsoh_ | and then I try to execute config.setup_logging() | 13:48 |
ralonsoh_ | but I have the same problem | 13:48 |
ralonsoh_ | actually, to configure the logging I need oslo_config | 13:48 |
dhellmann | does this happen on the master branch, or only with your PR? | 13:48 |
dhellmann | what plugin is being loaded? | 13:49 |
ralonsoh_ | dhellmann, is not a plugging but a module execute in functional test using a shell | 13:49 |
dhellmann | I don't know what that means | 13:50 |
ralonsoh_ | dhellmann, I'm just executing | 13:50 |
ralonsoh_ | python /opt/stack/neutron/neutron/tests/functional/agent/linux/bin/ipt_binname.py | 13:50 |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging master: Move legacy grenade jobs to Zuul v3 https://review.opendev.org/741947 | 13:52 |
openstackgerrit | Dmitry Tantsur proposed openstack/tooz master: Fix breakage with PyMySQL 0.10.0 https://review.opendev.org/741945 | 13:52 |
dtantsur | with a release note ^^^ plz review | 13:52 |
dhellmann | ralonsoh_ : you need to figure out what is being imported by the call to importlib.import_module() on line 61 of the traceback in http://paste.openstack.org/show/796122/ | 13:55 |
dhellmann | add a print statement to your local copy of the code or something | 13:55 |
dhellmann | that will tell us more about what is going on | 13:55 |
dhellmann | my guess is that the change in stevedore has changed the sequencing of imports in neutron's test (maybe neutron itself?) and now something that used to work by accident needs to be fixed to work explicitly | 13:56 |
dhellmann | but until we know what is being imported we won't know what is out of sequence | 13:57 |
ralonsoh_ | dhellmann, I'll try it now | 13:57 |
ralonsoh_ | dhellmann, done: we need first to import the oslo_config module. That breaks the circular import error we had because oslo_config.cfg is already loaded | 14:07 |
ralonsoh_ | dhellmann, thanks for the tips!! | 14:07 |
dhellmann | excellent, I'm glad you worked it out :-) | 14:08 |
openstackgerrit | Lance Bragstad proposed openstack/oslo.policy master: Clarify what exactly an "access file" is https://review.opendev.org/741954 | 14:18 |
bnemec | #startmeeting oslo | 15:00 |
bnemec | Courtesy ping for bnemec, smcginnis, moguimar, johnsom, stephenfin, bcafarel, kgiusti, jungleboyj | 15:00 |
bnemec | #link https://wiki.openstack.org/wiki/Meetings/Oslo#Agenda_for_Next_Meeting | 15:00 |
openstack | Meeting started Mon Jul 20 15:00:51 2020 UTC and is due to finish in 60 minutes. The chair is bnemec. Information about MeetBot at http://wiki.debian.org/MeetBot. | 15:00 |
openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 15:00 |
*** openstack changes topic to " (Meeting topic: oslo)" | 15:00 | |
openstack | The meeting name has been set to 'oslo' | 15:00 |
moguimar | o/ | 15:00 |
johnsom | o/ | 15:00 |
bcafarel | o/ | 15:01 |
jungleboyj | o/ | 15:01 |
kgiusti | o/ | 15:03 |
bnemec | #topic Red flags for/from liaisons | 15:03 |
*** openstack changes topic to "Red flags for/from liaisons (Meeting topic: oslo)" | 15:03 | |
bnemec | Looks like pymysql broke us over the weekend. | 15:03 |
jungleboyj | I am not aware of anything specific to Cinder. | 15:03 |
bnemec | Specifically tooz. | 15:03 |
bcafarel | just a note on neutron side: we got a recent test failure fixed with https://review.opendev.org/#/c/741957/ | 15:04 |
bnemec | dtantsur proposed a fix, which I just started looking at. Unfortunately it seems we have no lower-constraints job on that repo so there's nothing verifying that the fix works with older versions too. :-/ | 15:04 |
johnsom | Nothing from Octavia | 15:05 |
dtantsur | bnemec: I don't think there is a version that did not have Connection.cursor() | 15:05 |
moguimar | Nothing from Barbican | 15:05 |
bnemec | dtantsur: Yeah, that was my guess. | 15:06 |
bnemec | bcafarel: Ick. I hate eventlet. | 15:06 |
bcafarel | :) yes a nice surprise circular import | 15:07 |
bnemec | Oh, this is because of the stevedore change. | 15:07 |
bnemec | I wonder if there's any other way to break that circular import. Importing stuff before eventlet is monkey patched goes against our documented eventlet best practices. | 15:08 |
bnemec | dhellmann: ^ | 15:08 |
*** Luzi has quit IRC | 15:09 | |
bnemec | I guess as long as you're unblocked we can live with it. | 15:10 |
bnemec | #topic Releases | 15:10 |
*** openstack changes topic to "Releases (Meeting topic: oslo)" | 15:10 | |
*** ralonsoh_ is now known as ralonsoh | 15:10 | |
bnemec | I saw a bunch of release requests from hberaud last week, so I assume we're up to date on that. | 15:10 |
hberaud | o/ sorry to be late | 15:10 |
bnemec | np | 15:11 |
bnemec | Anything to add about releases? | 15:11 |
hberaud | indeed normally we more or less up-to-date | 15:11 |
bnemec | Cool. I guess people can look for a tooz release in the near future to fix the pymysql breakage. | 15:12 |
bnemec | #topic Action items from last meeting | 15:12 |
*** openstack changes topic to "Action items from last meeting (Meeting topic: oslo)" | 15:12 | |
bnemec | "kgiusti to look at migrating messaging jobs to zuulv3." | 15:12 |
bnemec | I saw some patches related to this. | 15:13 |
hberaud | yep | 15:13 |
bnemec | I think I even reviewed one. | 15:13 |
kgiusti | bnemec: yeah, seems straightforward: https://etherpad.opendev.org/p/goal-victoria-native-zuulv3-migration | 15:13 |
kgiusti | bnemec: hberaud: but Zuul (and tosky) have not had the final say yet :) | 15:13 |
hberaud | ack | 15:13 |
bnemec | Great! | 15:14 |
bnemec | "moguimar to propose patch integrating pre-commit to the gate for oslo.cache" | 15:14 |
moguimar | yes I did | 15:14 |
moguimar | me and hberaud | 15:14 |
moguimar | ah, the gating patch, I guess I didn't do that one | 15:15 |
hberaud | IIRC it was merged, isn't | 15:15 |
hberaud | ? | 15:15 |
moguimar | the precommit is merged | 15:15 |
*** hamalq has joined #openstack-oslo | 15:15 | |
hberaud | ack | 15:15 |
bnemec | Yeah, this was a followup to that. | 15:15 |
bnemec | Okay, will keep it on the list for next week then. | 15:15 |
bnemec | #action moguimar to propose patch integrating pre-commit to the gate for oslo.cache | 15:15 |
hberaud | ah okay, I missed the last meeting, so I got it | 15:15 |
moguimar | thanks ben | 15:16 |
bnemec | That's all of the action items. | 15:16 |
bnemec | #topic zuulv3 migration | 15:17 |
*** openstack changes topic to "zuulv3 migration (Meeting topic: oslo)" | 15:17 | |
bnemec | I guess we already kind of covered this too. | 15:17 |
bnemec | Besides the messaging jobs that Ken is handling, we have a couple of grenade jobs that need to be migrated and the pbr jobs. | 15:18 |
bnemec | I think that should be all that's left. | 15:18 |
bnemec | I assume grenade will be relatively easy since there should be a common migration path for that one. | 15:18 |
*** jgwentworth is now known as melwitt | 15:19 | |
bnemec | If someone wants to look into it, maybe sync with tosky. | 15:19 |
bnemec | The pbr jobs might be more interesting since I suspect they do some non-standard stuff. | 15:19 |
tosky | yep (grenade probably easy; others not sure) | 15:19 |
stephenfin | the pbr jobs suuuuck | 15:19 |
bnemec | They're testing installation with the proposed pbr patch, so they may not be able to rely on the normal zuul stuff. | 15:20 |
stephenfin | we would probably benefit from recreating them from scratch | 15:20 |
* bnemec assigns stephenfin to do that migration ;-) | 15:20 | |
bnemec | That's certainly an option. | 15:20 |
stephenfin | Probably a necessity. I can't solve https://review.opendev.org/#/c/719964/ :-\ | 15:21 |
bnemec | Ah, delightful. | 15:22 |
bnemec | At least since they're blocking something we shouldn't forget to do this. :-) | 15:22 |
tosky | kgiusti had a question about devstack-plugin-zmq; if support was dropped long ago, shouldn't the repository be retired? | 15:23 |
bnemec | Yeah, I think that's the right thing to do for that repo. | 15:23 |
kgiusti | tosky: most certainly | 15:24 |
bnemec | I guess the only concern would be if we're still using it in an older stable branch. | 15:24 |
bnemec | I don't know that we ever branched the zmq plugin. | 15:24 |
kgiusti | bnemec: dunno - but I doubt whatever tests used it were ever voting | 15:24 |
bnemec | On the other hand, the zmq tests were always super flaky and we're pretty sure the driver didn't work right anyway, so if it turns out that we break a stable branch we can probably just remove the tests. | 15:25 |
kgiusti | bnemec: zmq never really got stable | 15:25 |
smcginnis | It seemed an effort that was kind of dead on arrival. | 15:25 |
bnemec | Yeah | 15:25 |
kgiusti | bnemec: so how does one go about retiring a repo? | 15:25 |
bnemec | There's an infra doc. | 15:25 |
kgiusti | bnemec: kk - I'm just being lazy | 15:26 |
stephenfin | https://docs.openstack.org/project-team-guide/repository.html | 15:26 |
kgiusti | bnemec: stephenfin: most excellent thanks - I have an Action Item for next week then. | 15:26 |
bnemec | Cool, thanks. | 15:26 |
bnemec | #action kgiusti to retire devstack-plugin-zmq | 15:26 |
bnemec | Still some open questions on this, but I think we've got enough planned for the next week at least. | 15:28 |
bnemec | Anything else to cover on the migration topic before we move on? | 15:28 |
bnemec | #topic Weekly Wayward Review | 15:29 |
*** openstack changes topic to "Weekly Wayward Review (Meeting topic: oslo)" | 15:29 | |
bnemec | #link https://review.opendev.org/725317 | 15:30 |
bnemec | Simple one. I believe the rest of these merged already, right? | 15:30 |
moguimar | done | 15:30 |
bnemec | Thanks! | 15:32 |
bnemec | #topic Open discussion | 15:32 |
*** openstack changes topic to "Open discussion (Meeting topic: oslo)" | 15:32 | |
hberaud | bnemec: we only have this one now => https://review.opendev.org/#/c/725327/ | 15:32 |
hberaud | (similar patch) | 15:33 |
hberaud | but with some debats on it | 15:33 |
hberaud | s/debat/debates/ | 15:33 |
bnemec | Did we ever make oslo-cookiecutter reflect the main cookiecutter change? | 15:34 |
bnemec | Since we merged all of the other copies of that patch I think we might as well go ahead with it. | 15:35 |
hberaud | lemme check | 15:35 |
bnemec | Zane makes a good point about keeping our stuff in sync though. | 15:35 |
* bnemec had this on his todo list for a long time and never actually did it :-/ | 15:36 | |
hberaud | bnemec: we don't submit related patches against oslo-cookiecutter | 15:36 |
hberaud | s/submit/submitted/ | 15:37 |
moguimar | I think we can go ahead with this one and maybe action item to update oslo-cookiecutter | 15:38 |
bnemec | Okay, so that's another thing we need to do before calling the contributor docs goal done. | 15:38 |
hberaud | yep | 15:38 |
hberaud | I'll try to submit the oslo-cookiecutter patch tomorrow | 15:38 |
bnemec | Great, thanks! | 15:39 |
bnemec | #action hberaud to sync oslo-cookiecutter contributing template with main cookiecutter one | 15:39 |
bnemec | Anything else to discuss this week? | 15:40 |
moguimar | yep | 15:40 |
moguimar | https://review.opendev.org/#/c/640057/ | 15:40 |
moguimar | I was poking open patches in oslo.config and castellan | 15:40 |
moguimar | and updated the rst2txt patch to requirements | 15:40 |
moguimar | that one merged and then this patch from stephenfin got unblocked | 15:41 |
openstackgerrit | Merged openstack/oslo.limit master: Align contributing doc with oslo's policy https://review.opendev.org/725317 | 15:41 |
moguimar | but I'm not sure if I just created more work now that is not that big of a priority | 15:41 |
bnemec | I saw some discussion about this lsat week. | 15:41 |
bnemec | *last | 15:41 |
hberaud | also, I want to bring few words about eventlet, and especially about the stdlib SSL issue with monkey patched env, a fix have been merged on eventlet [1] so normally it will improve the situation, but I don't know it will be released (or if it is already) [1] https://github.com/eventlet/eventlet/commit/02fa826d22d0df7f9379c3a1e5cd2192e0ffadd8 | 15:43 |
bnemec | It sounds like a good thing, but has the potential to break people if they have invalid rst? | 15:43 |
moguimar | I think stephenfin would be the best person to answer that | 15:44 |
bnemec | hberaud: So we probably want to bump our minimum eventlet to that when it releases? Or at least document that people need that version for sane ssl? | 15:44 |
hberaud | yep | 15:44 |
hberaud | I'll try to track possible advancments and keep us up-to-date about this topic | 15:45 |
stephenfin | bnemec: Sphinx has a context manager you can use when parsing potentially broken rST. We use it for the oslo.config | 15:45 |
stephenfin | ...Sphinx extension | 15:45 |
bnemec | I assume that would make this pretty safe to do? | 15:46 |
bnemec | If I'm understanding the question right, we're trying to decide whether cleaning up the doc output is worth the potential breakage for invalid rst. | 15:47 |
bnemec | If we can eliminate the latter then this seems like a win, right? | 15:47 |
stephenfin | Yup, it should be fine | 15:48 |
bnemec | Okay, cool. | 15:48 |
stephenfin | if is_valid_rst: parse else no_parse | 15:48 |
bnemec | moguimar: ^Does that answer your question? | 15:48 |
openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/oslo.service master: Do not import "oslo.log" in the main module https://review.opendev.org/741972 | 15:50 |
moguimar | my main question is: should we keep this patch on or revert rst2txt from requirements | 15:50 |
moguimar | and abandon it | 15:50 |
bnemec | Seems like a good patch if we can get it working. | 15:50 |
moguimar | ack | 15:51 |
bnemec | It seems like most of the work is done, right? | 15:51 |
stephenfin | Yeah, I think it still makes sense. Just needs the final issues closed out | 15:51 |
moguimar | I guess since we put rst2txt as an extra, we revert the test cases to the original expected | 15:51 |
moguimar | and the patch should go back passing CI | 15:51 |
moguimar | I could do that | 15:52 |
bnemec | Sounds good. | 15:53 |
bnemec | #action moguimar to get https://review.opendev.org/#/c/640057/ in shape to merge | 15:53 |
moguimar | ack | 15:54 |
bnemec | Thanks for going through the patch backlog! | 15:54 |
bnemec | I haven't been doing that much lately. | 15:54 |
bnemec | We're down to about 5 minutes. Anything else before we end the meeting? | 15:55 |
bnemec | Okay, thanks for joining everyone! | 15:57 |
bnemec | #endmeeting | 15:57 |
*** openstack changes topic to "OpenStack Common Libraries | https://wiki.openstack.org/wiki/Oslo" | 15:57 | |
openstack | Meeting ended Mon Jul 20 15:57:05 2020 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:57 |
openstack | Minutes: http://eavesdrop.openstack.org/meetings/oslo/2020/oslo.2020-07-20-15.00.html | 15:57 |
openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/oslo/2020/oslo.2020-07-20-15.00.txt | 15:57 |
openstack | Log: http://eavesdrop.openstack.org/meetings/oslo/2020/oslo.2020-07-20-15.00.log.html | 15:57 |
hberaud | bnemec: thanks | 15:57 |
johnsom | o/ | 15:57 |
*** hamalq has quit IRC | 16:01 | |
*** hamalq has joined #openstack-oslo | 16:01 | |
*** hamalq_ has joined #openstack-oslo | 16:07 | |
*** hamalq has quit IRC | 16:11 | |
*** yoctozepto has quit IRC | 16:12 | |
*** yoctozepto has joined #openstack-oslo | 16:13 | |
*** dtantsur is now known as dtantsur|afk | 16:29 | |
*** ralonsoh has quit IRC | 17:48 | |
openstackgerrit | Ken Giusti proposed openstack/oslo.messaging master: Enable the rabbitmq failover test during the RabbitMQ functional test https://review.opendev.org/741998 | 17:56 |
*** tosky has quit IRC | 18:57 | |
*** dave-mccowan has quit IRC | 20:44 | |
*** dave-mccowan has joined #openstack-oslo | 20:46 | |
openstackgerrit | Merged openstack/tooz master: Fix breakage with PyMySQL 0.10.0 https://review.opendev.org/741945 | 20:48 |
*** bnemec has quit IRC | 20:55 | |
*** bnemec has joined #openstack-oslo | 21:10 | |
*** cognifloyd has quit IRC | 21:19 | |
*** raildo has quit IRC | 21:25 | |
*** moguimar has quit IRC | 22:21 | |
*** tkajinam has joined #openstack-oslo | 22:53 | |
*** moguimar has joined #openstack-oslo | 22:53 | |
*** moguimar has quit IRC | 22:53 | |
*** rcernin has joined #openstack-oslo | 22:58 | |
*** rcernin has quit IRC | 22:59 | |
*** rcernin has joined #openstack-oslo | 22:59 | |
*** bnemec has quit IRC | 23:20 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!