openstackgerrit | norman shen proposed openstack/oslo.messaging stable/ussuri: Catch ConnectionForced Exception https://review.opendev.org/743647 | 00:04 |
---|---|---|
*** rcernin has quit IRC | 00:05 | |
*** brinzhang_ has joined #openstack-oslo | 00:14 | |
*** brinzhang has quit IRC | 00:17 | |
*** rcernin has joined #openstack-oslo | 00:31 | |
*** zzzeek has quit IRC | 00:57 | |
*** jberg-dev has quit IRC | 00:57 | |
*** dtantsur|afk has quit IRC | 00:57 | |
*** zzzeek has joined #openstack-oslo | 01:01 | |
*** jberg-dev has joined #openstack-oslo | 01:01 | |
*** dtantsur|afk has joined #openstack-oslo | 01:01 | |
*** tkajinam has quit IRC | 01:06 | |
*** tkajinam has joined #openstack-oslo | 01:06 | |
*** tkajinam has quit IRC | 01:33 | |
*** tkajinam has joined #openstack-oslo | 01:34 | |
*** moguimar_ has quit IRC | 02:26 | |
openstackgerrit | Brin Zhang proposed openstack/oslo.cache master: Support SASL protocol for memcached https://review.opendev.org/742060 | 03:17 |
*** cognifloyd has joined #openstack-oslo | 03:19 | |
*** cognifloyd has quit IRC | 05:24 | |
openstackgerrit | Brin Zhang proposed openstack/oslo.cache master: Add python-binary-memcached and uhashring to support SASL https://review.opendev.org/743484 | 05:53 |
openstackgerrit | Brin Zhang proposed openstack/oslo.cache master: Support SASL protocol for memcached https://review.opendev.org/742060 | 05:53 |
*** cognifloyd has joined #openstack-oslo | 06:06 | |
*** moguimar_ has joined #openstack-oslo | 06:30 | |
*** cognifloyd has quit IRC | 06:38 | |
*** brinzhang0 has joined #openstack-oslo | 07:02 | |
*** brinzhang_ has quit IRC | 07:05 | |
*** brinzhang_ has joined #openstack-oslo | 07:22 | |
*** brinzhang0 has quit IRC | 07:25 | |
*** tosky has joined #openstack-oslo | 07:39 | |
*** ralonsoh has joined #openstack-oslo | 07:40 | |
*** brinzhang0 has joined #openstack-oslo | 07:45 | |
*** brinzhang_ has quit IRC | 07:48 | |
*** dtantsur|afk is now known as dtantsur | 07:53 | |
*** janders has joined #openstack-oslo | 08:44 | |
*** dtantsur is now known as dtantsur|brb | 08:58 | |
janders | g | 09:06 |
janders | g'day openstack-oslo | 09:06 |
janders | I'm working on a patch for Ironic which is using MultiOpt configuration | 09:07 |
janders | I'm hitting an issue with double quotes getting inserted into the configuration | 09:08 |
janders | http://paste.openstack.org/show/796409/ | 09:08 |
janders | (the mangled value is in the DEBUG log and also at the bottom of the paste) | 09:08 |
janders | Have you seen similar issues before? Do you have any pointers on how to resolve this? | 09:08 |
janders | those extra quotes are breaking my dictionaries :( | 09:09 |
*** rcernin has quit IRC | 09:12 | |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Apply fixes for pre-commit compliance in all code https://review.opendev.org/742440 | 09:17 |
openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add pre-commit to pep8 gate https://review.opendev.org/742441 | 09:17 |
*** moguimar_ is now known as moguimar | 09:32 | |
moguimar | janders, do you have a config example? | 09:33 |
janders | Hi moguimar yes I do | 09:36 |
moguimar | and a link to the config opt | 09:36 |
moguimar | and I'll try to debug it here | 09:36 |
janders | http://paste.openstack.org/show/796409/ covers just the lines I added | 09:36 |
janders | getting more content now | 09:37 |
janders | would you like complete files? | 09:37 |
moguimar | nope | 09:38 |
moguimar | is clean_step_add_params the name of your config opt? | 09:38 |
moguimar | how is it declared? | 09:38 |
moguimar | just wanna isolate it a play around a bit | 09:39 |
janders | correct, it's clean_step_add_params | 09:40 |
janders | http://paste.openstack.org/show/796413/ | 09:40 |
janders | here's how it's added to conductor's config options | 09:41 |
stephenfin | janders: I suspect the issue lies with the Dict type rather than the MultiOpt | 09:41 |
stephenfin | that expected simple string key-value pairs | 09:41 |
stephenfin | *expects | 09:42 |
janders | stephenfin thank you for your feedback. Do you think we need to re-think how the data is structured? | 09:42 |
stephenfin | janders: I have no idea if this will work, but can you try replacing this | 09:43 |
stephenfin | item_type=types.Dict(), | 09:43 |
stephenfin | with this | 09:43 |
stephenfin | item_type=types.Dict(value_type=types.Dict()), | 09:44 |
stephenfin | and see how things work | 09:44 |
stephenfin | ? | 09:44 |
janders | ok! trying now | 09:44 |
stephenfin | With that said, this is still quite a complex config option. Even if that works, it might be good to identify a way to flatten things. Is there a known set of key values (erase_devices, format, ...) you can enumerate? | 09:45 |
janders | unfortunately I had no luck with item_type=types.Dict(value_type=types.Dict()) | 10:00 |
*** tkajinam has quit IRC | 10:01 | |
janders | I will investigate further tomorrow | 10:02 |
janders | I hit a different error this time, perhaps I need to tweak the parsing code a little | 10:02 |
janders | thanks a lot, I will keep you posted | 10:03 |
janders | http://paste.openstack.org/show/796417/ | 10:09 |
janders | that's what I got to - chances are, it might be fixable | 10:09 |
janders | however - stephenfin I noted your comment regarding complexity and I do agree! Perhaps the spec I'm implementing needs some re-thinking | 10:10 |
*** dtantsur|brb is now known as dtantsur | 11:26 | |
*** raildo has joined #openstack-oslo | 11:44 | |
openstackgerrit | Ann Taraday proposed openstack/taskflow master: Add sentinel redis support https://review.opendev.org/743737 | 12:00 |
*** moguimar has quit IRC | 12:20 | |
*** moguimar has joined #openstack-oslo | 12:20 | |
*** moguimar has quit IRC | 12:20 | |
*** moguimar has joined #openstack-oslo | 12:21 | |
*** moguimar has quit IRC | 12:45 | |
*** moguimar has joined #openstack-oslo | 12:45 | |
*** moguimar has quit IRC | 13:21 | |
*** moguimar has joined #openstack-oslo | 13:23 | |
*** dave-mccowan has joined #openstack-oslo | 13:28 | |
dhellmann | janders : you might want to look at the option groups feature https://docs.openstack.org/oslo.config/latest/reference/defining.html#option-groups and especially the ability to dynamically register groups of options. "driver groups" may also be useful. | 13:39 |
*** moguimar has quit IRC | 13:39 | |
dhellmann | you'll end up with one option to list the sets of parameters and one group per set | 13:39 |
*** moguimar has joined #openstack-oslo | 13:41 | |
dhellmann | something more like this: http://paste.openstack.org/show/796426/ | 13:41 |
dhellmann | that's much easier to generate with a template and read as a human | 13:42 |
openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/tooz master: Use safe_decode for decoding in zookeeper driver https://review.opendev.org/743770 | 14:10 |
*** brinzhang_ has joined #openstack-oslo | 14:17 | |
*** brinzhang0 has quit IRC | 14:20 | |
*** cognifloyd has joined #openstack-oslo | 14:38 | |
*** rcernin has joined #openstack-oslo | 14:41 | |
*** lbragstad_ has joined #openstack-oslo | 14:51 | |
*** rcernin_ has joined #openstack-oslo | 14:51 | |
*** irclogbot_0 has quit IRC | 14:52 | |
*** rcernin_ has quit IRC | 14:56 | |
*** rcernin has quit IRC | 14:58 | |
*** lbragstad has quit IRC | 14:58 | |
*** irclogbot_2 has joined #openstack-oslo | 14:59 | |
*** brinzhang0 has joined #openstack-oslo | 15:04 | |
*** brinzhang_ has quit IRC | 15:06 | |
*** brinzhang_ has joined #openstack-oslo | 15:08 | |
*** hoonetorg has quit IRC | 15:09 | |
*** brinzhang_ has quit IRC | 15:09 | |
*** brinzhang_ has joined #openstack-oslo | 15:10 | |
*** brinzhang0 has quit IRC | 15:12 | |
*** hoonetorg has joined #openstack-oslo | 15:21 | |
*** janders has quit IRC | 15:26 | |
openstackgerrit | Dmitriy Rabotyagov (noonedeadpunk) proposed openstack/tooz master: Use safe_decode for decoding in zookeeper driver https://review.opendev.org/743770 | 15:43 |
*** brinzhang0 has joined #openstack-oslo | 16:10 | |
*** brinzhang_ has quit IRC | 16:13 | |
*** dtantsur is now known as dtantsur|afk | 17:21 | |
openstackgerrit | Luigi Toscano proposed openstack/oslo.log master: zuul: port the legacy grenade job https://review.opendev.org/743819 | 18:14 |
tosky | ^^ that seemed easy enough :) | 18:15 |
*** brinzhang_ has joined #openstack-oslo | 18:30 | |
*** brinzhang0 has quit IRC | 18:33 | |
openstackgerrit | Merged openstack/tooz master: Use safe_decode for decoding in zookeeper driver https://review.opendev.org/743770 | 18:40 |
*** ralonsoh has quit IRC | 18:53 | |
*** lbragstad_ is now known as lbragstad | 19:01 | |
*** moguimar_ has joined #openstack-oslo | 19:55 | |
*** moguimar has quit IRC | 19:55 | |
*** moguimar_ has quit IRC | 20:03 | |
*** moguimar_ has joined #openstack-oslo | 20:04 | |
*** moguimar_ has quit IRC | 20:34 | |
*** kgiusti has left #openstack-oslo | 20:38 | |
*** raildo has quit IRC | 21:26 | |
*** rcernin_ has joined #openstack-oslo | 22:35 | |
*** rcernin_ has quit IRC | 22:48 | |
*** rcernin has joined #openstack-oslo | 22:48 | |
*** tkajinam has joined #openstack-oslo | 22:53 | |
*** tosky has quit IRC | 23:21 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!