| *** rcernin has quit IRC | 01:19 | |
| *** rcernin has joined #openstack-oslo | 01:28 | |
| *** rcernin has quit IRC | 02:28 | |
| *** rcernin has joined #openstack-oslo | 02:30 | |
| *** rcernin has quit IRC | 03:24 | |
| *** rcernin has joined #openstack-oslo | 03:47 | |
| *** dave-mccowan has quit IRC | 03:57 | |
| adriant | Would anyone who works on oslo.config be able to weigh in on: http://lists.openstack.org/pipermail/openstack-discuss/2020-August/016553.html and the review mentioned there: https://review.opendev.org/#/c/746436/ ? | 04:13 |
|---|---|---|
| adriant | I don't doubt we could fit some of the features I need into oslo.config, but I have a feeling it doesn't really fit into olso.config | 04:15 |
| adriant | as silly as that sounds | 04:15 |
| adriant | I feel like oslo.config is nice and simple, and trying to turn it into something that supports nesting (and yaml/toml) breaks a lot of what people like about it | 04:16 |
| *** brinzhang0 has joined #openstack-oslo | 05:25 | |
| *** brinzhang_ has quit IRC | 05:29 | |
| *** brinzhang0 has quit IRC | 06:45 | |
| *** brinzhang0 has joined #openstack-oslo | 06:46 | |
| *** moguimar has joined #openstack-oslo | 06:48 | |
| *** brinzhang0 has quit IRC | 07:30 | |
| yoctozepto | morning | 07:34 |
| *** dtantsur|afk is now known as dtantsur | 07:34 | |
| yoctozepto | bnemec: just checking but you do agree to have etcd3gw under Oslo? | 07:35 |
| yoctozepto | (I started "move's technical details" thread with infra on #opendev if you want to stop by) | 07:36 |
| *** johnsom has quit IRC | 07:41 | |
| *** vdrok has quit IRC | 07:44 | |
| *** vdrok has joined #openstack-oslo | 07:46 | |
| *** rpittau has quit IRC | 07:47 | |
| *** rpittau has joined #openstack-oslo | 07:56 | |
| *** johnsom has joined #openstack-oslo | 07:57 | |
| *** elod is now known as elod_off | 07:58 | |
| *** rcernin has quit IRC | 07:58 | |
| *** tosky has joined #openstack-oslo | 08:18 | |
| *** vdrok has quit IRC | 08:30 | |
| *** vdrok has joined #openstack-oslo | 08:30 | |
| *** rpittau has quit IRC | 08:30 | |
| *** rpittau has joined #openstack-oslo | 08:30 | |
| *** johnsom has quit IRC | 08:30 | |
| *** johnsom has joined #openstack-oslo | 08:30 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Adding functional tests for memcache_pool backend https://review.opendev.org/718176 | 08:36 |
| moguimar | hberaud | 10:05 |
| moguimar | on https://review.opendev.org/#/c/718176/15 | 10:05 |
| moguimar | how do you want to structure the functional tests? | 10:05 |
| moguimar | tests/functional/backend? | 10:06 |
| moguimar | I was thinking about test/functional/memcached/test_"driver".py | 10:07 |
| moguimar | the class name feels confusing now | 10:13 |
| moguimar | class Something(test_base.BaseTestCaseCacheBackend)... | 10:13 |
| moguimar | we are testing a driver, not a backend | 10:13 |
| hberaud | moguimar: o/ | 10:31 |
| hberaud | primarly I was thinking about a sub directory for each driver e.g functional/{driver_name} => functional/memcache_pool | 10:32 |
| hberaud | moguimar: ^^ | 10:33 |
| moguimar | makes more sense | 10:34 |
| hberaud | but indeed we can consider to have a sub dir for each backend (etcd, memcached) and then inside of them a python file dedicated for each driver related to the backend | 10:34 |
| moguimar | this way we isolate drivers in different test runs | 10:34 |
| moguimar | easier to pinpoint which driver is failing on zuul | 10:35 |
| moguimar | but consumes more machines | 10:35 |
| moguimar | what do you think? | 10:35 |
| moguimar | running every driver in the same memcached instance might be flaky? | 10:36 |
| hberaud | Personaly I prefer to give the priority to the readability first | 10:36 |
| moguimar | so lets go with functional/backend_driver | 10:36 |
| moguimar | I'll change my patch | 10:37 |
| hberaud | machines consumed is related to patches submitted and we don't have patches each hours :) | 10:37 |
| moguimar | ok | 10:37 |
| hberaud | *sumitted | 10:37 |
| hberaud | *submitted | 10:37 |
| moguimar | do you wanna rebase your patch over mine? | 10:37 |
| hberaud | ok :) | 10:37 |
| moguimar | they'll probably conflict | 10:37 |
| hberaud | no problem I'll fix them | 10:38 |
| hberaud | just update your patch first and I'll rebase | 10:38 |
| moguimar | hberaud, do you really think we need proxies=['oslo_cache.testing.CacheIsolatingProxy'], | 11:03 |
| moguimar | it looks like to be a dogpile.cache.memory thing | 11:03 |
| hberaud | moguimar: where have you seen it? | 11:06 |
| moguimar | https://opendev.org/openstack/oslo.cache/src/branch/master/oslo_cache/testing.py#L48 | 11:07 |
| hberaud | hmm... these changes are not mine, I can find them on tests [1] that I refactored few months ago [2] [1] https://github.com/openstack/oslo.cache/blob/master/oslo_cache/tests/test_cache.py#L30 [2] https://github.com/openstack/oslo.cache/commit/9227352b39e65c8d457e91a69921d52139d048a1 but this was already there | 11:10 |
| hberaud | so you're surely right | 11:10 |
| hberaud | but by default if no backend are given we test against the dogpile cache in memory | 11:11 |
| hberaud | so IIRC by default we need that | 11:12 |
| hberaud | (due to the fact that the default used backend is the dogpile.cache in memory) | 11:13 |
| openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add Memcached functional tests to gate https://review.opendev.org/746045 | 11:19 |
| moguimar | lets see what does the gate thinks about my changes first before you rebase | 11:19 |
| openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add Memcached functional tests to gate https://review.opendev.org/746045 | 11:20 |
| openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add Memcached functional tests to gate https://review.opendev.org/746045 | 11:22 |
| moguimar | hberaud, but we don't run functional tests without setting a backend properly | 11:24 |
| hberaud | moguimar: > "lets see what does..." ack | 11:25 |
| hberaud | moguimar: you're right IIRC I added a rule to avoid to run functional tests against the default | 11:28 |
| moguimar | gotta go get some lunch | 11:29 |
| moguimar | o/ | 11:30 |
| hberaud | bon appetit | 11:30 |
| *** raildo has joined #openstack-oslo | 12:04 | |
| openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add Memcached functional tests to gate https://review.opendev.org/746045 | 12:40 |
| openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add Memcached functional tests to gate https://review.opendev.org/746045 | 12:41 |
| moguimar | hberaud, zuul seems to like my patch so far | 12:58 |
| *** dave-mccowan has joined #openstack-oslo | 13:07 | |
| *** redrobot has quit IRC | 13:08 | |
| *** kgiusti has joined #openstack-oslo | 13:11 | |
| openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add TLS Memcached functional tests to gate https://review.opendev.org/747161 | 13:30 |
| openstackgerrit | Moisés Guimarães proposed openstack/oslo.cache master: Add TLS Memcached functional tests to gate https://review.opendev.org/747161 | 13:34 |
| hberaud | moguimar: see my comment on https://review.opendev.org/#/c/746045/ | 13:37 |
| moguimar | yep | 13:37 |
| moguimar | the idea is for you to add memcache_pool on top of it | 13:38 |
| hberaud | yep | 13:38 |
| moguimar | I need tests for dogpile | 13:38 |
| moguimar | cause of TLS | 13:38 |
| moguimar | check https://review.opendev.org/#/c/747161/2 | 13:38 |
| hberaud | it's depend if this patch is strongly linked to https://review.opendev.org/#/c/743484/ or not | 13:39 |
| hberaud | moguimar: if https://review.opendev.org/#/c/746045/ is dedicated to test https://review.opendev.org/#/c/743484/ then I think this functional test is false | 13:40 |
| moguimar | it is not | 13:41 |
| hberaud | moguimar: oh nope sorry | 13:41 |
| hberaud | wrong links | 13:41 |
| hberaud | so no np | 13:41 |
| hberaud | np | 13:41 |
| moguimar | that is the base functional tests for dogpile.cache.bmemcached | 13:41 |
| hberaud | ok | 13:41 |
| moguimar | based on that, Jorhson will implement his tests with SASL | 13:42 |
| hberaud | I don't why but I was thinking both patches are linked | 13:42 |
| moguimar | they will need to patch pifpaf for sasl params | 13:42 |
| moguimar | I'll drop the topic from it | 13:42 |
| hberaud | they are but on a different order then the one I was thinking | 13:42 |
| hberaud | so ignore my comment | 13:43 |
| moguimar | topic fixed | 13:43 |
| *** Luzi has joined #openstack-oslo | 13:45 | |
| hberaud | moguimar: you did an amazing works related to TLS on the whole stack, kudos! | 13:57 |
| moguimar | thanks =D | 13:59 |
| moguimar | I'm adding a MEMCACHED_TLS_ENABLED env var to pifpaf, so we can have less code on our side | 13:59 |
| moguimar | and drop that passenv | 13:59 |
| moguimar | hberaud, scoriacorp is my fake org | 14:06 |
| hberaud | ack | 14:06 |
| moguimar | tls_memcached is a wrapper around the official version | 14:07 |
| moguimar | it adds the certificates and keys generation | 14:07 |
| moguimar | that's why I'm extracting them from there | 14:07 |
| bnemec | yoctozepto: Yeah, I'm fine with that. | 14:07 |
| moguimar | ok, I think this one is ready to go | 14:08 |
| moguimar | https://review.opendev.org/#/c/746045/13 | 14:08 |
| moguimar | hberaud, bnemec ^ | 14:08 |
| moguimar | the TLS one will fail as memcached with tls has not landed yet on ubuntu-focal | 14:09 |
| moguimar | and we are actually testing on ubuntu-bionic still | 14:09 |
| moguimar | tosky, any tips on what are we missing here? | 14:09 |
| moguimar | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_3fc/747161/2/check/oslo.cache-functional-tls-dogpile.cache.bmemcached/3fc1383/job-output.txt | 14:10 |
| moguimar | those are logs for this patch | 14:10 |
| moguimar | https://review.opendev.org/#/c/747161/2 | 14:10 |
| yoctozepto | bnemec: ack, thanks | 14:11 |
| hberaud | moguimar: can't we use the official memcached image here? => https://review.opendev.org/#/c/747161/2/oslo_cache/tests/functional/tls/update.sh | 14:18 |
| moguimar | hberaud, we can't | 14:19 |
| hberaud | ack thanks | 14:19 |
| moguimar | the keys are generated by me and layered over the official memcached | 14:20 |
| hberaud | moguimar: I missed the link you put about it | 14:20 |
| moguimar | https://github.com/scoriacorp/docker-tls-memcached | 14:21 |
| hberaud | yep I seen | 14:21 |
| yoctozepto | bnemec: qq - would you like it to be in storyboard or launchpad? | 14:22 |
| yoctozepto | bnemec: for now I'll treat it as tooz and pin it to launchpad | 14:29 |
| smcginnis | bnemec: There was a question earlier in the channel from Adrian about the config package he wrote for Adjutant. | 14:39 |
| smcginnis | bnemec: Not sure if we have someone familiar enough with oslo.config to see what is being done there, but it would be great if we didn't have to add a new config package if we don't really have to. | 14:40 |
| bnemec | yoctozepto: Sorry, yeah. We're still on launchpad. | 14:41 |
| bnemec | smcginnis: Yeah, I saw that email. I'll try to get a response written shortly. | 14:42 |
| yoctozepto | bnemec: ack, no problem | 14:42 |
| smcginnis | bnemec: If it ends up they are doing something entirely unique, then I guess that's the right path. I haven't been able to look close enough at what they are doing or what they actually need. | 14:43 |
| yoctozepto | bnemec: https://review.opendev.org/747185 and https://review.opendev.org/747188 | 14:43 |
| yoctozepto | you should probably ack at least the governance one | 14:43 |
| yoctozepto | best both ;d | 14:43 |
| *** larainema has quit IRC | 15:10 | |
| *** Luzi has quit IRC | 15:18 | |
| openstackgerrit | Hervé Beraud proposed openstack/oslo.cache master: Adding functional tests for memcache_pool backend https://review.opendev.org/718176 | 15:26 |
| tosky | moguimar: sorry, it was (overlapping) meeting time; is still there something where I can help? | 15:29 |
| moguimar | yep, I saw in the logs the string ubuntu-bionic | 15:30 |
| moguimar | I wonder what do we need to go ubuntu-focal | 15:30 |
| moguimar | for oslo.cache | 15:30 |
| *** tosky_ has joined #openstack-oslo | 15:35 | |
| *** tosky has quit IRC | 15:36 | |
| *** tosky_ is now known as tosky | 15:37 | |
| yoctozepto | bnemec: https://review.opendev.org/747188 needs your vote again; you bought me on that tag | 16:39 |
| *** dtantsur is now known as dtantsur|afk | 17:04 | |
| yoctozepto | bnemec: https://review.opendev.org/747185 hopefully the last iteration! | 19:29 |
| *** hberaud has quit IRC | 20:02 | |
| *** yoctozepto2 has joined #openstack-oslo | 20:06 | |
| *** yoctozepto has quit IRC | 20:07 | |
| *** yoctozepto2 is now known as yoctozepto | 20:07 | |
| *** jkulik has quit IRC | 20:10 | |
| *** smcginnis has quit IRC | 20:12 | |
| *** moguimar has quit IRC | 20:21 | |
| *** moguimar has joined #openstack-oslo | 20:50 | |
| *** kgiusti has left #openstack-oslo | 20:55 | |
| *** raildo has quit IRC | 21:31 | |
| *** tosky has quit IRC | 22:07 | |
| *** rcernin has joined #openstack-oslo | 22:49 | |
| *** rcernin has quit IRC | 23:06 | |
| *** rcernin has joined #openstack-oslo | 23:08 | |
| *** cognifloyd has quit IRC | 23:35 | |
| *** csatari has quit IRC | 23:55 | |
| *** knikolla has quit IRC | 23:56 | |
| *** knikolla has joined #openstack-oslo | 23:58 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!