*** tosky has quit IRC | 00:06 | |
*** hamalq has quit IRC | 00:18 | |
*** zzzeek has quit IRC | 00:42 | |
*** zzzeek has joined #openstack-oslo | 00:45 | |
*** brinzhang_ has joined #openstack-oslo | 01:31 | |
*** brinzhang has quit IRC | 01:33 | |
openstackgerrit | Merged openstack/os-api-ref master: Bump py37 to py38 in tox.ini https://review.opendev.org/760161 | 01:39 |
---|---|---|
*** johnsom has quit IRC | 02:00 | |
*** rpittau|afk has quit IRC | 02:00 | |
*** TheJulia has quit IRC | 02:00 | |
*** rpittau|afk has joined #openstack-oslo | 02:00 | |
*** TheJulia has joined #openstack-oslo | 02:00 | |
*** johnsom has joined #openstack-oslo | 02:01 | |
*** vdrok has quit IRC | 02:02 | |
*** vdrok has joined #openstack-oslo | 02:03 | |
openstackgerrit | Merged openstack/oslo.policy master: Fix hacking min version to 3.0.1 https://review.opendev.org/752504 | 02:32 |
*** dave-mccowan has quit IRC | 04:12 | |
*** ralonsoh has joined #openstack-oslo | 06:47 | |
*** sboyron has joined #openstack-oslo | 07:18 | |
*** rcernin has quit IRC | 07:31 | |
*** lbragstad has quit IRC | 08:04 | |
*** lbragstad has joined #openstack-oslo | 08:04 | |
*** hberaud has joined #openstack-oslo | 08:07 | |
*** hberaud has quit IRC | 08:18 | |
*** hberaud has joined #openstack-oslo | 08:19 | |
*** rpittau|afk is now known as rpittau | 08:40 | |
*** tosky has joined #openstack-oslo | 08:51 | |
*** dtantsur|afk is now known as dtantsur | 08:58 | |
*** rcernin has joined #openstack-oslo | 09:18 | |
*** hberaud has quit IRC | 09:30 | |
*** hberaud has joined #openstack-oslo | 09:32 | |
*** dtantsur is now known as dtantsur|brb | 09:44 | |
*** sum12 has quit IRC | 09:50 | |
*** rcernin has quit IRC | 10:07 | |
*** dhellmann has quit IRC | 10:23 | |
*** zzzeek has quit IRC | 10:28 | |
*** zzzeek has joined #openstack-oslo | 10:29 | |
openstackgerrit | Stephen Finucane proposed openstack/oslo.messaging stable/train: add min of 1 to rpc_conn_pool_size https://review.opendev.org/759410 | 10:42 |
openstackgerrit | Merged openstack/os-api-ref master: bump py37 to py38 in tox.ini https://review.opendev.org/757429 | 10:43 |
openstackgerrit | Merged openstack/os-api-ref master: Remove install unnecessary packages https://review.opendev.org/753512 | 10:45 |
*** rcernin has joined #openstack-oslo | 11:15 | |
*** dhellmann has joined #openstack-oslo | 11:18 | |
*** hberaud has quit IRC | 11:27 | |
*** dave-mccowan has joined #openstack-oslo | 11:44 | |
*** dave-mccowan has quit IRC | 11:48 | |
*** hberaud has joined #openstack-oslo | 11:56 | |
openstackgerrit | likui proposed openstack/oslo.limit master: Update requirements URLs in tox config https://review.opendev.org/760345 | 11:56 |
*** dtantsur|brb is now known as dtantsur | 11:57 | |
openstackgerrit | likui proposed openstack/oslo.limit master: Update URLs in tox docs https://review.opendev.org/760345 | 12:04 |
openstackgerrit | Merged openstack/oslo.concurrency stable/ussuri: Monkey patch original current_thread _active in processutils https://review.opendev.org/757029 | 12:11 |
*** raildo has joined #openstack-oslo | 12:27 | |
*** ianychoi__ is now known as ianychoi | 12:34 | |
*** Luzi has joined #openstack-oslo | 12:53 | |
*** rcernin has quit IRC | 13:43 | |
*** hamalq has joined #openstack-oslo | 14:41 | |
*** tkajinam has quit IRC | 15:05 | |
*** takamatsu has quit IRC | 15:07 | |
*** takamatsu has joined #openstack-oslo | 15:09 | |
openstackgerrit | Stephen Finucane proposed openstack/oslo.config master: types: Cleanup implementation of 'HostDomain' type https://review.opendev.org/760387 | 15:23 |
stephenfin | hberaud: Can you take a look at that? ^ | 15:23 |
stephenfin | Maybe bnemec too? ^ | 15:24 |
stephenfin | Assuming I have that understood correctly, I'd like to backport that too. The implementation we have right now doesn't look correct (I don't think we want to allow IP addresses?) | 15:24 |
bnemec | stephenfin: It doesn't allow ips, does it? The unit tests involving ips are all assertInvalids. | 15:28 |
stephenfin | bnemec: They're invalid IPs | 15:28 |
bnemec | Not all of them: self.assertInvalid("10.0.0.0") | 15:29 |
hberaud | yep we expect ip too | 15:29 |
hberaud | IIUC IPs will be be skipped, isn't? | 15:29 |
hberaud | (by using this version of HostDomain) | 15:30 |
stephenfin | bnemec: Sorry, crossed wires. I thought you were asking if the old version allowed IPs, and it does (valid ones) | 15:31 |
stephenfin | and hberaud is saying that's intentional? | 15:31 |
bnemec | Ah, that doesn't seem right. The only change in behavior was supposed to be support for _. | 15:33 |
stephenfin | Well, it depends on whether we're providing a new variant of the 'Hostname' type (hostnames only) or the 'HostAddress' type (hostnames or IP addresses) | 15:34 |
stephenfin | I'd thought the request was for the former. If it's the latter, what's there is still a bit messy but is correct at least | 15:34 |
hberaud | I think we want HostAddress with an extended hostname | 15:35 |
hberaud | as user can pass IPs and extended hosts | 15:35 |
stephenfin | hberaud: what was the use case for this again? Something specific, I assume? | 15:35 |
hberaud | sec | 15:36 |
smcginnis | I thought the main thing was being able to have "_" in the hostname. | 15:36 |
smcginnis | Which I still am not clear why we need a whole new class for that. | 15:36 |
stephenfin | smcginnis: Yeah, so did I | 15:36 |
stephenfin | smcginnis: https://tools.ietf.org/html/rfc1912 | 15:37 |
stephenfin | "The presence | 15:37 |
stephenfin | of underscores in a label is allowed in [RFC 1033], except [RFC 1033] | 15:37 |
stephenfin | is informational only and was not defining a standard. There is at | 15:37 |
stephenfin | least one popular TCP/IP implementation which currently refuses to | 15:37 |
stephenfin | talk to hosts named with underscores in them." | 15:37 |
stephenfin | It seems our 'Hostname' implementation is tied to the RFC 1033 definition | 15:37 |
stephenfin | the linux manpage for hostname(7) also suggests this implementation is correct https://man7.org/linux/man-pages/man7/hostname.7.html | 15:38 |
hberaud | stephenfin: that was the original bug => https://bugzilla.redhat.com/show_bug.cgi?id=1868940 | 15:38 |
openstack | bugzilla.redhat.com bug 1868940 in python-oslo-config "oslo_config not accepting undercore in the hostnames" [Medium,On_dev] - Assigned to mbollo | 15:38 |
stephenfin | So I do agree with bnemec that it should be a separate type, because there are clearly some things that say valid hostnames should _not_ include underscores | 15:39 |
hberaud | +1 | 15:39 |
moguimar | damani, did we get the oslo.utils release? | 16:02 |
hberaud | moguimar: yes https://review.opendev.org/#/c/760091/ | 16:05 |
hberaud | thanks damani | 16:05 |
moguimar | cool, thanks guys o/ | 16:05 |
hberaud | u r welcome :) | 16:05 |
openstackgerrit | Ade Lee proposed openstack/oslo.versionedobjects master: Replace md5 with oslo version https://review.opendev.org/756153 | 16:21 |
*** sboyron has quit IRC | 16:40 | |
*** Luzi has quit IRC | 16:46 | |
damani | moguimar, sorry yes | 16:53 |
*** rpittau is now known as rpittau|afk | 16:57 | |
*** hamalq has quit IRC | 17:13 | |
*** hamalq has joined #openstack-oslo | 17:14 | |
*** ralonsoh has quit IRC | 17:15 | |
openstackgerrit | Ade Lee proposed openstack/oslo.versionedobjects master: Replace md5 with oslo version https://review.opendev.org/756153 | 17:31 |
openstackgerrit | Ron Stone proposed openstack/openstackdocstheme master: Added styling for rST rubric directive. https://review.opendev.org/760425 | 17:35 |
*** dtantsur is now known as dtantsur|afk | 18:18 | |
*** tosky has quit IRC | 18:29 | |
*** hberaud has quit IRC | 19:00 | |
*** ccamel has quit IRC | 19:35 | |
openstackgerrit | Ade Lee proposed openstack/tooz master: Replace md5 with oslo version https://review.opendev.org/756432 | 19:45 |
*** hberaud has joined #openstack-oslo | 19:54 | |
*** zzzeek has quit IRC | 20:32 | |
*** zzzeek has joined #openstack-oslo | 20:33 | |
*** kgiusti has quit IRC | 20:46 | |
*** kgiusti has joined #openstack-oslo | 20:47 | |
*** camelCaser has joined #openstack-oslo | 21:13 | |
*** kgiusti has left #openstack-oslo | 21:38 | |
*** tosky has joined #openstack-oslo | 21:57 | |
*** hberaud has quit IRC | 22:47 | |
*** hamalq has quit IRC | 22:57 | |
*** rcernin has joined #openstack-oslo | 22:58 | |
*** rcernin has quit IRC | 23:00 | |
*** rcernin has joined #openstack-oslo | 23:00 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!