| opendevreview | melanie witt proposed openstack/oslo.limit master: WIP: Allow project_id=None for enforce/calculate https://review.opendev.org/c/openstack/oslo.limit/+/806635 | 00:44 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/oslo.limit master: Add interfaces for getting limits without enforcing https://review.opendev.org/c/openstack/oslo.limit/+/812096 | 00:44 |
| *** tkajinam is now known as tkajinam|lunch | 03:55 | |
| *** tkajinam|lunch is now known as tkajinam | 03:56 | |
| hberaud | fungi: thank you. | 07:51 |
| opendevreview | Hervé Beraud proposed openstack/oslo.cache master: Expose pymemcache's HashClient public params https://review.opendev.org/c/openstack/oslo.cache/+/824944 | 07:54 |
| opendevreview | Merged openstack/pbr master: Don't test with setuptools local distutils https://review.opendev.org/c/openstack/pbr/+/825665 | 08:32 |
| *** johnsom_ is now known as johnsom | 09:03 | |
| damani | fungi, thanks a lot you rock | 09:30 |
| *** melwitt is now known as Guest1312 | 09:32 | |
| opendevreview | Daniel Bengtsson proposed openstack/pbr master: remove explicit mock https://review.opendev.org/c/openstack/pbr/+/767972 | 09:39 |
| opendevreview | Daniel Bengtsson proposed openstack/pbr master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/pbr/+/791127 | 09:49 |
| opendevreview | Daniel Bengtsson proposed openstack/pbr master: Use importlib-metadata for runtime package version lookups https://review.opendev.org/c/openstack/pbr/+/662035 | 09:51 |
| damani | hberaud, i have rebase patches in pbr | 09:53 |
| hberaud | excellent, I'll wait for the CI | 09:54 |
| hberaud | thanks | 09:54 |
| damani | hberaud, you can close now https://review.opendev.org/c/openstack/pbr/+/825537 | 09:54 |
| hberaud | done | 09:55 |
| damani | hberaud, i think we can close https://review.opendev.org/c/openstack/pbr/+/787170 ? | 09:56 |
| damani | what do you think ? | 09:56 |
| hberaud | yes | 09:57 |
| damani | hberaud, cool, thanks a lot :) | 09:57 |
| hberaud | feel free to close iy | 09:57 |
| hberaud | it | 09:57 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.context master: Don't test with setuptools local distutils. https://review.opendev.org/c/openstack/oslo.context/+/825750 | 10:04 |
| hberaud | stephenfin, bnemec: Please can review this patch and its parents patches https://review.opendev.org/c/openstack/oslo.cache/+/824944 . These changes are needed to fix an with TLS downstream on OSP16 and OSP17 at least. Thanks by advance | 10:31 |
| hberaud | s/please can review/please can you review/ | 10:31 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.utils stable/victoria: Fix regex used to mask password https://review.opendev.org/c/openstack/oslo.utils/+/824912 | 10:33 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.utils stable/victoria: Dropping lower constraints testing https://review.opendev.org/c/openstack/oslo.utils/+/825316 | 10:33 |
| *** melwitt is now known as Guest1320 | 10:50 | |
| damani | hberaud, stephenfin, can you please review this patch https://review.opendev.org/c/openstack/oslo.context/+/825750 ? | 12:19 |
| damani | hberaud, https://review.opendev.org/c/openstack/oslo.utils/+/825316 | 12:19 |
| damani | hberaud, https://review.opendev.org/c/openstack/pbr/+/767972 | 12:20 |
| hberaud | damani: did you identified the same bug than pbr on oslo.context? | 12:49 |
| damani | hberaud, yes | 12:52 |
| hberaud | ok | 12:53 |
| damani | hberaud, actually i will try to check all the oslo projects to see if you have the same issue | 13:03 |
| hberaud | nice | 13:03 |
| hberaud | thanks | 13:03 |
| fungi | please be aware that there's no need to rebase patches unless they're actually in merge conflict. zuul always tests with the latest branch state | 13:08 |
| fungi | a recheck comment would have been sufficient to get fresh test results | 13:09 |
| damani | fungi, ok yes you're right | 13:27 |
| damani | sorry | 13:27 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.context master: Don't test with setuptools local distutils. https://review.opendev.org/c/openstack/oslo.context/+/825750 | 13:50 |
| fungi | anybody know why https://review.opendev.org/c/openstack/pbr/+/782138 set a different version of hacking in .pre-commit-config.yaml than is set in test-requirements.txt? they're a completely disjunct set, which seems like it will eventually end in breakage | 15:12 |
| fungi | or, rather, people pushing things which work with pre-commit but not the linting job | 15:12 |
| fungi | test-requirements.txt says not to allow hacking 4.x, while .pre-commit-config.yaml requires at least 4.x | 15:14 |
| fungi | seems like they should be made (and be kept) consistent, but since i don't use pre-commit i'm not sure if this was intentional | 15:14 |
| *** Guest1320 is now known as melwitt | 19:18 | |
| melwitt | hberaud: could you look at https://review.opendev.org/c/openstack/oslo.limit/+/806604 again when you have a chance? it was previously approved but needed a manual rebase | 19:22 |
| melwitt | dansmith: I rebased https://review.opendev.org/c/openstack/oslo.limit/+/806635 to reestablish the relation chain for my depends-on and I was also wondering, is it still WIP from your perspective or are you happy with it? | 19:25 |
| dansmith | melwitt: oh I dunno.. has a test, maybe it's okay? | 19:25 |
| melwitt | dansmith: yeah I was thinking it looked ok, wasn't sure if there was something more you wanted to add before removing the WIP from the commit message | 19:26 |
| dansmith | it's been too long to know | 19:27 |
| melwitt | I'm ready to start harassing people for reviews on those since you didn't hate the patch that previously used oslo.limit internals :) | 19:27 |
| dansmith | so if you've got it local and you want to de-WIP it that seems fine | 19:27 |
| melwitt | k, cool. thanks | 19:28 |
| opendevreview | melanie witt proposed openstack/oslo.limit master: Allow project_id=None for enforce/calculate https://review.opendev.org/c/openstack/oslo.limit/+/806635 | 19:35 |
| opendevreview | melanie witt proposed openstack/oslo.limit master: Add interfaces for getting limits without enforcing https://review.opendev.org/c/openstack/oslo.limit/+/812096 | 19:35 |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org is being restarted briefly to apply a bugfix | 23:03 | |
| opendevreview | Merged openstack/pbr master: remove explicit mock https://review.opendev.org/c/openstack/pbr/+/767972 | 23:11 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!