damani | hi | 08:04 |
---|---|---|
damani | hberaud, can you look please https://review.opendev.org/c/openstack/oslo.utils/+/826077 ? | 08:04 |
damani | hberaud, https://review.opendev.org/c/openstack/oslo.utils/+/824912 | 08:05 |
damani | stephenfin, can you review this patch please https://review.opendev.org/c/openstack/oslo.context/+/825750 ? | 08:06 |
opendevreview | Merged openstack/oslo.context master: Don't test with setuptools local distutils. https://review.opendev.org/c/openstack/oslo.context/+/825750 | 11:40 |
opendevreview | Daniel Bengtsson proposed openstack/oslo.context master: Integrate mypy https://review.opendev.org/c/openstack/oslo.context/+/742487 | 12:18 |
hberaud | bnemec: o/ sorry to harass you with these patches but please can you validate https://review.opendev.org/c/openstack/oslo.cache/+/824944 https://review.opendev.org/c/openstack/oslo.cache/+/803747 and https://review.opendev.org/c/openstack/oslo.cache/+/803716 thanks in advance | 13:07 |
*** mrunge_ is now known as mrunge | 13:11 | |
damani | stephenfin, are you around here ? | 13:21 |
iurygregory | Hey oslo experts :D, oslo.messaging can have multiple drivers enabled? The reason I'm asking is because the ironic-prometheus-exporter has it own driver so we can collect the sensor data from Ironic, today a person asked if it's possible to have the the kafka driver in oslo_messaging_notifications for the normal notifications he gets in their env plus the ipe driver to get the sensor data https://docs.openstack.or | 13:39 |
iurygregory | g/ironic-prometheus-exporter/latest/configuration.html | 13:39 |
hberaud | iurygregory: I'd argue that yes, it is possible https://docs.openstack.org/oslo.messaging/latest/configuration/opts.html#oslo-messaging-notifications | 13:43 |
hberaud | "The Drivers(s) to handle sending notifications. Possible values are messaging, messagingv2, routing, log, test, noop" | 13:44 |
iurygregory | hberaud, yeah, but for example the transport_url can have multiple values (I think each driver will need it owns transport_url, right?) | 13:46 |
iurygregory | ironic sends the sensor data via rpc from what I remember, so we just have "fake://" in the transport_url when using the ironic-prometheus-exporter | 13:48 |
hberaud | iurygregory: yes I think each driver need its own transport url | 13:48 |
hberaud | iurygregory: does these drivers configs will be stored in the same config file? | 13:49 |
iurygregory | humm good question, the ironic-prometheus-exporter is stored in the ironic.conf | 13:50 |
iurygregory | let me ask the person to join the channel here | 13:50 |
parasitid | hi | 13:51 |
hberaud | iurygregory: my main concern is that I don't think is it possible to store multiple similar config sections/keys in the same file, else they will be overrided | 13:51 |
hberaud | parasitid: o/ | 13:51 |
parasitid | hi hberaud. so to achieve what i'm trying to do, it would mean a dedicated entry(transport_url)/section for monitoring? | 13:52 |
iurygregory | the kafka config you have is already in the oslo_messaging_notifications in ironic.conf right? | 13:53 |
parasitid | yes | 13:53 |
hberaud | parasitid: taking into account the configuration doc I'd argue that yes, it would require a dedicated entry for monitoring | 13:55 |
hberaud | https://docs.openstack.org/oslo.messaging/latest/configuration/opts.html#oslo-messaging-notifications | 13:55 |
opendevreview | Daniel Bengtsson proposed openstack/oslo.context master: Integrate mypy https://review.opendev.org/c/openstack/oslo.context/+/742487 | 13:55 |
parasitid | some should spawn a brand new oslo project: oslo.monitoring, so we could have harmonized prom exporter configs :) | 13:56 |
hberaud | parasitid: maybe an already existing place to host those monitoring => https://opendev.org/openstack/oslo.metrics | 13:58 |
iurygregory | parasitid, from what i remember when I created the driver for the ironic-prometheus-exporter we don't really care about the transport_url, but I never tested with a value that is used by another driver | 14:01 |
iurygregory | if the ipe driver is enable in the ironic.conf + the location config I think it would work... | 14:02 |
parasitid | hberaud: oh i didn't know this one :) | 14:02 |
parasitid | iurygregory: ok, so there's a chance that i could mix up both transport_url=kafka:// and location=/prom and that would work ? | 14:03 |
iurygregory | parasitid, I think so | 14:06 |
iurygregory | the location config is only used by the ipe | 14:06 |
iurygregory | and from what i remember we don't really care about the transport_url | 14:07 |
opendevreview | Merged openstack/oslo.utils stable/ussuri: Dropping lower constraints testing https://review.opendev.org/c/openstack/oslo.utils/+/826077 | 14:22 |
opendevreview | Gregory Thiemonge proposed openstack/taskflow master: WIP Fixing unit tests https://review.opendev.org/c/openstack/taskflow/+/825539 | 15:13 |
opendevreview | Gregory Thiemonge proposed openstack/taskflow master: WIP Fixing unit tests https://review.opendev.org/c/openstack/taskflow/+/825539 | 16:19 |
opendevreview | Gregory Thiemonge proposed openstack/taskflow master: WIP Fixing unit tests https://review.opendev.org/c/openstack/taskflow/+/825539 | 16:55 |
opendevreview | Gregory Thiemonge proposed openstack/taskflow master: Fix unit tests https://review.opendev.org/c/openstack/taskflow/+/825539 | 17:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!