| opendevreview | zhufl proposed openstack/os-api-ref master: Just test, please ignore it https://review.opendev.org/c/openstack/os-api-ref/+/841666 | 02:14 |
|---|---|---|
| opendevreview | zhufl proposed openstack/os-api-ref master: Just test, please ignore it https://review.opendev.org/c/openstack/os-api-ref/+/841667 | 02:16 |
| opendevreview | zhufl proposed openstack/os-api-ref master: Just test, please ignore it https://review.opendev.org/c/openstack/os-api-ref/+/841666 | 02:19 |
| opendevreview | zhufl proposed openstack/os-api-ref master: Just test, please ignore it -2 https://review.opendev.org/c/openstack/os-api-ref/+/841666 | 02:22 |
| opendevreview | zhufl proposed openstack/os-api-ref master: Just test, please ignore it -1 https://review.opendev.org/c/openstack/os-api-ref/+/841666 | 02:22 |
| opendevreview | zhufl proposed openstack/os-api-ref master: Just test, please ignore. -1 https://review.opendev.org/c/openstack/os-api-ref/+/841670 | 02:36 |
| opendevreview | zhufl proposed openstack/os-api-ref master: Just test, please ignore -2 https://review.opendev.org/c/openstack/os-api-ref/+/841671 | 02:38 |
| opendevreview | zhufl proposed openstack/os-api-ref master: Just test, please ignore. -1 https://review.opendev.org/c/openstack/os-api-ref/+/841670 | 02:40 |
| opendevreview | zhufl proposed openstack/os-api-ref master: Just test, please ignore. -1 https://review.opendev.org/c/openstack/os-api-ref/+/841670 | 02:54 |
| hberaud | stephenfin: o/ Do you mind to revisit https://review.opendev.org/c/openstack/oslo.log/+/841383 thanks by advance | 08:33 |
| opendevreview | Merged openstack/oslo.log master: [Fix] init global_request_id if not in context https://review.opendev.org/c/openstack/oslo.log/+/841383 | 11:03 |
| sean-k-mooney | hberaud: stephenfin this might be a dumb question but the normaly funcationl test in oslo.messaging https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/tests/functional/notify/test_logger.py | 11:51 |
| sean-k-mooney | are those just run as part of the default tox env | 11:52 |
| sean-k-mooney | https://github.com/openstack/oslo.messaging/blob/master/tox.ini#L6= | 11:52 |
| sean-k-mooney | and https://github.com/openstack/oslo.messaging/blob/master/tox.ini#L45-L83= are for the other dirvers | 11:52 |
| sean-k-mooney | which are more integrtation tests kind of since they need rabbit or kafka ectra | 11:52 |
| sean-k-mooney | so to run the logger tests for exampel i shoudl just do tox -e py3 | 11:53 |
| sean-k-mooney | i was doing tox -e functional and it obviouls did not work so just wanted to check before i start creating some for the unix socket plugin | 11:54 |
| sean-k-mooney | im going to try and write some basic functional tests first then implemetne the driver using them | 11:54 |
| sean-k-mooney | so i was wondering if i need to add a new senarior or is it ok to just put it beside the logger tets | 11:55 |
| sean-k-mooney | oh interesting... | 11:58 |
| sean-k-mooney | fyi the oslo.messigint tests are not happy with python 3.9 | 11:59 |
| sean-k-mooney | AttributeError: 'ServerThreadHelper' object has no attribute 'isAlive' | 11:59 |
| sean-k-mooney | hum the test also seam to be assuming some config files exist | 12:04 |
| sean-k-mooney | that looks like a bug | 12:04 |
| sean-k-mooney | oslo_messaging.tests.functional.notify.test_logger.LoggingNotificationHandlerTestCase.test_logging(debug,messagingv2) ... SKIPPED: No transport url configured | 12:05 |
| hberaud | sean-k-mooney: I think is it ok to put the logger tests beside for now | 12:16 |
| sean-k-mooney | os i need to define NOTIFY_TRANSPORT_URL | 12:17 |
| sean-k-mooney | in my env to make this work | 12:17 |
| * sean-k-mooney finds the test structre a little confusing | 12:17 | |
| sean-k-mooney | hberaud: ack. i dont think the tests/functional/notify/test_logger.py test are actully testing oslo_messaging/notify/_impl_log.py | 12:20 |
| sean-k-mooney | they are testing `oslo_messaging.LoggingNotificationHandler | 12:20 |
| sean-k-mooney | so https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/log_handler.py | 12:21 |
| sean-k-mooney | so there are no functional test for the python logging notification driver | 12:21 |
| sean-k-mooney | that why i was getting confused | 12:22 |
| hberaud | I see | 12:34 |
| opendevreview | Douglas Mendizábal proposed openstack/pycadf master: Add doc/requirements https://review.opendev.org/c/openstack/pycadf/+/769768 | 15:35 |
| *** gibi is now known as gibi_pto | 16:39 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!