| sahid | o/ quick question | 08:11 |
|---|---|---|
| sahid | regarding osprofiler, some patche received +2s but are waiting for final approval, who can make it? | 08:11 |
| *** ralonsoh_ is now known as ralonsoh | 08:37 | |
| hberaud | sahid: You can ping stephenfin or tkajinam by example | 09:04 |
| opendevreview | Max proposed openstack/oslo.privsep master: setgid should be called before setuid https://review.opendev.org/c/openstack/oslo.privsep/+/873513 | 09:52 |
| sahid | hberaud: ack thanks | 10:00 |
| opendevreview | Max proposed openstack/oslo.privsep master: setgid should be called before setuid https://review.opendev.org/c/openstack/oslo.privsep/+/873513 | 10:26 |
| sahid | tkajinam: o/ any chance you have a look of those two patches for osprofiler? | 10:52 |
| tkajinam | sahid, I've left a few comments in these two. osprofiler was not part of my review query it seems | 11:16 |
| opendevreview | Max proposed openstack/oslo.privsep master: setgid should be called before setuid https://review.opendev.org/c/openstack/oslo.privsep/+/873550 | 11:23 |
| opendevreview | Max proposed openstack/oslo.privsep master: setgid should be called before setuid https://review.opendev.org/c/openstack/oslo.privsep/+/873513 | 11:26 |
| opendevreview | Max proposed openstack/oslo.privsep master: setgid should be called before setuid https://review.opendev.org/c/openstack/oslo.privsep/+/873513 | 11:33 |
| sahid | tkajinam: sure give me a moment I will address you comments | 11:39 |
| sahid | thank you :-) | 11:39 |
| sahid | I will try to invovle as I can on osprofiler and helping you on involving on it | 11:40 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: jaeger: introduce process tags' option for tracer https://review.opendev.org/c/openstack/osprofiler/+/873231 | 11:45 |
| tkajinam | sahid, oops sorry my comment for the first patch was not posted properly. Please reload | 11:57 |
| sahid | no worries will address them, makes sense, thank you | 12:03 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: jaeger: introduce service name prefix https://review.opendev.org/c/openstack/osprofiler/+/872152 | 12:09 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: jaeger: introduce process tags' option for tracer https://review.opendev.org/c/openstack/osprofiler/+/873231 | 12:09 |
| *** priteau_ is now known as priteau | 12:25 | |
| opendevreview | Merged openstack/osprofiler master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/openstack/osprofiler/+/789994 | 13:00 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: jaeger: introduce service name prefix https://review.opendev.org/c/openstack/osprofiler/+/872152 | 14:12 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: jaeger: introduce process tags' option for tracer https://review.opendev.org/c/openstack/osprofiler/+/873231 | 14:12 |
| opendevreview | Dmitriy Rabotyagov proposed openstack/oslo.messaging master: Fix typo in quorum-related variables for RabbitMQ https://review.opendev.org/c/openstack/oslo.messaging/+/873630 | 17:24 |
| *** jgwentworth is now known as melwitt | 18:33 | |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: jaeger: introduce service name prefix https://review.opendev.org/c/openstack/osprofiler/+/872152 | 20:01 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: jaeger: introduce process tags' option for tracer https://review.opendev.org/c/openstack/osprofiler/+/873231 | 20:01 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: jaeger: fix driver initialization for tests https://review.opendev.org/c/openstack/osprofiler/+/873643 | 20:01 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!