| sahid | o/ | 07:33 |
|---|---|---|
| sahid | morning hberaud, any chance that you have a second look on https://review.opendev.org/c/openstack/osprofiler/+/877969 :) | 07:34 |
| hberaud | sahid: thx! done | 07:43 |
| sahid | ah cool thank you hberaud | 07:47 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: add support of jaeger+otlp for jaeger tracing https://review.opendev.org/c/openstack/osprofiler/+/877358 | 07:52 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: devstack: remove jaeger container on unstack https://review.opendev.org/c/openstack/osprofiler/+/877969 | 10:57 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: add support of jaeger+otlp for jaeger tracing https://review.opendev.org/c/openstack/osprofiler/+/877358 | 10:57 |
| tkajinam | stephenfin, hi. thanks for the alembic patches for heat! I replied to your comment but I think yours is better and I'll try to merge yours instead of my naive ones. | 11:38 |
| tkajinam | I spent some time looking into db migration/alembic today so hopefully that helps me understand what you've done. | 11:38 |
| stephenfin | tkajinam: No problem, and sorry about the confusion/overlap. I should have said I was taking a look /o\ | 11:38 |
| stephenfin | Feel free to give me a shout if anything is unclear. It's mostly duplicated from other projects that have been using it for some time now so it's reasonably well "battle tested" | 11:39 |
| tkajinam | no, no problem at all. tbh I was not quite familiar with these migrations but now I (hope I) have a much clear view. | 11:41 |
| tobias-urdin | if any of you have some time over, I would really appreciate an estimate on how much work to fix sqlalchemy 2 for gnocchi | 11:58 |
| tobias-urdin | I don't have much insight into that layer or what will need to be done to support sqlalchemy 2, would probably save me countless of hours :) | 11:58 |
| stephenfin | tobias-urdin: Looks like it's already using alembic so you're good there. To prep for 2.0, you'll want to enable SQLAlchemy 2.0 warnings, initially filtering them out and then addressing them one by one | 12:02 |
| stephenfin | tobias-urdin: If you look at https://review.opendev.org/q/project:openstack/nova+topic:sqlalchemy-20 you'll see an example of this being done. It all kicks off with https://review.opendev.org/c/openstack/nova/+/804708 | 12:03 |
| tobias-urdin | yeah should be good on the migration part, just don't have enough good insight into determining how much work for sqlalchemy 2.0, good idea I'll see if I can enable that sooner rather than later | 12:03 |
| stephenfin | I think enabling those warnings would give you a good idea. Hopefully there aren't too many "unusual" things and you can copy that patterns seen in that sqlalchemy-2.0 series for nova and equivalent series for cinder, keystone etc. | 12:04 |
| stephenfin | cinder: https://review.opendev.org/q/project:openstack/cinder+topic:sqlalchemy-20 | 12:04 |
| tobias-urdin | but all functionality should be in 1.4 right that we already support so just updating lower constraint to 1.4 after 2.0 support is fixed? | 12:05 |
| stephenfin | keystone: https://review.opendev.org/q/project:openstack/keystone+topic:sqlalchemy-20 | 12:05 |
| stephenfin | In theory, yes | 12:05 |
| tobias-urdin | cool, yeah I can probably figure it out based on all those patches then, that's a relief | 12:05 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: devstack: remove jaeger container on unstack https://review.opendev.org/c/openstack/osprofiler/+/877969 | 12:06 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/osprofiler master: add support of jaeger+otlp for jaeger tracing https://review.opendev.org/c/openstack/osprofiler/+/877358 | 12:06 |
| stephenfin | We spotted a few things in oslo.db that still needed to be fixed manually, but they weren't too complicated https://review.opendev.org/c/openstack/oslo.db/+/875986/9 | 12:06 |
| stephenfin | and oslo.db is obviously quite a heavy user of SQLAlchemy APIs... | 12:06 |
| *** JasonF is now known as JayF | 13:56 | |
| sahid | hberaud: sorry annoying you again, i had to fix a formating issue. Can I ask you to have a new look on https://review.opendev.org/c/openstack/osprofiler/+/877969/4 I guess it is ready to go now :-) | 16:00 |
| opendevreview | Hervé Beraud proposed openstack/oslo.utils master: Implement zoneinfo support to drop dependency to pytz https://review.opendev.org/c/openstack/oslo.utils/+/872862 | 16:13 |
| opendevreview | Hervé Beraud proposed openstack/oslo.utils master: Use the new openstack-python3-jobs template https://review.opendev.org/c/openstack/oslo.utils/+/878470 | 16:13 |
| hberaud | stephenfin, tkajinam: o/ Please can you have a look to these 2 patches ^, thanks in advance | 16:14 |
| hberaud | sahid: sure | 16:15 |
| opendevreview | Hervé Beraud proposed openstack/oslo.serialization master: Implement zoneinfo support to drop dependency to pytz https://review.opendev.org/c/openstack/oslo.serialization/+/872915 | 16:18 |
| opendevreview | Hervé Beraud proposed openstack/oslo.serialization master: Use the new openstack-python3-jobs template https://review.opendev.org/c/openstack/oslo.serialization/+/878471 | 16:18 |
| hberaud | stephenfin, tkajinam: and to looks to these 2 others patches too ^ thanks | 16:18 |
| opendevreview | Brian Haley proposed openstack/oslo.utils master: Add netutils.get_my_ipv6() https://review.opendev.org/c/openstack/oslo.utils/+/878078 | 16:49 |
| opendevreview | Merged openstack/osprofiler master: devstack: remove jaeger container on unstack https://review.opendev.org/c/openstack/osprofiler/+/877969 | 17:44 |
| *** seebaer is now known as seba | 23:19 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!