| tkajinam | hberaud, since now python 3.8 was added back to tested runtime and I'm wondering how we should treat https://review.opendev.org/c/openstack/oslo.utils/+/872862 which likely breaks compatibility with py3.8 | 05:53 |
|---|---|---|
| tkajinam | I was trying https://review.opendev.org/c/openstack/oslo.utils/+/882800?tab=change-view-tab-header-zuul-results-summary but seems this is not allowed by requirement check. it'd be nice if you have any ideas | 05:54 |
| tkajinam | one different option we have is to build pytz in RDO. that might be helpful for the other few components still dependent on pytz | 05:57 |
| hberaud | tkajinam: one option could be to support pytz and zoneinfo at the same time in the code and to load one or the other if the import fails | 07:38 |
| tkajinam | hberaud, that's what I'm trying but I'm not too sure how I can add pytz to requirements.txt | 07:48 |
| tkajinam | so that we require it only in python 3.8 | 07:48 |
| tkajinam | the above patch attempts that but seems requirement check does not allow the current definition. also seems somehow pytz is still installed for some reason which I've not yet looked into | 07:49 |
| tkajinam | (probably something in dependencies are pulling it | 07:49 |
| hberaud | tkajinam: ah indeed, that's what I was thinking as solution... | 08:00 |
| hberaud | tkajinam: I think we have to add the python_version==3.8 here => https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L596 | 08:08 |
| hberaud | I think this is why we have this issue | 08:08 |
| hberaud | however, if we add this extra tag in openstack/requirements that risk to broke other deliverables that also rely on pytz | 08:10 |
| hberaud | they surely will start to fail as your current patch without this new tag (python_version) | 08:11 |
| hberaud | tkajinam: and apparently many projects still relies on pytz => https://github.com/search?q=org%3Aopenstack%20pytz%20path%3Arequirements.txt&type=code | 08:15 |
| hberaud | (I think we can ignore charm* and test-requirements.txt) | 08:16 |
| hberaud | else... lets remove the 'python_version' from your patch and lets follow your previous proposal about RDO | 08:20 |
| tkajinam | yeah | 08:22 |
| hberaud | py3.8 is EOL in ~ 1 year so other we only have to maintain this double code during a couple of months | 08:22 |
| hberaud | s/so other// | 08:23 |
| hberaud | the same is required in oslo.serialization | 08:24 |
| tkajinam | thanks for these inputs. So for short term I'll remove python_version and make pytz regardless of the python version. Once we establish the solution to require pytz only in 38 or remove py38 then we can get rid of pytz | 08:29 |
| hberaud | ok wfm | 08:29 |
| hberaud | I'll do the same for oslo.serialization | 08:30 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.utils master: Fix compatibility with Python 3.8 https://review.opendev.org/c/openstack/oslo.utils/+/882800 | 08:31 |
| tkajinam | updated the patch ^^^ | 08:35 |
| hberaud | thanls | 08:46 |
| hberaud | thanks | 08:46 |
| opendevreview | Hervé Beraud proposed openstack/oslo.serialization master: Fix compatibility with Python 3.8 https://review.opendev.org/c/openstack/oslo.serialization/+/883145 | 09:02 |
| hberaud | tkajinam: oslo.serialization ^ | 09:02 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!