opendevreview | Merged openstack/taskflow stable/2023.1: Fix parsing of zookeeper jobboard backend options https://review.opendev.org/c/openstack/taskflow/+/880605 | 05:24 |
---|---|---|
opendevreview | Merged openstack/oslo.messaging stable/zed: Add is_admin to safe fields list for notifications https://review.opendev.org/c/openstack/oslo.messaging/+/896424 | 05:31 |
opendevreview | Merged openstack/oslo.messaging stable/yoga: Add is_admin to safe fields list for notifications https://review.opendev.org/c/openstack/oslo.messaging/+/896425 | 07:49 |
opendevreview | Merged openstack/oslo.messaging stable/xena: Add is_admin to safe fields list for notifications https://review.opendev.org/c/openstack/oslo.messaging/+/896426 | 09:10 |
opendevreview | Thomas Goirand proposed openstack/oslo.cache master: Clean-up memcache connection sockets https://review.opendev.org/c/openstack/oslo.cache/+/900158 | 13:11 |
tkajinam | https://releases.openstack.org/constraints/upper/master | 14:16 |
tkajinam | ugh... it seens the change messed up something | 14:16 |
frickler | tkajinam: if you are talking about https://review.opendev.org/c/openstack/requirements/+/900517, that's because publishing on pypi is slower than zuul, so jobs run before they can find the new release on pypi | 14:34 |
frickler | but this one looks real: TypeError: expected string or bytes-like object | 14:38 |
frickler | in nova and ironic, e.g. https://zuul.opendev.org/t/openstack/build/d063eda10bbc487eaad57ffa7476bec7 | 14:38 |
tkajinam | yeah that error in ironic and nova looks real and we have to fix how they mock things | 14:39 |
tkajinam | I reproduced the problem locally and the version argument is not a string but <_AutospecMagicMock name='objects.MyObj.VERSION' id='140525135731536'> | 14:39 |
tkajinam | and thanks for the explanation about the slow pypi. let's see if we find further real failures after rechecks. | 14:40 |
tkajinam | ok I found the fix... let me report a bug and submit fixes | 14:54 |
*** carthaca_ is now known as carthaca | 15:02 | |
opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Clean-up memcache connection sockets https://review.opendev.org/c/openstack/oslo.cache/+/900158 | 15:21 |
opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Clean-up memcache connection sockets https://review.opendev.org/c/openstack/oslo.cache/+/900158 | 15:22 |
opendevreview | Thomas Goirand proposed openstack/oslo.cache master: Clean-up memcache connection sockets https://review.opendev.org/c/openstack/oslo.cache/+/900158 | 15:25 |
opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Clean-up memcache connection sockets https://review.opendev.org/c/openstack/oslo.cache/+/900158 | 15:35 |
tkajinam | zigo, sorry seems our updates conflicted. See the updated version I just submitted. I think even your latest version does not work as intended ^^^ | 15:35 |
zigo | tkajinam: Please overwrite my patch ! :) | 15:35 |
zigo | I'm writing shit ... | 15:35 |
zigo | You're not writing a loop though ... | 15:36 |
tkajinam | I believe it has while True at top | 15:37 |
zigo | Thanks for picking-it up. It's a real trouble in production, that one... | 15:37 |
zigo | Oh, indeed, got it. | 15:37 |
zigo | while True: with except break, got it. | 15:37 |
tkajinam | the loop ends when queue is empty because pop raises IndexError | 15:38 |
tkajinam | zigo, do you mind reporting a bug ? I think it's very useful to have some explanation about the issue | 15:38 |
zigo | Ok. | 15:38 |
tkajinam | https://bugs.launchpad.net/oslo.cache | 15:38 |
zigo | tkajinam: https://bugs.launchpad.net/oslo.cache/+bug/2043121 | 15:46 |
opendevreview | Takashi Kajinami proposed openstack/oslo.cache master: Clean-up memcache connection sockets https://review.opendev.org/c/openstack/oslo.cache/+/900158 | 15:48 |
tkajinam | zigo, ok, thanks. added the tag to link the fix to that bug | 15:48 |
*** tosky_ is now known as tosky | 18:43 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!