opendevreview | Takashi Kajinami proposed openstack/tooz master: redis: support healthcheck interval https://review.opendev.org/c/openstack/tooz/+/908964 | 02:29 |
---|---|---|
opendevreview | Takashi Kajinami proposed openstack/tooz master: redis: Fix wrong type used to parse socket_keepalive https://review.opendev.org/c/openstack/tooz/+/908965 | 02:47 |
opendevreview | Takashi Kajinami proposed openstack/oslo.cache stable/2023.2: Ensure requirements are capped by upper constraints https://review.opendev.org/c/openstack/oslo.cache/+/908975 | 08:07 |
opendevreview | Takashi Kajinami proposed openstack/oslo.cache stable/2023.1: Ensure requirements are capped by upper constraints https://review.opendev.org/c/openstack/oslo.cache/+/908976 | 08:13 |
opendevreview | Merged openstack/castellan master: Bump hacking https://review.opendev.org/c/openstack/castellan/+/906975 | 09:59 |
damani | hi | 10:09 |
damani | tkajinam, what do you think about https://review.opendev.org/c/openstack/oslo.cache/+/907681/2/oslo_cache/backends/dictionary.py? | 10:09 |
tkajinam | o/ | 10:24 |
tkajinam | damani, I've left a comment | 10:24 |
tkajinam | I don't think that specific change improves readability. | 10:25 |
damani | no | 10:26 |
damani | actually for me it's the oposite | 10:26 |
damani | it's harder to read | 10:26 |
tkajinam | yeah | 10:35 |
tkajinam | it may be useful in a different situations (like when we check whether x is within [a, b] but does not work well for that specific logic | 10:36 |
damani | tkajinam, i agree | 11:40 |
damani | hberaud, can you take a look please https://review.opendev.org/c/openstack/taskflow/+/907666 | 11:40 |
opendevreview | Takashi Kajinami proposed openstack/oslo.utils master: wip: showing proposal https://review.opendev.org/c/openstack/oslo.utils/+/908987 | 11:45 |
opendevreview | Merged openstack/openstack-doc-tools master: Update python classifier in setup.cfg https://review.opendev.org/c/openstack/openstack-doc-tools/+/905366 | 12:00 |
hberaud | both versions (the older one and the proprosed one) are ok for me, but, IMO readability must prevail on technical barrel role. So if you guys both think that it is harder to read, then I'd argue that we must keep the current version | 12:48 |
hberaud | s/role/roll | 12:48 |
opendevreview | Merged openstack/oslo.cache master: config: Document backends supporting specific options https://review.opendev.org/c/openstack/oslo.cache/+/908770 | 13:19 |
opendevreview | Merged openstack/taskflow master: redis: Add username https://review.opendev.org/c/openstack/taskflow/+/907667 | 13:22 |
opendevreview | Merged openstack/oslo.cache master: redis: Add functional tests https://review.opendev.org/c/openstack/oslo.cache/+/907651 | 13:23 |
opendevreview | Takashi Kajinami proposed openstack/oslo.utils master: wip: showing proposal https://review.opendev.org/c/openstack/oslo.utils/+/908987 | 13:42 |
damani | hberaud, i mean that link https://review.opendev.org/c/openstack/taskflow/+/907666 | 14:15 |
hberaud | done | 14:20 |
opendevreview | Merged openstack/taskflow master: redis: Enable SSL for sentinel https://review.opendev.org/c/openstack/taskflow/+/907666 | 15:39 |
opendevreview | Merged openstack/taskflow master: Use consistent credential for Redis and Redis Sentinel https://review.opendev.org/c/openstack/taskflow/+/907673 | 15:52 |
opendevreview | Merged openstack/taskflow master: redis: Support fallback servers https://review.opendev.org/c/openstack/taskflow/+/907674 | 15:52 |
*** jph4 is now known as jph | 18:32 | |
opendevreview | melanie witt proposed openstack/castellan master: Raise ManagedObjectNotFoundError in MockKeyManager https://review.opendev.org/c/openstack/castellan/+/909051 | 20:57 |
opendevreview | melanie witt proposed openstack/castellan master: Raise ManagedObjectNotFoundError in MockKeyManager https://review.opendev.org/c/openstack/castellan/+/909051 | 20:58 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!