| *** gthiemon1e is now known as gthiemonge | 11:46 | |
| dansmith | tkajinam: so the format_inspector stuff has now spread to three projects as part of that CVE handling and the (obviously not socialized plan in the embargoed discussion) was to move that to oslo ASAP to avoid that duplication | 15:26 |
|---|---|---|
| dansmith | I'm very much hoping I can move it to oslo.utils right next to imageutils that we already have there.. is that reasonable and/or do I need to do any other socializing/spec'ing of that before I can start? | 15:27 |
| tkajinam | dansmith, I vote for skipping the doc work and submitting the patch. I think we all know the actual requirement well now because the code is already there and used. | 15:31 |
| tkajinam | maybe the only question we have to sort first is whether we want to merge the implementation into imageutils or create a separate module. I don't have strong opinion but keeping it as a separate module (like image_format_inspector) is an easier way, I guess. | 15:37 |
| dansmith | I definitely don't want to put it *into* imageutils.py if that's what you mean.. definitely should be it's own file (likely set of files longer-term) | 15:39 |
| dansmith | maybe it would make more sense to make imageutils into imageutils/ and expose the only public thing in __init__.py to keep the same interface | 15:42 |
| dansmith | and then cultivate from there? | 15:42 |
| tkajinam | yeah that also makes sense to me | 15:46 |
| dansmith | okay, I'll put up something to do that and then build on top | 15:47 |
| tkajinam | thanks ! | 15:48 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.policy master: Enable enforce_scope and enforce_new_defaults by default https://review.opendev.org/c/openstack/oslo.policy/+/924283 | 16:00 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Make imageutils a directory https://review.opendev.org/c/openstack/oslo.utils/+/924346 | 16:43 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Import format_inspector from nova https://review.opendev.org/c/openstack/oslo.utils/+/924347 | 16:43 |
| dansmith | tkajinam: so in glance, we have a tools/test_format_inspector.py which has evolved (and needs to evolve further) into a small utility I think, since we need a way to test images using this python code without uploading them to a service | 16:57 |
| dansmith | i.e. to run the safety check on existing images in the cache, etc | 16:57 |
| dansmith | I don't think it needs a real stable CLI interface, but I was going to put it in here as well so that it is runnable with `python -m oslo_utils.imageutils` .. is that okay or not something oslo(_utils) wants to be in the business of? | 16:58 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Make FileInspector an ABC https://review.opendev.org/c/openstack/oslo.utils/+/924369 | 21:32 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Modularize image safety checks https://review.opendev.org/c/openstack/oslo.utils/+/924370 | 21:32 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Reinstate VMDK safety check coverage https://review.opendev.org/c/openstack/oslo.utils/+/924371 | 21:32 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Add region-complete signaling for inspectors https://review.opendev.org/c/openstack/oslo.utils/+/924372 | 21:32 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!