| opendevreview | Merged openstack/oslo.log master: Mock time.time_ns in test_rfc5424_isotime_format_no_microseconds for py3.13 https://review.opendev.org/c/openstack/oslo.log/+/924063 | 11:32 |
|---|---|---|
| opendevreview | Merged openstack/oslo.config master: Add option for generate shell completion script https://review.opendev.org/c/openstack/oslo.config/+/906478 | 11:54 |
| dansmith | tkajinam: thanks for your reviews so far.. anything else I can do to help move this along? | 13:54 |
| dansmith | happy to try to drum up some non-oslo reviews if it would help | 13:54 |
| dansmith | I'm really hoping we can get this in this cycle and get the other projects rebased on it to avoid a release where backports would have to be made to the embedded versions | 13:55 |
| dansmith | I definitely recognize it's a very sudden/unplanned need to review a bunch of code | 13:56 |
| tkajinam | dansmith, I'm afraid I'm busy till Friday but will spend some time on these till early next week... you can probably ask dansmith or hberaud (and probably stephenfin if he has time) to review give their reviews, too | 14:00 |
| dansmith | tkajinam: damani2 ? | 14:02 |
| dansmith | I'm happy to review :D | 14:02 |
| tkajinam | yes. wrong completion, sorry | 14:02 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.utils master: Decouple reason from a check instance https://review.opendev.org/c/openstack/oslo.utils/+/925403 | 14:39 |
| dansmith | tkajinam: no need to revise, I just read it wrong because of the name,_ filtering above | 15:17 |
| dansmith | with your permission to make it a dict, I'll fold that change into the base and get the series updated | 15:18 |
| tkajinam | +1 . I wonder if we want to use an exception instance directly, instead of string-fy-ing it so that we can add more attributes later. | 15:25 |
| dansmith | yeah, that would be better if that's okay | 15:27 |
| opendevreview | Takashi Kajinami proposed openstack/oslo.utils master: Decouple reason from a check instance https://review.opendev.org/c/openstack/oslo.utils/+/925403 | 15:27 |
| dansmith | tkajinam: I assume you want me to fold your change into the parent patch (with Co-Authored-By) and not just insert it into the stack, right? | 15:30 |
| dansmith | s/fold/squash/ | 15:30 |
| tkajinam | yeah that would make the review step easier because I can +2 | 15:31 |
| dansmith | ack will do in a bit, thanks | 15:32 |
| tkajinam | thanks ! | 15:33 |
| tkajinam | I'll add my +2 to the updated version and re-add +2 to other patches in the chain once a new versions is submitted. I'll leave the last GPT/MBR inspector to tomorrow because I have to understand the spec first. | 15:37 |
| dansmith | thanks | 15:39 |
| dansmith | I'm also going to collapse safety_checks and safety_check_names into a dict if that's okay, just to avoid them getting out of sync (and because your latest has a typo that requires that stuff to be fixed anyway) | 15:39 |
| dansmith | tkajinam: I'm working on this: https://opendev.org/openstack/os-test-images | 15:41 |
| dansmith | which will give you test images to run against if you want | 15:41 |
| dansmith | I also never heard an answer about including the utility in oslo.utils, which would also make it easier to run a tool against a test image from ^ from the command-line | 15:41 |
| dansmith | is that reasonable to be in oslo.utils? | 15:41 |
| tkajinam | dansmith, that's a good idea. alternatively we can create list of names from list of checks but I it's really redundant. | 15:42 |
| tkajinam | checking it | 15:42 |
| tkajinam | dansmith, it may depends on its expected usage. If the tool is used only in functional/unit tests of oslo.utils then it can be in oslo.utils, but if you aim to use it in any functional tests in other projects (cinder, glance, nova) then probably it's better to keep it in a separate repo | 15:55 |
| dansmith | tkajinam: it would be more like useful for admins I think | 15:55 |
| dansmith | but yeah, I can put it somewhere else | 15:55 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Modularize image safety checks https://review.opendev.org/c/openstack/oslo.utils/+/924370 | 16:00 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Reinstate VMDK safety check coverage https://review.opendev.org/c/openstack/oslo.utils/+/924371 | 16:00 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Add region-complete signaling for inspectors https://review.opendev.org/c/openstack/oslo.utils/+/924372 | 16:00 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Make VMDKInspector support non-sparse formats https://review.opendev.org/c/openstack/oslo.utils/+/924512 | 16:00 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Support VMDK sparse with footer https://review.opendev.org/c/openstack/oslo.utils/+/924526 | 16:00 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Refactor some things for oslo https://review.opendev.org/c/openstack/oslo.utils/+/924766 | 16:00 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Fix qcow2 feature flag checks (for the future) https://review.opendev.org/c/openstack/oslo.utils/+/924859 | 16:00 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Add GPT/MBR inspector https://review.opendev.org/c/openstack/oslo.utils/+/924963 | 16:00 |
| tkajinam | My point is that I don't want the test data generator command (like os-test-image-generator) installed as part of oslo.utils, because of the current scope of oslo.utils which is basically the general core library used by multiple projects. | 16:00 |
| tkajinam | If the tool is used within the tests of oslo.utils then it can stay in somewhere like tests/tools but if we want to make it more generally available then a separate location sounds better to me | 16:01 |
| dansmith | no, the generation is definitely not going to be in oslo, it's just the utility (for verifying images) that is in question | 16:04 |
| dansmith | and it's not something that would be used in tests, it would be used by admins (or devs) trying to reason about an image | 16:04 |
| dansmith | since it's not safe to run qemu-img on untrusted images, there's no way for an admin to inspect an image they suspect may be bad and/or confirm what *openstack* will say about its safety, | 16:05 |
| dansmith | aside from like uploading it to glance, which would be crazy :) | 16:05 |
| dansmith | but anyway, I'll put the tool somewhere, no worries | 16:05 |
| tkajinam | ah, ok | 16:09 |
| tkajinam | dansmith, sorry I totally misunderstood the tool you were talking about. ok having a verification CLI in oslo.utils would be ok because it may be used in real use. | 16:12 |
| dansmith | oh okay | 16:12 |
| tkajinam | or probably we can implement a sub command in openstack CLI ? (though I don't know if that's acceptable for SDK people) | 16:12 |
| dansmith | I guess we could but it seems out of scope for openstackclient to me | 16:12 |
| tkajinam | ok | 16:13 |
| dansmith | anyway, I can propose it and if it's not reasonable we can add it elsewhere.. it should be plenty portable since it just uses oslo.imageutils.format_inspector regardless of where it is | 16:13 |
| tkajinam | it seems that oslo.utils is required by openstackclient so having the tool in oslo.utils might be easier for people with only clients installed | 16:13 |
| tkajinam | +1 | 16:14 |
| dansmith | ack, well, if it already uses oslo.utils then perhaps | 16:15 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Add region-complete signaling for inspectors https://review.opendev.org/c/openstack/oslo.utils/+/924372 | 17:40 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Make VMDKInspector support non-sparse formats https://review.opendev.org/c/openstack/oslo.utils/+/924512 | 17:40 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Support VMDK sparse with footer https://review.opendev.org/c/openstack/oslo.utils/+/924526 | 17:40 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Refactor some things for oslo https://review.opendev.org/c/openstack/oslo.utils/+/924766 | 17:40 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Fix qcow2 feature flag checks (for the future) https://review.opendev.org/c/openstack/oslo.utils/+/924859 | 17:40 |
| opendevreview | Dan Smith proposed openstack/oslo.utils master: Add GPT/MBR inspector https://review.opendev.org/c/openstack/oslo.utils/+/924963 | 17:40 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!