opendevreview | Xu Qi proposed openstack/tooz master: zookeeper: fix argparse related to ssl https://review.opendev.org/c/openstack/tooz/+/927370 | 01:32 |
---|---|---|
opendevreview | melanie witt proposed openstack/sphinx-feature-classification master: Use force=True when calling copy_asset() https://review.opendev.org/c/openstack/sphinx-feature-classification/+/927449 | 02:52 |
melwitt | stephenfin: ^ | 03:07 |
opendevreview | melanie witt proposed openstack/sphinx-feature-classification master: Use force=True when calling copy_asset() https://review.opendev.org/c/openstack/sphinx-feature-classification/+/927449 | 03:25 |
opendevreview | yatin proposed openstack/osprofiler master: [DNM] Check exceptions https://review.opendev.org/c/openstack/osprofiler/+/927460 | 06:18 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: pre-commit: Bump dependencies https://review.opendev.org/c/openstack/openstackdocstheme/+/927482 | 09:50 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: pre-commit: Add ruff, ruff-format https://review.opendev.org/c/openstack/openstackdocstheme/+/927483 | 09:50 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: setup: Update Python classifiers https://review.opendev.org/c/openstack/openstackdocstheme/+/927484 | 09:50 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: Make Sphinx a required dependency https://review.opendev.org/c/openstack/openstackdocstheme/+/927485 | 09:50 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: Resolve Sphinx 8.x warnings https://review.opendev.org/c/openstack/openstackdocstheme/+/927486 | 09:50 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: Bump minimum Sphinx version https://review.opendev.org/c/openstack/openstackdocstheme/+/927487 | 09:50 |
opendevreview | sean mooney proposed openstack/openstackdocstheme master: fix new sphinx 9 warning https://review.opendev.org/c/openstack/openstackdocstheme/+/927496 | 11:52 |
opendevreview | sean mooney proposed openstack/openstackdocstheme master: fix new sphinx 9 warning https://review.opendev.org/c/openstack/openstackdocstheme/+/927496 | 12:00 |
opendevreview | sean mooney proposed openstack/openstackdocstheme master: fix new sphinx 9 warning https://review.opendev.org/c/openstack/openstackdocstheme/+/927496 | 12:06 |
sean-k-mooney | so we are going to need ^ to be released to unblock the gate | 12:07 |
frickler | sean-k-mooney: as discussed in #-nova I don't think so, also stephenfin has done a more complete stack of patches already, but those need the fix in nova first | 12:32 |
sean-k-mooney | i think sphinx-build is not treating RemovedInSphinx90Warning warnins as warnings when we pass -W | 12:37 |
sean-k-mooney | i dont actuly mind what the final fix is on the docs theme side once the gate is fixed and deprecation warning are corrected | 12:42 |
opendevreview | Hervé Beraud proposed openstack/oslo-specs master: oslo.service: Propose a plan to Remove Eventlet https://review.opendev.org/c/openstack/oslo-specs/+/927503 | 13:03 |
stephenfin | hberaud: frickler: Care to review that openstackdocstheme stack? I can push them through myself but would be good to have a once over | 13:50 |
opendevreview | Hervé Beraud proposed openstack/oslo-specs master: oslo.service: Propose a plan to Remove Eventlet https://review.opendev.org/c/openstack/oslo-specs/+/927503 | 14:03 |
frickler | stephenfin: done, except for one patch I have no idea about. also I'm no oslo core, so +1s only | 14:28 |
stephenfin | ack. ty! | 14:29 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: pre-commit: Bump dependencies https://review.opendev.org/c/openstack/openstackdocstheme/+/927482 | 14:30 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: pre-commit: Add ruff, ruff-format https://review.opendev.org/c/openstack/openstackdocstheme/+/927483 | 14:30 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: setup: Update Python classifiers https://review.opendev.org/c/openstack/openstackdocstheme/+/927484 | 14:30 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: Make Sphinx a required dependency https://review.opendev.org/c/openstack/openstackdocstheme/+/927485 | 14:31 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: Resolve Sphinx 8.x warnings https://review.opendev.org/c/openstack/openstackdocstheme/+/927486 | 14:31 |
opendevreview | Stephen Finucane proposed openstack/openstackdocstheme master: Bump minimum Sphinx version https://review.opendev.org/c/openstack/openstackdocstheme/+/927487 | 14:31 |
stephenfin | frickler: addressed comments on the top 1. If you want to check you're happy, I'll take your +1s as +2 and shove them through | 14:31 |
stephenfin | *first one | 14:32 |
frickler | stephenfin: that still doesn't address the "hash vs. tag" policy, though I must admit that's a weird one, assuming people would malicously move tags | 14:34 |
stephenfin | Yeah, I find that odd also. We never did that in SDK land and have stopped doing it in various oslo projects | 14:35 |
frickler | seems that was added by hberaud in https://review.opendev.org/c/openstack/openstackdocstheme/+/742158 , so I'd really like to see feedback from him on this | 14:35 |
stephenfin | iirc it was dtantsur that looked for it the first day, but I don't think he works on oslo-stuff any more so...YOLO | 14:36 |
stephenfin | ? | 14:36 |
stephenfin | ack, just fyi though I'm travelling to Seoul for summit early tomorrow so I'd like to close this out today. Hopefully hberaud can weigh in today. That or we push it through and revert later if needed | 14:37 |
dtantsur | What did I do? :) I haven't really worked on oslo. | 14:37 |
frickler | well if you ask me, I'd rather put the pre-commit changes last. the remainder I can all +1 | 14:37 |
stephenfin | dtantsur: We're referring to me not using commit IDs but rather tags in pre-commit files here https://review.opendev.org/c/openstack/openstackdocstheme/+/927482/2/.pre-commit-config.yaml | 14:39 |
dtantsur | Ah, okay. I don't remember much about it any more. | 14:40 |
stephenfin | ack | 14:41 |
opendevreview | Merged openstack/openstackdocstheme master: pre-commit: Bump dependencies https://review.opendev.org/c/openstack/openstackdocstheme/+/927482 | 15:43 |
opendevreview | Merged openstack/openstackdocstheme master: pre-commit: Add ruff, ruff-format https://review.opendev.org/c/openstack/openstackdocstheme/+/927483 | 15:45 |
opendevreview | Merged openstack/openstackdocstheme master: setup: Update Python classifiers https://review.opendev.org/c/openstack/openstackdocstheme/+/927484 | 15:46 |
opendevreview | Merged openstack/openstackdocstheme master: Make Sphinx a required dependency https://review.opendev.org/c/openstack/openstackdocstheme/+/927485 | 15:46 |
opendevreview | Merged openstack/openstackdocstheme master: Resolve Sphinx 8.x warnings https://review.opendev.org/c/openstack/openstackdocstheme/+/927486 | 15:48 |
opendevreview | Merged openstack/openstackdocstheme master: Bump minimum Sphinx version https://review.opendev.org/c/openstack/openstackdocstheme/+/927487 | 15:48 |
opendevreview | Cyril Roelandt proposed openstack/oslo.privsep master: Python 3.13: do not use removed module "pipes" https://review.opendev.org/c/openstack/oslo.privsep/+/927538 | 19:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!