opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Remove deprecated AMQP1 driver https://review.opendev.org/c/openstack/oslo.messaging/+/934116 | 09:40 |
---|---|---|
opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Remove deprecated AMQP1 driver https://review.opendev.org/c/openstack/oslo.messaging/+/934116 | 09:50 |
opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Remove deprecated AMQP1 driver https://review.opendev.org/c/openstack/oslo.messaging/+/934116 | 10:02 |
opendevreview | Takashi Kajinami proposed openstack/oslo.utils master: Add utility to replace crypt.crypt https://review.opendev.org/c/openstack/oslo.utils/+/931899 | 10:08 |
opendevreview | Merged openstack/os-api-ref master: Mark sphinx extensions thread safe https://review.opendev.org/c/openstack/os-api-ref/+/934151 | 10:30 |
opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Remove deprecated AMQP1 driver https://review.opendev.org/c/openstack/oslo.messaging/+/934116 | 10:52 |
opendevreview | Merged openstack/oslo.utils master: is_valid_ipv4: Enable strict check by default https://review.opendev.org/c/openstack/oslo.utils/+/903924 | 10:55 |
opendevreview | Daniel Bengtsson proposed openstack/oslo.messaging master: Remove deprecated AMQP1 driver https://review.opendev.org/c/openstack/oslo.messaging/+/934116 | 10:56 |
opendevreview | Merged openstack/tooz master: Remove Windows support https://review.opendev.org/c/openstack/tooz/+/932632 | 12:22 |
opendevreview | Hervé Beraud proposed openstack/oslo-specs master: oslo.service: Propose a plan to Remove Eventlet https://review.opendev.org/c/openstack/oslo-specs/+/927503 | 14:05 |
opendevreview | Hervé Beraud proposed openstack/oslo-specs master: oslo.service: Propose a plan to Remove Eventlet https://review.opendev.org/c/openstack/oslo-specs/+/927503 | 15:23 |
dtantsur | Hi folks. I got disconnected when Jay mentioned https://bugs.launchpad.net/oslo.utils/+bug/2086810 so I wonder if there have been any discussion | 16:06 |
dtantsur | We can work around this in Ironic but I wonder if there are other places where kernels may end up going through the format inspector | 16:07 |
dtantsur | dansmith: if you have a minute ^^ | 16:23 |
dansmith | on a call, but will circle back | 16:23 |
dtantsur | thx! | 16:23 |
frickler | dtantsur: fyi there was no reply to JayF's question earlier, you can also look at the logs at https://meetings.opendev.org/irclogs/%23openstack-oslo/ if needed | 16:32 |
dtantsur | how could I forget about logs.. thanks! | 16:32 |
dansmith | dtantsur: still on that call, but.. the reason it's being detected as GPT is because it *is* a GPT (mbr).. the x86 "bootable" self-uncompressing images have a boot record, partition table, and executable code at the front | 17:01 |
dtantsur | dansmith: yeah, TheJulia already brought me these shocking news :) Then I guess the validator should not fail on them? | 17:02 |
dansmith | dtantsur: so on the one hand, it would be best to be storing these in a "raw" and treating them as such, never running any qemu commands on them and thus not needing to do a safety check on them | 17:02 |
dansmith | on the other, the thing failing is because they don't have one of the partitions marked as bootable, which is just a sort of sanity check I added because it *should* be set right, but we could remove that check | 17:03 |
dansmith | but it'll mean you detect it as a gpt (which it is) | 17:03 |
dansmith | my goal with this stuff is to get people to stop treating things that aren't disk images as disk images, and vice versa | 17:03 |
dtantsur | it's a fair call, too | 17:04 |
dansmith | I want nova to basically only allow kernel/ramdisk to be in 'raw' and not allow disk images to be in 'raw' | 17:05 |
dansmith | so we'll use qemu tools on gpt,qcow2, etc, and allow those to be hooked up as disks, | 17:05 |
dansmith | but things that are not disk images are just payload data, stored in raw, and not allowed to be "booted" | 17:06 |
dansmith | also, the oslo one can expose *which* checks failed, so if you can't distinguish between real GPT disk images and kernels, you could potentially use that failure to indicate "okay, we'll ignore this check failure but we won't let you treat this like a bootable image as a result" | 17:08 |
dtantsur | Got it, thanks! | 17:17 |
JayF | I'll note https://review.opendev.org/c/openstack/oslo.utils/+/930379 is still pending review and might be helpful for some cases | 18:20 |
opendevreview | sean mooney proposed openstack/openstackdocstheme master: fix support for py39 https://review.opendev.org/c/openstack/openstackdocstheme/+/934384 | 21:48 |
*** haleyb is now known as haleyb|out | 22:44 | |
*** tosky_ is now known as tosky | 23:40 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!