| *** mhen_ is now known as mhen | 02:33 | |
| *** elodilles_pto is now known as elodilles | 08:34 | |
| opendevreview | Merged openstack/pbr master: Fix integration testing of current change https://review.opendev.org/c/openstack/pbr/+/938076 | 13:44 |
|---|---|---|
| *** sfinucan is now known as stephenfin | 14:06 | |
| opendevreview | Merged openstack/pbr master: Remove the use of six from PBR https://review.opendev.org/c/openstack/pbr/+/938413 | 15:56 |
| opendevreview | Merged openstack/pbr master: Test pip and setup.py install behavior in PBR testing https://review.opendev.org/c/openstack/pbr/+/938410 | 15:56 |
| opendevreview | Merged openstack/pbr master: Use pyproject.toml https://review.opendev.org/c/openstack/pbr/+/938331 | 15:56 |
| clarkb | thinking about ^ I wonder if there is a good way to do a beta release and have people check it work in their environments. We're already trying to approximate that in testing though so it may not be necesasry | 15:58 |
| clarkb | fungi: ^ you may have additional thoughts on that | 15:58 |
| opendevreview | Merged openstack/pbr master: Set up PBR with setuptools as a dependency https://review.opendev.org/c/openstack/pbr/+/938332 | 16:00 |
| fungi | i don't know of an easy way except maybe with a beta version spec in pyproject.toml for projects using one | 16:00 |
| fungi | switching a project to pyproject.toml based builds would also potentially introduce separate issues which would need untangling | 16:01 |
| clarkb | fungi: you do have projects using pyproject.toml and pbr already though right? Maybe it is worth a beta release and you could check things in those projects? | 16:04 |
| fungi | we could switch something like bindep over to using pyproject.toml first (you have a start in https://review.opendev.org/816741 ), then tag a pbr 6.2.0.0b1 and in build-system.requires specify pbr>=6.2.0.0b1 | 16:04 |
| fungi | actually, if my recheck on that comes back green, we can stack a wip change on it to require the beta i guess? | 16:07 |
| clarkb | fungi: I like that idea. Did you want to push up the wip stack? I guess we also need someone to request a release of pbr? | 16:16 |
| fungi | i can push up the pbr release request, yep | 16:16 |
| fungi | did we want to include any release notes in pbr first? | 16:17 |
| fungi | geussing not since we don't expect these recent changes to be user-facing differences | 16:17 |
| fungi | https://paste.opendev.org/show/bB7Tda0LFB2R8bmqGoHV/ is the 6 changes to merge since 6.1.0 | 16:18 |
| clarkb | the vast majority are testing only updates. The main thing would be the addition of pyproject.toml use by pbr itself | 16:19 |
| clarkb | I could go either way. We could note it just so that if there are unexpected problems people have a hint at where to start looking? | 16:19 |
| fungi | which, again, shouldn't be user-facing since it's only a build-time behavior change for pbr itself | 16:19 |
| clarkb | yup | 16:19 |
| fungi | users don't interact with pbr's own pyproject.toml, they get a prebuilt wheel | 16:19 |
| clarkb | I think we would only do it to leave a breadcrumb for unexpected debug needs | 16:19 |
| clarkb | oh thats a good point | 16:19 |
| clarkb | you only deal with the pyproject.toml when making an sdist or wheel right? | 16:20 |
| fungi | yes, really only when making an sdist | 16:20 |
| clarkb | in the case of installing via sdist you would then use it to make a wheel locally potentioally but the vast majority of users are likely to fetch the wheel directly | 16:20 |
| clarkb | then ya this seems less important | 16:20 |
| fungi | or when "installing" from a source tree/git checkout of pbr | 16:21 |
| fungi | pretty sure the wheel/build tools use the sdist metadata when creating a wheel, so pyproject.toml doesn't come into play | 16:21 |
| clarkb | ya I would guess that 99% of installs happen via pypi and fetch the wheel | 16:22 |
| fungi | since pbr's wheels are universal pure python, there is basically never a reason not to use the wheel except if you're testing building pbr | 16:23 |
| fungi | or packaging it for distros | 16:23 |
| fungi | by that logic, 6.1.1.0b1 might be more appropriate even | 16:24 |
| fungi | the last change adding setuptools as an explicit dep is the only one that really straddles the line between patch and minor (because it was implicitly a dep anyway before that) | 16:25 |
| fungi | https://review.opendev.org/c/openstack/releases/+/938505 Release PBR 6.1.1.0b1 | 16:48 |
| fungi | ERROR: could not validate version '6.1.1.0b1': Version 6.1.1.0b1 looks like a pre-release and the release model does not allow for it | 17:26 |
| clarkb | that seems like an overzealous check from the release team? | 17:26 |
| clarkb | seems weird to sya youcan never make a beta release | 17:27 |
| fungi | yes, i wonder what the reason is, since it's in the independent list | 17:27 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!