| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Introduce backend system in oslo.service https://review.opendev.org/c/openstack/oslo.service/+/935783 | 13:16 |
|---|---|---|
| damani[m] | hberaud, tkajinam, i have add a new unit test and a comment, i think now we are safe to merge | 13:19 |
| tkajinam | hmmm | 13:22 |
| tkajinam | damani[m], I've left a comment in the change, but I don't think the current unit tests describe the scenario I pointed. | 13:27 |
| tkajinam | damani[m], The problem is that conf is not updated according to config files until CONF.__call__ is called, and get_backend is called during import | 13:28 |
| tkajinam | when get_backend is called , CONF.__call__ is not yet called because import is processed before any function call, and at that timing CONF singleton has no values loaded from config files yet | 13:30 |
| tkajinam | I mean that the execution_backend option isn't really configurable set via config option in the current implementation which calls get_backend in module level. | 13:35 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Introduce backend system in oslo.service https://review.opendev.org/c/openstack/oslo.service/+/935783 | 13:40 |
| damani[m] | i have added a new test | 13:41 |
| damani[m] | so what is the best solution use environment variable? | 14:34 |
| damani[m] | instead the configuration? | 14:35 |
| damani[m] | tkajinam, zzzeek, are you around? | 14:48 |
| opendevreview | Hervé Beraud proposed openstack/futurist master: deprecate eventlet https://review.opendev.org/c/openstack/futurist/+/939361 | 15:37 |
| opendevreview | Daniel Bengtsson proposed openstack/oslo.service master: Introduce backend system in oslo.service https://review.opendev.org/c/openstack/oslo.service/+/935783 | 16:11 |
| -opendevstatus- NOTICE: The paste service at paste.opendev.org will have a short (15-20) minute outage momentarily to replace the underlying server. | 17:08 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!